On Mon, 21 Sep 2020 22:32:41 +0530 sundeep.l...@gmail.com wrote: > diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_trace.c > b/drivers/net/ethernet/marvell/octeontx2/af/rvu_trace.c > new file mode 100644 > index 0000000..f0b3f17 > --- /dev/null > +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_trace.c > @@ -0,0 +1,14 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* Marvell OcteonTx2 RVU Admin Function driver tracepoints > + * > + * Copyright (C) 2020 Marvell International Ltd. > + */ > + > +#define CREATE_TRACE_POINTS > +#include "rvu_trace.h" > + > +EXPORT_TRACEPOINT_SYMBOL(otx2_msg_alloc); > +EXPORT_TRACEPOINT_SYMBOL(otx2_msg_send); > +EXPORT_TRACEPOINT_SYMBOL(otx2_msg_check);
I don't think you need to export send and check. They are only used in the mbox module where they are defined. Otherwise looks acceptable to me. Please make sure you CC everyone who gave you feedback.
