Re: [DRAFT PATCH] random32: make prandom_u32() output unpredictable

2020-08-19 Thread Willy Tarreau
On Thu, Aug 20, 2020 at 08:08:43AM +0200, Willy Tarreau wrote: > On Thu, Aug 20, 2020 at 06:42:23AM +0200, Sedat Dilek wrote: > > On Thu, Aug 20, 2020 at 6:33 AM Willy Tarreau wrote: > > > > > > On Thu, Aug 20, 2020 at 05:05:49AM +0200, Sedat Dilek wrote: > > > > We have the same defines for K0 an

[PATCH] net: phy: mscc: Fix a couple of spelling mistakes "spcified" -> "specified"

2020-08-19 Thread Kaige Li
There are a couple of spelling mistakes in comment text. Fix these. Signed-off-by: Kaige Li --- drivers/net/phy/mscc/mscc_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/mscc/mscc_main.c b/drivers/net/phy/mscc/mscc_main.c index a4fbf3a..6bc7406 1006

[PATCH net] sctp: not disable bh in the whole sctp_get_port_local()

2020-08-19 Thread Xin Long
With disabling bh in the whole sctp_get_port_local(), when snum == 0 and too many ports have been used, the do-while loop will take the cpu for a long time and cause cpu stuck: [ ] watchdog: BUG: soft lockup - CPU#11 stuck for 22s! [ ] RIP: 0010:native_queued_spin_lock_slowpath+0x4de/0x940 [

Re: [PATCH 00/49] DRM driver for Hikey 970

2020-08-19 Thread Mauro Carvalho Chehab
Em Wed, 19 Aug 2020 23:25:51 +0200 Sam Ravnborg escreveu: > Hi John. > > > > So, IMO, the best is to keep it on staging for a while, until those > > > remaining bugs gets solved. > > > > I'm not sure I see all of these as compelling for pushing it in via > > staging. And I suspect in the proc

Re: [PATCH v2] dt-bindings: net: renesas,ether: Improve schema validation

2020-08-19 Thread Geert Uytterhoeven
Hi David, On Wed, Aug 19, 2020 at 10:05 PM David Miller wrote: > From: Geert Uytterhoeven > Date: Wed, 19 Aug 2020 14:45:39 +0200 > > > - Remove pinctrl consumer properties, as they are handled by core > > dt-schema, > > - Document missing properties, > > - Document missing PHY child n

Re: [RFC PATCH bpf-next 3/4] bpf: add bpf_trace_btf helper

2020-08-19 Thread Andrii Nakryiko
On Thu, Aug 6, 2020 at 1:24 PM Alan Maguire wrote: > > A helper is added to support tracing kernel type information in BPF > using the BPF Type Format (BTF). Its signature is > > long bpf_trace_btf(struct btf_ptr *ptr, u32 btf_ptr_size, u32 trace_id, >u64 flags); > > struct bt

Re: [PATCH 00/49] DRM driver for Hikey 970

2020-08-19 Thread Mauro Carvalho Chehab
Em Wed, 19 Aug 2020 14:13:05 -0700 John Stultz escreveu: > On Wed, Aug 19, 2020 at 4:46 AM Mauro Carvalho Chehab > wrote: > > Yet, I'm submitting it via staging due to the following reasons: > > > > - It depends on the LDO3 power supply, which is provided by > > a regulator driver that it is c

[PATCH bpf-next 3/4] selftests/bpf: fix two minor compilation warnings reported by GCC 4.9

2020-08-19 Thread Andrii Nakryiko
GCC 4.9 seems to be more strict in some regards. Fix two minor issue it reported. Fixes: 1c1052e0140a ("tools/testing/selftests/bpf: Add self-tests for new helper bpf_get_ns_current_pid_tgid.") Fixes: 2d7824ffd25c ("selftests: bpf: Add test for sk_assign") Signed-off-by: Andrii Nakryiko --- too

[PATCH bpf-next 1/4] libbpf: fix detection of BPF helper call instruction

2020-08-19 Thread Andrii Nakryiko
BPF_CALL | BPF_JMP32 is explicitly not allowed by verifier for BPF helper calls, so don't detect it as a valid call. Also drop the check on func_id pointer, as it's currently always non-null. Reported-by: Yonghong Song Fixes: 109cea5a594f ("libbpf: Sanitize BPF program code for bpf_probe_read_{k

[PATCH bpf-next 2/4] libbpf: fix libbpf build on compilers missing __builtin_mul_overflow

2020-08-19 Thread Andrii Nakryiko
GCC compilers older than version 5 don't support __builtin_mul_overflow yet. Given GCC 4.9 is the minimal supported compiler for building kernel and the fact that libbpf is a dependency of resolve_btfids, which is dependency of CONFIG_DEBUG_INFO_BTF=y, this needs to be handled. This patch fixes the

[PATCH bpf-next 4/4] selftests/bpf: list newest Clang built-ins needed for some CO-RE selftests

2020-08-19 Thread Andrii Nakryiko
Record which built-ins are optional and needed for some of recent BPF CO-RE subtests. Document Clang diff that fixed corner-case issue with __builtin_btf_type_id(). Suggested-by: Alexei Starovoitov Signed-off-by: Andrii Nakryiko --- tools/testing/selftests/bpf/README.rst| 21 +++

Re: [DRAFT PATCH] random32: make prandom_u32() output unpredictable

2020-08-19 Thread Willy Tarreau
On Thu, Aug 20, 2020 at 06:42:23AM +0200, Sedat Dilek wrote: > On Thu, Aug 20, 2020 at 6:33 AM Willy Tarreau wrote: > > > > On Thu, Aug 20, 2020 at 05:05:49AM +0200, Sedat Dilek wrote: > > > We have the same defines for K0 and K1 in include/linux/prandom.h and > > > lib/random32.c? > > > More room

Re: BUG: corrupted list in kobject_add_internal

2020-08-19 Thread Coiby Xu
On Fri, Aug 07, 2020 at 09:47:20AM -0700, syzbot wrote: Hello, syzbot found the following issue on: HEAD commit:5a30a789 Merge tag 'x86-urgent-2020-08-02' of git://git.ke.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1660c85890 kernel config: http

[RESEND PATCH] net: dsa: microchip: look for phy-mode in port nodes

2020-08-19 Thread Helmut Grohne
Documentation/devicetree/bindings/net/dsa/dsa.txt says that the phy-mode property should be specified on port nodes. However, the microchip drivers read it from the switch node. Let the driver use the per-port property and fall back to the old location with a warning. Fix in-tree users. Signed-o

[PATCH] [v2] wilc1000: Fix memleak in wilc_bus_probe

2020-08-19 Thread Dinghao Liu
When devm_clk_get() returns -EPROBE_DEFER, spi_priv should be freed just like when wilc_cfg80211_init() fails. Fixes: 854d66df74aed ("staging: wilc1000: look for rtc_clk clock in spi mode") Signed-off-by: Dinghao Liu --- Changelog: v2: - Remove 'staging' prefix in subject. --- drivers/net/wire

[PATCH 1/1 v5] igb: add XDP support

2020-08-19 Thread Sven Auhagen
Add XDP support to the IGB driver. The implementation follows the IXGBE XDP implementation closely and I used the following patches as basis: 1. commit 924708081629 ("ixgbe: add XDP support for pass and drop actions") 2. commit 33fdc82f0883 ("ixgbe: add support for XDP_TX action") 3. commit ed93a3

[PATCH] [v2] wilc1000: Fix memleak in wilc_sdio_probe

2020-08-19 Thread Dinghao Liu
When devm_clk_get() returns -EPROBE_DEFER, sdio_priv should be freed just like when wilc_cfg80211_init() fails. Fixes: 8692b047e86cf ("staging: wilc1000: look for rtc_clk clock") Signed-off-by: Dinghao Liu --- Changelog: v2: - Remove 'staging' prefix in subject. --- drivers/net/wireless/microc

Re: Re: [PATCH] staging: wilc1000: Fix memleak in wilc_sdio_probe

2020-08-19 Thread dinghao . liu
ajay.kat...@microchip.com写道: > Thanks for submitting the patch. The code changes looks okay to me. > > The driver is now moved out of staging so 'staging' prefix is not > required in subject. For future patches on wilc driver, the 'staging' > prefix can be removed. > > For this patch, I am not

INFO: task can't die in netdev_run_todo

2020-08-19 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:4993e4fe Add linux-next specific files for 20200814 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=1181e1a690 kernel config: https://syzkaller.appspot.com/x/.config?x=2055bd0d83d5ee16 dashboard

[PATCH bpf] bpf: xdp: fix XDP mode when no mode flags specified

2020-08-19 Thread Andrii Nakryiko
7f0a838254bd ("bpf, xdp: Maintain info on attached XDP BPF programs in net_device") inadvertently changed which XDP mode is assumed when no mode flags are specified explicitly. Previously, driver mode was preferred, if driver supported it. If not, generic SKB mode was chosen. That commit changed d

Re: [PATCH 05/28] media/v4l2: remove V4L2-FLAG-MEMORY-NON-CONSISTENT

2020-08-19 Thread Christoph Hellwig
On Thu, Aug 20, 2020 at 06:43:47AM +0200, Christoph Hellwig wrote: > On Wed, Aug 19, 2020 at 03:57:53PM +0200, Tomasz Figa wrote: > > > > Could you explain what makes you think it's unused? It's a feature of > > > > the UAPI generally supported by the videobuf2 framework and relied on > > > > by Ch

Re: [PATCH 19/28] dma-mapping: replace DMA_ATTR_NON_CONSISTENT with dma_{alloc, free}_pages

2020-08-19 Thread Christoph Hellwig
On Wed, Aug 19, 2020 at 05:03:52PM +0200, Tomasz Figa wrote: > > > > -Warning: These pieces of the DMA API should not be used in the > > -majority of cases, since they cater for unlikely corner cases that > > -don't belong in usual drivers. > > +These APIs allow to allocate pages that can be used l

Re: [PATCH 05/28] media/v4l2: remove V4L2-FLAG-MEMORY-NON-CONSISTENT

2020-08-19 Thread Christoph Hellwig
On Wed, Aug 19, 2020 at 03:07:04PM +0100, Robin Murphy wrote: >> FWIW, I asked back in time what the plan is for non-coherent >> allocations and it seemed like DMA_ATTR_NON_CONSISTENT and >> dma_sync_*() was supposed to be the right thing to go with. [2] The >> same thread also explains why dma_all

Re: [PATCH 05/28] media/v4l2: remove V4L2-FLAG-MEMORY-NON-CONSISTENT

2020-08-19 Thread Christoph Hellwig
On Wed, Aug 19, 2020 at 04:22:29PM +0200, Tomasz Figa wrote: > > > FWIW, I asked back in time what the plan is for non-coherent > > > allocations and it seemed like DMA_ATTR_NON_CONSISTENT and > > > dma_sync_*() was supposed to be the right thing to go with. [2] The > > > same thread also explains

Re: [PATCH 05/28] media/v4l2: remove V4L2-FLAG-MEMORY-NON-CONSISTENT

2020-08-19 Thread Christoph Hellwig
On Wed, Aug 19, 2020 at 04:11:52PM +0200, Tomasz Figa wrote: > > > By the way, as a videobuf2 reviewer, I'd appreciate being CC'd on any > > > series related to the subsystem-facing DMA API changes, since > > > videobuf2 is one of the biggest users of it. > > > > The cc list is too long - I cc list

Re: [PATCH 05/28] media/v4l2: remove V4L2-FLAG-MEMORY-NON-CONSISTENT

2020-08-19 Thread Christoph Hellwig
On Wed, Aug 19, 2020 at 03:57:53PM +0200, Tomasz Figa wrote: > > > Could you explain what makes you think it's unused? It's a feature of > > > the UAPI generally supported by the videobuf2 framework and relied on > > > by Chromium OS to get any kind of reasonable performance when > > > accessing V4

Re: [DRAFT PATCH] random32: make prandom_u32() output unpredictable

2020-08-19 Thread Sedat Dilek
On Thu, Aug 20, 2020 at 6:33 AM Willy Tarreau wrote: > > On Thu, Aug 20, 2020 at 05:05:49AM +0200, Sedat Dilek wrote: > > We have the same defines for K0 and K1 in include/linux/prandom.h and > > lib/random32.c? > > More room for simplifications? > > Definitely, I'm not surprized at all. As I said

Re: [PATCH] net: bypass ->sendpage for slab pages

2020-08-19 Thread Christoph Hellwig
On Wed, Aug 19, 2020 at 12:07:09PM -0700, David Miller wrote: > Yes this fixes the problem, but it doesn't in any way deal with the > callers who are doing this stuff. > > They are all likely using sendpage because they expect that it will > avoid the copy, for performance reasons or whatever. >

Re: [DRAFT PATCH] random32: make prandom_u32() output unpredictable

2020-08-19 Thread Willy Tarreau
On Thu, Aug 20, 2020 at 05:05:49AM +0200, Sedat Dilek wrote: > We have the same defines for K0 and K1 in include/linux/prandom.h and > lib/random32.c? > More room for simplifications? Definitely, I'm not surprized at all. As I said, the purpose was to discuss around the proposal, not much more. If

Re: [PATCH 00/49] DRM driver for Hikey 970

2020-08-19 Thread John Stultz
On Wed, Aug 19, 2020 at 7:01 PM John Stultz wrote: > > On Wed, Aug 19, 2020 at 2:36 PM John Stultz wrote: > > > > On Wed, Aug 19, 2020 at 4:46 AM Mauro Carvalho Chehab > > wrote: > > > So, IMO, the best is to keep it on staging for a while, until those > > > remaining bugs gets solved. > > > > >

Re: [PATCH bpf-next] tools/resolve_btfids: Fix sections with wrong alignment

2020-08-19 Thread Yonghong Song
On 8/19/20 7:27 PM, Fāng-ruì Sòng wrote: section(36) .comment, size 44, link 0, flags 30, type=1 section(37) .debug_aranges, size 45684, link 0, flags 800, type=1 - fixing wrong alignment sh_addralign 16, expected 8 section(38) .debug_info, size 129104957, link 0, flags 800, t

Re: [DRAFT PATCH] random32: make prandom_u32() output unpredictable

2020-08-19 Thread Sedat Dilek
On Sun, Aug 16, 2020 at 6:48 PM Sedat Dilek wrote: > > On Sun, Aug 16, 2020 at 5:01 PM Willy Tarreau wrote: > > > > Hi, > > > > so as I mentioned, I could run several test on our lab with variations > > around the various proposals and come to quite positive conclusions. > > > > Synthetic observa

Re: [PATCH v2] net: stmmac: Fix signedness bug in stmmac_probe_config_dt()

2020-08-19 Thread Yuehaibing
On 2020/8/19 1:04, Andrew Lunn wrote: > On Tue, Aug 18, 2020 at 11:15:00PM +0800, YueHaibing wrote: >> The "plat->phy_interface" variable is an enum and in this context GCC >> will treat it as an unsigned int so the error handling is never >> triggered. >> >> Fixes: b9f0b2f634c0 ("net: stmmac: plat

Re: [PATCH 00/49] DRM driver for Hikey 970

2020-08-19 Thread John Stultz
On Wed, Aug 19, 2020 at 2:36 PM John Stultz wrote: > > On Wed, Aug 19, 2020 at 4:46 AM Mauro Carvalho Chehab > wrote: > > So, IMO, the best is to keep it on staging for a while, until those > > remaining bugs gets solved. > > > > I added this series, together with the regulator driver and > > a f

Re: [PATCH net-next v1 2/3] net: openvswitch: refactor flow free function

2020-08-19 Thread David Miller
From: Tonghao Zhang Date: Thu, 20 Aug 2020 07:21:33 +0800 > On Thu, Aug 20, 2020 at 6:52 AM David Miller wrote: > >> From: xiangxia.m@gmail.com >> >> Date: Tue, 18 Aug 2020 18:09:22 +0800 >> >> >> >> > Decrease table->count and ufid_count unconditionally, >> >> >> >> You don't explain why t

Re: [net-next v3 1/4] devlink: check flash_update parameter support in net core

2020-08-19 Thread Jacob Keller
On 8/19/2020 4:36 PM, David Miller wrote: > From: Jacob Keller > Date: Tue, 18 Aug 2020 17:28:15 -0700 > >> @@ -991,6 +993,12 @@ enum devlink_trap_group_generic_id { >> } >> >> struct devlink_ops { >> +/** >> + * @supported_flash_update_params: >> + * mask of parameters sup

[PATCH bpf-next 1/3] bpf: implement link_query for bpf iterators

2020-08-19 Thread Yonghong Song
This patch implemented bpf_link callback functions show_fdinfo and fill_link_info to support link_query interface. The general interface for show_fdinfo and fill_link_info will print/fill the target_name. Each targets can register show_fdinfo and fill_link_info callbacks to print/fill more target

[PATCH bpf-next 0/3] bpf: implement link_query for bpf iterators

2020-08-19 Thread Yonghong Song
"link" has been an important concept for bpf ecosystem to connect bpf program with other properties. Currently, the information related information can be queried from userspace through bpf command BPF_LINK_GET_NEXT_ID, BPF_LINK_GET_FD_BY_ID and BPF_OBJ_GET_INFO_BY_FD. The information is also avail

[PATCH bpf-next 2/3] bpf: implement link_query callbacks in map element iterators

2020-08-19 Thread Yonghong Song
For bpf_map_elem and bpf_sk_local_storage bpf iterators, additional map_id should be shown for fdinfo and userspace query. For example, the following is for a bpf_map_elem iterator. $ cat /proc/1753/fdinfo/9 pos:0 flags: 0200 mnt_id: 14 link_type: iter link_id:34

[PATCH bpf-next 3/3] bpftool: implement link_query for bpf iterators

2020-08-19 Thread Yonghong Song
The link query for bpf iterators is implemented. Besides being shown to the user what bpf iterator the link represents, the target_name is also used to filter out what additional information should be printed out, e.g., whether map_id should be shown or not. The following is an example of bpf_iter

[PATCH AUTOSEL 5.8 12/27] svcrdma: Fix another Receive buffer leak

2020-08-19 Thread Sasha Levin
From: Chuck Lever [ Upstream commit 64d26422516b2e347b32e6d9b1d40b3c19a62aae ] During a connection tear down, the Receive queue is flushed before the device resources are freed. Typically, all the Receives flush with IB_WR_FLUSH_ERR. However, any pending successful Receives flush with IB_WR_SUC

[PATCH AUTOSEL 5.7 10/24] svcrdma: Fix another Receive buffer leak

2020-08-19 Thread Sasha Levin
From: Chuck Lever [ Upstream commit 64d26422516b2e347b32e6d9b1d40b3c19a62aae ] During a connection tear down, the Receive queue is flushed before the device resources are freed. Typically, all the Receives flush with IB_WR_FLUSH_ERR. However, any pending successful Receives flush with IB_WR_SUC

[PATCH AUTOSEL 4.19 08/18] svcrdma: Fix another Receive buffer leak

2020-08-19 Thread Sasha Levin
From: Chuck Lever [ Upstream commit 64d26422516b2e347b32e6d9b1d40b3c19a62aae ] During a connection tear down, the Receive queue is flushed before the device resources are freed. Typically, all the Receives flush with IB_WR_FLUSH_ERR. However, any pending successful Receives flush with IB_WR_SUC

[PATCH AUTOSEL 5.4 09/22] svcrdma: Fix another Receive buffer leak

2020-08-19 Thread Sasha Levin
From: Chuck Lever [ Upstream commit 64d26422516b2e347b32e6d9b1d40b3c19a62aae ] During a connection tear down, the Receive queue is flushed before the device resources are freed. Typically, all the Receives flush with IB_WR_FLUSH_ERR. However, any pending successful Receives flush with IB_WR_SUC

Re: [PATCH net-next v2 5/7] net: dsa: mt7530: Add the support of MT7531 switch

2020-08-19 Thread René van Dorst
Quoting Landen Chao : On Wed, 2020-08-19 at 00:09 +0800, Andrew Lunn wrote: On Tue, Aug 18, 2020 at 03:14:10PM +0800, Landen Chao wrote: > Add new support for MT7531: > > MT7531 is the next generation of MT7530. It is also a 7-ports switch with > 5 giga embedded phys, 2 cpu ports, and the same

Re: [PATCH net v2] net: gemini: Fix missing free_netdev() in error path of gemini_ethernet_port_probe()

2020-08-19 Thread David Miller
From: Wang Hai Date: Wed, 19 Aug 2020 10:33:09 +0800 > Replace alloc_etherdev_mq with devm_alloc_etherdev_mqs. In this way, > when probe fails, netdev can be freed automatically. > > Fixes: 4d5ae32f5e1e ("net: ethernet: Add a driver for Gemini gigabit > ethernet") > Reported-by: Hulk Robot > S

Re: [net-next v3 1/4] devlink: check flash_update parameter support in net core

2020-08-19 Thread David Miller
From: Jacob Keller Date: Tue, 18 Aug 2020 17:28:15 -0700 > @@ -991,6 +993,12 @@ enum devlink_trap_group_generic_id { > } > > struct devlink_ops { > + /** > + * @supported_flash_update_params: > + * mask of parameters supported by the driver's .flash_update > + * implem

Re: [PATCH net-next] ethtool: allow flow-type ether without IP protocol field

2020-08-19 Thread David Miller
From: Vishal Kulkarni Date: Wed, 19 Aug 2020 00:25:03 +0530 > Set IP protocol mask only when IP protocol field is set. > This will allow flow-type ether with vlan rule which don't have > protocol field to apply. > > ethtool -N ens5f4 flow-type ether proto 0x8100 vlan 0x600\ > m 0x1FFF action 3 l

Re: [PATCH NET] net: atlantic: Use readx_poll_timeout() for large timeout

2020-08-19 Thread David Miller
From: Sebastian Andrzej Siewior Date: Tue, 18 Aug 2020 18:14:39 +0200 > Commit >8dcf2ad39fdb2 ("net: atlantic: add hwmon getter for MAC temperature") > > implemented a read callback with an udelay(1U). This fails to > compile on ARM because the delay is >1ms. I doubt that it is needed to

Re: [PATCH v2 net] ptp: ptp_clockmatrix: use i2c_master_send for i2c write

2020-08-19 Thread David Miller
From: Date: Tue, 18 Aug 2020 10:41:22 -0400 > From: Min Li > > The old code for i2c write would break on some controllers, which fails > at handling Repeated Start Condition. So we will just use i2c_master_send > to handle write in one transanction. > > Changes since v1: > - Remove indentation

Re: [PATCH net v6] net: xdp: account for layer 3 packets in generic skb handler

2020-08-19 Thread David Miller
From: "Jason A. Donenfeld" Date: Sat, 15 Aug 2020 09:41:02 +0200 > A user reported that packets from wireguard were possibly ignored by XDP > [1]. Another user reported that modifying packets from layer 3 > interfaces results in impossible to diagnose drops. Jason this really is a minefield. If

Re: [PATCH v4 0/9] ptp: Add generic helper functions

2020-08-19 Thread David Miller
From: Kurt Kanzenbach Date: Tue, 18 Aug 2020 12:32:42 +0200 > in order to reduce code duplication (and cut'n'paste errors) in the ptp code > of > DSA, Ethernet and Phy drivers, create helper functions and move them to > ptp_classify. This way all drivers can share the same implementation. ...

[PATCH net-next v2 3/4] ibmvnic: remove never executed if statement

2020-08-19 Thread Lijun Pan
At the beginning of the function, from_passive_init is set false by "adapter->from_passive_init = false;", hence the if statement will never run. Signed-off-by: Lijun Pan --- drivers/net/ethernet/ibm/ibmvnic.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/net/ethernet/

[PATCH net-next v2 1/4] ibmvnic: compare adapter->init_done_rc with more readable ibmvnic_rc_codes

2020-08-19 Thread Lijun Pan
Instead of comparing (adapter->init_done_rc == 1), let it be (adapter->init_done_rc == PARTIALSUCCESS). Signed-off-by: Lijun Pan --- drivers/net/ethernet/ibm/ibmvnic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/i

[PATCH net-next v2 4/4] ibmvnic: merge ibmvnic_reset_init and ibmvnic_init

2020-08-19 Thread Lijun Pan
These two functions share the majority of the code, hence merge them together. In the meanwhile, add a reset pass-in parameter to differentiate them. Thus, the code is easier to read and to tell the difference between reset_init and regular init. Signed-off-by: Lijun Pan --- drivers/net/ethernet

[PATCH net-next v2 0/4] refactoring of ibmvnic code

2020-08-19 Thread Lijun Pan
This patch series refactor reset_init and init functions, and make some other cosmetic changes to make the code easier to read and debug. v2 removes __func__ and v1's 1/5. Lijun Pan (4): ibmvnic: compare adapter->init_done_rc with more readable ibmvnic_rc_codes ibmvnic: improve ibmvnic_ini

[PATCH net-next v2 2/4] ibmvnic: improve ibmvnic_init and ibmvnic_reset_init

2020-08-19 Thread Lijun Pan
When H_SEND_CRQ command returns with H_CLOSED, it means the server's CRQ is not ready yet. Instead of resetting immediately, we wait for the server to launch passive init. ibmvnic_init() and ibmvnic_reset_init() should also return the error code from ibmvnic_send_crq_init() call. Signed-off-by: Li

Re: [PATCH net-next v1 2/3] net: openvswitch: refactor flow free function

2020-08-19 Thread David Miller
From: xiangxia.m@gmail.com Date: Tue, 18 Aug 2020 18:09:22 +0800 > Decrease table->count and ufid_count unconditionally, You don't explain why this is a valid transformation. Is it a bug fix? Can it never happen? What are the details and how did you determine this?

Re: [PATCH net 2/3] net: qede: Disable aRFS for NPAR and 100G

2020-08-19 Thread David Miller
From: Dmitry Bogdanov Date: Wed, 19 Aug 2020 23:29:28 +0300 > Fixes: e4917d46a65 ("qede: Add aRFS support") This Fixes tag only has 11 digits of SHA1, when you should provide 12 like the other two patches in this series do. Thank you.

RE: [PATCH bpf-next 5/6] bpf: sockmap: allow update from BPF

2020-08-19 Thread John Fastabend
John Fastabend wrote: > Lorenz Bauer wrote: > > Allow calling bpf_map_update_elem on sockmap and sockhash from a BPF > > context. The synchronization required for this is a bit fiddly: we > > need to prevent the socket from changing it's state while we add it > > to the sockmap, since we rely on ge

Re: [PATCH v2] netlink: fix state reallocation in policy export

2020-08-19 Thread David Miller
From: Johannes Berg Date: Wed, 19 Aug 2020 21:52:38 +0200 > From: Johannes Berg > > Evidently, when I did this previously, we didn't have more than > 10 policies and didn't run into the reallocation path, because > it's missing a memset() for the unused policies. Fix that. > > Fixes: d07dcf9aa

Re: [PATCH, net-next, v3] ibmvnic: store RX and TX subCRQ handle array in ibmvnic_adapter struct

2020-08-19 Thread David Miller
From: Cristobal Forno Date: Wed, 19 Aug 2020 13:16:23 -0500 > Currently the driver reads RX and TX subCRQ handle array directly from > a DMA-mapped buffer address when it needs to make a H_SEND_SUBCRQ > hcall. This patch stores that information in the ibmvnic_sub_crq_queue > structure instead of

Re: [PATCH v3 bpf-next 0/5] Add libbpf support for type- and enum value-based CO-RE relocations

2020-08-19 Thread Andrii Nakryiko
On Wed, Aug 19, 2020 at 2:58 PM Alexei Starovoitov wrote: > > On Wed, Aug 19, 2020 at 12:45:14PM -0700, Andrii Nakryiko wrote: > > > > Selftests are added for all the new features. Selftests utilizing new Clang > > built-ins are designed such that they will compile with older Clangs and > > will

Re: [PATCH 49/49] dt: display: Add binds for the DPE and DSI controller for Kirin 960/970

2020-08-19 Thread Rob Herring
On Wed, 19 Aug 2020 13:46:17 +0200, Mauro Carvalho Chehab wrote: > Add a description of the bindings used by Kirin 960/970 Display > Serial Interface (DSI) controller and by its Display Engine (DPE). > > Signed-off-by: Mauro Carvalho Chehab > --- > .../display/hisilicon,hi3660-dpe.yaml |

Re: [PATCH V3 net 0/3] Bug fixes for ENA ethernet driver

2020-08-19 Thread David Miller
From: Shay Agroskin Date: Wed, 19 Aug 2020 20:28:35 +0300 > This series adds the following: > - Fix undesired call to ena_restore after returning from suspend > - Fix condition inside a WARN_ON > - Fix overriding previous value when updating missed_tx statistic > > v1->v2: > - fix bug when calli

Re: [PATCH net-next 2/3] net: dsa: mv88e6xxx: return error instead of lane in .serdes_get_lane

2020-08-19 Thread kernel test robot
Hi "Marek, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Marek-Beh-n/net-dsa-mv88e6xxx-Add-Amethyst-88E6393X/20200819-234008 base: https://git.kernel.org/pub/scm/linux/kernel/git/dave

Re: [PATCH net] drivers/net/wan/lapbether: Added needed_tailroom

2020-08-19 Thread Xie He
Hi Martin Schiller, Can you help review this patch? Thanks! It is a very simple patch that adds the "needed_tailroom" setting for this driver. Thank you! Xie He

Re: Kernel build error on BTFIDS vmlinux

2020-08-19 Thread Mark Wielaard
Hi, On Wed, 2020-08-19 at 19:18 +0200, Jiri Olsa wrote: > On Wed, Aug 19, 2020 at 04:34:30PM +0100, Nick Clifton wrote: > > > So it would be nice if binutils ld could also be fixed to write out > > > compressed sections with the correct alignment. > > > > OK, I will look into doing this. > > > >

Re: [PATCH v3 bpf-next 0/5] Add libbpf support for type- and enum value-based CO-RE relocations

2020-08-19 Thread Alexei Starovoitov
On Wed, Aug 19, 2020 at 12:45:14PM -0700, Andrii Nakryiko wrote: > > Selftests are added for all the new features. Selftests utilizing new Clang > built-ins are designed such that they will compile with older Clangs and will > be skipped during test runs. So this shouldn't cause any build and test

Re: [PATCH net-next 6/6] net: mvneta: enable jumbo frames for XDP

2020-08-19 Thread John Fastabend
Jakub Kicinski wrote: > On Wed, 19 Aug 2020 22:22:23 +0200 Lorenzo Bianconi wrote: > > > On Wed, 19 Aug 2020 15:13:51 +0200 Lorenzo Bianconi wrote: > > > > Enable the capability to receive jumbo frames even if the interface is > > > > running in XDP mode > > > > > > > > Signed-off-by: Lorenzo Bi

Re: [PATCH] block: convert tasklets to use new tasklet_setup() API

2020-08-19 Thread James Bottomley
On Wed, 2020-08-19 at 21:54 +0530, Allen wrote: > > [...] > > > > Since both threads seem to have petered out, let me suggest in > > > > kernel.h: > > > > > > > > #define cast_out(ptr, container, member) \ > > > > container_of(ptr, typeof(*container), member) > > > > > > > > It does what you

Re: [PATCH 00/49] DRM driver for Hikey 970

2020-08-19 Thread John Stultz
On Wed, Aug 19, 2020 at 4:46 AM Mauro Carvalho Chehab wrote: > So, IMO, the best is to keep it on staging for a while, until those > remaining bugs gets solved. > > I added this series, together with the regulator driver and > a few other patches (including a hack to fix a Kernel 5.8 > regression

Re: [PATCH bpf-next] tools/resolve_btfids: Fix sections with wrong alignment

2020-08-19 Thread Yonghong Song
On 8/19/20 2:23 AM, Jiri Olsa wrote: The data of compressed section should be aligned to 4 (for 32bit) or 8 (for 64 bit) bytes. The binutils ld sets sh_addralign to 1, which makes libelf fail with misaligned section error during the update as reported by Jesper: FAILED elf_update(WRITE):

tc filter by source port and destination port strange offset

2020-08-19 Thread Denis Gubin
Dear colleagues, There are filters. Let's have a look on it. Pretty mode showing: tc -p filter show dev ens5 parent : filter protocol ip pref 49146 u32 chain 0 filter protocol ip pref 49146 u32 chain 0 fh 806: ht divisor 1 filter protocol ip pref 49146 u32 chain 0 fh 806::800 order 2048 key

Re: [PATCH bpf-next] tools/resolve_btfids: Fix sections with wrong alignment

2020-08-19 Thread Yonghong Song
On 8/19/20 11:16 AM, Nick Desaulniers wrote: On Wed, Aug 19, 2020 at 10:36 AM Jiri Olsa wrote: On Wed, Aug 19, 2020 at 08:31:51AM -0700, Yonghong Song wrote: On 8/19/20 2:23 AM, Jiri Olsa wrote: The data of compressed section should be aligned to 4 (for 32bit) or 8 (for 64 bit) bytes.

Re: [PATCH 00/49] DRM driver for Hikey 970

2020-08-19 Thread Sam Ravnborg
Hi John. > > So, IMO, the best is to keep it on staging for a while, until those > > remaining bugs gets solved. > > I'm not sure I see all of these as compelling for pushing it in via > staging. And I suspect in the process of submitting the patches for > review folks may find the cause of some

RE: [PATCH bpf-next 5/6] bpf: sockmap: allow update from BPF

2020-08-19 Thread John Fastabend
Lorenz Bauer wrote: > Allow calling bpf_map_update_elem on sockmap and sockhash from a BPF > context. The synchronization required for this is a bit fiddly: we > need to prevent the socket from changing it's state while we add it > to the sockmap, since we rely on getting a callback via > sk_prot->

Re: [PATCH iproute2 v5 0/2] iplink: hsr: add support for creating PRP device

2020-08-19 Thread Murali Karicheri
Hi, Stephen, On 8/17/20 5:17 PM, Murali Karicheri wrote: This series enhances the iproute2 iplink module to add support for creating PRP device similar to HSR. The kernel part of this is already merged to v5.9 master v5 - addressed comment from Stephen Hemminger - Sending this with a iprout

Re: [PATCH bpf-next] net-veth: add type safety to veth_xdp_to_ptr() and veth_ptr_to_xdp()

2020-08-19 Thread Alexei Starovoitov
On Tue, Aug 18, 2020 at 7:00 PM Maciej Żenczykowski wrote: > > From: Maciej Żenczykowski > > This reduces likelihood of incorrect use. > > Test: builds I kept this in the commit log though it's a pointless comment. Please reconsider for the future. If you want to mention how you've tested it, pl

Re: [PATCH net-next 6/6] net: mvneta: enable jumbo frames for XDP

2020-08-19 Thread Jakub Kicinski
On Wed, 19 Aug 2020 22:22:23 +0200 Lorenzo Bianconi wrote: > > On Wed, 19 Aug 2020 15:13:51 +0200 Lorenzo Bianconi wrote: > > > Enable the capability to receive jumbo frames even if the interface is > > > running in XDP mode > > > > > > Signed-off-by: Lorenzo Bianconi > > > > Hm, already? Is

Re: [PATCH 00/49] DRM driver for Hikey 970

2020-08-19 Thread John Stultz
On Wed, Aug 19, 2020 at 4:46 AM Mauro Carvalho Chehab wrote: > Yet, I'm submitting it via staging due to the following reasons: > > - It depends on the LDO3 power supply, which is provided by > a regulator driver that it is currently on staging; > - Due to legal reasons, I need to preserve the a

Re: [PATCH bpf-next 1/2] net-tun: add type safety to tun_xdp_to_ptr() and tun_ptr_to_xdp()

2020-08-19 Thread Alexei Starovoitov
On Tue, Aug 18, 2020 at 6:07 PM Maciej Żenczykowski wrote: > > From: Maciej Żenczykowski > > This reduces likelihood of incorrect use. > > Test: builds > Signed-off-by: Maciej Żenczykowski Applied. Thanks

[PATCH] rtl818x_pci: switch from 'pci_' to 'dma_' API

2020-08-19 Thread Christophe JAILLET
The wrappers in include/linux/pci-dma-compat.h should go away. The patch has been generated with the coccinelle script below and has been hand modified to replace GFP_ with a correct flag. It has been compile tested. When memory is allocated in 'rtl8180_init_rx_ring()' and 'rtl8180_init_tx_ring()

Re: [PATCH 49/49] dt: display: Add binds for the DPE and DSI controller for Kirin 960/970

2020-08-19 Thread Sam Ravnborg
Hi Mauro. Some feedback in the following. Good to see DT schma files and not .txt files - but needs a bit more work. Sam On Wed, Aug 19, 2020 at 01:46:17PM +0200, Mauro Carvalho Chehab wrote: > Add a description of the bindings used by Kirin 960/970 Display > Serial Interface (DSI) contr

Re: xdp generic default option

2020-08-19 Thread Andrii Nakryiko
On Wed, Aug 19, 2020 at 2:29 AM Lorenzo Bianconi wrote: > > Hi Andrii, > > working on xdp multi-buff I figured out now xdp generic is the default choice > if not specified by userspace. In particular after commit 7f0a838254bd > ("bpf, xdp: Maintain info on attached XDP BPF programs in net_device")

RE: [PATCH bpf-next 4/6] bpf: override the meaning of ARG_PTR_TO_MAP_VALUE for sockmap and sockhash

2020-08-19 Thread John Fastabend
Lorenz Bauer wrote: > The verifier assumes that map values are simple blobs of memory, and > therefore treats ARG_PTR_TO_MAP_VALUE, etc. as such. However, there are > map types where this isn't true. For example, sockmap and sockhash store > sockets. In general this isn't a big problem: we can just

Re: [PATCH bpf] bpf: refer to struct xdp_md in user space comments

2020-08-19 Thread Yonghong Song
On 8/19/20 12:27 PM, Jakub Kicinski wrote: uAPI uses xdp_md, not xdp_buff. Fix comments. Signed-off-by: Jakub Kicinski Acked-by: Yonghong Song

Re: [PATCH bpf-next 6/6] selftests: bpf: test sockmap update from BPF

2020-08-19 Thread Yonghong Song
On 8/19/20 2:24 AM, Lorenz Bauer wrote: Add a test which copies a socket from a sockmap into another sockmap or sockhash. This excercises bpf_map_update_elem support from BPF context. Compare the socket cookies from source and destination to ensure that the copy succeeded. Signed-off-by: Lore

Re: [PATCH iproute2-next v2] iproute2: ss: add support to expose various inet sockopts

2020-08-19 Thread Roman Mashak
Wei Wang writes: > This commit adds support to expose the following inet socket options: > -- recverr > -- is_icsk > -- freebind > -- hdrincl > -- mc_loop > -- transparent > -- mc_all > -- nodefrag > -- bind_address_no_port > -- recverr_rfc4884 > -- defer_connect > with the option --inet-sockopt.

Re: [PATCH bpf-next 5/6] bpf: sockmap: allow update from BPF

2020-08-19 Thread Yonghong Song
On 8/19/20 2:24 AM, Lorenz Bauer wrote: Allow calling bpf_map_update_elem on sockmap and sockhash from a BPF context. The synchronization required for this is a bit fiddly: we need to prevent the socket from changing it's state while we add it to the sockmap, since we rely on getting a callbac

[PATCH net 0/3] net: qed disable aRFS in NPAR and 100G

2020-08-19 Thread Dmitry Bogdanov
This patchset fixes some recent issues found by customers. Dmitry Bogdanov (3): net: qed: Disable aRFS for NPAR and 100G net: qede: Disable aRFS for NPAR and 100G qed: RDMA personality shouldn't fail VF load drivers/net/ethernet/qlogic/qed/qed_dev.c | 11 ++- drivers/net/ether

RE: [PATCH bpf-next 3/6] bpf: sockmap: call sock_map_update_elem directly

2020-08-19 Thread John Fastabend
Lorenz Bauer wrote: > Don't go via map->ops to call sock_map_update_elem, since we know > what function to call in bpf_map_update_value. Since > check_map_func_compatibility doesn't allow calling > BPF_FUNC_map_update_elem from BPF context, we can remove > ops->map_update_elem and rename the functi

[PATCH net 3/3] net: qed: RDMA personality shouldn't fail VF load

2020-08-19 Thread Dmitry Bogdanov
Fix the assert during VF driver installation when the personality is iWARP Fixes: 1fe614d10f45 ("qed: Relax VF firmware requirements") Signed-off-by: Igor Russkikh Signed-off-by: Michal Kalderon Signed-off-by: Dmitry Bogdanov --- drivers/net/ethernet/qlogic/qed/qed_sriov.c | 1 + 1 file change

[PATCH net 2/3] net: qede: Disable aRFS for NPAR and 100G

2020-08-19 Thread Dmitry Bogdanov
In some configurations ARFS cannot be used, so disable it if device is not capable. Fixes: e4917d46a65 ("qede: Add aRFS support") Signed-off-by: Manish Chopra Signed-off-by: Igor Russkikh Signed-off-by: Michal Kalderon Signed-off-by: Dmitry Bogdanov --- drivers/net/ethernet/qlogic/qede/qede_f

[PATCH net 1/3] net: qed: Disable aRFS for NPAR and 100G

2020-08-19 Thread Dmitry Bogdanov
In CMT and NPAR the PF is unknown when the GFS block processes the packet. Therefore cannot use searcher as it has a per PF database, and thus ARFS must be disabled. Fixes: d51e4af5c209 ("qed: aRFS infrastructure support") Signed-off-by: Manish Chopra Signed-off-by: Igor Russkikh Signed-off-by:

Re: [PATCH bpf-next 4/7] libbpf: sanitize BPF program code for bpf_probe_read_{kernel,user}[_str]

2020-08-19 Thread Andrii Nakryiko
On Wed, Aug 19, 2020 at 1:15 PM Alexei Starovoitov wrote: > > On Wed, Aug 19, 2020 at 1:13 PM Andrii Nakryiko > wrote: > > > > On Tue, Aug 18, 2020 at 6:42 PM Yonghong Song wrote: > > > > > > > > > > > > On 8/18/20 2:33 PM, Andrii Nakryiko wrote: > > > > Add BPF program code sanitization pass, r

Re: [PATCH net-next 6/6] net: mvneta: enable jumbo frames for XDP

2020-08-19 Thread Lorenzo Bianconi
> On Wed, 19 Aug 2020 15:13:51 +0200 Lorenzo Bianconi wrote: > > Enable the capability to receive jumbo frames even if the interface is > > running in XDP mode > > > > Signed-off-by: Lorenzo Bianconi > > Hm, already? Is all the infra in place? Or does it not imply > multi-buffer. > Hi Jakub,

Re: [PATCH bpf-next 4/7] libbpf: sanitize BPF program code for bpf_probe_read_{kernel,user}[_str]

2020-08-19 Thread Alexei Starovoitov
On Wed, Aug 19, 2020 at 1:13 PM Andrii Nakryiko wrote: > > On Tue, Aug 18, 2020 at 6:42 PM Yonghong Song wrote: > > > > > > > > On 8/18/20 2:33 PM, Andrii Nakryiko wrote: > > > Add BPF program code sanitization pass, replacing calls to BPF > > > bpf_probe_read_{kernel,user}[_str]() helpers with b

Re: [PATCH bpf-next 4/6] bpf: override the meaning of ARG_PTR_TO_MAP_VALUE for sockmap and sockhash

2020-08-19 Thread Yonghong Song
On 8/19/20 2:24 AM, Lorenz Bauer wrote: The verifier assumes that map values are simple blobs of memory, and therefore treats ARG_PTR_TO_MAP_VALUE, etc. as such. However, there are map types where this isn't true. For example, sockmap and sockhash store sockets. In general this isn't a big pro

Re: [PATCH bpf-next 4/7] libbpf: sanitize BPF program code for bpf_probe_read_{kernel,user}[_str]

2020-08-19 Thread Andrii Nakryiko
On Tue, Aug 18, 2020 at 6:42 PM Yonghong Song wrote: > > > > On 8/18/20 2:33 PM, Andrii Nakryiko wrote: > > Add BPF program code sanitization pass, replacing calls to BPF > > bpf_probe_read_{kernel,user}[_str]() helpers with bpf_probe_read[_str](), if > > libbpf detects that kernel doesn't support

  1   2   3   4   >