On Wed, Aug 19, 2020 at 2:58 PM Alexei Starovoitov <alexei.starovoi...@gmail.com> wrote: > > On Wed, Aug 19, 2020 at 12:45:14PM -0700, Andrii Nakryiko wrote: > > > > Selftests are added for all the new features. Selftests utilizing new Clang > > built-ins are designed such that they will compile with older Clangs and > > will > > be skipped during test runs. So this shouldn't cause any build and test > > failures on systems with slightly outdated Clang compiler. > > > > LLVM patches adding these relocation in Clang: > > - __builtin_btf_type_id() ([0], [1], [2]); > > - __builtin_preserve_type_info(), __builtin_preserve_enum_value() ([3], > > [4]). > > > > [0] https://reviews.llvm.org/D74572 > > [1] https://reviews.llvm.org/D74668 > > [2] https://reviews.llvm.org/D85174 > > [3] https://reviews.llvm.org/D83878 > > [4] https://reviews.llvm.org/D83242 > > Applied.
Thanks! > Thank you for listing the above in the commit log, but please follow up with > corresponding update to README.rst and mention the same details there: the > symptoms of missing clang features, which tests are going to be skipped for > older clang, etc. Ok, sure. > > Also progs/test_core_reloc_type_id.c talks about some bug with > __builtin_preserve_type_info() please add llvm diff number that fixes > it to that .c file. Ok, that's [2] above.
