On Mon, Aug 17, 2020 at 10:38:24AM -0500, Bjorn Helgaas wrote:
> You've likely seen this already, but Coverity found this problem:
>
> *** CID 1466147: Control flow issues (DEADCODE)
> /drivers/net/ethernet/mellanox/mlxsw/spectrum_policer.c: 380 in
> mlxsw_sp_policers_init()
> 374
On 17. 08. 20, 11:06, Allen Pais wrote:
> From: Allen Pais
>
> Commit 12cc923f1ccc ("tasklet: Introduce new initialization API")'
> introduced a new tasklet initialization API. This series converts
> all the wireless drivers to use the new tasklet_setup() API
General question for the whole seri
>From commit f1394b798814 ("block: mark blk_account_io_completion
static") symbol blk_account_io_completion() has been marked as static,
which makes it no longer possible to attach kprobe to this event.
Currently, there are broken samples due to this reason.
As a solution to this, attach kprobe ev
On Mon, Aug 17, 2020 at 6:43 PM Tang Bin wrote:
>
> Hi Kalle：
>
> 在 2020/8/17 22:26, Kalle Valo 写道:
> >> In the function ath10k_ahb_clock_init(), devm_clk_get() doesn't
> >> return NULL. Thus use IS_ERR() and PTR_ERR() to validate
> >> the returned value instead of IS_ERR_OR_NULL().
> > Why? What'
We return the VLAN table size through devlink as a simple parameter, we
do not support altering it at runtime:
devlink resource show mdio_bus/fixed-0:1f
mdio_bus/fixed-0:1f:
name VTU size 4096 occ 4096 unit entry dpipe_tables none
Signed-off-by: Florian Fainelli
---
drivers/net/dsa/dsa_loop.c
Hi Kalle：
在 2020/8/17 22:26, Kalle Valo 写道:
In the function ath10k_ahb_clock_init(), devm_clk_get() doesn't
return NULL. Thus use IS_ERR() and PTR_ERR() to validate
the returned value instead of IS_ERR_OR_NULL().
Why? What's the benefit of this patch? Or what harm does
IS_ERR_OR_NULL() create?
The pull request you sent on Mon, 17 Aug 2020 15:15:16 -0700 (PDT):
> git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git refs/heads/master
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/4cf7562190c795f1f95be6ee0d161107d0dc5d49
Thank you!
--
Deet-doot-dot,
On 8/17/20 5:33 PM, Eric Dumazet wrote:
>
>
> On 8/17/20 2:17 PM, Hauke Mehrtens wrote:
>> On 8/16/20 8:07 PM, Eric Dumazet wrote:
>>>
>>>
>>> On 8/15/20 11:33 AM, Hauke Mehrtens wrote:
Use napi_complete_done() and activate the interrupts when this function
returns true. This way the
Hi Fabian,
On Fri, 14 Aug 2020 20:55:44 +0200
Fabian Frederick wrote:
> exit script with comments when parameters are wrong during address
> addition. No need for a message when trying to change MTU with lower
> values: output is self-explanatory
>
> Signed-off-by: Fabian Frederick
> ---
> to
On 8/17/20 2:17 PM, Hauke Mehrtens wrote:
> On 8/16/20 8:07 PM, Eric Dumazet wrote:
>>
>>
>> On 8/15/20 11:33 AM, Hauke Mehrtens wrote:
>>> Use napi_complete_done() and activate the interrupts when this function
>>> returns true. This way the generic NAPI code can take care of activating
>>> the
On 09.08.20 17:02, Jiri Olsa wrote:
> Adding d_path helper function that returns full path for
> given 'struct path' object, which needs to be the kernel
> BTF 'path' object. The path is returned in buffer provided
> 'buf' of size 'sz' and is zero terminated.
>
> bpf_d_path(&file->f_path, buf
From: Colin Ian King
The Kconfig help text contains the phrase "the the" in the help
text. Fix this and reformat the block of help text.
Signed-off-by: Colin Ian King
---
net/ipv4/Kconfig | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/net/ipv4/Kconfig b/net/
From: Colin Ian King
The Kconfig help text contains the phrase "the the" in the help
text. Fix this.
Signed-off-by: Colin Ian King
---
drivers/net/dsa/ocelot/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/ocelot/Kconfig b/drivers/net/dsa/ocelot/Kcon
Hi Murali,
I was finally able to go back to working on this, and should have
something for review when net-next opens.
Cheers,
Murali Karicheri writes:
> Hello Vinicius,
>
> Wondering what is your plan to add the support in ethtool to configure
> IET frame preemption? Waiting for the next re
On Mon, Aug 17, 2020 at 2:39 PM David Miller wrote:
>
> From: Cong Wang
> Date: Mon, 17 Aug 2020 13:59:46 -0700
>
> > Is this a new Kconfig feature? ipv6_stub was introduced for
> > VXLAN, at that time I don't remember we have such kind of
> > Kconfig rules, otherwise it would not be needed.
>
>
Another batch of fixes:
1) Remove nft_compat counter flush optimization, it generates warnings from
the refcount infrastructure. From Florian Westphal.
2) Fix BPF to search for build id more robustly, from Jiri Olsa.
3) Handle bogus getopt lengths in ebtables, from Florian Westphal.
4) I
From: Xu Wang
Date: Mon, 17 Aug 2020 02:04:13 +
> A multiplication for the size determination of a memory allocation
> indicated that an array data structure should be processed.
> Thus use the corresponding function "devm_kcalloc".
>
> Signed-off-by: Xu Wang
Applied, thanks.
From: Denys Zagorui
Date: Mon, 17 Aug 2020 10:52:24 -0700
> SIOCADDMULTI API allows adding multicast/unicast mac addresses but
> doesn't deferentiate them so if someone tries to add secondary
> unicast mac addr it will be added to multicast netdev list which is
> confusing. There is at least one
From: Necip Fazil Yildiran
Date: Mon, 17 Aug 2020 15:54:48 +
> From: Necip Fazil Yildiran
>
> Passing large uint32 sockaddr_qrtr.port numbers for port allocation
> triggers a warning within idr_alloc() since the port number is cast
> to int, and thus interpreted as a negative number. This l
From: David Ahern
Date: Mon, 17 Aug 2020 09:43:33 -0600
> h1 is initially configured to reach h2 via r1 rather than the
> more direct path through r2. If rp_filter is set and inherited
> for r2, forwarding fails since the source address of h1 is
> reachable from eth0 vs the packet coming to it vi
From:
Date: Mon, 17 Aug 2020 11:37:35 -0400
> @@ -53,7 +53,9 @@
>
> #define OUTPUT_MODULE_FROM_INDEX(index) (OUTPUT_0 + (index) * 0x10)
>
> -#define PEROUT_ENABLE_OUTPUT_MASK(0xdeadbeef)
> +#define PEROUT_ENABLE_OUTPUT_MASK(0xdeadbeef)
> +
> +#define IDTCM_MAX_WRITE_COUN
From: Alvin Šipraga
Date: Mon, 17 Aug 2020 15:58:59 +0200
> @@ -1269,6 +1269,9 @@ static void macvlan_port_destroy(struct net_device *dev)
> static int macvlan_validate(struct nlattr *tb[], struct nlattr *data[],
> struct netlink_ext_ack *extack)
> {
> + int rem, l
On Mon, Aug 17, 2020 at 11:27 AM Josef Bacik wrote:
>
> On 8/17/20 1:42 PM, Yonghong Song wrote:
> > With latest `bpftool prog` command, we observed the following kernel
> > panic.
> > BUG: kernel NULL pointer dereference, address:
> >
> > This patch used get_file_rcu() which
On Monday 17 August 2020 20:27:06 Jesse Brandeburg wrote:
> On Mon, 17 Aug 2020 16:27:01 +0300
> Kalle Valo wrote:
>
> > I was surprised to see that someone was using this driver in 2015, so
> > I'm not sure anymore what to do. Of course we could still just remove
> > it and later revert if someo
From: Cong Wang
Date: Mon, 17 Aug 2020 13:59:46 -0700
> Is this a new Kconfig feature? ipv6_stub was introduced for
> VXLAN, at that time I don't remember we have such kind of
> Kconfig rules, otherwise it would not be needed.
The ipv6_stub exists in order to allow the troublesome
"ipv6=m && fea
From: Cong Wang
Date: Mon, 17 Aug 2020 13:29:40 -0700
> On Mon, Aug 17, 2020 at 12:55 PM Randy Dunlap wrote:
>>
>> TIPC=m and IPV6=m builds just fine.
>>
>> Having tipc autoload ipv6 is a different problem. (IMO)
>>
>>
>> This Kconfig entry:
>> menuconfig TIPC
>> tristate "The TIPC Prot
From: Cong Wang
Date: Mon, 17 Aug 2020 11:55:55 -0700
> On Mon, Aug 17, 2020 at 11:49 AM Randy Dunlap wrote:
>>
>> It just restricts how TIPC can be built, so that
>> TIPC=y and IPV6=m cannot happen together, which causes
>> a build error.
>
> It also disallows TIPC=m and IPV6=m, right?
That c
Hello Vinicius,
Wondering what is your plan to add the support in ethtool to configure
IET frame preemption? Waiting for the next revision of the patch.
Thanks and regards,
--
Murali Karicheri
Texas Instruments
PRP support requires a proto parameter which is 0 for hsr and 1 for
prp. Default is hsr and is backward compatible.
Signed-off-by: Murali Karicheri
---
man/man8/ip-link.8.in | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/man/man8/ip-link.8.in b/man/man8/ip-link.8.in
This series enhances the iproute2 iplink module to add support
for creating PRP device similar to HSR. The kernel part of this
is already merged to v5.9 master
v4 - addressed comment from Stephen Hemminger
- Sending this with a iproute2 prefix so that this can
be merged to v5.9 iprout2 if
This patch enhances the iplink command to add a proto parameters to
create PRP device/interface similar to HSR. Both protocols are
quite similar and requires a pair of Ethernet interfaces. So re-use
the existing HSR iplink command to create PRP device/interface as
well. Use proto parameter to diffe
On 8/16/20 8:07 PM, Eric Dumazet wrote:
>
>
> On 8/15/20 11:33 AM, Hauke Mehrtens wrote:
>> Use napi_complete_done() and activate the interrupts when this function
>> returns true. This way the generic NAPI code can take care of activating
>> the interrupts.
>>
>> Signed-off-by: Hauke Mehrtens
>
On Mon, Aug 17, 2020 at 1:43 PM Randy Dunlap wrote:
>
> On 8/17/20 1:29 PM, Cong Wang wrote:
> > On Mon, Aug 17, 2020 at 12:55 PM Randy Dunlap wrote:
> >>
> >> TIPC=m and IPV6=m builds just fine.
> >>
> >> Having tipc autoload ipv6 is a different problem. (IMO)
> >>
> >>
> >> This Kconfig entry:
On 8/16/20 6:46 PM, Stephen Hemminger wrote:
On Thu, 6 Aug 2020 16:37:11 -0400
Murali Karicheri wrote:
+
+ print_int(PRINT_ANY,
+ "proto",
+ "proto %d ",
+ rta_getattr_u8(tb[IFLA_HSR_PROTOCOL]));
On 8/17/20 1:29 PM, Cong Wang wrote:
> On Mon, Aug 17, 2020 at 12:55 PM Randy Dunlap wrote:
>>
>> TIPC=m and IPV6=m builds just fine.
>>
>> Having tipc autoload ipv6 is a different problem. (IMO)
>>
>>
>> This Kconfig entry:
>> menuconfig TIPC
>> tristate "The TIPC Protocol"
>> de
On Mon, Aug 17, 2020 at 12:55 PM Randy Dunlap wrote:
>
> TIPC=m and IPV6=m builds just fine.
>
> Having tipc autoload ipv6 is a different problem. (IMO)
>
>
> This Kconfig entry:
> menuconfig TIPC
> tristate "The TIPC Protocol"
> depends on INET
> + depends on IPV6 || IPV6=n
On Mon, 17 Aug 2020, Jesse Brandeburg wrote:
> On Mon, 17 Aug 2020 16:27:01 +0300
> Kalle Valo wrote:
>
> > I was surprised to see that someone was using this driver in 2015, so
> > I'm not sure anymore what to do. Of course we could still just remove
> > it and later revert if someone steps up
On 8/17/20 12:48 PM, Kees Cook wrote:
> On Mon, Aug 17, 2020 at 12:44:34PM -0700, Jens Axboe wrote:
>> On 8/17/20 12:29 PM, Kees Cook wrote:
>>> On Mon, Aug 17, 2020 at 06:56:47AM -0700, Jens Axboe wrote:
On 8/17/20 2:15 AM, Allen Pais wrote:
> From: Allen Pais
>
> In preparation
On 8/17/20 12:26 PM, Cong Wang wrote:
> On Mon, Aug 17, 2020 at 12:00 PM Randy Dunlap wrote:
>>
>> On 8/17/20 11:55 AM, Cong Wang wrote:
>>> On Mon, Aug 17, 2020 at 11:49 AM Randy Dunlap wrote:
On 8/17/20 11:31 AM, Cong Wang wrote:
> On Sun, Aug 16, 2020 at 11:37 PM Xin Long wrote:
On 8/17/2020 7:55 AM, Helmut Grohne wrote:
Andrew Lunn asked me to turn my dead code removal RFC patch into a real
one splitting it per member. This is what this v2 series does. Some
parts of the RFC patch are already applied via:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.
On Mon, Aug 17, 2020 at 12:44:34PM -0700, Jens Axboe wrote:
> On 8/17/20 12:29 PM, Kees Cook wrote:
> > On Mon, Aug 17, 2020 at 06:56:47AM -0700, Jens Axboe wrote:
> >> On 8/17/20 2:15 AM, Allen Pais wrote:
> >>> From: Allen Pais
> >>>
> >>> In preparation for unconditionally passing the
> >>> str
On Mon, Aug 17, 2020 at 4:19 AM Jamal Hadi Salim wrote:
>
> On 2020-08-16 2:59 p.m., Cong Wang wrote:
> > On Thu, Aug 13, 2020 at 5:52 AM Jamal Hadi Salim wrote:
>
>
> [..]
> >> How do you know whether to use hash or mark or both
> >> for that specific key?
> >
> > Hmm, you can just unconditional
On 8/17/20 12:29 PM, Kees Cook wrote:
> On Mon, Aug 17, 2020 at 06:56:47AM -0700, Jens Axboe wrote:
>> On 8/17/20 2:15 AM, Allen Pais wrote:
>>> From: Allen Pais
>>>
>>> In preparation for unconditionally passing the
>>> struct tasklet_struct pointer to all tasklet
>>> callbacks, switch to using t
On Sun, 16 Aug 2020 23:14:20 +0200 Florian Westphal wrote:
> This fix wasn't correct: When this function is invoked from the
> retransmission worker, the iterator contains garbage and resetting
> it causes a crash.
>
> As the work queue should not be performance critical also zero the
> msghdr str
On Mon, 17 Aug 2020 07:39:01 + Necip Fazil Yildiran wrote:
> From: Necip Fazil Yildiran
>
> Passing large uint32 sockaddr_qrtr.port numbers for port allocation
> triggers a warning within idr_alloc() since the port number is cast
> to int, and thus interpreted as a negative number. This leads
Hello,
syzbot found the following issue on:
HEAD commit:2cc3c4b3 Merge tag 'io_uring-5.9-2020-08-15' of git://git...
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=10cf6aa690
kernel config: https://syzkaller.appspot.com/x/.config?x=19f02fc5c511a391
das
On Mon, Aug 17, 2020 at 06:56:47AM -0700, Jens Axboe wrote:
> On 8/17/20 2:15 AM, Allen Pais wrote:
> > From: Allen Pais
> >
> > In preparation for unconditionally passing the
> > struct tasklet_struct pointer to all tasklet
> > callbacks, switch to using the new tasklet_setup()
> > and from_task
On Mon, 17 Aug 2020 13:54:20 +0530 Allen Pais wrote:
> In preparation for unconditionally passing the
> struct tasklet_struct pointer to all tasklet
> callbacks, switch to using the new tasklet_setup()
> and from_tasklet() to pass the tasklet pointer explicitly.
>
> Signed-off-by: Romain Perier
>
On Mon, 17 Aug 2020 13:54:22 +0530 Allen Pais wrote:
> In preparation for unconditionally passing the
> struct tasklet_struct pointer to all tasklet
> callbacks, switch to using the new tasklet_setup()
> and from_tasklet() to pass the tasklet pointer explicitly.
>
> Signed-off-by: Romain Perier
>
On Mon, Aug 17, 2020 at 12:00 PM Randy Dunlap wrote:
>
> On 8/17/20 11:55 AM, Cong Wang wrote:
> > On Mon, Aug 17, 2020 at 11:49 AM Randy Dunlap wrote:
> >>
> >> On 8/17/20 11:31 AM, Cong Wang wrote:
> >>> On Sun, Aug 16, 2020 at 11:37 PM Xin Long wrote:
>
> On Mon, Aug 17, 2020 at 2:2
On Mon, Aug 17, 2020 at 4:44 PM Tom Herbert wrote:
>
> On Wed, Aug 5, 2020 at 1:27 AM Willem de Bruijn
> wrote:
> >
> > On Tue, Aug 4, 2020 at 5:57 PM Tom Herbert wrote:
> > >
> > > The definition for symmetric keys does not include the flow label so
> > > that when symmetric keys is used a non-
You've likely seen this already, but Coverity found this problem:
*** CID 1466147: Control flow issues (DEADCODE)
/drivers/net/ethernet/mellanox/mlxsw/spectrum_policer.c: 380 in
mlxsw_sp_policers_init()
374 }
375
376 return 0;
377
378 err_family_r
Hello,
looking at the other patches in this series, I think this patch's
subject "ath:" tag was supposed to be "carl9170:"?
(so the full subject is:
"wireless: carl9170: convert tasklets to use new tasklet_setup() API")
On 2020-08-17 11:06, Allen Pais wrote:
From: Allen Pais
In preparation
On Sun, Aug 16, 2020 at 10:45 PM Christoph Hellwig wrote:
>
> On Sun, Aug 16, 2020 at 10:55:09AM -0700, Cong Wang wrote:
> > On Sun, Aug 16, 2020 at 1:36 AM Coly Li wrote:
> > >
> > > The original problem was from nvme-over-tcp code, who mistakenly uses
> > > kernel_sendpage() to send pages alloc
On Mon, Aug 17, 2020 at 10:08:07AM -0700, Florian Fainelli wrote:
> On 8/16/20 12:43 PM, Andrew Lunn wrote:
> > Make use of devlink regions to allow read access to some of the
> > internal of the switches. The switch itself will never trigger a
> > region snapshot, it is assumed it is performed fro
> Looking at the documentation above (assuming it is up to date), these
> are raw hex dumps of the region, which is mildly useful.
>
> If we were to pretty print those regions such that they can fully
> replace the infamous debugfs interface patch from Vivien that has been
> floated around before,
On 8/17/20 11:55 AM, Cong Wang wrote:
> On Mon, Aug 17, 2020 at 11:49 AM Randy Dunlap wrote:
>>
>> On 8/17/20 11:31 AM, Cong Wang wrote:
>>> On Sun, Aug 16, 2020 at 11:37 PM Xin Long wrote:
On Mon, Aug 17, 2020 at 2:29 AM Cong Wang wrote:
>
> Or put it into struct ipv6_stub?
>>
On Mon, Aug 17, 2020 at 11:49 AM Randy Dunlap wrote:
>
> On 8/17/20 11:31 AM, Cong Wang wrote:
> > On Sun, Aug 16, 2020 at 11:37 PM Xin Long wrote:
> >>
> >> On Mon, Aug 17, 2020 at 2:29 AM Cong Wang wrote:
> >>>
> >>> Or put it into struct ipv6_stub?
> >> Hi Cong,
> >>
> >> That could be one wa
On 8/17/20 11:31 AM, Cong Wang wrote:
> On Sun, Aug 16, 2020 at 11:37 PM Xin Long wrote:
>>
>> On Mon, Aug 17, 2020 at 2:29 AM Cong Wang wrote:
>>>
>>> Or put it into struct ipv6_stub?
>> Hi Cong,
>>
>> That could be one way. We may do it when this new function becomes more
>> common.
>> By now,
From: "Jason A. Donenfeld"
Date: Mon, 17 Aug 2020 09:48:10 +0200
> On 8/17/20, Jesper Dangaard Brouer wrote:
>> On Sun, 16 Aug 2020 15:29:37 -0700 (PDT)
>> David Miller wrote:
>>
>>> From: "Jason A. Donenfeld"
>>> Date: Sat, 15 Aug 2020 09:29:30 +0200
>>>
>>> > When an XDP program changes the
From: Randy Dunlap
Date: Sun, 16 Aug 2020 22:43:54 -0700
> On 8/16/20 9:14 PM, David Miller wrote:
>> From: Randy Dunlap
>> Date: Sun, 16 Aug 2020 15:25:49 -0700
>>
>>> Fix a kernel-doc warning for the pcs_config() function prototype:
>>>
>>> ../include/linux/phylink.h:406: warning: Excess func
On Sun, Aug 16, 2020 at 11:37 PM Xin Long wrote:
>
> On Mon, Aug 17, 2020 at 2:29 AM Cong Wang wrote:
> >
> > Or put it into struct ipv6_stub?
> Hi Cong,
>
> That could be one way. We may do it when this new function becomes more
> common.
> By now, I think it's okay to make TIPC depend on IPV6
On 2020-08-17 14:59, Kalle Valo wrote:
Rasmus Villemoes writes:
On 14/08/2020 17.14, Christian Lamparter wrote:
On 2020-08-14 13:39, Lee Jones wrote:
'ar9170_qmap' is used in some source files which include carl9170.h,
but not all of them. Mark it as __maybe_unused to show that this is
not
On 8/17/20 1:42 PM, Yonghong Song wrote:
With latest `bpftool prog` command, we observed the following kernel
panic.
BUG: kernel NULL pointer dereference, address:
#PF: supervisor instruction fetch in kernel mode
#PF: error_code(0x0010) - not-present page
PGD
On Mon, 17 Aug 2020 16:27:01 +0300
Kalle Valo wrote:
> I was surprised to see that someone was using this driver in 2015, so
> I'm not sure anymore what to do. Of course we could still just remove
> it and later revert if someone steps up and claims the driver is still
> usable. Hmm. Does anyone
From: Min Li
The old code for i2c write would break on some controllers, which fails
at handling Repeated Start Condition. So we will just use i2c_master_send
to handle write in one transanction.
Signed-off-by: Min Li
---
drivers/ptp/ptp_clockmatrix.c | 56 +
From: Necip Fazil Yildiran
Passing large uint32 sockaddr_qrtr.port numbers for port allocation
triggers a warning within idr_alloc() since the port number is cast
to int, and thus interpreted as a negative number. This leads to
the rejection of such valid port numbers in qrtr_port_assign() as
idr
On Sun, 16 Aug 2020 21:43:16 +0200 Andrew Lunn wrote:
> Return the driver name and the asic.id with the switch name.
>
> Signed-off-by: Andrew Lunn
Reviewed-by: Jakub Kicinski
On Mon, Aug 17, 2020 at 11:37:35AM -0400, min.li...@renesas.com wrote:
> From: Min Li
>
> The old code for i2c write would break on some controllers, which fails
> at handling Repeated Start Condition. So we will just use i2c_master_send
> to handle write in one transanction.
>
> Signed-off-by:
SIOCADDMULTI API allows adding multicast/unicast mac addresses but
doesn't deferentiate them so if someone tries to add secondary
unicast mac addr it will be added to multicast netdev list which is
confusing. There is at least one user that allows adding secondary
unicast through this API.
(2f41f33
Hello,
syzbot found the following issue on:
HEAD commit:ce8056d1 wip: changed copy_from_user where instrumented
git tree: https://github.com/google/kmsan.git master
console output: https://syzkaller.appspot.com/x/log.txt?x=1496679e90
kernel config: https://syzkaller.appspot.com/x/.
Hello,
syzbot found the following issue on:
HEAD commit:4b6c093e Merge tag 'block-5.9-2020-08-14' of git://git.ker..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=1474141290
kernel config: https://syzkaller.appspot.com/x/.config?x=a98b778f5fca0653
das
With latest `bpftool prog` command, we observed the following kernel
panic.
BUG: kernel NULL pointer dereference, address:
#PF: supervisor instruction fetch in kernel mode
#PF: error_code(0x0010) - not-present page
PGD dfe894067 P4D dfe894067 PUD deb663067 PMD 0
On Mon, 17 Aug 2020 12:37:40 +0300 Moshe Shemesh wrote:
> Add devlink reload action to allow the user to request a specific reload
> action. The action parameter is optional, if not specified then devlink
> driver re-init action is used (backward compatible).
> Note that when required to do firmwar
So after some more fiddling, it looks like I got the diagram wrong.
Here's how the switch really consumes resources. 4 lookups in parallel,
they are ORed in 2 pairs (ingress with egress forms a pair), and the
result is ANDed. The consumptions for ingress and egress are really
completely independent
On 8/16/20 12:43 PM, Andrew Lunn wrote:
> Given a devlink instance, return the dsa switch it is associated to.
>
> Signed-off-by: Andrew Lunn
Reviewed-by: Florian Fainelli
--
Florian
On 8/16/20 3:39 PM, Andrew Lunn wrote:
>>> +static const struct devlink_region_ops *mv88e6xxx_region_port_ops[] = {
>>> + &mv88e6xxx_region_port_0_ops,
>>> + &mv88e6xxx_region_port_1_ops,
>>> + &mv88e6xxx_region_port_2_ops,
>>> + &mv88e6xxx_region_port_3_ops,
>>> + &mv88e6xxx_region_port_
On 8/16/20 12:43 PM, Andrew Lunn wrote:
> Make use of devlink regions to allow read access to some of the
> internal of the switches. The switch itself will never trigger a
> region snapshot, it is assumed it is performed from user space as
> needed.
>
> Andrew Lunn (7):
> net: dsa: Add helper t
Mon, Aug 17, 2020 at 11:37:52AM CEST, mo...@mellanox.com wrote:
>Add devlink reload rst documentation file.
>Update index file to include it.
>
>Signed-off-by: Moshe Shemesh
>---
>- Instead of reload levels driver,fw_reset,fw_live_patch have reload
> actions driver_reinit,fw_activate,fw_live_patc
Mon, Aug 17, 2020 at 11:37:40AM CEST, mo...@mellanox.com wrote:
>Add devlink reload action to allow the user to request a specific reload
>action. The action parameter is optional, if not specified then devlink
>driver re-init action is used (backward compatible).
>Note that when required to do fir
h1 is initially configured to reach h2 via r1 rather than the
more direct path through r2. If rp_filter is set and inherited
for r2, forwarding fails since the source address of h1 is
reachable from eth0 vs the packet coming to it via r1 and eth1.
Since rp_filter setting affects the test, explicitl
Link: https://lore.kernel.org/netdev/20200721083300.GA12970@laureti-dev/
Signed-off-by: Helmut Grohne
---
drivers/net/dsa/microchip/ksz_common.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/dsa/microchip/ksz_common.h
b/drivers/net/dsa/microchip/ksz_common.h
index 0120f2b72091..
Link: https://lore.kernel.org/netdev/20200721083300.GA12970@laureti-dev/
Signed-off-by: Helmut Grohne
---
drivers/net/dsa/microchip/ksz_common.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/dsa/microchip/ksz_common.h
b/drivers/net/dsa/microchip/ksz_common.h
index 1791442f04ee..
Link: https://lore.kernel.org/netdev/20200721083300.GA12970@laureti-dev/
Signed-off-by: Helmut Grohne
---
drivers/net/dsa/microchip/ksz_common.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/dsa/microchip/ksz_common.h
b/drivers/net/dsa/microchip/ksz_common.h
index 83247140b784..
Andrew Lunn asked me to turn my dead code removal RFC patch into a real
one splitting it per member. This is what this v2 series does. Some
parts of the RFC patch are already applied via:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b20a6b29a811bee0e44b64958d415eb50
Link: https://lore.kernel.org/netdev/20200721083300.GA12970@laureti-dev/
Signed-off-by: Helmut Grohne
---
drivers/net/dsa/microchip/ksz8795.c| 1 -
drivers/net/dsa/microchip/ksz9477.c| 8 +---
drivers/net/dsa/microchip/ksz_common.h | 1 -
3 files changed, 1 insertion(+), 9 deletions(-
Link: https://lore.kernel.org/netdev/20200721083300.GA12970@laureti-dev/
Signed-off-by: Helmut Grohne
---
drivers/net/dsa/microchip/ksz9477.c| 2 --
drivers/net/dsa/microchip/ksz_common.h | 1 -
2 files changed, 3 deletions(-)
diff --git a/drivers/net/dsa/microchip/ksz9477.c
b/drivers/net/d
Link: https://lore.kernel.org/netdev/20200721083300.GA12970@laureti-dev/
Signed-off-by: Helmut Grohne
---
drivers/net/dsa/microchip/ksz8795.c| 1 -
drivers/net/dsa/microchip/ksz_common.h | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/net/dsa/microchip/ksz8795.c
b/drivers/net/ds
On Mon, Aug 17, 2020 at 03:17:37PM +0200, Sven Eckelmann wrote:
> On Monday, 17 August 2020 10:39:00 CEST Bjørn Mork wrote:
> > Linus Lüssing writes:
> [...]
> > This is not a bug. They are deliberately breaking IPv6 because they
> > consider this a feature. You should not try to work around suc
On Wed, Aug 5, 2020 at 1:27 AM Willem de Bruijn
wrote:
>
> On Tue, Aug 4, 2020 at 5:57 PM Tom Herbert wrote:
> >
> > The definition for symmetric keys does not include the flow label so
> > that when symmetric keys is used a non-zero IPv6 flow label is not
> > extracted. Symmetric keys are used i
On Mon, Aug 17, 2020 at 11:22:23AM -0300, Marcelo Ricardo Leitner wrote:
> On Sat, Aug 15, 2020 at 02:49:31PM +, David Laight wrote:
> > From: David Laight
> > > Sent: 14 August 2020 17:18
> > >
> > > > > > At some point the negotiation of the number of SCTP streams
> > > > > > seems to have g
> +static int mlxsw_sp1_nve_vxlan_metrics_init(struct mlxsw_sp *mlxsw_sp)
> +{
> + struct mlxsw_sp_nve_metrics *metrics = &mlxsw_sp->nve->metrics;
> + struct devlink *devlink = priv_to_devlink(mlxsw_sp->core);
> + int err;
> +
> + err = mlxsw_sp1_nve_vxlan_counters_clear(mlxsw_sp);
Tang Bin writes:
> In the function ath10k_ahb_clock_init(), devm_clk_get() doesn't
> return NULL. Thus use IS_ERR() and PTR_ERR() to validate
> the returned value instead of IS_ERR_OR_NULL().
Why? What's the benefit of this patch? Or what harm does
IS_ERR_OR_NULL() create?
> Signed-off-by: Zhan
On Sat, Aug 15, 2020 at 02:49:31PM +, David Laight wrote:
> From: David Laight
> > Sent: 14 August 2020 17:18
> >
> > > > > At some point the negotiation of the number of SCTP streams
> > > > > seems to have got broken.
> > > > > I've definitely tested it in the past (probably 10 years ago!)
>
On Mon, Aug 17, 2020 at 01:54:30PM +0530, Allen Pais wrote:
> In preparation for unconditionally passing the
> struct tasklet_struct pointer to all tasklet
> callbacks, switch to using the new tasklet_setup()
> and from_tasklet() to pass the tasklet pointer explicitly.
>
> Signed-off-by: Romain Pe
On Mon, Aug 17, 2020 at 03:50:54PM +0300, Ido Schimmel wrote:
> From: Ido Schimmel
>
> Add an infrastructure that allows device drivers to dynamically register
> and unregister their supported metrics with devlink. The metrics and
> their values are exposed to user space which can decide to group
On Tue, Jul 21, 2020 at 10:46 PM Daniel Borkmann wrote:
>
> On 7/20/20 3:53 PM, Magnus Karlsson wrote:
> > In the skb Tx path, transmission of a packet is performed with
> > dev_direct_xmit(). When QUEUE_STATE_FROZEN is set in the transmit
> > routines, it returns NETDEV_TX_BUSY signifying that it
On Thu, Aug 13, 2020 at 04:24:04PM +0200, Sabrina Dubroca wrote:
> Xiumei reported a bug with espintcp over IPv6 in transport mode,
> because xfrm6_transport_finish expects to find IP6CB data (struct
> inet6_skb_cb). Currently, espintcp zeroes the CB, but the relevant
> part is actually preserved b
Remote source MAC addresses can be set on a 'source mode' macvlan
interface via the IFLA_MACVLAN_MACADDR_DATA attribute. This commit
tightens the validation of these MAC addresses to match the validation
already performed when setting or adding a single MAC address via the
IFLA_MACVLAN_MACADDR attr
On 8/17/20 2:15 AM, Allen Pais wrote:
> From: Allen Pais
>
> In preparation for unconditionally passing the
> struct tasklet_struct pointer to all tasklet
> callbacks, switch to using the new tasklet_setup()
> and from_tasklet() to pass the tasklet pointer explicitly.
Who came up with the idea t
1 - 100 of 276 matches
Mail list logo
