[PATCH ethtool v3 1/2] ethtool: add support for get/set ethtool_tunable

2020-07-19 Thread Govindarajulu Varadarajan
Add support for ETHTOOL_GTUNABLE and ETHTOOL_STUNABLE options. Tested rx-copybreak on enic driver. Tested ETHTOOL_TUNABLE_STRING options with test/debug changes in kernel. Signed-off-by: Govindarajulu Varadarajan --- v3: * Remove handling of string type tunables v2: * Fix alignments and braces.

[PATCH ethtool v3 2/2] man: add man page for ETHTOOL_GTUNABLE and ETHTOOL_STUNABLE

2020-07-19 Thread Govindarajulu Varadarajan
Signed-off-by: Govindarajulu Varadarajan --- v3: Document special values 0 (disabled) and 65535 (auto) for pfc-prevention-tout. v2: Add description ethtool.8.in | 40 1 file changed, 40 insertions(+) diff --git a/ethtool.8.in b/ethtool.8.in index 689822

Re: [PATCH net-next v2] net: ena: Fix using plain integer as NULL pointer in ena_init_napi_in_range

2020-07-19 Thread Shay Agroskin
Joe Perches writes: On Mon, 2020-07-20 at 10:53 +0800, Wang Hai wrote: Fix sparse build warning: drivers/net/ethernet/amazon/ena/ena_netdev.c:2193:34: warning: Using plain integer as NULL pointer [] diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/e

Re: [PATCH net-next 0/4] cxgb4: add ethtool self_test support

2020-07-19 Thread Vishal Kulkarni
On Friday, July 07/17/20, 2020 at 20:02:51 +0200, Andrew Lunn wrote: > On Fri, Jul 17, 2020 at 07:17:55PM +0530, Vishal Kulkarni wrote: > > This series of patches add support for below tests. > > 1. Adapter status test > > 2. Link test > > 3. Link speed test > > 4. Loopback test > > Hi Vishal > >

[PATCH] net: hns: use eth_broadcast_addr() to assign broadcast address

2020-07-19 Thread Xu Wang
This patch is to use eth_broadcast_addr() to assign broadcast address insetad of memset(). Signed-off-by: Xu Wang --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c b/drive

Re: [PATCH v2] libbpf bpf_helpers: Use __builtin_offsetof for offsetof

2020-07-19 Thread Andrii Nakryiko
On Sun, Jul 19, 2020 at 11:18 PM Ian Rogers wrote: > > The non-builtin route for offsetof has a dependency on size_t from > stdlib.h/stdint.h that is undeclared and may break targets. > The offsetof macro in bpf_helpers may disable the same macro in other > headers that have a #ifdef offsetof guar

Re: [PATCH] net: genetlink: Move initialization to core_initcall

2020-07-19 Thread Amit Kucheria
On Wed, Jul 15, 2020 at 1:11 PM Daniel Lezcano wrote: > > The generic netlink is initialized far after the netlink protocol > itself at subsys_initcall. The devlink is initialized at the same > level, but after, as shown by a disassembly of the vmlinux: > > [ ... ] > 374 8000115f22c0 <__initca

Re: [RFC PATCH bpf-next 2/2] selftests/bpf: Test __ksym externs with BTF

2020-07-19 Thread Andrii Nakryiko
On Wed, Jul 15, 2020 at 2:46 PM Hao Luo wrote: > > Extend ksyms.c selftest to make sure BTF enables direct loads of ksyms. > > Note that test is done against the kernel btf extended with kernel VARs. > > Signed-off-by: Hao Luo > --- > tools/testing/selftests/bpf/prog_tests/ksyms.c | 2 ++ > too

Re: [RFC PATCH bpf-next 1/2] bpf: BTF support for __ksym externs

2020-07-19 Thread Andrii Nakryiko
On Wed, Jul 15, 2020 at 2:45 PM Hao Luo wrote: > > Previous commits: > > commit 1c0c7074fefd ("libbpf: Add support for extracting kernel symbol > addresses") > commit 2e33efe32e01 ("libbpf: Generalize libbpf externs support") > > have introduced a new type of extern variable ksyms to access ker

Re: [PATCH bpf-next v2 3/6] bpf: support attaching freplace programs to multiple attach points

2020-07-19 Thread Andrii Nakryiko
On Thu, Jul 16, 2020 at 7:06 PM Alexei Starovoitov wrote: > > On Thu, Jul 16, 2020 at 12:50:05PM +0200, Toke Høiland-Jørgensen wrote: > > Alexei Starovoitov writes: > > > > > On Wed, Jul 15, 2020 at 03:09:02PM +0200, Toke Høiland-Jørgensen > > > wrote: > > >> > > >> + if (tgt_prog_fd) { >

Re: [PATCH for v5.9] RDS: Replace HTTP links with HTTPS ones

2020-07-19 Thread Leon Romanovsky
On Sun, Jul 19, 2020 at 05:58:45PM +0200, Alexander A. Klimov wrote: > Rationale: > Reduces attack surface on kernel devs opening the links for MITM > as HTTPS traffic is much harder to manipulate. > > Deterministic algorithm: > For each file: > If not .svg: > For each line: > If doesn'

Re: [PATCH V2 2/6] kvm: detect assigned device via irqbypass manager

2020-07-19 Thread Jason Wang
On 2020/7/18 上午2:08, Alex Williamson wrote: On Thu, 16 Jul 2020 19:23:45 +0800 Zhu Lingshan wrote: vDPA devices has dedicated backed hardware like passthrough-ed devices. Then it is possible to setup irq offloading to vCPU for vDPA devices. Thus this patch tries to manipulated assigned devic

[PATCH net-next v2 4/4] net: dsa: Setup dsa_netdev_ops

2020-07-19 Thread Florian Fainelli
Now that we have all the infrastructure in place for calling into the dsa_ptr->netdev_ops function pointers, install them when we configure the DSA CPU/management interface and tear them down. The flow is unchanged from before, but now we preserve equality of tests when network device drivers do te

[PATCH net-next v2 2/4] net: dsa: Add wrappers for overloaded ndo_ops

2020-07-19 Thread Florian Fainelli
Add definitions for the dsa_netdevice_ops structure which is a subset of the net_device_ops structure for the specific operations that we care about overlaying on top of the DSA CPU port net_device and provide inline stubs that take core managing whether DSA code is reachable. Signed-off-by: Flori

[PATCH net-next v2 0/4] net: dsa: Setup dsa_netdev_ops

2020-07-19 Thread Florian Fainelli
Hi David, Jakub, This patch series addresses the overloading of a DSA CPU/management interface's netdev_ops for the purpose of providing useful information from the switch side. Up until now we had duplicated the existing netdev_ops structure and added specific function pointers to return informa

[PATCH net-next v2 3/4] net: Call into DSA netdevice_ops wrappers

2020-07-19 Thread Florian Fainelli
Make the core net_device code call into our ndo_do_ioctl() and ndo_get_phys_port_name() functions via the wrappers defined previously Signed-off-by: Florian Fainelli --- net/core/dev.c | 5 + net/core/dev_ioctl.c | 5 + 2 files changed, 10 insertions(+) diff --git a/net/core/dev.c

[PATCH net-next v2 1/4] net: Wrap ndo_do_ioctl() to prepare for DSA stacked ops

2020-07-19 Thread Florian Fainelli
In preparation for adding another layer of call into a DSA stacked ops singleton, wrap the ndo_do_ioctl() call into dev_do_ioctl(). Reviewed-by: Andrew Lunn Signed-off-by: Florian Fainelli --- net/core/dev_ioctl.c | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-)

[PATCH] Fix memory overwriting issue when copy an address to user space

2020-07-19 Thread lebon zhou
When application provided buffer size less than sockaddr_storage, then kernel will overwrite some memory area which may cause memory corruption, e.g.: in recvmsg case, let msg_name=malloc(8) and msg_namelen=8, then usually application can call recvmsg successful but actually application memory get

[PATCH] net: vxge-main: Remove unnecessary cast in kfree()

2020-07-19 Thread Xu Wang
Remove unnecassary casts in the argument to kfree. Signed-off-by: Xu Wang --- drivers/net/ethernet/neterion/vxge/vxge-main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/neterion/vxge/vxge-main.c b/drivers/net/ethernet/neterion/vxge/vxge-main.c in

Re: [PATCH net-next 1/3] udp_tunnel: allow to turn off path mtu discovery on encap sockets

2020-07-19 Thread David Ahern
On 7/19/20 3:49 PM, Stefano Brivio wrote: >> >> With this test case, the lookup fails: >> >> [ 144.689378] vxlan: vxlan_xmit_one: dev vxlan_a 10.0.1.1/57864 -> >> 10.0.0.0/4789 len 5010 gw 10.0.1.2 >> [ 144.692755] vxlan: skb_tunnel_check_pmtu: dst dev br0 skb dev vxlan_a >> skb len 5010 encap_mt

Re: [PATCH net-next v2] net: ena: Fix using plain integer as NULL pointer in ena_init_napi_in_range

2020-07-19 Thread Joe Perches
On Mon, 2020-07-20 at 10:53 +0800, Wang Hai wrote: > Fix sparse build warning: > > drivers/net/ethernet/amazon/ena/ena_netdev.c:2193:34: warning: > Using plain integer as NULL pointer [] > diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c > b/drivers/net/ethernet/amazon/ena/ena_netdev.c

[PATCH net-next v2] net: ena: Fix using plain integer as NULL pointer in ena_init_napi_in_range

2020-07-19 Thread Wang Hai
Fix sparse build warning: drivers/net/ethernet/amazon/ena/ena_netdev.c:2193:34: warning: Using plain integer as NULL pointer Reported-by: Hulk Robot Signed-off-by: Wang Hai Suggested-by: Joe Perches Acked-by: Shay Agroskin --- v1->v2: Improve code readability based on Joe Perches's suggesti

Re: [PATCH v2 net-next 0/3] Fully describe the waveform for PTP periodic output

2020-07-19 Thread David Miller
From: Vladimir Oltean Date: Fri, 17 Jul 2020 01:45:28 +0300 > While using the ancillary pin functionality of PTP hardware clocks to > synchronize multiple DSA switches on a board, a need arised to be able > to configure the duty cycle of the master of this PPS hierarchy. > > Also, the PPS master

Re: [PATCH net-next v2] icmp: support rfc 4884

2020-07-19 Thread David Miller
From: Willem de Bruijn Date: Fri, 10 Jul 2020 09:29:02 -0400 > From: Willem de Bruijn > > Add setsockopt SOL_IP/IP_RECVERR_4884 to return the offset to an > extension struct if present. > > ICMP messages may include an extension structure after the original > datagram. RFC 4884 standardized th

[PATCH v2] net: neterion: vxge: reduce stack usage in VXGE_COMPLETE_VPATH_TX

2020-07-19 Thread Bixuan Cui
Fix the warning: [-Werror=-Wframe-larger-than=] drivers/net/ethernet/neterion/vxge/vxge-main.c: In function'VXGE_COMPLETE_VPATH_TX.isra.37': drivers/net/ethernet/neterion/vxge/vxge-main.c:119:1: warning: the frame size of 1056 bytes is larger than 1024 bytes Dropping the NR_SKB_COMPLETED to 16 is

Re: [PATCH] net: neterion: vxge: reduce stack usage in VXGE_COMPLETE_VPATH_TX

2020-07-19 Thread Bixuan Cui
On 2020/7/20 1:05, Stephen Hemminger wrote: > On Thu, 16 Jul 2020 17:32:47 + > Bixuan Cui wrote: > >> Fix the warning: [-Werror=-Wframe-larger-than=] >> >> drivers/net/ethernet/neterion/vxge/vxge-main.c: >> In function'VXGE_COMPLETE_VPATH_TX.isra.37': >> drivers/net/ethernet/neterion/vxge/

Re: [PATCH net-next] tcp: Optimize the recovery of tcp when lack of SACK

2020-07-19 Thread hujunwei
On 2020/7/19 11:29, Neal Cardwell wrote: > On Sat, Jul 18, 2020 at 6:43 AM hujunwei wrote: >> >> >> On 2020/7/17 22:44, Neal Cardwell wrote: >>> On Fri, Jul 17, 2020 at 7:43 AM hujunwei wrote: From: Junwei Hu In the document of RFC2582(https://tools.ietf.org/html/rfc2582)

RE: [PATCH/RFC] net: ethernet: ravb: Try to wake subqueue instead of stop on timeout

2020-07-19 Thread Yoshihiro Shimoda
Hello! > From: Sergei Shtylyov, Sent: Monday, July 20, 2020 4:20 AM > > Hello! > >Sorry about another late reply, was having h/w issues on the new work... No problem! :) Thank you for your reply! > On 07/06/2020 12:25 PM, Yoshihiro Shimoda wrote: > >> Maybe we should just fix those bl

Re: [PATCH -next] net: ena: use NULL instead of zero

2020-07-19 Thread wanghai (M)
在 2020/7/18 23:06, Joe Perches 写道: On Sat, 2020-07-18 at 19:56 +0800, Wang Hai wrote: Fix sparse build warning: drivers/net/ethernet/amazon/ena/ena_netdev.c:2193:34: warning: Using plain integer as NULL pointer Better to remove the initialization altogether and move the declaration into th

Re: amplifying qdisc

2020-07-19 Thread Russell Strong
On Mon, 13 Jul 2020 09:52:28 -0700 Stephen Hemminger wrote: > On Sun, 12 Jul 2020 11:40:01 +1000 > Russell Strong wrote: > > > On Wed, 8 Jul 2020 23:26:34 -0700 > > Stephen Hemminger wrote: > > > > > On Thu, 9 Jul 2020 16:10:34 +1000 > > > Russell Strong wrote: > > > > > > > Hi, > > >

[PATCH] net: ag71xx: add missed clk_disable_unprepare in error path of probe

2020-07-19 Thread Huang Guobin
The ag71xx_mdio_probe() forgets to call clk_disable_unprepare() when of_reset_control_get_exclusive() failed. Add the missed call to fix it. Fixes: d51b6ce441d3 ("net: ethernet: add ag71xx driver") Reported-by: Hulk Robot Signed-off-by: Huang Guobin --- drivers/net/ethernet/atheros/ag71xx.c | 3

Re: [PATCH v2 net-next 0/6] rework mvneta napi_poll loop for XDP multi-buffers

2020-07-19 Thread David Miller
From: Lorenzo Bianconi Date: Fri, 17 Jul 2020 00:16:28 +0200 > Rework mvneta_rx_swbm routine in order to process all rx descriptors before > building the skb or run the xdp program attached to the interface. > Introduce xdp_get_shared_info_from_{buff,frame} utility routines to get the > skb_share

Re: do a single memdup_user in sctp_setsockopt v2

2020-07-19 Thread David Miller
From: Christoph Hellwig Date: Sun, 19 Jul 2020 09:21:37 +0200 > here is a resend of my series to lift the copy_from_user out of the > individual sctp sockopt handlers into the main sctp_setsockopt > routine. > > Changes since v1: > - fixes a few sizeof calls. > - use memzero_explicit in sctp_s

Re: sockopt cleanups

2020-07-19 Thread David Miller
From: Christoph Hellwig Date: Fri, 17 Jul 2020 08:23:09 +0200 > this series cleans up various lose ends in the sockopt code, most > importantly removing the compat_{get,set}sockopt infrastructure in favor > of just using in_compat_syscall() in the few places that care. Series applied to net-next

Re: [PATCH] net: rds: rdma_transport.h: delete duplicated word

2020-07-19 Thread David Miller
From: Randy Dunlap Date: Sun, 19 Jul 2020 11:08:24 -0700 > Delete the doubled word "be" in a comment. > > Signed-off-by: Randy Dunlap Applied.

Re: [PATCH] net: atm: lec_arpc.h: delete duplicated word

2020-07-19 Thread David Miller
From: Randy Dunlap Date: Sun, 19 Jul 2020 11:08:01 -0700 > Delete the doubled word "the" in a comment. > > Signed-off-by: Randy Dunlap Applied to net-next.

Re: [PATCH net v2] bonding: check error value of register_netdevice() immediately

2020-07-19 Thread David Miller
From: Taehee Yoo Date: Sun, 19 Jul 2020 12:11:24 + > If register_netdevice() is failed, net_device should not be used > because variables are uninitialized or freed. > So, the routine should be stopped immediately. > But, bond_create() doesn't check return value of register_netdevice() > imme

Re: [PATCH net] arm64: dts: clearfog-gt-8k: fix switch link configuration

2020-07-19 Thread David Miller
From: Russell King Date: Sun, 19 Jul 2020 12:00:40 +0100 > The commit below caused a regression for clearfog-gt-8k, where the link > between the switch and the host does not come up. > > Investigation revealed two issues: > - MV88E6xxx DSA no longer allows an in-band link to come up as the link

Re: [PATCH net] net: dsa: mv88e6xxx: fix in-band AN link establishment

2020-07-19 Thread David Miller
From: Russell King Date: Sun, 19 Jul 2020 12:00:35 +0100 > If in-band negotiation or fixed-link modes are specified for a DSA > port, the DSA code will force the link down during initialisation. For > fixed-link mode, this is fine, as phylink will manage the link state. > However, for in-band mod

Re: [PATCH net-next v1] net: phy: at803x: add mdix configuration support for AR9331 and AR8035

2020-07-19 Thread David Miller
From: Oleksij Rempel Date: Sun, 19 Jul 2020 10:05:30 +0200 > This patch add MDIX configuration ability for AR9331 and AR8035. Theoretically > it should work on other Atheros PHYs, but I was able to test only this > two. > > Since I have no certified reference HW able to detect or configure MDIX,

Re: [PATCH net-next v7 0/4] net: enetc: remove bootloader dependency

2020-07-19 Thread David Miller
From: Michael Walle Date: Mon, 20 Jul 2020 00:03:32 +0200 > These patches were picked from the following series: > https://lore.kernel.org/netdev/1567779344-30965-1-git-send-email-claudiu.man...@nxp.com/ > They have never been resent. I've picked them up, addressed Andrews > comments, fixed some

Re: [PATCH -next] hsr: Convert to DEFINE_SHOW_ATTRIBUTE

2020-07-19 Thread miaoqinglang
在 2020/7/18 3:46, David Miller 写道: From: Qinglang Miao Date: Thu, 16 Jul 2020 16:47:28 +0800 Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Qinglang Miao This does not apply to the net-next tree. . Hi David, I'm sorry but​ this patch is based on linux-next rathe

Re: [PATCH ethtool] Fix segfault with cable test and ./configure --disable-netlink

2020-07-19 Thread Andrew Lunn
On Mon, Jul 20, 2020 at 02:12:51AM +0200, Michal Kubecek wrote: > On Fri, Jul 17, 2020 at 12:05:09AM +0200, Andrew Lunn wrote: > > When the netlink interface code is disabled, a stub version of > > netlink_run_handler() is used. This stub version needs to handle the > > case when there is no possib

Re: KMSAN: uninit-value in __skb_checksum_complete (4)

2020-07-19 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:14525656 compiler.h: reinstate missing KMSAN_INIT git tree: https://github.com/google/kmsan.git master console output: https://syzkaller.appspot.com/x/log.txt?x=16a7c82710 kernel config: https://syzkaller.appspot.

Re: [PATCH ethtool] Fix segfault with cable test and ./configure --disable-netlink

2020-07-19 Thread Michal Kubecek
On Fri, Jul 17, 2020 at 12:05:09AM +0200, Andrew Lunn wrote: > When the netlink interface code is disabled, a stub version of > netlink_run_handler() is used. This stub version needs to handle the > case when there is no possibility for a command to fall back to the > IOCTL call. The two cable test

Re: [PATCH v2 bpf-next 4/4] bpf: Add kernel module with user mode driver that populates bpffs.

2020-07-19 Thread kernel test robot
Hi Alexei, I love your patch! Yet something to improve: [auto build test ERROR on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Alexei-Starovoitov/bpf-Populate-bpffs-with-map-and-prog-iterators/20200717-124311 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-n

Re: [PATCH ethtool 0/4] Add support for IGC driver

2020-07-19 Thread Michal Kubecek
On Tue, Jul 07, 2020 at 04:47:56PM -0700, Andre Guedes wrote: > Hi all, > > This patch series adds support for parsing registers dumped by the IGC driver. > For now, the following registers are parsed: > > * Receive Address Low (RAL) > * Receive Address High (RAH) > * Receive Co

Re: [PATCH ethtool v2 2/2] man: add man page for ETHTOOL_GTUNABLE and ETHTOOL_STUNABLE

2020-07-19 Thread Michal Kubecek
On Fri, Jul 17, 2020 at 07:59:50AM -0700, Govindarajulu Varadarajan wrote: > Signed-off-by: Govindarajulu Varadarajan > --- > v2: > Add description > > ethtool.8.in | 40 > 1 file changed, 40 insertions(+) > > diff --git a/ethtool.8.in b/ethtool.8.in > i

Re: [PATCH ethtool v2 1/2] ethtool: add support for get/set ethtool_tunable

2020-07-19 Thread Michal Kubecek
On Fri, Jul 17, 2020 at 07:59:49AM -0700, Govindarajulu Varadarajan wrote: > Add support for ETHTOOL_GTUNABLE and ETHTOOL_STUNABLE options. > > Tested rx-copybreak on enic driver. Tested ETHTOOL_TUNNABLE_STRING A typo: TUNNABLE -> TUNABLE > options with test/debug changes in kernel. > > Signed-

Re: BUG: soft lockup in __do_sys_clock_adjtime

2020-07-19 Thread syzbot
syzbot has bisected this issue to: commit 5a781ccbd19e4664babcbe4b4ead7aa2b9283d22 Author: Vinicius Costa Gomes Date: Sat Sep 29 00:59:43 2018 + tc: Add support for configuring the taprio scheduler bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=13cb847f10 start commi

Re: [PATCH net v2 00/10] net/smc: fixes 2020-07-16

2020-07-19 Thread David Miller
From: Karsten Graul Date: Sat, 18 Jul 2020 15:06:08 +0200 > Please apply the following patch series for smc to netdev's net tree. > > The patches address problems caused by late or unexpected link layer > control packets, dma sync calls for unmapped memory, freed buffers > that are not removed f

[PATCH RFC net-next] net: phy: add constant for USXGMII bit 0

2020-07-19 Thread Michael Walle
Add the last missing constant of the USXGMII UsxgmiiChannelInfo field. Unfortunately, there is no meaningful name in the USXGMII Singleport Copper Interface specification. The specification just describe that it has to be set to 1. The corresponding SGMII macros has two different defines, ADVERTISE

Re: [PATCH for v5.9] sch_cake: Replace HTTP links with HTTPS ones

2020-07-19 Thread David Miller
Please don't do this "for v5.9" stuff. There is no precendence for this and it looks like -stable patch series to just about anyone. There are well defined, established, ways to write Subject lines for proper patch submissions. Please do not invent your own way of doing this. It is very frust

[PATCH net-next v7 0/4] net: enetc: remove bootloader dependency

2020-07-19 Thread Michael Walle
These patches were picked from the following series: https://lore.kernel.org/netdev/1567779344-30965-1-git-send-email-claudiu.man...@nxp.com/ They have never been resent. I've picked them up, addressed Andrews comments, fixed some more bugs and asked Claudiu if I can keep their SOB tags; he agreed.

[PATCH net-next v7 3/4] net: enetc: Initialize SerDes for SGMII and USXGMII protocols

2020-07-19 Thread Michael Walle
ENETC has ethernet MACs capable of SGMII, 2500BaseX and USXGMII. But in order to use these protocols some SerDes configurations need to be performed. The SerDes is configurable via an internal PCS PHY which is connected to an internal MDIO bus at address 0. This patch basically removes the depende

[PATCH net-next v7 1/4] net: phy: add USXGMII link partner ability constants

2020-07-19 Thread Michael Walle
The constants are taken from the USXGMII Singleport Copper Interface specification. The naming are based on the SGMII ones, but with an MDIO_ prefix. Signed-off-by: Michael Walle Reviewed-by: Russell King --- include/uapi/linux/mdio.h | 26 ++ 1 file changed, 26 insertio

[PATCH net-next v7 2/4] net: dsa: felix: (re)use already existing constants

2020-07-19 Thread Michael Walle
Now that there are USXGMII constants available, drop the old definitions and reuse the generic ones. Signed-off-by: Michael Walle Tested-by: Vladimir Oltean --- drivers/net/dsa/ocelot/felix_vsc9959.c | 45 +++--- 1 file changed, 12 insertions(+), 33 deletions(-) diff --git

[PATCH net-next v7 4/4] net: enetc: Use DT protocol information to set up the ports

2020-07-19 Thread Michael Walle
From: Alex Marginean Use DT information rather than in-band information from bootloader to set up MAC for XGMII. For RGMII use the DT indication in addition to RGMII defaults in hardware. However, this implies that PHY connection information needs to be extracted before netdevice creation, when t

Re: bug: net: dsa: mv88e6xxx: serdes Unable to communicate on fiber with vf610-zii-dev-rev-c

2020-07-19 Thread Marek Behun
On Sun, 19 Jul 2020 14:43:49 -0700 Chris Healy wrote: > > Hmm. > > > > What about the errata setup? > > It says: > > /* The 6390 copper ports have an errata which require poking magic > > * values into undocumented hidden registers and then performing a > > * software reset. > > */ > > But the

Re: [PATCH net-next 1/3] udp_tunnel: allow to turn off path mtu discovery on encap sockets

2020-07-19 Thread Stefano Brivio
On Sun, 19 Jul 2020 12:43:55 -0600 David Ahern wrote: > On 7/18/20 11:58 AM, Stefano Brivio wrote: > > On Sat, 18 Jul 2020 11:02:46 -0600 > > David Ahern wrote: > > > >> On 7/18/20 12:56 AM, Stefano Brivio wrote: > >>> On Fri, 17 Jul 2020 09:04:51 -0600 > >>> David Ahern wrote: > >>>

Re: bug: net: dsa: mv88e6xxx: serdes Unable to communicate on fiber with vf610-zii-dev-rev-c

2020-07-19 Thread Chris Healy
On Sat, Jul 18, 2020 at 8:22 AM Marek Behun wrote: > > On Sat, 18 Jul 2020 17:05:14 +0200 > Andrew Lunn wrote: > > > > If the traces were broken between the fiber module and the SERDES, I > > > should not see these counters incrementing. > > > > Plus it is reproducible on multiple boards, of diff

Re: [PATCH v2 net-next 01/14] qed: convert link mode from u32 to bitmap

2020-07-19 Thread Andrew Lunn
On Sun, Jul 19, 2020 at 11:14:40PM +0300, Alexander Lobakin wrote: > Currently qed driver already ran out of 32 bits to store link modes, > and this doesn't allow to add and support more speeds. > Convert link mode to bitmap that will always have enough space for > any number of speeds and modes.

Re: [PATCH] ethtool: dsa: mv88e6xxx: add pretty dump for 88E6352 SERDES

2020-07-19 Thread Michal Kubecek
On Thu, Jul 16, 2020 at 10:55:26AM -0700, Chris Healy wrote: > From: Andrew Lunn > > In addition to the port registers, the device can provide the > SERDES/PCS registers. Dump these, and for a few of the important > SGMII/1000Base-X registers decode the bits. > > Signed-off-by: Andrew Lunn > Si

[PATCH for v5.9] sctp: Replace HTTP links with HTTPS ones

2020-07-19 Thread Alexander A. Klimov
Rationale: Reduces attack surface on kernel devs opening the links for MITM as HTTPS traffic is much harder to manipulate. Deterministic algorithm: For each file: If not .svg: For each line: If doesn't contain `\bxmlns\b`: For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:

[PATCH v2 net-next 08/14] qede: introduce support for FEC control

2020-07-19 Thread Alexander Lobakin
Add Ethtool callbacks for querying and setting FEC parameters if it's supported by the underlying qed module and MFW version running on the device. Signed-off-by: Alexander Lobakin Signed-off-by: Igor Russkikh --- .../net/ethernet/qlogic/qede/qede_ethtool.c | 74 +++ 1 file ch

[PATCH for v5.9] rxrpc: Replace HTTP links with HTTPS ones

2020-07-19 Thread Alexander A. Klimov
Rationale: Reduces attack surface on kernel devs opening the links for MITM as HTTPS traffic is much harder to manipulate. Deterministic algorithm: For each file: If not .svg: For each line: If doesn't contain `\bxmlns\b`: For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:

[PATCH v2 net-next 13/14] qed: populate supported link modes maps on module init

2020-07-19 Thread Alexander Lobakin
Simplify and lighten qed_set_link() by declaring static link modes maps and populating them on module init. This way we save plenty of text size at the low expense of __ro_after_init and __initconst data (the latter will be purged after module init is done). Misc: sanitize exit callback. Signed-o

[PATCH v2 net-next 14/14] qed/qede: add support for the extended speed and FEC modes

2020-07-19 Thread Alexander Lobakin
Add all necessary code (NVM parsing, MFW and Ethtool reports etc.) to support extended speed and FEC modes. These new modes are supported by the new boards revisions and newer MFW versions. Misc: correct port type for MEDIA_KR. Signed-off-by: Alexander Lobakin Signed-off-by: Igor Russkikh ---

[PATCH v2 net-next 09/14] qed: reformat several structures a bit

2020-07-19 Thread Alexander Lobakin
Reformat a few nvm_cfg* structures (and partly qed_dev) prior to adding new fields and definitions. Signed-off-by: Alexander Lobakin Signed-off-by: Igor Russkikh --- drivers/net/ethernet/qlogic/qed/qed.h | 109 +++ drivers/net/ethernet/qlogic/qed/qed_hsi.h | 345 +++---

[PATCH v2 net-next 12/14] qed: add missing loopback modes

2020-07-19 Thread Alexander Lobakin
These modes are relevant only for several boards, but may be reported by MFW as well as the others. Signed-off-by: Alexander Lobakin Signed-off-by: Igor Russkikh --- drivers/net/ethernet/qlogic/qed/qed_hsi.h | 5 + drivers/net/ethernet/qlogic/qed/qed_main.c | 19 +++ inclu

[PATCH v2 net-next 10/14] qed: remove unused qed_hw_info::port_mode and QED_PORT_MODE

2020-07-19 Thread Alexander Lobakin
Struct field qed_hw_info::port_mode isn't used anywhere in the code, so can be safely removed to prevent possible dead code addition. Also remove the enumeration QED_PORT_MODE orphaned after this deletion. Signed-off-by: Alexander Lobakin --- drivers/net/ethernet/qlogic/qed/qed.h | 15 --

[PATCH v2 net-next 11/14] qed: add support for new port modes

2020-07-19 Thread Alexander Lobakin
These ports ship on new boards revisions and are supported by newer firmware versions. Signed-off-by: Alexander Lobakin Signed-off-by: Igor Russkikh --- drivers/net/ethernet/qlogic/qed/qed_dev.c | 5 + drivers/net/ethernet/qlogic/qed/qed_hsi.h | 5 + 2 files changed, 10 insertions(+) d

[PATCH v2 net-next 04/14] qed: use transceiver data to fill link partner's advertising speeds

2020-07-19 Thread Alexander Lobakin
Currently qed driver does not take into consideration transceiver's capabilities when generating link partner's speed advertisement. This leads to e.g. incorrect ethtool link info on 10GbaseT modules. Use transceiver info not only for advertisement and support arrays, but also for link partner's ab

[PATCH v2 net-next 07/14] qede: format qede{,_vf}_ethtool_ops

2020-07-19 Thread Alexander Lobakin
Prior to adding new callbacks, format qede ethtool_ops structs to make declarations more fancy and readable. Signed-off-by: Alexander Lobakin Signed-off-by: Igor Russkikh --- .../net/ethernet/qlogic/qede/qede_ethtool.c | 137 +- 1 file changed, 68 insertions(+), 69 deletions(-

[PATCH v2 net-next 06/14] qed: add support for Forward Error Correction

2020-07-19 Thread Alexander Lobakin
Add all necessary routines for reading supported FEC modes from NVM and querying FEC control to the MFW (if the running version supports it). Signed-off-by: Alexander Lobakin Signed-off-by: Igor Russkikh --- drivers/net/ethernet/qlogic/qed/qed_dev.c | 54 +++--- drivers/net/eth

[PATCH v2 net-next 05/14] qed: reformat several structures a bit

2020-07-19 Thread Alexander Lobakin
Prior to adding new fields and bitfields, reformat the related structures according to the Linux style (spaces to tabs, lowercase hex, indentation etc.). Signed-off-by: Alexander Lobakin Signed-off-by: Igor Russkikh --- drivers/net/ethernet/qlogic/qed/qed_hsi.h | 256 +++--- dri

[PATCH v2 net-next 03/14] qed: add support for multi-rate transceivers

2020-07-19 Thread Alexander Lobakin
Set the corresponding advertised and supported link modes according to the detected transceiver type and device capabilities. Signed-off-by: Alexander Lobakin Signed-off-by: Igor Russkikh --- drivers/net/ethernet/qlogic/qed/qed_hsi.h | 4 + drivers/net/ethernet/qlogic/qed/qed_main.c | 112 ++

[PATCH v2 net-next 02/14] qed: reformat public_port::transceiver_data a bit

2020-07-19 Thread Alexander Lobakin
Prior to adding new bitfields, reformat the existing ones from spaces to tabs, and unify all hex values to lowercase. Signed-off-by: Alexander Lobakin Signed-off-by: Igor Russkikh --- drivers/net/ethernet/qlogic/qed/qed_hsi.h | 108 +++--- 1 file changed, 55 insertions(+), 53 de

[PATCH v2 net-next 01/14] qed: convert link mode from u32 to bitmap

2020-07-19 Thread Alexander Lobakin
Currently qed driver already ran out of 32 bits to store link modes, and this doesn't allow to add and support more speeds. Convert link mode to bitmap that will always have enough space for any number of speeds and modes. This involves changes in qede and qedf as well, as they use definitions fro

[PATCH v2 net-next 00/14] qed/qede: add support for new operating modes

2020-07-19 Thread Alexander Lobakin
This series covers the support for the following: - new port modes; - loopback modes, previously missing; - new speed/link modes; - several FEC modes; - multi-rate transceivers; and also cleans up and optimizes several related parts of code. v2 (from [1]): - added a patch (#0010) that drops

Re: [PATCH/RFC] net: ethernet: ravb: Try to wake subqueue instead of stop on timeout

2020-07-19 Thread Sergei Shtylyov
Hello! Sorry about another late reply, was having h/w issues on the new work... On 07/06/2020 12:25 PM, Yoshihiro Shimoda wrote: > From: Yoshihiro Shimoda, Sent: Tuesday, May 26, 2020 6:47 PM > > According to the report of [1], this driver is possible to cause

Re: [PATCH net-next 1/3] udp_tunnel: allow to turn off path mtu discovery on encap sockets

2020-07-19 Thread David Ahern
On 7/18/20 11:58 AM, Stefano Brivio wrote: > On Sat, 18 Jul 2020 11:02:46 -0600 > David Ahern wrote: > >> On 7/18/20 12:56 AM, Stefano Brivio wrote: >>> On Fri, 17 Jul 2020 09:04:51 -0600 >>> David Ahern wrote: >>> On 7/17/20 6:27 AM, Stefano Brivio wrote: >> >>> Note that

[PATCH] net: rds: rdma_transport.h: delete duplicated word

2020-07-19 Thread Randy Dunlap
Delete the doubled word "be" in a comment. Signed-off-by: Randy Dunlap Cc: Santosh Shilimkar Cc: netdev@vger.kernel.org Cc: linux-r...@vger.kernel.org --- net/rds/rdma_transport.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20200717.orig/net/rds/rdma_transport.h +++

[PATCH] net: atm: lec_arpc.h: delete duplicated word

2020-07-19 Thread Randy Dunlap
Delete the doubled word "the" in a comment. Signed-off-by: Randy Dunlap Cc: "David S. Miller" Cc: Jakub Kicinski Cc: netdev@vger.kernel.org --- net/atm/lec_arpc.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20200717.orig/net/atm/lec_arpc.h +++ linux-next-20200717/n

Re: net: decnet: TODO Items

2020-07-19 Thread Suraj Upadhyay
On Sun, Jul 19, 2020 at 10:06:49AM -0700, Stephen Hemminger wrote: > On Fri, 17 Jul 2020 11:48:16 +0530 > Suraj Upadhyay wrote: > > > Hi Maintainers and Developers, > > I am interested in the DECnet TODO list. > > I just need a quick response whether they are worth doing or not > > for the am

Re: INFO: rcu detected stall in sys_clock_settime

2020-07-19 Thread syzbot
syzbot has bisected this issue to: commit 5a781ccbd19e4664babcbe4b4ead7aa2b9283d22 Author: Vinicius Costa Gomes Date: Sat Sep 29 00:59:43 2018 + tc: Add support for configuring the taprio scheduler bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=167142f090 start commi

Re: [PATCH iproute2] tc/m_estimator: Print proper value for estimator interval in raw.

2020-07-19 Thread Stephen Hemminger
On Fri, 17 Jul 2020 11:05:30 -0400 Jamie Gloudon wrote: > While looking at the estimator code, I noticed an incorrect interval > number printed in raw for the handles. This patch fixes the formatting. > > Before patch: > > r...@bytecenter.fr:~# tc -r filter add dev eth0 ingress estimator > 250m

Re: net: decnet: TODO Items

2020-07-19 Thread Stephen Hemminger
On Fri, 17 Jul 2020 11:48:16 +0530 Suraj Upadhyay wrote: > Hi Maintainers and Developers, > I am interested in the DECnet TODO list. > I just need a quick response whether they are worth doing or not > for the amount of development happening in this subsystem is extremely > low and I can't

Re: [PATCH] net: neterion: vxge: reduce stack usage in VXGE_COMPLETE_VPATH_TX

2020-07-19 Thread Stephen Hemminger
On Thu, 16 Jul 2020 17:32:47 + Bixuan Cui wrote: > Fix the warning: [-Werror=-Wframe-larger-than=] > > drivers/net/ethernet/neterion/vxge/vxge-main.c: > In function'VXGE_COMPLETE_VPATH_TX.isra.37': > drivers/net/ethernet/neterion/vxge/vxge-main.c:119:1: > warning: the frame size of 1056 byte

[PATCH for v5.9] ax25: Replace HTTP links with HTTPS ones

2020-07-19 Thread Alexander A. Klimov
Rationale: Reduces attack surface on kernel devs opening the links for MITM as HTTPS traffic is much harder to manipulate. Deterministic algorithm: For each file: If not .svg: For each line: If doesn't contain `\bxmlns\b`: For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:

Re: [PATCH net-next 2/4] net: dsa: Add wrappers for overloaded ndo_ops

2020-07-19 Thread Florian Fainelli
On 7/19/2020 8:40 AM, Andrew Lunn wrote: >> +#if IS_ENABLED(CONFIG_NET_DSA) >> +#define dsa_build_ndo_op(name, arg1_type, arg1_name, arg2_type, arg2_name) \ >> +static int inline dsa_##name(struct net_device *dev, arg1_type arg1_name, \ >> + arg2_type arg2_name) \ >

Re: [PATCH net-next 3/4] net: Call into DSA netdevice_ops wrappers

2020-07-19 Thread Florian Fainelli
On 7/19/2020 9:04 AM, Andrew Lunn wrote: >> If we have the core network stack reference DSA as a module then we >> force DSA to be either built-in or not, which is not very practical, >> people would still want a modular choice to be possible. The static >> inline only wraps indirect function po

Re: [PATCH net-next 3/4] net: Call into DSA netdevice_ops wrappers

2020-07-19 Thread Andrew Lunn
> If we have the core network stack reference DSA as a module then we > force DSA to be either built-in or not, which is not very practical, > people would still want a modular choice to be possible. The static > inline only wraps indirect function pointer calls using definitions > available at bui

[PATCH for v5.9] RDS: Replace HTTP links with HTTPS ones

2020-07-19 Thread Alexander A. Klimov
Rationale: Reduces attack surface on kernel devs opening the links for MITM as HTTPS traffic is much harder to manipulate. Deterministic algorithm: For each file: If not .svg: For each line: If doesn't contain `\bxmlns\b`: For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:

[PATCH bpf-next] bpf: cpumap: fix possible rcpu kthread hung

2020-07-19 Thread Lorenzo Bianconi
Fix the following cpumap kthread hung. The issue is currently occurring when __cpu_map_load_bpf_program fails (e.g if the bpf prog has not BPF_XDP_CPUMAP as expected_attach_type) $./test_progs -n 101 101/1 cpumap_with_progs:OK 101 xdp_cpumap_attach:OK Summary: 1/1 PASSED, 0 SKIPPED, 0 FAILED [ 36

[PATCH for v5.9] Documentation: intel: Replace HTTP links with HTTPS ones

2020-07-19 Thread Alexander A. Klimov
Rationale: Reduces attack surface on kernel devs opening the links for MITM as HTTPS traffic is much harder to manipulate. Deterministic algorithm: For each file: If not .svg: For each line: If doesn't contain `\bxmlns\b`: For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:

Re: [PATCH net-next 2/4] net: dsa: Add wrappers for overloaded ndo_ops

2020-07-19 Thread Andrew Lunn
> +#if IS_ENABLED(CONFIG_NET_DSA) > +#define dsa_build_ndo_op(name, arg1_type, arg1_name, arg2_type, arg2_name) \ > +static int inline dsa_##name(struct net_device *dev, arg1_type arg1_name, \ > + arg2_type arg2_name) \ > +{

Re: [PATCH net-next 1/4] net: Wrap ndo_do_ioctl() to prepare for DSA stacked ops

2020-07-19 Thread Andrew Lunn
On Fri, Jul 17, 2020 at 08:05:30PM -0700, Florian Fainelli wrote: > In preparation for adding another layer of call into a DSA stacked ops > singleton, wrap the ndo_do_ioctl() call into dev_do_ioctl(). > > Signed-off-by: Florian Fainelli Reviewed-by: Andrew Lunn Andrew

Re: [PATCH net] net: dsa: mv88e6xxx: fix in-band AN link establishment

2020-07-19 Thread Andrew Lunn
On Sun, Jul 19, 2020 at 12:00:35PM +0100, Russell King wrote: > If in-band negotiation or fixed-link modes are specified for a DSA > port, the DSA code will force the link down during initialisation. For > fixed-link mode, this is fine, as phylink will manage the link state. > However, for in-band

Re: [PATCH net] arm64: dts: clearfog-gt-8k: fix switch link configuration

2020-07-19 Thread Andrew Lunn
On Sun, Jul 19, 2020 at 12:00:40PM +0100, Russell King wrote: > The commit below caused a regression for clearfog-gt-8k, where the link > between the switch and the host does not come up. > > Investigation revealed two issues: > - MV88E6xxx DSA no longer allows an in-band link to come up as the li

  1   2   >