Re: [PATCH] staging: qlge: Remove pci-dma-compat wrapper APIs.

2020-07-12 Thread Benjamin Poirier
On 2020-07-13 11:14 +0530, Suraj Upadhyay wrote: > On Mon, Jul 13, 2020 at 01:59:59PM +0900, Benjamin Poirier wrote: > > On 2020-07-11 18:16 +0530, Suraj Upadhyay wrote: > > > The legacy API wrappers in include/linux/pci-dma-compat.h > > > should go away as it creates unnecessary midlayering > > >

Re: [PATCH v1 8/8] dt-bindings: net: dsa: Add documentation for Hellcreek switches

2020-07-12 Thread Kurt Kanzenbach
On Sat Jul 11 2020, Florian Fainelli wrote: > On 7/10/2020 4:36 AM, Kurt Kanzenbach wrote: >> Add basic documentation and example. >> >> Signed-off-by: Kurt Kanzenbach >> --- >> .../bindings/net/dsa/hellcreek.yaml | 132 ++ >> 1 file changed, 132 insertions(+) >> creat

Re: [PATCH v1 4/8] net: dsa: hellcreek: Add support for hardware timestamping

2020-07-12 Thread Kurt Kanzenbach
On Sat Jul 11 2020, Richard Cochran wrote: > On Fri, Jul 10, 2020 at 01:36:07PM +0200, Kurt Kanzenbach wrote: >> +static void hellcreek_get_rxts(struct hellcreek *hellcreek, >> + struct hellcreek_port_hwtstamp *ps, >> + struct sk_buff *skb, struct

Re: [PATCH v1 3/8] net: dsa: hellcreek: Add PTP clock support

2020-07-12 Thread Kurt Kanzenbach
On Sat Jul 11 2020, Florian Fainelli wrote: > On 7/10/2020 4:36 AM, Kurt Kanzenbach wrote: >> From: Kamil Alkhouri >> >> The switch has internal PTP hardware clocks. Add support for it. There are >> three >> clocks: >> >> * Synchronized >> * Syntonized >> * Free running >> >> Currently the

Re: [PATCH v1 2/8] net: dsa: Add DSA driver for Hirschmann Hellcreek switches

2020-07-12 Thread Kurt Kanzenbach
On Sat Jul 11 2020, Florian Fainelli wrote: > On 7/10/2020 4:36 AM, Kurt Kanzenbach wrote: >> Add a basic DSA driver for Hirschmann Hellcreek switches. Those switches are >> implementing features needed for Time Sensitive Networking (TSN) such as >> support >> for the Time Precision Protocol and v

Re: [PATCH 1/3] Bluetooth: Add new quirk for broken local ext features max_page

2020-07-12 Thread Marcel Holtmann
Hi Vasily, >>> Some adapters (e.g. RTL8723CS) advertise that they have more than >>> 2 pages for local ext features, but they don't support any features >>> declared in these pages. RTL8723CS reports max_page = 2 and declares >>> support for sync train and secure connection, but it responds with >

Re: [PATCH v3 net-next 3/3] octeontx2-pf: Add support for PTP clock

2020-07-12 Thread sundeep subbaraya
Hi Richard, On Thu, Jul 9, 2020 at 9:32 PM Richard Cochran wrote: > > On Thu, Jul 09, 2020 at 06:57:01PM +0530, sundeep.l...@gmail.com wrote: > > > @@ -1736,6 +1751,143 @@ static void otx2_reset_task(struct work_struct > > *work) > > netif_trans_update(pf->netdev); > > } > > > > +static i

Re: [net-next PATCH v6 4/6] net: phy: introduce phy_find_by_mdio_handle()

2020-07-12 Thread Calvin Johnson
On Sat, Jul 11, 2020 at 02:41:12PM -0700, Florian Fainelli wrote: > > > On 7/10/2020 11:55 PM, Calvin Johnson wrote: > > The PHYs on an mdiobus are probed and registered using mdiobus_register(). > > Later, for connecting these PHYs to MAC, the PHYs registered on the > > mdiobus have to be refere

Re: [net-next PATCH v6 2/6] net: phy: introduce device_mdiobus_register()

2020-07-12 Thread Calvin Johnson
On Sat, Jul 11, 2020 at 02:36:20PM -0700, Florian Fainelli wrote: > > > On 7/10/2020 11:55 PM, Calvin Johnson wrote: > > Introduce device_mdiobus_register() to register mdiobus > > in cases of either DT or ACPI. > > > > Signed-off-by: Calvin Johnson > > > > --- > > > > Changes in v6: > > - ch

Re: [PATCH] staging: qlge: Remove pci-dma-compat wrapper APIs.

2020-07-12 Thread Suraj Upadhyay
On Mon, Jul 13, 2020 at 01:59:59PM +0900, Benjamin Poirier wrote: > On 2020-07-11 18:16 +0530, Suraj Upadhyay wrote: > > The legacy API wrappers in include/linux/pci-dma-compat.h > > should go away as it creates unnecessary midlayering > > for include/linux/dma-mapping.h APIs, instead use dma-mappi

Re: [PATCH 3/3] arm64: allwinner: a64: enable Bluetooth On Pinebook

2020-07-12 Thread Vasily Khoruzhick
On Mon, Jul 6, 2020 at 4:47 AM Maxime Ripard wrote: > > Hi, > > On Sun, Jul 05, 2020 at 12:51:10PM -0700, Vasily Khoruzhick wrote: > > Pinebook has an RTL8723CS WiFi + BT chip, BT is connected to UART1 > > and uses PL5 as device wake GPIO, PL6 as host wake GPIO the I2C > > controlling signals are

[PATCH bpf-next 2/7] bpf, xdp: add bpf_link-based XDP attachment API

2020-07-12 Thread Andrii Nakryiko
Add bpf_link-based API (bpf_xdp_link) to attach BPF XDP program through BPF_LINK_CREATE command. bpf_xdp_link is mutually exclusive with direct BPF program attachment, previous BPF program should be detached prior to attempting to create a new bpf_xdp_link attachment (for a given XDP mode). Once l

[PATCH bpf-next 0/7] BPF XDP link

2020-07-12 Thread Andrii Nakryiko
Following cgroup and netns examples, implement bpf_link support for XDP. The semantics is described in patch #2. Program and link attachments are mutually exclusive, in the sense that neither link can replace attached program, nor program can replace attached link. Link can't replace attached link

[PATCH bpf-next 5/7] libbpf: add support for BPF XDP link

2020-07-12 Thread Andrii Nakryiko
Sync UAPI header and add support for using bpf_link-based XDP attachment. Make xdp/ prog type set expected attach type. Kernel didn't enforce attach_type for XDP programs before, so there is no backwards compatiblity issues there. Also fix section_names selftest to recognize that xdp prog types no

[PATCH bpf-next 4/7] bpf: implement BPF XDP link-specific introspection APIs

2020-07-12 Thread Andrii Nakryiko
Implement XDP link-specific show_fdinfo and link_info to emit ifindex. Signed-off-by: Andrii Nakryiko --- include/uapi/linux/bpf.h | 3 +++ net/core/dev.c | 31 +++ 2 files changed, 34 insertions(+) diff --git a/include/uapi/linux/bpf.h b/include/uapi/linu

[PATCH bpf-next 7/7] bpf, xdp: remove XDP_QUERY_PROG and XDP_QUERY_PROG_HW XDP commands

2020-07-12 Thread Andrii Nakryiko
Now that BPF program/link management is centralized in generic net_device code, kernel code never queries program id from drivers, so XDP_QUERY_PROG/XDP_QUERY_PROG_HW commands are unnecessary. This patch removes all the implementations of those commands in kernel, along the xdp_attachment_query().

[PATCH bpf-next 6/7] selftests/bpf: add BPF XDP link selftests

2020-07-12 Thread Andrii Nakryiko
Add selftest validating all the attachment logic around BPF XDP link. Test also link updates and get_obj_info() APIs. Signed-off-by: Andrii Nakryiko --- .../selftests/bpf/prog_tests/xdp_link.c | 137 ++ .../selftests/bpf/progs/test_xdp_link.c | 12 ++ 2 files changed

[PATCH bpf-next 3/7] bpf, xdp: implement LINK_UPDATE for BPF XDP link

2020-07-12 Thread Andrii Nakryiko
Add support for LINK_UPDATE command for BPF XDP link to enable reliable replacement of underlying BPF program. Signed-off-by: Andrii Nakryiko --- net/core/dev.c | 43 +++ 1 file changed, 43 insertions(+) diff --git a/net/core/dev.c b/net/core/dev.c index

[PATCH bpf-next 1/7] bpf, xdp: maintain info on attached XDP BPF programs in net_device

2020-07-12 Thread Andrii Nakryiko
Instead of delegating to drivers, maintain information about which BPF programs are attached in which XDP modes (generic/skb, driver, or hardware) locally in net_device. This effectively obsoletes XDP_QUERY_PROG command. Such re-organization simplifies existing code already. But it also allows to

Re: [PATCH 1/3] Bluetooth: Add new quirk for broken local ext features max_page

2020-07-12 Thread Vasily Khoruzhick
On Tue, Jul 7, 2020 at 9:03 AM Marcel Holtmann wrote: > > Hi Vasily, > > > Some adapters (e.g. RTL8723CS) advertise that they have more than > > 2 pages for local ext features, but they don't support any features > > declared in these pages. RTL8723CS reports max_page = 2 and declares > > support

Re: [PATCH 2/3] Bluetooth: btrtl: add support for the RTL8723CS

2020-07-12 Thread Vasily Khoruzhick
On Tue, Jul 7, 2020 at 9:01 AM Marcel Holtmann wrote: > > Hi Vasily, > > > The Realtek RTL8723CS is SDIO WiFi chip. It also contains a Bluetooth > > module which is connected via UART to the host. > > > > It shares lmp subversion with 8703B, so Realtek's userspace > > initialization tool (rtk_hcia

Re: [PATCH] staging: qlge: Remove pci-dma-compat wrapper APIs.

2020-07-12 Thread Benjamin Poirier
On 2020-07-11 18:16 +0530, Suraj Upadhyay wrote: > The legacy API wrappers in include/linux/pci-dma-compat.h > should go away as it creates unnecessary midlayering > for include/linux/dma-mapping.h APIs, instead use dma-mapping.h > APIs directly. > > The patch has been generated with the coccinell

[PATCH] net: fddi: skfp: Remove addr_to_string().

2020-07-12 Thread Tetsuo Handa
kbuild test robot found that addr_to_string() is available only when DEBUG is defined. And I found that what that function is doing is what %pM will do. Thus, replace %s with %pM and remove thread-unsafe addr_to_string() function. Reported-by: kbuild test robot Signed-off-by: Tetsuo Handa --- d

[net-next:master 211/211] net/bridge/br_netlink_tunnel.c:271:26: error: implicit declaration of function 'br_vlan_can_enter_range'; did you mean

2020-07-12 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 94339443686b36d3223bc032b7947267474e2679 commit: 94339443686b36d3223bc032b7947267474e2679 [211/211] net: bridge: notify on vlan tunnel changes done via the old api config: s390-defconfig (attached as .config

Re: mmotm 2020-07-09-21-00 uploaded (drivers/net/ethernet/mellanox/mlx5/core/en_main.c)

2020-07-12 Thread Randy Dunlap
On 7/12/20 9:02 PM, Stephen Rothwell wrote: > Hi Randy, > > On Fri, 10 Jul 2020 10:40:29 -0700 Randy Dunlap wrote: >> >> on i386: >> >> In file included from >> ../drivers/net/ethernet/mellanox/mlx5/core/en_main.c:49:0: >> ../drivers/net/ethernet/mellanox/mlx5/core/en_accel/en_accel.h: In functi

Re: [PATCH net-next v1 5/5] net: phy: micrel: ksz886x/ksz8081: add cabletest support

2020-07-12 Thread Oleksij Rempel
On Sat, Jul 11, 2020 at 08:29:12PM +0200, Andrew Lunn wrote: > On Fri, Jul 10, 2020 at 02:08:51PM +0200, Oleksij Rempel wrote: > > This patch support for cable test for the ksz886x switches and the > > ksz8081 PHY. > > > > The patch was tested on a KSZ8873RLL switch with following results: > > >

Re: mmotm 2020-07-09-21-00 uploaded (drivers/net/ethernet/mellanox/mlx5/core/en_main.c)

2020-07-12 Thread Stephen Rothwell
Hi Randy, On Fri, 10 Jul 2020 10:40:29 -0700 Randy Dunlap wrote: > > on i386: > > In file included from > ../drivers/net/ethernet/mellanox/mlx5/core/en_main.c:49:0: > ../drivers/net/ethernet/mellanox/mlx5/core/en_accel/en_accel.h: In function > ‘mlx5e_accel_sk_get_rxq’: > ../drivers/net/ethern

Re: [PATCH] vhost/scsi: fix up req type endian-ness

2020-07-12 Thread Jason Wang
On 2020/7/10 下午6:48, Michael S. Tsirkin wrote: vhost/scsi doesn't handle type conversion correctly for request type when using virtio 1.0 and up for BE, or cross-endian platforms. Fix it up using vhost_32_to_cpu. Cc: sta...@vger.kernel.org Signed-off-by: Michael S. Tsirkin --- drivers/vhos

Re: [PATCH] xsk: ixgbe: solve the soft interrupt 100% CPU usage when xdp rx traffic congestion

2020-07-12 Thread Yahui Chen
xdp skb-mode does not have this problem because `ixgbe_alloc_rx_buffers` always returns success and can always get the DMA address for packets. I think drv-mode should do the same. If the drv-mode app does not use the wakeup flag, the xdp queue's soft interrupt handles fewer packets but may occupy

linux-next: build failure after merge of the net-next tree

2020-07-12 Thread Stephen Rothwell
Hi all, After merging the net-next tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: net/bridge/br_netlink_tunnel.c: In function '__vlan_tunnel_handle_range': net/bridge/br_netlink_tunnel.c:271:26: error: implicit declaration of function 'br_vlan_can_enter_range'; did yo

[PATCH net-next 02/20] net: can: kerneldoc fixes

2020-07-12 Thread Andrew Lunn
Simple fixes which require no deep knowledge of the code. Cc: Oliver Hartkopp Cc: Marc Kleine-Budde Signed-off-by: Andrew Lunn --- net/can/af_can.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/can/af_can.c b/net/can/af_can.c index 128d37a4c2e0..5c06404bdf3e 100644 --- a/net/can/af

[PATCH net-next 13/20] net: openvswitch: kerneldoc fixes

2020-07-12 Thread Andrew Lunn
Simple fixes which require no deep knowledge of the code. Cc: Pravin B Shelar Signed-off-by: Andrew Lunn --- net/openvswitch/flow_netlink.c | 6 +++--- net/openvswitch/vport.c| 3 ++- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/net/openvswitch/flow_netlink.c b/net/ope

[PATCH net-next 05/20] net: decnet: kerneldoc fixes

2020-07-12 Thread Andrew Lunn
Simple fixes which require no deep knowledge of the code. Signed-off-by: Andrew Lunn --- net/decnet/dn_route.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/decnet/dn_route.c b/net/decnet/dn_route.c index 9eb7e4b62d9b..4cac31d22a50 100644 --- a/net/decnet/dn_route.c +++ b/net/decnet/

[PATCH net-next 19/20] net: wireless: kerneldoc fixes

2020-07-12 Thread Andrew Lunn
Simple fixes which require no deep knowledge of the code. Cc: Johannes Berg Signed-off-by: Andrew Lunn --- net/wireless/reg.c | 4 +++- net/wireless/wext-compat.c | 1 - 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/net/wireless/reg.c b/net/wireless/reg.c index 0d74a31e

[PATCH net-next 03/20] net: core: kerneldoc fixes

2020-07-12 Thread Andrew Lunn
Simple fixes which require no deep knowledge of the code. Signed-off-by: Andrew Lunn --- net/core/dev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/core/dev.c b/net/core/dev.c index c02bae927812..eab4ebe3c21c 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -7908,6 +7908,7 @@ EXPO

[PATCH net-next 17/20] net: switchdev: kerneldoc fixes

2020-07-12 Thread Andrew Lunn
Simple fixes which require no deep knowledge of the code. Cc: Jiri Pirko Signed-off-by: Andrew Lunn --- net/switchdev/switchdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/switchdev/switchdev.c b/net/switchdev/switchdev.c index f25604d68337..865f3e037425 100644 -

[PATCH net-next 04/20] net: dccp: kerneldoc fixes

2020-07-12 Thread Andrew Lunn
Simple fixes which require no deep knowledge of the code. Cc: Gerrit Renker Signed-off-by: Andrew Lunn --- net/dccp/ccids/lib/packet_history.c | 2 ++ net/dccp/feat.c | 6 ++ net/dccp/input.c| 1 + net/dccp/ipv4.c | 2 ++ net/dccp/

[PATCH net-next 12/20] net: nfc: kerneldoc fixes

2020-07-12 Thread Andrew Lunn
Simple fixes which require no deep knowledge of the code. Signed-off-by: Andrew Lunn --- net/nfc/core.c | 3 +-- net/nfc/nci/core.c | 4 ++-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/net/nfc/core.c b/net/nfc/core.c index c5f9c3ee82f8..eb377f87bcae 100644 --- a/net/nfc/c

[PATCH net-next 00/20] net simple kerneldoc fixes

2020-07-12 Thread Andrew Lunn
This is a collection of simple kerneldoc fixes. They are all low hanging fruit, were not real understanding of the code was needed. Andrew Lunn (20): net: 9p: kerneldoc fixes net: can: kerneldoc fixes net: core: kerneldoc fixes net: dccp: kerneldoc fixes net: decnet: kerneldoc fixes ne

[PATCH net-next 10/20] net: netfilter: kerneldoc fixes

2020-07-12 Thread Andrew Lunn
Simple fixes which require no deep knowledge of the code. Cc: Pablo Neira Ayuso Cc: Jozsef Kadlecsik Cc: Florian Westphal Signed-off-by: Andrew Lunn --- net/netfilter/nf_conntrack_core.c | 2 +- net/netfilter/nf_tables_api.c | 8 net/netfilter/nft_set_pipapo.c| 8 3

[PATCH net-next 08/20] net: llc: kerneldoc fixes

2020-07-12 Thread Andrew Lunn
Simple fixes which require no deep knowledge of the code. Signed-off-by: Andrew Lunn --- net/llc/af_llc.c| 1 - net/llc/llc_conn.c | 7 --- net/llc/llc_input.c | 1 + net/llc/llc_pdu.c | 2 +- net/llc/llc_sap.c | 3 +++ 5 files changed, 9 insertions(+), 5 deletions(-) diff --git a/

[PATCH net-next 06/20] net: ipv4: kerneldoc fixes

2020-07-12 Thread Andrew Lunn
Simple fixes which require no deep knowledge of the code. Cc: Paul Moore Cc: Alexey Kuznetsov Cc: Eric Dumazet Signed-off-by: Andrew Lunn --- net/ipv4/cipso_ipv4.c | 6 -- net/ipv4/ipmr.c | 3 +++ net/ipv4/tcp_input.c | 1 - net/ipv4/tcp_output.c | 2 ++ net/ipv4/tcp_timer.c | 2 +

[PATCH net-next 01/20] net: 9p: kerneldoc fixes

2020-07-12 Thread Andrew Lunn
Simple fixes which require no deep knowledge of the code. Cc: Eric Van Hensbergen Cc: Latchesar Ionkov Cc: Dominique Martinet Signed-off-by: Andrew Lunn --- net/9p/client.c | 2 +- net/9p/trans_rdma.c | 7 --- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/net/9p/clien

[PATCH net-next 09/20] net: mac80211: kerneldoc fixes

2020-07-12 Thread Andrew Lunn
Simple fixes which require no deep knowledge of the code. Cc: Johannes Berg Signed-off-by: Andrew Lunn --- net/mac80211/mesh_pathtbl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/net/mac80211/mesh_pathtbl.c b/net/mac80211/mesh_pathtbl.c index 117519bf33d6..fe4e853c61f

[PATCH net-next 16/20] net: socket: Move kerneldoc next to function it documents

2020-07-12 Thread Andrew Lunn
Fix the warning "Function parameter or member 'inode' not described in '__sock_release'' due to the kerneldoc being placed before __sock_release() not sock_release(), which does not take an inode parameter. Signed-off-by: Andrew Lunn --- net/socket.c | 17 - 1 file changed, 8 ins

[PATCH net-next 14/20] net: rxrpc: kerneldoc fixes

2020-07-12 Thread Andrew Lunn
Simple fixes which require no deep knowledge of the code. Cc: David Howells Signed-off-by: Andrew Lunn --- net/rxrpc/af_rxrpc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/rxrpc/af_rxrpc.c b/net/rxrpc/af_rxrpc.c index 394189b81849..cd7d0d204c74 100644 --- a/net/rxrpc

[PATCH net-next 20/20] net: x25: kerneldoc fixes

2020-07-12 Thread Andrew Lunn
Simple fixes which require no deep knowledge of the code. Cc: Andrew Hendry Signed-off-by: Andrew Lunn --- net/x25/x25_link.c | 2 +- net/x25/x25_route.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/net/x25/x25_link.c b/net/x25/x25_link.c index 7d02532aad0d..fdae054b7

[PATCH net-next 11/20] net: netlabel: kerneldoc fixes

2020-07-12 Thread Andrew Lunn
Simple fixes which require no deep knowledge of the code. Cc: Paul Moore Signed-off-by: Andrew Lunn --- net/netlabel/netlabel_domainhash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netlabel/netlabel_domainhash.c b/net/netlabel/netlabel_domainhash.c index a1f2320ec

[PATCH net-next 15/20] net: sched: kerneldoc fixes

2020-07-12 Thread Andrew Lunn
Simple fixes which require no deep knowledge of the code. Cc: Jamal Hadi Salim Cc: Cong Wang Cc: Jiri Pirko Signed-off-by: Andrew Lunn --- net/sched/em_canid.c | 1 + net/sched/ematch.c | 3 +-- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/net/sched/em_canid.c b/net/sched/

[PATCH net-next 18/20] net: tipc: kerneldoc fixes

2020-07-12 Thread Andrew Lunn
Simple fixes which require no deep knowledge of the code. Cc: Jon Maloy Cc: Ying Xue Signed-off-by: Andrew Lunn --- net/tipc/bearer.c| 2 +- net/tipc/discover.c | 5 ++--- net/tipc/link.c | 6 +++--- net/tipc/msg.c | 2 +- net/tipc/node.c | 4 ++-- net/tipc/socket.c| 8

Re: [PATCH v2 net] net: fec: fix hardware time stamping by external devices

2020-07-12 Thread Vladimir Oltean
On Mon, Jul 13, 2020 at 01:32:09AM +0300, Sergey Organov wrote: > > > > If you run "ethtool -T eth0" on a FEC network interface, it will always > > report its own PHC, and never the PHC of a PHY. So, you cannot claim > > that you are fixing PHY timestamping, since PHY timestamping is not > > advert

[PATCH net-next 07/20] net: ipv6: kerneldoc fixes

2020-07-12 Thread Andrew Lunn
Simple fixes which require no deep knowledge of the code. Cc: Alexey Kuznetsov Cc: Hideaki YOSHIFUJI Signed-off-by: Andrew Lunn --- net/ipv6/exthdrs.c| 1 - net/ipv6/ip6_output.c | 6 -- net/ipv6/ip6_tunnel.c | 10 ++ net/ipv6/udp.c| 3 +++ 4 files changed, 13 insert

[PATCH net-next v4] net: dccp: Add SIOCOUTQ IOCTL support (send buffer fill)

2020-07-12 Thread Richard Sailer
This adds support for the SIOCOUTQ IOCTL to get the send buffer fill of a DCCP socket, like UDP and TCP sockets already have. Regarding the used data field: DCCP uses per packet sequence numbers, not per byte, so sequence numbers can't be used like in TCP. sk_wmem_queued is not used by DCCP and al

Re: [PATCH net-next 0/3] vxlan, geneve: allow to turn off PMTU updates on encap socket

2020-07-12 Thread Stefano Brivio
On Sun, 12 Jul 2020 22:07:02 +0200 Florian Westphal wrote: > There are existing deployments where a vxlan or geneve interface is part > of a bridge. > > In this case, MTU may look like this: > > bridge mtu: 1450 > vxlan (bridge port) mtu: 1450 > other bridge ports: 1450 > > physical link (used

Re: [PATCH net-next 1/3] udp_tunnel: allow to turn off path mtu discovery on encap sockets

2020-07-12 Thread Stefano Brivio
Hi, On Sun, 12 Jul 2020 22:07:03 +0200 Florian Westphal wrote: > vxlan and geneve take the to-be-transmitted skb, prepend the > encapsulation header and send the result. > > Neither vxlan nor geneve can do anything about a lowered path mtu > except notifying the peer/upper dst entry. It could,

[PATCH V2 net-next 7/7] net: ena: support new LLQ acceleration mode

2020-07-12 Thread akiyano
From: Arthur Kiyanovski New devices add a new hardware acceleration engine, which adds some restrictions to the driver. Metadata descriptor must be present for each packet and the maximum burst size between two doorbells is now limited to a number advertised by the device. This patch adds: 1. A

[PATCH V2 net-next 6/7] net: ena: move llq configuration from ena_probe to ena_device_init()

2020-07-12 Thread akiyano
From: Arthur Kiyanovski When the ENA device resets to recover from some error state, all LLQ configuration values are reset to their defaults, because LLQ is initialized only once during ena_probe(). Changes in this commit: 1. Move the LLQ configuration process into ena_init_device() which is ca

[PATCH V2 net-next 0/7] ENA driver new features

2020-07-12 Thread akiyano
From: Arthur Kiyanovski V2 changes: --- 1. Update commit messages of 2 patches to be more verbose. 2. Remove "net: ena: enable support of rss hash key and function changes" patch. Will be resubmitted net. V1 cover letter: This patchset contains performance improveme

[PATCH V2 net-next 3/7] net: ena: cosmetic: satisfy gcc warning

2020-07-12 Thread akiyano
From: Arthur Kiyanovski gcc 4.8 reports a warning when initializing with = {0}. Dropping the "0" from the braces fixes the issue. This fix is not ANSI compatible but is allowed by gcc. Signed-off-by: Sameeh Jubran Signed-off-by: Arthur Kiyanovski --- drivers/net/ethernet/amazon/ena/ena_netdev

[PATCH V2 net-next 4/7] net: ena: cosmetic: change ena_com_stats_admin stats to u64

2020-07-12 Thread akiyano
From: Arthur Kiyanovski The size of the admin statistics in ena_com_stats_admin is changed from 32bit to 64bit so to align with the sizes of the other statistics in the driver (i.e. rx_stats, tx_stats and ena_stats_dev). This is done as part of an effort to create a unified API to read statistic

[PATCH V2 net-next 5/7] net: ena: add support for traffic mirroring

2020-07-12 Thread akiyano
From: Arthur Kiyanovski Add support for traffic mirroring, where the hardware reads the buffer from the instance memory directly. Traffic Mirroring needs access to the rx buffers in the instance. To have this access, this patch: 1. Changes the code to map and unmap the rx buffers bidirectionally

[PATCH V2 net-next 2/7] net: ena: add reserved PCI device ID

2020-07-12 Thread akiyano
From: Arthur Kiyanovski Add a reserved PCI device ID to the driver's table. Used for internal testing purposes. Signed-off-by: Arthur Kiyanovski --- drivers/net/ethernet/amazon/ena/ena_pci_id_tbl.h | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/ethernet/amazon/ena/ena_pci

[PATCH V2 net-next 1/7] net: ena: avoid unnecessary rearming of interrupt vector when busy-polling

2020-07-12 Thread akiyano
From: Arthur Kiyanovski In napi busy-poll mode, the kernel invokes the napi handler of the device repeatedly to poll the NIC's receive queues. This process repeats until a timeout, specific for each connection, is up. By polling packets in busy-poll mode the user may gain lower latency and higher

Re: [PATCH v2 net] net: fec: fix hardware time stamping by external devices

2020-07-12 Thread Sergey Organov
Vladimir Oltean writes: > On Sun, Jul 12, 2020 at 08:29:46PM +0300, Sergey Organov wrote: >> Vladimir Oltean writes: >> >> > As far as I understand. the reason why SKBTX_IN_PROGRESS exists is for >> > skb_tx_timestamp() to only provide a software timestamp if the hardware >> > timestamping isn'

Re: [PATCH net 0/3] bnxt_en: 3 bug fixes.

2020-07-12 Thread David Miller
From: Michael Chan Date: Sat, 11 Jul 2020 20:48:22 -0400 > 2 Fixes related to PHY/link settings. The last one fixes the sizing of > the completion ring. > > Please also queue for -stable. Thanks. Series applied and queued up for -stable, thanks.

Re: [PATCH] net: sky2: switch from 'pci_' to 'dma_' API

2020-07-12 Thread David Miller
From: Christophe JAILLET Date: Sat, 11 Jul 2020 22:49:44 +0200 > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GPF_ with a correct flag. > It has been compile tested. > > W

Re: [PATCH] net: skge: switch from 'pci_' to 'dma_' API

2020-07-12 Thread David Miller
From: Christophe JAILLET Date: Sat, 11 Jul 2020 22:35:18 +0200 > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GPF_ with a correct flag. > It has been compile tested. > > W

Re: [PATCH net-next 0/2] Fix MTU warnings for fec/mv886xxx combo

2020-07-12 Thread David Miller
From: Andrew Lunn Date: Sat, 11 Jul 2020 22:32:04 +0200 > Since changing the MTU of dsa slave interfaces was implemented, the > fec/mv88e6xxx combo has been giving warnings: > > [2.275925] mv88e6085 0.2:00: nonfatal error -95 setting MTU on port 9 > [2.284306] eth1: mtu greater than devi

Re: [PATCH net-next 3/3] net: treewide: Convert to netdev_ops_equal()

2020-07-12 Thread Florian Fainelli
On 7/12/2020 3:16 PM, Florian Fainelli wrote: > In order to support overloading of netdev_ops which can be done by > specific subsystems such as DSA, utilize netdev_ops_equal() which allows > a network driver implementing a ndo_equal operation to still qualify > whether a net_device::netdev_ops

Re: [PATCH net-next] net: bridge: notify on vlan tunnel changes done via the old api

2020-07-12 Thread David Miller
From: Nikolay Aleksandrov Date: Sat, 11 Jul 2020 18:05:04 +0300 > If someone uses the old vlan API to configure tunnel mappings we'll only > generate the old-style full port notification. That would be a problem > if we are monitoring the new vlan notifications for changes. The patch > resolves t

[PATCH net-next 2/3] net: dsa: Implement ndo_equal for CPU port net_device

2020-07-12 Thread Florian Fainelli
In order to preserve comparisons of the DSA network device bound to the switch's CPU port, implement net_device::ndo_equal which will return true while doing net_device_ops pointer comparisons. Network device drivers might do these checks to reject notifications targeting a different net_device in

[PATCH net-next 0/3] net: Preserve netdev_ops equality tests

2020-07-12 Thread Florian Fainelli
Hi David, Jakub, This patch series addresses a long standing with no known impact today with the overloading of netdev_ops done by the DSA layer. First we introduce a ndo_equal netdev_ops function pointer, then we have DSA utilize it, and finally all in tree users are converted to using either ne

[PATCH net-next 3/3] net: treewide: Convert to netdev_ops_equal()

2020-07-12 Thread Florian Fainelli
In order to support overloading of netdev_ops which can be done by specific subsystems such as DSA, utilize netdev_ops_equal() which allows a network driver implementing a ndo_equal operation to still qualify whether a net_device::netdev_ops is equal or not to its own. Mechanical conversion done b

[PATCH net-next 1/3] net: Introduce netdev_ops_equal

2020-07-12 Thread Florian Fainelli
DSA plays some tricks with overloading of a network device's netdev_ops in order to inject statistics, register dumps or various other operations. Because the pointer to the netdev_ops is not the same as the one the network driver registers, checks like theses: dev->netdev_ops == &foo_ops will no

[vhost:config-endian 38/39] drivers/platform/mellanox/mlxbf-tmfifo.c:1237:2: error: invalid preprocessing directive #defined; did you mean

2020-07-12 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git config-endian head: d8ede9b5e734748613d3e3108a4026244aa8e41f commit: 392755e77e260e8a173b228e8ecc17917f97d5eb [38/39] fixup! virtio_net: correct tags for config space fields config: arm64-allyesconfig (attached as .config) co

Re: [Linux-kernel-mentees] [PATCH net] qrtr: Fix ZERO_SIZE_PTR deref in qrtr_tun_write_iter()

2020-07-12 Thread Eric Biggers
On Sun, Jul 12, 2020 at 05:03:00PM -0400, Peilin Ye wrote: > qrtr_tun_write_iter() is dereferencing `ZERO_SIZE_PTR`s when `from->count` > equals to zero. Fix it by rejecting zero-length kzalloc() requests. > > This patch fixes the following syzbot bug: > > > https://syzkaller.appspot.com/bug

[PATCH net-next] net: mscc: ocelot: rethink Kconfig dependencies again

2020-07-12 Thread Vladimir Oltean
From: Vladimir Oltean Having the users of MSCC_OCELOT_SWITCH_LIB depend on REGMAP_MMIO was a bad idea, since that symbol is not user-selectable. So we should have kept a 'select REGMAP_MMIO'. When we do that, we run into 2 more problems: - By depending on GENERIC_PHY, we are causing a recursive

[Linux-kernel-mentees] [PATCH net] qrtr: Fix ZERO_SIZE_PTR deref in qrtr_tun_write_iter()

2020-07-12 Thread Peilin Ye
qrtr_tun_write_iter() is dereferencing `ZERO_SIZE_PTR`s when `from->count` equals to zero. Fix it by rejecting zero-length kzalloc() requests. This patch fixes the following syzbot bug: https://syzkaller.appspot.com/bug?id=f56bbe6668873ee245986bbd23312b895fa5a50a Reported-by: syzbot+03e343d

[PATCH iproute2] iplink_vxlan, geneve: Add PMTUDISC configuration

2020-07-12 Thread Florian Westphal
This allows to turn off route exception creation for the encapsulation socket. This is mainly useful if a vxlan interface is part of a bridge to prevent a bogus icmp error from shutting down the vxlan port: In a bridged environment, the sender is unaware of the icmp error (it is only addressed to

[PATCH net-next 2/3] vxlan: allow to disable path mtu learning on encap socket

2020-07-12 Thread Florian Westphal
While its already possible to configure VXLAN to never set the DF bit on packets that it sends, it was not yet possible to tell kernel to not update the encapsulation sockets path MTU. This can be used to tell ip stack to always use the interface MTU when VXLAN wants to send a packet. When packet

[PATCH net-next 0/3] vxlan, geneve: allow to turn off PMTU updates on encap socket

2020-07-12 Thread Florian Westphal
There are existing deployments where a vxlan or geneve interface is part of a bridge. In this case, MTU may look like this: bridge mtu: 1450 vxlan (bridge port) mtu: 1450 other bridge ports: 1450 physical link (used by vxlan) mtu: 1500. This makes sure that vxlan overhead (50 bytes) doesn't bri

[PATCH net-next 1/3] udp_tunnel: allow to turn off path mtu discovery on encap sockets

2020-07-12 Thread Florian Westphal
vxlan and geneve take the to-be-transmitted skb, prepend the encapsulation header and send the result. Neither vxlan nor geneve can do anything about a lowered path mtu except notifying the peer/upper dst entry. In routed setups, vxlan takes the updated pmtu from the encap sockets' dst entry and w

[PATCH net-next 3/3] geneve: allow disabling of pmtu detection on encap sk

2020-07-12 Thread Florian Westphal
same as vxlan change, compile tested only. Signed-off-by: Florian Westphal --- drivers/net/geneve.c | 59 include/uapi/linux/if_link.h | 1 + 2 files changed, 54 insertions(+), 6 deletions(-) diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c

Re: [PATCH v2 net] net: fec: fix hardware time stamping by external devices

2020-07-12 Thread Vladimir Oltean
On Sun, Jul 12, 2020 at 08:29:46PM +0300, Sergey Organov wrote: > Vladimir Oltean writes: > > > As far as I understand. the reason why SKBTX_IN_PROGRESS exists is for > > skb_tx_timestamp() to only provide a software timestamp if the hardware > > timestamping isn't going to. So hardware timestamp

[PATCH net-next v3 08/12] bridge: mrp: Implement the MRP Interconnect API

2020-07-12 Thread Horatiu Vultur
Thie patch adds support for MRP Interconnect. Similar with the MRP ring, if the HW can't generate MRP_InTest frames, then the SW will try to generate them. And if also the SW fails to generate the frames then an error is return to userspace. The forwarding/termination of MRP_In frames is happening

[PATCH net-next v3 09/12] bridge: mrp: Extend MRP netlink interface for configuring MRP interconnect

2020-07-12 Thread Horatiu Vultur
This patch extends the existing MRP netlink interface with the following attributes: IFLA_BRIDGE_MRP_IN_ROLE, IFLA_BRIDGE_MRP_IN_STATE and IFLA_BRIDGE_MRP_START_IN_TEST. These attributes are similar with their ring attributes but they apply to the interconnect port. Signed-off-by: Horatiu Vultur

[PATCH net-next v3 02/12] bridge: uapi: mrp: Extend MRP attributes for MRP interconnect

2020-07-12 Thread Horatiu Vultur
Extend the existing MRP netlink attributes to allow to configure MRP Interconnect: IFLA_BRIDGE_MRP_IN_ROLE - the parameter type is br_mrp_in_role which contains the interconnect id, the ring id, the interconnect role(MIM or MIC) and the port ifindex that represents the interconnect port. IFLA

[PATCH net-next v3 11/12] bridge: mrp: Extend br_mrp_fill_info

2020-07-12 Thread Horatiu Vultur
This patch extends the function br_mrp_fill_info to return also the status for the interconnect ring. Signed-off-by: Horatiu Vultur --- net/bridge/br_mrp_netlink.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/net/bridge/br_mrp_netlink.c b/net/bridge/br_mrp_netlink.c in

[PATCH net-next v3 06/12] bridge: mrp: Add br_mrp_in_port_open function

2020-07-12 Thread Horatiu Vultur
This function notifies the userspace when the node lost the continuity of MRP_InTest frames. Signed-off-by: Horatiu Vultur --- net/bridge/br_mrp_netlink.c | 22 ++ net/bridge/br_private_mrp.h | 1 + 2 files changed, 23 insertions(+) diff --git a/net/bridge/br_mrp_netlink.c

[PATCH net-next v3 12/12] net: bridge: Add port attribute IFLA_BRPORT_MRP_IN_OPEN

2020-07-12 Thread Horatiu Vultur
This patch adds a new port attribute, IFLA_BRPORT_MRP_IN_OPEN, which allows to notify the userspace when the node lost the contiuity of MRP_InTest frames. Signed-off-by: Horatiu Vultur --- include/uapi/linux/if_link.h | 1 + net/bridge/br_netlink.c| 3 +++ tools/include/uapi/li

[PATCH net-next v3 10/12] bridge: uapi: mrp: Extend MRP_INFO attributes for interconnect status

2020-07-12 Thread Horatiu Vultur
Extend the existing MRP_INFO to return status of MRP interconnect. In case there is no MRP interconnect on the node then the role will be disabled so the other attributes can be ignored. Signed-off-by: Horatiu Vultur --- include/uapi/linux/if_bridge.h | 5 + 1 file changed, 5 insertions(+)

[PATCH net-next v3 05/12] bridge: mrp: Rename br_mrp_port_open to br_mrp_ring_port_open

2020-07-12 Thread Horatiu Vultur
This patch renames the function br_mrp_port_open to br_mrp_ring_port_open. In this way is more clear that a ring port lost the continuity because there will be also a br_mrp_in_port_open. Signed-off-by: Horatiu Vultur --- net/bridge/br_mrp.c | 6 +++--- net/bridge/br_mrp_netlink.c | 2 +-

[PATCH net-next v3 03/12] bridge: mrp: Extend bridge interface

2020-07-12 Thread Horatiu Vultur
This patch adds a new flag(BR_MRP_LOST_IN_CONT) to the net bridge ports. This bit will be set when the port lost the continuity of MRP_InTest frames. Signed-off-by: Horatiu Vultur --- include/linux/if_bridge.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/if_bridge.h b/includ

[PATCH net-next v3 00/12] bridge: mrp: Add support for interconnect ring

2020-07-12 Thread Horatiu Vultur
This patch series extends existing MRP to add support for interconnect ring. An interconnect ring is a ring that connects 2 rings. In this way is possible to connect multiple rings. Each interconnect ring is form of 4 nodes, in which 3 have the role MIC(Media Redundancy Interconnect Client) and on

[PATCH net-next v3 07/12] bridge: switchdev: mrp: Extend MRP API for switchdev for MRP Interconnect

2020-07-12 Thread Horatiu Vultur
Implement the MRP API for interconnect switchdev. Similar with the other br_mrp_switchdev function, these function will just eventually call the switchdev functions: switchdev_port_obj_add/del. Signed-off-by: Horatiu Vultur --- net/bridge/br_mrp_switchdev.c | 62 +

[PATCH net-next v3 01/12] switchdev: mrp: Extend switchdev API for MRP Interconnect

2020-07-12 Thread Horatiu Vultur
Extend switchdev API to add support for MRP interconnect. The HW is notified in the following cases: SWITCHDEV_OBJ_ID_IN_ROLE_MRP: This is used when the interconnect role of the node changes. The supported roles are MIM and MIC. SWITCHDEV_OBJ_ID_IN_STATE_MRP: This is used when the interconnect

[PATCH net-next v3 04/12] bridge: mrp: Extend br_mrp for MRP interconnect

2020-07-12 Thread Horatiu Vultur
This patch extends the 'struct br_mrp' to contain information regarding the MRP interconnect. It contains the following: - the interconnect port 'i_port', which is NULL if the node doesn't have a interconnect role - the interconnect id, which is similar with the ring id, but this field is also

[PATCH 1/2] nl80211: Remove a misleading label in 'nl80211_trigger_scan()'

2020-07-12 Thread Christophe JAILLET
Since commit 5fe231e87372 ("cfg80211: vastly simplify locking"), the 'unlock' label at the end of 'nl80211_trigger_scan()' is useless and misleading, because nothing is unlocked there. Direct return can be used instead of 'err = -; goto unlock;' construction. Remove this label and simplify code a

[PATCH 2/2] nl80211: Simplify error handling path in 'nl80211_trigger_scan()'

2020-07-12 Thread Christophe JAILLET
Re-write the end of 'nl80211_trigger_scan()' with a more standard, easy to understand and future proof version. Signed-off-by: Christophe JAILLET --- net/wireless/nl80211.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/net/wireless/nl80211.c b/net/wirel

Re: [PATCH v2 net] net: fec: fix hardware time stamping by external devices

2020-07-12 Thread Sergey Organov
Vladimir Oltean writes: > On Sun, Jul 12, 2020 at 05:16:56PM +0300, Sergey Organov wrote: >> Vladimir Oltean writes: >> >> > Hi Sergey, >> > >> > On Sat, Jul 11, 2020 at 03:08:42PM +0300, Sergey Organov wrote: >> >> Fix support for external PTP-aware devices such as DSA or PTP PHY: >> >> >> >>

  1   2   >