Re-write the end of 'nl80211_trigger_scan()' with a more standard, easy to
understand and future proof version.

Signed-off-by: Christophe JAILLET <[email protected]>
---
 net/wireless/nl80211.c | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index a671ee5f5da7..898e5f53f263 100644
--- a/net/wireless/nl80211.c
+++ b/net/wireless/nl80211.c
@@ -7993,15 +7993,18 @@ static int nl80211_trigger_scan(struct sk_buff *skb, 
struct genl_info *info)
        rdev->scan_req = request;
        err = rdev_scan(rdev, request);
 
-       if (!err) {
-               nl80211_send_scan_start(rdev, wdev);
-               if (wdev->netdev)
-                       dev_hold(wdev->netdev);
-       } else {
+       if (err)
+               goto out_free;
+
+       nl80211_send_scan_start(rdev, wdev);
+       if (wdev->netdev)
+               dev_hold(wdev->netdev);
+
+       return 0;
+
  out_free:
-               rdev->scan_req = NULL;
-               kfree(request);
-       }
+       rdev->scan_req = NULL;
+       kfree(request);
 
        return err;
 }
-- 
2.25.1

Reply via email to