On Thu, Jun 04, 2020 at 10:09:10PM -0700, Eric Biggers wrote:
>
> There's also a case where "seqiv" is used without counter mode:
>
> net/xfrm/xfrm_algo.c:
>
> {
> .name = "rfc7539esp(chacha20,poly1305)",
So
select CRYPTO_SEQIV if CRYPTO_CTR || CRYPTO_CHACHA20POLY1305
and if th
> -Original Message-
> From: Rob Herring
> Sent: Friday, June 5, 2020 6:23 AM
> To: Ooi, Joyce
> Cc: David S . Miller ; Jakub Kicinski
> ; Thor Thayer ;
> netdev@vger.kernel.org; Rob Herring ; See, Chin
> Liang ; linux-ker...@vger.kernel.org; Nguyen,
> Dinh ; Westergreen, Dalon
> ; device
On Thu, Jun 04, 2020 at 06:02:54PM +0200, Toke Høiland-Jørgensen wrote:
> Hangbin Liu writes:
>
> > On Thu, Jun 04, 2020 at 02:37:23PM +0200, Toke Høiland-Jørgensen
> > wrote:
> >> > Now I use the ethtool_stats.pl to count forwarding speed and here is the
> >> > result:
> >> >
> >> > With
syzbot has bisected this bug to:
commit e42671084361302141a09284fde9bbc14fdd16bf
Author: Manivannan Sadhasivam
Date: Thu May 7 12:53:06 2020 +
net: qrtr: Do not depend on ARCH_QCOM
bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=17e2221210
start commit: acf25aa6 Mer
On Fri, Jun 05, 2020 at 10:29:56AM +1000, Herbert Xu wrote:
> On Fri, Jun 05, 2020 at 10:28:58AM +1000, Herbert Xu wrote:
> >
> > Hmm, the selection list doesn't include CTR so just adding SEQIV
> > per se makes no sense. I'm not certain that we really want to
> > include every algorithm under the
Le 05.06.2020 à 00:55, David Miller a écrit :
From: Valentin Longchamp
Date: Wed, 3 Jun 2020 23:21:13 +0200
Remove dev_watchdog_up() that directly called __netdev_watchdog_up() and
rename dev_watchdog_down() to __netdev_watchdog_down() for symmetry.
Signed-off-by: Valentin Longchamp
---
n
On Thu, Jun 04, 2020 at 05:21:55PM -0700, Stanislav Fomichev wrote:
> Attaching to these hooks can break iptables because its optval is
> usually quite big, or at least bigger than the current PAGE_SIZE limit.
>
> There are two possible ways to fix it:
> 1. Increase the limit to match iptables max
Sent a v2 with proper fixes and reported-by tags.
Thanks
Abhishek
On Thu, Jun 4, 2020 at 3:46 AM Rafael J. Wysocki wrote:
>
> On Wed, Jun 3, 2020 at 10:22 PM Abhishek Pandit-Subedi
> wrote:
> >
> > It is preferable to allow suspend even when Bluetooth has problems
> > preparing for sleep. When
It is preferable to allow suspend even when Bluetooth has problems
preparing for sleep. When Bluetooth fails to finish preparing for
suspend, log the error and allow the suspend notifier to continue
instead.
To also make it clearer why suspend failed, change bt_dev_dbg to
bt_dev_err when handling
On Wed, May 20, 2020 at 07:56:41AM +0200, Greg KH wrote:
> On Tue, May 19, 2020 at 09:53:16PM -0700, syzbot wrote:
> > Hello,
> >
> > syzbot found the following crash on:
> >
> > HEAD commit:d00f26b6 Merge git://git.kernel.org/pub/scm/linux/kernel/g..
> > git tree: net-next
> > console
On Thu, Jun 04, 2020 at 07:42:18AM -0700, syzbot wrote:
> Hello,
>
> syzbot found the following crash on:
>
> HEAD commit:065fcfd4 selftests: net: ip_defrag: ignore EPERM
> git tree: net-next
> console output: https://syzkaller.appspot.com/x/log.txt?x=15c3e51610
> kernel config: ht
[+Cc Matthew Wilcox]
Possibly a bug in lib/radix-tree.c? this_cpu_ptr() in radix_tree_node_alloc()
can be reached without a prior preempt_disable(). Or is the caller of
idr_alloc() doing something wrong?
On Thu, Jun 04, 2020 at 07:02:18PM -0700, syzbot wrote:
> Hello,
>
> syzbot found the foll
On 2020/6/4 下午4:59, Michael S. Tsirkin wrote:
On Wed, Jun 03, 2020 at 03:27:39PM +0800, Jason Wang wrote:
On 2020/6/2 下午9:06, Michael S. Tsirkin wrote:
With this patch applied, new and old code perform identically.
Lots of extra optimizations are now possible, e.g.
we can fetch multiple head
Calling pm_runtime_get_sync increments the counter even in case of
failure, causing incorrect ref count. Call pm_runtime_put if
pm_runtime_get_sync fails.
Signed-off-by: Navid Emamdoost
---
drivers/net/can/xilinx_can.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/dri
Calling pm_runtime_get_sync increments the counter even in case of
failure, causing incorrect ref count. Call pm_runtime_put if
pm_runtime_get_sync fails.
Signed-off-by: Navid Emamdoost
---
drivers/net/wireless/ti/wlcore/main.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git
The complete process is like this:
xprt_destroy
wait_on_bit_lock(&xprt->state, XPRT_LOCKED, TASK_UNINTERRUPTIBLE)
-->getlock
del_timer_sync(&xprt->timer) -->del xprt->timer
INIT_WORK(&xprt->task_cleanup, xprt_destroy_cb)
xprt_destroy_cb
xs_destroy(xprt->ops->destroy)
cancel_dela
Ping...
From: Andy Duan Sent: Tuesday, June 2, 2020 3:58 PM
> From: Fugang Duan
>
> When do suspend/resume test, there have WARN_ON() log dump from
> stmmac_xmit() funciton, the code logic:
> entry = tx_q->cur_tx;
> first_entry = entry;
> WARN_ON(tx_q->tx_skbuff[first_entry]);
Hello,
syzbot found the following crash on:
HEAD commit:acf25aa6 Merge tag 'Smack-for-5.8' of git://github.com/csc..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=13d6307a10
kernel config: https://syzkaller.appspot.com/x/.config?x=5263d9b5bce03c67
das
The only user of cxgb4_uld_in_use() is cxgb4_set_ktls_feature() which is
only available when CONFIG_CHELSIO_TLS_DEVICE=y. To avoid this compiler
warning when CONFIG_CHELSIO_TLS_DEVICE=n, place cxgb4_uld_in_use() behind
the same ifdef.
Signed-off-by: Tom Seewald
---
drivers/net/ethernet/chelsio/c
On 6/4/20 4:18 PM, Christoph Paasch wrote:
> +Eric & Leif
>
> Hello,
>
>
> (digging out an old thread ... ;-) )
>
Is there a tldr; ?
On Thu, Jun 04, 2020 at 05:40:31PM -0700, Eric Biggers wrote:
> +Cc linux-crypto. crypto_free_shash() is being called in atomic context;
> perhaps that should be allowed? kfree() can be called in atomic context.
Although vfree() cannot (which i personally hate ...)
> On Thu, Jun 04, 2020 at 05:
Hi all,
On Fri, 29 May 2020 13:19:55 +1000 Stephen Rothwell
wrote:
>
> Today's linux-next merge of the net-next tree got a conflict in:
>
> net/sunrpc/svcsock.c
>
> between commits:
>
> 11bbb0f76e99 ("SUNRPC: Trace a few more generic svc_xprt events")
> 998024dee197 ("SUNRPC: Add more s
+Cc linux-crypto. crypto_free_shash() is being called in atomic context;
perhaps that should be allowed? kfree() can be called in atomic context.
On Thu, Jun 04, 2020 at 05:33:19PM -0700, syzbot wrote:
> Hello,
>
> syzbot found the following crash on:
>
> HEAD commit:39884604 mptcp: fix NU
Hello,
syzbot found the following crash on:
HEAD commit:39884604 mptcp: fix NULL ptr dereference in MP_JOIN error ..
git tree: net-next
console output: https://syzkaller.appspot.com/x/log.txt?x=1322a9ce10
kernel config: https://syzkaller.appspot.com/x/.config?x=55b0bb710b7fdf44
das
On Fri, Jun 05, 2020 at 10:28:58AM +1000, Herbert Xu wrote:
>
> Hmm, the selection list doesn't include CTR so just adding SEQIV
> per se makes no sense. I'm not certain that we really want to
> include every algorithm under the sun. Steffen, what do you think?
Or how about
select CRYPT
On Thu, Jun 04, 2020 at 12:23:22PM -0700, Eric Biggers wrote:
> From: Eric Biggers
>
> Since CRYPTO_CTR no longer selects CRYPTO_SEQIV, it should be selected
> by INET_ESP and INET6_ESP -- similar to CRYPTO_ECHAINIV.
>
> Fixes: f23efcbcc523 ("crypto: ctr - no longer needs CRYPTO_SEQIV")
> Cc: Co
The only user of cxgb4_uld_in_use() is cxgb4_set_ktls_feature() which is
only available when CONFIG_CHELSIO_TLS_DEVICE=y. To avoid this compiler
warning when CONFIG_CHELSIO_TLS_DEVICE=n, place cxgb4_uld_in_use() behind
the same ifdef.
Signed-off-by: Tom Seewald
---
drivers/net/ethernet/chelsio/c
+Eric & Leif
Hello,
(digging out an old thread ... ;-) )
On Wed, Jun 11, 2014 at 11:05 PM Julian Anastasov wrote:
>
>
> Hello,
>
> On Tue, 10 Jun 2014, Wayne Badger wrote:
>
> > On 6/7/14, 10:41 AM, Julian Anastasov wrote:
> > >
> > > This discussion (http://marc.info/?t=1255410629
On Sat, May 30, 2020 at 07:02:01PM -0400, Boris Ostrovsky wrote:
> CAUTION: This email originated from outside of the organization. Do not click
> links or open attachments unless you can confirm the sender and know the
> content is safe.
>
>
>
> On 5/19/20 7:25 PM, Anchal Agarwal wrote:
> > I
From: Valentin Longchamp
Date: Wed, 3 Jun 2020 23:28:23 +0200
> net/sch_generic.h does not need to be included, remove it.
>
> Signed-off-by: Valentin Longchamp
Applied.
From: Heiner Kallweit
Date: Wed, 3 Jun 2020 22:29:06 +0200
> Th referenced change added an extra hw reset to rtl8169_net_suspend()
> what makes WoL fail on few chip versions. Therefore skip the extra
> reset if we're going down and WoL is enabled.
> In rtl_shutdown() rtl8169_hw_reset() is called
From: Valentin Longchamp
Date: Wed, 3 Jun 2020 23:15:27 +0200
> @@ -464,6 +464,7 @@ void __netdev_watchdog_up(struct net_device *dev)
> dev_hold(dev);
> }
> }
> +EXPORT_SYMBOL(__netdev_watchdog_up);
Please use EXPORT_SYMBOL_GPL(), thank you.
From: Valentin Longchamp
Date: Wed, 3 Jun 2020 23:21:13 +0200
> Remove dev_watchdog_up() that directly called __netdev_watchdog_up() and
> rename dev_watchdog_down() to __netdev_watchdog_down() for symmetry.
>
> Signed-off-by: Valentin Longchamp
> ---
> net/sched/sch_generic.c | 11 +++---
From: Pavel Machek
Date: Thu, 4 Jun 2020 23:42:59 +0200
> 64bit division is kind of expensive, and shift should do the job here.
>
> Signed-off-by: Pavel Machek (CIP)
I'll take this, applied, thanks.
From: Paolo Abeni
Date: Thu, 4 Jun 2020 18:55:45 +0200
> Clearing the 'inet_num' field is necessary and safe if and
> only if the socket is not bound. The MPTCP protocol calls
> the destroy helper on bound sockets, as tcp_v{4,6}_syn_recv_sock
> completed successfully.
>
> Move the clearing of s
From: "John W. Linville"
Date: Thu, 4 Jun 2020 14:35:39 -0400
> ethtool version 5.7 has been released.
>
> Home page: https://www.kernel.org/pub/software/network/ethtool/
> Download link:
> https://www.kernel.org/pub/software/network/ethtool/ethtool-5.7.tar.xz
>
> Release notes:
>
> * Fe
From: Wang Hai
Date: Thu, 4 Jun 2020 20:18:51 +0800
> If register_netdev(dev) fails, free_netdev(dev) needs
> to be called, otherwise a memory leak will occur.
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Reported-by: Hulk Robot
> Signed-off-by: Wang Hai
Applied, thanks.
From: Roelof Berg
Date: Wed, 3 Jun 2020 23:54:14 +0200
> Corrected the MAC_CR configuration bits for 1 GBit operation. The data
> sheet allows MAC_CR(2:1) to be 10 and also 11 for 1 GBit/s speed, but
> only 10 works correctly.
>
> Devices tested:
> Microchip Lan7431, fixed-phy mode
> Microchip
From: Dan Carpenter
Date: Wed, 3 Jun 2020 20:50:25 +0300
> The code is return PTR_ERR(NULL) which is zero or success. We should
> return -ENOMEM instead.
>
> Fixes: 94abdad6974a5 ("net: ethernet: dwmac: add ethernet glue logic for NXP
> imx8 chip")
> Signed-off-by: Dan Carpenter
Applied.
From: Michal Vokáč
Date: Wed, 3 Jun 2020 13:31:39 +0200
> Commit 7e99e3470172 ("net: dsa: remove dsa_switch_alloc helper")
> replaced the dsa_switch_alloc helper by devm_kzalloc in all DSA
> drivers. Unfortunately it introduced a typo in qca8k.c driver and
> wrong argument is passed to the devm_
From: Jiri Benc
Date: Wed, 3 Jun 2020 11:12:14 +0200
> If the geneve interface is in collect_md (external) mode, it can't send any
> packets submitted directly to its net interface, as such packets won't have
> metadata attached. This is expected.
>
> However, the kernel itself sends some packe
From:
Date: Wed, 3 Jun 2020 08:50:21 +
> From: Sameeh Jubran
>
> This patchset includes 2 XDP related bug fixes
>
> Difference from v1:
> * Fixed "Fixes" tag
Series applied, thanks.
From: Ahmed Abdelsalam
Date: Wed, 3 Jun 2020 06:54:42 +
> The seg6_validate_srh() is used to validate SRH for three cases:
>
> case1: SRH of data-plane SRv6 packets to be processed by the Linux kernel.
> Case2: SRH of the netlink message received from user-space (iproute2)
> Case3: SRH inj
On Thu, Jun 04, 2020 at 11:39:05PM +0200, Thomas Gleixner wrote:
> Kees Cook writes:
> >> > -#define NODE_NOT_IN_PAGE_FLAGS
> >> > +#define NODE_NOT_IN_PAGE_FLAGS 1
> >>
> >> but if we ever lose the 1 then the above will silently compile the code
> >> within the IS_ENABLED() section out.
> >
> >
From: Tuong Lien
Date: Wed, 3 Jun 2020 12:06:01 +0700
> syzbot found the following crash:
...
> Call Trace:
> tipc_sendstream+0x4c/0x70 net/tipc/socket.c:1533
> sock_sendmsg_nosec net/socket.c:652 [inline]
> sock_sendmsg+0xcf/0x120 net/socket.c:672
> sys_sendmsg+0x32f/0x810 net/socket.c
From: Cong Wang
Date: Tue, 2 Jun 2020 21:49:10 -0700
> There are two kinds of memory leaks in genl_family_rcv_msg_dumpit():
>
> 1. Before we call ops->start(), whenever an error happens, we forget
>to free the memory allocated in genl_family_rcv_msg_dumpit().
>
> 2. When ops->start() fails
From: Rohit Maheshwari
Date: Wed, 3 Jun 2020 09:58:13 +0530
> cxgb4_uld_in_use() is used only by cxgb4_ktls_det_feature() which
> is under CONFIG_CHELSIO_TLS_DEVICE macro.
>
> Fixes: a3ac249a1ab5 ("cxgb4/chcr: Enable ktls settings at run time")
> Signed-off-by: Rohit Maheshwari
Applied, thank
On Thu, 04 Jun 2020 15:32:56 +0800, Ooi, Joyce wrote:
> From: Dalon Westergreen
>
> Update devicetree bindings documentation to include msgdma
> prefetcher and ptp bindings.
>
> Cc: Rob Herring
> Cc: devicet...@vger.kernel.org
> Signed-off-by: Dalon Westergreen
> Signed-off-by: Joyce Ooi
> --
Hi Joyce",
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net/master]
[also build test WARNING on robh/for-next sparc-next/master linus/master v5.7
next-20200604]
[cannot apply to net-next/master]
[if your patch is applied to the wrong git tree, please
From: "Ooi, Joyce"
Date: Thu, 4 Jun 2020 15:32:46 +0800
> From: Joyce Ooi
>
> This patch series cleans up the Altera TSE driver and adds support
> for the newer msgdma prefetcher as well as ptp support when using
> the msgdma prefetcher.
>
> v2: Rename altera_ptp to intel_fpga_tod, modify msg
64bit division is kind of expensive, and shift should do the job here.
Signed-off-by: Pavel Machek (CIP)
---
Now with patch. Sorry about that.
diff --git a/net/xdp/xdp_umem.c b/net/xdp/xdp_umem.c
index 3889bd9aec46..d6c91a43a1ee 100644
--- a/net/xdp/xdp_umem.c
+++ b/net/xdp/xdp_umem.c
@@ -372,
Doing mod_timer() conditionaly is easier than conditionally unlocking
and jumping around...
Signed-off-by: Pavel Machek (CIP)
diff --git a/net/mac80211/mesh_hwmp.c b/net/mac80211/mesh_hwmp.c
index aa5150929996..02cde0fd08fe 100644
--- a/net/mac80211/mesh_hwmp.c
+++ b/net/mac80211/mesh_hwmp.c
@@
Kees Cook writes:
>> > -#define NODE_NOT_IN_PAGE_FLAGS
>> > +#define NODE_NOT_IN_PAGE_FLAGS 1
>>
>> but if we ever lose the 1 then the above will silently compile the code
>> within the IS_ENABLED() section out.
>
> That's true, yes. I considered two other ways to do this:
>
> 1) smallest patch,
64bit division is kind of expensive, and shift should do the job here.
Signed-off-by: Pavel Machek (CIP)
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
signature.asc
Description: Digital signature
Hi Dan,
I love your patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
[also build test WARNING on robh/for-next sparc-next/master net/master
linus/master v5.7 next-20200604]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve
On Thu, Jun 4, 2020 at 10:20 PM Kees Cook wrote:
>
> On Thu, Jun 04, 2020 at 12:29:17PM -0700, Nick Desaulniers wrote:
> > On Wed, Jun 3, 2020 at 4:32 PM Kees Cook wrote:
> > >
> > > Using uninitialized_var() is dangerous as it papers over real bugs[1]
> > > (or can in the future), and suppresses
On 6/3/20 10:45 PM, Song Liu wrote:
On Wed, Jun 3, 2020 at 12:05 PM Matthieu Baerts
wrote:
A recent commit added new variables only used if CONFIG_NETDEVICES is
set. A simple fix would be to only declare these variables if the same
condition is valid but Alexei suggested an even simpler soluti
Jakub
On 6/4/20 11:48 AM, Jakub Kicinski wrote:
On Thu, 4 Jun 2020 11:38:14 -0500 Dan Murphy wrote:
Jakub
On 6/4/20 11:25 AM, Jakub Kicinski wrote:
On Thu, 4 Jun 2020 06:14:10 -0500 Dan Murphy wrote:
Add RGMII internal delay configuration for Rx and Tx.
Signed-off-by: Dan Murphy
Hi Dan, p
Fix compile errors,warnings when CONFIG_IPV6 is disabled and
inconsistent indenting.
v1->v2:
- Corrected errors/warnings reported when used newer gcc version,
unused array.
Fixes: 6abde0b24122 ("crypto/chtls: IPv6 support for inline TLS")
Signed-off-by: Vinay Kumar Yadav
---
drivers/crypto/ch
On Thu, Jun 04, 2020 at 12:29:17PM -0700, Nick Desaulniers wrote:
> On Wed, Jun 3, 2020 at 4:32 PM Kees Cook wrote:
> >
> > Using uninitialized_var() is dangerous as it papers over real bugs[1]
> > (or can in the future), and suppresses unrelated compiler warnings (e.g.
> > "unused variable"). If
On Thu, Jun 04, 2020 at 01:08:44PM -0700, Nick Desaulniers wrote:
> On Wed, Jun 3, 2020 at 4:32 PM Kees Cook wrote:
> >
> > Using uninitialized_var() is dangerous as it papers over real bugs[1]
> > (or can in the future), and suppresses unrelated compiler warnings (e.g.
> > "unused variable"). If
On 6/4/2020 11:35 AM, John W. Linville wrote:
> ethtool version 5.7 has been released.
>
> Home page: https://www.kernel.org/pub/software/network/ethtool/
> Download link:
> https://www.kernel.org/pub/software/network/ethtool/ethtool-5.7.tar.xz
>
> Release notes:
>
> * Feature: ethtool:
Hello,
syzbot found the following crash on:
HEAD commit:39884604 mptcp: fix NULL ptr dereference in MP_JOIN error ..
git tree: net-next
console output: https://syzkaller.appspot.com/x/log.txt?x=125d5d1610
kernel config: https://syzkaller.appspot.com/x/.config?x=55b0bb710b7fdf44
das
From: Eric Biggers
Since CRYPTO_CTR no longer selects CRYPTO_SEQIV, it should be selected
by INET_ESP and INET6_ESP -- similar to CRYPTO_ECHAINIV.
Fixes: f23efcbcc523 ("crypto: ctr - no longer needs CRYPTO_SEQIV")
Cc: Corentin Labbe
Cc: Greg Kroah-Hartman
Cc: Herbert Xu
Cc: Steffen Klassert
> -Original Message-
> From: Intel-wired-lan On Behalf Of
> Wei Yongjun
> Sent: Monday, April 27, 2020 5:12 AM
> To: Kirsher, Jeffrey T ; Nguyen, Anthony L
>
> Cc: intel-wired-...@lists.osuosl.org; kernel-janit...@vger.kernel.org; Wei
> Yongjun ; netdev@vger.kernel.org
> Subject: [Intel-w
Hi Kees,
On Thu, Jun 4, 2020 at 5:01 PM Kees Cook wrote:
> On Thu, Jun 04, 2020 at 10:23:06AM -0300, Jason Gunthorpe wrote:
> > On Wed, Jun 03, 2020 at 04:32:02PM -0700, Kees Cook wrote:
> > > Using uninitialized_var() is dangerous as it papers over real bugs[1]
> > > (or can in the future), and
On Tue, Jun 02, 2020 at 03:12:27PM +0800, Jason Wang wrote:
>
> On 2020/6/2 下午1:09, Michael S. Tsirkin wrote:
> > On Fri, May 29, 2020 at 04:03:02PM +0800, Jason Wang wrote:
> > > Note that since virtio specification does not support get/restore
> > > virtqueue state. So we can not use this driver
ethtool version 5.7 has been released.
Home page: https://www.kernel.org/pub/software/network/ethtool/
Download link:
https://www.kernel.org/pub/software/network/ethtool/ethtool-5.7.tar.xz
Release notes:
* Feature: ethtool: Add support for Low Latency Reed Solomon
* Fix: ethtool.
On Sat, May 30, 2020 at 07:44:06PM -0400, Boris Ostrovsky wrote:
> CAUTION: This email originated from outside of the organization. Do not click
> links or open attachments unless you can confirm the sender and know the
> content is safe.
>
>
>
> On 5/19/20 7:28 PM, Anchal Agarwal wrote:
> > F
ath10k_htt_tx_free_msdu_id() has a lockdep assertion that htt->tx_lock
is held. Acquire the lock in a couple of error paths when calling that
function to ensure this condition is met.
Fixes: 6421969f248fd ("ath10k: refactor tx pending management")
Fixes: e62ee5c381c59 ("ath10k: Add support for htt
On Thu, Jun 04, 2020 at 07:59:40AM -0700, Kees Cook wrote:
> On Thu, Jun 04, 2020 at 10:23:06AM -0300, Jason Gunthorpe wrote:
> > On Wed, Jun 03, 2020 at 04:32:02PM -0700, Kees Cook wrote:
> > > Using uninitialized_var() is dangerous as it papers over real bugs[1]
> > > (or can in the future), and
On 6/4/20 9:55 AM, Paolo Abeni wrote:
> Clearing the 'inet_num' field is necessary and safe if and
> only if the socket is not bound. The MPTCP protocol calls
> the destroy helper on bound sockets, as tcp_v{4,6}_syn_recv_sock
> completed successfully.
>
> Move the clearing of such field out of
On Thu, Jun 04, 2020 at 10:40:06AM -0600, David Ahern wrote:
> On 6/4/20 9:48 AM, Jesper Dangaard Brouer wrote:
> > I will NOT send a patch that expose this in uapi/bpf.h. As I explained
> > before, this caused the issues for my userspace application, that
> > automatically picked-up struct bpf_de
Clearing the 'inet_num' field is necessary and safe if and
only if the socket is not bound. The MPTCP protocol calls
the destroy helper on bound sockets, as tcp_v{4,6}_syn_recv_sock
completed successfully.
Move the clearing of such field out of the common code, otherwise
the MPTCP MP_JOIN error pa
On Wed, Jun 03, 2020 at 02:36:46PM +0800, Jason Wang wrote:
>
> On 2020/6/3 下午2:30, Michael S. Tsirkin wrote:
> > On Wed, Jun 03, 2020 at 02:23:08PM +0800, Jason Wang wrote:
> > > > BTW now I re-read it I don't understand __vhost_get_user_slow:
> > > >
> > > >
> > > > static void __user *__vhost
On Thu, 4 Jun 2020 11:38:14 -0500 Dan Murphy wrote:
> Jakub
>
> On 6/4/20 11:25 AM, Jakub Kicinski wrote:
> > On Thu, 4 Jun 2020 06:14:10 -0500 Dan Murphy wrote:
> >> Add RGMII internal delay configuration for Rx and Tx.
> >>
> >> Signed-off-by: Dan Murphy
> > Hi Dan, please make sure W=1 C=1
On Thu, Jun 04, 2020 at 04:03:35PM +0100, Al Viro wrote:
> On Thu, Jun 04, 2020 at 06:10:23AM -0400, Michael S. Tsirkin wrote:
>
> > stac()
> > for (i = 0; i < 64; ++i) {
> > get_user(flags, desc[i].flags)
> unsafe_get_user(), please.
> > smp_rmb()
> > if (!(flags & VALID))
On Thu, Jun 04, 2020 at 03:59:24PM +0100, Al Viro wrote:
> On Thu, Jun 04, 2020 at 02:10:27PM +0800, Jason Wang wrote:
>
> > > > get_user(flags, desc->flags)
> > > > smp_rmb()
> > > > if (flags & VALID)
> > > > copy_from_user(&adesc, desc, sizeof adesc);
> > > >
> > > > this would be a good candi
On 6/4/20 9:48 AM, Jesper Dangaard Brouer wrote:
> I will NOT send a patch that expose this in uapi/bpf.h. As I explained
> before, this caused the issues for my userspace application, that
> automatically picked-up struct bpf_devmap_val, and started to fail
> (with no code changes), because it ne
Jakub
On 6/4/20 11:25 AM, Jakub Kicinski wrote:
On Thu, 4 Jun 2020 06:14:10 -0500 Dan Murphy wrote:
Add RGMII internal delay configuration for Rx and Tx.
Signed-off-by: Dan Murphy
Hi Dan, please make sure W=1 C=1 build is clean:
drivers/net/phy/dp83869.c:103:18: warning: ‘dp83869_internal
On Thu, 4 Jun 2020 06:14:10 -0500 Dan Murphy wrote:
> Add RGMII internal delay configuration for Rx and Tx.
>
> Signed-off-by: Dan Murphy
Hi Dan, please make sure W=1 C=1 build is clean:
drivers/net/phy/dp83869.c:103:18: warning: ‘dp83869_internal_delay’ defined
but not used [-Wunused-cons
Hangbin Liu writes:
> On Thu, Jun 04, 2020 at 02:37:23PM +0200, Toke Høiland-Jørgensen wrote:
>> > Now I use the ethtool_stats.pl to count forwarding speed and here is the
>> > result:
>> >
>> > With kernel 5.7(ingress i40e, egress i40e)
>> > XDP:
>> > bridge: 1.8M PPS
>> > xdp_redirect_ma
On Wed, 3 Jun 2020 09:22:57 -0700
Alexei Starovoitov wrote:
> On Wed, Jun 03, 2020 at 05:44:43PM +0200, Jesper Dangaard Brouer wrote:
> > The recent commit fbee97feed9b ("bpf: Add support to attach bpf program to a
> > devmap entry"), introduced ability to attach (and run) a separate XDP
> > bpf_
On Thu, 2020-06-04 at 22:49 +0800, Zheng Bin wrote:
> If RPC use udp as it's transport protocol, transport->connect_worker
> will call xs_udp_setup_socket.
> xs_udp_setup_socket
> sock = xs_create_sock
> if (IS_ERR(sock))
> goto out;
> out:
> xprt_unlock_connect
> xprt_schedule_
Hi,
+
+The STATS_FS_HIDDEN attribute won't affect the aggregation, it will only
+block the creation of the files.
Why does HIDDEN block the creation of files? instead of their visibility?
The file itself is used to allow the user to view the content of a
value. In order to make it hidden,
On Thu, Jun 4, 2020 at 4:56 PM Kees Cook wrote:
>
> Er? That's not what it looked like to me:
>
> #define IS_BUILTIN(option) __is_defined(option)
> #define IS_ENABLED(option) __or(IS_BUILTIN(option), IS_MODULE(option))
>
> But just to be sure, I just tested in with a real build:
>
> [3.242160]
On Thu, Jun 04, 2020 at 06:10:23AM -0400, Michael S. Tsirkin wrote:
> stac()
> for (i = 0; i < 64; ++i) {
>get_user(flags, desc[i].flags)
unsafe_get_user(), please.
>smp_rmb()
>if (!(flags & VALID))
> break;
>copy_from_user(&adesc[i], desc
On Thu, Jun 04, 2020 at 02:10:27PM +0800, Jason Wang wrote:
> > > get_user(flags, desc->flags)
> > > smp_rmb()
> > > if (flags & VALID)
> > > copy_from_user(&adesc, desc, sizeof adesc);
> > >
> > > this would be a good candidate I think.
> > Perhaps, once we get stac/clac out of raw_copy_from_use
On Thu, Jun 04, 2020 at 10:23:06AM -0300, Jason Gunthorpe wrote:
> On Wed, Jun 03, 2020 at 04:32:02PM -0700, Kees Cook wrote:
> > Using uninitialized_var() is dangerous as it papers over real bugs[1]
> > (or can in the future), and suppresses unrelated compiler warnings
> > (e.g. "unused variable")
On Thu, Jun 04, 2020 at 01:41:07PM +0200, Miguel Ojeda wrote:
> On Thu, Jun 4, 2020 at 9:58 AM Thomas Gleixner wrote:
> >
> > but if we ever lose the 1 then the above will silently compile the code
> > within the IS_ENABLED() section out.
>
> Yeah, I believe `IS_ENABLED()` is only meant for Kconf
Hello,
syzbot found the following crash on:
HEAD commit:065fcfd4 selftests: net: ip_defrag: ignore EPERM
git tree: net-next
console output: https://syzkaller.appspot.com/x/log.txt?x=15c3e51610
kernel config: https://syzkaller.appspot.com/x/.config?x=d89141553e61b775
dashboard link:
If RPC use udp as it's transport protocol, transport->connect_worker
will call xs_udp_setup_socket.
xs_udp_setup_socket
sock = xs_create_sock
if (IS_ERR(sock))
goto out;
out:
xprt_unlock_connect
xprt_schedule_autodisconnect
mod_timer
internal_add_timer -->inse
On Thu, Jun 04, 2020 at 02:37:23PM +0200, Toke Høiland-Jørgensen wrote:
> > Now I use the ethtool_stats.pl to count forwarding speed and here is the
> > result:
> >
> > With kernel 5.7(ingress i40e, egress i40e)
> > XDP:
> > bridge: 1.8M PPS
> > xdp_redirect_map:
> > generic mode: 1.9M PPS
> >
On Thu, Jun 04, 2020 at 09:58:07AM +0200, Thomas Gleixner wrote:
> Kees Cook writes:
> > -#ifdef NODE_NOT_IN_PAGE_FLAGS
> > - pfn_align = node_map_pfn_alignment();
> > - if (pfn_align && pfn_align < PAGES_PER_SECTION) {
> > - printk(KERN_WARNING "Node alignment %LuMB < min %LuMB,
>
On Thu, Jun 04, 2020 at 09:26:58AM +0200, Sedat Dilek wrote:
> On Thu, Jun 4, 2020 at 5:33 AM Nathan Chancellor
> wrote:
> >
> > On Wed, Jun 03, 2020 at 04:31:53PM -0700, Kees Cook wrote:
> > > Using uninitialized_var() is dangerous as it papers over real bugs[1]
> > > (or can in the future), and
On Thu, Jun 4, 2020 at 5:47 AM Victor Julien wrote:
>
> On 02-06-2020 22:18, Willem de Bruijn wrote:
> > On Tue, Jun 2, 2020 at 4:05 PM Victor Julien wrote:
> >>
> >> On 02-06-2020 21:38, Willem de Bruijn wrote:
> >>> On Tue, Jun 2, 2020 at 3:22 PM Victor Julien wrote:
>
> On 02-06-202
On Thu, Jun 4, 2020 at 9:10 PM Eric Dumazet wrote:
>
> On Thu, Jun 4, 2020 at 2:01 AM wrote:
> >
> > From: Jason Xing
> >
> > When using BBR mode, too many tcp socks cannot be released because of
> > duplicate use of the sock_hold() in the manner of tcp_internal_pacing()
> > when RTO happens. Th
On Wed, Jun 03, 2020 at 04:32:02PM -0700, Kees Cook wrote:
> Using uninitialized_var() is dangerous as it papers over real bugs[1]
> (or can in the future), and suppresses unrelated compiler warnings
> (e.g. "unused variable"). If the compiler thinks it is uninitialized,
> either simply initialize
Hangbin Liu writes:
> On Thu, Jun 04, 2020 at 11:44:24AM +0200, Toke Høiland-Jørgensen wrote:
>> Hangbin Liu writes:
>> > Here is the test topology, which looks like
>> >
>> > Host A| Host B|Host C
>> > eth0 +eth0 - eth1+eth0
>> >
>> > I did p
If register_netdev(dev) fails, free_netdev(dev) needs
to be called, otherwise a memory leak will occur.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Reported-by: Hulk Robot
Signed-off-by: Wang Hai
---
drivers/net/hamradio/yam.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/hamradi
1 - 100 of 144 matches
Mail list logo
