Re: [PATCH v1 01/25] net: core: device_rename: Use rwsem instead of a seqcount

2020-05-19 Thread Ahmed S. Darwish
Hello Eric, On Tue, May 19, 2020 at 07:01:38PM -0700, Eric Dumazet wrote: > > On 5/19/20 2:45 PM, Ahmed S. Darwish wrote: > > Sequence counters write paths are critical sections that must never be > > preempted, and blocking, even for CONFIG_PREEMPTION=n, is not allowed. > > > > Commit 5dbe7c178d3

[PATCH net-next v3 1/2] ethtool: provide UAPI for PHY Signal Quality Index (SQI)

2020-05-19 Thread Oleksij Rempel
Signal Quality Index is a mandatory value required by "OPEN Alliance SIG" for the 100Base-T1 PHYs [1]. This indicator can be used for cable integrity diagnostic and investigating other noise sources and implement by at least two vendors: NXP[2] and TI[3]. [1] http://www.opensig.org/download/docum

[PATCH net-next v3 0/2] provide KAPI for SQI

2020-05-19 Thread Oleksij Rempel
This patches are extending ethtool netlink interface to export Signal Quality Index (SQI). SQI provided by 100Base-T1 PHYs and can be used for cable diagnostic. Compared to a typical cable tests, this value can be only used after link is established. changes v3: - rename __ethtool_get_sqi* to link

[PATCH net-next v3 2/2] net: phy: tja11xx: add SQI support

2020-05-19 Thread Oleksij Rempel
This patch implements reading of the Signal Quality Index for better cable/link troubleshooting. Signed-off-by: Oleksij Rempel --- drivers/net/phy/nxp-tja11xx.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/drivers/net/phy/nxp-tja11xx.c b/drivers/net/phy/nxp-tja

Re: general protection fault in kobject_get (2)

2020-05-19 Thread Greg KH
On Tue, May 19, 2020 at 09:53:16PM -0700, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:d00f26b6 Merge git://git.kernel.org/pub/scm/linux/kernel/g.. > git tree: net-next > console output: https://syzkaller.appspot.com/x/log.txt?x=1316343c10 > kernel

Re: [PATCH 06/12] xen-blkfront: add callbacks for PM suspend and hibernation

2020-05-19 Thread kbuild test robot
Hi Anchal, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.7-rc6] [cannot apply to xen-tip/linux-next tip/irq/core tip/auto-latest next-20200519] [if your patch is applied to the wrong git tree, please drop us a note to help

Re: [PATCH v2 12/15] ath10k: use new module_firmware_crashed()

2020-05-19 Thread Emmanuel Grumbach
Hi all, Since I have been involved quite a bit in the firmware debugging features in iwlwifi, I think I can give a few insights here. But before this, we need to understand that there are several sources of issues: 1) the firmware may crash but the bus is still alive, you can still use the bus

Re: [PATCH bpf-next] selftests/bpf: add general instructions for test execution

2020-05-19 Thread Alexei Starovoitov
On Tue, May 19, 2020 at 10:34:25PM +0100, Alan Maguire wrote: > On Tue, 19 May 2020, Alexei Starovoitov wrote: > > > On Mon, May 18, 2020 at 12:23:10PM +0100, Alan Maguire wrote: > > > Getting a clean BPF selftests run involves ensuring latest trunk > > > LLVM/clang > > > are used, pahole is rece

Re: [PATCH 06/12] xen-blkfront: add callbacks for PM suspend and hibernation

2020-05-19 Thread kbuild test robot
Hi Anchal, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.7-rc6] [cannot apply to xen-tip/linux-next tip/irq/core tip/auto-latest next-20200519] [if your patch is applied to the wrong git tree, please drop us a note to help

Re: [PATCH net-next v1 1/2] ethtool: provide UAPI for PHY Signal Quality Index (SQI)

2020-05-19 Thread Oleksij Rempel
On Tue, May 19, 2020 at 04:03:48PM +0200, Andrew Lunn wrote: > > --- a/net/ethtool/common.c > > +++ b/net/ethtool/common.c > > @@ -310,6 +310,16 @@ int __ethtool_get_link(struct net_device *dev) > > return netif_running(dev) && dev->ethtool_ops->get_link(dev); > > } > > > > +int __ethtool_ge

Re: [PATCH net-next v1 1/2] ethtool: provide UAPI for PHY Signal Quality Index (SQI)

2020-05-19 Thread Oleksij Rempel
On Tue, May 19, 2020 at 03:26:30PM +0200, Andrew Lunn wrote: > On Tue, May 19, 2020 at 09:51:59AM +0200, Oleksij Rempel wrote: > > Signal Quality Index is a mandatory value required by "OPEN Alliance > > SIG" for the 100Base-T1 PHYs [1]. This indicator can be used for cable > > integrity diagnostic

general protection fault in kobject_get (2)

2020-05-19 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:d00f26b6 Merge git://git.kernel.org/pub/scm/linux/kernel/g.. git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=1316343c10 kernel config: https://syzkaller.appspot.com/x/.config?x=26d0bd769afe1a2c das

[PATCH net 2/4] wireguard: noise: read preshared key while taking lock

2020-05-19 Thread Jason A. Donenfeld
Prior we read the preshared key after dropping the handshake lock, which isn't an actual crypto issue if it races, but it's still not quite correct. So copy that part of the state into a temporary like we do with the rest of the handshake state variables. Then we can release the lock, operate on th

[PATCH net 3/4] wireguard: queueing: preserve flow hash across packet scrubbing

2020-05-19 Thread Jason A. Donenfeld
It's important that we clear most header fields during encapsulation and decapsulation, because the packet is substantially changed, and we don't want any info leak or logic bug due to an accidental correlation. But, for encapsulation, it's wrong to clear skb->hash, since it's used by fq_codel and

[PATCH net 4/4] wireguard: noise: separate receive counter from send counter

2020-05-19 Thread Jason A. Donenfeld
In "wireguard: queueing: preserve flow hash across packet scrubbing", we were required to slightly increase the size of the receive replay counter to something still fairly small, but an increase nonetheless. It turns out that we can recoup some of the additional memory overhead by splitting up the

[PATCH net 0/4] wireguard fixes for 5.7-rc7

2020-05-19 Thread Jason A. Donenfeld
Hi Dave, Hopefully these are the last fixes for 5.7: 1) A trivial bump in the selftest harness to support gcc-10. build.wireguard.com is still on gcc-9 but I'll probably switch to gcc-10 in the coming weeks. 2) A concurrency fix regarding userspace modifying the pre-shared key at the sa

[PATCH net 1/4] wireguard: selftests: use newer iproute2 for gcc-10

2020-05-19 Thread Jason A. Donenfeld
gcc-10 switched to defaulting to -fno-common, which broke iproute2-5.4. This was fixed in iproute-5.6, so switch to that. Because we're after a stable testing surface, we generally don't like to bump these unnecessarily, but in this case, being able to actually build is a basic necessity. Signed-o

Re: [PATCH v1 01/25] net: core: device_rename: Use rwsem instead of a seqcount

2020-05-19 Thread Stephen Hemminger
On Tue, 19 May 2020 20:18:19 -0700 Eric Dumazet wrote: > On 5/19/20 7:57 PM, David Miller wrote: > > From: Thomas Gleixner > > Date: Wed, 20 May 2020 01:42:30 +0200 > > > >> Stephen Hemminger writes: > >>> On Wed, 20 May 2020 00:23:48 +0200 > >>> Thomas Gleixner wrote: > No. We did

[PATCH net-next v2 4/5] vxlan: support for nexthop notifiers

2020-05-19 Thread Roopa Prabhu
From: Roopa Prabhu vxlan driver registers for nexthop add/del notifiers to cleanup fdb entries pointing to such nexthops. Signed-off-by: Roopa Prabhu --- drivers/net/vxlan.c | 33 + 1 file changed, 29 insertions(+), 4 deletions(-) diff --git a/drivers/net/vxlan

[PATCH net-next v2 5/5] selftests: net: add fdb nexthop tests

2020-05-19 Thread Roopa Prabhu
From: Roopa Prabhu This commit adds ipv4 and ipv6 fdb api tests to fib_nexthops.sh. Signed-off-by: Roopa Prabhu --- tools/testing/selftests/net/fib_nexthops.sh | 160 +++- 1 file changed, 158 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/net/fib_ne

[PATCH net-next v2 0/5] Support for fdb ECMP nexthop groups

2020-05-19 Thread Roopa Prabhu
From: Roopa Prabhu This series introduces ecmp nexthops and nexthop groups for mac fdb entries. In subsequent patches this is used by the vxlan driver fdb entries. The use case is E-VPN multihoming [1,2,3] which requires bridged vxlan traffic to be load balanced to remote switches (vteps) belongi

[PATCH net-next v2 1/5] nexthop: support for fdb ecmp nexthops

2020-05-19 Thread Roopa Prabhu
From: Roopa Prabhu This patch introduces ecmp nexthops and nexthop groups for mac fdb entries. In subsequent patches this is used by the vxlan driver fdb entries. The use case is E-VPN multihoming [1,2,3] which requires bridged vxlan traffic to be load balanced to remote switches (vteps) belongin

[PATCH net-next v2 3/5] nexthop: add support for notifiers

2020-05-19 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds nexthop add/del notifiers. To be used by vxlan driver in a later patch. Could possibly be used by switchdev drivers in the future. Signed-off-by: Roopa Prabhu --- include/net/netns/nexthop.h | 1 + include/net/nexthop.h | 12 net/ipv4/next

[PATCH net-next v2 2/5] vxlan: ecmp support for mac fdb entries

2020-05-19 Thread Roopa Prabhu
From: Roopa Prabhu Todays vxlan mac fdb entries can point to multiple remote ips (rdsts) with the sole purpose of replicating broadcast-multicast and unknown unicast packets to those remote ips. E-VPN multihoming [1,2,3] requires bridged vxlan traffic to be load balanced to remote switches (vtep

Re: [PATCH iproute2 v2 1/1] tc: action: fix time values output in JSON format

2020-05-19 Thread Stephen Hemminger
On Tue, 19 May 2020 20:59:44 -0400 Roman Mashak wrote: > Report tcf_t values in seconds, not jiffies, in JSON format as it is now > for stdout. > > v2: use PRINT_ANY, drop the useless casts and fix the style (Stephen > Hemminger) > > Fixes: 2704bd625583 ("tc: jsonify actions core") > Cc: Jiri

[PATCH 1/2 v3] net: ethernet: ti: fix some return value check of cpsw_ale_create()

2020-05-19 Thread Wei Yongjun
cpsw_ale_create() can return both NULL and PTR_ERR(), but all of the caller only check NULL for error handling. This patch convert it to only return PTR_ERR() in all error cases, and the caller using IS_ERR() instead of NULL test. Fixes: 4b41d3436796 ("net: ethernet: ti: cpsw: allow untagged traff

[PATCH 2/2 v3] net: ethernet: ti: am65-cpsw-nuss: fix error handling of am65_cpsw_nuss_probe

2020-05-19 Thread Wei Yongjun
Convert to using IS_ERR() instead of NULL test for cpsw_ale_create() error handling. Also fix to return negative error code from this error handling case instead of 0 in. Fixes: 93a76530316a ("net: ethernet: ti: introduce am65x/j721e gigabit eth subsystem driver") Reported-by: Hulk Robot Signed-

[PATCH 0/2 v3] net: ethernet: ti: fix some return value check

2020-05-19 Thread Wei Yongjun
This patchset convert cpsw_ale_create() to return PTR_ERR() only, and changed all the caller to check IS_ERR() instead of NULL. Since v2: 1) rebased on net.git, as Jakub's suggest 2) split am65-cpsw-nuss.c changes, as Grygorii's suggest Wei Yongjun (2): net: ethernet: ti: fix some return value

Re: [PATCH v1 01/25] net: core: device_rename: Use rwsem instead of a seqcount

2020-05-19 Thread Eric Dumazet
On 5/19/20 7:57 PM, David Miller wrote: > From: Thomas Gleixner > Date: Wed, 20 May 2020 01:42:30 +0200 > >> Stephen Hemminger writes: >>> On Wed, 20 May 2020 00:23:48 +0200 >>> Thomas Gleixner wrote: No. We did not. -ENOTESTCASE >>> >>> Please try, it isn't that hard.. >>> >>> # time f

Re: [PATCH net-next v1] hinic: add support to set and get pause param

2020-05-19 Thread David Miller
From: "luobin (L)" Date: Wed, 20 May 2020 09:51:02 +0800 > Sorry,I'm afraid I haven't got what you mean. Please don't top-post. What I said was: >> This doesn't apply cleanly to net-next. Which simply means that when I try to apply your patch to net-next with 'git am' it fails.

Re: [PATCH v1 01/25] net: core: device_rename: Use rwsem instead of a seqcount

2020-05-19 Thread David Miller
From: Thomas Gleixner Date: Wed, 20 May 2020 01:42:30 +0200 > Stephen Hemminger writes: >> On Wed, 20 May 2020 00:23:48 +0200 >> Thomas Gleixner wrote: >>> No. We did not. -ENOTESTCASE >> >> Please try, it isn't that hard.. >> >> # time for ((i=0;i<1000;i++)); do ip li add dev dummy$i type dumm

Re: [PATCH net] net: unexport skb_gro_receive()

2020-05-19 Thread David Miller
From: Eric Dumazet Date: Tue, 19 May 2020 15:53:51 -0700 > On Tue, May 19, 2020 at 3:53 PM David Miller wrote: >> >> From: Eric Dumazet >> Date: Tue, 19 May 2020 15:50:12 -0700 >> >> > skb_gro_receive() used to be used by SCTP, it is no longer the case. >> > >> > skb_gro_receive_list() is in th

Re: [PATCH] net: nlmsg_cancel() if put fails for nhmsg

2020-05-19 Thread David Ahern
On 5/19/20 7:57 PM, Stephen Worley wrote: > Fixes data remnant seen when we fail to reserve space for a > nexthop group during a larger dump. > > If we fail the reservation, we goto nla_put_failure and > cancel the message. > > Reproduce with the following iproute2 commands: > ===

Re: BPF for hash calculation

2020-05-19 Thread Ariel Levkovich
On May 19, 2020, at 22:13, Ariel Levkovich wrote: > > Hi Daniel, Aleksei > > I’m working on a feature to add support for datapath hash actions and > matching via TC API. > > One of the options we want to offer users there is to provide their own hash > calculation function, in the form of a

Re: [PATCH v3 6/7] perf test: Improve pmu event metric testing

2020-05-19 Thread Arnaldo Carvalho de Melo
Em Tue, May 19, 2020 at 10:15:48PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Tue, May 19, 2020 at 01:15:41PM -0700, Ian Rogers escreveu: > > On Tue, May 19, 2020 at 12:06 PM Arnaldo Carvalho de Melo > > errno != 0 for both cases as the man page notes suggest doing this. > > The tests using v a

RE: [net-next 00/14][pull request] 1GbE Intel Wired LAN Driver Updates 2020-05-19

2020-05-19 Thread Kirsher, Jeffrey T
> -Original Message- > From: Jakub Kicinski > Sent: Tuesday, May 19, 2020 19:00 > To: Kirsher, Jeffrey T > Cc: da...@davemloft.net; netdev@vger.kernel.org; nhor...@redhat.com; > sassm...@redhat.com > Subject: Re: [net-next 00/14][pull request] 1GbE Intel Wired LAN Driver > Updates 2020-05

Re: [PATCH v1 01/25] net: core: device_rename: Use rwsem instead of a seqcount

2020-05-19 Thread Eric Dumazet
On 5/19/20 2:45 PM, Ahmed S. Darwish wrote: > Sequence counters write paths are critical sections that must never be > preempted, and blocking, even for CONFIG_PREEMPTION=n, is not allowed. > > Commit 5dbe7c178d3f ("net: fix kernel deadlock with interface rename and > netdev name retrieval.") h

Re: [net-next 00/14][pull request] 1GbE Intel Wired LAN Driver Updates 2020-05-19

2020-05-19 Thread Jakub Kicinski
On Tue, 19 May 2020 17:04:05 -0700 Jeff Kirsher wrote: > This series contains updates to igc only. > > Sasha cleans up the igc driver code that is not used or needed. > > Vitaly cleans up driver code that was used to support Virtualization on > a device that is not supported by igc, so remove the

[PATCH] net: nlmsg_cancel() if put fails for nhmsg

2020-05-19 Thread Stephen Worley
Fixes data remnant seen when we fail to reserve space for a nexthop group during a larger dump. If we fail the reservation, we goto nla_put_failure and cancel the message. Reproduce with the following iproute2 commands: = ip link add dummy1 type dummy ip link add dummy2 type d

Re: UBSAN: array-index-out-of-bounds in kernel/bpf/arraymap.c:177

2020-05-19 Thread Qian Cai
> On May 19, 2020, at 7:23 PM, Andrii Nakryiko > wrote: > > I agree, it's bad to have this noise. But again, there is nothing > wrong with the way it's used in BPF code base. We'd gladly use > flexible array, if we could. But given we can't, I'd say the proper > solution (in order of my prefe

Re: [PATCH v1 01/25] net: core: device_rename: Use rwsem instead of a seqcount

2020-05-19 Thread Thomas Gleixner
Stephen Hemminger writes: > On Wed, 20 May 2020 01:42:30 +0200 > Thomas Gleixner wrote: > >> Stephen Hemminger writes: >> > On Wed, 20 May 2020 00:23:48 +0200 >> > Thomas Gleixner wrote: >> >> No. We did not. -ENOTESTCASE >> > >> > Please try, it isn't that hard.. >> > >> > # time for ((i=0

Re: [RFC PATCHv2 bpf-next 1/2] xdp: add a new helper for dev map multicast support

2020-05-19 Thread Hangbin Liu
On Tue, May 19, 2020 at 12:15:12PM +0200, Jesper Dangaard Brouer wrote: > Performance testing on a VM doesn't really make much sense. > > Pktgen is not meant to be used on virtual devices. Thanks, I will try on a physical machine. Cheers Hangbin

[PATCH net-next 0/2] net: hns3: adds two VLAN feature

2020-05-19 Thread Huazhong Tan
This patchset adds two new VLAN feature. [patch 1] adds a new dynamic VLAN mode. [patch 2] adds support for 'QOS' field to PVID. GuoJia Liao (2): net: hns3: adds support for dynamic VLAN mode net: hns3: add support for 'QOS' in port based VLAN configuration drivers/net/ethernet/hisilicon/hn

[PATCH net-next 2/2] net: hns3: add support for 'QOS' in port based VLAN configuration

2020-05-19 Thread Huazhong Tan
From: GuoJia Liao This patch adds support for 'QOS' in port based VLAN configuration. Signed-off-by: GuoJia Liao Signed-off-by: Huazhong Tan --- .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c| 32 -- .../ethernet/hisilicon/hns3/hns3pf/hclge_main.h| 4 +-- .../net

[PATCH net-next 1/2] net: hns3: adds support for dynamic VLAN mode

2020-05-19 Thread Huazhong Tan
From: GuoJia Liao There is a scenario which needs vNICs enable the VLAN filter in access port, while disable the VLAN filter in trunk port. Access port and trunk port can switch according to the user's configuration. This patch adds support for the dynamic VLAN mode. then the HNS3 driver can sup

Re: [PATCH v3 6/7] perf test: Improve pmu event metric testing

2020-05-19 Thread Arnaldo Carvalho de Melo
Em Tue, May 19, 2020 at 01:15:41PM -0700, Ian Rogers escreveu: > On Tue, May 19, 2020 at 12:06 PM Arnaldo Carvalho de Melo > wrote: > > > > Em Fri, May 15, 2020 at 03:17:31PM -0700, Ian Rogers escreveu: > > > Break pmu-events test into 2 and add a test to verify that all pmu > > > metric expressio

[PATCH iproute2 v2 1/1] tc: action: fix time values output in JSON format

2020-05-19 Thread Roman Mashak
Report tcf_t values in seconds, not jiffies, in JSON format as it is now for stdout. v2: use PRINT_ANY, drop the useless casts and fix the style (Stephen Hemminger) Fixes: 2704bd625583 ("tc: jsonify actions core") Cc: Jiri Pirko Signed-off-by: Roman Mashak --- tc/tc_util.c | 26 +++

Re: [PATCH v2 12/15] ath10k: use new module_firmware_crashed()

2020-05-19 Thread Brian Norris
Hi Luis, On Tue, May 19, 2020 at 7:02 AM Luis Chamberlain wrote: > On Mon, May 18, 2020 at 06:23:33PM -0700, Brian Norris wrote: > > On Sat, May 16, 2020 at 6:51 AM Johannes Berg > > wrote: > > > In addition, look what we have in iwl_trans_pcie_removal_wk(). If we > > > detect that the device i

Re: [PATCH v2 bpf-next 1/7] bpf: implement BPF ring buffer and verifier support for it

2020-05-19 Thread kbuild test robot
Hi Andrii, I love your patch! Perhaps something to improve: [auto build test WARNING on bpf-next/master] [also build test WARNING on next-20200519] [cannot apply to bpf/master rcu/dev v5.7-rc6] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW

Re: [PATCH v1 01/25] net: core: device_rename: Use rwsem instead of a seqcount

2020-05-19 Thread Stephen Hemminger
On Wed, 20 May 2020 01:42:30 +0200 Thomas Gleixner wrote: > Stephen Hemminger writes: > > On Wed, 20 May 2020 00:23:48 +0200 > > Thomas Gleixner wrote: > >> No. We did not. -ENOTESTCASE > > > > Please try, it isn't that hard.. > > > > # time for ((i=0;i<1000;i++)); do ip li add dev dummy$i

[net-next 02/14] igc: remove IGC_REMOVED function

2020-05-19 Thread Jeff Kirsher
From: Vitaly Lifshits igc driver has leftovers from the previous device that supported Virtualization. This can be found in the function IGC_REMOVED which became obsolete, and can be removed. Signed-off-by: Vitaly Lifshits Acked-by: Sasha Neftin Tested-by: Aaron Brown Signed-off-by: Jeff Kirs

[net-next 14/14] igc: Remove unused registers

2020-05-19 Thread Jeff Kirsher
From: Sasha Neftin Tx data FIFO Head/Tail, Saved and Packet Count registers not applicable for i225 LAN controller. This patch comes to clean up these registers. Signed-off-by: Sasha Neftin Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/igc/igc_dump.c | 4 -

[net-next 12/14] igc: Dump ETQF registers

2020-05-19 Thread Jeff Kirsher
From: Andre Guedes This patch adds the EType Queue Filter (ETQF) registers to the list of registers dumped by igc_get_regs(). Signed-off-by: Andre Guedes Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/igc/igc_ethtool.c | 3 +++ 1 file changed, 3 insertions(

[net-next 11/14] igc: Refactor ethertype filtering code

2020-05-19 Thread Jeff Kirsher
From: Andre Guedes The whole ethertype filtering code is implemented in igc_ethtool.c and mixes logic from ethtool and core parts. This patch refactors it so core logic is moved to igc_main.c, aligning the ethertype filtering code organization with the rest of the filtering code from the driver (

[net-next 10/14] igc: Fix MAX_ETYPE_FILTER value

2020-05-19 Thread Jeff Kirsher
From: Andre Guedes The I225 controller has 8 ethertype filters, not 4. This patch fixes the MAX_ETYPE_FILTER macro accordingly. Signed-off-by: Andre Guedes Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/igc/igc.h | 2 +- 1 file changed, 1 insertion(+), 1 de

[net-next 13/14] igc: Remove unused IGC_ICS_DRSTA define

2020-05-19 Thread Jeff Kirsher
From: Sasha Neftin Device reset assert for interrupt cause register not in use for i225 device. This patch comes to clean up this define. Signed-off-by: Sasha Neftin Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/igc/igc_defines.h | 1 - 1 file changed, 1 d

[net-next 08/14] igc: Remove duplicated IGC_RXPBS macro

2020-05-19 Thread Jeff Kirsher
From: Andre Guedes This patch remove the IGC_RXPBS macro defined in line 233 since it is already defined in line 18 with the exactly same value. Signed-off-by: Andre Guedes Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/igc/igc_regs.h | 2 -- 1 file changed

[net-next 03/14] igc: Clean up obsolete NVM defines

2020-05-19 Thread Jeff Kirsher
From: Sasha Neftin Packet buffer allocation, reserved word and pointer guard not applicable for i225 parts. This patch comes to clean up these obsolete defines Signed-off-by: Sasha Neftin Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/igc/igc_defines.h | 5

[net-next 09/14] igc: Remove ethertype filter in PTP code

2020-05-19 Thread Jeff Kirsher
From: Andre Guedes The driver only supports hardware timestamping for all incoming traffic (HWTSTAMP_FILTER_ALL) which is enabled via Rx Time Sync Control (TSYNCRXCTL) register already. Therefore, the ethertype filter set in in igc_ptp_set_timestamp_mode() is useless so this patch removes it. Si

[net-next 01/14] igc: Remove PCIe Control register

2020-05-19 Thread Jeff Kirsher
From: Sasha Neftin GCR (PCIe Control) register not in use and should be removed This patch clean up this register Signed-off-by: Sasha Neftin Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/igc/igc_regs.h | 3 --- 1 file changed, 3 deletions(-) diff --git a

[net-next 05/14] igc: Dump VLANPQF register

2020-05-19 Thread Jeff Kirsher
From: Andre Guedes This patch adds the VLAN Priority Queue Filter Register (VLANPQF) to the list of registers dumped by igc_get_regs(). Signed-off-by: Andre Guedes Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/igc/igc_ethtool.c | 2 ++ 1 file changed, 2 in

[net-next 07/14] igc: Refactor VLAN priority filtering code

2020-05-19 Thread Jeff Kirsher
From: Andre Guedes The whole VLAN priority filtering code is implemented in igc_ethtool.c and mixes logic from ethtool and core parts. This patch refactors it so core logic is moved to igc_main.c, aligning the VLAN priority filtering code organization with the MAC address filtering code. This pa

[net-next 04/14] igc: Rename IGC_VLAPQF macro

2020-05-19 Thread Jeff Kirsher
From: Andre Guedes This patch renames the IGC_VLAPQF macro to IGC_VLANPQF as well as related macros so they match the register name and fields described in the data sheet. Signed-off-by: Andre Guedes Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/igc/igc_de

[net-next 06/14] igc: Return -EOPNOTSUPP when VLAN mask doesn't match

2020-05-19 Thread Jeff Kirsher
From: Andre Guedes The I225 controller supports Rx queue assignment based on VLAN priority only. Other Tag Control Information (TCI) are valid, but not supported by the driver. So this patch changes the returning code from igc_add_ ethtool_nfc_entry() to -EOPNOTSUPP in order to provide more meani

[net-next 00/14][pull request] 1GbE Intel Wired LAN Driver Updates 2020-05-19

2020-05-19 Thread Jeff Kirsher
This series contains updates to igc only. Sasha cleans up the igc driver code that is not used or needed. Vitaly cleans up driver code that was used to support Virtualization on a device that is not supported by igc, so remove the dead code. Andre renames a few macros to align with register and

Re: [kbuild-all] Re: [PATCH net-next 2/4] net: phy: dp83869: Set opmode from straps

2020-05-19 Thread Philip Li
on to specify > > the > > base tree in git format-patch, please see > > https://stackoverflow.com/a/37406982] > > > > url: > > https://github.com/0day-ci/linux/commits/Dan-Murphy/DP83869-Enhancements/20200519-222047 > > base: https://git.kernel.

Re: [PATCH v1 01/25] net: core: device_rename: Use rwsem instead of a seqcount

2020-05-19 Thread Thomas Gleixner
Stephen Hemminger writes: > On Wed, 20 May 2020 00:23:48 +0200 > Thomas Gleixner wrote: >> No. We did not. -ENOTESTCASE > > Please try, it isn't that hard.. > > # time for ((i=0;i<1000;i++)); do ip li add dev dummy$i type dummy; done > > real 0m17.002s > user 0m1.064s > sys 0m0.375s And that

Re: [next-queue RFC 0/4] ethtool: Add support for frame preemption

2020-05-19 Thread Vinicius Costa Gomes
Andre Guedes writes: > Hi, > > Quoting Vinicius Costa Gomes (2020-05-15 18:29:44) >> One example, for retrieving and setting the configuration: >> >> $ ethtool $ sudo ./ethtool --show-frame-preemption enp3s0 >> Frame preemption settings for enp3s0: >> support: supported >> active

Re: [PATCH 05/12] genirq: Shutdown irq chips in suspend/resume during hibernation

2020-05-19 Thread Agarwal, Anchal
Thanks. Looks like send an old one without fix. Did resend the patch again. On Tue, 2020-05-19 at 23:26 +, Anchal Agarwal wrote: > Signed-off--by: Thomas Gleixner The Signed-off-by line needs to be fixed (hint: you have --) Balbir Singh

Re: [net-next 0/5] ip6_tunnel: add MPLS support

2020-05-19 Thread Vadim Fedorenko
On 20.05.2020 01:34, David Miller wrote: From: Vadim Fedorenko Date: Mon, 18 May 2020 23:33:43 +0300 The support for MPLS-in-IPv4 was added earlier. This patchset adds support for MPLS-in-IPv6. This adds way too many ifdefs into the C code, please find another way to abstract this such that y

[PATCH 11/12] xen: Update sched clock offset to avoid system instability in hibernation

2020-05-19 Thread Anchal Agarwal
Save/restore xen_sched_clock_offset in syscore suspend/resume during PM hibernation. Commit '867cefb4cb1012: ("xen: Fix x86 sched_clock() interface for xen")' fixes xen guest time handling during migration. A similar issue is seen during PM hibernation when system runs CPU intensive workload. Post

[PATCH 12/12] PM / hibernate: update the resume offset on SNAPSHOT_SET_SWAP_AREA

2020-05-19 Thread Anchal Agarwal
From: Aleksei Besogonov The SNAPSHOT_SET_SWAP_AREA is supposed to be used to set the hibernation offset on a running kernel to enable hibernating to a swap file. However, it doesn't actually update the swsusp_resume_block variable. As a result, the hibernation fails at the last step (after all th

[PATCH 10/12] xen: Introduce wrapper for save/restore sched clock offset

2020-05-19 Thread Anchal Agarwal
Introduce wrappers for save/restore xen_sched_clock_offset to be used by PM hibernation code to avoid system instability during resume. Signed-off-by: Anchal Agarwal --- arch/x86/xen/time.c| 15 +-- arch/x86/xen/xen-ops.h | 2 ++ 2 files changed, 15 insertions(+), 2 deletions(-)

Re: [PATCH 05/12] genirq: Shutdown irq chips in suspend/resume during hibernation

2020-05-19 Thread Singh, Balbir
On Tue, 2020-05-19 at 23:26 +, Anchal Agarwal wrote: > Signed-off--by: Thomas Gleixner The Signed-off-by line needs to be fixed (hint: you have --) Balbir Singh

[PATCH 08/12] xen/time: introduce xen_{save,restore}_steal_clock

2020-05-19 Thread Anchal Agarwal
From: Munehisa Kamata Currently, steal time accounting code in scheduler expects steal clock callback to provide monotonically increasing value. If the accounting code receives a smaller value than previous one, it uses a negative value to calculate steal time and results in incorrectly updated i

[PATCH 09/12] x86/xen: save and restore steal clock

2020-05-19 Thread Anchal Agarwal
From: Munehisa Kamata Save steal clock values of all present CPUs in the system core ops suspend callbacks. Also, restore a boot CPU's steal clock in the system core resume callback. For non-boot CPUs, restore after they're brought up, because runstate info for non-boot CPUs are not active until

[PATCH 07/12] xen-netfront: add callbacks for PM suspend and hibernation

2020-05-19 Thread Anchal Agarwal
From: Munehisa Kamata Add freeze, thaw and restore callbacks for PM suspend and hibernation support. The freeze handler simply disconnects the frotnend from the backend and frees resources associated with queues after disabling the net_device from the system. The restore handler just changes the

[PATCH 06/12] xen-blkfront: add callbacks for PM suspend and hibernation

2020-05-19 Thread Anchal Agarwal
From: Munehisa Kamata S4 power transition states are much different than xen suspend/resume. Former is visible to the guest and frontend drivers should be aware of the state transitions and should be able to take appropriate actions when needed. In transition to S4 we need to make sure that at le

[PATCH 05/12] genirq: Shutdown irq chips in suspend/resume during hibernation

2020-05-19 Thread Anchal Agarwal
Many legacy device drivers do not implement power management (PM) functions which means that interrupts requested by these drivers stay in active state when the kernel is hibernated. This does not matter on bare metal and on most hypervisors because the interrupt is restored on resume without any

[PATCH 04/12] x86/xen: add system core suspend and resume callbacks

2020-05-19 Thread Anchal Agarwal
From: Munehisa Kamata Add Xen PVHVM specific system core callbacks for PM suspend and hibernation support. The callbacks suspend and resume Xen primitives,like shared_info, pvclock and grant table. Note that Xen suspend can handle them in a different manner, but system core callbacks are called f

[PATCH 02/12] xenbus: add freeze/thaw/restore callbacks support

2020-05-19 Thread Anchal Agarwal
From: Munehisa Kamata Since commit b3e96c0c7562 ("xen: use freeze/restore/thaw PM events for suspend/resume/chkpt"), xenbus uses PMSG_FREEZE, PMSG_THAW and PMSG_RESTORE events for Xen suspend. However, they're actually assigned to xenbus_dev_suspend(), xenbus_dev_cancel() and xenbus_dev_resume()

[PATCH 03/12] x86/xen: Introduce new function to map HYPERVISOR_shared_info on Resume

2020-05-19 Thread Anchal Agarwal
Introduce a small function which re-uses shared page's PA allocated during guest initialization time in reserve_shared_info() and not allocate new page during resume flow. It also does the mapping of shared_info_page by calling xen_hvm_init_shared_info() to use the function. Signed-off-by: Anchal

[PATCH 01/12] xen/manage: keep track of the on-going suspend mode

2020-05-19 Thread Anchal Agarwal
From: Munehisa Kamata Guest hibernation is different from xen suspend/resume/live migration. Xen save/restore does not use pm_ops as is needed by guest hibernation. Hibernation in guest follows ACPI path and is guest inititated , the hibernation image is saved within guest as compared to later mo

[PATCH 00/12] Fix PM hibernation in Xen guests

2020-05-19 Thread Anchal Agarwal
Hello, This series fixes PM hibernation for hvm guests running on xen hypervisor. The running guest could now be hibernated and resumed successfully at a later time. The fixes for PM hibernation are added to block and network device drivers i.e xen-blkfront and xen-netfront. Any other driver that n

Re: UBSAN: array-index-out-of-bounds in kernel/bpf/arraymap.c:177

2020-05-19 Thread Andrii Nakryiko
On Tue, May 19, 2020 at 1:18 PM Qian Cai wrote: > > On Tue, May 19, 2020 at 3:30 PM Andrii Nakryiko > wrote: > > > > On Tue, May 19, 2020 at 8:00 AM Qian Cai wrote: > > > > > > On Mon, May 18, 2020 at 8:25 PM Andrii Nakryiko > > > wrote: > > > > > > > > On Mon, May 18, 2020 at 5:09 PM Qian Cai

Re: [PATCH v2 net] net/tls: fix encryption error checking

2020-05-19 Thread Vadim Fedorenko
On 20.05.2020 02:10, Jakub Kicinski wrote: On Wed, 20 May 2020 01:49:33 +0300 Vadim Fedorenko wrote: On 20.05.2020 01:04, Jakub Kicinski wrote: On Tue, 19 May 2020 13:20:43 +0300 Vadim Fedorenko wrote: bpf_exec_tx_verdict() can return negative value for copied variable. In that case this value

Re: [PATCH] net/amd: Remove the extra blank lines

2020-05-19 Thread Tang Bin
Hi David: On 2020/5/20 6:42, David Miller wrote: Please put these patches into a proper, numbered, patch series with an appropriate header posting. Whether you mean the patches should be like this: [PATCH 0/5].? Some of these patches do not apply cleanly to the net-next tree, which is

Re: [PATCH v1 01/25] net: core: device_rename: Use rwsem instead of a seqcount

2020-05-19 Thread Stephen Hemminger
On Wed, 20 May 2020 00:23:48 +0200 Thomas Gleixner wrote: > Stephen Hemminger writes: > > On Tue, 19 May 2020 23:45:23 +0200 > > "Ahmed S. Darwish" wrote: > > > >> Sequence counters write paths are critical sections that must never be > >> preempted, and blocking, even for CONFIG_PREEMPTION=n

Re: [PATCH] net: qrtr: Fix passing invalid reference to qrtr_local_enqueue()

2020-05-19 Thread Bjorn Andersson
On Tue 19 May 11:14 PDT 2020, Manivannan Sadhasivam wrote: > Once the traversal of the list is completed with list_for_each_entry(), > the iterator (node) will point to an invalid object. So passing this to > qrtr_local_enqueue() which is outside of the iterator block is erroneous > eventhough the

Re: [PATCH v2 net] net/tls: fix encryption error checking

2020-05-19 Thread Jakub Kicinski
On Wed, 20 May 2020 01:49:33 +0300 Vadim Fedorenko wrote: > On 20.05.2020 01:04, Jakub Kicinski wrote: > > On Tue, 19 May 2020 13:20:43 +0300 Vadim Fedorenko wrote: > >> bpf_exec_tx_verdict() can return negative value for copied > >> variable. In that case this value will be pushed back to caller

Re: [PATCH net] net: unexport skb_gro_receive()

2020-05-19 Thread David Miller
From: Eric Dumazet Date: Tue, 19 May 2020 15:50:12 -0700 > skb_gro_receive() used to be used by SCTP, it is no longer the case. > > skb_gro_receive_list() is in the same category : never used from modules. > > Signed-off-by: Eric Dumazet Maybe this is net-next material instead?

Re: [next-queue RFC 0/4] ethtool: Add support for frame preemption

2020-05-19 Thread Vinicius Costa Gomes
Andre Guedes writes: >> > >> >> active: active >> >> supported queues: 0xf > > Following the same rationale, is this 'supported queue' going aways as well? > I think so, with good error messages, when trying to set an express-only queue as preemptible, no need to expose this informatio

Re: [PATCH v2 net] net/tls: fix encryption error checking

2020-05-19 Thread Vadim Fedorenko
On 20.05.2020 01:04, Jakub Kicinski wrote: On Tue, 19 May 2020 13:20:43 +0300 Vadim Fedorenko wrote: bpf_exec_tx_verdict() can return negative value for copied variable. In that case this value will be pushed back to caller and the real error code will be lost. Fix it using signed type and check

[PATCH] mt76: mt7915: fix a handful of spelling mistakes

2020-05-19 Thread Colin King
From: Colin Ian King There are some spelling mistakes in some literal strings. Fix these. Signed-off-by: Colin Ian King --- drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/de

Re: [PATCH] sctp: Don't add the shutdown timer if its already been added

2020-05-19 Thread David Miller
From: Neil Horman Date: Tue, 19 May 2020 16:04:05 -0400 > This BUG halt was reported a while back, but the patch somehow got > missed: > ... > It appears that the side effect that starts the shutdown timer was processed > multiple times, which can happen as multiple paths can trigger it. This

Re: add a new ->ndo_tunnel_ctl method to avoid a few set_fs calls v2

2020-05-19 Thread David Miller
From: Christoph Hellwig Date: Tue, 19 May 2020 15:03:10 +0200 > both the ipv4 and ipv6 code have an ioctl each that can be used to create > a tunnel using code that doesn't live in the core kernel or ipv6 module. > Currently they call ioctls on the tunnel devices to create these, for > which the

Re: [PATCH] net/amd: Remove the extra blank lines

2020-05-19 Thread David Miller
Please put these patches into a proper, numbered, patch series with an appropriate header posting. Some of these patches do not apply cleanly to the net-next tree, which is where these changes should be targetted. Please respin. Thank you.

Re: [next-queue RFC 0/4] ethtool: Add support for frame preemption

2020-05-19 Thread Andre Guedes
Hi, Quoting Vinicius Costa Gomes (2020-05-18 12:34:22) > Hi, > > Michal Kubecek writes: > > > On Fri, May 15, 2020 at 06:29:44PM -0700, Vinicius Costa Gomes wrote: > >> Hi, > >> > >> This series adds support for configuring frame preemption, as defined > >> by IEEE 802.1Q-2018 (previously IEEE

Re: [next-queue RFC 0/4] ethtool: Add support for frame preemption

2020-05-19 Thread Andre Guedes
Hi, Quoting Vinicius Costa Gomes (2020-05-15 18:29:44) > One example, for retrieving and setting the configuration: > > $ ethtool $ sudo ./ethtool --show-frame-preemption enp3s0 > Frame preemption settings for enp3s0: > support: supported > active: active IIUC the code in patch 2

Re: [PATCH] net/sch_generic.h: use sizeof_member() and get rid of unused variable

2020-05-19 Thread David Miller
From: Antonio Quartulli Date: Tue, 19 May 2020 11:13:33 +0200 > Compiling with -Wunused triggers the following warning: > > ./include/net/sch_generic.h: In function ‘qdisc_cb_private_validate’: > ./include/net/sch_generic.h:464:23: warning: unused variable ‘qcb’ > [-Wunused-variable] > 464 |

  1   2   3   4   >