On Tue, May 19, 2020 at 03:26:30PM +0200, Andrew Lunn wrote: > On Tue, May 19, 2020 at 09:51:59AM +0200, Oleksij Rempel wrote: > > Signal Quality Index is a mandatory value required by "OPEN Alliance > > SIG" for the 100Base-T1 PHYs [1]. This indicator can be used for cable > > integrity diagnostic and investigating other noise sources and > > implement by at least two vendors: NXP[2] and TI[3]. > > Hi Oleksij > > With a multi part patch set, please always include a cover note, > describing what the patchset as a whole does.
ok
> > +int __ethtool_get_sqi(struct net_device *dev)
> > +{
> > + struct phy_device *phydev = dev->phydev;
> > +
> > + if (!phydev->drv->get_sqi)
> > + return -EOPNOTSUPP;
> > +
> > + return phydev->drv->get_sqi(phydev);
> > +}
>
> You are not doing any locking here, which you should. Due to modules
> vs built in, it can be a bit tricky getting this right. Take a look at
> how ethtool ioctl.c uses phy_ethtool_get_stats() and that inline
> function itself.
ok.
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
signature.asc
Description: PGP signature
