DMA not unmapped when lock failed, this patch fixed it.
Signed-off-by: Xiangyang Zhang
---
drivers/staging/qlge/qlge_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c
index a9163fb659d9..402edaeffe12 1
On Wed, May 13, 2020 at 01:58:55PM +0200, Maciej Fijalkowski wrote:
>
> So to me, if we would like to get rid of maxing out stack space, then we
> would have to do some dancing for preserving the tail call counter - keep
> it in some unused register? Or epilogue would pop it from stack to some
> r
On Thu, May 14, 2020 at 3:51 AM Jesper Dangaard Brouer
wrote:
>
> Update the memory requirements, when adding xdp.frame_sz in BPF test_run
> function bpf_prog_test_run_xdp() which e.g. is used by XDP selftests.
>
> Specifically add the expected reserved tailroom, but also allocated a
> larger memo
On Sun, 2020-05-17 at 04:47 +0200, Marek Vasut wrote:
> On 5/17/20 4:37 AM, Joe Perches wrote:
> > On Sun, 2020-05-17 at 04:28 +0200, Marek Vasut wrote:
> > > On 5/17/20 4:01 AM, Joe Perches wrote:
> > > > On Sun, 2020-05-17 at 02:33 +0200, Marek Vasut wrote:
> > > > > Drop those debug statements f
On 5/17/20 4:37 AM, Joe Perches wrote:
> On Sun, 2020-05-17 at 04:28 +0200, Marek Vasut wrote:
>> On 5/17/20 4:01 AM, Joe Perches wrote:
>>> On Sun, 2020-05-17 at 02:33 +0200, Marek Vasut wrote:
Drop those debug statements from both drivers. They were there since
at least 2011 and enabled
On Sun, 2020-05-17 at 04:28 +0200, Marek Vasut wrote:
> On 5/17/20 4:01 AM, Joe Perches wrote:
> > On Sun, 2020-05-17 at 02:33 +0200, Marek Vasut wrote:
> > > Drop those debug statements from both drivers. They were there since
> > > at least 2011 and enabled by default, but that's likely wrong.
>
On 5/17/20 4:01 AM, Joe Perches wrote:
> On Sun, 2020-05-17 at 02:33 +0200, Marek Vasut wrote:
>> Drop those debug statements from both drivers. They were there since
>> at least 2011 and enabled by default, but that's likely wrong.
> []
>> diff --git a/drivers/net/ethernet/micrel/ks8851_par.c
>>
On 5/17/20 4:02 AM, David Miller wrote:
> From: Marek Vasut
> Date: Sun, 17 May 2020 02:33:34 +0200
>
>> The KS8851SNL/SNLI and KS8851-16MLL/MLLI/MLLU are very much the same pieces
>> of silicon, except the former has an SPI interface, while the later has a
>> parallel bus interface. Thus far, Li
From: Marek Vasut
Date: Sun, 17 May 2020 02:33:34 +0200
> The KS8851SNL/SNLI and KS8851-16MLL/MLLI/MLLU are very much the same pieces
> of silicon, except the former has an SPI interface, while the later has a
> parallel bus interface. Thus far, Linux has two separate drivers for each
> and they
On Sun, 2020-05-17 at 02:33 +0200, Marek Vasut wrote:
> Drop those debug statements from both drivers. They were there since
> at least 2011 and enabled by default, but that's likely wrong.
[]
> diff --git a/drivers/net/ethernet/micrel/ks8851_par.c
> b/drivers/net/ethernet/micrel/ks8851_par.c
[]
>
tls_push_record can return -EAGAIN because of tcp layer. In that
case open_rec is already in the tx_record list and should not be
freed.
Also the record size can be more than the size requested to write
in tls_sw_do_sendpage(). That leads to overflow of copied variable
and wrong return code.
Fixes
This code was using get_user_pages_fast(), in a "Case 2" scenario
(DMA/RDMA), using the categorization from [1]. That means that it's
time to convert the get_user_pages_fast() + put_page() calls to
pin_user_pages_fast() + unpin_user_pages() calls.
There is some helpful background in [2]: basically
The parallel bus variant does not need to use the TX interrupt at all
as it writes the TX FIFO directly with in .ndo_start_xmit, permit the
drivers to configure the interrupt enable bits.
Reviewed-by: Andrew Lunn
Signed-off-by: Marek Vasut
Cc: David S. Miller
Cc: Lukas Wunner
Cc: Petr Stetiar
Pull all the SPI bus specific code into a separate file, so that it is
not mixed with the common code. Rename ks8851.c to ks8851_common.c. The
ks8851_common.c is linked with ks8851_spi.c now, so it can call the
accessors in the ks8851_spi.c without any pointer indirection.
Signed-off-by: Marek Vas
Pull out the spi->dev into one common place in the function instead of
having it repeated over and over again. This is done in preparation for
unifying ks8851 and ks8851-mll drivers. No functional change.
Reviewed-by: Andrew Lunn
Signed-off-by: Marek Vasut
Cc: David S. Miller
Cc: Lukas Wunner
Factor out this netif_rx_ni(), so it could be overridden by the parallel
bus variant of the KS8851 driver.
Signed-off-by: Marek Vasut
Cc: David S. Miller
Cc: Lukas Wunner
Cc: Petr Stetiar
Cc: YueHaibing
---
V3: New patch
V4: No change
V5: No change
V6: No change
---
drivers/net/ethernet/micr
Use device managed version of alloc_etherdev() to simplify the code.
No functional change intended.
Reviewed-by: Andrew Lunn
Signed-off-by: Marek Vasut
Cc: David S. Miller
Cc: Lukas Wunner
Cc: Petr Stetiar
Cc: YueHaibing
---
V2: Add RB from Andrew
V3: No change
V4: No change
V5: No change
V6
The KS8851SNL/SNLI and KS8851-16MLL/MLLI/MLLU are very much the same pieces
of silicon, except the former has an SPI interface, while the later has a
parallel bus interface. Thus far, Linux has two separate drivers for each
and they are diverging considerably.
This series unifies them into a singl
The RXFC register is the only one being read using 8-bit accessors.
To make it easier to support the 16-bit accesses used by the parallel
bus variant of KS8851, use 16-bit accessor to read RXFC register as
well as neighboring RXFCTR register.
Remove ks8851_rdreg8() as it is not used anywhere anymo
Drop those debug statements from both drivers. They were there since
at least 2011 and enabled by default, but that's likely wrong.
Signed-off-by: Marek Vasut
Cc: David S. Miller
Cc: Lukas Wunner
Cc: Petr Stetiar
Cc: YueHaibing
---
V6: New patch
---
drivers/net/ethernet/micrel/ks8851_par.c |
On the SPI variant of KS8851, the MAC address can be programmed with
either 8/16/32-bit writes. To make it easier to support the 16-bit
parallel option of KS8851 too, switch both the MAC address programming
and readout to 16-bit operations.
Remove ks8851_wrreg8() as it is not used anywhere anymore
Rename ndev variable to netdev for the sake of consistency.
No functional change.
Reviewed-by: Andrew Lunn
Signed-off-by: Marek Vasut
Cc: David S. Miller
Cc: Lukas Wunner
Cc: Petr Stetiar
Cc: YueHaibing
---
V2: New patch
V3: No change
V4: No change
V5: No change
V6: No change
---
drivers/n
Use netdev_err() instead of dev_err() to avoid accessing the spidev->dev
in the interrupt handler. This is the only place which uses the spidev
in this function, so replace it with netdev_err() to get rid of it. This
is done in preparation for unifying the KS8851 SPI and parallel drivers.
Reviewed
Replace spi_{get,set}_drvdata() with dev_{get,set}_drvdata(), which
works for both SPI and platform drivers. This is done in preparation
for unifying the KS8851 SPI and parallel bus drivers.
There should be no functional change.
Reviewed-by: Andrew Lunn
Signed-off-by: Marek Vasut
Cc: David S. M
Add a new struct ks8851_net_spi, which embeds the original
struct ks8851_net and contains the entries specific only to
the SPI variant of KS8851.
There should be no functional change.
Reviewed-by: Andrew Lunn
Signed-off-by: Marek Vasut
Cc: David S. Miller
Cc: Lukas Wunner
Cc: Petr Stetiar
Cc
While the SPI version of the KS8851 requires a TX worker thread to pump
data via SPI, the parallel bus version can write data into the TX FIFO
directly in .ndo_start_xmit, as the parallel bus access is much faster
and does not sleep. Factor out this TX work flush part, so it can be
overridden by th
Since the driver probe function already has a struct device *dev pointer
and can easily derive of_node pointer from it, pass the of_node pointer as
a parameter to ks8851_init_mac() to avoid fishing it out from ks->spidev.
This is the only reference to spidev in the function, so get rid of it.
This
Pull out bus access locking code into separate functions, this is done
in preparation for unifying the driver with the parallel bus one. The
parallel bus driver does not need heavy mutex locking of the bus and
works better with spinlocks, hence prepare these locking functions to
be overridden then.
Implement accessors for KS8851-16MLL/MLLI/MLLU parallel bus variant of
the KS8851. This is based off the ks8851_mll.c , which is a driver for
exactly the same hardware, however the ks8851.c code is much higher
quality. Hence, this patch pulls out the relevant information from the
ks8851_mll.c on ho
Factor out common code into ks8851_probe_common() and
ks8851_remove_common() to permit both SPI and parallel
bus driver variants to use the common code path for
both probing and removal.
There should be no functional change.
Reviewed-by: Andrew Lunn
Signed-off-by: Marek Vasut
Cc: David S. Mille
The ks8851_rdreg32() is used only in one place, to read two registers
using a single read. To make it easier to support 16-bit accesses via
parallel bus later on, replace this single read with two 16-bit reads
from each of the registers and drop the ks8851_rdreg32() altogether.
If this has noticea
The register and FIFO accessors are bus specific, so is locking.
Implement callbacks so that each variant of the KS8851 can implement
matching accessors and locking, and use the rest of the common code.
Reviewed-by: Andrew Lunn
Signed-off-by: Marek Vasut
Cc: David S. Miller
Cc: Lukas Wunner
Cc
The ks8851_mll.c is replaced by ks8851_par.c, which is using common code
from ks8851.c, just like ks8851_spi.c . Remove this old ad-hoc driver.
Signed-off-by: Marek Vasut
Cc: David S. Miller
Cc: Lukas Wunner
Cc: Petr Stetiar
Cc: YueHaibing
---
V2: No change
V3: No change
V4: No change
V5: No
From: Alex Elder
Date: Fri, 15 May 2020 15:07:29 -0500
> This series permits suspend/resume to work for the IPA driver
> on the Qualcomm SC7180 SoC. The IPA version on this SoC requires
> interrupts to be enabled when the suspend and resume callbacks are
> made, and the first patch moves away fr
From: Ido Schimmel
Date: Sun, 17 May 2020 01:43:04 +0300
> From: Ido Schimmel
>
> This patch set does not include any functional changes. It merely
> reworks the internal storage of traps, trap groups and trap policers in
> mlxsw to each use a single array.
>
> These changes allow us to get ri
From: Shakeel Butt
Date: Sat, 16 May 2020 15:35:46 -0700
> So, my argument is if non-zero order vzalloc has failed (allocations
> internal to vzalloc, including virtual mapping allocation and page
> table allocations, are order 0 and use GFP_KERNEL i.e. triggering
> reclaim and oom-killer) then t
On Fri, May 08, 2020 at 07:18:53AM +1000, NeilBrown wrote:
On Thu, May 07 2020, Sasha Levin wrote:
From: NeilBrown
[ Upstream commit 7c4310ff56422ea43418305d22bbc5fe19150ec4 ]
This one is buggy - it introduces a use-after-free. Best delay it for
now.
I've dropped it, thanks!
--
Thanks,
On Sat, 16 May 2020 at 23:54, David Miller wrote:
>
> From: Xulin Sun
> Date: Fri, 15 May 2020 11:18:13 +0800
>
> > BUG: sleeping function called from invalid context at
> > drivers/net/ethernet/mscc/ocelot.c:59
> > in_atomic(): 1, irqs_disabled(): 0, pid: 3778, name: ifconfig
> > INFO: lockdep
From: Ido Schimmel
Each trap registered with devlink is mapped to one or more Rx listeners.
These listeners allow the switch driver (e.g., mlxsw_spectrum) to
register a function that is called when a packet is received (trapped)
for a specific reason.
Currently, three arrays are used to describe
From: Ido Schimmel
Use one array to store all the information about all the trap groups
instead of hard coding it in code. This will be used in future patches
to disable certain functionality (e.g., policer binding) on a trap group
basis.
Signed-off-by: Ido Schimmel
Reviewed-by: Jiri Pirko
---
From: Ido Schimmel
One blank line is enough.
Signed-off-by: Ido Schimmel
Reviewed-by: Jiri Pirko
---
tools/testing/selftests/net/forwarding/devlink_lib.sh | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/testing/selftests/net/forwarding/devlink_lib.sh
b/tools/testing/selftests/net/fo
From: Ido Schimmel
It can be derived dynamically from the trap's name, so drop it.
Signed-off-by: Ido Schimmel
Reviewed-by: Jiri Pirko
---
.../net/mlxsw/devlink_trap_acl_drops.sh | 4 +--
.../net/mlxsw/devlink_trap_l2_drops.sh| 33 +++--
.../net/mlxsw/devlink_trap_l
From: Ido Schimmel
'struct mlxsw_sp_trap_policer_item' is only used in one file, so move it
there.
Signed-off-by: Ido Schimmel
Reviewed-by: Jiri Pirko
---
drivers/net/ethernet/mellanox/mlxsw/spectrum_trap.c | 6 ++
drivers/net/ethernet/mellanox/mlxsw/spectrum_trap.h | 6 --
2 files ch
From: Ido Schimmel
Instead of maintaining an array of policers and a linked list, only
maintain an array.
Signed-off-by: Ido Schimmel
Reviewed-by: Jiri Pirko
---
.../ethernet/mellanox/mlxsw/spectrum_trap.c | 148 +++---
.../ethernet/mellanox/mlxsw/spectrum_trap.h | 3 +-
2 f
From: Ido Schimmel
This patch set does not include any functional changes. It merely
reworks the internal storage of traps, trap groups and trap policers in
mlxsw to each use a single array.
These changes allow us to get rid of the multiple arrays we currently
have for traps, which make the trap
From: Heiner Kallweit
Date: Sun, 17 May 2020 00:05:08 +0200
> After having switched to devm_mdiobus_register() also this remaining
> call to mdiobus_unregister() can be removed.
>
> Signed-off-by: Heiner Kallweit
Applied, thanks.
From: Vladimir Oltean
Date: Sun, 17 May 2020 00:03:39 +0300
> As to why this doesn't go to tc but to ethtool: why would it go to tc?
Maybe you can't %100 duplicate the on-the-wire special format and
whatever, but the queueing behavior ABSOLUTELY you can emulate in
software.
And then you have th
From: Alex Elder
Date: Fri, 15 May 2020 14:52:03 -0500
> The iteration count value used in gsi_channel_poll() is intended to
> limit poll iterations to the budget supplied as an argument. But
> it's never updated.
>
> Fix this bug by incrementing the count each time through the loop.
>
> Repor
After having switched to devm_mdiobus_register() also this remaining
call to mdiobus_unregister() can be removed.
Signed-off-by: Heiner Kallweit
---
drivers/net/ethernet/realtek/r8169_main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/realtek/r8169_main.c
b/drivers/n
syzbot suspects this bug was fixed by commit:
commit f1e67e355c2aafeddf1eac31335709236996d2fe
Author: Thomas Gleixner
Date: Mon Nov 18 13:28:24 2019 +
fs/buffer: Make BH_Uptodate_Lock bit_spin_lock a regular spinlock_t
bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=1761c
On Sat, May 16, 2020 at 01:56:58PM -0700, David Miller wrote:
> From: Jakub Kicinski
> Date: Fri, 15 May 2020 12:48:59 -0700
>
> > There seems to be a few more things we can check in the core before
> > we call drivers' ethtool_ops->set_channels. Adding the checks to
> > the core simplifies the d
Hi David,
On Sat, 16 May 2020 at 23:39, David Miller wrote:
>
> From: Vinicius Costa Gomes
> Date: Fri, 15 May 2020 18:29:44 -0700
>
> > This series adds support for configuring frame preemption, as defined
> > by IEEE 802.1Q-2018 (previously IEEE 802.1Qbu) and IEEE 802.3br.
> >
> > Frame preemp
From: Jakub Kicinski
Date: Fri, 15 May 2020 12:48:59 -0700
> There seems to be a few more things we can check in the core before
> we call drivers' ethtool_ops->set_channels. Adding the checks to
> the core simplifies the drivers. This set only includes changes
> to the NFP driver as an example.
From: Christoph Hellwig
Date: Fri, 15 May 2020 08:33:24 +0200
> My initial plan was to add a ->tunnel_ctl method to the net_device_ops,
> and lift the copy_{to,from}_user for SIOCADDTUNNEL, SIOCCHGTUNNEL,
> SIOCDELTUNNEL and maybe SIOCGETTUNNEL to net/socket.c. But that turned
> out to have two
From: Xulin Sun
Date: Fri, 15 May 2020 11:18:13 +0800
> BUG: sleeping function called from invalid context at
> drivers/net/ethernet/mscc/ocelot.c:59
> in_atomic(): 1, irqs_disabled(): 0, pid: 3778, name: ifconfig
> INFO: lockdep is turned off.
> Preemption disabled at:
> [] dev_set_rx_mode+0x24
From: Christoph Paasch
Date: Thu, 14 May 2020 08:53:03 -0700
> RFC8684 allows to send 32-bit DATA_ACKs as long as the peer is not
> sending 64-bit data-sequence numbers. The 64-bit DSN is only there for
> extreme scenarios when a very high throughput subflow is combined with a
> long-RTT subflow
From: DENG Qingfang
Date: Wed, 13 May 2020 23:10:16 +0800
> When a client moves from a DSA user port to a software port in a bridge,
> it cannot reach any other clients that connected to the DSA user ports.
> That is because SA learning on the CPU port is disabled, so the switch
> ignores the cli
From: Nicolas Dichtel
Date: Wed, 13 May 2020 15:58:43 +0200
> The goal is to be able to inherit the initial devconf parameters from the
> current netns, ie the netns where this new netns has been created.
>
> This is useful in a containers environment where /proc/sys is read only.
> For example,
From: madhuparnabhowmi...@gmail.com
Date: Sat, 16 May 2020 13:15:15 +0530
> From: Madhuparna Bhowmik
>
> This patch fixes the following warning:
>
> =
> WARNING: suspicious RCU usage
> 5.7.0-rc4-next-20200507-syzkaller #0 Not tainted
> -
>
From: Shakeel Butt
Date: Fri, 15 May 2020 19:17:36 -0700
> and thus there is no need to have any fallback after vzalloc.
This statement is false.
The virtual mapping allocation or the page table allocations can fail.
A fallback is therefore indeed necessary.
From: Vinicius Costa Gomes
Date: Fri, 15 May 2020 18:29:44 -0700
> This series adds support for configuring frame preemption, as defined
> by IEEE 802.1Q-2018 (previously IEEE 802.1Qbu) and IEEE 802.3br.
>
> Frame preemption allows a packet from a higher priority queue marked
> as "express" to p
From: Luo bin
Date: Fri, 15 May 2020 19:42:12 +
> add support to change TX/RX queue number with ethtool -L
>
> Signed-off-by: Luo bin
I don't think you are properly following the semantics of this
ethtool command with your changes.
In fact, you are breaking the hinic_get_channels() functi
From: Luo bin
Date: Sat, 16 May 2020 02:00:30 +
> add support to set pause param with ethtool -A and get pause
> param with ethtool -a. Also remove set_link_ksettings ops for VF.
>
> Signed-off-by: Luo bin
Why are you using a semaphore and not a plain mutex.
Semaphores should be used as a
Microchip lan7431 is frequently connected to a phy. However, it
can also be directly connected to a MII remote peer without
any phy in between. For supporting such a phyless hardware setup
in Linux we added the capability to the driver to understand
the fixed-link and the phy-connection-type entrie
Hi Taehee,
On Sat, 16 May 2020 at 18:22, Taehee Yoo wrote:
>
> On Thu, 14 May 2020 at 00:56, Vladimir Oltean wrote:
> >
> > Hi Cong, Taehee,
> >
>
> Hi Vladimir!
> Sorry for the late reply.
>
> ...
>
> > I have a platform with the following layout:
> >
> > Regular NIC
> >|
> >
On Sat, May 16, 2020 at 03:11:40PM +, David Laight wrote:
> From: David Howells
> > Sent: 15 May 2020 16:20
> > Christoph Hellwig wrote:
> >
> > > > The advantage on using kernel_setsockopt here is that sctp module will
> > > > only be loaded if dlm actually creates a SCTP socket. With this
On Thu, 14 May 2020 at 00:56, Vladimir Oltean wrote:
>
> Hi Cong, Taehee,
>
Hi Vladimir!
Sorry for the late reply.
...
> I have a platform with the following layout:
>
> Regular NIC
>|
>+> DSA master for switch port
>|
>+> DSA master
From: Christoph Hellwig
> Sent: 15 May 2020 16:25
> On Fri, May 15, 2020 at 04:20:02PM +0100, David Howells wrote:
> > Christoph Hellwig wrote:
> >
> > > > The advantage on using kernel_setsockopt here is that sctp module will
> > > > only be loaded if dlm actually creates a SCTP socket. With thi
On Sat, May 16, 2020 at 02:00:30AM +, Luo bin wrote:
> +static int hinic_set_pauseparam(struct net_device *netdev,
> + struct ethtool_pauseparam *pause)
> +{
> + struct hinic_dev *nic_dev = netdev_priv(netdev);
> + struct hinic_pause_config pause_info = {0};
From: David Howells
> Sent: 15 May 2020 16:20
> Christoph Hellwig wrote:
>
> > > The advantage on using kernel_setsockopt here is that sctp module will
> > > only be loaded if dlm actually creates a SCTP socket. With this
> > > change, sctp will be loaded on setups that may not be actually using
From: Christoph Hellwig
> Sent: 15 May 2020 14:19
>
> this series moves the compat_ioctl handlers into the protocol handlers,
> avoiding the need to override the address space limited as in the current
> handler.
Is it worth moving the user copies for the main ioctl buffer
into the sys_ioctl() ent
On Sat, 2020-05-16 at 15:24 +0200, Johannes Berg wrote:
> Instead of the kernel taint, IMHO you should provide an annotation in
> sysfs (or somewhere else) for the *struct device* that had its firmware
> crash. Or maybe, if it's too complex to walk the entire hierarchy
> checking for that, have a
use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Vasundhara-Volam/bnxt_en-use-new-module_firmware_crashed/20200516-163022
base: https://git.kernel.org/pub/scm/linux/
On Fri, May 15, 2020 at 08:57:30AM -0700, Matthew Wilcox wrote:
> On Fri, May 15, 2020 at 10:23:17AM -0500, Nate Karstens wrote:
> > Series of 4 patches to implement close-on-fork. Tests have been
> > published to https://github.com/nkarstens/ltp/tree/close-on-fork
> > and cover close-on-fork funct
On Fri, 2020-05-15 at 21:28 +, Luis Chamberlain wrote:>
module_firmware_crashed
You didn't CC me or the wireless list on the rest of the patches, so I'm
replying to a random one, but ...
What is the point here?
This should in no way affect the integrity of the system/kernel, for
most device
system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Vasundhara-Volam/bnxt_en-use-new-module_firmware_crashed/20200516-163022
base: https://git.
add support to set pause param with ethtool -A and get pause
param with ethtool -a. Also remove set_link_ksettings ops for VF.
Signed-off-by: Luo bin
---
.../net/ethernet/huawei/hinic/hinic_ethtool.c | 100 +-
.../net/ethernet/huawei/hinic/hinic_hw_dev.c | 2 +
.../net/etherne
On Fri, May 15, 2020 at 06:29:44PM -0700, Vinicius Costa Gomes wrote:
> Hi,
>
> This series adds support for configuring frame preemption, as defined
> by IEEE 802.1Q-2018 (previously IEEE 802.1Qbu) and IEEE 802.3br.
>
> Frame preemption allows a packet from a higher priority queue marked
> as "e
mptcp calls this from the transmit side, from process context.
Allow a sleeping allocation instead of unconditional GFP_ATOMIC.
Acked-by: Paolo Abeni
Signed-off-by: Florian Westphal
---
include/linux/skbuff.h | 2 +-
net/core/skbuff.c | 8 +---
net/mptcp/protocol.c | 4 +++-
3 files
previous patches made sure we only call into this function
when these prerequisites are met, so no need to wait on the
subflow socket anymore.
Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/7
Acked-by: Paolo Abeni
Signed-off-by: Florian Westphal
---
net/mptcp/protocol.c | 14 ---
The mptcp_sendmsg_frag helper contains a loop that will wait on the
subflow sk.
It seems preferrable to only wait in mptcp_sendmsg() when blocking io is
requested. mptcp_sendmsg already has such a wait loop that is used when
no subflow socket is available for transmission.
This is another prepar
The mptcp_sendmsg_frag helper contains a loop that will wait on the
subflow sk.
It seems preferrable to only wait in mptcp_sendmsg() when blocking io is
requested. mptcp_sendmsg already has such a wait loop that is used when
no subflow socket is available for transmission.
This is a preparation
Paolo noticed that ssk_check_wmem() has same pattern, so add/use
common helper for both places.
Suggested-by: Paolo Abeni
Signed-off-by: Florian Westphal
---
net/mptcp/protocol.c | 27 +--
1 file changed, 13 insertions(+), 14 deletions(-)
diff --git a/net/mptcp/protocol
Its not enough to check for available tcp send space.
We also hold on to transmitted data for mptcp-level retransmits.
Right now we will send more and more data if the peer can ack data
at the tcp level fast enough, since that frees up tcp send buffer space.
But we also need to check that data wa
The transmit loop continues to xmit new data until an error is returned
or all data was transmitted.
For the blocking i/o case, this means that tcp_sendpages() may block on
the subflow until more space becomes available, i.e. we end up sleeping
with the mptcp socket lock held.
Instead we should c
This series reworks mptcp_sendmsg logic to avoid blocking on the subflow
socket.
It does so by removing the wait loop from mptcp_sendmsg_frag helper.
In order to do that, it moves prerequisites that are currently
handled in mptcp_sendmsg_frag (and cause it to wait until they are
met, e.g. frag ca
This makes use of the new module_firmware_crashed() to help
annotate when firmware for device drivers crash. When firmware
crashes devices can sometimes become unresponsive, and recovery
sometimes requires a driver unload / reload and in the worst cases
a reboot.
Using a taint flag allows us to an
> Subject: Re: [PATCH v2 net-next 0/7] dpaa2-eth: add support for Rx traffic
> classes
>
> On Fri, 15 May 2020 20:48:27 + Ioana Ciornei wrote:
> > > > There is no input taken from the user at the moment. The traffic
> > > > class id is statically selected based on the VLAN PCP field. The
> >
Hi Pali,
> The mwifiex_cfg80211_dump_station() uses static variable for iterating over
> a linked list of all associated stations (when the driver is in UAP role).
> This has
> a race condition if .dump_station is called in parallel for multiple
> interfaces.
> This corruption can be triggered b
use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Vasundhara-Volam/bnxt_en-use-new-module_firmware_crashed/20200516-135339
base: https://git.kernel.org/pub/scm/linux/
On Sat, May 16, 2020 at 1:29 AM Alexei Starovoitov
wrote:
>
> On Thu, May 14, 2020 at 12:47 PM Alexei Starovoitov
> wrote:
> >
> > On Thu, May 14, 2020 at 12:43 PM James Morris
> > wrote:
> > >
> > > On Wed, 13 May 2020, Alexei Starovoitov wrote:
> > >
> > > > James,
> > > >
> > > > since you to
On Thu, May 14, 2020 at 12:50:11PM -0700, David Miller wrote:
> From: Madhuparna Bhowmik
> Date: Thu, 14 May 2020 12:34:09 +0530
>
> > Sorry for this malformed patch, I have sent a patch with all these
> > corrections.
>
> It still needs more work, see Jakub's feedback.
>
Yes, I have sent the v2
From: Madhuparna Bhowmik
This patch fixes the following warning:
=
WARNING: suspicious RCU usage
5.7.0-rc4-next-20200507-syzkaller #0 Not tainted
-
net/ipv6/ip6mr.c:124 RCU-list traversed in non-reader section!!
ipmr_new_table() returns an
93 matches
Mail list logo
