Re: [PATCH ethtool] ethtool: dump nested registers

2019-08-06 Thread Jiri Pirko
Tue, Aug 06, 2019 at 07:20:02AM CEST, mkube...@suse.cz wrote: >On Mon, Aug 05, 2019 at 10:52:16AM -0400, Vivien Didelot wrote: >> Hi Michal! >> >> On Mon, 5 Aug 2019 10:04:48 +0200, Michal Kubecek wrote: >> > On Fri, Aug 02, 2019 at 03:34:54PM -0400, Vivien Didelot wrote: >> > > Usually kernel dr

Re: [PATCH net] netdevsim: Restore per-network namespace accounting for fib entries

2019-08-06 Thread Jiri Pirko
Wed, Aug 07, 2019 at 12:32:14AM CEST, jakub.kicin...@netronome.com wrote: >On Tue, 6 Aug 2019 12:15:17 -0700, David Ahern wrote: >> From: David Ahern >> >> Prior to the commit in the fixes tag, the resource controller in netdevsim >> tracked fib entries and rules per network namespace. Restore t

Re: [PATCH bpf 0/2] tools: bpftool: fix pinning error messages

2019-08-06 Thread Y Song
On Tue, Aug 6, 2019 at 5:20 PM Jakub Kicinski wrote: > > Hi! > > First make sure we don't use "prog" in error messages because > the pinning operation could be performed on a map. Second add > back missing error message if pin syscall failed. > > Jakub Kicinski (2): > tools: bpftool: fix error m

Re: [net] ixgbe: fix possible deadlock in ixgbe_service_task()

2019-08-06 Thread Taehee Yoo
On Wed, 7 Aug 2019 at 08:36, David Miller wrote: > Hi David Thank you for the review! > From: Jeff Kirsher > Date: Mon, 5 Aug 2019 13:04:03 -0700 > > > diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c > > b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c > > index cbaf712d6529..3386e7

[PATCH net v2] net/tls: prevent skb_orphan() from leaking TLS plain text with offload

2019-08-06 Thread Jakub Kicinski
sk_validate_xmit_skb() and drivers depend on the sk member of struct sk_buff to identify segments requiring encryption. Any operation which removes or does not preserve the original TLS socket such as skb_orphan() or skb_clone() will cause clear text leaks. Make the TCP socket underlying an offloa

[PATCH v4 bpf-next 10/14] selftests/bpf: add CO-RE relocs enum/ptr/func_proto tests

2019-08-06 Thread Andrii Nakryiko
Test CO-RE relocation handling of ints, enums, pointers, func protos, etc. Signed-off-by: Andrii Nakryiko Acked-by: Song Liu --- .../selftests/bpf/prog_tests/core_reloc.c | 36 ++ .../bpf/progs/btf__core_reloc_primitives.c| 3 + ...f__core_reloc_primitives___diff_enum_def.c |

[PATCH v4 bpf-next 02/14] libbpf: convert libbpf code to use new btf helpers

2019-08-06 Thread Andrii Nakryiko
Simplify code by relying on newly added BTF helper functions. Signed-off-by: Andrii Nakryiko --- tools/lib/bpf/btf.c | 181 ++- tools/lib/bpf/btf_dump.c | 136 ++--- tools/lib/bpf/libbpf.c | 60 +++-- 3 files changed, 15

[PATCH v4 bpf-next 08/14] selftests/bpf: add CO-RE relocs nesting tests

2019-08-06 Thread Andrii Nakryiko
Add a bunch of test validating correct handling of nested structs/unions. Signed-off-by: Andrii Nakryiko Acked-by: Song Liu --- .../selftests/bpf/prog_tests/core_reloc.c | 39 +++ .../bpf/progs/btf__core_reloc_nesting.c | 3 + .../btf__core_reloc_nesting___anon_embed.c| 3 +

[PATCH v4 bpf-next 09/14] selftests/bpf: add CO-RE relocs array tests

2019-08-06 Thread Andrii Nakryiko
Add tests for various array handling/relocation scenarios. Signed-off-by: Andrii Nakryiko Acked-by: Song Liu --- .../selftests/bpf/prog_tests/core_reloc.c | 41 ++ .../bpf/progs/btf__core_reloc_arrays.c| 3 + .../btf__core_reloc_arrays___diff_arr_dim.c | 3 + ...btf__cor

[PATCH v4 bpf-next 14/14] selftests/bpf: add CO-RE relocs misc tests

2019-08-06 Thread Andrii Nakryiko
Add tests validating few edge-cases of capturing offset relocations. Signed-off-by: Andrii Nakryiko --- .../selftests/bpf/prog_tests/core_reloc.c | 19 +++ .../bpf/progs/btf__core_reloc_misc.c | 5 ++ .../selftests/bpf/progs/core_reloc_types.h| 25 .../bpf/progs/te

[PATCH v4 bpf-next 13/14] selftests/bpf: add CO-RE relocs ints tests

2019-08-06 Thread Andrii Nakryiko
Add various tests validating handling compatible/incompatible integer types. Signed-off-by: Andrii Nakryiko Acked-by: Song Liu --- .../selftests/bpf/prog_tests/core_reloc.c | 40 +++ .../bpf/progs/btf__core_reloc_ints.c | 3 + .../bpf/progs/btf__core_reloc_ints___bool.c |

[PATCH v4 bpf-next 11/14] selftests/bpf: add CO-RE relocs modifiers/typedef tests

2019-08-06 Thread Andrii Nakryiko
Add tests validating correct handling of various combinations of typedefs and const/volatile/restrict modifiers. Signed-off-by: Andrii Nakryiko Acked-by: Song Liu --- .../selftests/bpf/prog_tests/core_reloc.c | 27 +++ .../bpf/progs/btf__core_reloc_mods.c | 3 + .../progs/btf_

[PATCH v4 bpf-next 07/14] selftests/bpf: add CO-RE relocs struct flavors tests

2019-08-06 Thread Andrii Nakryiko
Add tests verifying that BPF program can use various struct/union "flavors" to extract data from the same target struct/union. Signed-off-by: Andrii Nakryiko Acked-by: Song Liu --- .../selftests/bpf/prog_tests/core_reloc.c | 34 ++ .../bpf/progs/btf__core_reloc_flavors.c | 3

[PATCH v4 bpf-next 04/14] libbpf: implement BPF CO-RE offset relocation algorithm

2019-08-06 Thread Andrii Nakryiko
This patch implements the core logic for BPF CO-RE offsets relocations. Every instruction that needs to be relocated has corresponding bpf_offset_reloc as part of BTF.ext. Relocations are performed by trying to match recorded "local" relocation spec against potentially many compatible "target" type

[PATCH v4 bpf-next 01/14] libbpf: add helpers for working with BTF types

2019-08-06 Thread Andrii Nakryiko
Add lots of frequently used helpers that simplify working with BTF types. Signed-off-by: Andrii Nakryiko --- tools/lib/bpf/btf.h | 176 1 file changed, 176 insertions(+) diff --git a/tools/lib/bpf/btf.h b/tools/lib/bpf/btf.h index 88a52ae56fc6..63c93

[PATCH v4 bpf-next 12/14] selftests/bpf: add CO-RE relocs ptr-as-array tests

2019-08-06 Thread Andrii Nakryiko
Add test validating correct relocation handling for cases where pointer to something is used as an array. E.g.: int *ptr = ...; int x = ptr[42]; Signed-off-by: Andrii Nakryiko Acked-by: Song Liu --- .../selftests/bpf/prog_tests/core_reloc.c | 20 + .../bpf/progs/btf__core_r

[PATCH v4 bpf-next 05/14] selftests/bpf: add BPF_CORE_READ relocatable read macro

2019-08-06 Thread Andrii Nakryiko
Add BPF_CORE_READ macro used in tests to do bpf_core_read(), which automatically captures offset relocation. Signed-off-by: Andrii Nakryiko --- tools/testing/selftests/bpf/bpf_helpers.h | 20 1 file changed, 20 insertions(+) diff --git a/tools/testing/selftests/bpf/bpf_help

[PATCH v4 bpf-next 00/14] CO-RE offset relocations

2019-08-06 Thread Andrii Nakryiko
This patch set implements central part of CO-RE (Compile Once - Run Everywhere, see [0] and [1] for slides and video): relocating fields offsets. Most of the details are written down as comments to corresponding parts of the code. Patch #1 adds a bunch of commonly useful btf_xxx helpers to simplif

[PATCH v4 bpf-next 03/14] libbpf: add .BTF.ext offset relocation section loading

2019-08-06 Thread Andrii Nakryiko
Add support for BPF CO-RE offset relocations. Add section/record iteration macros for .BTF.ext. These macro are useful for iterating over each .BTF.ext record, either for dumping out contents or later for BPF CO-RE relocation handling. To enable other parts of libbpf to work with .BTF.ext contents

[PATCH v4 bpf-next 06/14] selftests/bpf: add CO-RE relocs testing setup

2019-08-06 Thread Andrii Nakryiko
Add CO-RE relocation test runner. Add one simple test validating that libbpf's logic for searching for kernel image and loading BTF out of it works. Signed-off-by: Andrii Nakryiko Acked-by: Song Liu --- .../selftests/bpf/prog_tests/core_reloc.c | 130 ++ .../bpf/progs/test_c

Re: [PATCH v2 bpf-next 1/4] bpf: unprivileged BPF access via /dev/bpf

2019-08-06 Thread Andy Lutomirski
On Mon, Aug 5, 2019 at 6:11 PM Alexei Starovoitov wrote: > > On Mon, Aug 05, 2019 at 02:25:35PM -0700, Andy Lutomirski wrote: > > It tries to make the kernel respect the access modes for fds. Without > > this patch, there seem to be some holes: nothing looked at program fds > > and, unless I miss

Re: [PATCH v2] net: mdio-octeon: Fix Kconfig warnings and build errors

2019-08-06 Thread Nathan Chancellor
On Tue, Aug 06, 2019 at 02:11:33PM -0700, David Miller wrote: > From: Nathan Chancellor > Date: Fri, 2 Aug 2019 23:01:56 -0700 > > > After commit 171a9bae68c7 ("staging/octeon: Allow test build on > > !MIPS"), the following combination of configs cause a few Kconfig > > warnings and build errors

Re: [RFC] implicit per-namespace devlink instance to set kernel resource limitations

2019-08-06 Thread David Ahern
On 8/6/19 8:59 PM, Andrew Lunn wrote: > However, zoom out a bit, from networking to the whole kernel. In > general, across the kernel as a whole, resource management is done > with cgroups. cgroups is the consistent operational model across the > kernel as a whole. > > So i think you need a second

[net-next v3] tipc: add loopback device tracking

2019-08-06 Thread john . rutherford
From: John Rutherford Since node internal messages are passed directly to the socket, it is not possible to observe those messages via tcpdump or wireshark. We now remedy this by making it possible to clone such messages and send the clones to the loopback interface. The clones are dropped at r

Re: [RFC] implicit per-namespace devlink instance to set kernel resource limitations

2019-08-06 Thread Andrew Lunn
On Tue, Aug 06, 2019 at 08:33:47PM -0600, David Ahern wrote: > Some time back supported was added for devlink 'resources'. The idea is > that hardware (mlxsw) has limited resources (e.g., memory) that can be > allocated in certain ways (e.g., kvd for mlxsw) thus implementing > restrictions on the n

Re: [RFC] implicit per-namespace devlink instance to set kernel resource limitations

2019-08-06 Thread David Ahern
Some time back supported was added for devlink 'resources'. The idea is that hardware (mlxsw) has limited resources (e.g., memory) that can be allocated in certain ways (e.g., kvd for mlxsw) thus implementing restrictions on the number of programmable entries (e.g., routes, neighbors) by userspace.

[v3,4/4] tools: bpftool: add documentation for net attach/detach

2019-08-06 Thread Daniel T. Lee
Since, new sub-command 'net attach/detach' has been added for attaching XDP program on interface, this commit documents usage and sample output of `net attach/detach`. Signed-off-by: Daniel T. Lee --- .../bpf/bpftool/Documentation/bpftool-net.rst | 51 +-- 1 file changed, 48 inse

[v3,2/4] tools: bpftool: add net detach command to detach XDP on interface

2019-08-06 Thread Daniel T. Lee
By this commit, using `bpftool net detach`, the attached XDP prog can be detached. Detaching the BPF prog will be done through libbpf 'bpf_set_link_xdp_fd' with the progfd set to -1. Signed-off-by: Daniel T. Lee --- tools/bpf/bpftool/net.c | 42 - 1 file c

[v3,1/4] tools: bpftool: add net attach command to attach XDP on interface

2019-08-06 Thread Daniel T. Lee
By this commit, using `bpftool net attach`, user can attach XDP prog on interface. New type of enum 'net_attach_type' has been made, as stated at cover-letter, the meaning of 'attach' is, prog will be attached on interface. With 'overwrite' option at argument, attached XDP program could be replace

[v3,0/4] tools: bpftool: add net attach/detach command to attach XDP prog

2019-08-06 Thread Daniel T. Lee
Currently, bpftool net only supports dumping progs attached on the interface. To attach XDP prog on interface, user must use other tool (eg. iproute2). By this patch, with `bpftool net attach/detach`, user can attach/detach XDP prog on interface. # bpftool prog 16: xdp name xdp_prog1

[v3,3/4] tools: bpftool: add bash-completion for net attach/detach

2019-08-06 Thread Daniel T. Lee
This commit adds bash-completion for new "net attach/detach" subcommand for attaching XDP program on interface. Signed-off-by: Daniel T. Lee --- tools/bpf/bpftool/bash-completion/bpftool | 64 +++ 1 file changed, 55 insertions(+), 9 deletions(-) diff --git a/tools/bpf/bpftoo

PARTNERSHIP REQUEST,

2019-08-06 Thread Simon Beron
Dear Friend, I need you to please let me know if there are fast growing investments in your country in which i can invest money in. I have access to a huge amount of money, which i want to invest in your country, i want to know if you can be an agent/partner to me and i will give you a commission

[PATCH net-next v7 1/6] cls_api: modify the tc_indr_block_ing_cmd parameters.

2019-08-06 Thread wenxu
From: wenxu This patch make tc_indr_block_ing_cmd can't access struct tc_indr_block_dev and tc_indr_block_cb. Signed-off-by: wenxu Acked-by: Jakub Kicinski --- v7: no change net/sched/cls_api.c | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/n

[PATCH net-next v7 5/6] flow_offload: support get multi-subsystem block

2019-08-06 Thread wenxu
From: wenxu It provide a callback list to find the blocks of tc and nft subsystems Signed-off-by: wenxu Acked-by: Jakub Kicinski --- v7: add a mutex lock for add/del flow_indr_block_ing_cb include/net/flow_offload.h | 10 - net/core/flow_offload.c| 51

[PATCH net-next v7 2/6] cls_api: remove the tcf_block cache

2019-08-06 Thread wenxu
From: wenxu Remove the tcf_block in the tc_indr_block_dev for muti-subsystem support. Signed-off-by: wenxu Acked-by: Jakub Kicinski --- v7: no change net/sched/cls_api.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/net/sched/cls_api.c b/net/sched/cls_a

[PATCH net-next v7 6/6] netfilter: nf_tables_offload: support indr block call

2019-08-06 Thread wenxu
From: wenxu nftable support indr-block call. It makes nftable an offload vlan and tunnel device. nft add table netdev firewall nft add chain netdev firewall aclout { type filter hook ingress offload device mlx_pf0vf0 priority - 300 \; } nft add rule netdev firewall aclout ip daddr 10.0.0.1 fwd

[PATCH net-next v7 3/6] cls_api: add flow_indr_block_call function

2019-08-06 Thread wenxu
From: wenxu This patch make indr_block_call don't access struct tc_indr_block_cb and tc_indr_block_dev directly Signed-off-by: wenxu Acked-by: Jakub Kicinski --- v7: no change net/sched/cls_api.c | 27 +-- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git

[PATCH net-next v7 4/6] flow_offload: move tc indirect block to flow offload

2019-08-06 Thread wenxu
From: wenxu move tc indirect block to flow_offload and rename it to flow indirect block.The nf_tables can use the indr block architecture. Signed-off-by: wenxu Acked-by: Jakub Kicinski --- v7: no change drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 10 +- .../net/ethernet/netronome/n

[PATCH net-next v7 0/6] flow_offload: add indr-block in nf_table_offload

2019-08-06 Thread wenxu
From: wenxu This series patch make nftables offload support the vlan and tunnel device offload through indr-block architecture. The first four patches mv tc indr block to flow offload and rename to flow-indr-block. Because the new flow-indr-block can't get the tcf_block directly. The fifth patch

Re: [PATCH net-next v6 5/6] flow_offload: support get multi-subsystem block

2019-08-06 Thread wenxu
在 2019/8/7 0:10, Pablo Neira Ayuso 写道: > >> >> +void flow_indr_add_block_ing_cb(struct flow_indr_block_ing_entry *entry) >> +{ > ... but registration does not protect the list with a mutex. > >> +list_add_tail_rcu(&entry->list, &block_ing_cb_list); >> +} >> +EXPORT_SYMBOL_GPL(flow_indr_add_

Re: [PATCH net] inet: frags: re-introduce skb coalescing for local delivery

2019-08-06 Thread Florian Westphal
Guillaume Nault wrote: > Before commit d4289fcc9b16 ("net: IP6 defrag: use rbtrees for IPv6 > defrag"), a netperf UDP_STREAM test[0] using big IPv6 datagrams (thus > generating many fragments) and running over an IPsec tunnel, reported > more than 6Gbps throughput. After that patch, the same test

Re: [PATCH bpf-next v5 0/3] selftests/bpf: switch test_progs back to stdio

2019-08-06 Thread Alexei Starovoitov
On Tue, Aug 6, 2019 at 10:45 AM Stanislav Fomichev wrote: > > I was looking into converting test_sockops* to test_progs framework > and that requires using cgroup_helpers.c which rely on stdio/stderr. > Let's use open_memstream to override stdout into buffer during > subtests instead of custom tes

[PATCH bpf 0/2] tools: bpftool: fix pinning error messages

2019-08-06 Thread Jakub Kicinski
Hi! First make sure we don't use "prog" in error messages because the pinning operation could be performed on a map. Second add back missing error message if pin syscall failed. Jakub Kicinski (2): tools: bpftool: fix error message (prog -> object) tools: bpftool: add error message on pin fai

[PATCH bpf 1/2] tools: bpftool: fix error message (prog -> object)

2019-08-06 Thread Jakub Kicinski
Change an error message to work for any object being pinned not just programs. Fixes: 71bb428fe2c1 ("tools: bpf: add bpftool") Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet --- tools/bpf/bpftool/common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/bpf/b

[PATCH bpf 2/2] tools: bpftool: add error message on pin failure

2019-08-06 Thread Jakub Kicinski
No error message is currently printed if the pin syscall itself fails. It got lost in the loadall refactoring. Fixes: 77380998d91d ("bpftool: add loadall command") Reported-by: Andy Lutomirski Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet --- CC: l...@kernel.org, s...@google.com t

Re: [PATCH net-next v6 5/6] flow_offload: support get multi-subsystem block

2019-08-06 Thread wenxu
在 2019/8/7 0:10, Pablo Neira Ayuso 写道: > On Sun, Aug 04, 2019 at 09:24:00PM +0800, we...@ucloud.cn wrote: >> diff --git a/include/net/flow_offload.h b/include/net/flow_offload.h >> index 8f1a7b8..6022dd0 100644 >> --- a/include/net/flow_offload.h >> +++ b/include/net/flow_offload.h > [...] >> @@

Re: [net] ixgbe: fix possible deadlock in ixgbe_service_task()

2019-08-06 Thread David Miller
From: Jeff Kirsher Date: Mon, 5 Aug 2019 13:04:03 -0700 > diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c > b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c > index cbaf712d6529..3386e752e458 100644 > --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c > +++ b/drivers/net/ethernet/int

Re: [PATCH net] netdevsim: Restore per-network namespace accounting for fib entries

2019-08-06 Thread Jakub Kicinski
On Tue, 6 Aug 2019 12:15:17 -0700, David Ahern wrote: > From: David Ahern > > Prior to the commit in the fixes tag, the resource controller in netdevsim > tracked fib entries and rules per network namespace. Restore that behavior. > > Fixes: 5fc494225c1e ("netdevsim: create devlink instance per

Re: [PATCH] net: dsa: qca8k: Add of_node_put() in qca8k_setup_mdio_bus()

2019-08-06 Thread David Miller
From: Nishka Dasgupta Date: Sun, 4 Aug 2019 21:00:18 +0530 > Each iteration of for_each_available_child_of_node() puts the previous > node, but in the case of a return from the middle of the loop, there > is no put, thus causing a memory leak. Hence add an of_node_put() before > the return. > Ad

Re: [net-next v2 0/8][pull request] 40GbE Intel Wired LAN Driver Updates 2019-08-05

2019-08-06 Thread David Miller
From: Jeff Kirsher Date: Mon, 5 Aug 2019 11:54:51 -0700 > This series contains updates to i40e driver only. Pulled, thanks Jeff.

Re: [PATCH net-next v2] openvswitch: Print error when ovs_execute_actions() fails

2019-08-06 Thread David Miller
From: Yifeng Sun Date: Sun, 4 Aug 2019 19:56:11 -0700 > Currently in function ovs_dp_process_packet(), return values of > ovs_execute_actions() are silently discarded. This patch prints out > an debug message when error happens so as to provide helpful hints > for debugging. > --- > v1->v2: Fixe

Re: [PATCH net 0/5] Fixes for SJA1105 DSA: FDBs, Learning and PTP

2019-08-06 Thread David Miller
From: Vladimir Oltean Date: Mon, 5 Aug 2019 01:38:43 +0300 > This is an assortment of functional fixes for the sja1105 switch driver > targeted for the "net" tree (although they apply on net-next just as > well). > > Patch 1/5 ("net: dsa: sja1105: Fix broken learning with vlan_filtering > disab

Re: [PATCH net-next 00/10] Support tunnels over VLAN in NFP

2019-08-06 Thread David Miller
From: John Hurley Date: Sun, 4 Aug 2019 16:09:02 +0100 > This patchset deals with tunnel encap and decap when the end-point IP > address is on an internal port (for example and OvS VLAN port). Tunnel > encap without VLAN is already supported in the NFP driver. This patchset > extends that to inc

Re: [net-next 0/8][pull request] 100GbE Intel Wired LAN Driver Updates 2019-08-04

2019-08-06 Thread David Miller
From: Jeff Kirsher Date: Sun, 4 Aug 2019 04:59:18 -0700 > This series contains more updates to fm10k from Jake Keller. > > Jake removes the unnecessary initialization of some variables to help > resolve static code checker warnings. Explicitly return success during > resume, since the value of

Re: [PATCH net-next] r8169: sync PCIe PHY init with vendor driver 8.047.01

2019-08-06 Thread David Miller
From: Heiner Kallweit Date: Sun, 4 Aug 2019 09:52:33 +0200 > Synchronize PCIe PHY initialization with vendor driver version 8.047.01. > > Signed-off-by: Heiner Kallweit Applied.

Re: [PATCH net-next] r8169: add helper r8168_mac_ocp_modify

2019-08-06 Thread David Miller
From: Heiner Kallweit Date: Sun, 4 Aug 2019 09:47:51 +0200 > Add a helper for MAC OCP read-modify-write operations. > > Signed-off-by: Heiner Kallweit Applied.

Re: [PATCH net-next] r8169: remove access to legacy register MultiIntr

2019-08-06 Thread David Miller
From: Heiner Kallweit Date: Sun, 4 Aug 2019 09:42:57 +0200 > This code piece was inherited from RTL8139 code, the register at > address 0x5c however has a different meaning on RTL8169 and is unused. > So we can remove this. > > Signed-off-by: Heiner Kallweit Applied.

Re: [PATCH net-next 0/2] Two small fq_codel optimizations

2019-08-06 Thread David Miller
From: Dave Taht Date: Sat, 3 Aug 2019 16:37:27 -0700 > These two patches improve fq_codel performance > under extreme network loads. The first patch > more rapidly escalates the codel count under > overload, the second just kills a totally useless > statistic. > > (sent together because they

Re: [PATCH net 0/2] action fixes for flow_offload infra compatibility

2019-08-06 Thread David Miller
From: Vlad Buslov Date: Sat, 3 Aug 2019 16:36:17 +0300 > Fix rcu warnings due to usage of action helpers that expect rcu read lock > protection from rtnl-protected context of flow_offload infra. Series applied.

Re: [PATCH v2] net: mdio-octeon: Fix Kconfig warnings and build errors

2019-08-06 Thread David Miller
From: Nathan Chancellor Date: Fri, 2 Aug 2019 23:01:56 -0700 > After commit 171a9bae68c7 ("staging/octeon: Allow test build on > !MIPS"), the following combination of configs cause a few Kconfig > warnings and build errors (distilled from arm allyesconfig and Randy's > randconfig builds): > >

Re: [PATCH net-next] net: dsa: dump CPU port regs through master

2019-08-06 Thread David Miller
From: Vivien Didelot Date: Fri, 2 Aug 2019 15:34:55 -0400 > Merge the CPU port registers dump into the master interface registers > dump through ethtool, by nesting the ethtool_drvinfo and ethtool_regs > structures of the CPU port into the dump. > > drvinfo->regdump_len will contain the full da

Re: [PATCH net 0/2] Fix batched event generation for vlan action

2019-08-06 Thread David Miller
From: Roman Mashak Date: Fri, 2 Aug 2019 15:16:45 -0400 > When adding or deleting a batch of entries, the kernel sends up to > TCA_ACT_MAX_PRIO (defined to 32 in kernel) entries in an event to user > space. However it does not consider that the action sizes may vary and > require different skb s

Re: [PATCH net] inet: frags: re-introduce skb coalescing for local delivery

2019-08-06 Thread David Miller
From: Guillaume Nault Date: Fri, 2 Aug 2019 17:15:03 +0200 > Before commit d4289fcc9b16 ("net: IP6 defrag: use rbtrees for IPv6 > defrag"), a netperf UDP_STREAM test[0] using big IPv6 datagrams (thus > generating many fragments) and running over an IPsec tunnel, reported > more than 6Gbps through

Re: [PATCH 03/17] mlx5: no need to check return value of debugfs_create functions

2019-08-06 Thread Saeed Mahameed
On Tue, 2019-08-06 at 18:11 +0200, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic > should > never do something different based on this. > > This cleans up a lot of unneeded code and l

Re: [PATCH net-next] mlx5: use correct counter

2019-08-06 Thread Jonathan Lemon
On 6 Aug 2019, at 12:03, Saeed Mahameed wrote: > On Tue, 2019-08-06 at 11:28 -0700, Jonathan Lemon wrote: >> mlx5e_grp_q_update_stats seems to be using the wrong counter >> for if_down_packets. >> >> Signed-off-by: Jonathan Lemon >> --- >> drivers/net/ethernet/mellanox/mlx5/core/en_stats.c | 2 +

Re: [PATCH 17/17] ieee802154: no need to check return value of debugfs_create functions

2019-08-06 Thread Greg Kroah-Hartman
On Tue, Aug 06, 2019 at 09:22:43PM +0200, Stefan Schmidt wrote: > Hello. > > On 06.08.19 18:11, Greg Kroah-Hartman wrote: > > When calling debugfs functions, there is no need to ever check the > > return value. The function can work or not, but the code logic should > > never do something differe

Re: [PATCH 03/17] mlx5: no need to check return value of debugfs_create functions

2019-08-06 Thread gre...@linuxfoundation.org
On Tue, Aug 06, 2019 at 07:41:57PM +, Saeed Mahameed wrote: > On Tue, 2019-08-06 at 18:11 +0200, Greg Kroah-Hartman wrote: > > When calling debugfs functions, there is no need to ever check the > > return value. The function can work or not, but the code logic > > should > > never do something

Re: [PATCH 03/17] mlx5: no need to check return value of debugfs_create functions

2019-08-06 Thread Saeed Mahameed
On Tue, 2019-08-06 at 18:11 +0200, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic > should > never do something different based on this. > > This cleans up a lot of unneeded code and l

Re: [PATCH net-next 0/6] drop_monitor: Various improvements and cleanups

2019-08-06 Thread David Miller
From: Ido Schimmel Date: Tue, 6 Aug 2019 16:19:50 +0300 > From: Ido Schimmel > > This patchset performs various improvements and cleanups in drop monitor > with no functional changes intended. There are no changes in these > patches relative to the RFC I sent two weeks ago [1]. > > A followup

Re: [PATCH 17/17] ieee802154: no need to check return value of debugfs_create functions

2019-08-06 Thread Stefan Schmidt
Hello. On 06.08.19 18:11, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Michael Hennerich > Cc: Alexander Aring > Cc: S

Re: [PATCH net-next v2 1/1] qed: Add new ethtool supported port types based on media.

2019-08-06 Thread Jakub Kicinski
On Mon, 5 Aug 2019 23:59:50 -0700, Rahul Verma wrote: > Supported ports in ethtool are displayed based on media type. > For media type fibre and twinaxial, port type is "FIBRE". Media type > Base-T is "TP" and media KR is "Backplane". > > V1->V2: > Corrected the subject. > > Signed-off-by: Rahul

[PATCH net] netdevsim: Restore per-network namespace accounting for fib entries

2019-08-06 Thread David Ahern
From: David Ahern Prior to the commit in the fixes tag, the resource controller in netdevsim tracked fib entries and rules per network namespace. Restore that behavior. Fixes: 5fc494225c1e ("netdevsim: create devlink instance per netdevsim instance") Signed-off-by: David Ahern --- drivers/net

Re: [PATCH net] hv_netvsc: Fix a warning of suspicious RCU usage

2019-08-06 Thread Jakub Kicinski
On Tue, 6 Aug 2019 05:17:44 +, Dexuan Cui wrote: > This fixes a warning of "suspicious rcu_dereference_check() usage" > when nload runs. > > Signed-off-by: Stephen Hemminger > Signed-off-by: Dexuan Cui Minor change in behaviour would perhaps be worth acknowledging in the commit message (sin

Re: [RFC] implicit per-namespace devlink instance to set kernel resource limitations

2019-08-06 Thread Andrew Lunn
On Tue, Aug 06, 2019 at 11:54:49AM -0700, Jakub Kicinski wrote: > On Tue, 6 Aug 2019 20:38:41 +0200, Jiri Pirko wrote: > > >> So the proposal is to have some new device, say "kernelnet", that > > >> would implicitly create per-namespace devlink instance. This devlink > > >> instance would be used t

Re: [PATCH net-next] mlx5: use correct counter

2019-08-06 Thread Saeed Mahameed
On Tue, 2019-08-06 at 11:28 -0700, Jonathan Lemon wrote: > mlx5e_grp_q_update_stats seems to be using the wrong counter > for if_down_packets. > > Signed-off-by: Jonathan Lemon > --- > drivers/net/ethernet/mellanox/mlx5/core/en_stats.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [PATCH 2/3] net: dsa: ksz: Merge ksz_priv.h into ksz_common.h

2019-08-06 Thread David Miller
From: Marek Vasut Date: Tue, 6 Aug 2019 15:06:08 +0200 > Merge the two headers into one, no functional change. > > Signed-off-by: Marek Vasut Applied.

Re: [PATCH 3/3] net: dsa: ksz: Drop NET_DSA_TAG_KSZ9477

2019-08-06 Thread David Miller
From: Marek Vasut Date: Tue, 6 Aug 2019 15:06:09 +0200 > This Kconfig option is unused, drop it. > > Signed-off-by: Marek Vasut Applied.

Re: [PATCH 1/3] net: dsa: ksz: Remove dead code and fix warnings

2019-08-06 Thread David Miller
From: Marek Vasut Date: Tue, 6 Aug 2019 15:06:07 +0200 > Remove ksz_port_cleanup(), which is unused. Add missing include > "ksz_common.h", which fixes the following warning when built with > make ... W=1 > > drivers/net/dsa/microchip/ksz_common.c:23:6: warning: no previous prototype > for ‘...

Re: [RFC] implicit per-namespace devlink instance to set kernel resource limitations

2019-08-06 Thread Jakub Kicinski
On Tue, 6 Aug 2019 20:38:41 +0200, Jiri Pirko wrote: > >> So the proposal is to have some new device, say "kernelnet", that > >> would implicitly create per-namespace devlink instance. This devlink > >> instance would be used to setup resource limits. Like: > >> > >> devlink resource set kernelnet

Re: [PATCH v3 net-next] be2net: disable bh with spin_lock in be_process_mcc

2019-08-06 Thread David Miller
From: Denis Kirjanov Date: Tue, 6 Aug 2019 12:51:11 +0200 > be_process_mcc() is invoked in 3 different places and > always with BHs disabled except the be_poll function > but since it's invoked from softirq with BHs > disabled it won't hurt. > > v1->v2: added explanation to the patch > v2->v3:

Re: [PATCH] net: sched: sch_taprio: fix memleak in error path for sched list parse

2019-08-06 Thread David Miller
From: Ivan Khoronzhuk Date: Tue, 6 Aug 2019 13:04:25 +0300 > Based on net/master I wonder about that because: > --- a/net/sched/sch_taprio.c > +++ b/net/sched/sch_taprio.c > @@ -1451,7 +1451,8 @@ static int taprio_change(struct Qdisc *sch, struct > nlattr *opt, > spin_unlock_bh(qdisc_lo

Re: [PATCH 0/2 net,v4] flow_offload hardware priority fixes

2019-08-06 Thread Jakub Kicinski
On Tue, 6 Aug 2019 18:03:08 +0200, Pablo Neira Ayuso wrote: > Hi, > > This patchset contains two updates for the flow_offload users: > > 1) Pass the major tc priority to drivers so they do not have to >lshift it. This is a preparation patch for the fix coming in >patch #2. > > 2) Set th

Re: [RFC] implicit per-namespace devlink instance to set kernel resource limitations

2019-08-06 Thread Jiri Pirko
Tue, Aug 06, 2019 at 08:27:17PM CEST, jakub.kicin...@netronome.com wrote: >On Tue, 6 Aug 2019 18:40:36 +0200, Jiri Pirko wrote: >> Hi all. >> >> I just discussed this with DavidA and I would like to bring this to >> broader audience. David wants to limit kernel resources in network >> namespaces,

[PATCH net-next] mlx5: use correct counter

2019-08-06 Thread Jonathan Lemon
mlx5e_grp_q_update_stats seems to be using the wrong counter for if_down_packets. Signed-off-by: Jonathan Lemon --- drivers/net/ethernet/mellanox/mlx5/core/en_stats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c b/drivers

Re: [RFC] implicit per-namespace devlink instance to set kernel resource limitations

2019-08-06 Thread Jakub Kicinski
On Tue, 6 Aug 2019 18:40:36 +0200, Jiri Pirko wrote: > Hi all. > > I just discussed this with DavidA and I would like to bring this to > broader audience. David wants to limit kernel resources in network > namespaces, for example fibs, fib rules, etc. > > He claims that devlink api is rich enough

Re: [patch net-next v2 1/3] net: devlink: allow to change namespaces

2019-08-06 Thread Jiri Pirko
Tue, Aug 06, 2019 at 07:55:30PM CEST, dsah...@gmail.com wrote: >On 8/6/19 11:53 AM, Jiri Pirko wrote: >> Let's figure out the devlink-controlling-kernel-resources thread first. >> What you describe here is exactly that. > >as I mentioned on the phone, any outcome of that thread will be in 5.4 >at b

Re: [RFC] implicit per-namespace devlink instance to set kernel resource limitations

2019-08-06 Thread Andrew Lunn
On Tue, Aug 06, 2019 at 11:38:32AM -0600, David Ahern wrote: > On 8/6/19 10:40 AM, Jiri Pirko wrote: > > Hi all. > > > > I just discussed this with DavidA and I would like to bring this to > > broader audience. David wants to limit kernel resources in network > > namespaces, for example fibs, fib

Re: [patch net-next v2 1/3] net: devlink: allow to change namespaces

2019-08-06 Thread David Ahern
On 8/6/19 11:53 AM, Jiri Pirko wrote: > Let's figure out the devlink-controlling-kernel-resources thread first. > What you describe here is exactly that. as I mentioned on the phone, any outcome of that thread will be in 5.4 at best. Meanwhile this breakage in 5.2 and 5.3 needs to be fixed.

Re: [PATCH bpf-next v4 1/3] selftests/bpf: test_progs: switch to open_memstream

2019-08-06 Thread Andrii Nakryiko
On Tue, Aug 6, 2019 at 10:54 AM Stanislav Fomichev wrote: > > On 08/06, Andrii Nakryiko wrote: > > On Tue, Aug 6, 2019 at 10:40 AM Stanislav Fomichev wrote: > > > > > > On 08/06, Andrii Nakryiko wrote: > > > > On Tue, Aug 6, 2019 at 10:19 AM Stanislav Fomichev > > > > wrote: > > > > > > > > > >

Re: [PATCH bpf-next v4 1/3] selftests/bpf: test_progs: switch to open_memstream

2019-08-06 Thread Stanislav Fomichev
On 08/06, Andrii Nakryiko wrote: > On Tue, Aug 6, 2019 at 10:40 AM Stanislav Fomichev wrote: > > > > On 08/06, Andrii Nakryiko wrote: > > > On Tue, Aug 6, 2019 at 10:19 AM Stanislav Fomichev > > > wrote: > > > > > > > > Use open_memstream to override stdout during test execution. > > > > The cop

Re: [patch net-next v2 1/3] net: devlink: allow to change namespaces

2019-08-06 Thread Jiri Pirko
Tue, Aug 06, 2019 at 07:34:59PM CEST, dsah...@gmail.com wrote: >On 8/5/19 9:20 AM, Jiri Pirko wrote: >> Mon, Aug 05, 2019 at 04:51:22PM CEST, dsah...@gmail.com wrote: >>> On 8/5/19 8:49 AM, Jiri Pirko wrote: > Your commit 5fc494225c1eb81309cc4c91f183cd30e4edb674 changed that from a > per-na

[sas...@kernel.org: Re: Back-porting request]

2019-08-06 Thread Stephen Suryaputra
Hi, How do I request back-porting of commit 5b18f1289808 ("ipv4: reset rt_iif for recirculated mcast/bcast out pkts") quoted below? I think for 4.19, the following diff is needed in addition to the commit: diff --git a/net/ipv4/route.c b/net/ipv4/route.c index cd84f7f68032..120ef1f284fa 100644 --

Re: [PATCH bpf-next v4 1/3] selftests/bpf: test_progs: switch to open_memstream

2019-08-06 Thread Andrii Nakryiko
On Tue, Aug 6, 2019 at 10:40 AM Stanislav Fomichev wrote: > > On 08/06, Andrii Nakryiko wrote: > > On Tue, Aug 6, 2019 at 10:19 AM Stanislav Fomichev wrote: > > > > > > Use open_memstream to override stdout during test execution. > > > The copy of the original stdout is held in env.stdout and use

[PATCH bpf-next v5 2/3] selftests/bpf: test_progs: test__printf -> printf

2019-08-06 Thread Stanislav Fomichev
Now that test__printf is a simple wraper around printf, let's drop it (and test__vprintf as well). Cc: Andrii Nakryiko Acked-by: Andrii Nakryiko Signed-off-by: Stanislav Fomichev --- .../selftests/bpf/prog_tests/bpf_verif_scale.c | 4 ++-- .../testing/selftests/bpf/prog_tests/l4lb_all.c |

[PATCH bpf-next v5 0/3] selftests/bpf: switch test_progs back to stdio

2019-08-06 Thread Stanislav Fomichev
I was looking into converting test_sockops* to test_progs framework and that requires using cgroup_helpers.c which rely on stdio/stderr. Let's use open_memstream to override stdout into buffer during subtests instead of custom test_{v,}printf wrappers. That lets us continue to use stdio in the subt

[PATCH bpf-next v5 3/3] selftests/bpf: test_progs: drop extra trailing tab

2019-08-06 Thread Stanislav Fomichev
Small (un)related cleanup. Cc: Andrii Nakryiko Acked-by: Andrii Nakryiko Signed-off-by: Stanislav Fomichev --- tools/testing/selftests/bpf/test_progs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/bpf/test_progs.c b/tools/testing/selftests/bpf/te

[PATCH bpf-next v5 1/3] selftests/bpf: test_progs: switch to open_memstream

2019-08-06 Thread Stanislav Fomichev
Use open_memstream to override stdout during test execution. The copy of the original stdout is held in env.stdout and used to print subtest info and dump failed log. test_{v,}printf are now simple wrappers around stdout and will be removed in the next patch. v5: * fix -v crash by always setting

Re: [PATCH 12/17] skge: no need to check return value of debugfs_create functions

2019-08-06 Thread Stephen Hemminger
On Tue, 6 Aug 2019 18:11:23 +0200 Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Mirko Lindner > Cc: Stephen Hemminger

Re: [PATCH bpf-next v4 1/3] selftests/bpf: test_progs: switch to open_memstream

2019-08-06 Thread Stanislav Fomichev
On 08/06, Andrii Nakryiko wrote: > On Tue, Aug 6, 2019 at 10:19 AM Stanislav Fomichev wrote: > > > > Use open_memstream to override stdout during test execution. > > The copy of the original stdout is held in env.stdout and used > > to print subtest info and dump failed log. > > > > test_{v,}print

Re: [RFC] implicit per-namespace devlink instance to set kernel resource limitations

2019-08-06 Thread David Ahern
On 8/6/19 10:40 AM, Jiri Pirko wrote: > Hi all. > > I just discussed this with DavidA and I would like to bring this to > broader audience. David wants to limit kernel resources in network > namespaces, for example fibs, fib rules, etc. > > He claims that devlink api is rich enough to program thi

  1   2   >