Re: [PATCH net-next v2] can: fix ioctl function removal

2019-07-29 Thread Oliver Hartkopp
According to Marc the original patch has already been applied by Dave. https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/commit/?id=473d924d7d46cb57aa4c1863261d18366af345af Thanks for the support & sorry for the noise! Best regards, Oliver On 30/07/2019 08.43, Oliver Hartkopp

[PATCH net-next v2] can: fix ioctl function removal

2019-07-29 Thread Oliver Hartkopp
Commit 60649d4e0af6c26b ("can: remove obsolete empty ioctl() handler") replaced the almost empty can_ioctl() function with sock_no_ioctl() which always returns -EOPNOTSUPP. Even though we don't have any ioctl() functions on socket/network layer we need to return -ENOIOCTLCMD to be able to forward

Re: [PATCH net-next] can: fix ioctl function removal

2019-07-29 Thread Marc Kleine-Budde
On 7/29/19 10:40 PM, Oliver Hartkopp wrote: > Commit 60649d4e0af ("can: remove obsolete empty ioctl() handler") replaced the > almost empty can_ioctl() function with sock_no_ioctl() which always returns > -EOPNOTSUPP. > > Even though we don't have any ioctl() functions on socket/network layer we

Re: [patch net-next 0/3] net: devlink: Finish network namespace support

2019-07-29 Thread Jiri Pirko
Mon, Jul 29, 2019 at 10:17:25PM CEST, dsah...@gmail.com wrote: >On 7/27/19 3:44 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Devlink from the beginning counts with network namespaces, but the >> instances has been fixed to init_net. The first patch allows user >> to move existing devlink insta

Re: [patch iproute2 1/2] devlink: introduce cmdline option to switch to a different namespace

2019-07-29 Thread Jiri Pirko
Mon, Jul 29, 2019 at 10:21:11PM CEST, dsah...@gmail.com wrote: >On 7/27/19 4:21 AM, Jiri Pirko wrote: diff --git a/devlink/devlink.c b/devlink/devlink.c index d8197ea3a478..9242cc05ad0c 100644 --- a/devlink/devlink.c +++ b/devlink/devlink.c @@ -32,6 +32,7 @@ #include

Re: [patch net-next 3/3] netdevsim: create devlink and netdev instances in namespace

2019-07-29 Thread Jiri Pirko
Mon, Jul 29, 2019 at 08:59:06PM CEST, jakub.kicin...@netronome.com wrote: >On Sat, 27 Jul 2019 11:44:59 +0200, Jiri Pirko wrote: >> From: Jiri Pirko >> >> When user does create new netdevsim instance using sysfs bus file, >> create the devlink instance and related netdev instance in the namespace

Re: [patch net-next 1/3] net: devlink: allow to change namespaces

2019-07-29 Thread Jiri Pirko
Mon, Jul 29, 2019 at 07:52:16PM CEST, da...@davemloft.net wrote: >From: Jiri Pirko >Date: Sat, 27 Jul 2019 11:44:57 +0200 > >> +if ((netns_pid_attr && (netns_fd_attr || netns_id_attr)) || >> +(netns_fd_attr && (netns_pid_attr || netns_id_attr)) || >> +(netns_id_attr && (netns_p

Re: [PATCH bpf-next 00/10] CO-RE offset relocations

2019-07-29 Thread Song Liu
> On Jul 29, 2019, at 4:09 PM, Andrii Nakryiko > wrote: > > On Mon, Jul 29, 2019 at 1:37 PM Song Liu wrote: >> >> On Mon, Jul 29, 2019 at 1:20 PM Song Liu wrote: >>> >>> On Wed, Jul 24, 2019 at 1:34 PM Andrii Nakryiko wrote: This patch set implements central part of CO-RE (Com

Re: [PATCH v2 bpf-next 1/4] bpf: unprivileged BPF access via /dev/bpf

2019-07-29 Thread Song Liu
Hi Andy, > On Jul 27, 2019, at 11:20 AM, Song Liu wrote: > > Hi Andy, > > Well, yes. sys_bpf() is pretty powerful. The goal of /dev/bpf is to enable special users to call sys_bpf(). In the meanwhile, such users should not take down the whole system easily >>>

Re: [PATCH v4 13/13] ARM: dts: sunxi: Switch from phy to phy-handle

2019-07-29 Thread Chen-Yu Tsai
On Thu, Jun 27, 2019 at 11:32 PM Maxime Ripard wrote: > > The phy device tree property has been deprecated in favor of phy-handle, > let's replace it. > > Signed-off-by: Maxime Ripard This patch breaks Ethernet on all my dwmac-sunxi, i.e. old GMAC, boards, with the following error messages:

RE: [PATCH net-next v3 2/2] qed: Add driver API for flashing the config attributes.

2019-07-29 Thread Sudarsana Reddy Kalluru
> -Original Message- > From: David Miller > Sent: Monday, July 29, 2019 11:34 PM > To: Sudarsana Reddy Kalluru > Cc: netdev@vger.kernel.org; Michal Kalderon ; > Ariel Elior > Subject: Re: [PATCH net-next v3 2/2] qed: Add driver API for flashing the > config attributes. > > From: Sudarsa

Re: [PATCH v3] net: dsa: qca8k: enable port flow control

2019-07-29 Thread xiaofeis
On 2019-07-29 21:23, Andrew Lunn wrote: But our qca8k HW can auto sync the pause status to MAC from phy with the auto-negotiated result. So no need to set in qca8k_adjust_link, since there is one setting in qca8k_port_set_status: mask |= QCA8K_PORT_STATUS_LINK_AUTO; How does the auto-sync actu

[PATCH V2] can: flexcan: fix deadlock when using self wakeup

2019-07-29 Thread Joakim Zhang
As reproted by Sean Nyekjaer below: When suspending, when there is still can traffic on the interfaces the flexcan immediately wakes the platform again. As it should :-). But it throws this error msg: [ 3169.378661] PM: noirq suspend of devices failed On the way down to suspend the interface that

[net-next:master 57/61] arch/mips/include/asm/octeon/cvmx-ipd.h:330:27: error: storage size of 'pip_sft_rst' isn't known

2019-07-29 Thread kbuild test robot
tree: https://kernel.googlesource.com/pub/scm/linux/kernel/git/davem/net-next.git master head: 85fd8011475e86265beff7b7617c493c247f5356 commit: 171a9bae68c72f2d1260c3825203760856e6793b [57/61] staging/octeon: Allow test build on !MIPS config: mips-allmodconfig (attached as .config) compiler:

Re: [PATCH net-next v4 2/3] flow_offload: Support get default block from tc immediately

2019-07-29 Thread wenxu
在 2019/7/30 0:55, Jakub Kicinski 写道: > On Mon, 29 Jul 2019 15:18:03 +0800, wenxu wrote: >> On 7/29/2019 12:42 PM, Jakub Kicinski wrote: >>> On Mon, 29 Jul 2019 10:43:56 +0800, wenxu wrote: On 7/29/2019 4:16 AM, Jakub Kicinski wrote: > I don't know the nft code, but it seems unlikely

[net-next 13/13] net/mlx5e: Protect tc flow table with mutex

2019-07-29 Thread Saeed Mahameed
From: Vlad Buslov TC flow table is created when first flow is added, and destroyed when last flow is removed. This assumes that all accesses to the table are externally synchronized with rtnl lock. To remove dependency on rtnl lock, add new mutex mlx5e_tc_table->t_lock and use it to protect the f

[net-next 11/13] net/mlx5e: Eswitch, use state_lock to synchronize vlan change

2019-07-29 Thread Saeed Mahameed
From: Vlad Buslov esw->state_lock is already used to protect vlan vport configuration change. However, all preparation and correctness checks, and code that sets vport data are not protected by this lock and assume external synchronization by rtnl lock. In order to remove dependency on rtnl lock,

[net-next 07/13] net/mlx5e: Change flow flags type to unsigned long

2019-07-29 Thread Saeed Mahameed
From: Vlad Buslov To remove dependency on rtnl lock and allow concurrent modification of 'flags' field of tc flow structure, change flow flag type to unsigned long and use atomic bit ops for reading and changing the flags. Implement auxiliary functions for setting, resetting and getting specific

[net-next 12/13] net/mlx5e: Rely on rcu instead of rtnl lock when getting upper dev

2019-07-29 Thread Saeed Mahameed
From: Vlad Buslov Function netdev_master_upper_dev_get() generates warning if caller doesn't hold rtnl lock. Modify rules update path to use rcu version of that function. Signed-off-by: Vlad Buslov Reviewed-by: Jianbo Liu Reviewed-by: Roi Dayan Signed-off-by: Saeed Mahameed --- .../net/ethe

[net-next 06/13] net/mlx5e: Extend tc flow struct with reference counter

2019-07-29 Thread Saeed Mahameed
From: Vlad Buslov With new classifier type that doesn't require rtnl lock, following invariant holds: - Filter with specified cookie created only once. - Filter with specified cookie deleted only once. - Stats updates can be performed in parallel to each other. Extend tc flow with rcu and ref

[net-next 09/13] net/mlx5e: Protect unready flows with dedicated lock

2019-07-29 Thread Saeed Mahameed
From: Vlad Buslov In order to remove dependency on rtnl lock for protecting unready_flows list when reoffloading unready flows on workqueue, extend representor uplink private structure with dedicated 'unready_flows_lock' mutex. Take the lock in all users of unready_flows list before accessing it.

[net-next 01/13] net/mlx5e: Print a warning when LRO feature is dropped or not allowed

2019-07-29 Thread Saeed Mahameed
From: Huy Nguyen When user enables LRO via ethtool and if the RQ mode is legacy, mlx5e_fix_features drops the request without any explanation. Add netdev_warn to cover this case. Fixes: 6c3a823e1e9c ("net/mlx5e: RX, Remove HW LRO support in legacy RQ") Signed-off-by: Huy Nguyen Signed-off-by: S

[net-next 03/13] net/mlx5e: Improve ethtool rxnfc callback structure

2019-07-29 Thread Saeed Mahameed
Don't choose who implements the rxnfc "get/set" callbacks according to CONFIG_MLX5_EN_RXNFC, instead have the callbacks always available and delegate to a function of a different driver module when needed (en_fs_ethtool.c), have stubs in en/fs.h to fallback to when en_fs_ethtool.c is compiled out,

[pull request][net-next 00/13] Mellanox, mlx5 tc flow handling for concurrent execution (Part 1)

2019-07-29 Thread Saeed Mahameed
Hi Dave, This series, mostly from Vlad, is the first part of ongoing work to improve mlx5 tc flow handling by removing dependency on rtnl_lock and providing a more fine-grained locking and rcu safe data structures. For more information please see tag log below. Please pull and let me know if the

[net-next 08/13] net/mlx5e: Protect tc flows hashtable with rcu

2019-07-29 Thread Saeed Mahameed
From: Vlad Buslov In order to remove dependency on rtnl lock, access to tc flows hashtable must be explicitly protected from concurrent flows removal. Extend tc flow structure with rcu to allow concurrent parallel access. Use rcu read lock to safely lookup flow in tc flows hash table, and take r

[net-next 02/13] net/mlx5e: Avoid warning print when not required

2019-07-29 Thread Saeed Mahameed
When disabling CQE compression in favor of time-stamping, don't show a warning when CQE compression is already disabled. Reviewed-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --

[net-next 10/13] net/mlx5e: Eswitch, change offloads num_flows type to atomic64

2019-07-29 Thread Saeed Mahameed
From: Vlad Buslov Eswitch implements its own locking by means of state_lock mutex and multiple fine-grained lock in containing data structures, and is supposed to not rely on rtnl lock. However, eswitch offloads num_flows type is a regular long long integer and cannot be modified concurrently. Th

[net-next 05/13] net/mlx5e: Simplify get_route_and_out_devs helper function

2019-07-29 Thread Saeed Mahameed
From: Eli Britstein The helper function has "if" branches that do the same. Merge them to simplify the code. Signed-off-by: Eli Britstein Reviewed-by: Roi Dayan Signed-off-by: Saeed Mahameed --- .../ethernet/mellanox/mlx5/core/en/tc_tun.c | 19 +++ 1 file changed, 7 inserti

[net-next 04/13] net/mlx5e: Fix unnecessary flow_block_cb_is_busy call

2019-07-29 Thread Saeed Mahameed
From: wenxu When call flow_block_cb_is_busy. The indr_priv is guaranteed to NULL ptr. So there is no need to call flow_bock_cb_is_busy. Fixes: 0d4fd02e7199 ("net: flow_offload: add flow_block_cb_is_busy() and use it") Signed-off-by: wenxu Signed-off-by: Saeed Mahameed --- drivers/net/etherne

Re: [bpf-next,v2 0/6] Introduce a BPF helper to generate SYN cookies

2019-07-29 Thread Petar Penkov
On Mon, Jul 29, 2019 at 1:48 PM Alexei Starovoitov wrote: > > On Mon, Jul 29, 2019 at 09:59:12AM -0700, Petar Penkov wrote: > > From: Petar Penkov > > > > This patch series introduces a BPF helper function that allows generating > > SYN > > cookies from BPF. Currently, this helper is enabled at

Re: [RFC PATCH 1/2] gianfar: convert to phylink

2019-07-29 Thread Vladimir Oltean
Hi Arseny, Nice project! On Wed, 24 Jul 2019 at 03:38, Arseny Solokha wrote: > > Convert gianfar to use the phylink API for better SFP modules support. > > The driver still uses phylib for serdes configuration over the TBI > interface, as there seems to be no functionally equivalent API present

[PATCH v2 net-next 1/1] tc-testing: Clarify the use of tdc's -d option

2019-07-29 Thread Lucas Bates
The -d command line argument to tdc requires the name of a physical device on the system where the tests will be run. If -d has not been used, tdc will skip tests that require a physical device. This patch is intended to better document what the -d option does and how it is used. Signed-off-by: L

Re: [PATCH bpf-next 00/10] CO-RE offset relocations

2019-07-29 Thread Andrii Nakryiko
On Mon, Jul 29, 2019 at 1:37 PM Song Liu wrote: > > On Mon, Jul 29, 2019 at 1:20 PM Song Liu wrote: > > > > On Wed, Jul 24, 2019 at 1:34 PM Andrii Nakryiko wrote: > > > > > > This patch set implements central part of CO-RE (Compile Once - Run > > > Everywhere, see [0] and [1] for slides and vide

[PATCH net] selftests/tls: fix TLS tests with CONFIG_TLS=n

2019-07-29 Thread Jakub Kicinski
Build bot reports some recent TLS tests are failing with CONFIG_TLS=n. Correct the expected return code and skip TLS installation if not supported. Tested with CONFIG_TLS=n and CONFIG_TLS=m. Reported-by: kernel test robot Fixes: cf32526c8842 ("selftests/tls: add a test for ULP but no keys") Fixe

Re: [PATCH net] net: ipv6: Fix a bug in ndisc_send_ns when netdev only has a global address

2019-07-29 Thread David Ahern
On 7/29/19 3:17 PM, David Miller wrote: > David, can you take a quick look at this? will do. I'll get back to you by tomorrow.

Re: [PATCH 1/3 net-next] linux: Add skb_frag_t page_offset accessors

2019-07-29 Thread Jakub Kicinski
On Mon, 29 Jul 2019 14:53:45 -0700, Jonathan Lemon wrote: > On 29 Jul 2019, at 14:25, Jakub Kicinski wrote: > > > On Mon, 29 Jul 2019 14:22:11 -0700, Jakub Kicinski wrote: > I realize you're following the existing code, but should we perhaps > use > the latest kdoc syntax? '()' af

Re: [PATCH net-next 00/16] bnxt_en: Add TPA (GRO_HW and LRO) on 57500 chips.

2019-07-29 Thread Michael Chan
On Mon, Jul 29, 2019 at 2:24 PM David Miller wrote: > > From: Michael Chan > Date: Mon, 29 Jul 2019 06:10:17 -0400 > > > This patchset adds TPA v2 support on the 57500 chips. TPA v2 is > > different from the legacy TPA scheme on older chips and requires major > > refactoring and restructuring of

Re: [PATCH 1/3 net-next] linux: Add skb_frag_t page_offset accessors

2019-07-29 Thread Jonathan Lemon
On 29 Jul 2019, at 14:25, Jakub Kicinski wrote: > On Mon, 29 Jul 2019 14:22:11 -0700, Jakub Kicinski wrote: I realize you're following the existing code, but should we perhaps use the latest kdoc syntax? '()' after function name, and args should have '@' prefix, '%' would be

[PATCH bpf-next 2/2] selftests/bpf: extend sockopt_sk selftest with TCP_CONGESTION use case

2019-07-29 Thread Stanislav Fomichev
Ignore SOL_TCP:TCP_CONGESTION in getsockopt and always override SOL_TCP:TCP_CONGESTION with "cubic" in setsockopt hook. Call setsockopt(SOL_TCP, TCP_CONGESTION) with short optval ("nv") to make sure BPF program has enough buffer space to replace it with "cubic". Signed-off-by: Stanislav Fomichev

[PATCH bpf-next 0/2] bpf: allocate extra memory for setsockopt hook buffer

2019-07-29 Thread Stanislav Fomichev
Current setsockopt hook is limited to the size of the buffer that user had supplied. Since we always allocate memory and copy the value into kernel space, allocate just a little bit more in case BPF program needs to override input data with a larger value. The canonical example is TCP_CONGESTION s

[PATCH bpf-next 1/2] bpf: always allocate at least 16 bytes for setsockopt hook

2019-07-29 Thread Stanislav Fomichev
Since we always allocate memory, allocate just a little bit more for the BPF program in case it need to override user input with bigger value. The canonical example is TCP_CONGESTION where input string might be too small to override (nv -> bbr or cubic). 16 bytes are chosen to match the size of TC

[net-next:master 57/59] drivers/net/phy/mdio-cavium.h:111:36: error: implicit declaration of function 'writeq'; did you mean 'writel'?

2019-07-29 Thread kbuild test robot
tree: https://kernel.googlesource.com/pub/scm/linux/kernel/git/davem/net-next.git master head: 1cb9dfca39eb406960f8f84864ddd6ba329ec321 commit: 171a9bae68c72f2d1260c3825203760856e6793b [57/59] staging/octeon: Allow test build on !MIPS config: c6x-allyesconfig (attached as .config) compiler:

Re: [PATCH 1/3 net-next] linux: Add skb_frag_t page_offset accessors

2019-07-29 Thread Jonathan Lemon
On 29 Jul 2019, at 14:22, Jakub Kicinski wrote: On Mon, 29 Jul 2019 14:02:21 -0700, Jonathan Lemon wrote: On 29 Jul 2019, at 13:50, Jakub Kicinski wrote: On Mon, 29 Jul 2019 10:19:39 -0700, Jonathan Lemon wrote: Add skb_frag_off(), skb_frag_off_add(), skb_frag_off_set(), and skb_frag_off_s

[net-next:master 57/59] drivers/staging/octeon/octeon-stubs.h:1205:9: warning: cast to pointer from integer of different size

2019-07-29 Thread kbuild test robot
tree: https://kernel.googlesource.com/pub/scm/linux/kernel/git/davem/net-next.git master head: 1cb9dfca39eb406960f8f84864ddd6ba329ec321 commit: 171a9bae68c72f2d1260c3825203760856e6793b [57/59] staging/octeon: Allow test build on !MIPS config: sh-allmodconfig (attached as .config) compiler: s

[PATCH bpf-next] tools: bpftool: add support for reporting the effective cgroup progs

2019-07-29 Thread Jakub Kicinski
Takshak said in the original submission: With different bpf attach_flags available to attach bpf programs specially with BPF_F_ALLOW_OVERRIDE and BPF_F_ALLOW_MULTI, the list of effective bpf-programs available to any sub-cgroups really needs to be available for easy debugging. Using BPF_F_QUERY_E

Re: [PATCH net] net/mlx5e: Fix unnecessary flow_block_cb_is_busy call

2019-07-29 Thread Saeed Mahameed
On Sat, 2019-07-27 at 22:59 +0800, we...@ucloud.cn wrote: > From: wenxu > > When call flow_block_cb_is_busy. The indr_priv is guaranteed to > NULL ptr. So there is no need to call flow_bock_cb_is_busy. > > Fixes: 0d4fd02e7199 ("net: flow_offload: add flow_block_cb_is_busy() > and use it") > Sign

Re: [PATCH 1/3 net-next] linux: Add skb_frag_t page_offset accessors

2019-07-29 Thread Jakub Kicinski
On Mon, 29 Jul 2019 14:22:11 -0700, Jakub Kicinski wrote: > > > I realize you're following the existing code, but should we perhaps > > > use > > > the latest kdoc syntax? '()' after function name, and args should have > > > '@' prefix, '%' would be for constants. > > > > That would be a task

Re: [PATCH 1/3 net-next] linux: Add skb_frag_t page_offset accessors

2019-07-29 Thread David Miller
From: Jakub Kicinski Date: Mon, 29 Jul 2019 14:22:11 -0700 > There is no need to ponder the connotations of verbs. Please just > look at other function names in skbuff.h, especially those which > copy fields :) > > static inline void skb_copy_hash(struct sk_buff *to, const struct sk_buff > *f

Re: [PATCH net-next 00/16] bnxt_en: Add TPA (GRO_HW and LRO) on 57500 chips.

2019-07-29 Thread David Miller
From: Michael Chan Date: Mon, 29 Jul 2019 06:10:17 -0400 > This patchset adds TPA v2 support on the 57500 chips. TPA v2 is > different from the legacy TPA scheme on older chips and requires major > refactoring and restructuring of the existing TPA logic. The main > difference is that the new TP

Re: [PATCH 1/3 net-next] linux: Add skb_frag_t page_offset accessors

2019-07-29 Thread Jakub Kicinski
On Mon, 29 Jul 2019 14:02:21 -0700, Jonathan Lemon wrote: > On 29 Jul 2019, at 13:50, Jakub Kicinski wrote: > > On Mon, 29 Jul 2019 10:19:39 -0700, Jonathan Lemon wrote: > >> Add skb_frag_off(), skb_frag_off_add(), skb_frag_off_set(), > >> and skb_frag_off_set_from() accessors for page_offset. >

Re: [PATCH bpf-next 10/10] selftests/bpf: add CO-RE relocs ints tests

2019-07-29 Thread Song Liu
On Wed, Jul 24, 2019 at 1:34 PM Andrii Nakryiko wrote: > > Add various tests validating handling compatible/incompatible integer > types. > > Signed-off-by: Andrii Nakryiko Acked-by: Song Liu

Re: [PATCH net] net: ipv6: Fix a bug in ndisc_send_ns when netdev only has a global address

2019-07-29 Thread David Miller
From: Su Yanjun Date: Mon, 29 Jul 2019 10:49:51 +0800 > When we send mpls packets and the interface only has a > manual global ipv6 address, then the two hosts cant communicate. > I find that in ndisc_send_ns it only tries to get a ll address. > In my case, the executive path is as below. > ip6_o

Re: ip route JSON format is unparseable for "unreachable" routes

2019-07-29 Thread David Ahern
On 7/28/19 5:09 AM, Michael Ziegler wrote: > Hi, > > I created a couple "unreachable" routes on one of my systems, like such: > >> ip route add unreachable 10.0.0.0/8 metric 255 >> ip route add unreachable 192.168.0.0/16 metric 255 > > Unfortunately this results in unparseable JSON output fr

Re: [PATCH bpf-next 09/10] selftest/bpf: add CO-RE relocs ptr-as-array tests

2019-07-29 Thread Song Liu
On Wed, Jul 24, 2019 at 12:31 PM Andrii Nakryiko wrote: > > Add test validating correct relocation handling for cases where pointer > to something is used as an array. E.g.: > > int *ptr = ...; > int x = ptr[42]; > > Signed-off-by: Andrii Nakryiko Acked-by: Song Liu

[PATCH mlx5-next 05/11] net/mlx5: E-Switch, Verify support QoS element type

2019-07-29 Thread Saeed Mahameed
From: Eli Cohen Check if firmware supports the requested element type before attempting to create the element type. In addition, explicitly specify the request element type and tsar type. Signed-off-by: Eli Cohen Reviewed-by: Paul Blakey Signed-off-by: Saeed Mahameed --- .../net/ethernet/mel

[PATCH mlx5-next 06/11] net/mlx5: E-switch, Combine metadata enable/disable functionality

2019-07-29 Thread Saeed Mahameed
From: Parav Pandit Except bit toggling code, rest of the code is same to enable/disable metadata passing functionality. Hence, combine them to single function and control using enable flag. Also instead of checking metadata supported at multiple places, fold into the helper function. Signed-off

[PATCH mlx5-next 07/11] net/mlx5: E-switch, Initialize TSAR Qos hardware block before its user vports

2019-07-29 Thread Saeed Mahameed
From: Parav Pandit First enable TSAR Qos hardware block in device before enabling its user vports. This refactor is needed so that vports can be enabled before their representor netdevice can be created. While at it, esw_create_tsar() returns error code which was used only to print error. Howev

[PATCH mlx5-next 09/11] net/mlx5: E-Switch, remove redundant error handling

2019-07-29 Thread Saeed Mahameed
We don't need to handle error flow of esw_create_legacy_table() in the same branch, it is already being handled directly after the if statement, for both legacy and switchdev modes in one place. Signed-off-by: Saeed Mahameed Reviewed-by: Roi Dayan --- drivers/net/ethernet/mellanox/mlx5/core/esw

[PATCH mlx5-next 11/11] net/mlx5: E-switch, Tide up eswitch config sequence

2019-07-29 Thread Saeed Mahameed
From: Parav Pandit Currently for PF and ECPF vports, representors are created before their eswitch hardware ports are initialized in below flow. mlx5_eswitch_enable() esw_offloads_init() esw_offloads_load_all_reps() [..] esw_enable_vport() However for VFs, vports are initialized before cr

[PATCH mlx5-next 10/11] net/mlx5: E-Switch, Remove redundant mc_promisc NULL check

2019-07-29 Thread Saeed Mahameed
From: Parav Pandit mc_promisc pointer points to an instance of struct esw_mc_addr allocated as part of the esw structure. Hence it cannot be NULL. Removed such redundant check and assign where it is actually used. While at it, add comment around legacy mode fields and move mc_promisc close to ot

[PATCH mlx5-next 08/11] net/mlx5: E-switch, Introduce helper function to enable/disable vports

2019-07-29 Thread Saeed Mahameed
From: Parav Pandit vports needs to be enabled in switchdev and legacy mode. In switchdev mode, vports should be enabled after initializing the FDB tables and before creating their represntors so that representor works on an initialized vport object. Prepare a helper function which can be called

[PATCH mlx5-next 04/11] net/mlx5: Make load_one() and unload_one() symmetric

2019-07-29 Thread Saeed Mahameed
From: Parav Pandit Currently mlx5_load_one() perform device registration using mlx5_register_device(). But mlx5_unload_one() doesn't unregister. Make them symmetric by doing device unregistration in mlx5_unload_one(). Signed-off-by: Parav Pandit Signed-off-by: Saeed Mahameed --- drivers/net/

[PATCH mlx5-next 02/11] net/mlx5: Add flow counter bulk allocation hardware bits and command

2019-07-29 Thread Saeed Mahameed
From: Gavi Teitz Add a handle to invoke the new FW capability of allocating a bulk of flow counters. Signed-off-by: Gavi Teitz Reviewed-by: Vlad Buslov Signed-off-by: Saeed Mahameed --- .../net/ethernet/mellanox/mlx5/core/fs_cmd.c | 10 - .../net/ethernet/mellanox/mlx5/core/fs_cmd.h

[PATCH mlx5-next 00/11] Mellanox, mlx5-next updates 2019-07-29

2019-07-29 Thread Saeed Mahameed
Hi All, This series include misc updates form mlx5 core driver. 1) Eli improves the handling of the support for QoS element type 2) Gavi refactors and prepares mlx5 flow counters for bluk allocation support 3) Parav, refactors and improves eswitch load/unload flows 4) Saeed, two misc cleanups In

[PATCH mlx5-next 03/11] net/mlx5: Fix offset of tisc bits reserved field

2019-07-29 Thread Saeed Mahameed
First reserved field is off by one instead of reserved_at_1 it should be reserved_at_2, fix that. Fixes: a12ff35e0fb7 ("net/mlx5: Introduce TLS TX offload hardware bits and structures") Signed-off-by: Saeed Mahameed Reviewed-by: Leon Romanovsky --- include/linux/mlx5/mlx5_ifc.h | 2 +- 1 file

[PATCH mlx5-next 01/11] net/mlx5: Refactor and optimize flow counter bulk query

2019-07-29 Thread Saeed Mahameed
From: Gavi Teitz Towards introducing the ability to allocate bulks of flow counters, refactor the flow counter bulk query process, removing functions and structs whose names indicated being used for flow counter bulk allocation FW commands, despite them actually only being used to support bulk qu

Re: [PATCH bpf-next 08/10] selftests/bpf: add CO-RE relocs modifiers/typedef tests

2019-07-29 Thread Song Liu
On Wed, Jul 24, 2019 at 12:30 PM Andrii Nakryiko wrote: > > Add tests validating correct handling of various combinations of > typedefs and const/volatile/restrict modifiers. > > Signed-off-by: Andrii Nakryiko Acked-by: Song Liu

Re: [PATCH bpf-next 07/10] selftests/bpf: add CO-RE relocs enum/ptr/func_proto tests

2019-07-29 Thread Song Liu
On Wed, Jul 24, 2019 at 12:31 PM Andrii Nakryiko wrote: > > Test CO-RE relocation handling of ints, enums, pointers, func protos, etc. > > Signed-off-by: Andrii Nakryiko Acked-by: Song Liu

Re: [PATCH bpf-next 05/10] selftests/bpf: add CO-RE relocs nesting tests

2019-07-29 Thread Song Liu
On Wed, Jul 24, 2019 at 1:33 PM Andrii Nakryiko wrote: > > Add a bunch of test validating correct handling of nested > structs/unions. > > Signed-off-by: Andrii Nakryiko Acked-by: Song Liu

Re: [PATCH 1/3 net-next] linux: Add skb_frag_t page_offset accessors

2019-07-29 Thread Jonathan Lemon
On 29 Jul 2019, at 13:50, Jakub Kicinski wrote: On Mon, 29 Jul 2019 10:19:39 -0700, Jonathan Lemon wrote: Add skb_frag_off(), skb_frag_off_add(), skb_frag_off_set(), and skb_frag_off_set_from() accessors for page_offset. Signed-off-by: Jonathan Lemon --- include/linux/skbuff.h | 61 +

Re: ip route JSON format is unparseable for "unreachable" routes

2019-07-29 Thread David Ahern
On 7/28/19 5:09 AM, Michael Ziegler wrote: > Hi, > > I created a couple "unreachable" routes on one of my systems, like such: > >> ip route add unreachable 10.0.0.0/8 metric 255 >> ip route add unreachable 192.168.0.0/16 metric 255 > > Unfortunately this results in unparseable JSON output fr

Re: [PATCH bpf-next v5 0/6] xdp: Add devmap_hash map type

2019-07-29 Thread Alexei Starovoitov
On Fri, Jul 26, 2019 at 7:26 PM Alexei Starovoitov wrote: > > On Fri, Jul 26, 2019 at 9:06 AM Toke Høiland-Jørgensen > wrote: > > > > This series adds a new map type, devmap_hash, that works like the existing > > devmap type, but using a hash-based indexing scheme. This is useful for the > > us

Re: [PATCH net v2] mlxsw: spectrum_ptp: Increase parsing depth when PTP is enabled

2019-07-29 Thread David Miller
From: Petr Machata Date: Mon, 29 Jul 2019 18:26:14 + > Spectrum systems have a configurable limit on how far into the packet they > parse. By default, the limit is 96 bytes. > > An IPv6 PTP packet is layered as Ethernet/IPv6/UDP (14+40+8 bytes), and > sequence ID of a PTP event is only avail

Re: [PATCH net] net/mlx5e: Fix unnecessary flow_block_cb_is_busy call

2019-07-29 Thread David Miller
From: Saeed Mahameed Date: Mon, 29 Jul 2019 18:25:26 + > Dave let me know if you want me to take it to my branch. Please do, thanks Saeed.

Re: [PATCH 1/3 net-next] linux: Add skb_frag_t page_offset accessors

2019-07-29 Thread Jakub Kicinski
On Mon, 29 Jul 2019 10:19:39 -0700, Jonathan Lemon wrote: > Add skb_frag_off(), skb_frag_off_add(), skb_frag_off_set(), > and skb_frag_off_set_from() accessors for page_offset. > > Signed-off-by: Jonathan Lemon > --- > include/linux/skbuff.h | 61 ++ > 1 f

Re: [bpf-next,v2 0/6] Introduce a BPF helper to generate SYN cookies

2019-07-29 Thread Alexei Starovoitov
On Mon, Jul 29, 2019 at 09:59:12AM -0700, Petar Penkov wrote: > From: Petar Penkov > > This patch series introduces a BPF helper function that allows generating SYN > cookies from BPF. Currently, this helper is enabled at both the TC hook and > the > XDP hook. > > The first two patches in the s

[PATCH net-next] can: fix ioctl function removal

2019-07-29 Thread Oliver Hartkopp
Commit 60649d4e0af ("can: remove obsolete empty ioctl() handler") replaced the almost empty can_ioctl() function with sock_no_ioctl() which always returns -EOPNOTSUPP. Even though we don't have any ioctl() functions on socket/network layer we need to return -ENOIOCTLCMD to be able to forward ioctl

Re: [PATCH bpf-next 04/10] selftests/bpf: add CO-RE relocs struct flavors tests

2019-07-29 Thread Song Liu
On Wed, Jul 24, 2019 at 1:34 PM Andrii Nakryiko wrote: > > Add tests verifying that BPF program can use various struct/union > "flavors" to extract data from the same target struct/union. > > Signed-off-by: Andrii Nakryiko Acked-by: Song Liu

Re: [PATCH bpf-next 00/10] CO-RE offset relocations

2019-07-29 Thread Song Liu
On Mon, Jul 29, 2019 at 1:20 PM Song Liu wrote: > > On Wed, Jul 24, 2019 at 1:34 PM Andrii Nakryiko wrote: > > > > This patch set implements central part of CO-RE (Compile Once - Run > > Everywhere, see [0] and [1] for slides and video): relocating field offsets. > > Most of the details are writt

Re: [PATCH bpf-next 03/10] selftests/bpf: add CO-RE relocs testing setup

2019-07-29 Thread Song Liu
On Wed, Jul 24, 2019 at 1:34 PM Andrii Nakryiko wrote: > > Add CO-RE relocation test runner. Add one simple test validating that > libbpf's logic for searching for kernel image and loading BTF out of it > works. > > Signed-off-by: Andrii Nakryiko Acked-by: Song Liu

Re: [patch iproute2 1/2] devlink: introduce cmdline option to switch to a different namespace

2019-07-29 Thread David Ahern
On 7/27/19 4:21 AM, Jiri Pirko wrote: >>> diff --git a/devlink/devlink.c b/devlink/devlink.c >>> index d8197ea3a478..9242cc05ad0c 100644 >>> --- a/devlink/devlink.c >>> +++ b/devlink/devlink.c >>> @@ -32,6 +32,7 @@ >>> #include "mnlg.h" >>> #include "json_writer.h" >>> #include "utils.h" >>> +#i

Re: [PATCH bpf-next 00/10] CO-RE offset relocations

2019-07-29 Thread Song Liu
On Wed, Jul 24, 2019 at 1:34 PM Andrii Nakryiko wrote: > > This patch set implements central part of CO-RE (Compile Once - Run > Everywhere, see [0] and [1] for slides and video): relocating field offsets. > Most of the details are written down as comments to corresponding parts of the > code. > >

Re: [patch iproute2 1/2] devlink: introduce cmdline option to switch to a different namespace

2019-07-29 Thread David Ahern
subject line should have iproute2-next

Re: [patch net-next 0/3] net: devlink: Finish network namespace support

2019-07-29 Thread David Ahern
On 7/27/19 3:44 AM, Jiri Pirko wrote: > From: Jiri Pirko > > Devlink from the beginning counts with network namespaces, but the > instances has been fixed to init_net. The first patch allows user > to move existing devlink instances into namespaces: > so you intend for an asic, for example, to

Re: [PATCH bpf-next 01/10] libbpf: add .BTF.ext offset relocation section loading

2019-07-29 Thread Song Liu
> On Jul 26, 2019, at 10:11 PM, Andrii Nakryiko > wrote: > > On Wed, Jul 24, 2019 at 10:20 PM Song Liu wrote: >> >> >> >>> On Jul 24, 2019, at 5:37 PM, Andrii Nakryiko >>> wrote: >>> >>> On Wed, Jul 24, 2019 at 5:00 PM Song Liu wrote: > On Jul 24, 2019, at 12:27

Re: [PATCH bpf-next 02/10] libbpf: implement BPF CO-RE offset relocation algorithm

2019-07-29 Thread Song Liu
> On Jul 24, 2019, at 12:27 PM, Andrii Nakryiko wrote: > > This patch implements the core logic for BPF CO-RE offsets relocations. > All the details are described in code comments. > > Signed-off-by: Andrii Nakryiko > --- > tools/lib/bpf/libbpf.c | 866 +++

Re: [PATCH net v2] mlxsw: spectrum_ptp: Increase parsing depth when PTP is enabled

2019-07-29 Thread Ido Schimmel
On Mon, Jul 29, 2019 at 06:26:14PM +, Petr Machata wrote: > Spectrum systems have a configurable limit on how far into the packet they > parse. By default, the limit is 96 bytes. > > An IPv6 PTP packet is layered as Ethernet/IPv6/UDP (14+40+8 bytes), and > sequence ID of a PTP event is only av

Re: [patch net-next 3/3] netdevsim: create devlink and netdev instances in namespace

2019-07-29 Thread Jakub Kicinski
On Sat, 27 Jul 2019 11:44:59 +0200, Jiri Pirko wrote: > From: Jiri Pirko > > When user does create new netdevsim instance using sysfs bus file, > create the devlink instance and related netdev instance in the namespace > of the caller. > > Signed-off-by: Jiri Pirko > diff --git a/drivers/net/n

Re: [PATCH] tcp: add new tcp_mtu_probe_floor sysctl

2019-07-29 Thread Josh Hunt
On 7/29/19 6:12 AM, Neal Cardwell wrote: On Sun, Jul 28, 2019 at 5:14 PM Josh Hunt wrote: On 7/28/19 6:54 AM, Eric Dumazet wrote: On Sun, Jul 28, 2019 at 1:21 AM Josh Hunt wrote: On 7/27/19 12:05 AM, Eric Dumazet wrote: On Sat, Jul 27, 2019 at 4:23 AM Josh Hunt wrote: The current imple

[PATCH net v2] mlxsw: spectrum_ptp: Increase parsing depth when PTP is enabled

2019-07-29 Thread Petr Machata
Spectrum systems have a configurable limit on how far into the packet they parse. By default, the limit is 96 bytes. An IPv6 PTP packet is layered as Ethernet/IPv6/UDP (14+40+8 bytes), and sequence ID of a PTP event is only available 32 bytes into payload, for a total of 94 bytes. When an addition

Re: [PATCH net] net/mlx5e: Fix unnecessary flow_block_cb_is_busy call

2019-07-29 Thread Saeed Mahameed
On Sat, 2019-07-27 at 22:59 +0800, we...@ucloud.cn wrote: > From: wenxu > > When call flow_block_cb_is_busy. The indr_priv is guaranteed to > NULL ptr. So there is no need to call flow_bock_cb_is_busy. > > Fixes: 0d4fd02e7199 ("net: flow_offload: add flow_block_cb_is_busy() > and use it") > Sign

Re: [PATCH net] mlxsw: spectrum_ptp: Increase parsing depth when PTP is enabled

2019-07-29 Thread Petr Machata
David Miller writes: > From: Ido Schimmel > Date: Sat, 27 Jul 2019 20:35:32 +0300 > >> @@ -979,19 +979,36 @@ static int mlxsw_sp1_ptp_mtpppc_update(struct >> mlxsw_sp_port *mlxsw_sp_port, >> { >> struct mlxsw_sp *mlxsw_sp = mlxsw_sp_port->mlxsw_sp; >> struct mlxsw_sp_port *tmp; >>

Re: [patch net] net: fix ifindex collision during namespace removal

2019-07-29 Thread David Miller
From: Jiri Pirko Date: Sun, 28 Jul 2019 14:56:36 +0200 > From: Jiri Pirko > > Commit aca51397d014 ("netns: Fix arbitrary net_device-s corruptions > on net_ns stop.") introduced a possibility to hit a BUG in case device > is returning back to init_net and two following conditions are met: > 1) d

Re: tcan4x5x on a Raspberry Pi

2019-07-29 Thread Dan Murphy
Konstantin On 7/29/19 6:19 AM, FIXED-TERM Buecheler Konstantin (ETAS-SEC/ECT-Mu) wrote: Hi all, I am currently working on a project where I am trying to use the tcan4550 chip with a Raspberry PI 3B. I am struggling to create a working device tree overlay file for the Raspberry Pi. Has anyone

Re: [PATCH net-next] r8169: make use of xmit_more

2019-07-29 Thread David Miller
From: Heiner Kallweit Date: Sun, 28 Jul 2019 11:25:19 +0200 > There was a previous attempt to use xmit_more, but the change had to be > reverted because under load sometimes a transmit timeout occurred [0]. > Maybe this was caused by a missing memory barrier, the new attempt > keeps the memory ba

Re: [PATCH net-next v3 2/2] qed: Add driver API for flashing the config attributes.

2019-07-29 Thread David Miller
From: Sudarsana Reddy Kalluru Date: Sat, 27 Jul 2019 18:55:49 -0700 > @@ -2268,6 +2330,9 @@ static int qed_nvm_flash(struct qed_dev *cdev, const > char *name) > rc = qed_nvm_flash_image_access(cdev, &data, > &check_resp)

Re: [PATCH net] net/mlx5e: Fix unnecessary flow_block_cb_is_busy call

2019-07-29 Thread David Miller
From: we...@ucloud.cn Date: Sat, 27 Jul 2019 22:59:55 +0800 > From: wenxu > > When call flow_block_cb_is_busy. The indr_priv is guaranteed to > NULL ptr. So there is no need to call flow_bock_cb_is_busy. > > Fixes: 0d4fd02e7199 ("net: flow_offload: add flow_block_cb_is_busy() and use > it") >

Re: [PATCH net] mlxsw: spectrum_ptp: Increase parsing depth when PTP is enabled

2019-07-29 Thread David Miller
From: Ido Schimmel Date: Sat, 27 Jul 2019 20:35:32 +0300 > @@ -979,19 +979,36 @@ static int mlxsw_sp1_ptp_mtpppc_update(struct > mlxsw_sp_port *mlxsw_sp_port, > { > struct mlxsw_sp *mlxsw_sp = mlxsw_sp_port->mlxsw_sp; > struct mlxsw_sp_port *tmp; > + u16 orig_ing_types = 0; > +

[PATCH V4 0/3] net: dsa: ksz: Add Microchip KSZ87xx support

2019-07-29 Thread Marek Vasut
This series adds support for Microchip KSZ87xx switches, which are slightly simpler compared to KSZ9xxx . Signed-off-by: Marek Vasut Cc: Andrew Lunn Cc: David S. Miller Cc: Florian Fainelli Cc: Tristram Ha Cc: Vivien Didelot Cc: Woojung Huh Marek Vasut (1): dt-bindings: net: dsa: ksz: do

[PATCH V4 3/3] net: dsa: ksz: Add Microchip KSZ8795 DSA driver

2019-07-29 Thread Marek Vasut
From: Tristram Ha Add Microchip KSZ8795 DSA driver. Signed-off-by: Tristram Ha Signed-off-by: Marek Vasut Cc: Andrew Lunn Cc: David S. Miller Cc: Florian Fainelli Cc: Tristram Ha Cc: Vivien Didelot Cc: Woojung Huh --- V2: - Use reverse xmas tree for variable declaration - Use BIT() m

  1   2   >