Re: [PATCH net] tcp: be more careful in tcp_fragment()

2019-07-21 Thread David Miller
From: Eric Dumazet Date: Fri, 19 Jul 2019 11:52:33 -0700 > Some applications set tiny SO_SNDBUF values and expect > TCP to just work. Recent patches to address CVE-2019-11478 > broke them in case of losses, since retransmits might > be prevented. > > We should allow these flows to make progress.

Re: [PATCH v2 net-next 03/11] net/ipv4: Plumb support for filtering route dumps

2019-07-21 Thread Hangbin Liu
On Fri, Jul 19, 2019 at 10:55:49AM -0600, David Ahern wrote: > Hi: > > On 7/18/19 10:17 PM, Hangbin Liu wrote: > > Hi David, > > > > Before commit 18a8021a7be3 ("net/ipv4: Plumb support for filtering route > > dumps"), when we dump a non-exist table, ip cmd exits silently. > > > > # ip -4 route

Re: [PATCH net] be2net: Synchronize be_update_queues with dev_watchdog

2019-07-21 Thread David Miller
From: Benjamin Poirier Date: Thu, 18 Jul 2019 10:42:18 +0900 > As pointed out by Firo Yang, a netdev tx timeout may trigger just before an > ethtool set_channels operation is started. be_tx_timeout(), which dumps > some queue structures, is not written to run concurrently with > be_update_queues(

Re: [PATCH] bnx2x: Prevent load reordering in tx completion processing

2019-07-21 Thread David Miller
From: Brian King Date: Mon, 15 Jul 2019 16:41:50 -0500 > This patch fixes an issue seen on Power systems with bnx2x which results > in the skb is NULL WARN_ON in bnx2x_free_tx_pkt firing due to the skb > pointer getting loaded in bnx2x_free_tx_pkt prior to the hw_cons > load in bnx2x_tx_int. Addi

Re: [PATCH net] net: phy: sfp: hwmon: Fix scaling of RX power

2019-07-21 Thread David Miller
From: Andrew Lunn Date: Sun, 21 Jul 2019 18:50:08 +0200 > The RX power read from the SFP uses units of 0.1uW. This must be > scaled to units of uW for HWMON. This requires a divide by 10, not the > current 100. > > With this change in place, sensors(1) and ethtool -m agree: > > sff2-isa- >

Re: [PATCH net-next] net: sched: verify that q!=NULL before setting q->flags

2019-07-21 Thread David Miller
From: Vlad Buslov Date: Sun, 21 Jul 2019 17:44:12 +0300 > In function int tc_new_tfilter() q pointer can be NULL when adding filter > on a shared block. With recent change that resets TCQ_F_CAN_BYPASS after > filter creation, following NULL pointer dereference happens in case parent > block is sh

Re: [PATCHv2 0/2] forcedeth: recv cache to make NIC work steadily

2019-07-21 Thread David Miller
I made it abundantly clear that I am completely not supportive of changes like this. If anything, we need to improve the behavior of the core kernel allocators, and the mid-level networking interfaces which use them, to fix problems like this. It is absolutely not sustainable to have every driv

Re: [PATCH net] kbuild: add net/netfilter/nf_tables_offload.h to header-test blacklist.

2019-07-21 Thread David Miller
From: Jeremy Sowden Date: Sun, 21 Jul 2019 12:31:05 +0100 > net/netfilter/nf_tables_offload.h includes net/netfilter/nf_tables.h > which is itself on the blacklist. > > Reported-by: Jakub Kicinski > Signed-off-by: Jeremy Sowden Applied.

Re: [PATCH net] kbuild: add net/netfilter/nf_tables_offload.h to header-test blacklist.

2019-07-21 Thread Pablo Neira Ayuso
On Sun, Jul 21, 2019 at 12:31:05PM +0100, Jeremy Sowden wrote: > net/netfilter/nf_tables_offload.h includes net/netfilter/nf_tables.h > which is itself on the blacklist. > > Reported-by: Jakub Kicinski > Signed-off-by: Jeremy Sowden Acked-by: Pablo Neira Ayuso Thanks, I think it would be good

[PATCH net] net: phy: sfp: hwmon: Fix scaling of RX power

2019-07-21 Thread Andrew Lunn
The RX power read from the SFP uses units of 0.1uW. This must be scaled to units of uW for HWMON. This requires a divide by 10, not the current 100. With this change in place, sensors(1) and ethtool -m agree: sff2-isa- Adapter: ISA adapter in0: +3.23 V temp1:+33.1 C power1:

Re: [PATCH net-next] net: sched: verify that q!=NULL before setting q->flags

2019-07-21 Thread Jiri Pirko
Sun, Jul 21, 2019 at 04:44:12PM CEST, vla...@mellanox.com wrote: >In function int tc_new_tfilter() q pointer can be NULL when adding filter >on a shared block. With recent change that resets TCQ_F_CAN_BYPASS after >filter creation, following NULL pointer dereference happens in case parent >block is

Re: [PATCH net-next 00/12] mlx5 TLS TX HW offload support

2019-07-21 Thread Tariq Toukan
On 7/18/2019 10:09 PM, David Miller wrote: > From: Jakub Kicinski > Date: Thu, 18 Jul 2019 10:08:47 -0700 > >> Yes, certainly. It's documentation and renaming a stat before it makes >> it into an official release. > > Agreed. > Ack. I'll prepare and send this week. Tariq

Re: [PATCHv2 0/2] forcedeth: recv cache to make NIC work steadily

2019-07-21 Thread Andrew Lunn
On Sun, Jul 21, 2019 at 08:53:51AM -0400, Zhu Yanjun wrote: > These patches are to this scenario: > > " > When the host run for long time, there are a lot of memory fragments in > the hosts. And it is possible that kernel will compact memory fragments. > But normally it is difficult for NIC driver

Re: [PATCHv2 2/2] forcedeth: disable recv cache by default

2019-07-21 Thread Andrew Lunn
On Sun, Jul 21, 2019 at 08:53:53AM -0400, Zhu Yanjun wrote: > The recv cache is to allocate 125MiB memory to reserve for NIC. > In the past time, this recv cache works very well. When the memory > is not enough, this recv cache reserves memory for NIC. > And the communications through this NIC is n

[PATCH net-next] net: sched: verify that q!=NULL before setting q->flags

2019-07-21 Thread Vlad Buslov
In function int tc_new_tfilter() q pointer can be NULL when adding filter on a shared block. With recent change that resets TCQ_F_CAN_BYPASS after filter creation, following NULL pointer dereference happens in case parent block is shared: [ 212.925060] BUG: kernel NULL pointer dereference, addres

Re: [PATCH net v3] net: neigh: fix multiple neigh timer scheduling

2019-07-21 Thread Julian Anastasov
Hello, On Sun, 14 Jul 2019, Lorenzo Bianconi wrote: > Neigh timer can be scheduled multiple times from userspace adding If the garbage comes from ndm_state, why we should create a patch that just covers the problem?: State: INCOMPLETE, STALE, FAILED, 0x8400 (0x8425) U

[PATCHv2 1/2] forcedeth: add recv cache to make nic work steadily

2019-07-21 Thread Zhu Yanjun
A recv cache is added. The size of recv cache is 1000Mbit / skb_length. When the system memory is not enough, this recv cache can make nic work steadily. When nic is up, this recv cache and work queue are created. When nic is down, this recv cache will be destroyed and delayed workqueue is canceled

[PATCHv2 2/2] forcedeth: disable recv cache by default

2019-07-21 Thread Zhu Yanjun
The recv cache is to allocate 125MiB memory to reserve for NIC. In the past time, this recv cache works very well. When the memory is not enough, this recv cache reserves memory for NIC. And the communications through this NIC is not affected by the memory shortage. And the performance of NIC is be

[PATCHv2 0/2] forcedeth: recv cache to make NIC work steadily

2019-07-21 Thread Zhu Yanjun
These patches are to this scenario: " When the host run for long time, there are a lot of memory fragments in the hosts. And it is possible that kernel will compact memory fragments. But normally it is difficult for NIC driver to allocate a memory from kernel. From this variable stat_rx_dropped, w

[PATCH net] kbuild: add net/netfilter/nf_tables_offload.h to header-test blacklist.

2019-07-21 Thread Jeremy Sowden
net/netfilter/nf_tables_offload.h includes net/netfilter/nf_tables.h which is itself on the blacklist. Reported-by: Jakub Kicinski Signed-off-by: Jeremy Sowden --- include/Kbuild | 1 + 1 file changed, 1 insertion(+) diff --git a/include/Kbuild b/include/Kbuild index 7e9f1acb9dd5..8de846a83d8f

Re: ENOBUILD in nf_tables

2019-07-21 Thread Jeremy Sowden
On 2019-07-20, at 09:44:43 +0200, Pablo Neira Ayuso wrote: > On Fri, Jul 19, 2019 at 10:07:43AM -0700, Jakub Kicinski wrote: > > I hit the following build breakage on net with the config attached. > > > > GCC 9, doesn't seem like your just-posted series fixes this? > > $ gcc -v > ... > gcc version