From: Pablo Neira Ayuso
Date: Fri, 19 Jul 2019 18:20:12 +0200
> The following patchset contains fixes for the flow_offload infrastructure:
Series applied, please fix the build failure reported by Jakub.
From: Pablo Neira Ayuso
Date: Fri, 19 Jul 2019 18:45:03 +0200
> The following patchset contains Netfilter fixes for net:
...
> You can pull these changes from:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git
Pulled.
On Fri, 19 Jul 2019 13:00:29 +0200, Jiri Pirko wrote:
> diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
> index 1fa30d514e3f..68ad12a7fc4d 100644
> --- a/net/core/rtnetlink.c
> +++ b/net/core/rtnetlink.c
> @@ -1793,6 +1793,8 @@ static const struct nla_policy ifla_policy[IFLA_MAX+1]
> = {
On Fri, 19 Jul 2019 13:00:26 +0200, Jiri Pirko wrote:
> diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
> index 7a2010b16e10..f11a2367037d 100644
> --- a/net/core/rtnetlink.c
> +++ b/net/core/rtnetlink.c
> @@ -980,6 +980,18 @@ static size_t rtnl_xdp_size(void)
> return xdp_size;
> }
On Fri, 19 Jul 2019 13:00:25 +0200, Jiri Pirko wrote:
> +int netdev_name_node_alt_destroy(struct net_device *dev, char *name)
> +{
> + struct netdev_name_node *name_node;
> + struct net *net = dev_net(dev);
> +
> + name_node = netdev_name_node_lookup(net, name);
> + if (!name_node)
On Fri, 19 Jul 2019 14:40:43 -0700
Vedang Patel wrote:
> In iproute2 txtime-assist series, it was pointed out that print_bool()
> should be used to print binary values. This is to make it JSON friendly.
>
> So, make the corresponding changes in ETF.
>
> Fixes: 8ccd49383cdc ("etf: Add skip_sock_
On Fri, Jul 19, 2019 at 1:27 PM Arnaldo Carvalho de Melo
wrote:
>
> Em Fri, Jul 19, 2019 at 01:04:32PM -0700, Andrii Nakryiko escreveu:
> > On Fri, Jul 19, 2019 at 11:34 AM Arnaldo Carvalho de Melo
> > wrote:
> > >
> > > Em Fri, Jul 19, 2019 at 11:26:50AM -0700, Andrii Nakryiko escreveu:
> > > >
In iproute2 txtime-assist series, it was pointed out that print_bool()
should be used to print binary values. This is to make it JSON friendly.
So, make the corresponding changes in ETF.
Fixes: 8ccd49383cdc ("etf: Add skip_sock_check")
Reported-by: Stephen Hemminger
Signed-off-by: Vedang Patel
> On Jul 18, 2019, at 10:12 PM, Stephen Hemminger
> wrote:
>
> On Thu, 18 Jul 2019 12:55:39 -0700
> Vedang Patel wrote:
>
>> -print_string(PRINT_ANY, "deadline_mode", "deadline_mode %s",
>> +print_string(PRINT_ANY, "deadline_mode", "deadline_mode %s ",
>>
Em Fri, Jul 19, 2019 at 01:04:32PM -0700, Andrii Nakryiko escreveu:
> On Fri, Jul 19, 2019 at 11:34 AM Arnaldo Carvalho de Melo
> wrote:
> >
> > Em Fri, Jul 19, 2019 at 11:26:50AM -0700, Andrii Nakryiko escreveu:
> > > On Fri, Jul 19, 2019 at 11:14 AM Arnaldo Carvalho de Melo
> > > wrote:
> > >
On Fri, 19 Jul 2019 21:17:40 +0200
Jiri Pirko wrote:
> Fri, Jul 19, 2019 at 06:29:36PM CEST, step...@networkplumber.org wrote:
> >On Fri, 19 Jul 2019 13:00:24 +0200
> >Jiri Pirko wrote:
> >
> >> From: Jiri Pirko
> >>
> >> Signed-off-by: Jiri Pirko
> >> ---
> >> include/linux/netdevice.h |
On 7/19/19 12:07 PM, Andrew Lunn wrote:
On Fri, Jul 19, 2019 at 11:41:28AM -0700, Shannon Nelson wrote:
On 7/18/19 7:40 PM, Andrew Lunn wrote:
On Thu, Jul 18, 2019 at 05:12:07PM -0700, Shannon Nelson wrote:
On 7/17/19 8:28 PM, Andrew Lunn wrote:
On Fri, Jul 12, 2019 at 10:16:31PM -0700, Shann
On Fri, Jul 19, 2019 at 11:34 AM Arnaldo Carvalho de Melo
wrote:
>
> Em Fri, Jul 19, 2019 at 11:26:50AM -0700, Andrii Nakryiko escreveu:
> > On Fri, Jul 19, 2019 at 11:14 AM Arnaldo Carvalho de Melo
> > wrote:
> > > Em Fri, Jul 19, 2019 at 10:54:44AM -0700, Andrii Nakryiko escreveu:
> > > > Ok,
Quoting René van Dorst :
Quoting Russell King - ARM Linux admin :
On Wed, Jul 17, 2019 at 09:31:11PM +, René van Dorst wrote:
Hi,
I am trying to enable flow control/pause on PHYLINK and fixed-link.
My setup SOC mac (mt7621) <-> RGMII <-> SWITCH mac (mt7530).
It seems that in fixed-link
On 7/19/19 12:46 PM, Andrii Nakryiko wrote:
> If VAR in non-sanitized BTF was size less than 4, converting such VAR
> into an INT with size=4 will cause BTF validation failure due to
> violationg of STRUCT (into which DATASEC was converted) member size.
> Fix by conservatively using size=1.
>
> Si
If VAR in non-sanitized BTF was size less than 4, converting such VAR
into an INT with size=4 will cause BTF validation failure due to
violationg of STRUCT (into which DATASEC was converted) member size.
Fix by conservatively using size=1.
Signed-off-by: Andrii Nakryiko
---
tools/lib/bpf/libbpf.
On 7/19/19 12:32 PM, Andrii Nakryiko wrote:
> In case when BTF loading fails despite sanitization, but BPF object has
> .BTF.ext loaded as well, we free and null obj->btf, but not
> obj->btf_ext. This leads to an attempt to relocate .BTF.ext later on
> during bpf_object__load(), which assumes obj->
In case when BTF loading fails despite sanitization, but BPF object has
.BTF.ext loaded as well, we free and null obj->btf, but not
obj->btf_ext. This leads to an attempt to relocate .BTF.ext later on
during bpf_object__load(), which assumes obj->btf is present. This leads
to SIGSEGV on null pointe
Fri, Jul 19, 2019 at 06:29:36PM CEST, step...@networkplumber.org wrote:
>On Fri, 19 Jul 2019 13:00:24 +0200
>Jiri Pirko wrote:
>
>> From: Jiri Pirko
>>
>> Signed-off-by: Jiri Pirko
>> ---
>> include/linux/netdevice.h | 10 +++-
>> net/core/dev.c| 96 +++-
Fri, Jul 19, 2019 at 06:31:35PM CEST, step...@networkplumber.org wrote:
>On Fri, 19 Jul 2019 13:00:22 +0200
>Jiri Pirko wrote:
>
>> From: Jiri Pirko
>>
>> In the past, there was repeatedly discussed the IFNAMSIZ (16) limit for
>> netdevice name length. Now when we have PF and VF representors
>>
On Fri, Jul 19, 2019 at 11:41:28AM -0700, Shannon Nelson wrote:
> On 7/18/19 7:40 PM, Andrew Lunn wrote:
> >On Thu, Jul 18, 2019 at 05:12:07PM -0700, Shannon Nelson wrote:
> >>On 7/17/19 8:28 PM, Andrew Lunn wrote:
> >>>On Fri, Jul 12, 2019 at 10:16:31PM -0700, Shannon Nelson wrote:
> On 7/8/19
Some applications set tiny SO_SNDBUF values and expect
TCP to just work. Recent patches to address CVE-2019-11478
broke them in case of losses, since retransmits might
be prevented.
We should allow these flows to make progress.
This patch allows the first and last skb in retransmit queue
to be sp
On 7/18/19 7:40 PM, Andrew Lunn wrote:
On Thu, Jul 18, 2019 at 05:12:07PM -0700, Shannon Nelson wrote:
On 7/17/19 8:28 PM, Andrew Lunn wrote:
On Fri, Jul 12, 2019 at 10:16:31PM -0700, Shannon Nelson wrote:
On 7/8/19 7:14 PM, Andrew Lunn wrote:
+static int ionic_set_pauseparam(struct net_devic
Em Fri, Jul 19, 2019 at 11:26:50AM -0700, Andrii Nakryiko escreveu:
> On Fri, Jul 19, 2019 at 11:14 AM Arnaldo Carvalho de Melo
> wrote:
> > Em Fri, Jul 19, 2019 at 10:54:44AM -0700, Andrii Nakryiko escreveu:
> > > Ok, did some more googling. This warning (turned error in your setup)
> > > is emi
Em Fri, Jul 19, 2019 at 09:25:07AM -0700, Y Song escreveu:
> On Fri, Jul 19, 2019 at 7:35 AM Arnaldo Carvalho de Melo
> wrote:
> > Using endian.h and its endianness macros makes this code build in a
> > wider range of compilers, as some don't have those macros
> > (__BYTE_ORDER__, __ORDER_LITTLE_
On Fri, Jul 19, 2019 at 11:14 AM Arnaldo Carvalho de Melo
wrote:
>
> Em Fri, Jul 19, 2019 at 10:54:44AM -0700, Andrii Nakryiko escreveu:
> > On Thu, Jul 18, 2019 at 6:16 PM Arnaldo Carvalho de Melo
> > wrote:
> > >
> > > Em Thu, Jul 18, 2019 at 02:16:29PM -0700, Andrii Nakryiko escreveu:
> > > >
On Fri, 19 Jul 2019 15:12:24 +0200, Ilya Leoshkevich wrote:
> > Am 18.07.2019 um 20:51 schrieb Jakub Kicinski
> > :
> >
> > We should probably make a script with all the ways of calling make
> > should work. Otherwise we can lose track too easily.
>
> Thanks for the script!
>
> I’m trying to
Em Fri, Jul 19, 2019 at 10:54:44AM -0700, Andrii Nakryiko escreveu:
> On Thu, Jul 18, 2019 at 6:16 PM Arnaldo Carvalho de Melo
> wrote:
> >
> > Em Thu, Jul 18, 2019 at 02:16:29PM -0700, Andrii Nakryiko escreveu:
> > > On Thu, Jul 18, 2019 at 12:14 PM Arnaldo Carvalho de Melo
> > > wrote:
> > > >
On Thu, Jul 18, 2019 at 6:16 PM Arnaldo Carvalho de Melo
wrote:
>
> Em Thu, Jul 18, 2019 at 02:16:29PM -0700, Andrii Nakryiko escreveu:
> > On Thu, Jul 18, 2019 at 12:14 PM Arnaldo Carvalho de Melo
> > wrote:
> > >
> > > Em Thu, Jul 18, 2019 at 03:56:19PM -0300, Arnaldo Carvalho de Melo
> > > es
On Wed, 17 Jul 2019 18:15:31 -0700
Ivan Delalande wrote:
> Fixes: fcc16c22 ("provide common json output formatter")
> Signed-off-by: Ivan Delalande
Applied.
On Wed, 17 Jul 2019 17:31:49 +0300
Leon Romanovsky wrote:
> From: Leon Romanovsky
>
> Changelog v0->v1:
> * Fixed typo in manual page (Gal)
> * Rebased on top of d035cc1b "ip tunnel: warn when changing IPv6 tunnel
> without tunnel name"
> * Dropped update header file because it was already
On Fri, 19 Jul 2019 10:29:13 -0700, Jakub Kicinski wrote:
> John says:
>
> Resolve a series of splats discovered by syzbot and an unhash
> TLS issue noted by Eric Dumazet.
Sorry for the delay, this code is quite tricky. According to my testing
TLS SW and HW should now work, I hope I didn't regres
From: John Fastabend
__sock_map_delete() may be called from a tcp event such as unhash or
close from the following trace,
tcp_bpf_close()
tcp_bpf_remove()
sk_psock_unlink()
sock_map_delete_from_link()
__sock_map_delete()
In this case the sock lock is held but this
Test the error codes returned when TCP connection is not
in ESTABLISHED state.
Signed-off-by: Jakub Kicinski
Reviewed-by: Dirk van der Merwe
---
tools/testing/selftests/net/tls.c | 52 +++
1 file changed, 52 insertions(+)
diff --git a/tools/testing/selftests/net/tls
Add a simple test which installs the TLS state for both directions,
sends and receives data on both sockets.
Signed-off-by: Jakub Kicinski
Reviewed-by: Dirk van der Merwe
---
tools/testing/selftests/net/tls.c | 31 +++
1 file changed, 31 insertions(+)
diff --git a/t
Add test for killing the connection via shutdown.
Signed-off-by: Jakub Kicinski
Reviewed-by: Dirk van der Merwe
---
tools/testing/selftests/net/tls.c | 27 +++
1 file changed, 27 insertions(+)
diff --git a/tools/testing/selftests/net/tls.c
b/tools/testing/selftests/net
From: John Fastabend
The tls close() callback currently drops the sock lock, makes a
cancel_delayed_work_sync() call, and then relocks the sock.
By restructuring the code we can avoid droping lock and then
reclaiming it. To simplify this we do the following,
tls_sk_proto_close
set_bit(CLOSING
The deprecated TOE offload doesn't actually do anything in
tls_sk_proto_close() - all TLS code is skipped and context
not freed. Remove the callback to make it easier to refactor
tls_sk_proto_close().
Signed-off-by: Jakub Kicinski
Reviewed-by: Dirk van der Merwe
---
net/tls/tls_main.c | 4
Add test which sends some data with MSG_MORE and then
closes the socket (never calling send without MSG_MORE).
This should make sure we clean up open records correctly.
Signed-off-by: Jakub Kicinski
Reviewed-by: Dirk van der Merwe
---
tools/testing/selftests/net/tls.c | 10 ++
1 file ch
From: John Fastabend
We need to have a synchronize_rcu before free'ing the sockmap because
any outstanding psock references will have a pointer to the map and
when they use this could trigger a use after free.
Fixes: 604326b41a6fb ("bpf, sockmap: convert to generic sk_msg interface")
Signed-off-
John says:
Resolve a series of splats discovered by syzbot and an unhash
TLS issue noted by Eric Dumazet.
The main issues revolved around interaction between TLS and
sockmap tear down. TLS and sockmap could both reset sk->prot
ops creating a condition where a close or unhash op could be
called fo
From: John Fastabend
It is possible (via shutdown()) for TCP socks to go through TCP_CLOSE
state via tcp_disconnect() without actually calling tcp_close which
would then call the tls close callback. Because of this a user could
disconnect a socket then put it in a LISTEN state which would break
o
In tls_set_device_offload_rx() we prepare the software context
for RX fallback and proceed to add the connection to the device.
Unfortunately, software context prep includes arming strparser
so in case of a later error we have to release the socket lock
to call strp_done().
In preparation for not
From: John Fastabend
The tls close() callback currently drops the sock lock to call
strp_done(). Split up the RX cleanup into stopping the strparser
and releasing most resources, syncing strparser and finally
freeing the context.
To avoid the need for a strp_done() call on the cleanup path
of de
From: John Fastabend
Sockmap does not currently support adding sockets after TLS has been
enabled. There never was a real use case for this so it was never
added. But, we lost the test for ULP at some point so add it here
and fail the socket insert if TLS is enabled. Future work could
make sockma
Make sure we test the TLS_BASE/TLS_BASE case both with data
and the tear down/clean up path.
Signed-off-by: Jakub Kicinski
Reviewed-by: Dirk van der Merwe
---
tools/testing/selftests/net/tls.c | 74 +++
1 file changed, 74 insertions(+)
diff --git a/tools/testing/sel
From: John Fastabend
When a map free is called and in parallel a socket is closed we
have two paths that can potentially reset the socket prot ops, the
bpf close() path and the map free path. This creates a problem
with which prot ops should be used from the socket closed side.
If the map_free s
On Fri, Jul 19, 2019 at 7:34 AM Arnaldo Carvalho de Melo
wrote:
>
> From: Arnaldo Carvalho de Melo
>
> As it fails to build in some systems with:
>
> libbpf.c: In function 'perf_buffer__new':
> libbpf.c:4515: error: unknown field 'sample_period' specified in initializer
> libbpf.c:4516: err
> -Original Message-
> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On
> Behalf Of Kevin Laatz
> Sent: Monday, July 15, 2019 8:07 PM
> To: netdev@vger.kernel.org; a...@kernel.org; dan...@iogearbox.net; Topel,
> Bjorn ; Karlsson, Magnus
> ; jakub.kicin...@netronome.com;
> -Original Message-
> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On
> Behalf Of Kevin Laatz
> Sent: Monday, July 15, 2019 8:07 PM
> To: netdev@vger.kernel.org; a...@kernel.org; dan...@iogearbox.net; Topel,
> Bjorn ; Karlsson, Magnus
> ; jakub.kicin...@netronome.com;
> -Original Message-
> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On
> Behalf Of Kevin Laatz
> Sent: Monday, July 15, 2019 8:07 PM
> To: netdev@vger.kernel.org; a...@kernel.org; dan...@iogearbox.net; Topel,
> Bjorn ; Karlsson, Magnus
> ; jakub.kicin...@netronome.com;
> -Original Message-
> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On
> Behalf Of Kevin Laatz
> Sent: Monday, July 15, 2019 8:06 PM
> To: netdev@vger.kernel.org; a...@kernel.org; dan...@iogearbox.net; Topel,
> Bjorn ; Karlsson, Magnus
> ; jakub.kicin...@netronome.com;
> -Original Message-
> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On
> Behalf Of Kevin Laatz
> Sent: Monday, July 15, 2019 8:06 PM
> To: netdev@vger.kernel.org; a...@kernel.org; dan...@iogearbox.net; Topel,
> Bjorn ; Karlsson, Magnus
> ; jakub.kicin...@netronome.com;
Hi Pablo,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[cannot apply to v5.2 next-20190719]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Pablo-Neira
Hi:
On 7/18/19 10:17 PM, Hangbin Liu wrote:
> Hi David,
>
> Before commit 18a8021a7be3 ("net/ipv4: Plumb support for filtering route
> dumps"), when we dump a non-exist table, ip cmd exits silently.
>
> # ip -4 route list table 1
> # echo $?
> 0
>
> After commit 18a8021a7be3 ("net/ipv4: Plumb s
From: Phil Sutter
Trying to create an inet family nat chain would not cause
nft_chain_nat.ko module to auto-load due to missing module alias. Add a
proper one with hard-coded family value 1 for the pseudo-family
NFPROTO_INET.
Fixes: d164385ec572 ("netfilter: nat: add inet family nat support")
Si
If it is a module, request this module. Otherwise, if it is compiled
built-in or not selected, skip this.
Fixes: 0ef1efd1354d ("netfilter: nf_tables: force module load in case
select_ops() returns -EAGAIN")
Signed-off-by: Pablo Neira Ayuso
---
net/netfilter/nft_meta.c | 2 +-
1 file changed, 1
From: Arnd Bergmann
The new nft_meta_bridge code fails to link as built-in when NF_TABLES
is a loadable module.
net/bridge/netfilter/nft_meta_bridge.o: In function `nft_meta_bridge_get_eval':
nft_meta_bridge.c:(.text+0x1e8): undefined reference to `nft_meta_get_eval'
net/bridge/netfilter/nft_met
From: Fernando Fernandez Mancera
14:51:00.024418 IP 192.168.122.1.41462 > netfilter.90: Flags [S], seq
4023580551,
14:51:00.024454 IP netfilter.90 > 192.168.122.1.41462: Flags [S.], seq
727560212, ack 4023580552,
14:51:00.024524 IP 192.168.122.1.41462 > netfilter.90: Flags [.], ack 1,
Note: here
Place NF_CONNTRACK_BRIDGE away from the NF_TABLES_BRIDGE dependency.
Fixes: 3c171f496ef5 ("netfilter: bridge: add connection tracking system")
Signed-off-by: Pablo Neira Ayuso
---
net/bridge/netfilter/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/bridge/netf
From: xiao ruizhu
When conntracks change during a dialog, SDP messages may be sent from
different conntracks to establish expects with identical tuples. In this
case expects conflict may be detected for the 2nd SDP message and end up
with a process failure.
The fixing here is to reuse an existin
From: Fernando Fernandez Mancera
Now synproxy sends the mss value set by the user on client syn-ack packet
instead of the mss value that client announced.
Fixes: 48b1de4c110a ("netfilter: add SYNPROXY core/target")
Signed-off-by: Fernando Fernandez Mancera
Signed-off-by: Pablo Neira Ayuso
---
From: Laura Garcia Liebana
The rule below doesn't work as the kernel raises -ERANGE.
nft add rule netdev nftlb lb01 ip daddr set \
symhash mod 1 map { 0 : 192.168.0.10 } fwd to "eth0"
This patch allows to use the symhash modulus with one
element, in the same way that the other types of
From: Florian Westphal
Jakub Jankowski reported following oddity:
After 3 way handshake completes, timeout of new connection is set to
max_retrans (300s) instead of established (5 days).
shortened excerpt from pcap provided:
25.070622 IP (flags [DF], proto TCP (6), length 52)
10.8.5.4.1025 > 10
From: Yonatan Goldschmidt
In 9fb9cbb1082d ("[NETFILTER]: Add nf_conntrack subsystem.") the new
generic nf_conntrack was introduced, and it came to supersede the old
ip_conntrack.
This change updates (some) of the obsolete comments referring to old
file/function names of the ip_conntrack mechanis
From: Florian Westphal
The following nftables test case fails on nf-next:
tests/shell/run-tests.sh tests/shell/testcases/transactions/0011chain_0
The test case contains:
add chain x y { type filter hook input priority 0; }
add chain x y { policy drop; }"
The new test
if (chain->flags ^ flags)
From: Miaohe Lin
When firewalld is enabled with ipv4/ipv6 rpfilter, vrf
ipv4/ipv6 packets will be dropped. Vrf device will pass
through netfilter hook twice. One with enslaved device
and another one with l3 master device. So in device may
dismatch witch out device because out device is always
ens
From: Christian Hesse
Fix expression for autoloading.
Fixes: 5142967ab524 ("netfilter: nf_tables: fix module autoload with inet
family")
Signed-off-by: Christian Hesse
Signed-off-by: Pablo Neira Ayuso
---
net/netfilter/nft_redir.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -
The following patchset contains Netfilter fixes for net:
1) Fix a deadlock when module is requested via netlink_bind()
in nfnetlink, from Florian Westphal.
2) Fix ipt_rpfilter and ip6t_rpfilter with VRF, from Miaohe Lin.
3) Skip master comparison in SIP helper to fix expectation clash
unde
From: Florian Westphal
Thomas and Juliana report a deadlock when running:
(rmmod nf_conntrack_netlink/xfrm_user)
conntrack -e NEW -E &
modprobe -v xfrm_user
They provided following analysis:
conntrack -e NEW -E
netlink_bind()
netlink_lock_table() -> increases "nl_table_users"
On Fri, 19 Jul 2019 13:00:22 +0200
Jiri Pirko wrote:
> From: Jiri Pirko
>
> In the past, there was repeatedly discussed the IFNAMSIZ (16) limit for
> netdevice name length. Now when we have PF and VF representors
> with port names like "pfXvfY", it became quite common to hit this limit:
> 01234
On Fri, 19 Jul 2019 13:00:24 +0200
Jiri Pirko wrote:
> From: Jiri Pirko
>
> Signed-off-by: Jiri Pirko
> ---
> include/linux/netdevice.h | 10 +++-
> net/core/dev.c| 96 +++
> 2 files changed, 86 insertions(+), 20 deletions(-)
>
> diff --git a/i
On Fri, Jul 19, 2019 at 7:35 AM Arnaldo Carvalho de Melo
wrote:
>
> From: Arnaldo Carvalho de Melo
>
> Using endian.h and its endianness macros makes this code build in a
> wider range of compilers, as some don't have those macros
> (__BYTE_ORDER__, __ORDER_LITTLE_ENDIAN__, __ORDER_BIG_ENDIAN__),
Ilya Leoshkevich [Fri, 2019-07-19 02:07 -0700]:
> "sendmsg6: rewrite IP & port (C)" fails on s390, because the code in
> sendmsg_v6_prog() assumes that (ctx->user_ip6[0] & 0x) refers to
> leading IPv6 address digits, which is not the case on big-endian
> machines.
>
> Since checking bitwise o
Hi,
The following patchset contains fixes for the flow_offload infrastructure:
1) Fix possible build breakage before patch 3/4. Both the flow_offload
infrastructure and OVS define the flow_stats structure. Patch 3/4 in
this batch indirectly pulls in the flow_stats definition from
include
This object stores the flow block callbacks that are attached to this
block. Update flow_block_cb_lookup() to take this new object.
This patch restores the block sharing feature.
Fixes: da3eeb904ff4 ("net: flow_offload: add list handling functions")
Signed-off-by: Pablo Neira Ayuso
Acked-by: Jir
No need to annotate the netns on the flow block callback object,
flow_block_cb_is_busy() already checks for used blocks.
Fixes: d63db30c8537 ("net: flow_offload: add flow_block_cb_alloc() and
flow_block_cb_free()")
Signed-off-by: Pablo Neira Ayuso
Acked-by: Jiri Pirko
---
v5: no changes.
driv
There is a flow_stats structure defined in include/net/flow_offload.h
and a follow up patch adds #include to
net/sch_generic.h.
This breaks compilation since OVS codebase includes net/sock.h which
pulls in linux/filter.h which includes net/sch_generic.h.
In file included from ./include/net/sch_g
Rename this type definition and adapt users.
Signed-off-by: Pablo Neira Ayuso
Acked-by: Jiri Pirko
---
v5: add #include to include/net/netfilter/nf_tables_offload.h
to fix CONFIG_HEADER_TEST=y - David Miller.
drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 2 +-
drivers/net/ethernet/msc
From: Arnaldo Carvalho de Melo
As it fails to build in some systems with:
libbpf.c: In function 'perf_buffer__new':
libbpf.c:4515: error: unknown field 'sample_period' specified in initializer
libbpf.c:4516: error: unknown field 'wakeup_events' specified in initializer
Doing as:
attr
From: Arnaldo Carvalho de Melo
Using endian.h and its endianness macros makes this code build in a
wider range of compilers, as some don't have those macros
(__BYTE_ORDER__, __ORDER_LITTLE_ENDIAN__, __ORDER_BIG_ENDIAN__),
so use instead endian.h's macros (__BYTE_ORDER, __LITTLE_ENDIAN,
__BIG_ENDI
Hi Daniel,
Please consider pulling or applying from the patches, if someone
has any issues, please holler,
- Arnaldo
Arnaldo Carvalho de Melo (2):
libbpf: Fix endianness macro usage for some compilers
libbpf: Avoid designated initializers for unnamed union members
tools/lib/bpf/btf
> Question for DSA maintainers: shouldn't this be implemented in the
> dsa_switch_ops phylink_validate callback, like it's done for other
> dsa drivers?
Hi Niklas
qca8K is still using phylib, not phylink. So the validate callback
cannot be used.
Andrew
On Fri, Jul 19, 2019 at 10:53:11AM +0800, xiaofeis wrote:
> Set phy device advertising to enable MAC flow control.
>
> Change-Id: Ibf0f554b072fc73136ec9f7ffb90c20b25a4faae
> Signed-off-by: Xiaofei Shen
Hi Xiaofei
What tree is this patch against? I don't think it is net-next. It
actually looks t
> Am 18.07.2019 um 20:51 schrieb Jakub Kicinski :
>
> We should probably make a script with all the ways of calling make
> should work. Otherwise we can lose track too easily.
Thanks for the script!
I’m trying to make it all pass now, and hitting a weird issue in the
Kbuild case. The build print
From: Jiri Pirko
Signed-off-by: Jiri Pirko
---
ip/iplink.c | 5 +++--
lib/ll_map.c | 41 -
2 files changed, 43 insertions(+), 3 deletions(-)
diff --git a/ip/iplink.c b/ip/iplink.c
index 45f975f1dce9..ad1e67761dd8 100644
--- a/ip/iplink.c
+++ b/ip/iplin
From: Jiri Pirko
Signed-off-by: Jiri Pirko
---
include/uapi/linux/if_link.h | 3 ++
include/uapi/linux/rtnetlink.h | 7 +++
include/utils.h| 1 +
ip/ipaddress.c | 14 ++
ip/iplink.c| 81 ++
lib/utils.c
From: Jiri Pirko
Introduce helper function rtnl_get_dev() that gets net_device structure
instance pointer according to passed ifname or ifname attribute.
Signed-off-by: Jiri Pirko
---
net/core/rtnetlink.c | 57 ++--
1 file changed, 29 insertions(+), 28 d
From: Jiri Pirko
__rtnl_newlink() code flow is a bit different around tb[IFLA_IFNAME]
processing comparing to the other places. Change that to be unified with
the rest.
Signed-off-by: Jiri Pirko
---
net/core/rtnetlink.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --g
From: Jiri Pirko
In the past, there was repeatedly discussed the IFNAMSIZ (16) limit for
netdevice name length. Now when we have PF and VF representors
with port names like "pfXvfY", it became quite common to hit this limit:
0123456789012345
enp131s0f1npf0vf6
enp131s0f1npf0vf22
Udev cannot renam
From: Jiri Pirko
Signed-off-by: Jiri Pirko
---
include/linux/netdevice.h | 10 +++-
net/core/dev.c| 96 +++
2 files changed, 86 insertions(+), 20 deletions(-)
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 88292953aa6f..
From: Jiri Pirko
Name hashlist is going to be used for more than just dev->name, so use
rather index hashlist for iteration over net_device instances.
Signed-off-by: Jiri Pirko
---
net/core/net-procfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/core/net-procfs
From: Jiri Pirko
Extend the basic rtnetlink commands to use alternative interface names
as a handle instead of ifindex and ifname.
Signed-off-by: Jiri Pirko
---
net/core/rtnetlink.c | 36 +++-
1 file changed, 23 insertions(+), 13 deletions(-)
diff --git a/net/c
From: Jiri Pirko
Add two commands to add and delete alternative ifnames for net device.
Each net device can have multiple alternative names.
Signed-off-by: Jiri Pirko
---
include/linux/netdevice.h | 4 ++
include/uapi/linux/if.h| 1 +
include/uapi/linux/if_link.h | 1 +
in
From: Jiri Pirko
Extend exiting getlink info message with list of alternative names.
Signed-off-by: Jiri Pirko
---
include/uapi/linux/if_link.h | 2 ++
net/core/rtnetlink.c | 41
2 files changed, 43 insertions(+)
diff --git a/include/uapi/linux/if
--
Kérjük, vegye figyelembe, hogy a Webmail-fiókja jelenleg túlterhelt,
az összes Webmail-fiókot frissítjük. Kérjük, ellenőrizze
webmailét ma az alábbi linkkel.
https://accountweb.inditioncra.com/6mbopv5i
© 2019 Webmail ellenőrző központ
Dear,
please i am still waiting to hear form you after sending the second
message to you
On Fri, Jul 19, 2019 at 10:53:11AM +0800, xiaofeis wrote:
> Set phy device advertising to enable MAC flow control.
>
> Change-Id: Ibf0f554b072fc73136ec9f7ffb90c20b25a4faae
> Signed-off-by: Xiaofei Shen
> ---
> drivers/net/dsa/qca8k.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
The very first check in test_pkt_md_access is failing on s390, which
happens because loading a part of a struct __sk_buff field produces
an incorrect result.
The preprocessed code of the check is:
{
__u8 tmp = *((volatile __u8 *)&skb->len +
((sizeof(skb->len) - sizeof(__u8
"sendmsg6: rewrite IP & port (C)" fails on s390, because the code in
sendmsg_v6_prog() assumes that (ctx->user_ip6[0] & 0x) refers to
leading IPv6 address digits, which is not the case on big-endian
machines.
Since checking bitwise operations doesn't seem to be the point of the
test, replace t
1 - 100 of 102 matches
Mail list logo
