[PATCH net] selftests: fib_rule_tests: use pre-defined DEV_ADDR

2019-05-20 Thread Hangbin Liu
DEV_ADDR is defined but not used. Use it in address setting. Do the same with IPv6 for consistency. Reported-by: David Ahern Fixes: fc82d93e57e3 ("selftests: fib_rule_tests: fix local IPv4 address typo") Signed-off-by: Hangbin Liu --- tools/testing/selftests/net/fib_rule_tests.sh | 5 +++-- 1 f

[PATCH net v2] Validate required parameters in inet6_validate_link_af

2019-05-20 Thread Maxim Mikityanskiy
inet6_set_link_af requires that at least one of IFLA_INET6_TOKEN or IFLA_INET6_ADDR_GET_MODE is passed. If none of them is passed, it returns -EINVAL, which may cause do_setlink() to fail in the middle of processing other commands and give the following warning message: A link change request fai

Re: [PATCH v2 net 2/2] net: core: generic XDP support for stacked device

2019-05-20 Thread Jiri Pirko
Mon, May 20, 2019 at 06:04:05PM CEST, step...@networkplumber.org wrote: >On Mon, 20 May 2019 11:11:05 +0200 >Jiri Pirko wrote: > >> Sun, May 19, 2019 at 05:10:46AM CEST, step...@networkplumber.org wrote: >> >When a device is stacked like (team, bonding, failsafe or netvsc) the >> >XDP generic prog

Re: [PATCH v2 net 2/2] net: core: generic XDP support for stacked device

2019-05-20 Thread Jiri Pirko
Tue, May 21, 2019 at 06:47:23AM CEST, jasow...@redhat.com wrote: > >On 2019/5/20 下午5:11, Jiri Pirko wrote: >> Sun, May 19, 2019 at 05:10:46AM CEST, step...@networkplumber.org wrote: >> > When a device is stacked like (team, bonding, failsafe or netvsc) the >> > XDP generic program for the parent de

Re: [PATCH v2 net 2/2] net: core: generic XDP support for stacked device

2019-05-20 Thread Jason Wang
On 2019/5/20 下午11:53, Stephen Hemminger wrote: On Mon, 20 May 2019 11:11:05 +0200 Jiri Pirko wrote: Sun, May 19, 2019 at 05:10:46AM CEST, step...@networkplumber.org wrote: When a device is stacked like (team, bonding, failsafe or netvsc) the XDP generic program for the parent device is not

Re: [PATCH] net: vxlan: disallow removing to other namespace

2019-05-20 Thread Tonghao Zhang
On Tue, May 21, 2019 at 7:53 AM David Miller wrote: > > From: xiangxia.m@gmail.com > Date: Fri, 17 May 2019 19:42:23 -0700 > > > From: Tonghao Zhang > > > > Don't allow to remove the vxlan device to other namesapce, > > because we maintain the data of vxlan net device on original > > net-name

Re: [PATCH v2 net 2/2] net: core: generic XDP support for stacked device

2019-05-20 Thread Jason Wang
On 2019/5/20 下午5:11, Jiri Pirko wrote: Sun, May 19, 2019 at 05:10:46AM CEST, step...@networkplumber.org wrote: When a device is stacked like (team, bonding, failsafe or netvsc) the XDP generic program for the parent device is not called. In these cases, the rx handler changes skb->dev to its

Re: [PATCH] net/mlx5e: Allow removing representors netdev to other namespace

2019-05-20 Thread Tonghao Zhang
On Tue, May 21, 2019 at 4:24 AM Or Gerlitz wrote: > > On Mon, May 20, 2019 at 3:19 PM wrote: > > > > From: Tonghao Zhang > > > > At most case, we use the ConnectX-5 NIC on compute node for VMs, > > but we will offload forwarding rules to NICs on gateway node. > > On the gateway node, we will ins

[PATCH net-next] cxgb4: Revert "cxgb4: Remove SGE_HOST_PAGE_SIZE dependency on page size"

2019-05-20 Thread Vishal Kulkarni
This reverts commit 2391b0030e241386d710df10e53e2cfc3c5d4fc1 SGE's BAR2 Doorbell/GTS Page Size is now interpreted correctly in the firmware itself by using actual host page size. Hence previous commit needs to be reverted. Signed-off-by: Vishal Kulkarni --- drivers/net/ethernet/chelsio/cxgb4/t4_

[PATCH net-next] cxgb4: Enable hash filter with offload

2019-05-20 Thread Vishal Kulkarni
This patch enables hash filter along with offload Signed-off-by: Vishal Kulkarni --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h| 1 + drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c | 38 +++-- drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.h | 2 +- drivers/net/ethernet

Mutual Benefit

2019-05-20 Thread Dave Lin
Hi, I am contacting you with regards to using your last name for funds claim of long dormant funds belonging to a late depositor . Let me know if you are interested for more details . Best Regards David Lin

Re: [PATCH net-next] ptp: Fix example program to match kernel.

2019-05-20 Thread David Miller
From: Richard Cochran Date: Sun, 19 May 2019 22:15:05 -0700 > Ever since commit 3a06c7ac24f9 ("posix-clocks: Remove interval timer > facility and mmap/fasync callbacks") the possibility of PHC based > posix timers has been removed. In addition it will probably never > make sense to implement thi

Re: [PATCH net 0/2] kselftests: fib_rule_tests: fix "from $SRC_IP iif $DEV" match testing

2019-05-20 Thread David Miller
From: Hangbin Liu Date: Mon, 20 May 2019 12:36:53 +0800 > As all the IPv4 testing addresses are in the same subnet and egress > device == ingress device, to pass "from $SRC_IP iif $DEV" match > test, we need enable forwarding to get the route entry. Series applied, thanks.

Re: [[PATCH net-next] 0/2] Convert mdio wait function to use readx_poll_timeout()

2019-05-20 Thread David Miller
From: Benedikt Spranger Date: Sun, 19 May 2019 19:59:35 +0200 > On loaded systems with a preemptible kernel both functions > axienet_mdio_wait_until_ready() and xemaclite_mdio_wait() may report a > false positive error return. > Convert both functions to use readx_poll_timeout() to handle the > s

[RFC PATCH 08/11] perf: add perf_output_begin_forward_in_page

2019-05-20 Thread Kris Van Hees
Right now, BPF programs can only write to a perf event ring buffer by constructing a sample (as an arbitrary chunk of memory of a given size), and calling perf_event_output() to have it written to the ring buffer. A new implementation of DTrace (based on BPF) avoids constructing the data sample pr

Re: [PATCH] net: vxlan: disallow removing to other namespace

2019-05-20 Thread David Miller
From: xiangxia.m@gmail.com Date: Fri, 17 May 2019 19:42:23 -0700 > From: Tonghao Zhang > > Don't allow to remove the vxlan device to other namesapce, > because we maintain the data of vxlan net device on original > net-namespace. > > $ ip netns add ns100 > $ ip link add vxlan100 typ

[RFC PATCH 09/11] bpf: mark helpers explicitly whether they may change the context

2019-05-20 Thread Kris Van Hees
Some helpers may update the context. Right now, various network filter helpers may make changes to the packet data. This is verified by calling the bpf_helper_changes_pkt_data() function with the function pointer. This function resides in net/core/filter.c and needs to be updated for any helper

Re: [PATCH net] ipv6: Consider sk_bound_dev_if when binding a raw socket to an address

2019-05-20 Thread David Ahern
On 5/20/19 12:57 PM, Mike Manning wrote: > IPv6 does not consider if the socket is bound to a device when binding > to an address. The result is that a socket can be bound to eth0 and > then bound to the address of eth1. If the device is a VRF, the result > is that a socket can only be bound to an

Re: [PATCH net 1/2] selftests: fib_rule_tests: fix local IPv4 address typo

2019-05-20 Thread David Ahern
On 5/19/19 10:36 PM, Hangbin Liu wrote: > The IPv4 testing address are all in 192.51.100.0 subnet. It doesn't make > sense to set a 198.51.100.1 local address. Should be a typo. The unused DEV_ADDR suggests you are correct. That should be removed as well or the IPv6 address encoded and used for co

Re: [PATCH iproute2-next] treewide: refactor help messages

2019-05-20 Thread David Ahern
On 5/17/19 7:38 AM, Matteo Croce wrote: > Every tool in the iproute2 package have one or more function to show > an help message to the user. Some of these functions print the help > line by line with a series of printf call, e.g. ip/xfrm_state.c does > 60 fprintf calls. > If we group all the calls

Re: [PATCH 1/8] net: qualcomm: rmnet: fix struct rmnet_map_header

2019-05-20 Thread Alex Elder
On 5/20/19 3:11 PM, Subash Abhinov Kasiviswanathan wrote: > On 2019-05-20 07:53, Alex Elder wrote: >> The C bit-fields in the first byte of the rmnet_map_header structure >> are defined in the wrong order.  The first byte should be formatted >> this way: >> +--- reserved_bit >>

Re: [PATCH] net/mlx5e: restrict the real_dev of vlan device is the same as uplink device

2019-05-20 Thread Saeed Mahameed
On Sun, 2019-05-19 at 06:49 +, Roi Dayan wrote: > > On 18/05/2019 06:10, wenxu wrote: > > There will be multiple vlan device which maybe not belong to the > > uplink rep device, so wen can limit it > > > > 在 2019/5/18 4:30, Saeed Mahameed 写道: > > > On Wed, 2019-05-15 at 17:25 +0800, we...@ucl

[PATCH] Documentation/networking: fix af_xdp.rst Sphinx warnings

2019-05-20 Thread Randy Dunlap
From: Randy Dunlap Fix Sphinx warnings in Documentation/networking/af_xdp.rst by adding indentation: Documentation/networking/af_xdp.rst:319: WARNING: Literal block expected; none found. Documentation/networking/af_xdp.rst:326: WARNING: Literal block expected; none found. Fixes: 0f4a9b7d4ecb

Re: [RFC PATCH v2 net-next 0/3] flow_offload: Re-add per-action statistics

2019-05-20 Thread Jamal Hadi Salim
On 2019-05-20 2:36 p.m., Edward Cree wrote: On 20/05/2019 17:29, Jamal Hadi Salim wrote: Maybe dump after each step and it will be easier to see what is happening. I don't *think* my changes can have caused this, but I'll try a test on a   vanilla kernel just to make sure the same thing happe

Re: IP-Aliasing for IPv6?

2019-05-20 Thread Michal Kubecek
On Mon, May 20, 2019 at 10:23:03PM +0200, M. Buecher wrote: > Used feature is the label option of `ip`, which works for IPv4, but not with > IPv6. The only reason for having these labels is to allow old tools like ifconfig to partially work even if the underlying implementation changed. There is n

Re: IP-Aliasing for IPv6?

2019-05-20 Thread Toke Høiland-Jørgensen
"M. Buecher" writes: > On 2019-05-15 11:26, Michal Kubecek wrote: >> On Tue, May 14, 2019 at 08:49:12PM +0200, M. Buecher wrote: >>> According to the documentation [1] "IP-Aliasing" is an obsolete way to >>> manage multiple IP[v4]-addresses/masks on an interface. >>> For having multiple IP[v4]-ad

Re: [PATCH] net/mlx5e: Allow removing representors netdev to other namespace

2019-05-20 Thread Or Gerlitz
On Mon, May 20, 2019 at 3:19 PM wrote: > > From: Tonghao Zhang > > At most case, we use the ConnectX-5 NIC on compute node for VMs, > but we will offload forwarding rules to NICs on gateway node. > On the gateway node, we will install multiple NICs and set them to > different dockers which contai

Re: IP-Aliasing for IPv6?

2019-05-20 Thread M. Buecher
On 2019-05-15 11:26, Michal Kubecek wrote: On Tue, May 14, 2019 at 08:49:12PM +0200, M. Buecher wrote: According to the documentation [1] "IP-Aliasing" is an obsolete way to manage multiple IP[v4]-addresses/masks on an interface. For having multiple IP[v4]-addresses on an interface this is ab

Re: [PATCH 1/1] vmalloc: Fix issues with flush flag

2019-05-20 Thread Edgecombe, Rick P
On Fri, 2019-05-17 at 14:01 -0700, Rick Edgecomb e wrote: > Meelis Roos reported issues with the new VM_FLUSH_RESET_PERMS flag on > the > sparc architecture. > Argh, this patch is not correct in the flush range for non-x86. I'll send a revision.

Re: [PATCH net 3/3] Documentation: add TLS offload documentation

2019-05-20 Thread Jakub Kicinski
On Sun, 19 May 2019 06:24:36 +, Boris Pismenny wrote: > On 5/16/2019 8:56 PM, Jakub Kicinski wrote: > > On Thu, 16 May 2019 09:08:52 +, Boris Pismenny wrote: > >>> diff --git a/Documentation/networking/tls-offload.rst > >>> b/Documentation/networking/tls-offload.rst > >>> new file mode 1

Re: [PATCH net] net/ipv6: Reinstate ping/traceroute use with source address in VRF

2019-05-20 Thread Mike Manning
On 20/05/2019 17:58, David Ahern wrote: > On 5/20/19 2:40 AM, Mike Manning wrote: >> Since the commit 1893ff20275b ("net/ipv6: Add l3mdev check to >> ipv6_chk_addr_and_flags"), traceroute using TCP SYN or ICMP ECHO option >> and ping fail when specifying a source address typically on a loopback >>

Re: [PATCH bpf] bpf: Check sk_fullsock() before returning from bpf_sk_lookup()

2019-05-20 Thread Joe Stringer
On Fri, May 17, 2019 at 2:21 PM Martin KaFai Lau wrote: > > The BPF_FUNC_sk_lookup_xxx helpers return RET_PTR_TO_SOCKET_OR_NULL. > Meaning a fullsock ptr and its fullsock's fields in bpf_sock can be > accessed, e.g. type, protocol, mark and priority. > Some new helper, like bpf_sk_storage_get(), a

[PATCH net] ipv6: Consider sk_bound_dev_if when binding a raw socket to an address

2019-05-20 Thread Mike Manning
IPv6 does not consider if the socket is bound to a device when binding to an address. The result is that a socket can be bound to eth0 and then bound to the address of eth1. If the device is a VRF, the result is that a socket can only be bound to an address in the default VRF. Resolve by consideri

Re: [PATCH bpf] bpf: Check sk_fullsock() before returning from bpf_sk_lookup()

2019-05-20 Thread Joe Stringer
On Sat, May 18, 2019 at 7:08 PM Martin Lau wrote: > > On Sat, May 18, 2019 at 06:52:48PM -0700, Joe Stringer wrote: > > On Sat, May 18, 2019, 09:05 Martin Lau wrote: > > > > > > On Sat, May 18, 2019 at 08:38:46AM -1000, Joe Stringer wrote: > > > > On Fri, May 17, 2019, 12:02 Martin Lau wrote: >

Re: [PATCH bpf] bpf: Check sk_fullsock() before returning from bpf_sk_lookup()

2019-05-20 Thread Martin Lau
On Sat, May 18, 2019 at 07:07:29PM -0700, Martin Lau wrote: > On Sat, May 18, 2019 at 06:52:48PM -0700, Joe Stringer wrote: > > On Sat, May 18, 2019, 09:05 Martin Lau wrote: > > > > > > On Sat, May 18, 2019 at 08:38:46AM -1000, Joe Stringer wrote: > > > > On Fri, May 17, 2019, 12:02 Martin Lau wr

Re: [PATCH net] net/mlx4_en: ethtool, Remove unsupported SFP EEPROM high pages query

2019-05-20 Thread David Miller
From: Tariq Toukan Date: Mon, 20 May 2019 17:42:52 +0300 > From: Erez Alfasi > > Querying EEPROM high pages data for SFP module is currently > not supported by our driver but is still tried, resulting in > invalid FW queries. > > Set the EEPROM ethtool data length to 256 for SFP module to > li

Re: [RFC PATCH v2 net-next 0/3] flow_offload: Re-add per-action statistics

2019-05-20 Thread Edward Cree
On 20/05/2019 17:29, Jamal Hadi Salim wrote: > Maybe dump after each step and it will be easier to see what is > happening. > >> I don't *think* my changes can have caused this, but I'll try a test on a >>   vanilla kernel just to make sure the same thing happens there. > > Possible an offload bug

Re: [PATCH net-next 1/4] net: phylink: support for link gpio interrupt

2019-05-20 Thread Russell King - ARM Linux admin
On Mon, May 20, 2019 at 11:22:21AM -0700, Florian Fainelli wrote: > On 5/20/19 8:22 AM, Russell King wrote: > > Add support for using GPIO interrupts with a fixed-link GPIO rather than > > polling the GPIO every second and invoking the phylink resolution. This > > avoids unnecessary calls to mac_c

Re: [PATCH rdma-next 01/15] rds: Don't check return value from destroy CQ

2019-05-20 Thread Leon Romanovsky
On Mon, May 20, 2019 at 10:17:43AM -0700, Santosh Shilimkar wrote: > On 5/19/2019 11:54 PM, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > There is no value in checking ib_destroy_cq() result and skipping > > to clear struct ic fields. This connection needs to be reinitialized > > anyway

Re: [PATCH 2/5] libbpf: add missing typedef

2019-05-20 Thread Stanislav Fomichev
On 05/20, Matteo Croce wrote: > On Mon, May 20, 2019 at 6:53 PM Stanislav Fomichev wrote: > > > > On 05/18, Matteo Croce wrote: > > > Sync tools/include/linux/types.h with the UAPI one to fix this build > > > error: > > > > > > make -C samples/bpf/../../tools/lib/bpf/ RM='rm -rf' LDFLAGS= > > >

Re: [PATCH net-next 4/4] net: sfp: remove sfp-bus use of netdevs

2019-05-20 Thread Florian Fainelli
On 5/20/19 8:22 AM, Russell King wrote: > The sfp-bus code now no longer has any use for the network device > structure, so remove its use. > > Signed-off-by: Russell King Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net-next 3/4] net: sfp: add mandatory attach/detach methods for sfp buses

2019-05-20 Thread Florian Fainelli
On 5/20/19 8:22 AM, Russell King wrote: > Add attach and detach methods for SFP buses, which will allow us to get > rid of the netdev storage in sfp-bus. > > Signed-off-by: Russell King Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net-next 2/4] net: phy: allow Clause 45 access via mii ioctl

2019-05-20 Thread Florian Fainelli
On 5/20/19 8:22 AM, Russell King wrote: > Allow userspace to generate Clause 45 MII access cycles via phylib. > This is useful for tools such as mii-diag to be able to inspect Clause > 45 PHYs. > > Signed-off-by: Russell King Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net-next 1/4] net: phylink: support for link gpio interrupt

2019-05-20 Thread Florian Fainelli
On 5/20/19 8:22 AM, Russell King wrote: > Add support for using GPIO interrupts with a fixed-link GPIO rather than > polling the GPIO every second and invoking the phylink resolution. This > avoids unnecessary calls to mac_config(). > > Signed-off-by: Russell King Reviewed-by: Florian Fainelli

Re: [PATCH net] Validate required parameters in inet6_validate_link_af

2019-05-20 Thread David Miller
From: Maxim Mikityanskiy Date: Mon, 20 May 2019 08:08:07 + > +static int inet6_validate_link_af(const struct net_device *dev, > + const struct nlattr *nla) > +{ > + struct inet6_dev *idev = NULL; > + struct nlattr *tb[IFLA_INET6_MAX + 1]; > + int err;

Re: [RFC PATCH v2 net-next 0/3] flow_offload: Re-add per-action statistics

2019-05-20 Thread Edward Cree
On 20/05/2019 17:29, Jamal Hadi Salim wrote: > On 2019-05-20 12:10 p.m., Edward Cree wrote: >> # tc filter del dev $vfrep parent : pref 49151 >> # tc -stats filter show dev $vfrep parent : >> filter protocol arp pref 49152 flower chain 0 >> filter protocol arp pref 49152 flower chain 0 hand

Re: [PATCH rdma-next 01/15] rds: Don't check return value from destroy CQ

2019-05-20 Thread Santosh Shilimkar
On 5/19/2019 11:54 PM, Leon Romanovsky wrote: From: Leon Romanovsky There is no value in checking ib_destroy_cq() result and skipping to clear struct ic fields. This connection needs to be reinitialized anyway. Signed-off-by: Leon Romanovsky --- net/rds/ib_cm.c | 8 1 file changed

Re: [PATCH iproute2 net-next] ip: add a new parameter -Numeric

2019-05-20 Thread Stephen Hemminger
On Mon, 20 May 2019 09:18:08 -0600 David Ahern wrote: > On 5/20/19 1:56 AM, Hangbin Liu wrote: > > When calles rtnl_dsfield_n2a(), we get the dsfield name from > > /etc/iproute2/rt_dsfield. But different distribution may have > > different names. So add a new parameter '-Numeric' to only show > >

Re: [PATCH net] net/ipv6: Reinstate ping/traceroute use with source address in VRF

2019-05-20 Thread David Ahern
On 5/20/19 2:40 AM, Mike Manning wrote: > Since the commit 1893ff20275b ("net/ipv6: Add l3mdev check to > ipv6_chk_addr_and_flags"), traceroute using TCP SYN or ICMP ECHO option > and ping fail when specifying a source address typically on a loopback > /dummy interface in the same VRF, e.g.: > >

Re: [RFC PATCH v2 net-next 0/3] flow_offload: Re-add per-action statistics

2019-05-20 Thread Jamal Hadi Salim
On 2019-05-20 12:29 p.m., Jamal Hadi Salim wrote: Assuming in this case you added by value the actions? To be clear on the terminology: "By Value" implies you add the filter and action in the same command line. "By Reference" implies you first create the action then create a filter which binds

Re: [RFC PATCH v2 net-next 0/3] flow_offload: Re-add per-action statistics

2019-05-20 Thread Jamal Hadi Salim
On 2019-05-20 12:10 p.m., Edward Cree wrote: On 20/05/2019 16:38, Jamal Hadi Salim wrote: That is fine then if i could do: tc actions add action drop index 104 then followed by for example the two filters you show below.. That seems to work. nice. Is your hardware not using explicit indic

Re: [RFC PATCH v2 net-next 0/3] flow_offload: Re-add per-action statistics

2019-05-20 Thread Edward Cree
On 20/05/2019 16:38, Jamal Hadi Salim wrote: > That is fine then if i could do: > > tc actions add action drop index 104 > then > followed by for example the two filters you show below.. That seems to work. > Is your hardware not using explicit indices into a stats table? No; we ask the HW to allo

Re: [PATCH v2 net 2/2] net: core: generic XDP support for stacked device

2019-05-20 Thread Stephen Hemminger
On Mon, 20 May 2019 11:11:05 +0200 Jiri Pirko wrote: > Sun, May 19, 2019 at 05:10:46AM CEST, step...@networkplumber.org wrote: > >When a device is stacked like (team, bonding, failsafe or netvsc) the > >XDP generic program for the parent device is not called. In these > >cases, the rx handler ch

Re: [RFC PATCH v2 net-next 2/3] flow_offload: restore ability to collect separate stats per action

2019-05-20 Thread Jamal Hadi Salim
On 2019-05-20 11:46 a.m., Edward Cree wrote: I can't see anything stats-offload related in net/sched/cls_u32.c (just  SW stats dumping in u32_dump()) and it doesn't call  tcf_exts_stats_update() either.  Looking through ixgbe code I also  don't see any sign there of stats gathering for offloa

Re: [PATCH v2 net 2/2] net: core: generic XDP support for stacked device

2019-05-20 Thread Stephen Hemminger
On Mon, 20 May 2019 11:11:05 +0200 Jiri Pirko wrote: > Sun, May 19, 2019 at 05:10:46AM CEST, step...@networkplumber.org wrote: > >When a device is stacked like (team, bonding, failsafe or netvsc) the > >XDP generic program for the parent device is not called. In these > >cases, the rx handler ch

Re: [RFC PATCH v2 net-next 2/3] flow_offload: restore ability to collect separate stats per action

2019-05-20 Thread Edward Cree
On 18/05/2019 21:35, Jamal Hadi Salim wrote: > Your patch doesnt have U32. IIRC, I have seen stats on ixgbe with the > u32 classifier last time i mucked around with it > (maybe Pablo's changes removed it?). I can't see anything stats-offload related in net/sched/cls_u32.c (just  SW stats dumping in

Re: [RFC PATCH v2 net-next 0/3] flow_offload: Re-add per-action statistics

2019-05-20 Thread Pablo Neira Ayuso
On Mon, May 20, 2019 at 04:37:10PM +0100, Edward Cree wrote: > On 19/05/2019 01:22, Pablo Neira Ayuso wrote: > > On Fri, May 17, 2019 at 04:27:29PM +0100, Edward Cree wrote: > >> On 15/05/2019 20:39, Edward Cree wrote: > > [...] > >> Pablo, how do the two options interact with your netfilter offloa

Re: [RFC PATCH v2 net-next 0/3] flow_offload: Re-add per-action statistics

2019-05-20 Thread Jamal Hadi Salim
On 2019-05-20 11:37 a.m., Edward Cree wrote: On 19/05/2019 01:22, Pablo Neira Ayuso wrote: On Fri, May 17, 2019 at 04:27:29PM +0100, Edward Cree wrote: Thanks.  Looking at net/netfilter/nfnetlink_acct.c, it looks as though you  don't have a u32 index in there; for the cookie approach, would

Re: [PATCH net-next 0/4] phylink/sfp updates

2019-05-20 Thread Vladimir Oltean
On Mon, 20 May 2019 at 18:21, Russell King - ARM Linux admin wrote: > > Hi, > > I realise that net-next probably isn't open yet, but I believe folk > will find these patches "interesting" so I'm sending them to share > them with people working on this code, rather than expecting them to > be picke

Re: [RFC PATCH v2 net-next 0/3] flow_offload: Re-add per-action statistics

2019-05-20 Thread Jamal Hadi Salim
On 2019-05-20 11:26 a.m., Edward Cree wrote: On 18/05/2019 21:39, Jamal Hadi Salim wrote: On 2019-05-17 1:14 p.m., Edward Cree wrote: On 17/05/2019 16:27, Edward Cree wrote: Unless *I* missed something, I'm not changing the TC<=>user-space API at  all.  If user space specifies an index, the

Re: [PATCH 1/8] net: qualcomm: rmnet: fix struct rmnet_map_header

2019-05-20 Thread Bjorn Andersson
On Mon 20 May 06:53 PDT 2019, Alex Elder wrote: > The C bit-fields in the first byte of the rmnet_map_header structure > are defined in the wrong order. The first byte should be formatted > this way: > +--- reserved_bit > | +- cd_bit > |

Re: [RFC PATCH v2 net-next 0/3] flow_offload: Re-add per-action statistics

2019-05-20 Thread Edward Cree
On 19/05/2019 01:22, Pablo Neira Ayuso wrote: > On Fri, May 17, 2019 at 04:27:29PM +0100, Edward Cree wrote: >> On 15/05/2019 20:39, Edward Cree wrote: > [...] >> Pablo, how do the two options interact with your netfilter offload?  I'm >>  guessing it's easier for you to find a unique pointer than

Re: [RFC PATCH v2 net-next 0/3] flow_offload: Re-add per-action statistics

2019-05-20 Thread Edward Cree
On 18/05/2019 21:39, Jamal Hadi Salim wrote: > On 2019-05-17 1:14 p.m., Edward Cree wrote: >> On 17/05/2019 16:27, Edward Cree wrote: >>> I'm now leaning towards the >>>   approach of adding "unsigned long cookie" to struct flow_action_entry >>>   and populating it with (unsigned long)act in tc_set

[PATCH net-next 3/4] net: sfp: add mandatory attach/detach methods for sfp buses

2019-05-20 Thread Russell King
Add attach and detach methods for SFP buses, which will allow us to get rid of the netdev storage in sfp-bus. Signed-off-by: Russell King --- drivers/net/phy/phylink.c | 16 drivers/net/phy/sfp-bus.c | 4 ++-- include/linux/sfp.h | 6 ++ 3 files changed, 24 insertion

[PATCH net-next 2/4] net: phy: allow Clause 45 access via mii ioctl

2019-05-20 Thread Russell King
Allow userspace to generate Clause 45 MII access cycles via phylib. This is useful for tools such as mii-diag to be able to inspect Clause 45 PHYs. Signed-off-by: Russell King --- drivers/net/phy/phy.c | 33 - 1 file changed, 24 insertions(+), 9 deletions(-) diff

[PATCH net-next 4/4] net: sfp: remove sfp-bus use of netdevs

2019-05-20 Thread Russell King
The sfp-bus code now no longer has any use for the network device structure, so remove its use. Signed-off-by: Russell King --- drivers/net/phy/phylink.c | 3 +-- drivers/net/phy/sfp-bus.c | 10 +++--- include/linux/sfp.h | 6 ++ 3 files changed, 6 insertions(+), 13 deletions(-)

[PATCH net-next 1/4] net: phylink: support for link gpio interrupt

2019-05-20 Thread Russell King
Add support for using GPIO interrupts with a fixed-link GPIO rather than polling the GPIO every second and invoking the phylink resolution. This avoids unnecessary calls to mac_config(). Signed-off-by: Russell King --- drivers/net/phy/phylink.c | 36 1 file

[PATCH net-next 0/4] phylink/sfp updates

2019-05-20 Thread Russell King - ARM Linux admin
Hi, I realise that net-next probably isn't open yet, but I believe folk will find these patches "interesting" so I'm sending them to share them with people working on this code, rather than expecting them to be picked up this week. The first patch adds support for using interrupts when using a GP

Re: [PATCH iproute2 net-next] ip: add a new parameter -Numeric

2019-05-20 Thread David Ahern
On 5/20/19 1:56 AM, Hangbin Liu wrote: > When calles rtnl_dsfield_n2a(), we get the dsfield name from > /etc/iproute2/rt_dsfield. But different distribution may have > different names. So add a new parameter '-Numeric' to only show > the dsfield number. > > This parameter is only used for tos valu

[PATCH net] net: phylink: ensure inband AN works correctly

2019-05-20 Thread Russell King
Do not update the link interface mode while the link is down to avoid spurious link interface changes. Always call mac_config if we have a PHY to propagate the pause mode settings to the MAC. Signed-off-by: Russell King --- drivers/net/phy/phylink.c | 37 +++-- 1

Re: [RFC] vsock: proposal to support multiple transports at runtime

2019-05-20 Thread Stefano Garzarella
Hi Dexuan, On Thu, May 16, 2019 at 09:48:11PM +, Dexuan Cui wrote: > > From: Stefano Garzarella > > Sent: Tuesday, May 14, 2019 1:16 AM > > To: netdev@vger.kernel.org; Stefan Hajnoczi ; Dexuan > > > > Hi guys, > > I'm currently interested on implement a multi-transport support for VSOCK in >

[PATCH net] net/mlx4_en: ethtool, Remove unsupported SFP EEPROM high pages query

2019-05-20 Thread Tariq Toukan
From: Erez Alfasi Querying EEPROM high pages data for SFP module is currently not supported by our driver but is still tried, resulting in invalid FW queries. Set the EEPROM ethtool data length to 256 for SFP module to limit the reading for page 0 only and prevent invalid FW queries. Fixes: 720

Re: NVMEM address DT post processing [Was: Re: [PATCH net 0/3] add property "nvmem_macaddr_swap" to swap macaddr bytes order]

2019-05-20 Thread Rob Herring
On Mon, May 13, 2019 at 6:16 AM Petr Štetiar wrote: > > Srinivas Kandagatla [2019-05-13 11:06:48]: > > > On 13/05/2019 10:07, Petr Štetiar wrote: > > > Srinivas Kandagatla [2019-05-13 > > > 09:25:55]: > > > > > > > My initial idea was to add compatible strings to the cell so that most > > > >

[PATCH] net: vxlan: disallow removing to other namespace

2019-05-20 Thread xiangxia . m . yue
From: Tonghao Zhang Don't allow to remove the vxlan device to other namesapce, because we maintain the data of vxlan net device on original net-namespace. $ ip netns add ns100 $ ip link add vxlan100 type vxlan dstport 4789 external $ ip link set dev vxlan100 netns ns100 $ ip netn

Re: [PATCH iproute2 v2] m_mirred: don't bail if the control action is missing

2019-05-20 Thread Roman Mashak
On Mon, May 20, 2019 at 5:58 AM Paolo Abeni wrote: > > The mirred act admits an optional control action, defaulting > to TC_ACT_PIPE. The parsing code currently emits an error message > if the control action is not provided on the command line, even > if the command itself completes with no error.

Re: [PATCH] can: flexcan: fix deadlock when using self wakeup

2019-05-20 Thread Marc Kleine-Budde
On 5/17/19 4:39 AM, Joakim Zhang wrote: > As reproted by Sean Nyekjaer bellow: > When suspending, when there is still can traffic on the > interfaces the flexcan immediately wakes the platform again. > As it should :-) > But it throws this error msg: > [ 3169.378661] PM: noirq suspend of devices fa

[PATCH] net/mlx5e: Allow removing representors netdev to other namespace

2019-05-20 Thread xiangxia . m . yue
From: Tonghao Zhang At most case, we use the ConnectX-5 NIC on compute node for VMs, but we will offload forwarding rules to NICs on gateway node. On the gateway node, we will install multiple NICs and set them to different dockers which contain different net namespace, different routing table. I

Re: [PATCH iproute2 net-next] ip: add a new parameter -Numeric

2019-05-20 Thread Phil Sutter
Hi, On Mon, May 20, 2019 at 03:56:48PM +0800, Hangbin Liu wrote: > When calles rtnl_dsfield_n2a(), we get the dsfield name from > /etc/iproute2/rt_dsfield. But different distribution may have > different names. So add a new parameter '-Numeric' to only show > the dsfield number. > > This paramete

[PATCH iproute2 v2] m_mirred: don't bail if the control action is missing

2019-05-20 Thread Paolo Abeni
The mirred act admits an optional control action, defaulting to TC_ACT_PIPE. The parsing code currently emits an error message if the control action is not provided on the command line, even if the command itself completes with no error. This change shuts down the error message, using the appropri

Re: [PATCH v2 net 2/2] net: core: generic XDP support for stacked device

2019-05-20 Thread Jiri Pirko
Sun, May 19, 2019 at 05:10:46AM CEST, step...@networkplumber.org wrote: >When a device is stacked like (team, bonding, failsafe or netvsc) the >XDP generic program for the parent device is not called. In these >cases, the rx handler changes skb->dev to its own in the receive >handler, and returns

[PATCH net] net/ipv6: Reinstate ping/traceroute use with source address in VRF

2019-05-20 Thread Mike Manning
Since the commit 1893ff20275b ("net/ipv6: Add l3mdev check to ipv6_chk_addr_and_flags"), traceroute using TCP SYN or ICMP ECHO option and ping fail when specifying a source address typically on a loopback /dummy interface in the same VRF, e.g.: # ip vrf exec vrfgreen ping 3000::1 -I ::2

Re: [PATCH] netfilter: ctnetlink: Resolve conntrack L3-protocol flush regression

2019-05-20 Thread Nicolas Dichtel
Le 06/05/2019 à 15:16, Pablo Neira Ayuso a écrit : > On Mon, May 06, 2019 at 10:49:52AM +0200, Nicolas Dichtel wrote: [snip] >> Is it possible to queue this for stable? > > Sure, as soon as this hits Linus' tree. > FYI, it's now in Linus tree: https://git.kernel.org/pub/scm/linux/kernel/git/torva

[PATCH ethtool] ethtool.spec: Use standard file location macros

2019-05-20 Thread Tariq Toukan
From: Mikhael Goikhman Use _prefix and _sbindir macros to allow building the package under a different prefix. Signed-off-by: Mikhael Goikhman Signed-off-by: Tzafrir Cohen Signed-off-by: Tariq Toukan --- ethtool.spec.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/

Re: patch for iproute2

2019-05-20 Thread Hangbin Liu
On Sat, May 18, 2019 at 01:52:36PM +1000, Martin Kealey wrote: > > Hello iproute2 maintainer. > > (Sorry, I don't know your name) > > I recently noticed a discrepancy: the internal documentation for the ip > command says that an *RTT* value can be sufficed with "s" (second) or "ms" > (millisecon

[PATCH net] Validate required parameters in inet6_validate_link_af

2019-05-20 Thread Maxim Mikityanskiy
inet6_set_link_af requires that at least one of IFLA_INET6_TOKEN or IFLA_INET6_ADDR_GET_MODE is passed. If none of them is passed, it returns -EINVAL, which may cause do_setlink() to fail in the middle of processing other commands and give the following warning message: A link change request fai

[PATCH iproute2 net-next] ip: add a new parameter -Numeric

2019-05-20 Thread Hangbin Liu
When calles rtnl_dsfield_n2a(), we get the dsfield name from /etc/iproute2/rt_dsfield. But different distribution may have different names. So add a new parameter '-Numeric' to only show the dsfield number. This parameter is only used for tos value at present. We could enable this for other fields