Re: [PATCH v3 net-next 10/15] net: aquantia: introduce fwreq mutex

2019-04-26 Thread Igor Russkikh
On 27.04.2019 0:20, Andrew Lunn wrote: > On Fri, Apr 26, 2019 at 09:48:02AM +, Igor Russkikh wrote: >> From: Nikita Danilov >> >> Some of FW operations could be invoked simultaneously, >> from f.e. ethtool context and from service service activity work. >> Here we introduce a fw mutex to sec

Re: [PATCH v3 net-next 14/15] net: aquantia: fixups on 64bit dma counters

2019-04-26 Thread Igor Russkikh
On 27.04.2019 0:36, Andrew Lunn wrote: >> +self->curr_stats.dma_pkt_rc = >> hw_atl_stats_rx_dma_good_pkt_counterlsw_get(self) + >> + >> ((u64)hw_atl_stats_rx_dma_good_pkt_countermsw_get(self) << 32); > > Don't you need to do something to avoid issue with ov

Re: [PATCH v3 net-next 04/15] net: aquantia: link interrupt handling function

2019-04-26 Thread Igor Russkikh
>> +static irqreturn_t aq_linkstate_threaded_isr(int irq, void *private) >> +{ >> +struct aq_nic_s *self = private; >> + >> +if (!self) >> +return IRQ_NONE; >> + >> +aq_nic_update_link_status(self); >> + >> +self->aq_hw_ops->hw_irq_enable(self->aq_hw, >> +

WaitYourReply

2019-04-26 Thread Ella Golan
My name is Ms Ella Golan, I'm the Chief Executive Officer (C.P.A) of the First International Bank of Israel (FIBI). I'm getting in touch with you in regards to a very important and urgent matter. Kindly respond back at your earliest convenience so I can provide you the details. Faithfully, Ms Ell

Re: [PATCH v3 net-next 02/15] net: aquantia: implement hwmon api for chip temperature

2019-04-26 Thread Igor Russkikh
On 27.04.2019 0:06, Andrew Lunn wrote: >> +void aq_drvinfo_exit(struct net_device *ndev) >> +{ >> +} > > Nit: > > I don't think any of the other patches add anything to this. So i > suggest killing it. Ok, indeed. Will fix in v4 Thanks Igor

Re: [PATCH mlx5-next 09/11] net/mlx5: Eswitch, enable RoCE loopback traffic

2019-04-26 Thread Leon Romanovsky
On Fri, Apr 26, 2019 at 09:58:23PM +, Saeed Mahameed wrote: > From: Maor Gottlieb > > When in switchdev mode, we would like to treat loopback RoCE > traffic (on eswitch manager) as RDMA and not as regular > Ethernet traffic > In order to enable it we add flow steering rule that forward RoCE >

Re: 32-bit zext time complexity (Was Re: [PATCH bpf-next] selftests/bpf: two scale tests)

2019-04-26 Thread Alexei Starovoitov
On Fri, Apr 26, 2019 at 03:50:33PM +0100, Edward Cree wrote: > On 26/04/2019 14:06, Jiong Wang wrote: > > Alexei Starovoitov writes: > >> Note that bpf_patch_insn_single() is calling bpf_adj_branches() twice too. > >> And dead_code + convert_ctx + fixup_bpf_calls are calling > >> bpf_patch_insn_sin

Re: 32-bit zext time complexity (Was Re: [PATCH bpf-next] selftests/bpf: two scale tests)

2019-04-26 Thread Alexei Starovoitov
On Fri, Apr 26, 2019 at 02:06:33PM +0100, Jiong Wang wrote: > > Alexei Starovoitov writes: > > > On Thu, Apr 25, 2019 at 08:25:44AM +0100, Jiong Wang wrote: > >> > >> Alexei Starovoitov writes: > >> > >> > On Thu, Apr 25, 2019 at 12:07:06AM +0100, Jiong Wang wrote: > >> >> > >> >> Alexei Staro

Re: [PATCH v2 0/5] strict netlink validation

2019-04-26 Thread David Ahern
On 4/26/19 6:07 AM, Johannes Berg wrote: > Here's a respin, with the following changes: > * change message when rejecting unknown attribute types (David Ahern) > * drop nl80211 patch - I'll apply it separately > * remove NL_VALIDATE_POLICY - we have a lot of calls to nla_parse() >that really

Re: [PATCH bpf-next 0/2] Two arm64 bpf jit improvements

2019-04-26 Thread Alexei Starovoitov
On Fri, Apr 26, 2019 at 12:48 PM Daniel Borkmann wrote: > > This set holds two arm64 bpf jit improvements for xadd. Thanks! Applied to bpf-next. Thanks

[PATCH net-next 0/7] ipv4 ipv6: Move location of pcpu route cache and exceptions

2019-04-26 Thread David Ahern
From: David Ahern This series moves IPv4 pcpu cached routes from fib_nh to fib_nh_common to make the caches avaialable for IPv6 nexthops (fib6_nh) with IPv4 routes. This allows a fib6_nh struct to be used with both IPv4 and and IPv6 routes. In addition pcpu caches and exception entries for IPv6

[PATCH net-next 6/7] ipv6: Refactor exception functions

2019-04-26 Thread David Ahern
From: David Ahern Before moving exception bucket from fib6_info to fib6_nh, refactor rt6_flush_exceptions, rt6_remove_exception_rt, rt6_mtu_change_route, and rt6_update_exception_stamp_rt. In all 3 cases, move the primary logic into a new helper that starts with fib6_nh_. The latter 3 functions s

[PATCH net-next 2/7] ipv4: Pass fib_nh_common to rt_cache_route

2019-04-26 Thread David Ahern
From: David Ahern Now that the cached routes are in fib_nh_common, pass it to rt_cache_route and simplify its callers. For rt_set_nexthop, the tclassid becomes the last user of fib_nh so move it under an IS_ENABLED check. Signed-off-by: David Ahern --- net/ipv4/route.c | 23 +++

[PATCH net-next 3/7] ipv4: Move exception bucket to nh_common

2019-04-26 Thread David Ahern
From: David Ahern Similar to the cached routes, make IPv4 exceptions accessible when using an IPv6 nexthop struct with IPv4 routes. Simplify the exception functions by passing in fib_nh_common since that is all it needs, and then cleanup the call sites that have extraneous fib_nh conversions. As

[PATCH net-next 4/7] ipv6: Move pcpu cached routes to fib6_nh

2019-04-26 Thread David Ahern
From: David Ahern rt6_info are specific instances of a fib entry and are tied to a device and gateway - ie., a nexthop. Before nexthop objects, IPv6 fib entries have separate fib6_info for each nexthop in a multipath route, so the location of the pcpu cache in the fib6_info struct worked. However

[PATCH net-next 7/7] ipv6: Move exception bucket to fib6_nh

2019-04-26 Thread David Ahern
From: David Ahern Similar to the pcpu routes exceptions are really per nexthop, so move rt6i_exception_bucket from fib6_info to fib6_nh. To avoid additional increases to the size of fib6_nh for a 1-bit flag, use the lowest bit in the allocated memory pointer for the flushed flag. Add helpers for

[PATCH net-next 1/7] ipv4: Move cached routes to fib_nh_common

2019-04-26 Thread David Ahern
From: David Ahern While the cached routes, nh_pcpu_rth_output and nh_rth_input, are IPv4 specific, a later patch wants to make them accessible for IPv6 nexthops with IPv4 routes using a fib6_nh. Move the cached routes from fib_nh to fib_nh_common and update references. Initialization of the cach

[PATCH net-next 5/7] ipv6: Refactor fib6_drop_pcpu_from

2019-04-26 Thread David Ahern
From: David Ahern Move the existing pcpu walk in fib6_drop_pcpu_from to a new helper, __fib6_drop_pcpu_from, that can be invoked per fib6_nh with a reference to the from entries that need to be evicted. If the passed in from is non-NULL then only entries associated with that fib6_info are removed

My name is Mrs. Coan Kanazawa from Mongolia

2019-04-26 Thread MRS COAN KANAZAWA
My name is Mrs. Coan Kanazawa from Mongolia, I know that this message might come to you as surprise because we don't know each other nor have we ever met before but accept it with an open and positive mind. I have a Very important request that made me to contact you; I was diagnosed with ovarian c

Re: [PATCH 4.9 stable 0/5] net: ip6 defrag: backport fixes

2019-04-26 Thread Captain Wiggum
Thanks Peter! I have your patch for 4.14 running now. Then I'll run this patch for 4.9. I'll report the results by Monday. --John Masinter On Fri, Apr 26, 2019 at 9:41 AM Peter Oskolkov wrote: > > This is a backport of a 5.1rc patchset: > https://patchwork.ozlabs.org/cover/1029418/ > > Which wa

[PATCH v4 bpf-next 7/7] bpf: Add ene-to-end test for bpf_sk_storage_* helpers

2019-04-26 Thread Martin KaFai Lau
This patch rides on an existing BPF_PROG_TYPE_CGROUP_SKB test (test_sock_fields.c) to do a TCP end-to-end test on the new bpf_sk_storage_* helpers. Signed-off-by: Martin KaFai Lau --- tools/testing/selftests/bpf/bpf_helpers.h | 5 + .../bpf/progs/test_sock_fields_kern.c | 53 +

[PATCH v4 bpf-next 5/7] bpf: Add verifier tests for the bpf_sk_storage

2019-04-26 Thread Martin KaFai Lau
This patch adds verifier tests for the bpf_sk_storage: 1. ARG_PTR_TO_MAP_VALUE_OR_NULL 2. Map and helper compatibility (e.g. disallow bpf_map_loookup_elem) It also takes this chance to remove the unused struct btf_raw_data and uses the BTF encoding macros from "test_btf.h". Acked-by: Yonghong Son

[PATCH v4 bpf-next 4/7] bpf: Refactor BTF encoding macro to test_btf.h

2019-04-26 Thread Martin KaFai Lau
Refactor common BTF encoding macros for other tests to use. The libbpf may reuse some of them in the future which requires some more thoughts before publishing as a libbpf API. Signed-off-by: Martin KaFai Lau --- tools/testing/selftests/bpf/test_btf.c | 63 +-- tools/testing

[PATCH v4 bpf-next 0/7] BPF sk local storage

2019-04-26 Thread Martin KaFai Lau
v4: - Move checks to map_alloc_check in patch 1 (Stanislav Fomichev) - Refactor BTF encoding macros to test_btf.h at a new patch 4 (Stanislav Fomichev) - Refactor getenv and add print PASS message at the end of the test in patch 6 (Yonghong Song) v3: - Replace spinlock_types.h with spinlock.h

[PATCH v4 bpf-next 6/7] bpf: Add BPF_MAP_TYPE_SK_STORAGE test to test_maps

2019-04-26 Thread Martin KaFai Lau
This patch adds BPF_MAP_TYPE_SK_STORAGE test to test_maps. The src file is rather long, so it is put into another dir map_tests/ and compile like the current prog_tests/ does. Other existing tests in test_maps can also be re-factored into map_tests/ in the future. Signed-off-by: Martin KaFai Lau

[PATCH v4 bpf-next 1/7] bpf: Introduce bpf sk local storage

2019-04-26 Thread Martin KaFai Lau
After allowing a bpf prog to - directly read the skb->sk ptr - get the fullsock bpf_sock by "bpf_sk_fullsock()" - get the bpf_tcp_sock by "bpf_tcp_sock()" - get the listener sock by "bpf_get_listener_sock()" - avoid duplicating the fields of "(bpf_)sock" and "(bpf_)tcp_sock" into different bpf ru

[PATCH v4 bpf-next 3/7] bpf: Support BPF_MAP_TYPE_SK_STORAGE in bpf map probing

2019-04-26 Thread Martin KaFai Lau
This patch supports probing for the new BPF_MAP_TYPE_SK_STORAGE. BPF_MAP_TYPE_SK_STORAGE enforces BTF usage, so the new probe requires to create and load a BTF also. Signed-off-by: Martin KaFai Lau --- tools/bpf/bpftool/map.c | 1 + tools/lib/bpf/libbpf_probes.c | 74 +

[PATCH v4 bpf-next 2/7] bpf: Sync bpf.h to tools

2019-04-26 Thread Martin KaFai Lau
This patch sync the bpf.h to tools/. Signed-off-by: Martin KaFai Lau --- tools/include/uapi/linux/bpf.h | 44 +- 1 file changed, 43 insertions(+), 1 deletion(-) diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h index 704bb69514a2..be08e

Re: [PATCH mlx5-next 00/11] Mellanox, mlx5-next updates 2019-04-25

2019-04-26 Thread Jakub Kicinski
On Fri, 26 Apr 2019 21:58:02 +, Saeed Mahameed wrote: > Hi, > > This series provides misc low level updates to mlx5 core driver, to be > shared between rdma and net-next trees. > > 1) From Aya: Enable general events on all physical link types and > restrict general event handling of subtype

[PATCH mlx5-next 06/11] net/mlx5: Pass flow steering objects to fs_cmd

2019-04-26 Thread Saeed Mahameed
From: Maor Gottlieb Pass the flow steering objects instead of their attributes to fs_cmd in order to decrease number of arguments and in addition it will be used to update object fields. Pass the flow steering root namespace instead of the device so will have context to the namespace in the fs_cm

[PATCH mlx5-next 10/11] net/mlx5: Geneve, Add basic Geneve encap/decap flow table capabilities

2019-04-26 Thread Saeed Mahameed
From: Yevgeny Kliteynik Introduce support for Geneve flow specification and allow the creation of rules that are matching on basic Geneve protocol fields: VNI, OAM bit, protocol type, options length. Reviewed-by: Oz Shlomo Signed-off-by: Yevgeny Kliteynik Signed-off-by: Saeed Mahameed --- in

[PATCH mlx5-next 09/11] net/mlx5: Eswitch, enable RoCE loopback traffic

2019-04-26 Thread Saeed Mahameed
From: Maor Gottlieb When in switchdev mode, we would like to treat loopback RoCE traffic (on eswitch manager) as RDMA and not as regular Ethernet traffic In order to enable it we add flow steering rule that forward RoCE loopback traffic to the HW RoCE filter (by adding allow rule). In addition we

[PATCH mlx5-next 07/11] net/mlx5: Add support in RDMA RX steering

2019-04-26 Thread Saeed Mahameed
From: Maor Gottlieb Add new flow steering namespace - MLX5_FLOW_NAMESPACE_RDMA_RX. Flow steering rules in this namespace are used to filter RDMA traffic. Signed-off-by: Maor Gottlieb Reviewed-by: Mark Bloch Signed-off-by: Saeed Mahameed --- .../net/ethernet/mellanox/mlx5/core/fs_cmd.c | 1

[PATCH mlx5-next 00/11] Mellanox, mlx5-next updates 2019-04-25

2019-04-26 Thread Saeed Mahameed
Hi, This series provides misc low level updates to mlx5 core driver, to be shared between rdma and net-next trees. 1) From Aya: Enable general events on all physical link types and restrict general event handling of subtype DELAY_DROP_TIMEOUT in mlx5 rdma driver to ethernet links only as it was

[PATCH mlx5-next 11/11] net/mlx5: Geneve, Add flow table capabilities for Geneve decap with TLV options

2019-04-26 Thread Saeed Mahameed
From: Yevgeny Kliteynik Introduce specification for Geneve decap flow with encapsulation options and allow creation of rules that are matching on Geneve TLV options. Reviewed-by: Oz Shlomo Signed-off-by: Yevgeny Kliteynik Signed-off-by: Saeed Mahameed --- .../net/ethernet/mellanox/mlx5/core/

[PATCH mlx5-next 08/11] net/mlx5: Add new miss flow table action

2019-04-26 Thread Saeed Mahameed
From: Maor Gottlieb Flow table supports three types of miss action: 1. Default miss action - go to default miss table according to table. 2. Go to specific table. 3. Switch domain - go to the root table of an alternative steering table domain. New table miss action was added - switch_domain.

[PATCH mlx5-next 01/11] net/mlx5: E-Switch: Introduce prio tag mode

2019-04-26 Thread Saeed Mahameed
From: Eli Britstein Current ConnectX HW is unable to perform VLAN pop in TX path and VLAN push on RX path. To workaround that limitation untagged packets will be tagged with VLAN ID 0x000 (priority tag) and pop/push actions will be replaced by VLAN re-write actions (which are supported by the HW)

[PATCH mlx5-next 04/11] IB/mlx5: Restrict 'DELAY_DROP_TIMEOUT' subtype to Ethernet interfaces

2019-04-26 Thread Saeed Mahameed
From: Aya Levin Subtype 'DELAY_DROP_TIMEOUT' (under 'GENERAL' event) is restricted to Ethernet interfaces. This patch doesn't change functionality or breaks current flow. In the downstream patch, non Ethernet (like IB) interfaces will receive 'GENERAL' event. Fixes: 5d3c537f9070 ("net/mlx5: Hand

[PATCH mlx5-next 03/11] net/mlx5: Separate and generalize dma device from pci device

2019-04-26 Thread Saeed Mahameed
From: Vu Pham The mlx5 Sub-Function (SF) sub device will be introduced in subsequent patches. It will be created as mediated device and belong to mdev bus. It is necessary to treat dma operations on PF, VF and SF in uniform way, hence reduce the dependency on pdev pci dev struct and work directly

[PATCH mlx5-next 05/11] net/mlx5: Enable general events on all interfaces

2019-04-26 Thread Saeed Mahameed
From: Aya Levin Open events of type 'GENERAL' to all types of interfaces. Prior to this patch, 'GENERAL' events were captured only by Ethernet interfaces. Other interface types (non-Ethernet) were excluded and couldn't receive 'GENERAL' events. Fixes: 5d3c537f9070 ("net/mlx5: Handle event of pow

Re: [PATCH net] packet: in recvmsg msg_name return at least sockaddr_ll

2019-04-26 Thread Willem de Bruijn
On Fri, Apr 26, 2019 at 3:29 PM Willem de Bruijn wrote: > > From: Willem de Bruijn > > Packet send checks that msg_name is at least sizeof sockaddr_ll. > Packet recv must return at least this length, so that its output > can be passed unmodified to packet send. > > This ceased to be true since ad

[PATCH mlx5-next 02/11] net/mlx5: Get rid of storing copy of device name

2019-04-26 Thread Saeed Mahameed
From: Parav Pandit Currently mlx5 core stores copy of the PCI device name in a mlx5_priv structure and uses pr_warn, pr_err helpers. Get rid of the copy of this name; instead store the parent device pointer that contains name as well as dma specific parameters. This also allows to use kernel's w

Re: [PATCH v3 net-next 15/15] net: aquantia: remove outdated device ids

2019-04-26 Thread Andrew Lunn
On Fri, Apr 26, 2019 at 09:48:15AM +, Igor Russkikh wrote: > From: Nikita Danilov > > Some device ids were never released and does not exist. > Cleanup these. > > Signed-off-by: Nikita Danilov > Signed-off-by: Igor Russkikh Reviewed-by: Andrew Lunn Andrew

Re: [PATCH v3 bpf-next 5/6] bpf: Add BPF_MAP_TYPE_SK_STORAGE test to test_maps

2019-04-26 Thread Martin Lau
On Fri, Apr 26, 2019 at 11:32:01AM -0700, Yonghong Song wrote: > > > On 4/26/19 10:11 AM, Martin KaFai Lau wrote: > > This patch adds BPF_MAP_TYPE_SK_STORAGE test to test_maps. > > The src file is rather long, so it is put into another dir map_tests/ > > and compile like the current prog_tests/ d

Re: [PATCH v3 net-next 14/15] net: aquantia: fixups on 64bit dma counters

2019-04-26 Thread Andrew Lunn
> + self->curr_stats.dma_pkt_rc = > hw_atl_stats_rx_dma_good_pkt_counterlsw_get(self) + > + > ((u64)hw_atl_stats_rx_dma_good_pkt_countermsw_get(self) << 32); Don't you need to do something to avoid issue with overflow from lsw into msw? I've often seen code

Re: [PATCH 4.9 stable 0/5] net: ip6 defrag: backport fixes

2019-04-26 Thread Peter Oskolkov
On Fri, Apr 26, 2019 at 8:41 AM Peter Oskolkov wrote: > > This is a backport of a 5.1rc patchset: > https://patchwork.ozlabs.org/cover/1029418/ > > Which was backported into 4.19: > https://patchwork.ozlabs.org/cover/1081619/ > > and into 4.14: > https://patchwork.ozlabs.org/cover/1089651/ >

Re: [PATCH v3 bpf-next 6/6] bpf: Add ene-to-end test for bpf_sk_storage_* helpers

2019-04-26 Thread Martin Lau
On Fri, Apr 26, 2019 at 10:55:02AM -0700, Stanislav Fomichev wrote: > On 04/26, Martin KaFai Lau wrote: > > This patch rides on an existing BPF_PROG_TYPE_CGROUP_SKB test > > (test_sock_fields.c) to do a TCP end-to-end test on the new > > bpf_sk_storage_* helpers. > > > > Signed-off-by: Martin KaFa

Re: [PATCH v3 net-next 10/15] net: aquantia: introduce fwreq mutex

2019-04-26 Thread Andrew Lunn
On Fri, Apr 26, 2019 at 09:48:02AM +, Igor Russkikh wrote: > From: Nikita Danilov > > Some of FW operations could be invoked simultaneously, > from f.e. ethtool context and from service service activity work. > Here we introduce a fw mutex to secure and serialize access > to FW logic. > > Si

Re: [PATCH v3 bpf-next 5/6] bpf: Add BPF_MAP_TYPE_SK_STORAGE test to test_maps

2019-04-26 Thread Martin Lau
On Fri, Apr 26, 2019 at 10:54:00AM -0700, Stanislav Fomichev wrote: > On 04/26, Martin KaFai Lau wrote: > > This patch adds BPF_MAP_TYPE_SK_STORAGE test to test_maps. > > The src file is rather long, so it is put into another dir map_tests/ > > and compile like the current prog_tests/ does. Other

Re: [PATCH v3 net-next 09/15] net: aquantia: user correct MSI irq type

2019-04-26 Thread Andrew Lunn
On Fri, Apr 26, 2019 at 09:48:00AM +, Igor Russkikh wrote: > Typo in msi code. No much impact though. > > Signed-off-by: Nikita Danilov > Signed-off-by: Igor Russkikh Reviewed-by: Andrew Lunn Andrew

Re: [PATCH v3 bpf-next 1/6] bpf: Introduce bpf sk local storage

2019-04-26 Thread Martin Lau
On Fri, Apr 26, 2019 at 10:52:20AM -0700, Stanislav Fomichev wrote: > On 04/26, Martin KaFai Lau wrote: > > After allowing a bpf prog to > > - directly read the skb->sk ptr > > - get the fullsock bpf_sock by "bpf_sk_fullsock()" > > - get the bpf_tcp_sock by "bpf_tcp_sock()" > > - get the listener s

Re: [PATCH v3 net-next 08/15] net: aquantia: use macros for better visibility

2019-04-26 Thread Andrew Lunn
On Fri, Apr 26, 2019 at 09:47:57AM +, Igor Russkikh wrote: > Improve for better readability > > Signed-off-by: Nikita Danilov > Signed-off-by: Igor Russkikh Reviewed-by: Andrew Lunn Andrew

Re: [PATCH v3 net-next 06/15] net: aquantia: link status irq handling

2019-04-26 Thread Andrew Lunn
> + if (self->aq_nic_cfg.link_irq_vec) { > + int irqvec = pci_irq_vector(self->pdev, > + > self->aq_nic_cfg.link_irq_vec); > + err = request_threaded_irq(irqvec, NULL, > +

Re: [PATCH v3 net-next 05/15] net: aquantia: create global service workqueue

2019-04-26 Thread Andrew Lunn
On Fri, Apr 26, 2019 at 09:47:50AM +, Igor Russkikh wrote: > From: Nikita Danilov > > We need this to schedule link interrupt handling and > various service tasks. > > Signed-off-by: Nikita Danilov > Signed-off-by: Igor Russkikh Reviewed-by: Andrew Lunn Andrew

Re: [PATCH v3 net-next 04/15] net: aquantia: link interrupt handling function

2019-04-26 Thread Andrew Lunn
On Fri, Apr 26, 2019 at 09:47:47AM +, Igor Russkikh wrote: > Define link interrupt handler > > Signed-off-by: Nikita Danilov > Signed-off-by: Igor Russkikh > --- > drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/drive

Re: [PATCH iproute2-next] Update tc-bpf.8 man page examples

2019-04-26 Thread David Ahern
On 4/26/19 2:34 PM, Daniel Borkmann wrote: > On 04/26/2019 07:40 PM, David Ahern wrote: >> On 4/20/19 1:06 PM, Lucas Siba wrote: >>> From: Lucas Siba @ 2019-04-20 11:40 UTC >>> To: netdev >>> >>> This patch updates the tc-bpf.8 example application for changes to the >>> struct bpf_elf_map definitio

Re: [PATCH v3 net-next 02/15] net: aquantia: implement hwmon api for chip temperature

2019-04-26 Thread Andrew Lunn
> +void aq_drvinfo_exit(struct net_device *ndev) > +{ > +} Nit: I don't think any of the other patches add anything to this. So i suggest killing it. Reviewed-by: Andrew Lunn Andrew

Re: [PATCH v3 net-next 03/15] net: aquantia: add link interrupt fields

2019-04-26 Thread Andrew Lunn
On Fri, Apr 26, 2019 at 09:47:44AM +, Igor Russkikh wrote: > Declare macroes and nic fields to support link interrupt > handling > > Signed-off-by: Nikita Danilov > Signed-off-by: Igor Russkikh Reviewed-by: Andrew Lunn Andrew

Re: [PATCH v3 net-next 01/15] net: aquantia: add infrastructure to readout chip temperature

2019-04-26 Thread Andrew Lunn
On Fri, Apr 26, 2019 at 09:47:39AM +, Igor Russkikh wrote: > From: Yana Esina > > Ability to read the chip temperature from memory > via hwmon interface > > Signed-off-by: Yana Esina > Signed-off-by: Nikita Danilov > Signed-off-by: Igor Russkikh Reviewed-by: Andrew Lunn Andrew

Re: [PATCH iproute2-next] Update tc-bpf.8 man page examples

2019-04-26 Thread Daniel Borkmann
On 04/26/2019 07:40 PM, David Ahern wrote: > On 4/20/19 1:06 PM, Lucas Siba wrote: >> From: Lucas Siba @ 2019-04-20 11:40 UTC >> To: netdev >> >> This patch updates the tc-bpf.8 example application for changes to the >> struct bpf_elf_map definition. In it's current form, things compile, but >> the

Re: [PATCH net-next 5/6] xsk: Change the default frame size to 4096 and allow controlling it

2019-04-26 Thread Björn Töpel
On 2019-04-26 13:42, Maxim Mikityanskiy wrote: The typical XDP memory scheme is one packet per page. Change the AF_XDP frame size in libbpf to 4096, which is the page size on x86, to allow libbpf to be used with the drivers with the packet-per-page scheme. Add a command line option -f to xdpsock

Re: [PATCH net-next 4/6] xsk: Extend channels to support combined XSK/non-XSK traffic

2019-04-26 Thread Björn Töpel
On 2019-04-26 13:42, Maxim Mikityanskiy wrote: Currently, the drivers that implement AF_XDP zero-copy support (e.g., i40e) switch the channel into a different mode when an XSK is opened. It causes some issues that have to be taken into account. For example, RSS needs to be reconfigured to skip th

Re: [PATCH net-next 3/6] xsk: Add getsockopt XDP_OPTIONS

2019-04-26 Thread Björn Töpel
On 2019-04-26 13:42, Maxim Mikityanskiy wrote: Make it possible for the application to determine whether the AF_XDP socket is running in zero-copy mode. To achieve this, add a new getsockopt option XDP_OPTIONS that returns flags. The only flag supported for now is the zero-copy mode indicator. A

Re: [PATCH net-next 0/6] AF_XDP infrastructure improvements

2019-04-26 Thread Björn Töpel
On 2019-04-26 13:42, Maxim Mikityanskiy wrote: This series contains improvements to the AF_XDP kernel infrastructure. They are required for the upcoming AF_XDP support in mlx5e, but also some of them benefit to all drivers, and some can be useful for other drivers that want to implement AF_XDP. ,

[PATCH v2 2/5] isdn: remove hisax driver

2019-04-26 Thread Arnd Bergmann
With the decline of ISDN, this seems to have become almost completely obsolete, and even in the past years before that, almost all remaining users appear to have used mISDN instead. Birger Harzenetter noted that he is still using i4l/hisax to take advantage of the 'divert' driver for call diversio

[PATCH v2 1/5] isdn: gigaset: remove i4l support

2019-04-26 Thread Arnd Bergmann
isdn4linux is getting removed, and the gigaset driver can still use the CAPI support, so this can all go away. Signed-off-by: Arnd Bergmann --- Documentation/isdn/README.gigaset | 36 +- drivers/isdn/gigaset/Kconfig | 9 - drivers/isdn/gigaset/Makefile | 10 +- drivers/isdn/gigaset/

[PATCH v2 0/5] isdn: deprecate non-mISDN drivers

2019-04-26 Thread Arnd Bergmann
When isdn4linux came up in the context of another patch series, I remembered that we had discussed removing it a while ago. It turns out that the suggestion from Karsten Keil wa to remove I4L in 2018 after the last public ISDN networks are shut down. This has happened now (with a very small number

[PATCH v2 3/5] isdn: remove isdn4linux

2019-04-26 Thread Arnd Bergmann
With all isdn4linux hardware drivers gone, this is only a wrapper around CAPI to support old user space. However, from looking at the mailing list, it seems that the last time anyone asked about it was in 2014, when the upgrade from a linux-2.4 installation failed, and mISDN was suggested as a repl

[PATCH v2 5/5] isdn: move capi drivers to staging

2019-04-26 Thread Arnd Bergmann
I tried to find any indication of whether the capi drivers are still in use, and have not found anything from a long time ago. With public ISDN networks almost completely shut down over the past 12 months, there is very little you can actually do with this hardware. The main remaining use case wou

[PATCH v2 4/5] isdn: hdlc: move into mISDN

2019-04-26 Thread Arnd Bergmann
The last remnant of the isdn4linux interface is now the isdnhdlc support, used by the netjet driver. Move it next to that driver. Signed-off-by: Arnd Bergmann --- drivers/isdn/Makefile | 1 - drivers/isdn/hardware/mISDN/Kconfig| 7

[PATCH bpf-next 0/2] Two arm64 bpf jit improvements

2019-04-26 Thread Daniel Borkmann
This set holds two arm64 bpf jit improvements for xadd. Thanks! Daniel Borkmann (2): bpf, arm64: remove prefetch insn in xadd mapping bpf, arm64: use more scalable stadd over ldxr / stxr loop in xadd arch/arm64/include/asm/insn.h | 8 arch/arm64/kernel/insn.c | 40

[PATCH bpf-next 1/2] bpf, arm64: remove prefetch insn in xadd mapping

2019-04-26 Thread Daniel Borkmann
Prefetch-with-intent-to-write is currently part of the XADD mapping in the AArch64 JIT and follows the kernel's implementation of atomic_add. This may interfere with other threads executing the LDXR/STXR loop, leading to potential starvation and fairness issues. Drop the optional prefetch instructi

[PATCH bpf-next 2/2] bpf, arm64: use more scalable stadd over ldxr / stxr loop in xadd

2019-04-26 Thread Daniel Borkmann
Since ARMv8.1 supplement introduced LSE atomic instructions back in 2016, lets add support for STADD and use that in favor of LDXR / STXR loop for the XADD mapping if available. STADD is encoded as an alias for LDADD with XZR as the destination register, therefore add LDADD to the instruction encod

Re: [PATCH net] packet: validate address length if non-zero

2019-04-26 Thread Willem de Bruijn
On Fri, Apr 26, 2019 at 11:14 AM David Laight wrote: > > From: Willem de Bruijn > > Sent: 26 April 2019 16:11 > > On Thu, Apr 25, 2019 at 11:42 AM Willem de Bruijn > > wrote: > > > > > > On Thu, Apr 25, 2019 at 10:35 AM David Laight > > > wrote: > > > > > > > > From: Willem de Bruijn > > > > >

[PATCH net] packet: in recvmsg msg_name return at least sockaddr_ll

2019-04-26 Thread Willem de Bruijn
From: Willem de Bruijn Packet send checks that msg_name is at least sizeof sockaddr_ll. Packet recv must return at least this length, so that its output can be passed unmodified to packet send. This ceased to be true since adding support for lladdr longer than sll_addr. Since, the return value u

Re: [PATCH 4.14 stable v2 1/5] ipv6: frags: fix a lockdep false positive

2019-04-26 Thread Captain Wiggum
Sorry for the late reply. I am starting the TAHI test on the 4.14 v2 patch today and reply with results before Mon morning. The test is long running so we let it run overnight. On Tue, Apr 23, 2019 at 11:48 AM Peter Oskolkov wrote: > > From: Eric Dumazet > > [ Upstream commit 415787d7799f4fccbe8

[PATCH net] packet: validate msg_namelen in send directly

2019-04-26 Thread Willem de Bruijn
From: Willem de Bruijn Packet sockets in datagram mode take a destination address. Verify its length before passing to dev_hard_header. Prior to 2.6.14-rc3, the send code ignored sll_halen. This is established behavior. Directly compare msg_namelen to dev->addr_len. Fixes: 6b8d95f1795c4 ("packe

Re: [PATCH 6/6] netlink: add infrastructure to expose policies to userspace

2019-04-26 Thread Johannes Berg
On Fri, 2019-04-26 at 20:21 +0200, Pablo Neira Ayuso wrote: > On Fri, Apr 26, 2019 at 02:13:06PM +0200, Johannes Berg wrote: > > diff --git a/include/uapi/linux/genetlink.h b/include/uapi/linux/genetlink.h > > index 877f7fa95466..9c0636ec2286 100644 > > --- a/include/uapi/linux/genetlink.h > > +++

Re: [PATCH net-next 4/6] xsk: Extend channels to support combined XSK/non-XSK traffic

2019-04-26 Thread Jakub Kicinski
On Fri, 26 Apr 2019 11:42:37 +, Maxim Mikityanskiy wrote: > Currently, the drivers that implement AF_XDP zero-copy support (e.g., > i40e) switch the channel into a different mode when an XSK is opened. It > causes some issues that have to be taken into account. For example, RSS > needs to be re

Re: [PATCH v3 net-next 12/15] net: aquantia: fetch up to date statistics on ethtool request

2019-04-26 Thread Jakub Kicinski
On Fri, 26 Apr 2019 09:48:07 +, Igor Russkikh wrote: > From: Dmitry Bogdanov > > This improves ethtool -S usage, where stats are now actual > on each request. Before that stats only were updated at service > timer period. > > Tested-by: Nikita Danilov > Signed-off-by: Igor Russkikh > Signe

[PATCH bpf-next v5 1/5] bpf: add writable context for raw tracepoints

2019-04-26 Thread Matt Mullins
This is an opt-in interface that allows a tracepoint to provide a safe buffer that can be written from a BPF_PROG_TYPE_RAW_TRACEPOINT program. The size of the buffer must be a compile-time constant, and is checked before allowing a BPF program to attach to a tracepoint that uses this feature. The

Re: [PATCH v3 bpf-next 3/6] bpf: Support BPF_MAP_TYPE_SK_STORAGE in bpf map probing

2019-04-26 Thread Yonghong Song
On 4/26/19 11:21 AM, Martin Lau wrote: > On Fri, Apr 26, 2019 at 10:50:29AM -0700, Yonghong Song wrote: >> >> >> On 4/26/19 10:11 AM, Martin KaFai Lau wrote: >>> This patch supports probing for the new BPF_MAP_TYPE_SK_STORAGE. >>> BPF_MAP_TYPE_SK_STORAGE enforces BTF usage, so the new probe >>> r

Re: TC stats / hw offload question

2019-04-26 Thread Pablo Neira Ayuso
On Fri, Apr 26, 2019 at 01:13:41PM +0100, Edward Cree wrote: > On 25/04/2019 23:33, Pablo Neira Ayuso wrote: > > On Thu, Apr 25, 2019 at 02:23:08PM +0100, Edward Cree wrote: > >> On 24/04/2019 16:03, Edward Cree wrote: > >>> static int efx_tc_flower_replace(struct efx_nic *efx, > >>>               

Re: [PATCH v2 bpf-next 1/6] bpf: Introduce bpf sk local storage

2019-04-26 Thread Yonghong Song
On 4/26/19 11:04 AM, Martin Lau wrote: > On Fri, Apr 26, 2019 at 10:27:16AM -0700, Yonghong Song wrote: >> >> >> On 4/25/19 5:10 PM, Martin KaFai Lau wrote: >>> After allowing a bpf prog to >>> - directly read the skb->sk ptr >>> - get the fullsock bpf_sock by "bpf_sk_fullsock()" >>> - get the bp

Re: [PATCH v3 bpf-next 5/6] bpf: Add BPF_MAP_TYPE_SK_STORAGE test to test_maps

2019-04-26 Thread Yonghong Song
On 4/26/19 10:11 AM, Martin KaFai Lau wrote: > This patch adds BPF_MAP_TYPE_SK_STORAGE test to test_maps. > The src file is rather long, so it is put into another dir map_tests/ > and compile like the current prog_tests/ does. Other existing > tests in test_maps can also be re-factored into map_

Re: [PATCH v3 bpf-next 3/6] bpf: Support BPF_MAP_TYPE_SK_STORAGE in bpf map probing

2019-04-26 Thread Martin Lau
On Fri, Apr 26, 2019 at 10:50:29AM -0700, Yonghong Song wrote: > > > On 4/26/19 10:11 AM, Martin KaFai Lau wrote: > > This patch supports probing for the new BPF_MAP_TYPE_SK_STORAGE. > > BPF_MAP_TYPE_SK_STORAGE enforces BTF usage, so the new probe > > requires to create and load a BTF also. > >

Re: [PATCH 6/6] netlink: add infrastructure to expose policies to userspace

2019-04-26 Thread Pablo Neira Ayuso
On Fri, Apr 26, 2019 at 02:13:06PM +0200, Johannes Berg wrote: > diff --git a/include/uapi/linux/genetlink.h b/include/uapi/linux/genetlink.h > index 877f7fa95466..9c0636ec2286 100644 > --- a/include/uapi/linux/genetlink.h > +++ b/include/uapi/linux/genetlink.h > @@ -48,6 +48,7 @@ enum { > CT

Re: [PATCH iproute2-next] iplink_vlan: add support for VLAN bridge binding flag

2019-04-26 Thread David Ahern
On 4/20/19 4:45 AM, Mike Manning wrote: > This patch adds support for the VLAN bridge binding flag that is > provided in net-next kernel by the series merged by 1ab839281cf7 > ("net-support-binding-vlan-dev-link-state-to-vlan-member-bridge-ports") > > Signed-off-by: Mike Manning > --- > include/

Re: [PATCH v3 bpf-next 4/6] bpf: Add verifier tests for the bpf_sk_storage

2019-04-26 Thread Yonghong Song
On 4/26/19 10:11 AM, Martin KaFai Lau wrote: > This patch adds verifier tests for the bpf_sk_storage: > 1. ARG_PTR_TO_MAP_VALUE_OR_NULL > 2. Map and helper compatibility (e.g. disallow bpf_map_loookup_elem) > > It also takes this chance to remove the unused struct btf_raw_data. > > Signed-off-b

Re: [PATCH v2 bpf-next 1/6] bpf: Introduce bpf sk local storage

2019-04-26 Thread Martin Lau
On Fri, Apr 26, 2019 at 10:27:16AM -0700, Yonghong Song wrote: > > > On 4/25/19 5:10 PM, Martin KaFai Lau wrote: > > After allowing a bpf prog to > > - directly read the skb->sk ptr > > - get the fullsock bpf_sock by "bpf_sk_fullsock()" > > - get the bpf_tcp_sock by "bpf_tcp_sock()" > > - get the

Re: [PATCH v3 bpf-next 6/6] bpf: Add ene-to-end test for bpf_sk_storage_* helpers

2019-04-26 Thread Stanislav Fomichev
On 04/26, Martin KaFai Lau wrote: > This patch rides on an existing BPF_PROG_TYPE_CGROUP_SKB test > (test_sock_fields.c) to do a TCP end-to-end test on the new > bpf_sk_storage_* helpers. > > Signed-off-by: Martin KaFai Lau > --- > tools/testing/selftests/bpf/bpf_helpers.h | 5 + > .../bpf

Re: [PATCH v3 bpf-next 5/6] bpf: Add BPF_MAP_TYPE_SK_STORAGE test to test_maps

2019-04-26 Thread Stanislav Fomichev
On 04/26, Martin KaFai Lau wrote: > This patch adds BPF_MAP_TYPE_SK_STORAGE test to test_maps. > The src file is rather long, so it is put into another dir map_tests/ > and compile like the current prog_tests/ does. Other existing > tests in test_maps can also be re-factored into map_tests/ in the

Re: [PATCH v3 bpf-next 1/6] bpf: Introduce bpf sk local storage

2019-04-26 Thread Stanislav Fomichev
On 04/26, Martin KaFai Lau wrote: > After allowing a bpf prog to > - directly read the skb->sk ptr > - get the fullsock bpf_sock by "bpf_sk_fullsock()" > - get the bpf_tcp_sock by "bpf_tcp_sock()" > - get the listener sock by "bpf_get_listener_sock()" > - avoid duplicating the fields of "(bpf_)sock

Re: [PATCH v3 bpf-next 3/6] bpf: Support BPF_MAP_TYPE_SK_STORAGE in bpf map probing

2019-04-26 Thread Yonghong Song
On 4/26/19 10:11 AM, Martin KaFai Lau wrote: > This patch supports probing for the new BPF_MAP_TYPE_SK_STORAGE. > BPF_MAP_TYPE_SK_STORAGE enforces BTF usage, so the new probe > requires to create and load a BTF also. > > Signed-off-by: Martin KaFai Lau > --- > tools/bpf/bpftool/map.c |

Re: [PATCH iproute2-next] Update tc-bpf.8 man page examples

2019-04-26 Thread David Ahern
On 4/20/19 1:06 PM, Lucas Siba wrote: > From: Lucas Siba @ 2019-04-20 11:40 UTC > To: netdev > > This patch updates the tc-bpf.8 example application for changes to the > struct bpf_elf_map definition. In it's current form, things compile, but > the resulting object file is rejected by the verifier

Re: [PATCH v2 bpf-next 1/6] bpf: Introduce bpf sk local storage

2019-04-26 Thread Yonghong Song
On 4/25/19 5:10 PM, Martin KaFai Lau wrote: > After allowing a bpf prog to > - directly read the skb->sk ptr > - get the fullsock bpf_sock by "bpf_sk_fullsock()" > - get the bpf_tcp_sock by "bpf_tcp_sock()" > - get the listener sock by "bpf_get_listener_sock()" > - avoid duplicating the fields of

[PATCH v3 bpf-next 3/6] bpf: Support BPF_MAP_TYPE_SK_STORAGE in bpf map probing

2019-04-26 Thread Martin KaFai Lau
This patch supports probing for the new BPF_MAP_TYPE_SK_STORAGE. BPF_MAP_TYPE_SK_STORAGE enforces BTF usage, so the new probe requires to create and load a BTF also. Signed-off-by: Martin KaFai Lau --- tools/bpf/bpftool/map.c | 1 + tools/lib/bpf/libbpf_probes.c | 74 +

[PATCH v3 bpf-next 1/6] bpf: Introduce bpf sk local storage

2019-04-26 Thread Martin KaFai Lau
After allowing a bpf prog to - directly read the skb->sk ptr - get the fullsock bpf_sock by "bpf_sk_fullsock()" - get the bpf_tcp_sock by "bpf_tcp_sock()" - get the listener sock by "bpf_get_listener_sock()" - avoid duplicating the fields of "(bpf_)sock" and "(bpf_)tcp_sock" into different bpf ru

[PATCH v3 bpf-next 5/6] bpf: Add BPF_MAP_TYPE_SK_STORAGE test to test_maps

2019-04-26 Thread Martin KaFai Lau
This patch adds BPF_MAP_TYPE_SK_STORAGE test to test_maps. The src file is rather long, so it is put into another dir map_tests/ and compile like the current prog_tests/ does. Other existing tests in test_maps can also be re-factored into map_tests/ in the future. Signed-off-by: Martin KaFai Lau

[PATCH v3 bpf-next 0/6] BPF sk local storage

2019-04-26 Thread Martin KaFai Lau
v3: - Replace spinlock_types.h with spinlock.h in patch 1 (kbuild test robot ) v2: - Add the "test_maps.h" file in patch 5 This series introduces the BPF sk local storage. The details is in the patch 1 commit message. Martin KaFai Lau (6): bpf: Introduce bpf sk local storage bpf: Sync bpf

  1   2   >