[PATCH net] ipv4: Add ICMPv6 support when parse route ipproto

2019-02-24 Thread Hangbin Liu
For ip rules, we need to use 'ipproto ipv6-icmp' to match ICMPv6 headers. But for ip -6 route, currently we only support tcp, udp and icmp. Add ICMPv6 support so we can match ipv6-icmp rules for route lookup. Reported-by: Jianlin Shi Fixes: eacb9384a3fe ("ipv6: support sport, dport and ip_proto

Re: [PATCH net-next v2 2/2] net: phy: aquantia: add hwmon support

2019-02-24 Thread Heiner Kallweit
On 25.02.2019 03:17, Florian Fainelli wrote: > Le 2/24/19 à 1:36 PM, Heiner Kallweit a écrit : >> This adds HWMON support for the temperature sensor and the related >> alarms on the 107/108/109 chips. This patch is based on work from >> Nikita and Andrew. I added: >> - support for changing alarm th

[PATCH v2] net: dsa: fix a leaked reference by adding missing of_node_put

2019-02-24 Thread Wen Yang
The call to of_parse_phandle returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings: ./net/dsa/port.c:294:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on

RE: [PATCH 0/3] soc: fsl: dpio: enable and configure cache stashing

2019-02-24 Thread Ioana Ciornei
> Subject: Re: [PATCH 0/3] soc: fsl: dpio: enable and configure cache stashing > > From: Ioana Ciornei > Date: Sat, 23 Feb 2019 08:48:42 + > > > The first two patches enable cache stashing and configure the core > > cluster destination per software portal while the third patch is the > > one

[PATCH mlx5-next] net/mlx5: ODP support for XRC transport is not enabled by default in FW

2019-02-24 Thread Leon Romanovsky
From: Moni Shoua ODP support for XRC transport is not enabled by default in FW, so we need separate ODP checks to enable/disable it. While that, rewrite the set of ODP SRQ support capabilities in way that tests each field separately for clearness, which is not needed for current FW, but better t

Re: [PATCH net-next] switchdev: Complete removal of switchdev_port_attr_get()

2019-02-24 Thread David Miller
From: Florian Fainelli Date: Sun, 24 Feb 2019 18:39:02 -0800 > We have no more in tree users of switchdev_port_attr_get() after > d0e698d57a94 ("Merge branch 'net-Get-rid-of-switchdev_port_attr_get'") > so completely remove the function signature and body. > > Signed-off-by: Florian Fainelli A

Re: [PATCH net-next] dsa: Remove phydev parameter from disable_port call

2019-02-24 Thread David Miller
From: Andrew Lunn Date: Sun, 24 Feb 2019 20:44:43 +0100 > No current DSA driver makes use of the phydev parameter passed to the > disable_port call. Remove it. > > Signed-off-by: Andrew Lunn Applied to net-next, with some fuzz...

Re: [PATCH net] net: phy: fix reading fixed phy status

2019-02-24 Thread David Miller
From: Heiner Kallweit Date: Sun, 24 Feb 2019 18:01:18 +0100 > With the switch to phy_resolve_aneg_linkmode() we don't read from the > chip any longer what is advertised but use phydev->advertising directly. > For a fixed phy however this bitmap is empty so far, what results in > no common mode be

Re: [PATCH net-next] net: phy: improve auto-neg emulation in swphy

2019-02-24 Thread David Miller
From: Heiner Kallweit Date: Sun, 24 Feb 2019 17:41:47 +0100 > Auto-neg emulation currently doesn't set bit BMCR_ANENABLE in BMCR, > add this. Users will ignore speed and duplex settings in BMCR because > we're emulating auto-neg, therefore we can remove related code. > See also following discussi

Re: pull request: bluetooth-next 2019-02-24

2019-02-24 Thread David Miller
From: Johan Hedberg Date: Sun, 24 Feb 2019 10:36:34 +0200 > Here's the main bluetooth-next pull request for the 5.1 kernel. > > - Fixes & improvements to mediatek, hci_qca, btrtl, and btmrvl HCI drivers > - Fixes to parsing invalid L2CAP config option sizes > - Locking fix to bt_accept_enqueu

Re: [PATCH] ip_tunnel: Add ip tunnel tunnel_info dst_cache in ip_tunnel_xmit

2019-02-24 Thread Dan Carpenter
Hi wenxu, Thank you for the patch! Perhaps something to improve: url: https://github.com/0day-ci/linux/commits/wenxu-ucloud-cn/ip_tunnel-Add-ip-tunnel-tunnel_info-dst_cache-in-ip_tunnel_xmit/20190224-065214 smatch warnings: net/ipv4/ip_tunnel.c:734 ip_tunnel_xmit() error: uninitialized

Re: [PATCH net-next v3] ip_tunnel: Add ip tunnel tun_info type dst_cache in ip_tunnel_xmit

2019-02-24 Thread David Miller
From: we...@ucloud.cn Date: Sun, 24 Feb 2019 08:24:45 +0800 > From: wenxu > > ip l add dev tun type gretap key 1000 > > Non-tunnel-dst ip tunnel device can send packet through lwtunnel > This patch provide the tun_inf dst cache support for this mode. > > Signed-off-by: wenxu Applied.

Re: [PATCH net-next] net: fix double-free in bpf_lwt_xmit_reroute

2019-02-24 Thread David Miller
From: Peter Oskolkov Date: Sat, 23 Feb 2019 18:25:01 -0800 > dst_output() frees skb when it fails (see, for example, > ip_finish_output2), so it must not be freed in this case. > > Fixes: 3bd0b15281af ("bpf: add handling of BPF_LWT_REROUTE to lwt_bpf.c") > Signed-off-by: Peter Oskolkov Applied

Re: [PATCH net-next 0/2] mv88e6xxx: Avoid false positive Lockdep splats

2019-02-24 Thread David Miller
From: Andrew Lunn Date: Sat, 23 Feb 2019 17:43:55 +0100 > When acquiring the GPIO interrupt line for the switch, it is possible > to trigger lockdep splats. These are false positives, the mutex is in > a different IRQ descriptor. But fix it anyway, since it could mask > real locking issues. Seri

[PATCH v3 1/2] dt-bindings: net: Add bindings for mdio mux consumers

2019-02-24 Thread Pankaj Bansal
When we use the bindings defined in Documentation/devicetree/bindings/mux to define mdio mux in producer and consumer terms, it results in two devices. one is mux producer and other is mux consumer. Add the bindings needed for Mdio mux consumer devices. Signed-off-by: Pankaj Bansal --- Notes:

[PATCH v3 2/2] drivers: net: phy: mdio-mux: Add support for Generic Mux controls

2019-02-24 Thread Pankaj Bansal
Add support for Generic Mux controls, when Mdio mux node is a consumer of mux produced by some other device. Signed-off-by: Pankaj Bansal --- Notes: V3: - Avoid recast from platform_get_drvdata - Check mux_control_deselect output in switch_fn - rearrange swithc_fn code to reduce

Re: [PATCH net-next v4] ip_tunnel: Add dst_cache support in lwtunnel_state of ip tunnel

2019-02-24 Thread David Miller
From: we...@ucloud.cn Date: Sat, 23 Feb 2019 21:32:54 +0800 > From: wenxu > > The lwtunnel_state is not init the dst_cache Which make the > ip_md_tunnel_xmit can't use the dst_cache. It will lookup > route table every packets. > > Signed-off-by: wenxu Applied.

Re: [PATCH] tun: fix blocking read

2019-02-24 Thread David Miller
From: Timur Celik Date: Sat, 23 Feb 2019 12:53:13 +0100 > This patch moves setting of the current state into the loop. Otherwise > the task may end up in a busy wait loop if none of the break conditions > are met. > > Signed-off-by: Timur Celik Applied and queued up for -stable, thanks.

Re: [Patch net-next 00/12] code optimizations & bugfixes for HNS3 driver

2019-02-24 Thread David Miller
From: Huazhong Tan Date: Sat, 23 Feb 2019 17:22:07 +0800 > This patchset includes bugfixes and code optimizations for > the HNS3 ethernet controller driver. Series applied, thanks.

Re: [PATCH 0/3] soc: fsl: dpio: enable and configure cache stashing

2019-02-24 Thread David Miller
From: Ioana Ciornei Date: Sat, 23 Feb 2019 08:48:42 + > The first two patches enable cache stashing and configure the core cluster > destination per software portal while the third patch is the one > configuring the amount of stashing on a queue. Should I merge this series in via my networki

RE: [PATCHv3 net-next] tls: Return type of non-data records retrieved using MSG_PEEK in recvmsg

2019-02-24 Thread Vakul Garg
> -Original Message- > From: netdev-ow...@vger.kernel.org On > Behalf Of David Miller > Sent: Monday, February 25, 2019 11:29 AM > To: Vakul Garg > Cc: netdev@vger.kernel.org; bor...@mellanox.com; > avia...@mellanox.com; davejwat...@fb.com; doro...@fb.com > Subject: Re: [PATCHv3 net-ne

Re: [PATCHv3 net-next] tls: Return type of non-data records retrieved using MSG_PEEK in recvmsg

2019-02-24 Thread David Miller
From: Vakul Garg Date: Sat, 23 Feb 2019 08:42:37 + > The patch enables returning 'type' in msghdr for records that are > retrieved with MSG_PEEK in recvmsg. Further it prevents records peeked > from socket from getting clubbed with any other record of different > type when records are subsequ

Re: [PATCH net-next v2 0/3] ipv4/v6: icmp: small cleanup and update

2019-02-24 Thread David Miller
From: Kefeng Wang Date: Sat, 23 Feb 2019 15:28:25 +0800 > v2: > - Add cover letter and user proper patch subject-prefix suggested-by Eric > Dumazet > > This patch series contains some small cleanup and update, > 1) use icmp/v6_sk_exit when icmp_sk_init fails instead of open-code > 2) use new pe

Re: [PATCH] ila: Fix uninitialised return value in ila_xlat_nl_cmd_flush

2019-02-24 Thread David Miller
From: Herbert Xu Date: Sat, 23 Feb 2019 13:30:47 +0800 > This patch fixes an uninitialised return value error in > ila_xlat_nl_cmd_flush. > > Reported-by: Dan Carpenter > Fixes: 6c4128f65857 ("rhashtable: Remove obsolete...") > Signed-off-by: Herbert Xu Applied, thanks Herbert.

Re: [PATCH net-next] net/sched: act_tunnel_key: Add dst_cache support

2019-02-24 Thread David Miller
From: we...@ucloud.cn Date: Fri, 22 Feb 2019 15:58:12 +0800 > From: wenxu > > The metadata_dst is not init the dst_cache which make the > ip_md_tunnel_xmit can't use the dst_cache. It will lookup > route table every packets. > > Signed-off-by: wenxu Applied.

Re: [PATCH net-next 00/15] mlxsw: spectrum_acl: Don't take rtnl mutex for region rehash

2019-02-24 Thread David Miller
From: Ido Schimmel Date: Sun, 24 Feb 2019 06:46:21 + > Jiri says: > > During region rehash, a new region is created with a more optimized set > of masks (ERPs). When transitioning to the new region, all the rules > from the old region are copied one-by-one to the new region. This > transitio

Re: [PATCH net] sit: use ipv6_mod_enabled to check if ipv6 is disabled

2019-02-24 Thread Eric Dumazet
On 02/24/2019 08:12 PM, Hangbin Liu wrote: > ipv6_mod_enabled() is more safe and gentle to check if ipv6 is disabled > at running time. > Why is it better exactly ? IPv6 can be enabled on the host, but disabled per device /proc/sys/net/ipv6/conf/{name}/disable_ipv6 > Fixes: 173656accaf5 (

Re: [PATCH net-next v2 0/7] net: phy: marvell10g: Add 2.5GBaseT support

2019-02-24 Thread David Miller
From: Maxime Chevallier Date: Sat, 23 Feb 2019 00:37:37 +0100 > This series adds the missing bits necessary to fully support 2.5GBaseT > in the Marvell Alaska PHYs. > > The main points for that support are : > > - Making use of the .get_features call, recently introduced by Heiner >and And

Re: [PATCH v4 net-next 0/4] net: dsa: microchip: add MIB counters support

2019-02-24 Thread David Miller
From: Date: Fri, 22 Feb 2019 16:36:46 -0800 > This series of patches is to modify the KSZ9477 DSA driver to read MIB > counters periodically to avoid overflow. Series applied.

[PATCH net] geneve: use ipv6_mod_enabled to check if ipv6 is disabled

2019-02-24 Thread Hangbin Liu
ipv6_mod_enabled() is more safe and gentle to check if ipv6 is disabled at running time. Fixes: c0a47e44c098 ("geneve: should not call rt6_lookup() when ipv6 was disabled") Signed-off-by: Hangbin Liu --- drivers/net/geneve.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dr

[PATCH net] sit: use ipv6_mod_enabled to check if ipv6 is disabled

2019-02-24 Thread Hangbin Liu
ipv6_mod_enabled() is more safe and gentle to check if ipv6 is disabled at running time. Fixes: 173656accaf5 ("sit: check if IPv6 enabled before calling ip6_err_gen_icmpv6_unreach()") Signed-off-by: Hangbin Liu --- net/ipv6/sit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH net-next v2 2/2] net: phy: aquantia: add hwmon support

2019-02-24 Thread Andrew Lunn
On Sun, Feb 24, 2019 at 06:17:49PM -0800, Florian Fainelli wrote: > Le 2/24/19 à 1:36 PM, Heiner Kallweit a écrit : > > This adds HWMON support for the temperature sensor and the related > > alarms on the 107/108/109 chips. This patch is based on work from > > Nikita and Andrew. I added: > > - supp

[net v3 1/1] tipc: fix race condition causing hung sendto

2019-02-24 Thread Tung Nguyen
When sending multicast messages via blocking socket, if sending link is congested (tsk->cong_link_cnt is set to 1), the sending thread will be put into sleeping state. However, tipc_sk_filter_rcv() is called under socket spin lock but tipc_wait_for_cond() is not. So, there is no guarantee that the

[RFC] nasty corner case in unix_dgram_sendmsg()

2019-02-24 Thread Al Viro
Consider the following scenario: sendmsg() with explicit ->msg_name on unconnected SOCK_DGRAM AF_UNIX socket finds the recepient just about to die. We go through sk_locked = 0; unix_state_lock(other); restart_locked: err = -EPERM; if (!unix_may_send(sk, othe

[PATCH] ath9k: remove set but not used variable 'acq'

2019-02-24 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/wireless/ath/ath9k/recv.c: In function 'ath_rx_count_airtime': drivers/net/wireless/ath/ath9k/recv.c:1010:18: warning: variable 'acq' set but not used [-Wunused-but-set-variable] It's not used after 89cea7493a34 ("ath9k: Switch to mac802

[PATCH][net-next] net: Use RCU_POINTER_INITIALIZER() to init static variable

2019-02-24 Thread Li RongQing
This pointer is RCU protected, so proper primitives should be used. Signed-off-by: Zhang Yu Signed-off-by: Li RongQing --- net/sched/sch_generic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c index 38e5add14fab..7bcee8b8f8

[PATCH net-next] switchdev: Complete removal of switchdev_port_attr_get()

2019-02-24 Thread Florian Fainelli
We have no more in tree users of switchdev_port_attr_get() after d0e698d57a94 ("Merge branch 'net-Get-rid-of-switchdev_port_attr_get'") so completely remove the function signature and body. Signed-off-by: Florian Fainelli --- include/net/switchdev.h | 4 net/switchdev/switchdev.c | 42 --

Re: [PATCH 1/3] net: ethernet: add support for PCS and 2.5G speed

2019-02-24 Thread Florian Fainelli
Le 2/22/19 à 12:12 PM, Parshuram Thombare a écrit : > This patch add support for PCS (for SGMII interface) and 2.5Gbps MAC > in Cadence ethernet controller driver. At a high level you don't seem to be making use of PHYLINK so which 2.5Gbps interfaces do you actually support? > > Signed-off-by: P

Re: [PATCH net-next v2 2/2] net: phy: aquantia: add hwmon support

2019-02-24 Thread Florian Fainelli
Le 2/24/19 à 1:36 PM, Heiner Kallweit a écrit : > This adds HWMON support for the temperature sensor and the related > alarms on the 107/108/109 chips. This patch is based on work from > Nikita and Andrew. I added: > - support for changing alarm thresholds via sysfs > - move HWMON code to a separat

Re: [PATCH net-next v3 3/6] nfp: add .ndo_get_devlink

2019-02-24 Thread Florian Fainelli
Le 2/22/19 à 2:07 PM, Jakub Kicinski a écrit : > Support getting devlink instance from a new NDO. > > Signed-off-by: Jakub Kicinski Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net-next v3 4/6] nfp: remove ethtool flashing fallback

2019-02-24 Thread Florian Fainelli
Le 2/22/19 à 2:07 PM, Jakub Kicinski a écrit : > Now that devlink fallback will be called reliably, we can remove > the ethtool flashing code. > > Signed-off-by: Jakub Kicinski Reviewed-by: Florian Fainelli -- Florian

[PATCH net-next] mlxsw: spectrum: remove set but not used variable 'autoneg_status'

2019-02-24 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/ethernet/mellanox/mlxsw/spectrum.c: In function 'mlxsw_sp_port_get_link_ksettings': drivers/net/ethernet/mellanox/mlxsw/spectrum.c:3062:5: warning: variable 'autoneg_status' set but not used [-Wunused-but-set-variable] It's not used sin

Re: [PATCH net-next 0/2] net: switchdev.h inclusion removal

2019-02-24 Thread David Miller
From: Florian Fainelli Date: Fri, 22 Feb 2019 12:31:32 -0800 > This targets a few drivers that no longer to have net/switchdev.h > included. Series applied.

Re: [PATCH net-next v3 0/6] devlink: make ethtool compat reliable

2019-02-24 Thread David Miller
Jakub please address the feedback you were given. Thanks.

Re: [PATCH net-next] net: phy: check PMAPMD link status only in genphy_c45_read_link

2019-02-24 Thread David Miller
From: Heiner Kallweit Date: Fri, 22 Feb 2019 22:59:38 +0100 > The current code reports a link as up if all devices (except a few > blacklisted ones) report the link as up. This breaks Aquantia AQCS109 > for lower speeds because on this PHY the PCS link status reflects a > 10G link only. For Marve

Re: [PATCH v2 bpf-next 0/9] bpf: Network Resource Manager (NRM)

2019-02-24 Thread David Ahern
On 2/23/19 11:48 PM, Alexei Starovoitov wrote: > 'network resources' also include back bone and TOR capacity and > this mechanism is going to help address that as well. This appears to be the talk you are referring to: http://vger.kernel.org/lpc_net2018_talks/LPC%20NRM.pdf and from my reading it

Re: [PATCH] net: lantiq: Do not use eth_change_mtu()

2019-02-24 Thread David Miller
From: Hauke Mehrtens Date: Fri, 22 Feb 2019 20:12:57 +0100 > eth_change_mtu() is not needed any more, the networking subsystem will > call it automatically when this callback is not implemented. > > Signed-off-by: Hauke Mehrtens Applied to net-next.

Re: [PATCH] net: dsa: lantiq: Add GPHY firmware files

2019-02-24 Thread David Miller
From: Hauke Mehrtens Date: Fri, 22 Feb 2019 20:11:13 +0100 > This adds the file names of the FW files which this driver handles into > the module description. > > Signed-off-by: Hauke Mehrtens Applied.

Re: [PATCH v2 net-next] net: phy: improve definition of __ETHTOOL_LINK_MODE_MASK_NBITS

2019-02-24 Thread David Miller
From: Heiner Kallweit Date: Fri, 22 Feb 2019 19:25:59 +0100 > The way to define __ETHTOOL_LINK_MODE_MASK_NBITS seems to be overly > complicated, go with a standard approach instead. > Whilst we're at it, move the comment to the right place. > > v2: > - rebased > > Signed-off-by: Heiner Kallweit

Re: [PATCH v2 0/2] NETWORKING: avoid use IPCB in cipso_v4_error

2019-02-24 Thread David Miller
From: Nazarov Sergey Date: Fri, 22 Feb 2019 20:39:29 +0300 > The original discussion is here: > https://lore.kernel.org/linux-security-module/16659801547571...@sas1-890ba5c2334a.qloud-c.yandex.net/ > > Changes in v2: > - original patch divided on 2 parts: add __icmp_send function, fix > cipso_v

Re: [PATCH] NETWORKING: avoid use IPCB in cipso_v4_error

2019-02-24 Thread David Miller
From: Nazarov Sergey Date: Fri, 22 Feb 2019 19:35:29 +0300 > I tried to analyze the cases of using icmp_send in kernel. It > indirectly used by many protocols: ARP, IP, UDP, Netfilter, IPVS, > IPIP, GRE over IP, CLIP, XFRM, CIPSOv4. Different IP tunnels and > XFRM operating directly over IP laye

Re: [PATCH net] net/sched: act_skbedit: fix refcount leak when replace fails

2019-02-24 Thread David Miller
From: Davide Caratti Date: Fri, 22 Feb 2019 12:33:26 +0100 > when act_skbedit was converted to use RCU in the data plane, we added an > error path, but we forgot to drop the action refcount in case of failure > during a 'replace' operation: > > # tc actions add action skbedit ptype otherhost pa

Re: [PATCH net] net/sched: act_ipt: fix refcount leak when replace fails

2019-02-24 Thread David Miller
From: Davide Caratti Date: Fri, 22 Feb 2019 12:33:25 +0100 > After commit 4e8ddd7f1758 ("net: sched: don't release reference on action > overwrite"), the error path of all actions was converted to drop refcount > also when the action was being overwritten. But we forgot act_ipt_init(), > in case

[PATCH] rtl_bt: Update firmware for BT part of RTL8822C

2019-02-24 Thread Larry Finger
The file was sent to me by Max Chou . Signed-off-by: Larry Finger Cc: Max Chou --- WHENCE | 2 ++ rtl_bt/rtl8822cu_fw.bin | Bin 22412 -> 41588 bytes 2 files changed, 2 insertions(+) diff --git a/WHENCE b/WHENCE index 853990b..351b312 100644 --- a/WHENCE +++ b/WHENCE @@ -325

Re: [PATCH net-next 2/2] net: phy: aquantia: add hwmon support

2019-02-24 Thread Andrew Lunn
> I just see that we don't need struct aqr_priv at all for hwmon > because it uses device-managed versions of the relevant functions. > So we can add such a struct when it's actually needed. Hi Heiner Yes, i had not noticed that. Andrew

Re: No traffic with Marvell switch and latest linux-next

2019-02-24 Thread Heiner Kallweit
On 24.02.2019 22:26, Florian Fainelli wrote: > > > On February 24, 2019 9:04:55 AM PST, Andrew Lunn wrote: >>> The added difficulty here and the reason why Andrew went with the >>> approach that is used by the code currently is because neither do the >>> CPU or DSA ports are backed by a net_devi

[PATCH net-next v2 1/2] net: phy: aquantia: rename aquantia.c to aquantia_main.c

2019-02-24 Thread Heiner Kallweit
Rename aquantia.c to aquantia_main.c to be prepared for adding new functionality to separate source code files. Signed-off-by: Heiner Kallweit --- drivers/net/phy/Makefile| 1 + drivers/net/phy/{aquantia.c => aquantia_main.c} | 0 2 files changed, 1 insertion(+) rename d

[PATCH net-next v2 2/2] net: phy: aquantia: add hwmon support

2019-02-24 Thread Heiner Kallweit
This adds HWMON support for the temperature sensor and the related alarms on the 107/108/109 chips. This patch is based on work from Nikita and Andrew. I added: - support for changing alarm thresholds via sysfs - move HWMON code to a separate source file to improve maintainability - smaller changes

[PATCH net-next v2 0/2] net: phy: aquantia: add hwmon support

2019-02-24 Thread Heiner Kallweit
This series adds HWMON support for the temperature sensor and the related alarms on the 107/108/109 chips. v2: - remove struct aqr_priv - rename header file to aquantia.h Heiner Kallweit (2): net: phy: aquantia: rename aquantia.c to aquantia_main.c net: phy: aquantia: add hwmon support driv

Re: No traffic with Marvell switch and latest linux-next

2019-02-24 Thread Florian Fainelli
On February 24, 2019 9:04:55 AM PST, Andrew Lunn wrote: >> The added difficulty here and the reason why Andrew went with the >> approach that is used by the code currently is because neither do the >> CPU or DSA ports are backed by a net_device. It is somewhere on my >TODO >> to permit the use

Re: [PATCH net-next 2/2] net: phy: aquantia: add hwmon support

2019-02-24 Thread Heiner Kallweit
On 24.02.2019 21:29, Andrew Lunn wrote: >> diff --git a/drivers/net/phy/aquantia_hwmon.c >> b/drivers/net/phy/aquantia_hwmon.c >> new file mode 100644 >> index 0..c0dd695f6 >> --- /dev/null >> +++ b/drivers/net/phy/aquantia_hwmon.c >> @@ -0,0 +1,263 @@ >> +// SPDX-License-Identifier: GPL-2

Re: [PATCH net-next 0/3] net: protodown support for macvlan and vxlan

2019-02-24 Thread David Miller
From: Andy Roulin Date: Fri, 22 Feb 2019 18:06:35 + > This patch series adds dev_change_proto_down_generic, a generic > implementation of ndo_change_proto_down, which sets the netdev carrier > state according to the new proto_down value. > > This handler adds the ability to set protodown on

Re: marvell10g.c merge into net-next

2019-02-24 Thread Maxime Chevallier
Hello Dave, Heiner, On Sun, 24 Feb 2019 21:35:11 +0100 Heiner Kallweit wrote: >On 24.02.2019 21:15, David Miller wrote: >> >> Heiner, please look at net-next which I just merged net into. >> >> Net had a bug fix wherein the MDIO_AN_10GBT_CTRL_ADV_NBT_MASK >> bits are cleared in the 10gbt contr

32-bit Amlogic SoCs: avoid using Ethernet MAC addresses

2019-02-24 Thread Martin Blumenstingl
I have seen Anand's your question in [0]: > only issue is I have is the each time their is random MAC address so I > get new IP from dhcp server. > How can I avoid this. I have tried to enable eFuse driver but with no success. u-boot on the 64-bit SoCs can read the MAC address from the eFuse and p

Re: [PATCH net-next 0/8] Add tests for unlocked flower classifier implementation

2019-02-24 Thread David Miller
From: Vlad Buslov Date: Fri, 22 Feb 2019 16:00:39 +0200 > Implement tests for tdc testsuite to verify concurrent rules update with > rtnl-unlocked flower classifier implementation. The goal of these tests > is to verify general flower classifier correctness by updating filters > on same classifie

Re: [PATCH ethtool] ethtool: Add support for 200Gbps (50Gbps per lane) link mode

2019-02-24 Thread Andrew Lunn
> > Hi Michal > > > > So are you doing a read/modify/write? In that case, off/on makes > > sense. For a pure write, i don't see the need for off/on. > > When using netlink interface, the read/modify/write cycle is limited to > kernel code and is done under rtnl_lock. The netlink interface allows

Re: [PATCH net-next] net: Skip GSO length estimation if transport header is not set

2019-02-24 Thread David Miller
From: Maxim Mikityanskiy Date: Fri, 22 Feb 2019 12:55:22 + > qdisc_pkt_len_init expects transport_header to be set for GSO packets. > Patch [1] skips transport_header validation for GSO packets that don't > have network_header set at the moment of calling virtio_net_hdr_to_skb, > and allows t

Re: [PATCH net-next v2 2/2] doc: add phylink documentation to the networking book

2019-02-24 Thread David Miller
From: Russell King Date: Fri, 22 Feb 2019 11:31:46 + > Add some phylink documentation to the networking book detailing how > to convert network drivers from phylib to phylink. > > Signed-off-by: Russell King > --- > v2: updated with comments from Randy and updated to apply to net-next Appl

Re: [PATCH net-next v2 1/2] net: phylink: update mac_config() documentation

2019-02-24 Thread David Miller
From: Russell King Date: Fri, 22 Feb 2019 11:31:41 + > A detail for mac_config() had been missed in the documentation for the > method - it is expected that the method will update the MAC to the > settings, rather than completely reprogram the MAC on each call. > Update the documentation for

Re: [PATCH][net-next] net: Use RCU_INIT_POINTER() to set sk_wq

2019-02-24 Thread David Miller
From: Li RongQing Date: Fri, 22 Feb 2019 17:08:22 +0800 > This pointer is RCU protected, so proper primitives should be used. > > Signed-off-by: Zhang Yu > Signed-off-by: Li RongQing Applied.

Re: marvell10g.c merge into net-next

2019-02-24 Thread Heiner Kallweit
On 24.02.2019 21:15, David Miller wrote: > > Heiner, please look at net-next which I just merged net into. > > Net had a bug fix wherein the MDIO_AN_10GBT_CTRL_ADV_NBT_MASK > bits are cleared in the 10gbt control register to work around > a problem with some marvell10g phy chips. > > In the merg

Re: stmmac / meson8b-dwmac

2019-02-24 Thread Simon Huelck
Am 24.02.2019 um 20:42 schrieb Sebastian Gottschall: > vice are you talking about? its not your windows pc. if its a ipq8064 > based device or something like that you should look > on a very different location. this platform like the r7800 has stmac > performance problems since the kernel clk code

Re: [PATCH net-next] net: phy: let genphy_c45_read_abilities also check aneg capability

2019-02-24 Thread David Miller
From: Heiner Kallweit Date: Fri, 22 Feb 2019 08:23:04 +0100 > When using genphy_c45_read_abilities() as get_features callback we > also have to set the autoneg capability in phydev->supported. > > Signed-off-by: Heiner Kallweit Applied, thanks.

Re: [PATCH ethtool] ethtool: Add support for 200Gbps (50Gbps per lane) link mode

2019-02-24 Thread Michal Kubecek
On Sun, Feb 24, 2019 at 08:40:15PM +0100, Andrew Lunn wrote: > > > This is getting less friendly all the time, and it was never very > > > friendly to start with. We have the strings which represent these link > > > modes in the table used for dumping caps. How about allowing the user > > > to list

Re: [PATCH 5/5] net: dsa: fix a leaked reference by adding missing of_node_put

2019-02-24 Thread David Miller
From: Wen Yang Date: Fri, 22 Feb 2019 15:15:42 +0800 > diff --git a/net/dsa/dsa2.c b/net/dsa/dsa2.c > index 8c431e0..89823f0 100644 > --- a/net/dsa/dsa2.c > +++ b/net/dsa/dsa2.c > @@ -613,7 +613,7 @@ static int dsa_switch_parse_ports_of(struct dsa_switch > *ds, > struct device_node *ports,

Re: [PATCH net-next 2/2] net: phy: aquantia: add hwmon support

2019-02-24 Thread Andrew Lunn
> diff --git a/drivers/net/phy/aquantia_hwmon.c > b/drivers/net/phy/aquantia_hwmon.c > new file mode 100644 > index 0..c0dd695f6 > --- /dev/null > +++ b/drivers/net/phy/aquantia_hwmon.c > @@ -0,0 +1,263 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* HWMON driver for Aquantia PHY > + * > +

marvell10g.c merge into net-next

2019-02-24 Thread David Miller
Heiner, please look at net-next which I just merged net into. Net had a bug fix wherein the MDIO_AN_10GBT_CTRL_ADV_NBT_MASK bits are cleared in the 10gbt control register to work around a problem with some marvell10g phy chips. In the merge I preserved your usage of the generic c45 helpers in t

Re: [PATCH] Documentation: networking: switchdev: Update port parent ID section

2019-02-24 Thread David Miller
From: David Miller Date: Sun, 24 Feb 2019 11:26:30 -0800 (PST) > From: Florian Fainelli > Date: Sun, 24 Feb 2019 08:46:59 -0800 > >> Looks like you applied this to the "net" tree, and I missed prefixing >> the patch to indicate this was targeted at the "net-next" tree. Are you >> planning a mer

[PATCH net-next 1/2] net: phy: aquantia: rename aquantia.c to aquantia_main.c

2019-02-24 Thread Heiner Kallweit
Rename aquantia.c to aquantia_main.c to be prepared for adding new functionality to separate source code files. Signed-off-by: Heiner Kallweit --- drivers/net/phy/Makefile| 1 + drivers/net/phy/{aquantia.c => aquantia_main.c} | 0 2 files changed, 1 insertion(+) rename d

[PATCH net-next 2/2] net: phy: aquantia: add hwmon support

2019-02-24 Thread Heiner Kallweit
This adds HWMON support for the temperature sensor and the related alarms on the 107/108/109 chips. This patch is based on work from Nikita and Andrew. I added: - support for changing alarm thresholds via sysfs - move HWMON code to a separate source file to improve maintainability - smaller changes

[PATCH net-next 0/2] net: phy: aquantia: add hwmon support

2019-02-24 Thread Heiner Kallweit
This series adds HWMON support for the temperature sensor and the related alarms on the 107/108/109 chips. Heiner Kallweit (2): net: phy: aquantia: rename aquantia.c to aquantia_main.c net: phy: aquantia: add hwmon support drivers/net/phy/Makefile | 1 + drivers/net/ph

Re: stmmac / meson8b-dwmac

2019-02-24 Thread Sebastian Gottschall
** **its clearly visible when i activated the other stream for getting duplex load ... The highest rate also stays alot under the possible 930MBits that i have seen earlier with 4.14. ** ** ** **the parallel stream reached around 450Mbits , which almost sums up to 660Mbits. This is what i me

[PATCH net-next] dsa: Remove phydev parameter from disable_port call

2019-02-24 Thread Andrew Lunn
No current DSA driver makes use of the phydev parameter passed to the disable_port call. Remove it. Signed-off-by: Andrew Lunn --- drivers/net/dsa/b53/b53_common.c | 4 ++-- drivers/net/dsa/b53/b53_priv.h | 2 +- drivers/net/dsa/bcm_sf2.c | 9 - drivers/net/dsa

Re: No traffic with Marvell switch and latest linux-next

2019-02-24 Thread Russell King - ARM Linux admin
On Sun, Feb 24, 2019 at 06:28:48PM +0100, Andrew Lunn wrote: > On Sun, Feb 24, 2019 at 03:31:26PM +, Russell King - ARM Linux admin > wrote: > > On Sun, Feb 24, 2019 at 12:42:35AM +0100, Andrew Lunn wrote: > > > Looking forward, at some point we are going to have to make fixed-link > > > suppo

Re: [PATCH ethtool] ethtool: Add support for 200Gbps (50Gbps per lane) link mode

2019-02-24 Thread Andrew Lunn
> > This is getting less friendly all the time, and it was never very > > friendly to start with. We have the strings which represent these link > > modes in the table used for dumping caps. How about allowing the user > > to list a comma separate list of modes. > > > > ethtool -s lan42 advertise

Re: [PATCH 1/2 v2] kprobe: Do not use uaccess functions to access kernel memory that can fault

2019-02-24 Thread Andy Lutomirski
On Sat, Feb 23, 2019 at 12:30 AM Nadav Amit wrote: > > > On Feb 22, 2019, at 3:59 PM, Andy Lutomirski wrote: > > > > On Fri, Feb 22, 2019 at 3:02 PM Jann Horn wrote: > >> On Fri, Feb 22, 2019 at 11:39 PM Nadav Amit wrote: > On Feb 22, 2019, at 2:21 PM, Nadav Amit wrote: > > > On

Re: [PATCH] Documentation: networking: switchdev: Update port parent ID section

2019-02-24 Thread David Miller
From: Florian Fainelli Date: Sun, 24 Feb 2019 08:46:59 -0800 > Looks like you applied this to the "net" tree, and I missed prefixing > the patch to indicate this was targeted at the "net-next" tree. Are you > planning a merge from "net" to "net-next" anytime soon? Yes, I am working on that right

Re: [PATCH ethtool] ethtool: Add support for 200Gbps (50Gbps per lane) link mode

2019-02-24 Thread Michal Kubecek
On Sun, Feb 24, 2019 at 05:47:51PM +0100, Andrew Lunn wrote: > On Sun, Feb 24, 2019 at 05:08:21PM +0200, Tariq Toukan wrote: > > From: Aya Levin > > index 5a26cff5fb33..64ce0711ad5f 100644 > > --- a/ethtool.8.in > > +++ b/ethtool.8.in > > @@ -650,6 +650,11 @@ lB l lB. > > 0x4

Re: [GIT] Networking

2019-02-24 Thread pr-tracker-bot
The pull request you sent on Sat, 23 Feb 2019 18:57:10 -0800 (PST): > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git refs/heads/master has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/c4eb1e1852df60d61e04a6b580a0490460c9e31b Thank you! -- Deet-doot-dot, I

Re: [PATCH ethtool] ethtool: Add support for 200Gbps (50Gbps per lane) link mode

2019-02-24 Thread Michal Kubecek
On Sun, Feb 24, 2019 at 05:08:21PM +0200, Tariq Toukan wrote: > From: Aya Levin > > Introduce 50Gbps per lane link modes and 200Gbps speed, update print > functions and initialization functions accordingly. > In addition, update related man page accordingly. > > Signed-off-by: Aya Levin > Signe

Re: [PATCH v2 bpf-next 2/9] bpf: Add bpf helper bpf_tcp_enter_cwr

2019-02-24 Thread Eric Dumazet
On 02/23/2019 07:08 PM, Martin Lau wrote: > On Sat, Feb 23, 2019 at 05:32:14PM -0800, Eric Dumazet wrote: >> >> >> On 02/22/2019 05:06 PM, brakmo wrote: >>> From: Martin KaFai Lau >>> >>> This patch adds a new bpf helper BPF_FUNC_tcp_enter_cwr >>> "int bpf_tcp_enter_cwr(struct bpf_tcp_sock *tp)

Re: [PATCH net] net: phy: fix reading fixed phy status

2019-02-24 Thread Heiner Kallweit
On 24.02.2019 18:57, Andrew Lunn wrote: > On Sun, Feb 24, 2019 at 06:01:18PM +0100, Heiner Kallweit wrote: >> With the switch to phy_resolve_aneg_linkmode() we don't read from the >> chip any longer what is advertised but use phydev->advertising directly. >> For a fixed phy however this bitmap is e

Re: [PATCH net] net: phy: fix reading fixed phy status

2019-02-24 Thread Andrew Lunn
On Sun, Feb 24, 2019 at 06:01:18PM +0100, Heiner Kallweit wrote: > With the switch to phy_resolve_aneg_linkmode() we don't read from the > chip any longer what is advertised but use phydev->advertising directly. > For a fixed phy however this bitmap is empty so far, what results in > no common mode

Re: [PATCH net-next] net: phy: improve auto-neg emulation in swphy

2019-02-24 Thread Andrew Lunn
On Sun, Feb 24, 2019 at 05:41:47PM +0100, Heiner Kallweit wrote: > Auto-neg emulation currently doesn't set bit BMCR_ANENABLE in BMCR, > add this. Users will ignore speed and duplex settings in BMCR because > we're emulating auto-neg, therefore we can remove related code. > See also following discu

Re: No traffic with Marvell switch and latest linux-next

2019-02-24 Thread Andrew Lunn
On Sun, Feb 24, 2019 at 03:31:26PM +, Russell King - ARM Linux admin wrote: > On Sun, Feb 24, 2019 at 12:42:35AM +0100, Andrew Lunn wrote: > > Looking forward, at some point we are going to have to make fixed-link > > support higher speeds. That probably means we need a swphy-c45 which > > emul

Re: [PATCH iproute2-next v2 00/19] Export object IDs to users

2019-02-24 Thread Leon Romanovsky
On Sun, Feb 24, 2019 at 10:16:37AM -0500, David Ahern wrote: > On 2/23/19 4:15 AM, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > Changelog: > > v1->v2: > > * Fixed commit messages > > * Added Steve's ROB > > v0->v1: > > * Rebased to latest iproute2-next > > * Added latest rdma_netli

Re: No traffic with Marvell switch and latest linux-next

2019-02-24 Thread Andrew Lunn
> The added difficulty here and the reason why Andrew went with the > approach that is used by the code currently is because neither do the > CPU or DSA ports are backed by a net_device. It is somewhere on my TODO > to permit the use of PHYLINK without the need of a net_device to cover > those spec

[PATCH net] net: phy: fix reading fixed phy status

2019-02-24 Thread Heiner Kallweit
With the switch to phy_resolve_aneg_linkmode() we don't read from the chip any longer what is advertised but use phydev->advertising directly. For a fixed phy however this bitmap is empty so far, what results in no common mode being found. This breaks DSA. Fix this by advertising everything that is

Re: [PATCH net-next 7/8] net: switchdev: Replace port attr set SDO with a notification

2019-02-24 Thread Florian Fainelli
Le 2/23/19 à 2:32 AM, Ido Schimmel a écrit : > On Fri, Feb 22, 2019 at 03:59:25PM -0800, Florian Fainelli wrote: >> Drop switchdev_ops.switchdev_port_attr_set. Drop the uses of this field >> from all clients, which were migrated to use switchdev notification in >> the previous patches. >> >> Add a

Re: [PATCH ethtool] ethtool: Add support for 200Gbps (50Gbps per lane) link mode

2019-02-24 Thread Andrew Lunn
On Sun, Feb 24, 2019 at 05:08:21PM +0200, Tariq Toukan wrote: > From: Aya Levin > index 5a26cff5fb33..64ce0711ad5f 100644 > --- a/ethtool.8.in > +++ b/ethtool.8.in > @@ -650,6 +650,11 @@ lB l lB. > 0x4 5baseCR2 Full > 0x8 5baseKR2 Full > 0x100

  1   2   >