Re: [PATCH] ipvs: Fix signed integer overflow when setsockopt timeout

2019-01-13 Thread zhangxiaoxu (A)
ping? On 1/10/2019 4:39 PM, ZhangXiaoxu wrote: There is a UBSAN bug report as below: UBSAN: Undefined behaviour in net/netfilter/ipvs/ip_vs_ctl.c:2227:21 signed integer overflow: -2147483647 * 1000 cannot be represented in type 'int' Reproduce program: #include #include

KASAN: slab-out-of-bounds Read in xfrm_policy_insert_list

2019-01-13 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:8d008e64a2eb mISDN: hfcsusb: Use struct_size() in kzalloc() git tree: net console output: https://syzkaller.appspot.com/x/log.txt?x=164f010740 kernel config: https://syzkaller.appspot.com/x/.config?x=7308e68273924137 dashboar

[PATCHv2 3/4] net: dsa: mt7530: support the 7530 switch on the Mediatek MT7621 SoC

2019-01-13 Thread gerg
From: Greg Ungerer The MediaTek MT7621 SoC device contains a 7530 switch, and the existing linux kernel 7530 DSA switch driver can be used with it. The bulk of the changes required stem from the 7621 having different regulator and pad setup. The existing setup of these in the 7530 driver appears

[PATCHv2 4/4] dt-bindings: net: dsa: add new MT7530 binding to support MT7621

2019-01-13 Thread gerg
From: Greg Ungerer Add devicetree binding to support the compatible mt7530 switch as used in the MediaTek MT7621 SoC. Signed-off-by: Greg Ungerer --- Documentation/devicetree/bindings/net/dsa/mt7530.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) v1: initial patch v2: changed to u

[PATCHv2 2/4] net: ethernet: mediatek: do not force autonegiation at init

2019-01-13 Thread gerg
From: Greg Ungerer Do not attempt to force a port phy auto-ngeotiation during the driver init phase. It is not necessary and results in a warning at system boot up: mtk_soc_eth 1e10.ethernet: generated random MAC address be:e7:d4:9d:7d:b0 mtk_soc_eth 1e10.ethernet: connected mac 0 to PHY

[PATCHv2 0/4]: net: dsa: mt7530: support MT7530 in the MT7621 So

2019-01-13 Thread gerg
This is the second version of a patch series supporting the MT7530 switch as used in the MediaTek MT7621 SoC. Unlike the MediaTek MT7623 the MT7621 is built around a dual core MIPS CPU architecture. But inside it uses basically the same 7530 switch. These patches resolves all issues I had with v

[PATCHv2 1/4] net: ethernet: mediatek: support MT7621 SoC ethernet hardware

2019-01-13 Thread gerg
From: Bjørn Mork The Mediatek MT7621 SoC contains the same ethernet hardware module as used on a number of other MediaTek SoC parts. There are some minor differences to deal with but we can use the same driver to support them all. This patch is based on work by Bjørn Mork , and his original patc

Re: KASAN: null-ptr-deref Read in ip6_hold_safe

2019-01-13 Thread Dmitry Vyukov
On Mon, Jan 14, 2019 at 7:52 AM syzbot wrote: > > Hello, > > syzbot found the following crash on: > > HEAD commit:b71acb0e3721 Merge branch 'linus' of git://git.kernel.org/.. > git tree: net-next > console output: https://syzkaller.appspot.com/x/log.txt?x=1492759f40 > kernel config:

KASAN: null-ptr-deref Read in ip6_hold_safe

2019-01-13 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:b71acb0e3721 Merge branch 'linus' of git://git.kernel.org/.. git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=1492759f40 kernel config: https://syzkaller.appspot.com/x/.config?x=b03c5892bb940c76 da

Fw: [Bug 202249] New: WARNING: CPU: 1 PID: 3904 at net/ipv4/raw_diag.c:28 raw_get_hashinfo.isra.0+0x1a/0x30

2019-01-13 Thread Stephen Hemminger
This problem was not reported previously. Looks like ss hitting bug in raw_diag.c Begin forwarded message: Date: Sun, 13 Jan 2019 09:52:12 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 202249] New: WARNING: CPU: 1 PID: 3904 at net/ipv4/raw_diag.c:2

[PATCH] networking: Documentation: fix snmp_counters.rst Sphinx warnings

2019-01-13 Thread Randy Dunlap
From: Randy Dunlap Fix over 100 documentation warnings in snmp_counter.rst by extending the underline string lengths and inserting a blank line after bullet items. Examples: Documentation/networking/snmp_counter.rst:1: WARNING: Title overline too short. Documentation/networking/snmp_counter.rst

linux-next: build warning after merge of the net tree

2019-01-13 Thread Stephen Rothwell
Hi all, After merging the net tree, today's linux-next build (powerpc allyesconfig) produced this warning: ld: warning: orphan section `.bpfilter_umh' from `net/bpfilter/bpfilter_umh_blob.o' being placed in section `.bpfilter_umh' Introduced by commit 61fbf5933d42 ("net: bpfilter: restart bp

RE: [PATCH net] bridge: Fix ethernet header pointer before check skb forwardable

2019-01-13 Thread wangyunjian
> -Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Saturday, January 12, 2019 10:55 PM > To: wangyunjian > Cc: netdev@vger.kernel.org; xudingke > Subject: Re: [PATCH net] bridge: Fix ethernet header pointer before check > skb forwardable > > On Sat, Jan 12, 2019 at

Re: [PATCH net 1/1] bonding: fix PACKET_ORIGDEV regression on bonding masters

2019-01-13 Thread Maciej Żenczykowski
So I don't remember the specifics... (note I'm writing this all from memory without looking it up/testing it - I may be utterly wrong or dreaming) But I seem to recall that the core problem we were trying to solve was that a daemon listening on an AF_PACKET ethertype 88CC [LLDP] socket not bound

Re: [PATCH net 1/1] bonding: fix PACKET_ORIGDEV regression on bonding masters

2019-01-13 Thread David Miller
From: Michal Soltys Date: Mon, 7 Jan 2019 17:29:46 +0100 > This patch reverts: > > b89f04c61efe bonding: deliver link-local packets with skb->dev set to link > that packets arrived on > > And its subsequent fixups: > > 6a9e461f6fe4 bonding: pass link-local packets to bonding master also. > 0

[GIT] Networking

2019-01-13 Thread David Miller
1) Fix regression in multi-SKB responses to RTM_GETADDR, from Arthur Gautier. 2) Fix ipv6 frag parsing in openvswitch, from Yi-Hung Wei. 3) Unbounded recursion in ipv4 and ipv6 GUE tunnels, from Stefano Brivio. 4) Use after free in hns driver, from Yonglong Liu. 5) icmp6_send() needs to

Re: [Patch net] net_sched: refetch skb protocol for each filter

2019-01-13 Thread Cong Wang
On Sat, Jan 12, 2019 at 7:41 AM Jamal Hadi Salim wrote: > > On 2019-01-12 7:23 a.m., Jamal Hadi Salim wrote: > > > Do we have a test case for a setup like this in tdc? > > i.e incoming tagged and then vlan popped by action? > > Otherwise a test with IFE which resets the ethertype > > would be suff

Re: [Patch net] net_sched: refetch skb protocol for each filter

2019-01-13 Thread Cong Wang
On Sat, Jan 12, 2019 at 4:23 AM Jamal Hadi Salim wrote: > Cong, > I am a little worried about the impact of this change. Smells > more like it has to do with Vlan action or related issues > than with reclassifying. You can verify this patch with Martin's test case. I verified it with the script b

Re: [PATCH v2] vrf: Fix conntrack-dnat conflict in vrf-device PREROUTING hook

2019-01-13 Thread kbuild test robot
Hi wenxu, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] [also build test ERROR on v5.0-rc1 next-20190111] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/

Re: [PATCH 1/3] net: introduce SO_BINDTOIF sockopt

2019-01-13 Thread kbuild test robot
Hi David, I love your patch! Yet something to improve: [auto build test ERROR on net/master] [also build test ERROR on v5.0-rc1 next-20190111] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Dav

[PATCH v2] can: bcm: check timer values before ktime conversion

2019-01-13 Thread Oliver Hartkopp
Kyungtae Kim detected a potential integer overflow in bcm_[rx|tx]_setup() when the conversion into ktime multiplies the given value with NSEC_PER_USEC (1000). Reference: https://marc.info/?l=linux-can&m=154732118819828&w=2 Add a check for the given tv_usec, so that the value stays below one secon

Re: Problem with queuing vlan tagged packets after migration from 3.16.0 to 4.9.0

2019-01-13 Thread Cong Wang
On Sat, Jan 12, 2019 at 4:12 AM Jamal Hadi Salim wrote: > > It will be a new feature in the sense the user will have to specify > something like (adding "mark" for clarify): > > tc filter add protocol 802.1q .. u32 \ > match u32 0 0 \ > mark 15 \ > vlanid 1234 > action vlan pop reclassify Th

Re: [PATCH v4] coding-style: Clarify the expectations around bool

2019-01-13 Thread Matthew Wilcox
On Thu, Jan 10, 2019 at 11:48:13PM +, Jason Gunthorpe wrote: > +The Linux kernel bool type is an alias for the C99 _Bool type. bool values > can > +only evaluate to 0 or 1, and implicit or explicit conversion to bool > +automatically converts the value to true or false. When using bool types t

Re: WoL broken in r8169.c since kernel 4.19

2019-01-13 Thread Heiner Kallweit
On 13.01.2019 17:01, Marc Haber wrote: > On Sat, Jan 12, 2019 at 09:28:48PM +0100, Heiner Kallweit wrote: >> On 12.01.2019 21:08, Marc Haber wrote: >>> I am writing to all people who have commits in r8169.c between the v4.18 >>> and v4.19 tags in the Linux kernel. Please ignore as appropriate. If >

WoL broken in r8169.c since kernel 4.19

2019-01-13 Thread Marc Haber
Hi, I am writing to all people who have commits in r8169.c between the v4.18 and v4.19 tags in the Linux kernel. Please ignore as appropriate. If you'd prefer that to be on a mailing list, please indicate on which list you want to have that, and I'll resend. My desktop copmuter has the following

Re: [PATCH v4] coding-style: Clarify the expectations around bool

2019-01-13 Thread Federico Vaga
On 2019-01-11 00:48, Jason Gunthorpe wrote: There has been some confusion since checkpatch started warning about bool use in structures, and people have been avoiding using it. Many people feel there is still a legitimate place for bool in structures, so provide some guidance on bool usage der

Re: [PATCH net] ipv6: route: remove duplicated string from error message

2019-01-13 Thread David Ahern
On 1/12/19 2:07 PM, Joe Perches wrote: > On Sat, 2019-01-12 at 12:45 -0800, Jakub Kicinski wrote: >> "IPv6: " prefix is already added by pr_fmt, no need to include >> it again in the pr_warn() format. > [] >> diff --git a/net/ipv6/route.c b/net/ipv6/route.c > [] >> @@ -4256,7 +4256,7 @@ static void

Re: WoL broken in r8169.c since kernel 4.19

2019-01-13 Thread Marc Haber
On Sat, Jan 12, 2019 at 09:28:48PM +0100, Heiner Kallweit wrote: > On 12.01.2019 21:08, Marc Haber wrote: > > I am writing to all people who have commits in r8169.c between the v4.18 > > and v4.19 tags in the Linux kernel. Please ignore as appropriate. If > > you'd prefer that to be on a mailing li

Re: [PATCH v5 1/6] net: lorawan: Add LoRaWAN socket module

2019-01-13 Thread Jian-Hong Pan
Jian-Hong Pan 於 2019年1月7日 週一 下午10:47寫道: > > Andreas Färber 於 2018年12月29日 週六 下午3:27寫道: > > > > Hi Jian-Hong, > > > > Am 16.12.18 um 11:18 schrieb Jian-Hong Pan: > > > This patch adds a new address/protocol family for LoRaWAN network. > > > It also implements the the functions and maps to Datagram

[PATCH rdma-next 0/3] Indirect MKEY over DEVX

2019-01-13 Thread Leon Romanovsky
From: Leon Romanovsky Hi, >From Yishai, --- This series enables using indirect mkey over DEVX. The first patch recognizes the creation of an indirect mkey as part of DEVX object creation, in that case the umem valid bit should

[PATCH rdma-next 3/3] IB/mlx5: Add support for ODP for DEVX indirection mkey

2019-01-13 Thread Leon Romanovsky
From: Yishai Hadas Add support for ODP for DEVX indirection mkey, it includes: - Recognizing its type as part of the radix tree lookup. - Use similar flow as done for the MW MKEY type. Signed-off-by: Yishai Hadas Reviewed-by: Artemy Kovalyov Signed-off-by: Leon Romanovsky --- drivers/infinib

[PATCH mlx5-next 2/3] IB/mlx5: Manage indirection mkey upon DEVX flow for ODP

2019-01-13 Thread Leon Romanovsky
From: Yishai Hadas Manage indirection mkey upon DEVX flow to support ODP. To support a page fault event on the indirection mkey it needs to be part of the device mkey radix tree. Both the creation and the deletion flows for a DEVX object which is indirection mkey were adapted to handle that. S

[PATCH rdma-next 1/3] IB/mlx5: DEVX handling for indirection MKEY

2019-01-13 Thread Leon Romanovsky
From: Yishai Hadas Once an indirection MKEY is created umem valid bit shouldn't be set as this MKEY doesn't really hold a umem. Signed-off-by: Yishai Hadas Reviewed-by: Artemy Kovalyov Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/devx.c | 38 +--

[PATCH mlx5-next] RDMA/mad: Reduce MAD scope to mlx5_ib only

2019-01-13 Thread Leon Romanovsky
From: Leon Romanovsky Management Datagram Interface (MAD) is applicable only when physical port is Infiniband. It makes MAD command logic to be completely unrelated to eth/core parts of mlx5. Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/cmd.c | 37 + drive

[PATCH 2/2] net: bridge: fix tc added vlan insert as payload

2019-01-13 Thread Zahari Doychev
The skb->mac_len is used for the skb_push before inserting the vlan tag to the packet payload. After that the skb is pulled only ETH_HLEN and the network header is being reset to get the correct packet mac header. This avoids sending packets with incorrect mac header when vlan tags are pushed with

[PATCH 0/2] net: bridge: fix tc added QinQ forwarding

2019-01-13 Thread Zahari Doychev
The Linux bridge seems to not correctly forward double vlan tagged packets added using the tc vlan action. I am using a bridge with two netdevs and on one of them a have the clsact qdisc with tc flower rule adding two vlan tags. ip link add name br0 type bridge vlan_filtering 1 ip link set dev br0

[PATCH 1/2] net: bridge: fix tc added QinQ forwarding

2019-01-13 Thread Zahari Doychev
Use the skb->mac_len instead of using the ETH_HLEN when pushing the skb data pointer. This fixes sending incorrect packets when more than one vlan tags are pushed by tc-vlan and the mac header length is bigger than ETH_HLEN. In this way the vlan tagged contained in the skb is inserted at right offs

Re: [PATCH] can: bcm: check timer values before ktime conversion

2019-01-13 Thread Andre Naujoks
On 1/13/19 9:18 AM, Oliver Hartkopp wrote: > Hi Andre, > > On 1/12/19 11:45 PM, Andre Naujoks wrote: >> I really don't know. That's why I'd be hesitant to restrict this. Maybe >> limit it to something really out of the ordinary, like a year? > > :-) > > The intention was to send and monitor cycl

Re: [PATCH net-next v5 0/5] Introduce NETIF_F_GRO_HW

2019-01-13 Thread Shay Agroskin
Thank you for your replies. It answered my questions. Shay On 1/8/2019 12:58 PM, Michael Chan wrote: On Mon, Jan 7, 2019 at 6:00 AM Shay Agroskin wrote: a) All segments (aggregated packets) must be of the same size (except possibly the last one). (This in order to know each segments size, w

Re: Sticky packet drops on mlx5 RX queue

2019-01-13 Thread Tariq Toukan
Hi Pieter, On 1/11/2019 12:41 AM, Pieter Noordhuis wrote: > I'm looking into an issue with mlx5 on 4.11.3. It is triggered by high memory > pressure but continues for long after the memory pressure is gone. It starts > to continuously use pfmemalloc pages, some of which appear to be coming from

Re: [PATCH iproute-next] tc: m_tunnel_key: Allow key-less tunnels

2019-01-13 Thread Or Gerlitz
On Thu, Jan 10, 2019 at 3:05 PM Adi Nissim wrote: > Change the id parameter of the tunnel_key set action from mandatory to > optional. > Some tunneling protocols (e.g. GRE) specify the id as an optional field. Hi, The kernel code for the tunnel key actions allows keyless tunnels as of 5.0 (commi

[PATCH v2] dt-bindings: net: dsa: ksz9477: fix indentation for switch spi bindings

2019-01-13 Thread Sergio Paracuellos
Switch bindings for spi managed mode are using spaces instead of tabs. Fix them to get a file with a proper kernel indentation style. Reviewed-by: Florian Fainelli Signed-off-by: Sergio Paracuellos --- Changes in v2: - Rebase onto net-next - Collect previous Reviewed-by tags .../device

Re: [PATCH] can: bcm: check timer values before ktime conversion

2019-01-13 Thread Oliver Hartkopp
Hi Andre, On 1/12/19 11:45 PM, Andre Naujoks wrote: I really don't know. That's why I'd be hesitant to restrict this. Maybe limit it to something really out of the ordinary, like a year? :-) The intention was to send and monitor cyclic CAN frames within a range of 5 to 5000ms. Even if you wa