Hi wenxu, Thank you for the patch! Yet something to improve:
[auto build test ERROR on net-next/master] [also build test ERROR on v5.0-rc1 next-20190111] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/wenxu-ucloud-cn/vrf-Fix-conntrack-dnat-conflict-in-vrf-device-PREROUTING-hook/20190111-151714 config: i386-randconfig-b0-01140058 (attached as .config) compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): In file included from include/net/netfilter/nf_conntrack.h:25:0, from drivers/net/vrf.c:40: include/linux/netfilter/nf_conntrack_proto_gre.h:31:22: error: field 'nf' has incomplete type struct nf_proto_net nf; ^ In file included from drivers/net/vrf.c:40:0: include/net/netfilter/nf_conntrack.h:69:22: error: field 'ct_general' has incomplete type struct nf_conntrack ct_general; ^ include/net/netfilter/nf_conntrack.h: In function 'nf_ct_get': include/net/netfilter/nf_conntrack.h:158:15: error: 'const struct sk_buff' has no member named '_nfct' *ctinfo = skb->_nfct & NFCT_INFOMASK; ^ include/net/netfilter/nf_conntrack.h:160:31: error: 'const struct sk_buff' has no member named '_nfct' return (struct nf_conn *)(skb->_nfct & NFCT_PTRMASK); ^ include/net/netfilter/nf_conntrack.h: In function 'nf_ct_put': >> include/net/netfilter/nf_conntrack.h:167:2: error: implicit declaration of >> function 'nf_conntrack_put' [-Werror=implicit-function-declaration] nf_conntrack_put(&ct->ct_general); ^ include/net/netfilter/nf_conntrack.h: In function 'nf_ct_set': include/net/netfilter/nf_conntrack.h:324:5: error: 'struct sk_buff' has no member named '_nfct' skb->_nfct = (unsigned long)ct | info; ^ include/net/netfilter/nf_conntrack.h: In function 'nf_ct_get': include/net/netfilter/nf_conntrack.h:161:1: warning: control reaches end of non-void function [-Wreturn-type] } ^ cc1: some warnings being treated as errors vim +/nf_conntrack_put +167 include/net/netfilter/nf_conntrack.h 303223092 Florian Westphal 2017-01-23 153 9fb9cbb10 Yasuyuki Kozakai 2005-11-09 154 /* Return conntrack_info and tuple hash for given skb. */ 9fb9cbb10 Yasuyuki Kozakai 2005-11-09 155 static inline struct nf_conn * 9fb9cbb10 Yasuyuki Kozakai 2005-11-09 156 nf_ct_get(const struct sk_buff *skb, enum ip_conntrack_info *ctinfo) 9fb9cbb10 Yasuyuki Kozakai 2005-11-09 157 { a9e419dc7 Florian Westphal 2017-01-23 @158 *ctinfo = skb->_nfct & NFCT_INFOMASK; a9e419dc7 Florian Westphal 2017-01-23 159 a9e419dc7 Florian Westphal 2017-01-23 160 return (struct nf_conn *)(skb->_nfct & NFCT_PTRMASK); 9fb9cbb10 Yasuyuki Kozakai 2005-11-09 161 } 9fb9cbb10 Yasuyuki Kozakai 2005-11-09 162 9fb9cbb10 Yasuyuki Kozakai 2005-11-09 163 /* decrement reference count on a conntrack */ 9fb9cbb10 Yasuyuki Kozakai 2005-11-09 164 static inline void nf_ct_put(struct nf_conn *ct) 9fb9cbb10 Yasuyuki Kozakai 2005-11-09 165 { 44d6e2f27 Varsha Rao 2017-08-30 166 WARN_ON(!ct); 9fb9cbb10 Yasuyuki Kozakai 2005-11-09 @167 nf_conntrack_put(&ct->ct_general); 9fb9cbb10 Yasuyuki Kozakai 2005-11-09 168 } 9fb9cbb10 Yasuyuki Kozakai 2005-11-09 169 :::::: The code at line 167 was first introduced by commit :::::: 9fb9cbb1082d6b31fb45aa1a14432449a0df6cf1 [NETFILTER]: Add nf_conntrack subsystem. :::::: TO: Yasuyuki Kozakai <yasuyuki.koza...@toshiba.co.jp> :::::: CC: David S. Miller <da...@davemloft.net> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip