Re: [PATCH bpf-next 07/19] bpf: verifier: remove dead code

2018-12-21 Thread Alexei Starovoitov
On Fri, Dec 21, 2018 at 03:46:32PM -0800, Jakub Kicinski wrote: > On Thu, 20 Dec 2018 07:19:06 +, Yonghong Song wrote: > > > I think this will break func_info, since it's not adjusted here. > > > Also iirc line_info is relying on first insn to always have line_info. > > > If first insn is dead,

Re: [PATCH bpf-next 07/19] bpf: verifier: remove dead code

2018-12-21 Thread Martin Lau
On Fri, Dec 21, 2018 at 03:46:32PM -0800, Jakub Kicinski wrote: > I want to also > tackle the JIT linfo offsets for offloads while at it and post an RFC > (unless you're handling that already Martin?) No. I am not :)

Re: [bpf-next RFCv2 2/3] veth: support AF_XDP.

2018-12-21 Thread William Tu
On Fri, Dec 21, 2018 at 12:38 AM Björn Töpel wrote: > > Den ons 19 dec. 2018 kl 01:55 skrev William Tu : > > > > The patch adds support for AF_XDP async xmit. Users can use > > AF_XDP on both side of the veth and get better performance, with > > the cost of ksoftirqd doing the xmit. The veth_xsk

Re: rfc: bool structure members (was Re: [PATCH V3] net/mlx4: Get rid of page operation after dma_alloc_coherent)

2018-12-21 Thread Jason Gunthorpe
On Thu, Dec 20, 2018 at 09:12:43PM -0800, Joe Perches wrote: > Care to submit a coding_style.rst patch or > improve the one below this? I took yours and revised it a little bit. I spent some time looking at assembly and decided to drop the performance note, the number of cases that run into overhe

Re: [PATCH bpf-next 07/19] bpf: verifier: remove dead code

2018-12-21 Thread Jakub Kicinski
On Thu, 20 Dec 2018 07:19:06 +, Yonghong Song wrote: > > I think this will break func_info, since it's not adjusted here. > > Also iirc line_info is relying on first insn to always have line_info. > > If first insn is dead, second insn might not have a line_info generated > > and things won't g

[PATCH V3] net: phy: tja11xx: Add TJA11xx PHY driver

2018-12-21 Thread Marek Vasut
Add driver for the NXP TJA1100 and TJA1101 PHYs. These PHYs are special BroadRReach 100BaseT1 PHYs used in automotive. Signed-off-by: Marek Vasut Cc: Andrew Lunn Cc: Florian Fainelli Cc: Heiner Kallweit --- V2: - Use phy_modify(), phy_{set,clear}_bits() - Drop enable argument of tja11xx_en

Re: [PATCH V2] net: phy: tja11xx: Add TJA11xx PHY driver

2018-12-21 Thread Marek Vasut
On 12/15/2018 07:01 PM, Heiner Kallweit wrote: > On 14.12.2018 17:11, Marek Vasut wrote: >> Add driver for the NXP TJA1100 and TJA1101 PHYs. These PHYs are special >> BroadRReach 100BaseT1 PHYs used in automotive. >> >> Signed-off-by: Marek Vasut >> --- >> V2: - Use phy_modify(), phy_{set,clear}_b

Re: [PATCH V2] net: phy: tja11xx: Add TJA11xx PHY driver

2018-12-21 Thread Marek Vasut
On 12/15/2018 06:38 PM, Heiner Kallweit wrote: > On 15.12.2018 18:01, Andrew Lunn wrote: >>> +static struct tja11xx_phy_stats tja11xx_hw_stats[] = { >>> + { "phy_symbol_error_count", 20, 0, 0x }, >>> + { "phy_overtemp_error", 21, 1, BIT(1) }, >>> + { "phy_undervolt_error", 21, 3, BIT(3) }

Re: [PATCH net-next] staging: octeon: fix build failure with XFRM enabled

2018-12-21 Thread Guenter Roeck
On Fri, Dec 21, 2018 at 09:57:26PM +0100, Florian Westphal wrote: > skb->sp doesn't exist anymore in the next-next tree, so mips defconfig > no longer builds. Use helper instead to reset the secpath. > > Not even compile tested. > It does fix the build error. Tested-by: Guenter Roeck > Cc: Gr

Re: dsa: how to set external PHY address of slave MDIO bus

2018-12-21 Thread John Rama
Hi Andrew, >> Use a phy-handle in the port properties. Thanks !! John On 2018/12/21 4:56, Andrew Lunn wrote: > On Thu, Dec 20, 2018 at 08:26:56PM -0500, John Rama wrote: >> Hi, Guys, >> >> I have one question. I'm working following configuration, and implementing a >> device driver. >> Basic

Re: [GIT] Networking

2018-12-21 Thread pr-tracker-bot
The pull request you sent on Fri, 21 Dec 2018 12:42:25 -0800 (PST): > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git master has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/87935eee57705e9b6df506c5df8b92d6a0b77a51 Thank you! -- Deet-doot-dot, I am a bot.

[PATCH] phonet: af_phonet: Fix Spectre v1 vulnerability

2018-12-21 Thread Gustavo A. R. Silva
protocol is indirectly controlled by user-space, hence leading to a potential exploitation of the Spectre variant 1 vulnerability. This issue was detected with the help of Smatch: net/phonet/af_phonet.c:48 phonet_proto_get() warn: potential spectre issue 'proto_tab' [w] (local cap) Fix this by

[PATCH] nfc: af_nfc: Fix Spectre v1 vulnerability

2018-12-21 Thread Gustavo A. R. Silva
proto is indirectly controlled by user-space, hence leading to a potential exploitation of the Spectre variant 1 vulnerability. This issue was detected with the help of Smatch: net/nfc/af_nfc.c:42 nfc_sock_create() warn: potential spectre issue 'proto_tab' [w] (local cap) Fix this by sanitizing

[PATCH] can: af_can: Fix Spectre v1 vulnerability

2018-12-21 Thread Gustavo A. R. Silva
protocol is indirectly controlled by user-space, hence leading to a potential exploitation of the Spectre variant 1 vulnerability. This issue was detected with the help of Smatch: net/can/af_can.c:115 can_get_proto() warn: potential spectre issue 'proto_tab' [w] Fix this by sanitizing protocol

Re: [PATCH net-next] Amiga PCMCIA 100 MBit card support

2018-12-21 Thread Michael Schmitz
Dave, Am 21.12.2018 um 13:10 schrieb David Miller: From: ALeX Kazik Date: Wed, 19 Dec 2018 23:24:32 +0100 + bool "PCMCIA NE2000 100MBit support" + default n + depends on ARM_ETHERH=n && AX88796=n && HYDRA=n && MAC8390=n + depends on MCF8390=n && NE2000=n && NE2K_PCI=n

[PATCH] net: core: Fix Spectre v1 vulnerability

2018-12-21 Thread Gustavo A. R. Silva
flen is indirectly controlled by user-space, hence leading to a potential exploitation of the Spectre variant 1 vulnerability. This issue was detected with the help of Smatch: net/core/filter.c:1101 bpf_check_classic() warn: potential spectre issue 'filter' [w] Fix this by sanitizing flen befor

[PATCH net-next] staging: octeon: fix build failure with XFRM enabled

2018-12-21 Thread Florian Westphal
skb->sp doesn't exist anymore in the next-next tree, so mips defconfig no longer builds. Use helper instead to reset the secpath. Not even compile tested. Cc: Greg Kroah-Hartman Reported-by: Guenter Roeck Fixes: 4165079ba328d ("net: switch secpath to use skb extension infrastructure") Signed-o

[GIT] Networking

2018-12-21 Thread David Miller
Some more bug fixes have trickled in, we have: 1) Local MAC entries properly in mscc driver, from Allan W. Nielsen. 2) Eric Dumazet found some more of the typical "pskb_may_pull() --> oops forgot to reload the header pointer" bugs in ipv6 tunnel handling. 3) Bad SKB socket pointer in ipv

[PATCH] sock: Make sock->sk_tstamp thread-safe

2018-12-21 Thread Deepa Dinamani
Al Viro mentioned that there is probably a race condition lurking in accesses of sk_tstamp on 32-bit machines. sock->sk_tstamp is of type ktime_t which is always an s64. On a 32 bit architecture, we might run into situations of unsafe access as the access to the field becomes non atomic. Use seql

Re: [bpf-next RFCv2 1/3] xsk: add xsk_umem_consume_tx_virtual.

2018-12-21 Thread William Tu
On Thu, Dec 20, 2018 at 11:48 AM Björn Töpel wrote: > > Den ons 19 dec. 2018 kl 01:55 skrev William Tu : > > > > Currently the xsk_umem_consume_tx expects only the physical NICs so > > the api returns a dma address. This patch introduce the new function > > to return the virtual address, when XSK

Re: [PATCH] net: 80003es2lan: fix a missing check of read failure

2018-12-21 Thread Jeff Kirsher
On Thu, 2018-12-20 at 15:23 -0600, Kangjie Lu wrote: > When e1000_read_kmrn_reg_80003es2lan() fails, "kum_reg_data" is > uninitialized and may contain random value. However, it is further > used in the following execution, which will lead to undefined > behaviors. > The fix checks the failure of e1

Re: [PATCH rdma-next 0/2] Allocate the per-port Q counter

2018-12-21 Thread Jason Gunthorpe
On Sun, Dec 09, 2018 at 12:52:34PM +0200, Leon Romanovsky wrote: > From: Leon Romanovsky > > Hi > > See commit message for the patch description. > > Thanks > > Leon Romanovsky (1): > net/mlx5: Add shared Q counter bits > > Yishai Hadas (1): > IB/mlx5: Allocate the per-port Q counter shar

Re: [PATCH 1/1] Fix qmap header retrieval in qmimux_rx_fixup

2018-12-21 Thread David Miller
From: Daniele Palmas Date: Fri, 21 Dec 2018 13:07:23 +0100 > This patch fixes qmap header retrieval when modem is configured for > dl data aggregation. > > Signed-off-by: Daniele Palmas Applied, thanks.

Re: [PATCH v2 bpf-next 3/4] bpf: Make more use of 'any' alignment in test_verifier.c

2018-12-21 Thread Eric Dumazet
On 11/30/2018 09:08 PM, David Miller wrote: > > Use F_NEEDS_EFFICIENT_UNALIGNED_ACCESS in more tests where the > expected result is REJECT. > > Signed-off-by: David S. Miller > --- > tools/testing/selftests/bpf/test_verifier.c | 44 > + > 1 file changed, 44 inser

Re: qmi_wwan: Add support for Fibocom NL678 series

2018-12-21 Thread David Miller
From: Jörgen Storvist Date: Fri, 21 Dec 2018 15:38:52 +0100 > Added support for Fibocom NL678 series cellular module QMI interface. > Using QMI_QUIRK_SET_DTR required for Qualcomm MDM9x40 series chipsets. > > Signed-off-by: Jörgen Storvist Applied.

Re: [PATCH net-next] tls: Do not call sk_memcopy_from_iter with zero length

2018-12-21 Thread David Miller
From: Vakul Garg Date: Fri, 21 Dec 2018 17:41:47 + > The variable 'ret' is already set to the return value of > tls_clone_plaintext_msg(). In case try_to_copy != 0, the value of > 'ret' is overwritten with return value of > sk_msg_memcopy_from_iter(). In case try_to_copy == 0, the value of

Re: [PATCH net-next v2 0/3] net: skb extension follow-ups

2018-12-21 Thread David Miller
From: Paolo Abeni Date: Fri, 21 Dec 2018 19:03:12 +0100 > This series includes some follow-up for the recently added skb extension. > The first patch addresses an unlikely race while adding skb extensions, > and the following two are just minor code clean-up. > > v1 -> v2: > - be sure to flag t

Re: [PATCH net-next v2 3/3] net: minor cleanup in skb_ext_add()

2018-12-21 Thread Florian Westphal
Paolo Abeni wrote: > When the extension to be added is already present, the only > skb field we may need to update is 'extensions': we can reorder > the code and avoid a branch. Thanks Paolo. Acked-by: Florian Westphal

[PATCH net-next v2 3/3] net: minor cleanup in skb_ext_add()

2018-12-21 Thread Paolo Abeni
When the extension to be added is already present, the only skb field we may need to update is 'extensions': we can reorder the code and avoid a branch. v1 -> v2: - be sure to flag the newly added extension as active Signed-off-by: Paolo Abeni --- net/core/skbuff.c | 7 ++- 1 file changed,

[PATCH net-next v2 2/3] net: drop the unused helper skb_ext_get()

2018-12-21 Thread Paolo Abeni
Such helper is currently unused, and skb extension users are better off using skb_ext_add()/skb_ext_del(). So let's drop it. Signed-off-by: Paolo Abeni Acked-by: Florian Westphal --- include/linux/skbuff.h | 11 --- 1 file changed, 11 deletions(-) diff --git a/include/linux/skbuff.h b/

[PATCH net-next v2 1/3] net: fix possible user-after-free in skb_ext_add()

2018-12-21 Thread Paolo Abeni
On cow we can free the old extension: we must avoid dereferencing such extension after skb_ext_maybe_cow(). Since 'new' contents are always equal to 'old' after the copy, we can fix the above accessing the relevant data using 'new'. Fixes: df5042f4c5b9 ("sk_buff: add skb extension infrastructure")

[PATCH net-next v2 0/3] net: skb extension follow-ups

2018-12-21 Thread Paolo Abeni
This series includes some follow-up for the recently added skb extension. The first patch addresses an unlikely race while adding skb extensions, and the following two are just minor code clean-up. v1 -> v2: - be sure to flag the newly added extension as active in skb_ext_add() Paolo Abeni (3):

RE: [PATCH net-next] tls: Do not call sk_memcopy_from_iter with zero length

2018-12-21 Thread Vakul Garg
> -Original Message- > From: David Miller > Sent: Friday, December 21, 2018 10:39 PM > To: Vakul Garg > Cc: netdev@vger.kernel.org; bor...@mellanox.com; > avia...@mellanox.com; davejwat...@fb.com; doro...@fb.com > Subject: Re: [PATCH net-next] tls: Do not call sk_memcopy_from_iter with

Re: [PATCH v2 1/4] vmalloc: New flags for safe vfree on special perms

2018-12-21 Thread Ard Biesheuvel
On Fri, 21 Dec 2018 at 18:12, Andy Lutomirski wrote: > > > On Dec 21, 2018, at 9:39 AM, Ard Biesheuvel > > wrote: > > > >> On Wed, 12 Dec 2018 at 03:20, Andy Lutomirski wrote: > >> > >> On Tue, Dec 11, 2018 at 4:12 PM Rick Edgecombe > >> wrote: > >>> > >>> This adds two new flags VM_IMMEDIATE_

Re: [PATCH net] ipv6: tunnels: fix two use-after-free

2018-12-21 Thread David Miller
From: Eric Dumazet Date: Fri, 21 Dec 2018 07:47:51 -0800 > xfrm6_policy_check() might have re-allocated skb->head, we need > to reload ipv6 header pointer. > > sysbot reported : ... > Fixes: 0d3c703a9d17 ("ipv6: Cleanup IPv6 tunnel receive path") > Fixes: ed1efb2aefbb ("ipv6: Add support for IP

Re: [PATCH net-next] Prevent overflow of sk_msg in sk_msg_clone()

2018-12-21 Thread David Miller
From: John Fastabend Date: Fri, 21 Dec 2018 08:19:36 -0800 > On 12/21/18 7:55 AM, Vakul Garg wrote: >> Fixed function sk_msg_clone() to prevent overflow of 'dst' while adding >> pages in scatterlist entries. The overflow of 'dst' causes crash in kernel >> tls module while doing record encryption.

Re: [PATCH v2 1/4] vmalloc: New flags for safe vfree on special perms

2018-12-21 Thread Andy Lutomirski
> On Dec 21, 2018, at 9:39 AM, Ard Biesheuvel wrote: > >> On Wed, 12 Dec 2018 at 03:20, Andy Lutomirski wrote: >> >> On Tue, Dec 11, 2018 at 4:12 PM Rick Edgecombe >> wrote: >>> >>> This adds two new flags VM_IMMEDIATE_UNMAP and VM_HAS_SPECIAL_PERMS, for >>> enabling vfree operations to immediat

Re: [PATCH net] packet: validate address length

2018-12-21 Thread David Miller
From: Willem de Bruijn Date: Fri, 21 Dec 2018 12:06:59 -0500 > From: Willem de Bruijn > > Packet sockets with SOCK_DGRAM may pass an address for use in > dev_hard_header. Ensure that it is of sufficient length. > > Reported-by: syzbot > Signed-off-by: Willem de Bruijn Applied and queued up

Re: [PATCH net-next] tls: Do not call sk_memcopy_from_iter with zero length

2018-12-21 Thread David Miller
From: Vakul Garg Date: Fri, 21 Dec 2018 15:16:52 + > @@ -943,10 +943,12 @@ int tls_sw_sendmsg(struct sock *sk, struct msghdr *msg, > size_t size) > tls_ctx->tx.overhead_size); > } > > - ret = sk_msg_memcopy_from_iter(sk, &msg->msg

Re: [PATCH net-next 0/4] bridge: implement Multicast Router Discovery (RFC4286)

2018-12-21 Thread David Miller
From: Linus Lüssing Date: Fri, 21 Dec 2018 16:15:07 +0100 > This patchset adds initial Multicast Router Discovery support to > the Linux bridge (RFC4286). With MRD it is possible to detect multicast > routers and mark bridge ports and forward multicast packets to such routers > accordingly. ...

[PATCH net] packet: validate address length

2018-12-21 Thread Willem de Bruijn
From: Willem de Bruijn Packet sockets with SOCK_DGRAM may pass an address for use in dev_hard_header. Ensure that it is of sufficient length. Reported-by: syzbot Signed-off-by: Willem de Bruijn --- net/packet/af_packet.c | 4 1 file changed, 4 insertions(+) diff --git a/net/packet/af_pa

Re: [PATCH v2] net: mvneta: add basic XDP_DROP support

2018-12-21 Thread David Miller
From: Domagoj Pintaric Date: Fri, 21 Dec 2018 14:22:23 +0100 > Add initial mvneta XDP support for hardware buffer management enabled > devices only. > > Signed-off-by: Domagoj Pintaric > CC: Luka Perkov > CC: Thomas Petazzoni > CC: David S. Miller > --- > v2: > - fixed unused value warning >

Re: [PATCH] net: netxen: fix a missing check and an uninitialized use

2018-12-21 Thread David Miller
From: Kangjie Lu Date: Fri, 21 Dec 2018 00:22:32 -0600 > When netxen_rom_fast_read() fails, "bios" is left uninitialized and may > contain random value, thus should not be used. > > The fix ensures that if netxen_rom_fast_read() fails, we return "-EIO". > > Signed-off-by: Kangjie Lu Applied,

Re: [PATCH rdma-next 0/5] Cleanup of CONFIG_INFINIBAND_ON_DEMAND_PAGING usage

2018-12-21 Thread Jason Gunthorpe
On Fri, Dec 21, 2018 at 03:59:54PM +0200, Leon Romanovsky wrote: > > diff --git a/drivers/infiniband/core/umem.c b/drivers/infiniband/core/umem.c > > index c6144df47ea47e..c2615b6bb68841 100644 > > +++ b/drivers/infiniband/core/umem.c > > @@ -95,6 +95,9 @@ struct ib_umem *ib_umem_get(struct ib_uco

Re: [PATCH net-next] bpf: fix segfault in test_verifier selftest

2018-12-21 Thread David Miller
From: Daniel Borkmann Date: Fri, 21 Dec 2018 14:04:46 +0100 > Minor fallout from merge resolution, test_verifier was segfaulting > because the REJECT result was correct, but errstr was NULL. Properly > fix it as in 339bbff2d6e0. > > Fixes: 339bbff2d6e0 ("Merge > git://git.kernel.org/pub/scm/lin

Re: [PATCH net-next 0/3] net: skb extension follow-ups

2018-12-21 Thread David Miller
From: Paolo Abeni Date: Fri, 21 Dec 2018 13:09:34 +0100 > On Thu, 2018-12-20 at 16:51 -0800, David Miller wrote: >> From: Paolo Abeni >> Date: Thu, 20 Dec 2018 19:38:15 +0100 >> >> > This series includes some follow-up for the recently added skb extension. >> > The first patch addresses an unli

Re: [PATCH v2 1/4] vmalloc: New flags for safe vfree on special perms

2018-12-21 Thread Ard Biesheuvel
On Wed, 12 Dec 2018 at 03:20, Andy Lutomirski wrote: > > On Tue, Dec 11, 2018 at 4:12 PM Rick Edgecombe > wrote: > > > > This adds two new flags VM_IMMEDIATE_UNMAP and VM_HAS_SPECIAL_PERMS, for > > enabling vfree operations to immediately clear executable TLB entries to > > freed > > pages, and

Re: [RFC] AF_PACKET transport_offset fix

2018-12-21 Thread Willem de Bruijn
On Fri, Dec 21, 2018 at 10:24 AM Maxim Mikityanskiy wrote: > > Hi everyone, > > Currently, sockets created as socket(AF_PACKET, SOCK_RAW, 0) have a problem: > skb->transport_header is set to an incorrect value. In short, packet_snd() > function calls skb_probe_transport_header() while skb->protoco

Re: [PATCH net-next] Prevent overflow of sk_msg in sk_msg_clone()

2018-12-21 Thread John Fastabend
On 12/21/18 7:55 AM, Vakul Garg wrote: > Fixed function sk_msg_clone() to prevent overflow of 'dst' while adding > pages in scatterlist entries. The overflow of 'dst' causes crash in kernel > tls module while doing record encryption. > > Crash fixed by this patch. > > [ 78.796119] Unable to han

Re: net-next is CLOSED

2018-12-21 Thread David Miller
From: Saeed Mahameed Date: Fri, 21 Dec 2018 07:37:29 + > On Thu, 2018-12-20 at 23:15 -0800, David Miller wrote: >> Please keep it to bug fixes. >> >> Thank you for your cooperation. > > What happens to a series that i sent 10 minutes before this email, but > for some reason it still doesn't

Re: [PATCH] sunrpc: convert to DEFINE_SHOW_ATTRIBUTE

2018-12-21 Thread Frank Lee
Please igonre this one. Thanks

[RESNED] sunrpc: convert to DEFINE_SHOW_ATTRIBUTE

2018-12-21 Thread Yangtao Li
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Yangtao Li --- net/sunrpc/rpc_pipe.c | 19 +++ 1 file changed, 3 insertions(+), 16 deletions(-) diff --git a/net/sunrpc/rpc_pipe.c b/net/sunrpc/rpc_pipe.c index 4fda18d47e2c..69663681bf9d 100644 --- a/net/sunrp

[PATCH net-next] Prevent overflow of sk_msg in sk_msg_clone()

2018-12-21 Thread Vakul Garg
Fixed function sk_msg_clone() to prevent overflow of 'dst' while adding pages in scatterlist entries. The overflow of 'dst' causes crash in kernel tls module while doing record encryption. Crash fixed by this patch. [ 78.796119] Unable to handle kernel NULL pointer dereference at virtual addre

[PATCH net] ipv6: tunnels: fix two use-after-free

2018-12-21 Thread Eric Dumazet
xfrm6_policy_check() might have re-allocated skb->head, we need to reload ipv6 header pointer. sysbot reported : BUG: KASAN: use-after-free in __ipv6_addr_type+0x302/0x32f net/ipv6/addrconf_core.c:40 Read of size 4 at addr 888191b8cb70 by task syz-executor2/1304 CPU: 0 PID: 1304 Comm: syz-e

Re: [pull request][net-next 0/9] Mellanox, mlx5 XDP TX 100 Million packet per second

2018-12-21 Thread Jesper Dangaard Brouer
On Thu, 20 Dec 2018 23:06:38 -0800 Saeed Mahameed wrote: > XDP_TX: > We see a huge gain on single port ConnectX-5, and reach the 100 Mpps > milestone. > * Single-port HCA: > Before: 70 Mpps > After: 100 Mpps (+42.8%) Great, this confirm that we were hitting a PCIe limit in our XD

Re: [PATCH net-next 0/4] bridge: implement Multicast Router Discovery (RFC4286)

2018-12-21 Thread Nikolay Aleksandrov
On 12/21/18 5:15 PM, Linus Lüssing wrote: > Hi, > > This patchset adds initial Multicast Router Discovery support to > the Linux bridge (RFC4286). With MRD it is possible to detect multicast > routers and mark bridge ports and forward multicast packets to such routers > accordingly. > > So far, m

Explaining the XDP page-requirement (Was: [PATCH v2 net-next 0/8] dpaa2-eth: Introduce XDP support)

2018-12-21 Thread Jesper Dangaard Brouer
On Fri, 7 Dec 2018 18:07:49 + Ioana Ciocoi Radulescu wrote: > Thanks a lot for the info, will look into this. Do you have any > pointers as to why the full page restriction exists in the first > place? Sorry if it's a dumb question, but I haven't found details on > this and I'd really like to

[PATCH net-next] tls: Do not call sk_memcopy_from_iter with zero length

2018-12-21 Thread Vakul Garg
In some conditions e.g. when tls_clone_plaintext_msg() returns -ENOSPC, the number of bytes to be copied using subsequent function sk_msg_memcopy_from_iter() becomes zero. This causes function sk_msg_memcopy_from_iter() to fail which in turn causes tls_sw_sendmsg() to return failure. To prevent it,

Re: A weird problem of Realtek r8168 after resume from S3

2018-12-21 Thread Chris Chiu
On Fri, Dec 21, 2018 at 3:22 AM Heiner Kallweit wrote: > > On 20.12.2018 10:43, Chris Chiu wrote: > > On Thu, Dec 20, 2018 at 3:41 AM Heiner Kallweit > > wrote: > >> > >> On 19.12.2018 16:32, Chris Chiu wrote: > >>> On Wed, Dec 19, 2018 at 4:28 AM Heiner Kallweit > >>> wrote: > > On

[PATCH net-next 2/4] bridge: simplify ip_mc_check_igmp() and ipv6_mc_check_mld() internals

2018-12-21 Thread Linus Lüssing
With this patch the internal use of the skb_trimmed is reduced to the ICMPv6/IGMP checksum verification. And for the length checks the newly introduced helper functions are used instead of calculating and checking with skb->len directly. These changes should hopefully make it easier to verify that

[PATCH net-next 0/4] bridge: implement Multicast Router Discovery (RFC4286)

2018-12-21 Thread Linus Lüssing
Hi, This patchset adds initial Multicast Router Discovery support to the Linux bridge (RFC4286). With MRD it is possible to detect multicast routers and mark bridge ports and forward multicast packets to such routers accordingly. So far, multicast routers are detected via IGMP/MLD queries and PIM

[PATCH net-next 1/4] bridge: simplify ip_mc_check_igmp() and ipv6_mc_check_mld() calls

2018-12-21 Thread Linus Lüssing
This patch refactors ip_mc_check_igmp(), ipv6_mc_check_mld() and their callers (more precisely, the Linux bridge) to not rely on the skb_trimmed parameter anymore. An skb with its tail trimmed to the IP packet length was initially introduced for the following three reasons: 1) To be able to verif

[PATCH net-next 3/4] bridge: join all-snoopers multicast address

2018-12-21 Thread Linus Lüssing
Next to snooping IGMP/MLD queries RFC4541, section 2.1.1.a) recommends to snoop multicast router advertisements to detect multicast routers. Multicast router advertisements are sent to an "all-snoopers" multicast address. To be able to receive them reliably, we need to join this group. Otherwise

[PATCH net-next 4/4] bridge: Snoop Multicast Router Advertisements

2018-12-21 Thread Linus Lüssing
When multiple multicast routers are present in a broadcast domain then only one of them will be detectable via IGMP/MLD query snooping. The multicast router with the lowest IP address will become the selected and active querier while all other multicast routers will then refrain from sending querie

Re: [PATCH bpf-next v2] libbpf: Show supported ELF section names on when failed to guess a prog/attach type

2018-12-21 Thread Quentin Monnet
2018-12-21 22:22 UTC+0900 ~ Taeung Song > We need to let users check their wrong ELF section name > with proper ELF section names when failed to get a prog/attach type from it. > Because users can't realize libbpf guess prog/attach types from > given ELF section names. > For example, when a 'cgrou

Re: 4.20-rc6: WARNING: CPU: 30 PID: 197360 at net/core/flow_dissector.c:764 __skb_flow_dissect

2018-12-21 Thread Willem de Bruijn
On Fri, Dec 21, 2018 at 1:45 AM Christian Borntraeger wrote: > > > > On 20.12.2018 18:23, Willem de Bruijn wrote: > > On Thu, Dec 20, 2018 at 11:17 AM Ido Schimmel wrote: > >> > >> On Thu, Dec 20, 2018 at 03:09:22PM +0100, Christian Borntraeger wrote: > >>> On 20.12.2018 10:12, Ido Schimmel wrote

Re: [PATCH net-next] net: Don't return pfmemalloc pages to the page pool.

2018-12-21 Thread Jesper Dangaard Brouer
On Thu, 20 Dec 2018 14:11:35 -0800 "Jonathan Lemon" wrote: > On 20 Dec 2018, at 5:03, Jesper Dangaard Brouer wrote: > [...] > > I don't like adding this in the hot-path. Instead we could move this > > to the page alloc slow-path, and reject allocating pages with > > pgmemalloc in the first pl

[PATCH] soc: fsl: qbman: avoid race in clearing QMan interrupt

2018-12-21 Thread Madalin Bucur
By clearing all interrupt sources, not only those that already occurred, the existing code may acknowledge by mistake interrupts that occurred after the code checks for them. Signed-off-by: Madalin Bucur Signed-off-by: Roy Pledge --- drivers/soc/fsl/qbman/qman.c | 9 + 1 file changed, 5

qmi_wwan: Add support for Fibocom NL678 series

2018-12-21 Thread Jörgen Storvist
Added support for Fibocom NL678 series cellular module QMI interface. Using QMI_QUIRK_SET_DTR required for Qualcomm MDM9x40 series chipsets. Signed-off-by: Jörgen Storvist --- qmicli -d /dev/cdc-wdm0 -p --dms-get-manufacturer [/dev/cdc-wdm0] Device manufacturer retrieved: Manufacturer: '

Re: [PATCH rdma-next 0/5] Cleanup of CONFIG_INFINIBAND_ON_DEMAND_PAGING usage

2018-12-21 Thread Leon Romanovsky
On Thu, Dec 20, 2018 at 08:32:35PM -0700, Jason Gunthorpe wrote: > On Thu, Dec 20, 2018 at 11:23:13AM +0200, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > Hi, > > > > As a followup to Jason's request to rethink > > CONFIG_INFINIBAND_ON_DEMAND_PAGING > > usage, this series cleans mlx5_i

[PATCH bpf-next v2] libbpf: Show supported ELF section names on when failed to guess a prog/attach type

2018-12-21 Thread Taeung Song
We need to let users check their wrong ELF section name with proper ELF section names when failed to get a prog/attach type from it. Because users can't realize libbpf guess prog/attach types from given ELF section names. For example, when a 'cgroup' section name of a BPF program is used, Before:

[PATCH v2] net: mvneta: add basic XDP_DROP support

2018-12-21 Thread Domagoj Pintaric
Add initial mvneta XDP support for hardware buffer management enabled devices only. Signed-off-by: Domagoj Pintaric CC: Luka Perkov CC: Thomas Petazzoni CC: David S. Miller --- v2: - fixed unused value warning - added additional hardware buffer management check --- drivers/net/ethernet/marve

[PATCH net-next] bpf: fix segfault in test_verifier selftest

2018-12-21 Thread Daniel Borkmann
Minor fallout from merge resolution, test_verifier was segfaulting because the REJECT result was correct, but errstr was NULL. Properly fix it as in 339bbff2d6e0. Fixes: 339bbff2d6e0 ("Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next") Signed-off-by: Daniel Borkmann --- [ Hi Dav

Re: [PATCH iproute2 1/1] testsuite: Fix colorize

2018-12-21 Thread Petr Vorel
Hi Stephen, > On Tue, 18 Dec 2018 20:29:04 +0100 > Petr Vorel wrote: > > bash and dash require for escape sequence to use 'echo -e' or printf > > (but working on zsh). Choosing printf as it's implementation is IMHO > > more portable than echo implementations. > > dash also require to use \033[0;

Re: [PATCH 1/1] Fix qmap header retrieval in qmimux_rx_fixup

2018-12-21 Thread Daniele Palmas
Il giorno ven 21 dic 2018 alle ore 13:33 Bjørn Mork ha scritto: > > Daniele Palmas writes: > > > This patch fixes qmap header retrieval when modem is configured for > > dl data aggregation. > > > > Signed-off-by: Daniele Palmas > > --- > > Hi Bjørn and all, > > > > I'm facing an issue when using

Re: [PATCH v1 net-next] net: dsa: microchip: add KSZ9477 I2C driver

2018-12-21 Thread Marek Vasut
On 12/21/2018 01:23 PM, Dan Carpenter wrote: > On Fri, Dec 21, 2018 at 01:14:51PM +0100, Marek Vasut wrote: >> On 12/21/2018 10:29 AM, Dan Carpenter wrote: >>> On Wed, Dec 19, 2018 at 10:50:16PM +, tristram...@microchip.com wrote: So if I change the new code, should I go back to corre

Re: [PATCH 1/1] Fix qmap header retrieval in qmimux_rx_fixup

2018-12-21 Thread Bjørn Mork
Daniele Palmas writes: > This patch fixes qmap header retrieval when modem is configured for > dl data aggregation. > > Signed-off-by: Daniele Palmas > --- > Hi Bjørn and all, > > I'm facing an issue when using qmi_wwan with modem configured with dl data > aggregation and qmap multiplexing, e.g

Re: [PATCH v1 net-next] net: dsa: microchip: add KSZ9477 I2C driver

2018-12-21 Thread Dan Carpenter
On Fri, Dec 21, 2018 at 01:14:51PM +0100, Marek Vasut wrote: > On 12/21/2018 10:29 AM, Dan Carpenter wrote: > > On Wed, Dec 19, 2018 at 10:50:16PM +, tristram...@microchip.com wrote: > >> > >> So if I change the new code, should I go back to correct the old code? > > > > Other operating system

Re: [PATCH v1 net-next] net: dsa: microchip: add KSZ9477 I2C driver

2018-12-21 Thread Marek Vasut
On 12/21/2018 10:29 AM, Dan Carpenter wrote: > On Wed, Dec 19, 2018 at 10:50:16PM +, tristram...@microchip.com wrote: >> >> So if I change the new code, should I go back to correct the old code? > > Other operating systems would worry about breaking code which is working > fine, but re-writing

Re: [PATCH net-next 0/3] net: skb extension follow-ups

2018-12-21 Thread Paolo Abeni
On Thu, 2018-12-20 at 16:51 -0800, David Miller wrote: > From: Paolo Abeni > Date: Thu, 20 Dec 2018 19:38:15 +0100 > > > This series includes some follow-up for the recently added skb extension. > > The first patch addresses an unlikely race while adding skb extensions, > > and the following two

[PATCH 1/1] Fix qmap header retrieval in qmimux_rx_fixup

2018-12-21 Thread Daniele Palmas
This patch fixes qmap header retrieval when modem is configured for dl data aggregation. Signed-off-by: Daniele Palmas --- Hi Bjørn and all, I'm facing an issue when using qmi_wwan with modem configured with dl data aggregation and qmap multiplexing, e.g. something like root@L2122:~# qmicli -d

[PATCH] netfilter: x_tables: add xt_tunnel match

2018-12-21 Thread wenxu
From: wenxu This patch allows us to match on the tunnel metadata that is available of the packet. We can use this to validate if the packet comes from/goes to tunnel and the corresponding tunnel ID in the iptables. Signed-off-by: wenxu --- include/uapi/linux/netfilter/xt_tunnel.h | 13 +++

Re: dsa: how to set external PHY address of slave MDIO bus

2018-12-21 Thread Andrew Lunn
On Thu, Dec 20, 2018 at 08:26:56PM -0500, John Rama wrote: > Hi, Guys, > > I have one question. I'm working following configuration, and implementing a > device driver. > Basically, port 1-7 is working fine. I'm now having problem on port8. > > - System

[PATCH bpf-next] selftests/bpf: fix error printing in test_devmap()

2018-12-21 Thread Xiaozhou Liu
As a simple fix, just print the correct map type. Signed-off-by: Xiaozhou Liu --- tools/testing/selftests/bpf/test_maps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/bpf/test_maps.c b/tools/testing/selftests/bpf/test_maps.c index 9c79ee017df3..e2b

Re: [PATCH v1 net-next] net: dsa: microchip: add KSZ9477 I2C driver

2018-12-21 Thread Dan Carpenter
On Wed, Dec 19, 2018 at 10:50:16PM +, tristram...@microchip.com wrote: > > So if I change the new code, should I go back to correct the old code? Other operating systems would worry about breaking code which is working fine, but re-writing ancient code is The Linux Way. regards, dan carpenter

Re: [RFT][PATCH 4/7] net: dsa: microchip: Remove dev->txbuf

2018-12-21 Thread Andrew Lunn
On Fri, Dec 21, 2018 at 01:02:23AM +, tristram...@microchip.com wrote: > > On 12/20/2018 10:41 AM, Andrew Lunn wrote: > > > On Wed, Dec 19, 2018 at 05:20:33PM -0800, Florian Fainelli wrote: > > >> On 12/19/18 5:06 PM, Marek Vasut wrote: > > >>> Previous patches unconver that ksz_spi_write() is

RE: [PATCH mlx5-next] IB/mlx5: Prevent allocating UMEM and UCTX as some general object

2018-12-21 Thread Achiad Shochat
Great, thanks -Original Message- From: Jason Gunthorpe Sent: Thursday, December 20, 2018 11:02 PM To: Leon Romanovsky Cc: Doug Ledford ; Yishai Hadas ; RDMA mailing list ; Achiad Shochat ; Saeed Mahameed ; linux-netdev ; Leon Romanovsky Subject: Re: [PATCH mlx5-next] IB/mlx5: Preve

general protection fault in ip6_route_output_flags

2018-12-21 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:a9cd3439e3c6 neighbor: Use nda_policy for validating attri.. git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=143d3a0d40 kernel config: https://syzkaller.appspot.com/x/.config?x=1f6442435a55ea09 da

Re: PROBLEM: xfrm: XFRMINSTATEMODEERROR for transport mode IPsec SA when IP VTI is active

2018-12-21 Thread Steffen Klassert
On Sat, Dec 15, 2018 at 07:02:41PM +0800, Lemon Lam wrote: > Hello, > > I recently joined DN42 with my virtual private servers, and decided to use > GRE > and IPsec to form interconnects between servers. > I can use GRE over IPsec VTI tunnel fine, but when I simplified some tunnels > down to GRE o

BUG: unable to handle kernel paging request in iptunnel_xmit

2018-12-21 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:d84e7bc0595a rds: Fix warning. git tree: net console output: https://syzkaller.appspot.com/x/log.txt?x=1461543540 kernel config: https://syzkaller.appspot.com/x/.config?x=c8970c89a0efbb23 dashboard link: https://syzkaller.app

Re: [bpf-next RFCv2 2/3] veth: support AF_XDP.

2018-12-21 Thread Björn Töpel
Den ons 19 dec. 2018 kl 01:55 skrev William Tu : > > The patch adds support for AF_XDP async xmit. Users can use > AF_XDP on both side of the veth and get better performance, with > the cost of ksoftirqd doing the xmit. The veth_xsk_async_xmit > simply kicks the napi function, veth_poll, to run,

[RFC] AF_PACKET transport_offset fix

2018-12-21 Thread Maxim Mikityanskiy
Hi everyone, Currently, sockets created as socket(AF_PACKET, SOCK_RAW, 0) have a problem: skb->transport_header is set to an incorrect value. In short, packet_snd() function calls skb_probe_transport_header() while skb->protocol == 0 (zero is taken from the third parameter of the socket() call), w

[PATCH iproute2 v3] iproute: Set ip/ip6 lwtunnel flags

2018-12-21 Thread wenxu
From: wenxu ip l add dev tun type gretap external ip r a 10.0.0.1 encap ip dst 192.168.152.171 id 1000 dev gretap For gretap example when the command set the id but don't set the TUNNEL_KEY flags. There is no key field in the send packet User can set flags with key, csum, seq ip r a 10.0.0.1 en

[net-next 8/9] net/mlx5e: XDP, Support Enhanced Multi-Packet TX WQE

2018-12-21 Thread Saeed Mahameed
From: Tariq Toukan Add support for the HW feature of multi-packet WQE in XDP xmit flow. The conventional TX descriptor (WQE, Work Queue Element) serves a single packet. Our HW has support for multi-packet WQE (MPWQE) in which a single descriptor serves multiple TX packets. This reduces both the

[net-next 6/9] net/mlx5e: XDP, Maintain a FIFO structure for xdp_info instances

2018-12-21 Thread Saeed Mahameed
From: Tariq Toukan This provides infrastructure to have multiple xdp_info instances for the same consumer index. Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 13 ++-- .../net/ethernet/mellanox/mlx5/core/en/xdp.c | 32 ++

[net-next 7/9] net/mlx5e: XDP, Add array for WQE info descriptors

2018-12-21 Thread Saeed Mahameed
From: Tariq Toukan Each xdp_wqe_info instance describes the number of data-segments and WQEBBs of the WQE. This is useful for a downstream patch that adds support for Multi-Packet TX WQE feature. Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/

[net-next 9/9] net/mlx5e: XDP, Add user control for XDP TX MPWQE feature

2018-12-21 Thread Saeed Mahameed
From: Tariq Toukan Add ethtool private flag 'xdp_tx_mpwqe' to control the feature from userspace. Feature is set ON by default, if supported. Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 1 + .../ethernet/mellanox/mlx5/core/en_

[net-next 3/9] net/mlx5e: XDP, Change the XDP SQ redirect indication

2018-12-21 Thread Saeed Mahameed
From: Tariq Toukan Do not maintain an SQ state bit to indicate whether an XDP SQ serves redirect operations. Instead, rely on the fact that such an XDP SQ doesn't reside in an RQ instance, while the others do. This info is not known to the XDP SQ functions themselves, and they rely on their call

[net-next 2/9] net/mlx5e: XDP, Precede XDP-related operations in RQ poll by a loaded program check

2018-12-21 Thread Saeed Mahameed
From: Tariq Toukan At the end of the RQ polling loop, some XDP-related operations might be required. Before checking them one by one, check if an XDP program is even loaded. Combine all the checks and operations in a single function in xdp files. This saves unnecessary checks for non-XDP flows.

[net-next 4/9] net/mlx5e: XDP, Warn upon polling an error CQE

2018-12-21 Thread Saeed Mahameed
From: Tariq Toukan Do not ignore the CQE opcode. This helps expose issues and debug them. Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/

  1   2   >