Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/wireless/ath/wil6210/main.c: In function '_wil6210_disconnect':
drivers/net/wireless/ath/wil6210/main.c:407:23: warning:
variable 'wdev' set but not used [-Wunused-but-set-variable]
It never used since commit ("e1b43407c034 wil6210: refa
On Tue, 04 Dec 2018 21:13:27 -0800 (PST), David Miller wrote:
> From: Jakub Kicinski
> Date: Mon, 3 Dec 2018 17:43:28 -0800
>
> > Documentation/networking/ is full of cryptically named files with
> > driver documentation. This makes finding interesting information
> > at a glance really hard.
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/wireless/broadcom/b43/phy_n.c: In function
'b43_nphy_op_recalc_txpower':
drivers/net/wireless/broadcom/b43/phy_n.c:5898:7: warning:
variable 'tx_pwr_state' set but not used [-Wunused-but-set-variable]
drivers/net/wireless/broadcom/b43/p
On 2018/12/04 11:52, Nicolas Belouin wrote:
> On 03/12 07:59, Eric Dumazet wrote:
> >
> >
> > On 12/03/2018 07:20 AM, Nicolas Belouin wrote:
> > > Hi,
> > > I ran into a panic while adding an interface to a bridge with a vxlan
> > > interface already attached to it, as it seems related mtu=9000.
This function can dynamically change total_nr_elements of a flex_array,
and keep the old elements of the same memory. Returns 0 if it succeeds.
Note that it won't do any memory allocation or shrinking for elements,
which should be only done by flex_array_prealloc and flex_array_shrink.
Suggested-
Now when doing 4-shakehand or adding new streams, sctp has to allocate
new memory for asoc->stream and copy the old stream's information from
the old asoc->stream to the new one. It also cause the stream pointers
to change, by which a panic was even caused due to stream->out_curr's
change.
To fix
This patch is to separate the base data memory from struct flex_array and
save it into a page. With this change, total_nr_elements of a flex_array
can grow or shrink without having the old element's memory changed when
the new size of the flex_arry crosses FLEX_ARRAY_BASE_SIZE, which will
be added
Without the support for the total_nr_elements's growing or shrinking
dynamically, flex_array is not that 'flexible'. Like when users want
to change the size, they have to redo flex_array_alloc and copy all
the elements from the old to the new one. The worse thing is every
element's memory gets cha
Hi Jiong,
On 05/12/18 2:25 AM, Jiong Wang wrote:
> This patch implements code-gen for BPF_ALU | BPF_ARSH | BPF_*.
>
> Cc: Naveen N. Rao
> Cc: Sandipan Das
> Signed-off-by: Jiong Wang
> ---
[...]
> diff --git a/arch/powerpc/net/bpf_jit_comp64.c
> b/arch/powerpc/net/bpf_jit_comp64.c
> index 174
From: Aya Levin
Move modify tirs hash functionality (mlx5e_modify_tirs_hash) from
en_ethtool.c to en_main.c. This allows future use of this fuctionality
from en_fs_ethtool.c, while keeping current convention: en_ethtool.c
doesn't have an API. There is no functional change here.
Signed-off-by: A
From: Aya Levin
Refactor mlx5e_build_indir_tir_ctx_hash for better code re-use. TIR
stands for Transport Interface Receive, which is responsible for all
transport related operations on the receive side. Added a
static array with TIR default configuration values. This separates
configuration value
From: Tariq Toukan
Refactor the code of private-flags setter.
Replace consecutive calls to mlx5e_handle_pflag with a loop
that uses a preset set of parameters.
Signed-off-by: Tariq Toukan
Signed-off-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/en.h | 17 ++---
.../ethernet/
From: Aya Levin
Enable user configuration of RX hash fields that are used for traffic
spreading into RX queues. User can change built-in RSS (Receive Side
Scaling) profiles on the following traffic types: UDP4, UDP6, TCP4 and
TCP6. This configuration effects both outer and inner headers. Added
From: Aya Levin
Remove RSS params from params struct under channels, and introduce
a new struct with RSS configuration params under priv struct. There is
no functional change here.
Signed-off-by: Aya Levin
Reviewed-by: Tariq Toukan
Signed-off-by: Saeed Mahameed
---
drivers/net/ethernet/mella
From: Gal Pressman
Remove couple of defines that are no longer used.
Signed-off-by: Gal Pressman
Signed-off-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/en.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en.h
b/drivers/net/eth
tx_pause_storm_warning_events ethtool counter name has a trailing
space, remove it.
Signed-off-by: Saeed Mahameed
Reviewed-by: Eran Ben Elisha
---
drivers/net/ethernet/mellanox/mlx5/core/en_stats.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox
Hi Dave,
The following series is for mlx5e netdevice driver, it adds ethtool
support for RX hash fields configuration and some misc updates, please
see tag log below.
Please pull and let me know if there's any problem.
Thanks,
Saeed.
---
The following changes since commit 55827458e0586b1d4e84
Register devlink_port with devlink and create initial port params
table for bnxt_en. The table consists of a generic parameter:
wake-on-lan: Enables Wake on Lan for this port when magic packet
is received with this port's MAC address using ACPI pattern.
If enabled, the controller asserts a wake pi
This patchset adds support for configuration parameters setting through
devlink_port. Each device registers supported configuration parameters
table.
The user can retrieve data on these parameters by
"devlink port param show" command and can set new value to a
parameter by "devlink port param set
wake-on-lan - Enables Wake on Lan for this port when magic packet
is received with this port's MAC address using ACPI pattern.
If enabled, the controller asserts a wake pin upon reception of
WoL packet. ACPI (Advanced Configuration and Power Interface)
is an industry specification for the efficien
Add notification call for devlink port param set, register and unregister
functions.
Add devlink_port_param_value_changed() function to enable the driver notify
devlink on value change. Driver should use this function after value was
changed on any configuration mode part to driverinit.
Cc: Jiri P
Add support for "driverinit" configuration mode value for devlink_port
configuration parameters. Two additional functions added to help the
driver get/set the value from/to devlink:
devlink_port_param_driverinit_value_set() and
devlink_port_param_driverinit_value_get().
Also, move the common code
Add port param set command to set the value for a parameter.
Value can be set to any of the supported configuration modes.
Cc: Jiri Pirko
Signed-off-by: Vasundhara Volam
---
include/uapi/linux/devlink.h | 1 +
net/core/devlink.c | 41 ++---
2 files
Add port param get command which gets data per parameter.
It also has option to dump the parameters data per port.
Cc: Jiri Pirko
Signed-off-by: Vasundhara Volam
---
include/uapi/linux/devlink.h | 2 +
net/core/devlink.c | 102 ---
2 files cha
Add functions to register and unregister for the driver supported
configuration parameters table per port.
Cc: Jiri Pirko
Signed-off-by: Vasundhara Volam
---
include/net/devlink.h | 29 +++
net/core/devlink.c| 130 ++
2 files changed,
On Sun, Dec 2, 2018 at 4:37 AM Tariq Toukan wrote:
>
> From: Saeed Mahameed
>
> MLX4_EN depends on NETDEVICES, ETHERNET and INET Kconfigs.
> Make sure they are listed in MLX4_EN Kconfig dependencies.
>
> This fixes the following build break:
>
> drivers/net/ethernet/mellanox/mlx4/en_rx.c:582:18:
On Tue, Dec 4, 2018 at 9:06 AM Eric Dumazet wrote:
>
>
>
> On 12/04/2018 08:59 AM, David Laight wrote:
> > Where does 68 come from?
>
> Min IPv4 MTU per RFC791
>
What's wrong with using IPV4_MIN_MTU instead of 68
even in just comment?
From: Eric Dumazet
Date: Tue, 4 Dec 2018 07:58:17 -0800
> TCP_NOTSENT_LOWAT socket option or sysctl was added in linux-3.12
> as a step to enable bigger tcp sndbuf limits.
>
> It works reasonably well, but the following happens :
>
> Once the limit is reached, TCP stack generates
> an [E]POLLO
From: Baruch Siach
Date: Tue, 4 Dec 2018 16:03:53 +0200
> The .validate phylink callback should empty the supported bitmap when
> the interface mode is invalid.
>
> Cc: Maxime Chevallier
> Cc: Antoine Tenart
> Reported-by: Russell King
> Signed-off-by: Baruch Siach
Applied.
From: Baruch Siach
Date: Tue, 4 Dec 2018 16:03:52 +0200
> The mvpp2_phylink_validate() relies on the interface field of
> phylink_link_state to determine valid link modes. However, when called
> from phylink_sfp_module_insert() this field in not initialized. The
> default switch case then exclud
From: Jakub Kicinski
Date: Mon, 3 Dec 2018 17:43:28 -0800
> Documentation/networking/ is full of cryptically named files with
> driver documentation. This makes finding interesting information
> at a glance really hard. Move all those files into a directory
> called device_drivers (since not a
From: Felix Jia
Date: Mon, 3 Dec 2018 16:39:31 +1300
> +int
> +ip6_get_addrport(struct iphdr *iph, __be32 *saddr4, __be32 *daddr4,
> + __be16 *sport4, __be16 *dport4, __u8 *proto, int *icmperr)
> +{
This looks like something the flow dissector can do alreayd, please look into
utili
On Tue, Dec 4, 2018 at 6:05 PM Saeed Mahameed wrote:
>
> After the following flow counters API refactoring:
> ("net/mlx5: Use flow counter IDs and not the wrapping cache object")
> flow counters private data structures mlx5_fc_cache and mlx5_fc are
> redundantly exposed in fs_core.h, they have not
On Tue, Dec 4, 2018 at 6:06 PM Saeed Mahameed wrote:
>
> +static inline u8 get_cqe_opcode(struct mlx5_cqe64 *cqe)
Make it const please.
From: Or Gerlitz
Date: Sun, 2 Dec 2018 14:55:19 +0200
> This short series from Adi Nissim allows to support key-less tunnels
> by the tc tunnel key actions, which is needed for some GRE use-cases.
>
> changes from V0:
> - addresses build warning spotted by kbuild, make sure to always init
>
From: Jouke Witteveen
Date: Sat, 1 Dec 2018 17:00:21 +0100
> Make it easy for userspace to respond to acquisition/loss of carrier.
> The uevent is picked up by udev and, on systems with systemd, the
> device unit of the interface announces a configuration reload.
>
> Signed-off-by: Jouke Witteve
From: Nicolas Saenz Julienne
Date: Mon, 3 Dec 2018 13:21:01 +0100
> After getting a reference to the platform device's of_node the probe
> function ends up calling of_find_matching_node() using the node as an
> argument. The function takes care of decreasing the refcount on it. We
> are then inc
From: Eric Dumazet
Date: Tue, 4 Dec 2018 09:40:35 -0800
> kmsan was able to trigger a kernel-infoleak using a gre device [1]
>
> nlmsg_populate_fdb_fill() has a hard coded assumption
> that dev->addr_len is ETH_ALEN, as normally guaranteed
> for ARPHRD_ETHER devices.
>
> A similar issue was fi
From: Colin King
Date: Mon, 3 Dec 2018 17:13:31 +
> From: Colin Ian King
>
> There is a spelling mistake in a DP_NOTICE message, fix it.
>
> Signed-off-by: Colin Ian King
Applied.
If the sequence:
obj = rhashtable_walk_next(iter);
rhashtable_walk_stop(iter);
rhashtable_remove_fast(ht, &obj->head, params);
rhashtable_walk_start(iter);
races with another thread inserting or removing
an object on the same hash chain, a subsequent
rhashtable_walk_next() is not g
On Tue, Nov 27, 2018 at 10:10 PM Cong Wang wrote:
>
> When an ethernet frame is padded to meet the minimum ethernet frame
> size, the padding octets are not covered by the hardware checksum.
> Fortunately the padding octets are ususally zero's, which don't affect
> checksum. However, we have a swi
On Fri, Nov 30, 2018 at 08:49:17AM -0500, Aaron Conole wrote:
>
> While this is one reason to use hash map, I don't think we should use
> this as a reason to exclude development of a data type that may work
> better. After all, if we can do better then we should.
I'm all for improving existing h
On Tue, Dec 4, 2018 at 4:59 PM Saeed Mahameed wrote:
>
> Cong, you are missing some important details, hardware can only parse a
> handful of protocols IP/TCP/UDP some tunneling like vxlan,GRE, etc..
> but for complicated protocols and new generic tunneling protocols,
> which the hardware wasn't b
On Tue, Dec 4, 2018 at 5:06 PM Saeed Mahameed wrote:
>
> Hi Cong, sorry to hear that, i will take your patch evaluate and test
> personally, will do the needed changes and post it later.
Please don't. I am withdrawing my SoB too. To avoid any legal
issues, please speak to a legal expert before yo
On Tue, Dec 4, 2018 at 5:16 PM Saeed Mahameed wrote:
> Please understand that RX data path is really sensitive and we are
> trying to find the optimal fix of any issue here, sorry for any
> inconvenience.
I am sorry for sending out this patch, I am certain that it wastes
a lot of your time.
The
> On Dec 4, 2018, at 5:45 PM, Edgecombe, Rick P
> wrote:
>
> On Tue, 2018-12-04 at 16:53 -0800, Nadav Amit wrote:
>>> On Dec 4, 2018, at 4:29 PM, Edgecombe, Rick P
>>> wrote:
>>>
>>> On Tue, 2018-12-04 at 16:01 -0800, Nadav Amit wrote:
> On Dec 4, 2018, at 3:51 PM, Edgecombe, Rick P <
From: Daniel Jurgens
The function is only used to retrieve CQEs, use the proper type as the
return value.
Signed-off-by: Daniel Jurgens
Signed-off-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/wq.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ne
Hi
This patchset is for mlx5-next shared branch, and will be applied there
once the review is done.
Patches 1,2,3 are trivial improvements to CQE API
1. return CQE pointer instead of void pointer in get_cqe function
2. helper function for retrieving the CQE opcode, used in rdma and netdev
Patch
From: Tariq Toukan
Introduce and use a helper that extracts the opcode
from a CQE (completion queue entry) structure.
Signed-off-by: Tariq Toukan
Signed-off-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 10 +-
drivers/net/ethernet/mellanox/mlx5/core/en_t
From: Tariq Toukan
Use the new helper that extracts the opcode
from a CQE (completion queue entry) structure.
Signed-off-by: Tariq Toukan
Signed-off-by: Saeed Mahameed
---
drivers/infiniband/hw/mlx5/cq.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/infin
After the following flow counters API refactoring:
("net/mlx5: Use flow counter IDs and not the wrapping cache object")
flow counters private data structures mlx5_fc_cache and mlx5_fc are
redundantly exposed in fs_core.h, they have nothing to do with flow
steering core and they are private to fs_co
> On Dec 4, 2018, at 3:52 PM, Edgecombe, Rick P
> wrote:
>
>> On Tue, 2018-12-04 at 12:09 -0800, Andy Lutomirski wrote:
>> On Tue, Dec 4, 2018 at 12:02 PM Edgecombe, Rick P
>> wrote:
>>>
On Tue, 2018-12-04 at 16:03 +, Will Deacon wrote:
On Mon, Dec 03, 2018 at 05:43:11PM -0800
On Tue, 2018-12-04 at 16:53 -0800, Nadav Amit wrote:
> > On Dec 4, 2018, at 4:29 PM, Edgecombe, Rick P
> > wrote:
> >
> > On Tue, 2018-12-04 at 16:01 -0800, Nadav Amit wrote:
> > > > On Dec 4, 2018, at 3:51 PM, Edgecombe, Rick P <
> > > > rick.p.edgeco...@intel.com>
> > > > wrote:
> > > >
> > >
> On Dec 4, 2018, at 5:09 PM, Edgecombe, Rick P
> wrote:
>
> On Tue, 2018-12-04 at 14:48 -0800, Nadav Amit wrote:
>>> On Dec 4, 2018, at 11:48 AM, Andy Lutomirski wrote:
>>>
>>> On Tue, Dec 4, 2018 at 11:45 AM Nadav Amit wrote:
> On Dec 4, 2018, at 10:56 AM, Andy Lutomirski wrote:
>
On Mon, 2018-12-03 at 13:59 +0100, Miroslav Lichvar wrote:
> Read the system time right before and immediately after reading the
> low
> register of the internal timer. This adds support for the
> PTP_SYS_OFFSET_EXTENDED ioctl.
>
> Cc: Richard Cochran
> Cc: Saeed Mahameed
> Signed-off-by: Mirosl
On Tue, 2018-12-04 at 12:21 -0800, Cong Wang wrote:
> On Tue, Dec 4, 2018 at 11:33 AM Saeed Mahameed
> wrote:
> > On Sat, Dec 1, 2018 at 12:38 PM Cong Wang > > wrote:
> > > is_last_ethertype_ip() is used to check IP/IPv6 protocol before
> > > parsing IP/IPv6 headers.
> > >
> > > But __vlan_get_p
On Tue, 2018-12-04 at 14:48 -0800, Nadav Amit wrote:
> > On Dec 4, 2018, at 11:48 AM, Andy Lutomirski wrote:
> >
> > On Tue, Dec 4, 2018 at 11:45 AM Nadav Amit wrote:
> > > > On Dec 4, 2018, at 10:56 AM, Andy Lutomirski wrote:
> > > >
> > > > On Mon, Dec 3, 2018 at 5:43 PM Nadav Amit wrote:
>
Le 30/11/18 à 12:16, Laurent Bigonville a écrit :
Le 10/10/18 à 21:09, Stephen Hemminger a écrit :
On Wed, 10 Oct 2018 03:16:40 +0200
Laurent Bigonville wrote:
Le 9/10/18 à 22:09, Stephen Hemminger a écrit :
On Tue, 9 Oct 2018 19:30:30 +0200
Laurent Bigonville wrote:
Hello,
On my desktop
On Tue, 2018-12-04 at 12:50 -0800, Cong Wang wrote:
> On Tue, Dec 4, 2018 at 11:21 AM Saeed Mahameed
> wrote:
> > we are still working on it.
>
> No, I give up.
>
> Sorry for wasting time. Let's save everyone's time by discarding it!!
> :)
Hi Cong, sorry to hear that, i will take your patch eva
On Tue, 2018-12-04 at 12:35 -0800, Cong Wang wrote:
> On Tue, Dec 4, 2018 at 11:17 AM Saeed Mahameed
> wrote:
> > On Mon, Dec 3, 2018 at 11:52 PM Eric Dumazet
> > wrote:
> > > On Mon, Dec 3, 2018 at 11:30 PM Cong Wang <
> > > xiyou.wangc...@gmail.com> wrote:
> > > > On Mon, Dec 3, 2018 at 11:08 P
> On Dec 4, 2018, at 4:29 PM, Edgecombe, Rick P
> wrote:
>
> On Tue, 2018-12-04 at 16:01 -0800, Nadav Amit wrote:
>>> On Dec 4, 2018, at 3:51 PM, Edgecombe, Rick P
>>> wrote:
>>>
>>> On Tue, 2018-12-04 at 12:36 -0800, Nadav Amit wrote:
> On Dec 4, 2018, at 12:02 PM, Edgecombe, Rick P <
>>>
From: Nikolay Aleksandrov
Date: Wed, 5 Dec 2018 01:45:16 +0200
> On a related note I saw Paul's call_rcu patches hit, so I'll wait for those
> to go in and will rebase on top of them before sending the v3 as the bridge
> change will have a conflict with this set.
They aren't going in via my tree
On Tue, 4 Dec 2018 16:26:05 -0800
Eric Dumazet wrote:
> > + /* skb_push() won't panic if we have room for the unaligned size
> > only */
> > + BUG_ON(skb_headroom(skb) < hh_alen);
> >
>
> What about avoiding the panic and instead call kfree_skb() ?
>
> if (WARN_ON_ONCE(sk
Hi all,
Today's linux-next merge of the net-next tree got a conflict in:
drivers/net/phy/phy_device.c
between commit:
d2a36971ef59 ("net: phy: don't allow __set_phy_supported to add unsupported
modes")
from the net tree and commits:
3c1bcc8614db ("net: ethernet: Convert phydev advertiz
On Tue, 2018-12-04 at 16:01 -0800, Nadav Amit wrote:
> > On Dec 4, 2018, at 3:51 PM, Edgecombe, Rick P
> > wrote:
> >
> > On Tue, 2018-12-04 at 12:36 -0800, Nadav Amit wrote:
> > > > On Dec 4, 2018, at 12:02 PM, Edgecombe, Rick P <
> > > > rick.p.edgeco...@intel.com>
> > > > wrote:
> > > >
> > >
Patch 1/2 fixes a slab out-of-bounds occurring with short SCTP packets over
IPv4 over L2TP over IPv6 on a configuration with relatively low HEADER_MAX.
Patch 2/2 makes sure we panic in neigh_hh_output() instead of silently
writing before the allocated buffer in case the headroom is enough for the
While skb_push() makes the kernel panic if the skb headroom is less than
the unaligned hardware header size in neigh_hh_output(), it will proceed
silently in case we copy more than that because of alignment.
In the case fixed by the previous patch,
"ipv6: Check available headroom in ip6_xmit() eve
Even if we send an IPv6 packet without options, MAX_HEADER might not be
enough to account for the additional headroom required by alignment of
hardware headers.
On a configuration without HYPERV_NET, WLAN, AX25, and with IPV6_TUNNEL,
sending short SCTP packets over IPv4 over L2TP over IPv6, we sta
On Tue, Dec 04, 2018 at 11:49:27AM -0800, Florian Fainelli wrote:
...
I was thinking also about pinned list of vlans to the address, but in
this case this information also has to be synced by members of device
chain,
because it can be modified on any device level and it looks not very
friendly
Hi Jiong,
On Tue, Dec 04, 2018 at 03:55:16PM -0500, Jiong Wang wrote:
> Jitting of BPF_K is supported already, but not BPF_X. This patch complete
> the support for the latter on both MIPS and microMIPS.
>
> Cc: Paul Burton
> Cc: linux-m...@vger.kernel.org
> Signed-off-by: Jiong Wang
> ---
> ar
> On Dec 4, 2018, at 3:51 PM, Edgecombe, Rick P
> wrote:
>
> On Tue, 2018-12-04 at 12:36 -0800, Nadav Amit wrote:
>>> On Dec 4, 2018, at 12:02 PM, Edgecombe, Rick P
>>> wrote:
>>>
>>> On Tue, 2018-12-04 at 16:03 +, Will Deacon wrote:
On Mon, Dec 03, 2018 at 05:43:11PM -0800, Nadav Ami
On Tue, 2018-12-04 at 12:09 -0800, Andy Lutomirski wrote:
> On Tue, Dec 4, 2018 at 12:02 PM Edgecombe, Rick P
> wrote:
> >
> > On Tue, 2018-12-04 at 16:03 +, Will Deacon wrote:
> > > On Mon, Dec 03, 2018 at 05:43:11PM -0800, Nadav Amit wrote:
> > > > > On Nov 27, 2018, at 4:07 PM, Rick Edgeco
On 12/4/18 5:01 PM, Nikolay Aleksandrov wrote:
> Hi,
> The current bridge multicast code uses a custom rhashtable
> implementation which predates the generic rhashtable API. Patch 01
> converts it to use the generic kernel rhashtable which simplifies the
> code a lot and removes duplicated function
On Tue, Dec 04, 2018 at 11:49:27AM -0800, Florian Fainelli wrote:
On 12/4/18 10:57 AM, Ivan Khoronzhuk wrote:
On Mon, Dec 03, 2018 at 03:57:03PM -0800, Florian Fainelli wrote:
On 12/3/18 3:51 PM, Ivan Khoronzhuk wrote:
On Mon, Dec 03, 2018 at 02:17:00PM -0800, Florian Fainelli wrote:
On 12/3/
On 12/04, Song Liu wrote:
> On Mon, Dec 3, 2018 at 3:08 PM Stanislav Fomichev wrote:
> >
> > On 12/03, Song Liu wrote:
> > > On Mon, Dec 3, 2018 at 11:00 AM Stanislav Fomichev
> > > wrote:
> > > >
> > > > The input is packet data, the output is struct bpf_flow_key. This should
> > > > make it ea
> On Dec 4, 2018, at 3:27 PM, Andy Lutomirski wrote:
>
>
>
>
> On Dec 4, 2018, at 2:48 PM, Nadav Amit wrote:
>
>>> On Dec 4, 2018, at 11:48 AM, Andy Lutomirski wrote:
>>>
>>> On Tue, Dec 4, 2018 at 11:45 AM Nadav Amit wrote:
> On Dec 4, 2018, at 10:56 AM, Andy Lutomirski wrote:
>
On 12/04, Song Liu wrote:
> On Mon, Dec 3, 2018 at 8:01 PM Stanislav Fomichev wrote:
> >
> > We want to make sure that the following condition holds:
> > 0 <= nhoff <= thoff <= skb->len
> >
> > BPF program can set out-of-bounds nhoff and thoff, which is dangerous, see
> > recent commit d0c081b4913
On Dec 4, 2018, at 2:48 PM, Nadav Amit wrote:
>> On Dec 4, 2018, at 11:48 AM, Andy Lutomirski wrote:
>>
>> On Tue, Dec 4, 2018 at 11:45 AM Nadav Amit wrote:
On Dec 4, 2018, at 10:56 AM, Andy Lutomirski wrote:
On Mon, Dec 3, 2018 at 5:43 PM Nadav Amit wrote:
>> On Nov
On 12/04, Song Liu wrote:
> On Mon, Dec 3, 2018 at 8:01 PM Stanislav Fomichev wrote:
> >
> > We are returning thoff from the flow dissector, not the nhoff. Pass
> > thoff along with nhoff to the bpf program (initially thoff == nhoff)
> > and expect flow dissector amend/return thoff, not nhoff.
> >
On Mon, Dec 3, 2018 at 3:08 PM Stanislav Fomichev wrote:
>
> On 12/03, Song Liu wrote:
> > On Mon, Dec 3, 2018 at 11:00 AM Stanislav Fomichev wrote:
> > >
> > > The input is packet data, the output is struct bpf_flow_key. This should
> > > make it easy to test flow dissector programs without elab
On Mon, Dec 3, 2018 at 8:01 PM Stanislav Fomichev wrote:
>
> We want to make sure that the following condition holds:
> 0 <= nhoff <= thoff <= skb->len
>
> BPF program can set out-of-bounds nhoff and thoff, which is dangerous, see
> recent commit d0c081b49137 ("flow_dissector: properly cap thoff f
On Mon, Dec 3, 2018 at 8:01 PM Stanislav Fomichev wrote:
>
> We are returning thoff from the flow dissector, not the nhoff. Pass
> thoff along with nhoff to the bpf program (initially thoff == nhoff)
> and expect flow dissector amend/return thoff, not nhoff.
>
> This avoids confusion, when by the
Commit-ID: dd06d25d06f4932c570540877eba88d868dbba9b
Gitweb: https://git.kernel.org/tip/dd06d25d06f4932c570540877eba88d868dbba9b
Author: Paul E. McKenney
AuthorDate: Wed, 7 Nov 2018 15:12:34 -0800
Committer: Paul E. McKenney
CommitDate: Sat, 1 Dec 2018 12:38:51 -0800
net/decnet: Replace
Commit-ID: 0245b80e284d4fdabbf50589180482dc4d2cf277
Gitweb: https://git.kernel.org/tip/0245b80e284d4fdabbf50589180482dc4d2cf277
Author: Paul E. McKenney
AuthorDate: Wed, 7 Nov 2018 15:09:25 -0800
Committer: Paul E. McKenney
CommitDate: Sat, 1 Dec 2018 12:38:50 -0800
net/core/skmsg: Rep
Commit-ID: 1a56f7d53b5c8e82442e86eeac0b5d549088ee42
Gitweb: https://git.kernel.org/tip/1a56f7d53b5c8e82442e86eeac0b5d549088ee42
Author: Paul E. McKenney
AuthorDate: Tue, 6 Nov 2018 19:45:50 -0800
Committer: Paul E. McKenney
CommitDate: Sat, 1 Dec 2018 12:38:48 -0800
net/bridge: Replace
Commit-ID: 5da54c1810e52f7abba0ff7932761f945875
Gitweb: https://git.kernel.org/tip/5da54c1810e52f7abba0ff7932761f945875
Author: Paul E. McKenney
AuthorDate: Tue, 6 Nov 2018 19:43:32 -0800
Committer: Paul E. McKenney
CommitDate: Sat, 1 Dec 2018 12:38:47 -0800
net/core: Replace c
Commit-ID: ae0e33494a601e13df79c4742d88d4d2bc2b0a87
Gitweb: https://git.kernel.org/tip/ae0e33494a601e13df79c4742d88d4d2bc2b0a87
Author: Paul E. McKenney
AuthorDate: Tue, 6 Nov 2018 19:40:39 -0800
Committer: Paul E. McKenney
CommitDate: Sat, 1 Dec 2018 12:38:46 -0800
net/sched: Replace
> On Dec 4, 2018, at 11:48 AM, Andy Lutomirski wrote:
>
> On Tue, Dec 4, 2018 at 11:45 AM Nadav Amit wrote:
>>> On Dec 4, 2018, at 10:56 AM, Andy Lutomirski wrote:
>>>
>>> On Mon, Dec 3, 2018 at 5:43 PM Nadav Amit wrote:
> On Nov 27, 2018, at 4:07 PM, Rick Edgecombe
> wrote:
>
Commit-ID: d05faa5f1ac50beef77b4ceba0e8e157d41146e2
Gitweb: https://git.kernel.org/tip/d05faa5f1ac50beef77b4ceba0e8e157d41146e2
Author: Paul E. McKenney
AuthorDate: Mon, 5 Nov 2018 17:14:53 -0800
Committer: Paul E. McKenney
CommitDate: Tue, 27 Nov 2018 09:21:37 -0800
drivers/vhost: Rep
Commit-ID: 16f11500842ce022fe654e38bd447e15790911dd
Gitweb: https://git.kernel.org/tip/16f11500842ce022fe654e38bd447e15790911dd
Author: Paul E. McKenney
AuthorDate: Mon, 5 Nov 2018 17:07:39 -0800
Committer: Paul E. McKenney
CommitDate: Tue, 27 Nov 2018 09:21:37 -0800
ethernet/realtek:
Commit-ID: fd8e688b0e8cc0c0a8ca18acb69cb8397ed62eec
Gitweb: https://git.kernel.org/tip/fd8e688b0e8cc0c0a8ca18acb69cb8397ed62eec
Author: Paul E. McKenney
AuthorDate: Mon, 5 Nov 2018 17:05:08 -0800
Committer: Paul E. McKenney
CommitDate: Tue, 27 Nov 2018 09:21:36 -0800
ethernet/sis: Repl
On Mon, 3 Dec 2018 12:13:06 +0100
Emeric Dupont wrote:
> When performing make install in iproute2 (current git master),
> if $(HAVE_MNL) is not selected, some Makefiles try to call
> install with an empty target, which causes a non-critical make error.
>
> Signed-off-by: Emeric Dupont
Commit-ID: 97eeebea894283c290ead6694b76f575e7654773
Gitweb: https://git.kernel.org/tip/97eeebea894283c290ead6694b76f575e7654773
Author: Lance Roy
AuthorDate: Thu, 4 Oct 2018 23:45:42 -0700
Committer: Paul E. McKenney
CommitDate: Mon, 12 Nov 2018 09:06:22 -0800
smsc: Replace spin_is_loc
Commit-ID: 013ff4a6e7bc5aa64b0b937daae0244e3c93e49c
Gitweb: https://git.kernel.org/tip/013ff4a6e7bc5aa64b0b937daae0244e3c93e49c
Author: Lance Roy
AuthorDate: Thu, 4 Oct 2018 23:45:41 -0700
Committer: Paul E. McKenney
CommitDate: Mon, 12 Nov 2018 09:06:22 -0800
sfc: Replace spin_is_lock
On Tue, 4 Dec 2018 16:07:41 +
Petr Machata wrote:
> When no error is reported in the first iov, do not prematurely return,
> but process further iovs. This fixes batch processing.
>
> Fixes: c60389e4f9ea ("libnetlink: fix leak and using unused memory on error")
> Signed-off-by: Petr Machata
On Mon, 2018-11-26 at 17:56 +0530, Anshuman Khandual wrote:
> At present there are multiple places where invalid node number is encoded
> as -1. Even though implicitly understood it is always better to have macros
> in there. Replace these open encodings for an invalid node number with the
> global
On Tue, Dec 4, 2018 at 1:16 PM Eric Dumazet wrote:
>
> Erm I never suggested to get rid of CHECKSUM_COMPLETE...
> My suggestion was to reorder the mlx5 logic to match mlx4 one.
>
> CHECKSUM_COMPLETE is very nice _when_/_if_ the NIC is unable to
> fully dissect a packet and validate L4, as a fallba
On 12/04/2018 12:35 PM, Cong Wang wrote:
> On Tue, Dec 4, 2018 at 11:17 AM Saeed Mahameed
> wrote:
>>
>> On Mon, Dec 3, 2018 at 11:52 PM Eric Dumazet wrote:
>>>
>>> On Mon, Dec 3, 2018 at 11:30 PM Cong Wang wrote:
On Mon, Dec 3, 2018 at 11:08 PM Eric Dumazet wrote:
>
> The
On Tue, Dec 04, 2018 at 03:56:33PM -0500, Neil Horman wrote:
> On Tue, Dec 04, 2018 at 05:52:02PM -0200, Marcelo Ricardo Leitner wrote:
> > On Tue, Dec 04, 2018 at 02:39:46PM -0500, Neil Horman wrote:
> > > On Tue, Dec 04, 2018 at 08:27:41PM +0100, Jakub Audykowicz wrote:
> > > > If for some reason
On Tue, Dec 04, 2018 at 05:52:02PM -0200, Marcelo Ricardo Leitner wrote:
> On Tue, Dec 04, 2018 at 02:39:46PM -0500, Neil Horman wrote:
> > On Tue, Dec 04, 2018 at 08:27:41PM +0100, Jakub Audykowicz wrote:
> > > If for some reason an association's fragmentation point is zero,
> > > sctp_datamsg_fro
1 - 100 of 253 matches
Mail list logo
