[PATCH v4 net-next 2/9] devlink: Add generic parameter msix_vec_per_pf_max

2018-10-03 Thread Vasundhara Volam
msix_vec_per_pf_max - This param sets the number of MSIX vectors that the device requests from the host on driver initialization. This value is set in the device which is applicable per PF. Cc: Jiri Pirko Cc: Michael Chan Signed-off-by: Vasundhara Volam --- include/net/devlink.h | 4 net/

[PATCH v4 net-next 4/9] bnxt_en: Use ignore_ari devlink parameter

2018-10-03 Thread Vasundhara Volam
This patch adds support for ignore_ari generic permanent mode devlink parameter. This parameter is disabled by default. It can be enabled using devlink param commands. ignore_ari - If enabled, device ignores ARI(Alternate Routing ID) capability, even when platforms has the support and creates same

[PATCH v4 net-next 3/9] devlink: Add generic parameter msix_vec_per_pf_min

2018-10-03 Thread Vasundhara Volam
msix_vec_per_pf_min - This param sets the number of minimal MSIX vectors required for the device initialization. This value is set in the device which limits MSIX vectors per PF. Cc: Jiri Pirko Cc: Michael Chan Signed-off-by: Vasundhara Volam --- include/net/devlink.h | 4 net/core/devlin

[PATCH v4 net-next 5/9] bnxt_en: return proper error when FW returns HWRM_ERR_CODE_RESOURCE_ACCESS_DENIED

2018-10-03 Thread Vasundhara Volam
Return proper error code when Firmware returns HWRM_ERR_CODE_RESOURCE_ACCESS_DENIED for HWRM_NVM_GET/SET_VARIABLE commands. Cc: Michael Chan Signed-off-by: Vasundhara Volam --- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --g

[PATCH v4 net-next 6/9] bnxt_en: Use msix_vec_per_pf_max and msix_vec_per_pf_min devlink params.

2018-10-03 Thread Vasundhara Volam
This patch adds support for following generic permanent mode devlink parameters. They can be modified using devlink param commands. msix_vec_per_pf_max - This param sets the number of MSIX vectors that the device requests from the host on driver initialization. This value is set in the device whic

[PATCH v4 net-next 8/9] devlink: Add Documentation/networking/devlink-params.txt

2018-10-03 Thread Vasundhara Volam
This patch adds a new file to add information about some of the generic configuration parameters set via devlink. Cc: "David S. Miller" Cc: Jonathan Corbet Cc: linux-...@vger.kernel.org Cc: Jiri Pirko Cc: Michael Chan Signed-off-by: Vasundhara Volam --- Documentation/networking/devlink-param

[PATCH v4 net-next 9/9] devlink: Add Documentation/networking/devlink-params-bnxt.txt

2018-10-03 Thread Vasundhara Volam
This patch adds a new file to add information about configuration parameters that are supported by bnxt_en driver via devlink. Cc: "David S. Miller" Cc: Jonathan Corbet Cc: linux-...@vger.kernel.org Cc: Jiri Pirko Cc: Michael Chan Signed-off-by: Vasundhara Volam --- Documentation/networking/

[PATCH v4 net-next 1/9] devlink: Add generic parameter ignore_ari

2018-10-03 Thread Vasundhara Volam
ignore_ari - Device ignores ARI(Alternate Routing ID) capability, even when platforms has the support and creates same number of partitions when platform does not support ARI capability. Cc: Jiri Pirko Cc: Michael Chan Signed-off-by: Vasundhara Volam --- include/net/devlink.h | 4 net/cor

[PATCH v4 net-next 7/9] bnxt_en: Add a driver specific gre_ver_check devlink parameter.

2018-10-03 Thread Vasundhara Volam
This patch adds following driver-specific permanent mode boolean parameter. gre_ver_check - Generic Routing Encapsulation(GRE) version check will be enabled in the device. If disabled, device skips version checking for GRE packets. Cc: Michael Chan Signed-off-by: Vasundhara Volam --- drivers/n

[PATCH v4 net-next 0/9] bnxt_en: devlink param updates

2018-10-03 Thread Vasundhara Volam
This patchset adds support for 3 generic and 1 driver-specific devlink parameters. Add documentation for these configuration parameters. Also, this patchset adds support to return proper error code if HWRM_NVM_GET/SET_VARIABLE commands return error code HWRM_ERR_CODE_RESOURCE_ACCESS_DENIED. v3->v

[RFC 2/2] nfp: register remote block callbacks for vxlan/geneve

2018-10-03 Thread Jakub Kicinski
From: John Hurley Test stub to illustrate how the NFP could register for and receive callbacks from remote block setups. Signed-off-by: John Hurley Signed-off-by: Jakub Kicinski --- .../net/ethernet/netronome/nfp/flower/main.c | 12 ++ .../net/ethernet/netronome/nfp/flower/main.h | 10 ++

[RFC 1/2] net: sched: register callbacks for remote tc block binds

2018-10-03 Thread Jakub Kicinski
From: John Hurley Currently drivers can register for TC block binds/unbinds by implementing the setup_tc ndo. However, drivers may also be interested in binds to higher level devices (e.g. tunnel drivers) to potentially offload filters applied to them. Introduce indirect block setups which allow

[RFC 0/2] net: sched: indirect/remote setup tc block cb registering

2018-10-03 Thread Jakub Kicinski
Hi! This set contains a rough RFC implementation of a proposed [1] replacement for egdev cls_flower offloads. I did some last minute restructuring and removal of parts I felt were unnecessary, so if there are glaring bugs they are probably mine, not John's :) but hopefully this will give an idea

Re: [PATCH iproute2] lib/libnetlink: fix response seq check

2018-10-03 Thread Stephen Hemminger
On Wed, 3 Oct 2018 16:01:40 -0700 Vlad Dumitrescu wrote: > Hi, > > On Fri, Sep 28, 2018 at 10:14 AM wrote: > > > > From: Vlad Dumitrescu > > > > Taking a one-iovec example, with rtnl->seq at 42. iovlen == 1, seq > > becomes 43 on line 604, and a message is sent with nlmsg_seq == 43. If > > a r

Re: Kernel oops with mlx5 and dual XDP redirect programs

2018-10-03 Thread Saeed Mahameed
On Wed, 2018-10-03 at 11:30 +0200, Toke Høiland-Jørgensen wrote: > Hi Saeed > > I can reliably oops the kernel with the mlx5 driver, by installing > XDP_REDIRECT programs on two devices so they redirect to each other, > and then remove them while there is traffic on the interface. > > Steps to re

[PATCH v3] net/ncsi: Add NCSI OEM command support

2018-10-03 Thread Vijay Khemka
This patch adds OEM commands and response handling. It also defines OEM command and response structure as per NCSI specification along with its handlers. ncsi_cmd_handler_oem: This is a generic command request handler for OEM commands ncsi_rsp_handler_oem: This is a generic response handler for OE

Re: [PATCH iproute2] lib/libnetlink: fix response seq check

2018-10-03 Thread Vlad Dumitrescu
Hi, On Fri, Sep 28, 2018 at 10:14 AM wrote: > > From: Vlad Dumitrescu > > Taking a one-iovec example, with rtnl->seq at 42. iovlen == 1, seq > becomes 43 on line 604, and a message is sent with nlmsg_seq == 43. If > a response with nlmsg_seq of 42 is received, the condition being fixed > in this

[PATCH net-next] net/neigh: Extend dump filter to proxy neighbor dumps

2018-10-03 Thread David Ahern
From: David Ahern Move the attribute parsing from neigh_dump_table to neigh_dump_info, and pass the filter arguments down to neigh_dump_table in a new struct. Add the filter option to proxy neigh dumps as well to make them consistent. Signed-off-by: David Ahern --- net/core/neighbour.c | 72 ++

[PATCH bpf-next 3/6] libbpf: Consistent prefixes for interfaces in nlattr.h.

2018-10-03 Thread Andrey Ignatov
libbpf is used more and more outside kernel tree. That means the library should follow good practices in library design and implementation to play well with third party code that uses it. One of such practices is to have a common prefix (or a few) for every interface, function or data structure, l

[PATCH bpf-next 1/6] libbpf: Move __dump_nlmsg_t from API to implementation

2018-10-03 Thread Andrey Ignatov
This typedef is used only by implementation in netlink.c. Nothing uses it in public API. Move it to netlink.c. Signed-off-by: Andrey Ignatov Acked-by: Alexei Starovoitov --- tools/lib/bpf/libbpf.h | 3 --- tools/lib/bpf/netlink.c | 3 +++ 2 files changed, 3 insertions(+), 3 deletions(-) diff

[PATCH bpf-next 2/6] libbpf: Consistent prefixes for interfaces in libbpf.h.

2018-10-03 Thread Andrey Ignatov
libbpf is used more and more outside kernel tree. That means the library should follow good practices in library design and implementation to play well with third party code that uses it. One of such practices is to have a common prefix (or a few) for every interface, function or data structure, l

[PATCH bpf-next 5/6] libbpf: Make include guards consistent

2018-10-03 Thread Andrey Ignatov
Rename include guards to have consistent names "__LIBBPF_". Signed-off-by: Andrey Ignatov Acked-by: Alexei Starovoitov --- tools/lib/bpf/bpf.h | 6 +++--- tools/lib/bpf/btf.h | 6 +++--- tools/lib/bpf/libbpf.h| 6 +++--- tools/lib/bpf/nlattr.h| 6 +++--- tools/lib/bpf/str_er

[PATCH bpf-next 4/6] libbpf: Consistent prefixes for interfaces in str_error.h.

2018-10-03 Thread Andrey Ignatov
libbpf is used more and more outside kernel tree. That means the library should follow good practices in library design and implementation to play well with third party code that uses it. One of such practices is to have a common prefix (or a few) for every interface, function or data structure, l

[PATCH bpf-next 6/6] libbpf: Use __u32 instead of u32 in bpf_program__load

2018-10-03 Thread Andrey Ignatov
Make bpf_program__load consistent with other interfaces: use __u32 instead of u32. That in turn fixes build of samples: In file included from ./samples/bpf/trace_output_user.c:21:0: ./tools/lib/bpf/libbpf.h:132:9: error: unknown type name ‘u32’ u32 kern_version); ^ Fixes: commit

[PATCH bpf-next 0/6] Consistent prefixes for libbpf interfaces

2018-10-03 Thread Andrey Ignatov
This patch set renames a few interfaces in libbpf, mostly netlink related, so that all symbols provided by the library have only three possible prefixes: % nm -D tools/lib/bpf/libbpf.so | \ awk '$2 == "T" {sub(/[_\(].*/, "", $3); if ($3) print $3}' | \ sort | \ uniq -c 91 bpf

[PATCH net] net: sched: Add policy validation for tc attributes

2018-10-03 Thread David Ahern
From: David Ahern A number of TC attributes are processed without proper validation (e.g., length checks). Add a tca policy for all input attributes and use when invoking nlmsg_parse. The 2 Fixes tags below cover the latest additions. The other attributes are a string (KIND), nested attribute (O

Re: How to post rxrpc patches for net-next with deps on net?

2018-10-03 Thread David Miller
From: David Howells Date: Wed, 03 Oct 2018 21:29:19 +0100 > I have some rxrpc patches to post for your net-next/master branch, but there's > a dependency in them on the rxrpc-fixes-20180928 tag you pulled into your > net/master branch. > > What's the best way to handle this? > > (1) Wait for y

Re: [net-next 00/13][pull request] 10GbE Intel Wired LAN Driver Updates 2018-10-03

2018-10-03 Thread David Miller
From: Jeff Kirsher Date: Wed, 3 Oct 2018 13:24:58 -0700 > This series contains updates to ixgbe/ixgbevf and few fixes for i40e & iavf. Pulled, thanks Jeff.

Re: r8169 tx batching(?) causing performance problems

2018-10-03 Thread David Miller
From: David Howells Date: Wed, 03 Oct 2018 21:19:40 +0100 > David Miller wrote: > >> Probably you are seeing some interrupt mitigation. >> >> It seems there is a difference in how the interrupt mitigation is >> programmed on for 8168 chips vs. others by default. Most get >> all zeros in the I

Re: [net] ixgbe: check return value of napi_complete_done()

2018-10-03 Thread David Miller
From: Jeff Kirsher Date: Wed, 3 Oct 2018 11:30:35 -0700 > From: Song Liu > > The NIC driver should only enable interrupts when napi_complete_done() > returns true. This patch adds the check for ixgbe. > > Cc: sta...@vger.kernel.org # 4.10+ > Suggested-by: Eric Dumazet > Signed-off-by: Song L

Re: [RFC PATCH bpf-next v3 4/7] bpf: add bpf queue and stack maps

2018-10-03 Thread Alexei Starovoitov
On Wed, Oct 03, 2018 at 12:01:37PM -0500, Mauricio Vasquez wrote: > > > On 10/01/2018 07:26 PM, Alexei Starovoitov wrote: > > On Mon, Oct 01, 2018 at 08:11:43AM -0500, Mauricio Vasquez wrote: > > > > > > +BPF_CALL_3(bpf_map_pop_elem, struct bpf_map *, map, void *, > > > > > > value, u32, size) >

[PATCH iproute2-next v2] tc: flower: expose hardware offload count

2018-10-03 Thread Vlad Buslov
Recently flower classifier was updated to expose count of devices that filter is offloaded to. Add support to print this counter as 'in_hw_count'. Signed-off-by: Vlad Buslov Acked-by: Jiri Pirko --- Changes from V1 to V2: - Change print format string to "%u" tc/f_flower.c | 10 +- 1 fi

How to post rxrpc patches for net-next with deps on net?

2018-10-03 Thread David Howells
Hi Dave, I have some rxrpc patches to post for your net-next/master branch, but there's a dependency in them on the rxrpc-fixes-20180928 tag you pulled into your net/master branch. What's the best way to handle this? (1) Wait for you to merge net into net-next? (2) Base it on my own merge of

[net-next 07/13] ixgbe: Fix crash with VFs and flow director on interface flap

2018-10-03 Thread Jeff Kirsher
From: Radoslaw Tyl This patch fix crash when we have restore flow director filters after reset adapter. In ixgbe_fdir_filter_restore() filter->action is outside of the rx_ring array, as it has a VF identifier in the upper 32 bits. Signed-off-by: Radoslaw Tyl Tested-by: Andrew Bowers Signed-off

[net-next 12/13] ixgbe: add AF_XDP zero-copy Tx support

2018-10-03 Thread Jeff Kirsher
From: Björn Töpel This patch adds zero-copy Tx support for AF_XDP sockets. It implements the ndo_xsk_async_xmit netdev ndo and performs all the Tx logic from a NAPI context. This means pulling egress packets from the Tx ring, placing the frames on the NIC HW descriptor ring and completing sent fr

[net-next 03/13] ixgbe: remove redundant function ixgbe_fw_recovery_mode()

2018-10-03 Thread Jeff Kirsher
From: YueHaibing There are no in-tree callers. Signed-off-by: YueHaibing Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ixgbe/ixgbe_common.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c b

[net-next 02/13] ixgbe: Fix ixgbe TX hangs with XDP_TX beyond queue limit

2018-10-03 Thread Jeff Kirsher
From: Radoslaw Tyl We have Tx hang when number Tx and XDP queues are more than 64. In XDP always is MTQC == 0x0 (64TxQs). We need more space for Tx queues. Signed-off-by: Radoslaw Tyl Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 14

[net-next 01/13] ixgbevf: fix msglen for ipsec mbx messages

2018-10-03 Thread Jeff Kirsher
From: Shannon Nelson Don't be fancy with message lengths, just set lengths to number of dwords, not bytes. Fixes: 0062e7cc955e ("ixgbevf: add VF IPsec offload code") Reported-by: Dan Carpenter Signed-off-by: Shannon Nelson Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net

[net-next 00/13][pull request] 10GbE Intel Wired LAN Driver Updates 2018-10-03

2018-10-03 Thread Jeff Kirsher
This series contains updates to ixgbe/ixgbevf and few fixes for i40e & iavf. Shannon Nelson fixes the message length for IPsec mailbox messages. Radoslaw fixes a transmit hang that occurs when XDP_TX exceeds the queue limit. Fixes a crash when we restor flow director filters after a reset. YueH

[net-next 06/13] i40e: Remove unnecessary print statement

2018-10-03 Thread Jeff Kirsher
From: Nathan Chancellor Clang warns that the address of a pointer will always evaluated as true in a boolean context. drivers/net/ethernet/intel/i40e/i40e_debugfs.c:136:9: warning: address of array 'vsi->active_vlans' will always evaluate to 'true' [-Wpointer-bool-conversion] vs

[net-next 10/13] ixgbe: add AF_XDP zero-copy Rx support

2018-10-03 Thread Jeff Kirsher
From: Björn Töpel This patch adds zero-copy Rx support for AF_XDP sockets. Instead of allocating buffers of type MEM_TYPE_PAGE_SHARED, the Rx frames are allocated as MEM_TYPE_ZERO_COPY when AF_XDP is enabled for a certain queue. All AF_XDP specific functions are added to a new file, ixgbe_xsk.c.

[net-next 05/13] i40e: Use proper enum in i40e_ndo_set_vf_link_state

2018-10-03 Thread Jeff Kirsher
From: Nathan Chancellor Clang warns when one enumerated type is converted implicitly to another. drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c:4214:42: warning: implicit conversion from enumeration type 'enum i40e_aq_link_speed' to different enumeration type 'enum virtchnl_link_speed'

[net-next 13/13] iavf: fix a typo

2018-10-03 Thread Jeff Kirsher
From: Rami Rosen This trivial patch fixes a typo in iavf.h. Signed-off-by: Rami Rosen Acked-by: Jesse Brandeburg Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/iavf/iavf.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/et

[net-next 09/13] ixgbe: move common Rx functions to ixgbe_txrx_common.h

2018-10-03 Thread Jeff Kirsher
From: Björn Töpel This patch prepares for the upcoming zero-copy Rx functionality, by moving/changing linkage of common functions, used both by the regular path and zero-copy path. Signed-off-by: Björn Töpel Tested-by: William Tu Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- driv

[net-next 11/13] ixgbe: move common Tx functions to ixgbe_txrx_common.h

2018-10-03 Thread Jeff Kirsher
From: Björn Töpel This patch prepares for the upcoming zero-copy Tx functionality by moving common functions used both by the regular path and zero-copy path. Signed-off-by: Björn Töpel Tested-by: William Tu Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel

[net-next 08/13] ixgbe: added Rx/Tx ring disable/enable functions

2018-10-03 Thread Jeff Kirsher
From: Björn Töpel Add functions for Rx/Tx ring enable/disable. Instead of resetting the whole device, only the affected ring is disabled or enabled. This plumbing is used in later commits, when zero-copy AF_XDP support is introduced. Signed-off-by: Björn Töpel Tested-by: William Tu Tested-by:

[net-next 04/13] ixgbevf: off by one in ixgbevf_ipsec_tx()

2018-10-03 Thread Jeff Kirsher
From: Dan Carpenter The ipsec->tx_tbl[] array has IXGBE_IPSEC_MAX_SA_COUNT elements so the > should be a >=. Fixes: 0062e7cc955e ("ixgbevf: add VF IPsec offload code") Signed-off-by: Dan Carpenter Signed-off-by: Shannon Nelson Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers

Re: r8169 tx batching(?) causing performance problems

2018-10-03 Thread David Howells
David Miller wrote: > Probably you are seeing some interrupt mitigation. > > It seems there is a difference in how the interrupt mitigation is > programmed on for 8168 chips vs. others by default. Most get > all zeros in the IntrMitigate register, whilst for 8168 chips > a value of 0x5151 is pr

Targeted Global B2B Companies emails list

2018-10-03 Thread catherine . white
Hi, I just wanted to check if you would be interested in a list of Managed Service Providers (MSPs) and Managed Security Service Providers (MSSPs)? We also have the data intelligence of: •Managed Service Providers (MSP’s) – 25,000 unique companies •Managed Security Service Pr

[net] ixgbe: check return value of napi_complete_done()

2018-10-03 Thread Jeff Kirsher
From: Song Liu The NIC driver should only enable interrupts when napi_complete_done() returns true. This patch adds the check for ixgbe. Cc: sta...@vger.kernel.org # 4.10+ Suggested-by: Eric Dumazet Signed-off-by: Song Liu Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net

Re: [net-next 08/15] ice: Notify VF of link status change

2018-10-03 Thread Or Gerlitz
On Wed, Oct 3, 2018 at 6:46 PM Jeff Kirsher wrote: > From: Anirudh Venkataramanan > > When PF gets a link status change event, notify the VFs of the same. so you always want to block east/west traffic when the uplink is down? why? The correct approach is to have vf/vport e-switch representor on

Re: [PATCH iproute2 net-next v1 5/6] tc: Add support for configuring the taprio scheduler

2018-10-03 Thread Vinicius Costa Gomes
Hi David, David Ahern writes: > On 9/28/18 7:10 PM, Vinicius Costa Gomes wrote: >> This traffic scheduler allows traffic classes states (transmission >> allowed/not allowed, in the simplest case) to be scheduled, according >> to a pre-generated time sequence. This is the basis of the IEEE >> 802

Re: [RFC PATCH bpf-next v3 4/7] bpf: add bpf queue and stack maps

2018-10-03 Thread Mauricio Vasquez
On 10/01/2018 07:26 PM, Alexei Starovoitov wrote: On Mon, Oct 01, 2018 at 08:11:43AM -0500, Mauricio Vasquez wrote: +BPF_CALL_3(bpf_map_pop_elem, struct bpf_map *, map, void *, value, u32, size) +{ +    void *ptr; + +    if (map->value_size != size) +    return -EINVAL; + +    ptr = map->

Re: [RFC PATCH v2 bpf-next 0/2] verifier liveness simplification

2018-10-03 Thread Jiong Wang
On 03/10/2018 16:59, Alexei Starovoitov wrote: On Wed, Oct 03, 2018 at 04:36:31PM +0100, Jiong Wang wrote: Now this hasn't happened. I am still debugging the root cause, but kind of feel "64-bit" attribute propagation is the issue, it seems to me it can't be nicely integrated into the existing

Re: [net-next 00/15][pull request] 100GbE Intel Wired LAN Driver Updates 2018-10-03

2018-10-03 Thread David Miller
From: Jeff Kirsher Date: Wed, 3 Oct 2018 08:48:10 -0700 > This series contains updates to ice and virtchnl. Pulled, thanks Jeff.

Re: [PATCH net-next] cxgb4: remove the unneeded locks

2018-10-03 Thread David Miller
From: Ganesh Goudar Date: Wed, 3 Oct 2018 18:26:32 +0530 > cxgb_set_tx_maxrate will be called holding rtnl lock, > hence remove all unneeded locks. > > Signed-off-by: Ganesh Goudar Applied.

Re: [PATCH iproute2 net-next v1 5/6] tc: Add support for configuring the taprio scheduler

2018-10-03 Thread David Ahern
On 9/28/18 7:10 PM, Vinicius Costa Gomes wrote: > This traffic scheduler allows traffic classes states (transmission > allowed/not allowed, in the simplest case) to be scheduled, according > to a pre-generated time sequence. This is the basis of the IEEE > 802.1Qbv specification. > > Example confi

Re: r8169 tx batching(?) causing performance problems

2018-10-03 Thread David Miller
Probably you are seeing some interrupt mitigation. It seems there is a difference in how the interrupt mitigation is programmed on for 8168 chips vs. others by default. Most get all zeros in the IntrMitigate register, whilst for 8168 chips a value of 0x5151 is programmed. You can play with eth

Re: [PATCH iproute2-next] tc: flower: expose hardware offload count

2018-10-03 Thread Vlad Buslov
On Wed 03 Oct 2018 at 16:08, Davide Caratti wrote: > On Wed, 2018-10-03 at 18:29 +0300, Vlad Buslov wrote: >> Recently flower classifier was updated to expose count of devices that >> filter is offloaded to. Add support to print this counter as 'in_hw_count'. >> >> Signed-off-by: Vlad Buslov >

Re: [PATCH v2 iproute2-next 1/3] tc: support conversions to or from 64 bit nanosecond-based time

2018-10-03 Thread Dave Taht
On Mon, Aug 27, 2018 at 9:39 AM Dave Taht wrote: > > On Mon, Aug 27, 2018 at 9:11 AM Stephen Hemminger > wrote: > > > > On Sun, 26 Aug 2018 19:42:28 -0700 > > Yousuk Seung wrote: > > > > > +int get_time(unsigned int *time, const char *str) > > > +{ > > > + double t; > > > + char *p; > >

Re: [PATCH iproute2-next] tc: flower: expose hardware offload count

2018-10-03 Thread Davide Caratti
On Wed, 2018-10-03 at 18:29 +0300, Vlad Buslov wrote: > Recently flower classifier was updated to expose count of devices that > filter is offloaded to. Add support to print this counter as 'in_hw_count'. > > Signed-off-by: Vlad Buslov > Acked-by: Jiri Pirko > --- > tc/f_flower.c | 10 +++

Re: [PATCH v2 net] mpls: allow routes on ip6gre devices

2018-10-03 Thread Simon Horman
On Fri, Sep 21, 2018 at 02:30:05PM -0700, Saif Hasan wrote: > Summary: > > This appears to be necessary and sufficient change to enable `MPLS` on > `ip6gre` tunnels (RFC4023). > > This diff allows IP6GRE devices to be recognized by MPLS kernel module > and hence user can configure interface to ac

[PATCH v2] net: phy: phylink: fix SFP interface autodetection

2018-10-03 Thread Baruch Siach
When connecting SFP PHY to phylink use the detected interface. Otherwise, the link fails to come up when the configured 'phy-mode' differs from the SFP detected mode. Move most of phylink_connect_phy() into __phylink_connect_phy(), and leave phylink_connect_phy() as a wrapper. phylink_sfp_connect_

Re: [RFC PATCH v2 bpf-next 0/2] verifier liveness simplification

2018-10-03 Thread Alexei Starovoitov
On Wed, Oct 03, 2018 at 04:36:31PM +0100, Jiong Wang wrote: > On 28/09/2018 14:36, Edward Cree wrote: > > On 26/09/18 23:16, Jiong Wang wrote: > >> On 22/08/2018 20:00, Edward Cree wrote: > >>> In the future this idea may be extended to form use-def chains. > >> > >>   1. instruction level use->def

[net-next 09/15] ice: Extend malicious operations detection logic

2018-10-03 Thread Jeff Kirsher
From: Anirudh Venkataramanan This patch extends the existing malicious driver operation detection logic to cover malicious operations by the VF driver as well. Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- .../net/ethernet/intel/ice/ice_hw_aut

[net-next 06/15] ice: Add handlers for VF netdevice operations

2018-10-03 Thread Jeff Kirsher
From: Anirudh Venkataramanan This patch implements handlers for the following NDO operations: .ndo_set_vf_spoofchk .ndo_set_vf_mac .ndo_get_vf_config .ndo_set_vf_trust .ndo_set_vf_vlan .ndo_set_vf_link_state Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Ki

[net-next 00/15][pull request] 100GbE Intel Wired LAN Driver Updates 2018-10-03

2018-10-03 Thread Jeff Kirsher
This series contains updates to ice and virtchnl. Yashaswini Raghuram adds a new virtchnl capability flag to support the exchange of additional supported speeds. Anirudh adds support for SR-IOV for the ice driver. Added code to initialize, configure and use mailbox queues for PF and VF communica

[net-next 04/15] ice: Update VSI and queue management code to handle VF VSI

2018-10-03 Thread Jeff Kirsher
From: Anirudh Venkataramanan Until now, all the VSI and queue management code supported only the PF VSI type (ICE_VSI_PF). Update these flows to handle the VF VSI type (ICE_VSI_VF) type as well. Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- dr

[net-next 03/15] ice: Add handler to configure SR-IOV

2018-10-03 Thread Jeff Kirsher
From: Anirudh Venkataramanan This patch implements parts of ice_sriov_configure and VF reset flow. To create virtual functions (VFs), the user sets a value in num_vfs through sysfs. This results in the kernel calling the handler for .sriov_configure which is ice_sriov_configure. VF setup first

[net-next 10/15] ice: Fix forward to queue group logic

2018-10-03 Thread Jeff Kirsher
From: Anirudh Venkataramanan When adding a rule, queue region size needs to be provided as log base 2 of the number of queues in region. Fix that. Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ice/ice_switch.c | 14 +

[net-next 13/15] ice: Add more flexibility on how we assign an ITR index

2018-10-03 Thread Jeff Kirsher
From: Brett Creeley This issue came about when looking at the VF function ice_vc_cfg_irq_map_msg. Currently we are assigning the itr_setting value to the itr_idx received from the AVF driver, which is not correct and is not used for the VF flow anyway. Currently the only way we set the ITR index

[net-next 02/15] ice: Add support to detect SR-IOV capability and mailbox queues

2018-10-03 Thread Jeff Kirsher
From: Anirudh Venkataramanan Mailbox queue is a type of control queue that's used for communication between PF and VF. This patch adds code to initialize, configure and use mailbox queues. This patch also adds support to detect and parse SR-IOV capabilities returned by the hardware. Signed-off-

[net-next 11/15] ice: Add code to go from ICE_FWD_TO_VSI_LIST to ICE_FWD_TO_VSI

2018-10-03 Thread Jeff Kirsher
From: Brett Creeley When a switch rule is initially created we set the filter action to ICE_FWD_TO_VSI. The filter action changes to ICE_FWD_TO_VSI_LIST whenever more than one VSI is subscribed to the same switch rule. When the switch rule goes from 2 VSIs in the list to 1 VSI we remove and delet

[net-next 14/15] ice: Use the right function to enable/disable VSI

2018-10-03 Thread Jeff Kirsher
From: Dave Ertman The ice_ena/dis_vsi should have a single differentiating factor to determine if the netdev_ops call is used or a direct call to ice_vsi_open/close. This is if the netif is running or not. If netif is running, use ndo_open/ndo_close. Else, use ice_vsi_open/ice_vsi_close. Signe

[net-next 12/15] ice: Fix potential null pointer issues

2018-10-03 Thread Jeff Kirsher
From: Dave Ertman Add checks in the filter handling flow to avoid dereferencing NULL pointers. Signed-off-by: Dave Ertman Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ice/ice_switch.c | 13 +++-- 1 file cha

[net-next 07/15] ice: Implement virtchnl commands for AVF support

2018-10-03 Thread Jeff Kirsher
From: Anirudh Venkataramanan virtchnl is a protocol/interface specification that allows the Intel "Adaptive Virtual Function (AVF)" driver (iavf.ko) to work with more than one physical function driver. The AVF driver sends "virtchnl commands" (control plane only) to the PF driver over mailbox que

[net-next 15/15] ice: Update version string

2018-10-03 Thread Jeff Kirsher
From: Anirudh Venkataramanan Update version string to 0.7.2-k Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ice/ice_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/inte

[net-next 08/15] ice: Notify VF of link status change

2018-10-03 Thread Jeff Kirsher
From: Anirudh Venkataramanan When PF gets a link status change event, notify the VFs of the same. Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ice/ice_main.c| 2 ++ drivers/net/ethernet/intel/ice/ice_virtch

[net-next 05/15] ice: Add support for VF reset events

2018-10-03 Thread Jeff Kirsher
From: Anirudh Venkataramanan Post VF initialization, there are a couple of different ways in which a VF reset can be triggered. One is when the underlying PF itself goes through a reset and other is via a VFLR interrupt. ice_reset_vf introduced in this patch handles both these cases. Also introd

[net-next 01/15] virtchnl: Added support to exchange additional speed values

2018-10-03 Thread Jeff Kirsher
From: Yashaswini Raghuram Prathivadi Bhayankaram Introduced a new virtchnl capability flag and a struct to support exchange of additional supported speeds. Signed-off-by: Yashaswini Raghuram Prathivadi Bhayankaram Signed-off-by: Anirudh Venkataramanan Signed-off-by: Jeff Kirsher --- includ

Re: [RFC PATCH v2 bpf-next 0/2] verifier liveness simplification

2018-10-03 Thread Jiong Wang
On 28/09/2018 14:36, Edward Cree wrote: > On 26/09/18 23:16, Jiong Wang wrote: >> On 22/08/2018 20:00, Edward Cree wrote: >>> In the future this idea may be extended to form use-def chains. >> >>   1. instruction level use->def chain >> >>  - new use->def chains for each instruction. one eBPF

[PATCH iproute2-next] tc: flower: expose hardware offload count

2018-10-03 Thread Vlad Buslov
Recently flower classifier was updated to expose count of devices that filter is offloaded to. Add support to print this counter as 'in_hw_count'. Signed-off-by: Vlad Buslov Acked-by: Jiri Pirko --- tc/f_flower.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/tc/f

Re: r8169 tx batching(?) causing performance problems

2018-10-03 Thread David Howells
David Howells wrote: > Can someone help me figure out a performance issue that seems to be caused by > an RTL8168g/8111g NIC that seems to be batching up transmissions - or, at > least, not starting immediately that it's given something to transmit? I've been told that: commit ad5f97faf

Re: [PATCH RFC v2 net-next 00/25] rtnetlink: Add support for rigid checking of data in dump request

2018-10-03 Thread David Ahern
On 10/3/18 8:59 AM, Stephen Hemminger wrote: > On Mon, 1 Oct 2018 17:28:26 -0700 > David Ahern wrote: > >> How to resolve the problem of not breaking old userspace yet be able to >> move forward with new features such as kernel side filtering which are >> crucial for efficient operation at high

Re: [PATCH RFC v2 net-next 00/25] rtnetlink: Add support for rigid checking of data in dump request

2018-10-03 Thread Stephen Hemminger
On Mon, 1 Oct 2018 17:28:26 -0700 David Ahern wrote: > How to resolve the problem of not breaking old userspace yet be able to > move forward with new features such as kernel side filtering which are > crucial for efficient operation at high scale? What about forward compatibility? How would th

Re: [bpf-next PATCH 1/3] net: fix generic XDP to handle if eth header was mangled

2018-10-03 Thread Jesper Dangaard Brouer
On Tue, 25 Sep 2018 22:36:39 -0700 Song Liu wrote: > On Tue, Sep 25, 2018 at 7:26 AM Jesper Dangaard Brouer > wrote: > > > > XDP can modify (and resize) the Ethernet header in the packet. > > > > There is a bug in generic-XDP, because skb->protocol and skb->pkt_type > > are setup before reaching

[PATCH] net: sample/bpf/tracex3_user.c: erase "ARRAY_SIZE" redefined

2018-10-03 Thread Bo YU
There is a warning when compiling bpf program in sample/bpf BTW,i get the warning from David's net tree, then i git clone bpf tree try to compile bpf program,but it tell me failed to do that maybe i was not compile the whole kernel once. I don't know this is ok or not. Signed-off-by: Bo YU ---

[PATCH net] be2net: don't flip hw_features when VXLANs are added/deleted

2018-10-03 Thread Davide Caratti
the be2net implementation of .ndo_tunnel_{add,del}() changes the value of NETIF_F_GSO_UDP_TUNNEL bit in 'features' and 'hw_features', but it forgets to call netdev_features_change(). Moreover, ethtool setting for that bit can potentially be reverted after a tunnel is added or removed. GSO already

PROBLEM: NETDEV WATCHDOG r8169 transmit queue time out in commit 4fd48c4ac0a0578862819295222a825c97686ac7 onwards.

2018-10-03 Thread Iain Price
[1.] One line summary of the problem: NETDEV WATCHDOG r8169 transmit queue time out in commit 4fd48c4ac0a0578862819295222a825c97686ac7 onwards. [2.] Full description of the problem/report: Uncertain exact cause, standard usage uptime before issue is 2-12 hours, however I can accelerate the

[PATCH net-next] cxgb4: remove the unneeded locks

2018-10-03 Thread Ganesh Goudar
cxgb_set_tx_maxrate will be called holding rtnl lock, hence remove all unneeded locks. Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/sched.c | 68 +++--- drivers/net/ethernet/chelsio/cxgb4/sched.h | 2 - 2 files changed, 15 insertions(+), 55 deletio

Re: __dev_kfree_skb_any() and use of dev_kfree_skb()

2018-10-03 Thread Neil Horman
On Tue, Oct 02, 2018 at 03:20:48PM -0700, Florian Fainelli wrote: > On 10/02/2018 03:05 PM, Eric Dumazet wrote: > > On Tue, Oct 2, 2018 at 2:54 PM Florian Fainelli > > wrote: > >> > >> On 10/02/2018 02:17 PM, Eric Dumazet wrote: > >>> On Tue, Oct 2, 2018 at 1:07 PM Florian Fainelli > >>> wrote:

r8169 tx batching(?) causing performance problems

2018-10-03 Thread David Howells
Hi, Can someone help me figure out a performance issue that seems to be caused by an RTL8168g/8111g NIC that seems to be batching up transmissions - or, at least, not starting immediately that it's given something to transmit? The setup that I'm dealing with is an AFS filesystem client (the test

Kernel oops with mlx5 and dual XDP redirect programs

2018-10-03 Thread Toke Høiland-Jørgensen
Hi Saeed I can reliably oops the kernel with the mlx5 driver, by installing XDP_REDIRECT programs on two devices so they redirect to each other, and then remove them while there is traffic on the interface. Steps to reproduce: # cd ~/build/linux/samples/bpf # ./xdp_redirect_map $( 8b 8c 24 a8 3

Re: [PATCH net] ipv6: revert degradation in IPv6 Ready Logo test results

2018-10-03 Thread 吉藤英明
Hi, 2018年10月3日(水) 16:57 Mike Manning : > > On 02/10/2018 19:26, David Miller wrote: > > From: Mike Manning > > Date: Tue, 2 Oct 2018 12:40:30 +0100 > > > >> This reverts commit 0ed4229b08c1 ("ipv6: defrag: drop non-last frags > >> smaller than min mtu"). While one should not get fragments smalle

Re: [PATCH net] ipv6: revert degradation in IPv6 Ready Logo test results

2018-10-03 Thread Mike Manning
On 02/10/2018 19:26, David Miller wrote: > From: Mike Manning > Date: Tue, 2 Oct 2018 12:40:30 +0100 > >> This reverts commit 0ed4229b08c1 ("ipv6: defrag: drop non-last frags >> smaller than min mtu"). While one should not get fragments smaller than >> the IPv6 minimum MTU, not handling crafted p

Re: [PATCH] xfrm: fix gro_cells leak when remove virtual xfrm interfaces

2018-10-03 Thread Steffen Klassert
On Sun, Sep 30, 2018 at 03:06:06PM +0800, Li RongQing wrote: > The device gro_cells has been initialized, it should be freed, > otherwise it will be leaked > > Fixes: f203b76d78092faf2 ("xfrm: Add virtual xfrm interfaces") > Signed-off-by: Zhang Yu > Signed-off-by: Li RongQing Applied, thanks a