Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/ethernet/qlogic/qed/qed_ooo.c: In function 'qed_ooo_delete_isles':
drivers/net/ethernet/qlogic/qed/qed_ooo.c:354:30: warning:
variable 'p_archipelago' set but not used [-Wunused-but-set-variable]
drivers/net/ethernet/qlogic/qed/qed_ooo.
Signed-off-by: Sudarsana Reddy Kalluru
Signed-off-by: Ameen Rahman
---
MAINTAINERS | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 15565de..e941d1b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2956,7 +2956,6 @@ F:include/linux/bc
On Thu, 2018-09-27 at 13:43 +1000, Samuel Mendoza-Jonas wrote:
> On Mon, 2018-09-24 at 17:08 -0700, Vijay Khemka wrote:
> > This patch adds OEM command to get mac address from NCSI device and and
> > configure the same to the network card.
> >
> > ncsi_cmd_arg - Modified this structure to include
On Wed, Sep 26, 2018 at 8:49 PM Song Liu wrote:
>
> We also need this patch from Eric:
>
> https://marc.info/?l=linux-netdev&m=153780304905946
>
I will submit this formally tomorrow, thanks.
> On Sep 26, 2018, at 8:33 PM, David Miller wrote:
>
> From: Michael Chan
> Date: Wed, 26 Sep 2018 00:41:04 -0400
>
>> The current netpoll implementation in the bnxt_en driver has problems
>> that may miss TX completion events. bnxt_poll_work() in effect is
>> only handling at most 1 TX pac
From: "Maciej Żenczykowski"
Date: Tue, 25 Sep 2018 21:59:28 -0700
> From: Maciej Żenczykowski
>
> (fix documentation and sysctl access to treat it as such)
>
> Tested:
> # zcat /proc/config.gz | egrep ^CONFIG_HZ
> CONFIG_HZ_1000=y
> CONFIG_HZ=1000
> # echo $[(1<<32)/1000 + 1] | tee /pr
From: Michael Chan
Date: Wed, 26 Sep 2018 00:41:04 -0400
> The current netpoll implementation in the bnxt_en driver has problems
> that may miss TX completion events. bnxt_poll_work() in effect is
> only handling at most 1 TX packet before exiting. In addition,
> there may be in flight TX compl
From: "Maciej Żenczykowski"
Date: Tue, 25 Sep 2018 20:56:26 -0700
> From: Maciej Żenczykowski
>
> (the parameters in question are mark and flow_flags)
>
> Reviewed-by: David Ahern
> Signed-off-by: Maciej Żenczykowski
Applied.
From: "Maciej Żenczykowski"
Date: Tue, 25 Sep 2018 20:56:27 -0700
> From: Maciej Żenczykowski
>
> (the parameters in question are mark and flow_flags)
>
> Reviewed-by: David Ahern
> Signed-off-by: Maciej Żenczykowski
Applied.
From: Hangbin Liu
Date: Wed, 26 Sep 2018 10:35:42 +0800
> When add vxlan ttl inherit support, I forgot to fill it when dump
> vlxan info. Fix it now.
>
> Fixes: 72f6d71e491e6 ("vxlan: add ttl inherit support")
> Signed-off-by: Hangbin Liu
Applied and queued up for -stable.
From: Andrew Lunn
Date: Tue, 25 Sep 2018 01:50:00 +0200
> A HWMON device is only registered is the SFP module supports the
> diagnostic page and is complient to SFF8472. Don't unconditionally
> unregister the hwmon device when the SFP module is remove, otherwise
> we access data structures which
From: Mahesh Bandewar
Date: Mon, 24 Sep 2018 14:40:11 -0700
> From: Mahesh Bandewar
>
> Syzkaller reported this on a slightly older kernel but it's still
> applicable to the current kernel -
...
> Signed-off-by: Mahesh Bandewar
Applied and queued up for -stable.
From: Mahesh Bandewar
Date: Mon, 24 Sep 2018 14:39:42 -0700
> From: Mahesh Bandewar
>
> Commit b89f04c61efe ("bonding: deliver link-local packets with
> skb->dev set to link that packets arrived on") changed the behavior
> of how link-local-multicast packets are processed. The change in
> the b
From: Heiner Kallweit
Date: Mon, 24 Sep 2018 23:36:50 +0200
> diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
> index a1f8e4816..40a7dc101 100644
> --- a/drivers/net/phy/phy.c
> +++ b/drivers/net/phy/phy.c
...
> @@ -635,6 +635,13 @@ int phy_speed_up(struct phy_device *phydev)
> }
>
On Thu, 27 Sep 2018 at 00:39, wrote:
>
> > > As I understand Justin's version adds a generic handler, using the NCSI
> > > Netlink interface to pass OEM commands and responses to and from
> > > userspace, which does the actual packet handling.
> > Thanks for the direction Sam! Justin, if you do
From: Dave Jones
Date: Mon, 24 Sep 2018 15:23:17 -0400
> Callers of bond_for_each_slave_rcu are expected to hold the rcu lock,
> otherwise a trace like below is shown
...
> Signed-off-by: Dave Jones
Hey Dave, after some recent changes by Eric Dumazet this no longer
applies.
Please respin agai
From: Heiner Kallweit
Date: Mon, 24 Sep 2018 21:58:04 +0200
> phy_suspend doesn't always recognize that WoL is enabled and therefore
> suspends the PHY when it should not. First idea to address the issue
> was to reuse checks used in mdio_bus_phy_may_suspend which check
> whether relevant devices
From: dsah...@kernel.org
Date: Wed, 26 Sep 2018 17:35:14 -0700
> From: David Ahern
>
> The change to move metrics from the dst to rt6_info moved the call
> to ip6_convert_metrics from ip6_route_add to ip6_route_info_create. In
> doing so it makes the call in ip6_route_info_append redundant and
>
Hi
Situated in (United Kingdom) DEBENHAMS RETAIL PLC is a retailer shop
furnished by European products.We are looking to buy ( Fashion
items,Perfumes, Lighters, Tiles Marbles, Wooden Floors, Smart-phones,
Tablets,Laptops, TVs, Air conditioner etc...) and find new partnership
with companies
On Wed, 26 Sep 2018 23:54:17 +, Andrey Ignatov wrote:
> Jakub Kicinski [Wed, 2018-09-26 16:20 -0700]:
> > On Wed, 26 Sep 2018 15:24:52 -0700, Andrey Ignatov wrote:
> > > This patch set introduces libbpf_attach_type_by_name function in libbpf to
> > > identify attach type by section name.
> >
Hello
Please i still await your response regarding my previous email.
Hello
Please i still await your response regarding my previous email.
On 09/25/2018 08:38 AM, Daniel Borkmann wrote:
> On 09/24/2018 10:49 PM, Willem de Bruijn wrote:
>> From: Willem de Bruijn
>>
>> BPF flow dissectors are configured per network namespace.
>> __skb_flow_dissect looks up the netns through dev_net(skb->dev).
>>
>> In some dissector paths skb->dev i
From: David Ahern
The change to move metrics from the dst to rt6_info moved the call
to ip6_convert_metrics from ip6_route_add to ip6_route_info_create. In
doing so it makes the call in ip6_route_info_append redundant and
actually leaks the metrics installed as part of the ip6_route_info_create.
Hello
Please i still await your response regarding my previous email.
On 09/26/2018 04:46 PM, stran...@codeaurora.org wrote:
> Hi Eric,
>
> Someone recently reported a crash to us on the 4.14.62 kernel where excessive
> WARNING prints were spamming the logs and causing watchdog bites. The kernel
> does have the following commit by Soheil:
> bffd168c3fc5 "tcp: cle
Jakub Kicinski [Wed, 2018-09-26 16:20 -0700]:
> On Wed, 26 Sep 2018 15:24:52 -0700, Andrey Ignatov wrote:
> > This patch set introduces libbpf_attach_type_by_name function in libbpf to
> > identify attach type by section name.
> >
> > This is useful to avoid writing same logic over and over again
Hi Eric,
Someone recently reported a crash to us on the 4.14.62 kernel where
excessive
WARNING prints were spamming the logs and causing watchdog bites. The
kernel
does have the following commit by Soheil:
bffd168c3fc5 "tcp: clear tp->packets_out when purging write queue"
Before this bug we s
On 09/26/2018 02:22 PM, Daniel Borkmann wrote:
> On 09/26/2018 11:09 PM, Tetsuo Handa wrote:
>> Hello, Alexei and Daniel.
>>
>> Can you show us how to run testcases you are testing?
>
> Sorry for the delay; currently quite backlogged but will definitely take a
> look
> at these reports. Regarding
On Wed, 26 Sep 2018 15:24:52 -0700, Andrey Ignatov wrote:
> This patch set introduces libbpf_attach_type_by_name function in libbpf to
> identify attach type by section name.
>
> This is useful to avoid writing same logic over and over again in user
> space applications that leverage libbpf.
>
>
Reserve two TLV types for feature development, and warn in the driver
if they ever leak into production.
Signed-off-by: Jakub Kicinski
Reviewed-by: Simon Horman
---
drivers/net/ethernet/netronome/nfp/nfp_net_ctrl.c | 7 +++
drivers/net/ethernet/netronome/nfp/nfp_net_ctrl.h | 8
2 f
On Mon, 24 Sep 2018 at 05:22, Daniel Borkmann wrote:
>
> On 09/21/2018 07:10 PM, Joe Stringer wrote:
> > reference tracking: leak potential reference
> > reference tracking: leak potential reference on stack
> > reference tracking: leak potential reference on stack 2
> > reference tracking: zero p
Add section names for BPF_SK_SKB_STREAM_PARSER and
BPF_SK_SKB_STREAM_VERDICT attach types to be able to identify them in
libbpf_attach_type_by_name.
"stream_parser" and "stream_verdict" are used instead of simple "parser"
and "verdict" just to avoid possible confusion in a place where attach
type
Add selftest for libbpf functions libbpf_prog_type_by_name and
libbpf_attach_type_by_name.
Example of output:
% ./tools/testing/selftests/bpf/test_section_names
Summary: 35 PASSED, 0 FAILED
Signed-off-by: Andrey Ignatov
---
tools/testing/selftests/bpf/Makefile | 2 +-
.../selftes
Use newly introduced libbpf_attach_type_by_name in test_socket_cookie
selftest.
Signed-off-by: Andrey Ignatov
---
tools/testing/selftests/bpf/test_socket_cookie.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/tools/testing/selftests/bpf/test_socket_cookie.c
b/tools/te
This patch set introduces libbpf_attach_type_by_name function in libbpf to
identify attach type by section name.
This is useful to avoid writing same logic over and over again in user
space applications that leverage libbpf.
Patch 1 has more details on the new function and problem being solved.
P
There is a common use-case when ELF object contains multiple BPF
programs and every program has its own section name. If it's cgroup-bpf
then programs have to be 1) loaded and 2) attached to a cgroup.
It's convenient to have information necessary to load BPF program
together with program itself. T
Add section names for BPF_CGROUP_INET_INGRESS and BPF_CGROUP_INET_EGRESS
attach types to be able to identify them in libbpf_attach_type_by_name.
"cgroup_skb" is used instead of "cgroup/skb" mostly to easy possible
unifying of how libbpf and bpftool works with section names:
* bpftool uses "cgroup_
On 22/08/2018 20:00, Edward Cree wrote:
The first patch is a simplification of register liveness tracking by using
a separate parentage chain for each register and stack slot, thus avoiding
the need for logic to handle callee-saved registers when applying read
marks. In the future this idea m
> When you run ethtool -m on this driver, the kernel calls
> mlx4_en_get_module_info
> to determine the length of the eeprom, and that value will be either 256 or
> 512
> bytes.
So it sounds like QSFP modules using 8636 are not supported. You would
expect a size to be one of 256, 384, 512 or 640
On Wed, Sep 26, 2018 at 08:47:34PM +, Chris Preimesberger wrote:
> Hello Andrew,
>
> Thank you for the quick response!!
> Apologies in advance for my use of outlook and top-posting, etc...
>
> I've run the raw option and the hex option, and pasted the results below.
> Since the raw option pri
On Wed, Sep 26, 2018 at 07:29:23PM +, Chris Preimesberger wrote:
> Hello,
>
> I'm re-sending in plain text per the auto-reply from a spam filter. I have
> attached some text files this time, which explain the situation below, in
> case the below email's font & formatting is now too messed u
On 09/26/2018 11:09 PM, Tetsuo Handa wrote:
> Hello, Alexei and Daniel.
>
> Can you show us how to run testcases you are testing?
Sorry for the delay; currently quite backlogged but will definitely take a look
at these reports. Regarding your question: majority of test cases are in the
kernel tre
On 09/26/2018 09:44 PM, Jonathan Corbet wrote:
> On Wed, 26 Sep 2018 18:11:42 +0900
> Chang-an Song wrote:
>
>>> - The original document has a copyright assertion but no associated
>>>license. Do we know what the license is? I assume it's something
>>>that is free and GPL-compatible, b
Hello, Alexei and Daniel.
Can you show us how to run testcases you are testing?
On 2018/09/22 22:25, Tetsuo Handa wrote:
> Hello.
>
> syzbot is reporting many lockup problems on bpf.git / bpf-next.git / net.git
> / net-next.git trees.
>
> INFO: rcu detected stall in br_multicast_port_group_e
Dan Carpenter wrote on Wed, Sep 26, 2018:
> p9_tag_alloc() is supposed to return error pointers, but we accidentally
> return a NULL here. It would cause a NULL dereference in the caller.
>
> Fixes: 996d5b4db4b1 ("9p: Use a slab for allocating requests")
> Signed-off-by: Dan Carpenter
Good catc
From: Soheil Hassas Yeganeh
When we have less than PAGE_SIZE of data on receive queue,
we set recv_skip_hint to 0. Instead, set it to the actual
number of bytes available.
Signed-off-by: Soheil Hassas Yeganeh
Signed-off-by: Eric Dumazet
---
net/ipv4/tcp.c | 14 +-
1 file changed,
From: Soheil Hassas Yeganeh
When SKBs are coalesced, we can have SKBs with different
frag sizes. Some with PAGE_SIZE and some not with PAGE_SIZE.
Since recv_skip_hint is always set to the full SKB size,
it can overestimate the amount that should be read using
normal read for coalesced packets.
C
Hello Andrew,
Thank you for the quick response!!
Apologies in advance for my use of outlook and top-posting, etc...
I've run the raw option and the hex option, and pasted the results below.
Since the raw option printed strange characters on the CLI, I re-ran it,
Sending the output to a file (raw.
> > As I understand Justin's version adds a generic handler, using the NCSI
> > Netlink interface to pass OEM commands and responses to and from
> > userspace, which does the actual packet handling.
> Thanks for the direction Sam! Justin, if you don't mind, can you share the
> patches you have
From: Johannes Berg
Fix a simple typo: attribuets -> attributes
Signed-off-by: Johannes Berg
---
include/net/netlink.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/net/netlink.h b/include/net/netlink.h
index ddabc832febc..69866f5a97f2 100644
--- a/include/net/net
Disable the clk during suspend to save power. Note that tp->clk may be
NULL, the clk core functions handle this without problems.
Reviewed-by: Andy Shevchenko
Tested-by: Carlo Caione
Signed-off-by: Hans de Goede
---
drivers/net/ethernet/realtek/r8169.c | 5 +
1 file changed, 5 insertions(+
In regular NIC transmission flow, driver always configures MAC using
Tx queue zero descriptor as a part of MAC learning flow.
But with multi Tx queue supported NIC, regular transmission can occur on
any non-zero Tx queue and from that context it uses
Tx queue zero descriptor to configure MAC, at th
On Wed, Sep 26, 2018 at 07:29:23PM +, Chris Preimesberger wrote:
> Hello,
>
> I'm re-sending in plain text per the auto-reply from a spam filter.
Yep. no html obfustication accepted here. Please ASCII only please :-)
Please can you also wrap your lines at about 75 characters.
> I have atta
On Wed, 26 Sep 2018 18:11:42 +0900
Chang-an Song wrote:
> > - The original document has a copyright assertion but no associated
> >license. Do we know what the license is? I assume it's something
> >that is free and GPL-compatible, but that would be good to know for
> >sure.
>
>
Hello,
I'm re-sending in plain text per the auto-reply from a spam filter. I have
attached some text files this time, which explain the situation below, in case
the below email's font & formatting is now too messed up for easy comprehension.
Thank you and best regards.
Chris Preimesberger |
On 09/25/2018 12:19 PM, Pablo Neira Ayuso wrote:
> These actions need to be added to support bcm sf2 features available
> through the ethtool_rx_flow interface.
>
> Signed-off-by: Pablo Neira Ayuso
Reviewed-by: Florian Fainelli
--
Florian
On 09/26/2018 08:51 AM, Jakub Kicinski wrote:
> On Tue, 25 Sep 2018 21:19:51 +0200, Pablo Neira Ayuso wrote:
>> This patchset is adding a new layer between drivers and the existing
>> software frontends, so it's a bit more code, but it is core
>> infrastructure common to everyone and this comes wit
Hi Pablo,
On 09/25/2018 12:20 PM, Pablo Neira Ayuso wrote:
> Update this driver to use the flow_rule infrastructure, hence the same
> code to populate hardware IR can be used from ethtool_rx_flow and the
> cls_flower interfaces.
Thanks for doing the conversion, I believe we could change things a
This patch fixes the bug that all datapath and vport ops are returning
wrong values (OVS_FLOW_CMD_NEW or OVS_DP_CMD_NEW) in their replies.
Signed-off-by: Yifeng Sun
---
net/openvswitch/datapath.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/net/openv
From: Julian Wiedmann
Date: Wed, 26 Sep 2018 18:07:08 +0200
> please apply two qeth patches for -net. The first is a trivial cleanup
> required for patch #2 by Jean, which fixes a potential endless loop.
Series applied, thank you.
From: Wei Yongjun
Date: Wed, 26 Sep 2018 12:20:00 +
> Fixes the following sparse warning:
>
> drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c:873:5: warning:
> symbol 'aq_fw1x_set_power' was not declared. Should it be static?
>
> Fixes: a0da96c08cfa ("net: aquantia: implement
From: Wei Yongjun
Date: Wed, 26 Sep 2018 12:09:45 +
> Fixes the following sparse warning:
>
> net/core/gen_stats.c:166:1: warning:
> symbol '___gnet_stats_copy_basic' was not declared. Should it be static?
>
> Fixes: 5e111210a443 ("net/core: Add new basic hardware counter")
> Signed-off-by
From: Wei Yongjun
Date: Wed, 26 Sep 2018 12:10:48 +
> Fixes the following sparse warning:
>
> net/tls/tls_sw.c:655:16: warning:
> symbol 'get_rec' was not declared. Should it be static?
>
> Fixes: a42055e8d2c3 ("net/tls: Add support for async encryption of records
> for performance")
> Si
On Tue, Sep 25, 2018 at 2:34 AM, Patrick Ruddy
wrote:
> On Wed, 2018-09-19 at 21:47 -0700, David Ahern wrote:
>> On 9/18/18 6:12 AM, Patrick Ruddy wrote:
>> >
>> > I've hit a small snag with adding the new groups. The number of defined
>> > groups currently sits at 31 so I can only add one before
From: Johannes Berg
Date: Wed, 26 Sep 2018 11:15:29 +0200
> This adds nested policy validation, which lets you specify the
> nested attribute type, e.g. NLA_NESTED with sub-policy, or the
> new NLA_NESTED_ARRAY with sub-sub-policy.
>
>
> Changes in v2:
> * move setting the bad attr pointer/mes
>Hi Vijay,
> Thanks for the patch; before I get too into a review though I'd like to
> loop in Justin (cc'd) who I know is also working on an OEM command patch.
> The changes here are very specific (eg. a command specific config option
> "CONFIG_NCSI_OEM_CMD_GET_MAC"), which is ok
From: Julian Wiedmann
Date: Wed, 26 Sep 2018 18:29:01 +0200
> please apply one more series of cleanups and small improvements for qeth
> to net-next. Note that one patch needs to touch both af_iucv and qeth, in
> order to untangle their receive paths.
Series applied, thank you.
The cdev-to-card translation walks through two layers of drvdata,
with no locking or refcounting (where eg. the ccwgroup core only
accesses a cdev's drvdata while holding the ccwlock).
This might be safe for now, but any careless usage of the helper has the
potential for subtle races and use-after
If qeth_check_ipa_data() consumed an event, there's no point in
processing it further. So drop it early, and make the surrounding code
a tiny bit more readable.
Signed-off-by: Julian Wiedmann
---
drivers/s390/net/qeth_core_main.c | 21 +++--
1 file changed, 11 insertions(+), 10 d
1. tracing iob->rc makes no sense when it hasn't been modified by the
callback,
2. the qeth_dbf_list is declared with LIST_HEAD, which also initializes
the list,
3. the ccwgroup core only calls the thaw/restore callbacks if the gdev
is online, so we don't have to check for it again.
Signe
The netdevice is always available, apply any carrier state changes to it
without caching them.
On a STARTLAN event (ie. carrier-up), defer updating the state to
qeth_core_hardsetup_card() in the subsequent recovery action.
Also remove the carrier-state checks from the xmit routines. Stopping
trans
Pull one level of checking up into qeth_send_control_data_cb(), and
clean up an else-after-return. No functional change.
Signed-off-by: Julian Wiedmann
---
drivers/s390/net/qeth_core_main.c | 129 +-
1 file changed, 58 insertions(+), 71 deletions(-)
diff --gi
Hi Dave,
please apply one more series of cleanups and small improvements for qeth
to net-next. Note that one patch needs to touch both af_iucv and qeth, in
order to untangle their receive paths.
Thanks,
Julian
Julian Wiedmann (15):
s390/qeth: convert layer attribute to enum
s390/qeth: use D
We have no code that is waiting for these events, so just drop them when
they arrive.
Signed-off-by: Julian Wiedmann
---
drivers/s390/net/qeth_core_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/s390/net/qeth_core_main.c
b/drivers/s390/net/qeth_core_main.
This allows us to remove the CARD_FROM_CDEV calls in the iob callbacks.
Signed-off-by: Julian Wiedmann
---
drivers/s390/net/qeth_core.h | 3 ++-
drivers/s390/net/qeth_core_main.c | 53 ++-
2 files changed, 32 insertions(+), 24 deletions(-)
diff --git a/
When not using the CQ, this allows us avoid the second skb queue walk
in qeth_release_skbs().
Signed-off-by: Julian Wiedmann
---
drivers/s390/net/qeth_core_main.c | 29 +
1 file changed, 5 insertions(+), 24 deletions(-)
diff --git a/drivers/s390/net/qeth_core_main.c
This was presumably left over from back when qeth recursed into
dev_queue_xmit().
Signed-off-by: Julian Wiedmann
---
drivers/s390/net/qeth_core_main.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/s390/net/qeth_core_main.c
b/drivers/s390/net/qeth_core_main.c
index c5c40c6d8b7d..0
To match the use of __skb_queue_purge(), also make the skb's enqueue in
qeth_fill_buffer() lockless.
Signed-off-by: Julian Wiedmann
---
drivers/s390/net/qeth_core_main.c | 19 ---
1 file changed, 4 insertions(+), 15 deletions(-)
diff --git a/drivers/s390/net/qeth_core_main.c
b/
This patch attempts to untangle the TX and RX code in qeth from
af_iucv's respective HiperTransport path:
On the TX side, pointing skb_network_header() at the IUCV header
means that qeth_l3_fill_af_iucv_hdr() no longer needs a magical offset
to access the header.
On the RX side, qeth pulls the (fak
Device initialization code usually first loads a subdriver
(via qeth_core_load_discipline()), and then runs its setup() callback.
If this fails, it rolls back the load via qeth_core_free_discipline().
qeth_core_free_discipline() expects the options.layer attribute to be
initialized, but on error i
qeth_core_probe_device() sets the gdev's drvdata, but doesn't reset it
on a subsequent error. Move the (re-)setting around a bit, so that it
happens symmetrically on allocating/freeing the qeth_card struct.
This is no actual problem, as the ccwgroup core will discard the gdev
on a probe error. But
Consolidate declaration and initialization of a static variable.
While at it reduce its scope in qeth_core_load_discipline(), and simplify
the return logic accordingly.
Signed-off-by: Julian Wiedmann
---
drivers/s390/net/qeth_core_main.c | 13 ++---
1 file changed, 6 insertions(+), 7 del
While the raw values are fixed due to their use in a sysfs attribute,
we can still use the proper QETH_DISCIPLINE_* enum within the driver.
Also move the initialization into qeth_set_initial_options(), along with
all other user-configurable fields.
Signed-off-by: Julian Wiedmann
---
drivers/s39
> On Sep 25, 2018, at 9:41 PM, Michael Chan wrote:
>
> The current netpoll implementation in the bnxt_en driver has problems
> that may miss TX completion events. bnxt_poll_work() in effect is
> only handling at most 1 TX packet before exiting. In addition,
> there may be in flight TX comple
From: Jean Delvare
Functions qeth_get_ipa_msg and qeth_get_ipa_cmd_name are modifying
the last member of global arrays without any locking that I can see.
If two instances of either function are running at the same time,
it could cause a race ultimately leading to an array overrun (the
contents o
From: zhong jiang
Use the common code ARRAY_SIZE macro instead of a private implementation.
Reviewed-by: Jean Delvare
Signed-off-by: zhong jiang
Signed-off-by: Martin Schwidefsky
Signed-off-by: Julian Wiedmann
---
drivers/s390/net/qeth_core_mpc.c | 7 ++-
1 file changed, 2 insertions(+)
Hi Dave,
please apply two qeth patches for -net. The first is a trivial cleanup
required for patch #2 by Jean, which fixes a potential endless loop.
Thanks,
Julian
Jean Delvare (1):
s390: qeth: Fix potential array overrun in cmd/rc lookup
zhong jiang (1):
s390: qeth_core_mpc: Use ARRAY_SIZ
On Tue, 25 Sep 2018 21:19:51 +0200, Pablo Neira Ayuso wrote:
> This patchset is adding a new layer between drivers and the existing
> software frontends, so it's a bit more code, but it is core
> infrastructure common to everyone and this comes with benefits for
> driver developers:
Thanks a lot f
On Wed, 26 Sep 2018 at 17:50, Jason A. Donenfeld wrote:
>
> On Wed, Sep 26, 2018 at 5:45 PM Jason A. Donenfeld wrote:
> > So what you have in mind is something like calling simd_relax() every
> > 4096 bytes or so?
>
> That was actually pretty easy, putting together both of your suggestions:
>
> s
On Tue, 25 Sep 2018 21:19:55 +0200, Pablo Neira Ayuso wrote:
> This implements TC action to flow_action translation from cls_flower.
>
> Signed-off-by: Pablo Neira Ayuso
> ---
> net/sched/cls_flower.c | 124
> -
> 1 file changed, 123 insertions(+)
On 09/25/2018 10:42 PM, Harini Katakam wrote:
Hi,
On Tue, Sep 25, 2018 at 11:00 PM Harini Katakam wrote:
Hi Daniel,
On Tue, Sep 25, 2018 at 9:10 PM Andrew Lunn wrote:
I hope this this thread isn't too old to bring back to life. So it seems
that Harini found that m88e did not need this
On Wed, 26 Sep 2018 08:54:43 -0600
David Ahern wrote:
> On 9/25/18 11:51 PM, Jiri Benc wrote:
> > On Tue, 25 Sep 2018 09:37:41 -0600, David Ahern wrote:
> >> For ifaddrmsg ifa_flags aligns with ifi_type which is set by kernel side
> >> so this should be ok.
> >
> > Does the existing user spa
On 9/25/18 11:51 PM, Jiri Benc wrote:
> On Tue, 25 Sep 2018 09:37:41 -0600, David Ahern wrote:
>> For ifaddrmsg ifa_flags aligns with ifi_type which is set by kernel side
>> so this should be ok.
>
> Does the existing user space set ifi_type to anything? Does it zero out
> the field?
>
> Are we a
Den tis 25 sep. 2018 kl 16:57 skrev Jakub Kicinski
:
>
> On Mon, 24 Sep 2018 18:35:55 +0200, Björn Töpel wrote:
> > + if (adapter->flags & IXGBE_FLAG_SRIOV_ENABLED)
> > + return -EINVAL;
> > +
> > + if (adapter->flags & IXGBE_FLAG_DCB_ENABLED)
> > + return -EINVAL;
>
On 26 Sep 2018, at 14:09, Wei Yongjun wrote:
> Fixes the following sparse warning:
>
> net/core/gen_stats.c:166:1: warning:
> symbol '___gnet_stats_copy_basic' was not declared. Should it be static?
>
Thanks for fixing my commit ;)
Acked-by: Eelco Chaudron
> Fixes: 5e111210a443 ("net/core:
Fixes the following sparse warning:
drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c:873:5: warning:
symbol 'aq_fw1x_set_power' was not declared. Should it be static?
Fixes: a0da96c08cfa ("net: aquantia: implement WOL support")
Signed-off-by: Wei Yongjun
---
drivers/net/ethernet/aq
Fixes the following sparse warning:
net/tls/tls_sw.c:655:16: warning:
symbol 'get_rec' was not declared. Should it be static?
Fixes: a42055e8d2c3 ("net/tls: Add support for async encryption of records for
performance")
Signed-off-by: Wei Yongjun
---
net/tls/tls_sw.c | 2 +-
1 file changed, 1
Fixes the following sparse warning:
net/core/gen_stats.c:166:1: warning:
symbol '___gnet_stats_copy_basic' was not declared. Should it be static?
Fixes: 5e111210a443 ("net/core: Add new basic hardware counter")
Signed-off-by: Wei Yongjun
---
net/core/gen_stats.c | 2 +-
1 file changed, 1 inser
The exception spec is targeted for Real Time Alerting, in order to know when
something bad had happened to a PCI device
- Provide alert debug information
- Self healing
- If problem needs vendor support, provide a way to gather all needed debugging
information.
The exception mechanism contains c
1 - 100 of 117 matches
Mail list logo
