Re: [PATCH net-next] net: stmmac: Add PPS and Flexible PPS support

2018-05-24 Thread kbuild test robot
Hi Jose, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Jose-Abreu/net-stmmac-Add-PPS-and-Flexible-PPS-support/20180525-074128 config: i386-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-

Re: [PATCH net-next 0/8] nfp: offload LAG for tc flower egress

2018-05-24 Thread Jiri Pirko
Thu, May 24, 2018 at 04:22:47AM CEST, jakub.kicin...@netronome.com wrote: >Hi! > >This series from John adds bond offload to the nfp driver. Patch 5 >exposes the hash type for NETDEV_LAG_TX_TYPE_HASH to make sure nfp >hashing matches that of the software LAG. This may be unnecessarily >conservati

Re: [PATCH 0/4] RFC CPSW switchdev mode

2018-05-24 Thread Ilias Apalodimas
On Thu, May 24, 2018 at 06:33:10PM +0200, Andrew Lunn wrote: > On Thu, May 24, 2018 at 07:02:54PM +0300, Ilias Apalodimas wrote: > > On Thu, May 24, 2018 at 05:25:59PM +0200, Andrew Lunn wrote: > > > O.K, back to the basic idea. Switch ports are just normal Linux > > > interfaces. > > > > > > How

Re: [PATCH 0/6] ravb/sh_eth: fix sleep in atomic by reusing shared ethtool handlers

2018-05-24 Thread Vladimir Zapolskiy
Hello Sergei, On 05/24/2018 08:24 PM, Sergei Shtylyov wrote: > On 05/24/2018 07:40 PM, Sergei Shtylyov wrote: > >>> For ages trivial changes to RAVB and SuperH ethernet links by means of >>> standard 'ethtool' trigger a 'sleeping function called from invalid >>> context' bug, to visualize it on r

Re: [PATCH net-next] net: phy: convert further flags in struct phy_device to bit-field

2018-05-24 Thread Heiner Kallweit
Am 25.05.2018 um 01:03 schrieb Florian Fainelli: > On 05/24/2018 01:15 PM, Heiner Kallweit wrote: >> This patch is a follow-up to 87e5808d52b6 ("net: phy: replace bool >> members in struct phy_device with bit-fields") and converts further >> flags to bit-fields. > > This looks fine, but then you w

Re: [PATCH 1/6] ravb: remove custom .nway_reset from ethtool ops

2018-05-24 Thread Vladimir Zapolskiy
Hello Sergei, On 05/24/2018 08:01 PM, Sergei Shtylyov wrote: > On 05/24/2018 07:44 PM, Andrew Lunn wrote: > >> The change fixes a sleep in atomic context issue, which can be >> always triggered by running 'ethtool -r' command, because >> phy_start_aneg() protects phydev fields by a mu

Re: [PATCH net-next] net:sched: add action inheritdsfield to skbmod

2018-05-24 Thread Fu, Qiaobin
Hi Marcelo, Thanks for pointing out these style issues. Below is the updated version: --- The new action inheritdsfield copies the field DS of IPv4 and IPv6 packets into skb->priority. This enables later classification of packets based on the DS field. Original idea by Jamal Hadi Salim Signed-

[PATCH v3 bpf-next 0/5] bpf: Hooks for sys_sendmsg

2018-05-24 Thread Andrey Ignatov
v2 -> v3: * place BPF logic under static key in udp_sendmsg, udpv6_sendmsg; * rebase. v1 -> v2: * return ENOTSUPP if bpf_prog rewrote IPv6-only with IPv4-mapped IPv6; * add test for IPv4-mapped IPv6 use-case; * fix build for CONFIG_CGROUP_BPF=n; * rebase. This path set adds BPF hooks for sys_send

[PATCH v3 bpf-next 2/5] bpf: Sync bpf.h to tools/

2018-05-24 Thread Andrey Ignatov
Sync new `BPF_CGROUP_UDP4_SENDMSG` and `BPF_CGROUP_UDP6_SENDMSG` attach types to tools/. Signed-off-by: Andrey Ignatov Acked-by: Alexei Starovoitov Acked-by: Martin KaFai Lau --- tools/include/uapi/linux/bpf.h | 8 1 file changed, 8 insertions(+) diff --git a/tools/include/uapi/linux

[PATCH v3 bpf-next 1/5] bpf: Hooks for sys_sendmsg

2018-05-24 Thread Andrey Ignatov
In addition to already existing BPF hooks for sys_bind and sys_connect, the patch provides new hooks for sys_sendmsg. It leverages existing BPF program type `BPF_PROG_TYPE_CGROUP_SOCK_ADDR` that provides access to socket itlself (properties like family, type, protocol) and user-passed `struct sock

[PATCH v3 bpf-next 5/5] selftests/bpf: Selftest for sys_sendmsg hooks

2018-05-24 Thread Andrey Ignatov
Add selftest for BPF_CGROUP_UDP4_SENDMSG and BPF_CGROUP_UDP6_SENDMSG attach types. Try to sendmsg(2) to specific IP:port and test that: * source IP is overridden as expected. * remote IP:port pair is overridden as expected; Both UDPv4 and UDPv6 are tested. Output: # test_sock_addr.sh 2>/dev/nu

[PATCH v3 bpf-next 3/5] libbpf: Support guessing sendmsg{4,6} progs

2018-05-24 Thread Andrey Ignatov
libbpf can guess prog type and expected attach type based on section name. Add hints for "cgroup/sendmsg4" and "cgroup/sendmsg6" section names. Signed-off-by: Andrey Ignatov Acked-by: Alexei Starovoitov Acked-by: Martin KaFai Lau --- tools/lib/bpf/libbpf.c | 2 ++ 1 file changed, 2 insertions(

[PATCH v3 bpf-next 4/5] selftests/bpf: Prepare test_sock_addr for extension

2018-05-24 Thread Andrey Ignatov
test_sock_addr was not easy to extend since it was focused on sys_bind and sys_connect quite a bit. Reorganized it so that it'll be easier to cover new test-cases for `BPF_PROG_TYPE_CGROUP_SOCK_ADDR`: - decouple test-cases so that only one BPF prog is tested at a time; - check programmatically t

Re: [PATCH 4/4] cpsw: add switchdev support

2018-05-24 Thread Ilias Apalodimas
On Thu, May 24, 2018 at 06:39:04PM +0200, Andrew Lunn wrote: > On Thu, May 24, 2018 at 04:32:34PM +0300, Ilias Apalodimas wrote: > > On Thu, May 24, 2018 at 03:12:29PM +0200, Andrew Lunn wrote: > > > Device tree is supposed to describe the hardware. Using that hardware > > > in different ways is no

Re: [PATCH v2 bpf-next 1/5] bpf: Hooks for sys_sendmsg

2018-05-24 Thread Andrey Ignatov
Daniel Borkmann [Thu, 2018-05-24 18:00 -0700]: > On 05/23/2018 01:40 AM, Andrey Ignatov wrote: > [...] > > diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c > > index ff4d4ba..a1f9ba2 100644 > > --- a/net/ipv4/udp.c > > +++ b/net/ipv4/udp.c > > @@ -900,6 +900,7 @@ int udp_sendmsg(struct sock *sk, struc

RE: [PATCH 5/5] MAINTAINERS: add myself as maintainer for QorIQ PTP clock driver

2018-05-24 Thread Y.b. Lu
This patch has a dependency which is now on staging git tree. https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/commit/?h=staging-next&id=7fd899fff5907dbb02089494102ef628988f2330 > -Original Message- > From: Yangbo Lu [mailto:yangbo...@nxp.com] > Sent: Friday, May 25, 201

[PATCH 3/5] net: ethernet: gianfar_ethtool: get phc index through drvdata

2018-05-24 Thread Yangbo Lu
Global variable gfar_phc_index was used to get and store phc index through gianfar_ptp driver. However gianfar_ptp had been renamed as ptp_qoriq for QorIQ common PTP driver. This gfar_phc_index doesn't work any more, and the phc index is stored in drvdata now. This patch is to support getting phc i

[PATCH 1/5] ptp: rework gianfar_ptp as QorIQ common PTP driver

2018-05-24 Thread Yangbo Lu
gianfar_ptp was the PTP clock driver for 1588 timer module of Freescale QorIQ eTSEC (Enhanced Three-Speed Ethernet Controllers) platforms. Actually QorIQ DPAA (Data Path Acceleration Architecture) platforms is also using the same 1588 timer module in hardware. This patch is to rework gianfar_ptp a

[PATCH 2/5] ptp_qoriq: move some definitions to header file

2018-05-24 Thread Yangbo Lu
This patch is to move some definitions in ptp_qoriq.c to the header file. Signed-off-by: Yangbo Lu --- drivers/ptp/ptp_qoriq.c | 132 +-- include/linux/fsl/ptp_qoriq.h | 141 + 2 files changed, 142 insertions(+),

[PATCH 5/5] MAINTAINERS: add myself as maintainer for QorIQ PTP clock driver

2018-05-24 Thread Yangbo Lu
Added myself as maintainer for QorIQ PTP clock driver. Since gianfar_ptp.c was renamed to ptp_qoriq.c, let's also maintain it under QorIQ PTP clock driver. Signed-off-by: Yangbo Lu --- MAINTAINERS | 17 + 1 files changed, 9 insertions(+), 8 deletions(-) diff --git a/MAINTAINER

[PATCH 4/5] dt-bindings: ptp: add ptp-qoriq.txt

2018-05-24 Thread Yangbo Lu
This patch is to add a documentation for ptp_qoriq dt-bindings. The description for ptp_qoriq dt-bindings was actually moved from Documentation/devicetree/bindings/net/fsl-tsec-phy.txt, since gianfar_ptp driver was moved to ptp_qoriq driver. Signed-off-by: Yangbo Lu --- .../devicetree/bindings/n

Re: STMMAC driver with TSO enabled issue

2018-05-24 Thread Bhadram Varka
Hi Jose, On 5/24/2018 3:01 PM, Jose Abreu wrote: Hi Bhadram, On 24-05-2018 06:58, Bhadram Varka wrote: After some time if check Tx descriptor status - then I see only below [..] [85788.286730] 027 [0x827951b0]: 0xf854f000 0x0 0x16d8 0x9000 index 025 and 026 descriptors processed but not

[PATCH net] tun: Fix NULL pointer dereference in XDP redirect

2018-05-24 Thread Toshiaki Makita
Calling XDP redirection requires preempt/bh disabled. Especially softirq can call another XDP function and redirection functions, then percpu value ri->map can be overwritten to NULL. This is a generic XDP case called from tun. [ 3535.736058] BUG: unable to handle kernel NULL pointer dereference

Re: [PATCH net] ipv4: remove warning in ip_recv_error

2018-05-24 Thread Willem de Bruijn
On Thu, May 24, 2018 at 10:18 PM, David Miller wrote: > From: Willem de Bruijn > Date: Wed, 23 May 2018 14:29:52 -0400 > >> From: Willem de Bruijn >> >> A precondition check in ip_recv_error triggered on an otherwise benign >> race. Remove the warning. >> >> The warning triggers when passing an

[PATCH net-next] net: dsa: dsa_loop: Make dynamic debugging helpful

2018-05-24 Thread Florian Fainelli
Remove redundant debug prints from phy_read/write since we can trace those calls through trace events. Enhance dynamic debug prints to print arguments which helps figuring how what is going on at the driver level with higher level configuration interfaces. Signed-off-by: Florian Fainelli --- dri

Re: [PATCH net-next 0/7] net: bridge: Notify about bridge VLANs

2018-05-24 Thread Florian Fainelli
On 05/24/2018 08:09 AM, Petr Machata wrote: > In commit 946a11e7408e ("mlxsw: spectrum_span: Allow bridge for gretap > mirror"), mlxsw got support for offloading mirror-to-gretap such that > the underlay packet path involves a bridge. In that case, the offload is > also influenced by PVID setting

Re: [PATCH net-next 0/7] net: bridge: Notify about bridge VLANs

2018-05-24 Thread Florian Fainelli
On 05/24/2018 10:20 AM, Florian Fainelli wrote: > Hi Petr, > > On 05/24/2018 08:09 AM, Petr Machata wrote: >> In commit 946a11e7408e ("mlxsw: spectrum_span: Allow bridge for gretap >> mirror"), mlxsw got support for offloading mirror-to-gretap such that >> the underlay packet path involves a bri

Re: [PATCH net-next 0/8] nfp: offload LAG for tc flower egress

2018-05-24 Thread David Miller
From: Jakub Kicinski Date: Wed, 23 May 2018 19:22:47 -0700 > This series from John adds bond offload to the nfp driver. Patch 5 > exposes the hash type for NETDEV_LAG_TX_TYPE_HASH to make sure nfp > hashing matches that of the software LAG. This may be unnecessarily > conservative, let's see wh

Re: [PATCH net-next] hv_netvsc: fix bogus ifalias on network device

2018-05-24 Thread David Miller
From: Stephen Hemminger Date: Wed, 23 May 2018 18:02:00 -0700 > If the guest network adapter is not configured with DeviceNaming > enabled on the host, then the query for friendly name will return > success but with a zero length name. Which then leads to a garbage value > (stack contents) for if

Re: [RFC v5 0/5] virtio: support packed ring

2018-05-24 Thread Tiwei Bie
On Fri, May 25, 2018 at 10:31:26AM +0800, Jason Wang wrote: > On 2018年05月22日 16:16, Tiwei Bie wrote: > > Hello everyone, > > > > This RFC implements packed ring support in virtio driver. > > > > Some simple functional tests have been done with Jason's > > packed ring implementation in vhost (RFC

Re: [PATCH net v2] enic: set DMA mask to 47 bit

2018-05-24 Thread David Miller
From: Govindarajulu Varadarajan Date: Wed, 23 May 2018 11:17:39 -0700 > In commit 624dbf55a359b ("driver/net: enic: Try DMA 64 first, then > failover to DMA") DMA mask was changed from 40 bits to 64 bits. > Hardware actually supports only 47 bits. > > Fixes: 624dbf55a359b ("driver/net: enic: Try

Re: [PATCH v2 net-next 0/3] net: Update fib_table_lookup tracepoints

2018-05-24 Thread David Miller
From: dsah...@kernel.org Date: Wed, 23 May 2018 17:08:46 -0700 > From: David Ahern > > Update the FIB lookup tracepoints to include ip proto and port fields > from the flow struct. In the process make the IPv4 tracepoint inline > with IPv6 which is much easier to use and follow the lookup and re

Re: [PATCH v2] ppp: remove the PPPIOCDETACH ioctl

2018-05-24 Thread David Miller
From: Eric Biggers Date: Wed, 23 May 2018 14:37:38 -0700 > From: Eric Biggers > > The PPPIOCDETACH ioctl effectively tries to "close" the given ppp file > before f_count has reached 0, which is fundamentally a bad idea. It > does check 'f_count < 2', which excludes concurrent operations on the

Re: [Patch net-next] net_sched: switch to rcu_work

2018-05-24 Thread David Miller
From: Cong Wang Date: Wed, 23 May 2018 15:26:53 -0700 > Commit 05f0fe6b74db ("RCU, workqueue: Implement rcu_work") introduces > new API's for dispatching work in a RCU callback. Now we can just > switch to the new API's for tc filters. This could get rid of a lot > of code. > > Signed-off-by: Co

Re: [PATCH net-next] net: stmmac: Add PPS and Flexible PPS support

2018-05-24 Thread kbuild test robot
Hi Jose, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Jose-Abreu/net-stmmac-Add-PPS-and-Flexible-PPS-support/20180525-074128 config: arm-sunxi_defconfig (attached as .config) compiler: arm-linux-gnueabi-

Re: [RFC v5 0/5] virtio: support packed ring

2018-05-24 Thread Jason Wang
On 2018年05月22日 16:16, Tiwei Bie wrote: Hello everyone, This RFC implements packed ring support in virtio driver. Some simple functional tests have been done with Jason's packed ring implementation in vhost (RFC v4): https://lkml.org/lkml/2018/5/16/501 Both of ping and netperf worked as expe

Re: [PATCH bpf-next v7 6/6] selftests/bpf: test for seg6local End.BPF action

2018-05-24 Thread Y Song
When compiling latest bpf-next, I hit the following compilation error: clang -I. -I./include/uapi -I../../../include/uapi -idirafter /usr/local/include -idirafter /data/users/yhs/work/llvm/build/install/lib/clang/7.0.0/include -idirafter /usr/include -Wno-compare-distinct-pointer-types \

Re: [RFC V4 PATCH 8/8] vhost: event suppression for packed ring

2018-05-24 Thread Jason Wang
On 2018年05月16日 20:32, Jason Wang wrote: +static bool vhost_notify_packed(struct vhost_dev *dev, + struct vhost_virtqueue *vq) +{ + __virtio16 event_off_wrap, event_flags; + __u16 old, new, off_wrap; + bool v; + + /* Flush out used descriptor

[RFC net-next 2/4] net: sched: add tcf_proto_op to offload a rule

2018-05-24 Thread Jakub Kicinski
From: John Hurley Create a new tcf_proto_op called offload that generates a new offload message for each node in a tcf_proto. Pointers to the tcf_proto and whether the offload request is to add or delete the node are included. Also included is a callback function to send the offload message to an

Re: [PATCH net-next 00/10] Mirroring tests involving VLAN

2018-05-24 Thread David Miller
From: Petr Machata Date: Thu, 24 May 2018 16:27:04 +0200 > This patchset tests mirror-to-gretap with various underlay > configurations involving VLAN netdevice in particular. Some of the tests > involve bridges as well, but tests aimed specifically at testing bridges > (i.e. FDB, STP) are not par

[RFC net-next 3/4] net: sched: cls_flower: implement offload tcf_proto_op

2018-05-24 Thread Jakub Kicinski
From: John Hurley Add the offload tcf_proto_op in flower to generate an offload message for each filter in the given tcf_proto. Call the specified callback with this new offload message. The function only returns an error if the callback rejects adding a 'hardware only' rule. A filter contains a

[RFC net-next 4/4] net: sched: cls_matchall: implement offload tcf_proto_op

2018-05-24 Thread Jakub Kicinski
From: John Hurley Add the offload tcf_proto_op in matchall to generate an offload message for each filter in the given tcf_proto. Call the specified callback with this new offload message. The function only returns an error if the callback rejects adding a 'hardware only' rule. Ensure matchall f

[RFC net-next 0/4] net: sched: support replay of filter offload when binding to block

2018-05-24 Thread Jakub Kicinski
Hi! This series from John adds the ability to replay filter offload requests when new offload callback is being registered on a TC block. This is most likely to take place for shared blocks today, when a block which already has rules is bound to another interface. Prior to this patch set if any

[RFC net-next 1/4] net: sched: pass extack pointer to block binds and cb registration

2018-05-24 Thread Jakub Kicinski
From: John Hurley Pass the extact struct from a tc qdisc add to the block bind function and, in turn, to the setup_tc ndo of binding device via the tc_block_offload struct. Pass this back to any block callback registrations to allow netlink logging of fails in the bind process. Signed-off-by: Jo

Re: pull-request: bpf-next 2018-05-24

2018-05-24 Thread David Miller
From: Alexei Starovoitov Date: Thu, 24 May 2018 19:03:51 -0700 > The following pull-request contains BPF updates for your *net-next* > tree. Pulled, thanks Alexei.

Re: [PATCH net-next 0/8] ibmvnic: Failover hardening

2018-05-24 Thread David Miller
From: Thomas Falcon Date: Wed, 23 May 2018 13:37:54 -0500 > Introduce additional transport event hardening to handle > events during device reset. In the driver's current state, > if a transport event is received during device reset, it can > cause the device to become unresponsive as invalid ope

Re: [PATCH net] ipv4: remove warning in ip_recv_error

2018-05-24 Thread David Miller
From: Willem de Bruijn Date: Wed, 23 May 2018 14:29:52 -0400 > From: Willem de Bruijn > > A precondition check in ip_recv_error triggered on an otherwise benign > race. Remove the warning. > > The warning triggers when passing an ipv6 socket to this ipv4 error > handling function. RaceFuzzer w

Re: [PATCH net-next 0/3] selftests: forwarding: Additions to mirror-to-gretap tests

2018-05-24 Thread David Miller
From: Petr Machata Date: Wed, 23 May 2018 18:34:49 +0200 > This patchset is for a handful of edge cases in mirror-to-gretap > scenarios: removal of mirrored-to netdevice (#1), removal of underlay > route for tunnel remote endpoint (#2) and cessation of mirroring upon > removal of flower mirroring

Re: [PATCH net] net : sched: cls_api: deal with egdev path only if needed

2018-05-24 Thread David Miller
From: Or Gerlitz Date: Wed, 23 May 2018 19:24:48 +0300 > When dealing with ingress rule on a netdev, if we did fine through the > conventional path, there's no need to continue into the egdev route, > and we can stop right there. > > Not doing so may cause a 2nd rule to be added by the cls api l

Re: [PATCH net] vhost: synchronize IOTLB message with dev cleanup

2018-05-24 Thread David Miller
From: Jason Wang Date: Tue, 22 May 2018 19:58:57 +0800 > DaeRyong Jeong reports a race between vhost_dev_cleanup() and > vhost_process_iotlb_msg(): > > Thread interleaving: > CPU0 (vhost_process_iotlb_msg)CPU1 (vhost_dev_cleanup) > (In the case of both VHOST_IOTLB_UPDATE

pull-request: bpf-next 2018-05-24

2018-05-24 Thread Alexei Starovoitov
Hi David, The following pull-request contains BPF updates for your *net-next* tree. The main changes are: 1) Björn Töpel cleans up AF_XDP (removes rebind, explicit cache alignment from uapi, etc). 2) David Ahern adds mtu checks to bpf_ipv{4,6}_fib_lookup() helpers. 3) Jesper Dangaard Brouer a

Re: [pull request][net 0/2] Mellanox, mlx5 fixes 2018-05-24

2018-05-24 Thread David Miller
From: Saeed Mahameed Date: Thu, 24 May 2018 14:53:11 -0700 > This series includes two mlx5 fixes. > > 1) add FCS data to checksum complete when required, from Eran Ben > Elisha. > > 2) Fix A race in IPSec sandbox QP commands, from Yossi Kuperman. > > Please pull and let me know if there's any

Re: [PATCH net] packet: fix reserve calculation

2018-05-24 Thread David Miller
From: Willem de Bruijn Date: Thu, 24 May 2018 18:10:30 -0400 > From: Willem de Bruijn > > Commit b84bbaf7a6c8 ("packet: in packet_snd start writing at link > layer allocation") ensures that packet_snd always starts writing > the link layer header in reserved headroom allocated for this > purpos

Re: [PATCH net-next] cxgb4: Check for kvzalloc allocation failure

2018-05-24 Thread David Miller
From: YueHaibing Date: Fri, 25 May 2018 09:39:20 +0800 > On 2018/5/24 23:07, David Miller wrote: >> From: YueHaibing >> Date: Tue, 22 May 2018 15:07:18 +0800 >> >>> diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c >>> b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c >>> index 130d

Re: [bpf-next V5 PATCH 0/8] xdp: introduce bulking for ndo_xdp_xmit API

2018-05-24 Thread Alexei Starovoitov
On Thu, May 24, 2018 at 04:45:41PM +0200, Jesper Dangaard Brouer wrote: > This patchset change ndo_xdp_xmit API to take a bulk of xdp frames. > > When kernel is compiled with CONFIG_RETPOLINE, every indirect function > pointer (branch) call hurts performance. For XDP this have a huge > negative pe

Re: [PATCH net-next] cxgb4: Check for kvzalloc allocation failure

2018-05-24 Thread YueHaibing
On 2018/5/24 23:07, David Miller wrote: > From: YueHaibing > Date: Tue, 22 May 2018 15:07:18 +0800 > >> diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c >> b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c >> index 130d1ee..019cffe 100644 >> --- a/drivers/net/ethernet/chelsio/cxgb4/c

linux-next: manual merge of the scsi tree with the net-next tree

2018-05-24 Thread Mark Brown
Hi James, Today's linux-next merge of the scsi tree got a conflict in: drivers/scsi/qedf/qedf.h between commit: 8673daf4f55bf3b91 ("qedf: Add get_generic_tlv_data handler.") from the net-next tree and commit: 4b9b7fabb39b3e9d7 ("scsi: qedf: Improve firmware debug dump handling") from t

Re: [PATCH bpf-next v5 0/7] bpf: implement BPF_TASK_FD_QUERY

2018-05-24 Thread Alexei Starovoitov
On 5/24/18 5:27 PM, Daniel Borkmann wrote: On 05/24/2018 08:21 PM, Yonghong Song wrote: Currently, suppose a userspace application has loaded a bpf program and attached it to a tracepoint/kprobe/uprobe, and a bpf introspection tool, e.g., bpftool, wants to show which bpf program is attached to w

Re: [PATCH] PCI: allow drivers to limit the number of VFs to 0

2018-05-24 Thread Jakub Kicinski
Hi Bjorn! On Thu, 24 May 2018 18:57:48 -0500, Bjorn Helgaas wrote: > On Mon, Apr 02, 2018 at 03:46:52PM -0700, Jakub Kicinski wrote: > > Some user space depends on enabling sriov_totalvfs number of VFs > > to not fail, e.g.: > > > > $ cat .../sriov_totalvfs > .../sriov_numvfs > > > > For devices

Re: [PATCH v2 bpf-next 1/5] bpf: Hooks for sys_sendmsg

2018-05-24 Thread Daniel Borkmann
On 05/23/2018 01:40 AM, Andrey Ignatov wrote: [...] > diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c > index ff4d4ba..a1f9ba2 100644 > --- a/net/ipv4/udp.c > +++ b/net/ipv4/udp.c > @@ -900,6 +900,7 @@ int udp_sendmsg(struct sock *sk, struct msghdr *msg, > size_t len) > { > struct inet_sock *i

[PATCH net-next v5 0/2] openvswitch: Support conntrack zone limit

2018-05-24 Thread Yi-Hung Wei
Currently, nf_conntrack_max is used to limit the maximum number of conntrack entries in the conntrack table for every network namespace. For the VMs and containers that reside in the same namespace, they share the same conntrack table, and the total # of conntrack entries for all the VMs and contai

[PATCH net-next v5 1/2] openvswitch: Add conntrack limit netlink definition

2018-05-24 Thread Yi-Hung Wei
Define netlink messages and attributes to support user kernel communication that uses the conntrack limit feature. Signed-off-by: Yi-Hung Wei --- include/uapi/linux/openvswitch.h | 28 1 file changed, 28 insertions(+) diff --git a/include/uapi/linux/openvswitch.h b/

[PATCH net-next v5 2/2] openvswitch: Support conntrack zone limit

2018-05-24 Thread Yi-Hung Wei
Currently, nf_conntrack_max is used to limit the maximum number of conntrack entries in the conntrack table for every network namespace. For the VMs and containers that reside in the same namespace, they share the same conntrack table, and the total # of conntrack entries for all the VMs and contai

Re: [Bridge] [PATCH net-next] net: bridge: add support for port isolation

2018-05-24 Thread Toshiaki Makita
On 2018/05/24 17:56, Nikolay Aleksandrov wrote: > This patch adds support for a new port flag - BR_ISOLATED. If it is set > then isolated ports cannot communicate between each other, but they can > still communicate with non-isolated ports. The same can be achieved via > ACLs but they can't scale w

Re: [PATCH v3 net] stmmac: Added support for 802.1ad S-TAG stripping

2018-05-24 Thread Toshiaki Makita
On 2018/05/25 1:56, Elad Nachman wrote: > stmmac reception handler calls stmmac_rx_vlan() to strip the vlan before > calling napi_gro_receive(). > > The function assumes VLAN tagged frames are always tagged with 802.1Q > protocol, > and assigns ETH_P_8021Q to the skb by hard-coding the parameter

Re: [PATCH net] vhost: synchronize IOTLB message with dev cleanup

2018-05-24 Thread Michael S. Tsirkin
On Tue, May 22, 2018 at 07:58:57PM +0800, Jason Wang wrote: > DaeRyong Jeong reports a race between vhost_dev_cleanup() and > vhost_process_iotlb_msg(): > > Thread interleaving: > CPU0 (vhost_process_iotlb_msg)CPU1 (vhost_dev_cleanup) > (In the case of both VHOST_IOTLB_UPDA

Re: [PATCH bpf-next v5 0/7] bpf: implement BPF_TASK_FD_QUERY

2018-05-24 Thread Daniel Borkmann
On 05/24/2018 08:21 PM, Yonghong Song wrote: > Currently, suppose a userspace application has loaded a bpf program > and attached it to a tracepoint/kprobe/uprobe, and a bpf > introspection tool, e.g., bpftool, wants to show which bpf program > is attached to which tracepoint/kprobe/uprobe. Such at

Re: [PATCH] PCI: allow drivers to limit the number of VFs to 0

2018-05-24 Thread Bjorn Helgaas
Hi Jakub, On Mon, Apr 02, 2018 at 03:46:52PM -0700, Jakub Kicinski wrote: > Some user space depends on enabling sriov_totalvfs number of VFs > to not fail, e.g.: > > $ cat .../sriov_totalvfs > .../sriov_numvfs > > For devices which VF support depends on loaded FW we have the > pci_sriov_{g,s}et_

Re: [v8, bpf-next, 4/9] net/wireless/iwlwifi: fix iwlwifi_dev_ucode_error tracepoint

2018-05-24 Thread Steven Rostedt
On Thu, 24 May 2018 16:28:39 -0700 Alexei Starovoitov wrote: > Ohh. I didn't realize that networking wireless doesn't fall under netdev. > I thought wireless folks are silent because they are embarrassed > by a function with 17 arguments. Please lets refrain from the demeaning comments. I agree

[PATCH] ath6kl: mark expected switch fall-throughs

2018-05-24 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva --- drivers/net/wireless/ath/ath6kl/cfg80211.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath6kl

Re: [PATCH bpf-next v2 0/3] bpf: add boot parameters for sysctl knobs

2018-05-24 Thread Alexei Starovoitov
On Thu, May 24, 2018 at 09:41:08AM +0200, Jesper Dangaard Brouer wrote: > On Wed, 23 May 2018 15:02:45 -0700 > Alexei Starovoitov wrote: > > > On Wed, May 23, 2018 at 02:18:19PM +0200, Eugene Syromiatnikov wrote: > > > Some BPF sysctl knobs affect the loading of BPF programs, and during > > > sys

Re: [PATCH 00/14] Modify action API for implementing lockless actions

2018-05-24 Thread Cong Wang
On Mon, May 14, 2018 at 7:27 AM, Vlad Buslov wrote: > Currently, all netlink protocol handlers for updating rules, actions and > qdiscs are protected with single global rtnl lock which removes any > possibility for parallelism. This patch set is a first step to remove > rtnl lock dependency from T

Re: [v8, bpf-next, 4/9] net/wireless/iwlwifi: fix iwlwifi_dev_ucode_error tracepoint

2018-05-24 Thread Alexei Starovoitov
On Wed, May 23, 2018 at 01:03:08PM +0200, Johannes Berg wrote: > On Wed, 2018-03-28 at 12:05 -0700, Alexei Starovoitov wrote: > > fix iwlwifi_dev_ucode_error tracepoint to pass pointer to a table > > instead of all 17 arguments by value. > > dvm/main.c and mvm/utils.c have 'struct iwl_error_event_t

[PATCH] ath10k: htt_tx: mark expected switch fall-throughs

2018-05-24 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Notice that in this particular case, I replaced "pass through" with a proper "fall through" comment, which is what GCC is expecting to find. Signed-off-by: Gustavo A. R. Silva --- driver

[PATCH] ath5k: mark expected switch fall-through

2018-05-24 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva --- drivers/net/wireless/ath/ath5k/pcu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/ath/ath5k/pcu.c b/drivers/net/wireles

Re: [PATCH net-next] net: phy: convert further flags in struct phy_device to bit-field

2018-05-24 Thread Florian Fainelli
On 05/24/2018 01:15 PM, Heiner Kallweit wrote: > This patch is a follow-up to 87e5808d52b6 ("net: phy: replace bool > members in struct phy_device with bit-fields") and converts further > flags to bit-fields. This looks fine, but then you would also have to clean-up all code that does phydev->asym

Re: 4.16 issue with mbim modem and ping with size > 14552 bytes

2018-05-24 Thread Daniele Palmas
Hi Greg, 2018-05-24 17:53 GMT+02:00 Greg KH : > On Thu, May 24, 2018 at 05:04:49PM +0200, Daniele Palmas wrote: >> Hello, >> >> I have an issue with an USB mbim modem when trying to send with ping >> more than 14552 bytes: it looks like to me a kernel issue, but not at >> the cdc_mbim or cdc_ncm l

Re: [PATCH net] packet: in packet_snd start writing at link layer allocation

2018-05-24 Thread Willem de Bruijn
On Thu, May 24, 2018 at 1:01 PM, Willem de Bruijn wrote: > On Thu, May 24, 2018 at 11:17 AM, Willem de Bruijn > wrote: >> On Thu, May 24, 2018 at 11:07 AM, Tariq Toukan wrote: >>> >>> >>> On 14/05/2018 3:20 AM, David Miller wrote: From: Willem de Bruijn Date: Fri, 11 May 2018 13:

[PATCH net] packet: fix reserve calculation

2018-05-24 Thread Willem de Bruijn
From: Willem de Bruijn Commit b84bbaf7a6c8 ("packet: in packet_snd start writing at link layer allocation") ensures that packet_snd always starts writing the link layer header in reserved headroom allocated for this purpose. This is needed because packets may be shorter than hard_header_len, in

Re: [PATCH net-next 0/8] nfp: offload LAG for tc flower egress

2018-05-24 Thread Jakub Kicinski
On Thu, 24 May 2018 22:26:03 +0300, Or Gerlitz wrote: > On Thu, May 24, 2018 at 9:49 PM, Jakub Kicinski > wrote: > > On Thu, 24 May 2018 20:04:56 +0300, Or Gerlitz wrote: > > >> Does this apply also to non-uplink representors? if yes, what is the use > >> case? > >> > >> We are looking on supp

[pull request][net 0/2] Mellanox, mlx5 fixes 2018-05-24

2018-05-24 Thread Saeed Mahameed
Hi Dave, This series includes two mlx5 fixes. 1) add FCS data to checksum complete when required, from Eran Ben Elisha. 2) Fix A race in IPSec sandbox QP commands, from Yossi Kuperman. Please pull and let me know if there's any problem. for -stable v4.15 ("net/mlx5e: When RXFCS is set, add FCS

[net 2/2] net/mlx5: IPSec, Fix a race between concurrent sandbox QP commands

2018-05-24 Thread Saeed Mahameed
From: Yossi Kuperman Sandbox QP Commands are retired in the order they are sent. Outstanding commands are stored in a linked-list in the order they appear. Once a response is received and the callback gets called, we pull the first element off the pending list, assuming they correspond. Sending

[net 1/2] net/mlx5e: When RXFCS is set, add FCS data into checksum calculation

2018-05-24 Thread Saeed Mahameed
From: Eran Ben Elisha When RXFCS feature is enabled, the HW do not strip the FCS data, however it is not present in the checksum calculated by the HW. Fix that by manually calculating the FCS checksum and adding it to the SKB checksum field. Add helper function to find the FCS data for all SKB

Re: [PATCH net-next] net: phy: realtek: add suspend/resume callbacks for RTL8211B

2018-05-24 Thread Heiner Kallweit
Am 24.05.2018 um 22:53 schrieb Andrew Lunn: > On Thu, May 24, 2018 at 10:40:12PM +0200, Heiner Kallweit wrote: >> Add RTL8211B suspend / resume callbacks. >> >> Signed-off-by: Heiner Kallweit >> --- >> This patch is based on my knowledge of the r8169 driver, and on some >> guessing. Therefore I'd

[net-next V2 2/6] net/mlx5e: Move port speed code from en_ethtool.c to en/port.c

2018-05-24 Thread Saeed Mahameed
From: Huy Nguyen Move four below functions from en_ethtool.c to en/port.c. These functions are used by both en_ethtool.c and en_main.c. Future code can use these functions without ethtool link mode dependency. u32 mlx5e_port_ptys2speed(u32 eth_proto_oper); int mlx5e_port_linkspeed(struct mlx5

[PATCH net-next] ifb: fix packets checksum

2018-05-24 Thread Jon Maxwell
Fixup the checksum for CHECKSUM_COMPLETE when pulling skbs on RX path. Otherwise we get splats when tc mirred is used to redirect packets to ifb. Before fix: nic: hw csum failure Signed-off-by: Jon Maxwell --- drivers/net/ifb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[net-next V2 1/6] net/dcb: Add dcbnl buffer attribute

2018-05-24 Thread Saeed Mahameed
From: Huy Nguyen In this patch, we add dcbnl buffer attribute to allow user change the NIC's buffer configuration such as priority to buffer mapping and buffer size of individual buffer. This attribute combined with pfc attribute allows advanced user to fine tune the qos setting for specific pri

[net-next V2 6/6] net/mlx5e: Receive buffer support for DCBX

2018-05-24 Thread Saeed Mahameed
From: Huy Nguyen Add dcbnl's set/get buffer configuration callback that allows user to set/get buffer size configuration and priority to buffer mapping. By default, firmware controls receive buffer configuration and priority of buffer mapping based on the changes in pfc settings. When set buffer

[net-next V2 5/6] net/mlx5e: Receive buffer configuration

2018-05-24 Thread Saeed Mahameed
From: Huy Nguyen Add APIs for buffer configuration based on the changes in pfc configuration, cable len, buffer size configuration, and priority to buffer mapping. Note that the xoff fomula is as below xoff = ((301+2.16 * len [m]) * speed [Gbps] + 2.72 MTU [B] xoff_threshold = buffer_size -

[net-next V2 4/6] net/mlx5: PPTB and PBMC register firmware command support

2018-05-24 Thread Saeed Mahameed
From: Huy Nguyen Add firmware command interface to read and write PPTB and PBMC registers. PPTB register enables mappings priority to a specific receive buffer. PBMC registers enables changing the receive buffer's configuration such as buffer size, xon/xoff thresholds, buffer's lossy property a

[net-next V2 3/6] net/mlx5: Add pbmc and pptb in the port_access_reg_cap_mask

2018-05-24 Thread Saeed Mahameed
From: Huy Nguyen Add pbmc and pptb in the port_access_reg_cap_mask. These two bits determine if device supports receive buffer configuration. Signed-off-by: Huy Nguyen Reviewed-by: Parav Pandit Signed-off-by: Saeed Mahameed --- include/linux/mlx5/device.h | 3 +++ include/linux/mlx5/mlx5_

[pull request][net-next V2 0/6] Mellanox, mlx5e updates 2018-05-19

2018-05-24 Thread Saeed Mahameed
Hi Dave, This is a mlx5e only pull request, for more information please see tag log below. Please pull and let me know if there's any problem. v1->v2: 1) patch #1 commit message: lldptool usage example and explanation on why dcbnl is selected over devlink interface as was agreed on mailing l

Re: [net-next 2/6] net/mlx5: Add pbmc and pptb in the port_access_reg_cap_mask

2018-05-24 Thread Saeed Mahameed
On Thu, May 24, 2018 at 2:21 PM, Or Gerlitz wrote: > On Tue, May 22, 2018 at 7:01 PM, Saeed Mahameed > wrote: >> On Tue, May 22, 2018 at 3:21 AM, Or Gerlitz wrote: >>> On Tue, May 22, 2018 at 1:19 PM, Or Gerlitz wrote: On Tue, May 22, 2018 at 12:04 AM, Saeed Mahameed wrote: > Fr

Re: [net-next 2/6] net/mlx5: Add pbmc and pptb in the port_access_reg_cap_mask

2018-05-24 Thread Or Gerlitz
On Tue, May 22, 2018 at 7:01 PM, Saeed Mahameed wrote: > On Tue, May 22, 2018 at 3:21 AM, Or Gerlitz wrote: >> On Tue, May 22, 2018 at 1:19 PM, Or Gerlitz wrote: >>> On Tue, May 22, 2018 at 12:04 AM, Saeed Mahameed >>> wrote: From: Huy Nguyen Add pbmc and pptb in the port_acces

Re: [PATCH net-next] net: phy: realtek: add suspend/resume callbacks for RTL8211B

2018-05-24 Thread Andrew Lunn
On Thu, May 24, 2018 at 10:40:12PM +0200, Heiner Kallweit wrote: > Add RTL8211B suspend / resume callbacks. > > Signed-off-by: Heiner Kallweit > --- > This patch is based on my knowledge of the r8169 driver, and on some > guessing. Therefore I'd appreciate a confirmation from Realtek. > > The in

[PATCH net-next] net: phy: realtek: add suspend/resume callbacks for RTL8211B

2018-05-24 Thread Heiner Kallweit
Add RTL8211B suspend / resume callbacks. Signed-off-by: Heiner Kallweit --- This patch is based on my knowledge of the r8169 driver, and on some guessing. Therefore I'd appreciate a confirmation from Realtek. The integrated PHY in some chips supported by the r8169 driver uses a special sequence

[PATCH net-next] net: phy: convert further flags in struct phy_device to bit-field

2018-05-24 Thread Heiner Kallweit
This patch is a follow-up to 87e5808d52b6 ("net: phy: replace bool members in struct phy_device with bit-fields") and converts further flags to bit-fields. Signed-off-by: Heiner Kallweit --- include/linux/phy.h | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a

Re: [PATCH v3] powerpc: Implement csum_ipv6_magic in assembly

2018-05-24 Thread Segher Boessenkool
On Thu, May 24, 2018 at 10:18:44AM +, Christophe Leroy wrote: > On 05/24/2018 06:20 AM, Christophe LEROY wrote: > >Le 23/05/2018 à 20:34, Segher Boessenkool a écrit : > >>On Tue, May 22, 2018 at 08:57:01AM +0200, Christophe Leroy wrote: > >>>The generic csum_ipv6_magic() generates a pretty bad

Re: [PATCH net-next] vrf: add CRC32c offload to device features

2018-05-24 Thread Marcelo Ricardo Leitner
On Thu, May 24, 2018 at 05:49:35PM +0200, Davide Caratti wrote: > SCTP sockets originated in a VRF can improve their performance if CRC32c > computation is delegated to underlying devices: update device features, > setting NETIF_F_SCTP_CRC. Iterating the following command in the topology > proposed

[PATCH] 8139too: Remove unnecessary netif_napi_del()

2018-05-24 Thread Bo Chen
The call to free_netdev() in __rtl8139_cleanup_dev() clears the network device napi list, and explicit calls to netif_napi_del() are unnecessary. Signed-off-by: Bo Chen --- drivers/net/ethernet/realtek/8139too.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/realtek/81

  1   2   3   >