RE: [PATCH net-next] team: Use extack to report enslavement failures

2018-02-27 Thread Yuval Mintz
> >> > If so, for how long? They should certainly be removed eventually. How > >> > do we ensure we don't forget? > >> > > >> > Seems to me it would be better to remove them right now. > >> > >> I can do that unless someone objects. > > > >I don't object, but FWIW keep in mind extack errors don't s

Re: [PATCH net-next] team: Use extack to report enslavement failures

2018-02-27 Thread Jiri Pirko
Wed, Feb 28, 2018 at 12:49:59AM CET, kubak...@wp.pl wrote: >On Tue, 27 Feb 2018 22:22:12 +0200, Ido Schimmel wrote: >> > If so, for how long? They should certainly be removed eventually. How >> > do we ensure we don't forget? >> > >> > Seems to me it would be better to remove them right now. >>

Re: [patch net 0/2] mlxsw: couple of fixes

2018-02-27 Thread Jiri Pirko
Tue, Feb 27, 2018 at 08:39:06PM CET, da...@davemloft.net wrote: >From: Jiri Pirko >Date: Tue, 27 Feb 2018 12:56:12 +0100 > >> From: Jiri Pirko >> >> Couple of unrelated fixes for mlxsw. >> >> --- >> Please consider the first patch for -stable. >> Thanks! > >Patch #2 doesn't apply cleanly, pleas

Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

2018-02-27 Thread Jiri Pirko
Tue, Feb 27, 2018 at 10:41:49PM CET, kubak...@wp.pl wrote: >On Tue, 27 Feb 2018 13:16:21 -0800, Alexander Duyck wrote: >> Basically we need some sort of PCI or PCIe topology mapping for the >> devices that can be translated into something we can communicate over >> the communication channel. > >Hm

[PATCH] r8169: convert remaining feature flag and remove enum features

2018-02-27 Thread Heiner Kallweit
Now that only one feature flag is left we can convert it and remove enum features. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet

Re: [RFC PATCH v2] ptr_ring: linked list fallback

2018-02-27 Thread Jason Wang
On 2018年02月28日 12:09, Michael S. Tsirkin wrote: Or we can add plist to a union: struct sk_buff { union { struct { /* These two members must be first. */ struct sk_buff *next; str

[PATCH] e1000e: Fix link status in case of error.

2018-02-27 Thread Benjamin Poirier
Before commit 19110cfbb34d ("e1000e: Separate signaling for link check/link up"), errors which happen after "get_link_status = false" in the copper check_for_link callbacks would be ignored and the link considered up. After that commit, any error implies that the link is down. Since all combination

Re: [RFC PATCH] e1000e: Fix link check race condition.

2018-02-27 Thread Benjamin Poirier
On 2018/02/26 08:14, Alexander Duyck wrote: [...] > > > > > switch (hw->mac.type) { > > case e1000_pch2lan: > > ret_val = e1000_k1_workaround_lv(hw); > > if (ret_val) > > - return ret_val; > > + goto out; >

[PATCH net 0/2] Fixes, cleanup and modernization for macmace driver

2018-02-27 Thread Finn Thain
Changes since v4 of combined patch series: - Removed redundant and non-portable MACH_IS_MAC tests. - Omitted patches unrelated to macmace driver. Finn Thain (2): net/macmace: Drop redundant MACH_IS_MAC test net/macmace: Fix and clean up log messages drivers/net/ethernet/apple/macmace.c | 25

[PATCH net 1/2] net/macmace: Drop redundant MACH_IS_MAC test

2018-02-27 Thread Finn Thain
The MACH_IS_MAC test is redundant here because the platform device won't get registered unless MACH_IS_MAC. Adopt module_platform_driver() convention. Cc: Geert Uytterhoeven Signed-off-by: Finn Thain --- drivers/net/ethernet/apple/macmace.c | 16 +--- 1 file changed, 1 insertion(+),

[PATCH net 2/2] net/macmace: Fix and clean up log messages

2018-02-27 Thread Finn Thain
Don't log the unexpanded "eth%d" format string. Log the chip revision in the probe message (consistent with mace.c). Drop redundant debug messages for FIFO events recorded in the interface statistics (also consistent with mace.c). Tested-by: Stan Johnson Signed-off-by: Finn Thain --- drivers/ne

Re: [RFC PATCH v2] ptr_ring: linked list fallback

2018-02-27 Thread Michael S. Tsirkin
On Wed, Feb 28, 2018 at 11:39:15AM +0800, Jason Wang wrote: > > > On 2018年02月28日 11:28, Jason Wang wrote: > > > > Well I believe the main user for this is qdisc, which use skb > > > > array. And we > > > > can not use what implemented in this patch directly for sk_buff > > > > without some > > >

Re: [RFC PATCH v2] ptr_ring: linked list fallback

2018-02-27 Thread Michael S. Tsirkin
On Wed, Feb 28, 2018 at 11:28:57AM +0800, Jason Wang wrote: > > > On 2018年02月28日 01:12, Michael S. Tsirkin wrote: > > On Tue, Feb 27, 2018 at 10:29:26AM +0800, Jason Wang wrote: > > > > > > On 2018年02月27日 04:34, Michael S. Tsirkin wrote: > > > > On Mon, Feb 26, 2018 at 11:15:42AM +0800, Jason Wa

[PATCH net-next v2 1/5] net: fib_rules: support for match on ip_proto, sport and dport

2018-02-27 Thread Roopa Prabhu
From: Roopa Prabhu uapi for ip_proto, sport and dport range match in fib rules. Signed-off-by: Roopa Prabhu --- include/net/fib_rules.h| 36 - include/uapi/linux/fib_rules.h | 8 net/core/fib_rules.c | 92 +- 3 fil

[PATCH net-next v2 3/5] ipv6: fib6_rules: support for match on sport, dport and ip proto

2018-02-27 Thread Roopa Prabhu
From: Roopa Prabhu support to match on src port, dst port and ip protocol. Signed-off-by: Roopa Prabhu --- net/ipv6/fib6_rules.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/net/ipv6/fib6_rules.c b/net/ipv6/fib6_rules.c index 95a2c9e..bcd1f22 100644 --- a/net/ipv6/fib6_rule

[PATCH net-next v2 5/5] ipv6: route: dissect flow in input path if fib rules need it

2018-02-27 Thread Roopa Prabhu
From: Roopa Prabhu Dissect flow in fwd path if fib rules require it. Controlled by a flag to avoid penatly for the common case. Flag is set when fib rules with sport, dport and proto match that require flow dissect are installed. Also passes the dissected hash keys to the multipath hash function

[PATCH net-next v2 2/5] ipv4: fib_rules: support match on sport, dport and ip proto

2018-02-27 Thread Roopa Prabhu
From: Roopa Prabhu support to match on src port, dst port and ip protocol. Signed-off-by: Roopa Prabhu --- net/ipv4/fib_rules.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/net/ipv4/fib_rules.c b/net/ipv4/fib_rules.c index 35d646a..16083b8 100644 --- a/net/ipv4/fib_rules.c

[PATCH net-next v2 4/5] ipv4: route: dissect flow in input path if fib rules need it

2018-02-27 Thread Roopa Prabhu
From: Roopa Prabhu Dissect flow in fwd path if fib rules require it. Controlled by a flag to avoid penatly for the common case. Flag is set when fib rules with sport, dport and proto match that require flow dissect are installed. Also passes the dissected hash keys to the multipath hash function

[PATCH net-next v2 0/5] fib_rules: support sport, dport and proto match

2018-02-27 Thread Roopa Prabhu
From: Roopa Prabhu This series extends fib rule match support to include sport, dport and ip proto match (to complete the 5-tuple match support). Common use-cases of Policy based routing in the data center require 5-tuple match. The last 2 patches in the series add a call to flow dissect in the f

Re: [pull request][for-next 00/15] Mellanox, mlx5 RDMA E-Switch representors 2018-02-23

2018-02-27 Thread Doug Ledford
On Mon, 2018-02-26 at 12:36 -0800, Saeed Mahameed wrote: > Hi Doug and Dave, > > This series includes shared code updates for mlx5 core driver for both > netdev and rdma subsystems. This series should be pulled to both > trees so we can continue netdev and rdma specific submissions separately. >

Re: [RFC PATCH v2] ptr_ring: linked list fallback

2018-02-27 Thread Jason Wang
On 2018年02月28日 11:28, Jason Wang wrote: Well I believe the main user for this is qdisc, which use skb array. And we can not use what implemented in this patch directly for sk_buff without some changes on the data structure. Why not? skb has next and prev pointers at 1st two fields: struct s

Re: [RFC PATCH v2] ptr_ring: linked list fallback

2018-02-27 Thread Jason Wang
On 2018年02月28日 01:12, Michael S. Tsirkin wrote: On Tue, Feb 27, 2018 at 10:29:26AM +0800, Jason Wang wrote: On 2018年02月27日 04:34, Michael S. Tsirkin wrote: On Mon, Feb 26, 2018 at 11:15:42AM +0800, Jason Wang wrote: On 2018年02月26日 09:17, Michael S. Tsirkin wrote: So pointer rings work fine

Re: [PATCH net] vrf: check forwarding on the original netdevice when generating ICMP dest unreachable

2018-02-27 Thread David Ahern
On 2/27/18 11:36 AM, Stephen Suryaputra wrote: > When ip_error() is called the device is the l3mdev master instead of the > original device. So the forwarding check should be on the original one. > > Signed-off-by: Stephen Suryaputra > --- > net/ipv4/route.c | 9 - > 1 file changed, 8 in

Re: [PATCH RFC 2/2] vhost: packed ring support

2018-02-27 Thread Jason Wang
On 2018年02月27日 17:03, Tiwei Bie wrote: On Wed, Feb 14, 2018 at 10:37:09AM +0800, Jason Wang wrote: [...] +static void set_desc_used(struct vhost_virtqueue *vq, + struct vring_desc_packed *desc, bool wrap_counter) +{ + __virtio16 flags = desc->flags; + + if (

Re: [PATCH] KEYS: DNS: limit the length of option strings

2018-02-27 Thread Eric Dumazet
On Tue, 2018-02-27 at 17:49 -0800, Eric Biggers wrote: > From: Eric Biggers > > Adding a dns_resolver key whose payload contains a very long option name > resulted in that string being printed in full. This hit the WARN_ONCE() > in set_precision() during the printk(), because printk() only suppo

Re: [V9fs-developer] [PATCH] net/9p: avoid -ERESTARTSYS leak to userspace

2018-02-27 Thread jiangyiwen
Hi Al, I totally agree the Greg's suggestion, I think v9fs is the direction as the VirtFS in the virtualization field, that it still deserves to be used and developed, so I also suggestion you can apply (or nack) the patch as v9fs maintainer, I hope you won't refuse. Thanks, Yiwen. On 2018/2/21

[PATCH] KEYS: DNS: limit the length of option strings

2018-02-27 Thread Eric Biggers
From: Eric Biggers Adding a dns_resolver key whose payload contains a very long option name resulted in that string being printed in full. This hit the WARN_ONCE() in set_precision() during the printk(), because printk() only supports a precision of up to 32767 bytes: precision 100 too

Re: dns_resolver_preparse tries to print arbitrarily-large user-provided strings

2018-02-27 Thread Eric Biggers
Hi Mark, On Tue, Feb 27, 2018 at 04:43:13PM +, Mark Rutland wrote: > Hi, > > As a heads-up, while fuzzing v4.16-rc3 on arm64 with Syzkaller, I hit a > system hang which I was able to minize to the reproducer below. It looks > like the system hang is an artifact of Syzkaller using panic_on_war

Re: [PATCH RESEND net-next 0/2] ntuple filters with RSS

2018-02-27 Thread Alexander Duyck
On Tue, Feb 27, 2018 at 3:47 PM, Jakub Kicinski wrote: > On Tue, 27 Feb 2018 17:59:12 +, Edward Cree wrote: >> This series introduces the ability to mark an ethtool steering filter to use >> RSS spreading, and the ability to create and configure multiple RSS contexts >> with different indire

Re: [net-next 0/7][pull request] 40GbE Intel Wired LAN Driver Updates 2018-02-26

2018-02-27 Thread Jeff Kirsher
On Tue, 2018-02-27 at 12:57 -0500, David Miller wrote: > From: Jeff Kirsher > Date: Mon, 26 Feb 2018 13:39:24 -0800 > > > This series contains updates to i40e and i40evf only. > > Pulled, but... > > Please stop splitting Fixes: tags up into multiple lines. Make it > always one line no matter h

[PATCH] selftests/bpf: Add bpf_probe_read_str to bpf_helpers.h

2018-02-27 Thread Tushar Dave
Using bpf_probe_read_str() from samples/bpf causes compiler warning. e.g. warning: implicit declaration of function 'bpf_probe_read_str' is invalid in C99 [-Wimplicit-function-declaration] num = bpf_probe_read_str(buf, sizeof(buf), ctx->di); ^ 1 warning generated. Add b

Re: [PATCH bpf-next v8 08/11] landlock: Add ptrace restrictions

2018-02-27 Thread Andy Lutomirski
On Wed, Feb 28, 2018 at 12:00 AM, Mickaël Salaün wrote: > > On 28/02/2018 00:23, Andy Lutomirski wrote: >> On Tue, Feb 27, 2018 at 11:02 PM, Andy Lutomirski wrote: >>> On Tue, Feb 27, 2018 at 10:14 PM, Mickaël Salaün wrote: >>> >>> I think you're wrong here. Any sane container trying to us

Re: [PATCH bpf-next v8 08/11] landlock: Add ptrace restrictions

2018-02-27 Thread Mickaël Salaün
On 28/02/2018 00:23, Andy Lutomirski wrote: > On Tue, Feb 27, 2018 at 11:02 PM, Andy Lutomirski wrote: >> On Tue, Feb 27, 2018 at 10:14 PM, Mickaël Salaün wrote: >>> >>> On 27/02/2018 06:01, Andy Lutomirski wrote: > On Feb 26, 2018, at 8:17 PM, Andy Lutomirski wrote: > >>

Re: [net-next v3 0/2] eBPF seccomp filters

2018-02-27 Thread chris hyser
On 02/27/2018 04:58 PM, Daniel Borkmann wrote: >> On 02/27/2018 05:59 PM, chris hyser wrote: On 02/27/2018 11:00 AM, Kees Cook wrote: On Tue, Feb 27, 2018 at 6:53 AM, chris hyser wrote: On 02/26/2018 11:38 PM, Kees Cook wrote: On Mon, Feb 26, 2018 at 8:19 PM, Andy Lutomirski wrote: 3. Str

Re: [PATCH net-next] team: Use extack to report enslavement failures

2018-02-27 Thread Jakub Kicinski
On Tue, 27 Feb 2018 22:22:12 +0200, Ido Schimmel wrote: > > If so, for how long? They should certainly be removed eventually. How > > do we ensure we don't forget? > > > > Seems to me it would be better to remove them right now. > > I can do that unless someone objects. I don't object, but FWI

[PATCH net-next] inet: whitespace cleanup

2018-02-27 Thread Stephen Hemminger
Ran simple script to find/remove trailing whitespace and blank lines at EOF because that kind of stuff git whines about and editors leave behind. Signed-off-by: Stephen Hemminger --- include/net/ethoc.h| 1 - include/net/flow.h | 2 +- include/net/inet_connectio

Re: [PATCH RESEND net-next 0/2] ntuple filters with RSS

2018-02-27 Thread Jakub Kicinski
On Tue, 27 Feb 2018 17:59:12 +, Edward Cree wrote: > This series introduces the ability to mark an ethtool steering filter to use > RSS spreading, and the ability to create and configure multiple RSS contexts > with different indirection tables, hash keys, and hash fields. > An implementation

Re: [PATCH net-next 0/5] Modernize bitbanged GPIO MDIO

2018-02-27 Thread Florian Fainelli
On 02/27/2018 03:10 PM, Andrew Lunn wrote: >> Nack on patches 1 and 3, because I am slowly resuming work on an x86 >> platform driver that uses the mdio-gpio driver with platform data, and >> DT is not an option there, and I would rather not have to revert your >> changes. > > Hi Florian > > Woul

[PATCH net] tcp: purge write queue upon RST

2018-02-27 Thread Soheil Hassas Yeganeh
From: Soheil Hassas Yeganeh When the connection is reset, there is no point in keeping the packets on the write queue until the connection is closed. RFC 793 (page 70) and RFC 793-bis (page 64) both suggest purging the write queue upon RST: https://tools.ietf.org/html/draft-ietf-tcpm-rfc793bis-0

Re: [PATCH bpf-next v8 08/11] landlock: Add ptrace restrictions

2018-02-27 Thread Andy Lutomirski
On Tue, Feb 27, 2018 at 11:02 PM, Andy Lutomirski wrote: > On Tue, Feb 27, 2018 at 10:14 PM, Mickaël Salaün wrote: >> >> On 27/02/2018 06:01, Andy Lutomirski wrote: >>> >>> On Feb 26, 2018, at 8:17 PM, Andy Lutomirski wrote: > On Tue, Feb 27, 2018 at 12:41 AM, Mickaël Salaün wrote

[PATCH net-next] socket: skip checking sk_err for recvmmsg(MSG_ERRQUEUE)

2018-02-27 Thread Soheil Hassas Yeganeh
From: Soheil Hassas Yeganeh recvmmsg does not call ___sys_recvmsg when sk_err is set. That is fine for normal reads but, for MSG_ERRQUEUE, recvmmsg should always call ___sys_recvmsg regardless of sk->sk_err to be able to clear error queue. Otherwise, users are not able to drain the error queue us

Re: [PATCH net-next] ipv6: allow userspace to add IFA_F_OPTIMISTIC addresses

2018-02-27 Thread Sabrina Dubroca
2018-02-27, 10:47:08 -0500, David Miller wrote: > From: Sabrina Dubroca > Date: Tue, 27 Feb 2018 15:13:28 +0100 > > > 2018-02-26, 12:11:27 -0500, David Miller wrote: > >> From: Sabrina Dubroca > >> Date: Mon, 26 Feb 2018 17:56:19 +0100 > >> > >> That's completely different to this case, which i

Re: [net-next v3 0/2] eBPF seccomp filters

2018-02-27 Thread Andy Lutomirski
On Tue, Feb 27, 2018 at 11:10 PM, Mickaël Salaün wrote: > > On 27/02/2018 05:54, Andy Lutomirski wrote: >> >> >>> On Feb 26, 2018, at 8:38 PM, Kees Cook wrote: >>> >>> On Mon, Feb 26, 2018 at 8:19 PM, Andy Lutomirski >>> wrote: > On Feb 26, 2018, at 3:20 PM, Kees Cook wrote: > > On

Re: [net-next v3 0/2] eBPF seccomp filters

2018-02-27 Thread Mickaël Salaün
On 27/02/2018 05:54, Andy Lutomirski wrote: > > >> On Feb 26, 2018, at 8:38 PM, Kees Cook wrote: >> >> On Mon, Feb 26, 2018 at 8:19 PM, Andy Lutomirski wrote: On Feb 26, 2018, at 3:20 PM, Kees Cook wrote: On Mon, Feb 26, 2018 at 3:04 PM, Alexei Starovoitov wrote: >> O

Re: [PATCH net-next 0/5] Modernize bitbanged GPIO MDIO

2018-02-27 Thread Andrew Lunn
> Nack on patches 1 and 3, because I am slowly resuming work on an x86 > platform driver that uses the mdio-gpio driver with platform data, and > DT is not an option there, and I would rather not have to revert your > changes. Hi Florian Would it be O.K. to change the platform_data to use a gpio

Re: [PATCH bpf-next v8 00/11] Landlock LSM: Toward unprivileged sandboxing

2018-02-27 Thread Andy Lutomirski
On Tue, Feb 27, 2018 at 10:03 PM, Mickaël Salaün wrote: > > On 27/02/2018 05:36, Andy Lutomirski wrote: >> On Tue, Feb 27, 2018 at 12:41 AM, Mickaël Salaün wrote: >>> Hi, >>> >>> >>> ## Why use the seccomp(2) syscall? >>> >>> Landlock use the same semantic as seccomp to apply access rule >>> res

Re: [PATCH bpf-next v8 08/11] landlock: Add ptrace restrictions

2018-02-27 Thread Andy Lutomirski
On Tue, Feb 27, 2018 at 10:14 PM, Mickaël Salaün wrote: > > On 27/02/2018 06:01, Andy Lutomirski wrote: >> >> >>> On Feb 26, 2018, at 8:17 PM, Andy Lutomirski wrote: >>> On Tue, Feb 27, 2018 at 12:41 AM, Mickaël Salaün wrote: A landlocked process has less privileges than a non-landlock

linux-next: manual merge of the net-next tree with the net tree

2018-02-27 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: net/ipv4/ip_tunnel.c between commit: 4e994776e7bd ("ip_tunnel: Do not use mark in skb by default") from the net tree and commit: b0066da52ea5 ("ip_tunnel: Rename & publish init_tunnel_flow") from the net-next tree

Re: [PATCH net-next 11/11] ipmr, ip6mr: Unite dumproute flows

2018-02-27 Thread Nikolay Aleksandrov
On 27/02/18 20:58, Yuval Mintz wrote: > The various MFC entries are being held in the same kind of mr_tables > for both ipmr and ip6mr, and their traversal logic is identical. > Also, with the exception of the addresses [and other small tidbits] > the major bulk of the nla setting is identical. >

Re: [PATCH net-next 09/11] ipmr, ip6mr: Unite vif seq functions

2018-02-27 Thread Nikolay Aleksandrov
On 27/02/18 20:58, Yuval Mintz wrote: > Same as previously done with the mfc seq, the logic for the vif seq is > refactored to be shared between ipmr and ip6mr. > > Signed-off-by: Yuval Mintz > --- > include/linux/mroute_base.h | 33 ++ > net/ipv4/ipmr.c |

Re: [RFC PATCH V3] virtio_pci: Add SR-IOV support

2018-02-27 Thread Rustad, Mark D
> On Feb 27, 2018, at 7:35 AM, David Miller wrote: > > I don't like these helpers on many different levels. > So kill off pci_sriov_enable() helper completely, it is unnecessary, > and rename the disable helper so that it says something meaningful to > the reader. Yes. Once pointed out, I com

Re: [PATCH net-next 10/11] ip6mr: Remove MFC_NOTIFY and refactor flags

2018-02-27 Thread Nikolay Aleksandrov
On 27/02/18 20:58, Yuval Mintz wrote: > MFC_NOTIFY exists in ip6mr, probably as some legacy code > [was already removed for ipmr in commit > 06bd6c0370bb ("net: ipmr: remove unused MFC_NOTIFY flag and make the flags > enum"). > Remove it from ip6mr as well, and move the enum into a common file; >

Re: [PATCH net-next 08/11] ipmr, ip6mr: Unite mfc seq logic

2018-02-27 Thread Nikolay Aleksandrov
On 27/02/18 20:58, Yuval Mintz wrote: > With the exception of the final dump, ipmr and ip6mr have the exact same > seq logic for traversing a given mr_table. Refactor that code and make > it common. > > Signed-off-by: Yuval Mintz > --- > include/linux/mroute_base.h | 69 +

Re: [PATCH net-next 07/11] ipmr, ip6mr: Unite logic for searching in MFC cache

2018-02-27 Thread Nikolay Aleksandrov
On 27/02/18 20:58, Yuval Mintz wrote: > ipmr and ip6mr utilize the exact same methods for searching the > hashed resolved connections, difference being only in the construction > of the hash comparison key. > > In order to unite the flow, introduce an mr_table operation set that > would contain th

Re: [PATCH net-next 06/11] ipmr, ip6mr: Make mfc_cache a common structure

2018-02-27 Thread Nikolay Aleksandrov
On 27/02/18 20:58, Yuval Mintz wrote: > mfc_cache and mfc6_cache are almost identical - the main difference is > in the origin/group addresses and comparison-key. Make a common > structure encapsulating most of the multicast routing logic - mr_mfc > and convert both ipmr and ip6mr into using it. >

Re: [PATCH] selftest: fix kselftest-merge depend on 'RUNTIME_TESTING_MENU'

2018-02-27 Thread Anders Roxell
On 23 February 2018 at 08:05, Zong Li wrote: > 2018-02-23 3:57 GMT+08:00 Anders Roxell : >> On 22 February 2018 at 12:53, Zong Li wrote: >>> Since the 'commit d3deafaa8b5c ("lib/: make RUNTIME_TESTS a menuconfig >>> to ease disabling it all")', the make kselftest-merge cannot merge the >>> config

[PATCH] qlogic/qed: Constify *pkt_type_str[]

2018-02-27 Thread Hernán Gonzalez
Note: This is compile only tested as I have no access to the hw. Constifying and declaring as static saves 24 bytes. add/remove: 0/1 grow/shrink: 0/0 up/down: 0/-24 (-24) Function old new delta pkt_type_str 24 - -

[PATCH] emulex/benet: Constify *be_misconfig_evt_port_state[]

2018-02-27 Thread Hernán Gonzalez
Note: This is compile only tested as I have no access to the hw. No benefit gained except for some self-documenting. add/remove: 0/0 grow/shrink: 0/0 up/down: 0/0 (0) Function old new delta Total: Before=2757703, After=2757703, chg +0.00% Signed-off-by: H

Re: [PATCH] pci-iov: Add support for unmanaged SR-IOV

2018-02-27 Thread Alexander Duyck
On Tue, Feb 27, 2018 at 1:40 PM, Alex Williamson wrote: > On Tue, 27 Feb 2018 11:06:54 -0800 > Alexander Duyck wrote: > >> From: Alexander Duyck >> >> This patch is meant to add support for SR-IOV on devices when the VFs are >> not managed by the kernel. Examples of recent patches attempting to

Re: [net-next v3 0/2] eBPF seccomp filters

2018-02-27 Thread chris hyser
On 02/27/2018 04:58 PM, Daniel Borkmann wrote: On 02/27/2018 05:59 PM, chris hyser wrote: On 02/27/2018 11:00 AM, Kees Cook wrote: On Tue, Feb 27, 2018 at 6:53 AM, chris hyser wrote: On 02/26/2018 11:38 PM, Kees Cook wrote: On Mon, Feb 26, 2018 at 8:19 PM, Andy Lutomirski wrote: 3. Straig

Re: [PATCH bpf-next v8 08/11] landlock: Add ptrace restrictions

2018-02-27 Thread Mickaël Salaün
On 27/02/2018 05:17, Andy Lutomirski wrote: > On Tue, Feb 27, 2018 at 12:41 AM, Mickaël Salaün wrote: >> A landlocked process has less privileges than a non-landlocked process >> and must then be subject to additional restrictions when manipulating >> processes. To be allowed to use ptrace(2) an

Re: [PATCH bpf-next v8 08/11] landlock: Add ptrace restrictions

2018-02-27 Thread Mickaël Salaün
On 27/02/2018 06:01, Andy Lutomirski wrote: > > >> On Feb 26, 2018, at 8:17 PM, Andy Lutomirski wrote: >> >>> On Tue, Feb 27, 2018 at 12:41 AM, Mickaël Salaün wrote: >>> A landlocked process has less privileges than a non-landlocked process >>> and must then be subject to additional restrictio

[PATCH 2/2 net] tcp: revert F-RTO extension to detect more spurious timeouts

2018-02-27 Thread Yuchung Cheng
This reverts commit 89fe18e44f7ee5ab1c90d0dff5835acee7751427. While the patch could detect more spurious timeouts, it could cause poor TCP performance on broken middle-boxes that modifies TCP packets (e.g. receive window, SACK options). Since the performance gain is much smaller compared to the po

[PATCH 0/2 net] revert a F-RTO extension due to broken middle-boxes

2018-02-27 Thread Yuchung Cheng
This patch series reverts a (non-standard) TCP F-RTO extension that aimed to detect more spurious timeouts. Unfortunately it could result in poor performance due to broken middle-boxes that modify TCP packets. E.g. https://www.spinics.net/lists/netdev/msg484154.html We believe the best and simplest

[PATCH 1/2 net] tcp: revert F-RTO middle-box workaround

2018-02-27 Thread Yuchung Cheng
This reverts commit cc663f4d4c97b7297fb45135ab23cfd508b35a77. While fixing some broken middle-boxes that modifies receive window fields, it does not address middle-boxes that strip off SACK options. The best solution is to fully revert this patch and the root F-RTO enhancement. Fixes: cc663f4d4c97

Re: [PATCH net-next 05/11] ipmr, ip6mr: Unite creation of new mr_table

2018-02-27 Thread Nikolay Aleksandrov
On 27/02/18 20:58, Yuval Mintz wrote: > Now that both ipmr and ip6mr are using the same mr_table structure, > we can have a common function to allocate & initialize a new instance. > > Signed-off-by: Yuval Mintz > --- > include/linux/mroute_base.h | 17 + > net/ipv4/ipmr.c

Re: [PATCH bpf-next v8 00/11] Landlock LSM: Toward unprivileged sandboxing

2018-02-27 Thread Mickaël Salaün
On 27/02/2018 05:36, Andy Lutomirski wrote: > On Tue, Feb 27, 2018 at 12:41 AM, Mickaël Salaün wrote: >> Hi, >> >> This eight series is a major revamp of the Landlock design compared to >> the previous series [1]. This enables more flexibility and granularity >> of access control with file paths.

Re: [net-next v3 0/2] eBPF seccomp filters

2018-02-27 Thread Daniel Borkmann
On 02/27/2018 05:59 PM, chris hyser wrote: > On 02/27/2018 11:00 AM, Kees Cook wrote: >> On Tue, Feb 27, 2018 at 6:53 AM, chris hyser wrote: >>> On 02/26/2018 11:38 PM, Kees Cook wrote: On Mon, Feb 26, 2018 at 8:19 PM, Andy Lutomirski wrote: > > 3. Straight-up bugs.  Those are e

Re: [PATCH bpf-next v8 05/11] seccomp,landlock: Enforce Landlock programs per process hierarchy

2018-02-27 Thread Mickaël Salaün
On 27/02/2018 17:39, Andy Lutomirski wrote: > On Tue, Feb 27, 2018 at 5:32 AM, Alexei Starovoitov > wrote: >> On Tue, Feb 27, 2018 at 05:20:55AM +, Andy Lutomirski wrote: >>> On Tue, Feb 27, 2018 at 4:54 AM, Alexei Starovoitov >>> wrote: On Tue, Feb 27, 2018 at 04:40:34AM +, Andy Lu

Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

2018-02-27 Thread Jakub Kicinski
On Tue, 27 Feb 2018 13:16:21 -0800, Alexander Duyck wrote: > Basically we need some sort of PCI or PCIe topology mapping for the > devices that can be translated into something we can communicate over > the communication channel. Hm. This is probably a completely stupid idea, but if we need to s

Re: [PATCH] pci-iov: Add support for unmanaged SR-IOV

2018-02-27 Thread Alex Williamson
On Tue, 27 Feb 2018 11:06:54 -0800 Alexander Duyck wrote: > From: Alexander Duyck > > This patch is meant to add support for SR-IOV on devices when the VFs are > not managed by the kernel. Examples of recent patches attempting to do this > include: It appears to enable sriov when the _pf_ is n

Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

2018-02-27 Thread Michael S. Tsirkin
On Tue, Feb 27, 2018 at 09:49:59AM +0100, Jiri Pirko wrote: > Now the question is: is it possible to merge the demands you have and > the generic needs I described into a single solution? From what I see, > that would be quite hard/impossible. So at the end, I think that we have > to end-up with 2

Re: [net-next 00/13][pull request] 10GbE Intel Wired LAN Driver Updates 2018-02-26

2018-02-27 Thread Alexander Duyck
On Mon, Feb 26, 2018 at 5:59 PM, David Miller wrote: > From: Jeff Kirsher > Date: Mon, 26 Feb 2018 10:07:43 -0800 > >> This series contains updates to ixgbe and ixgbevf only. > ... >> Emil updates ixgbevf with several features and improvements done in >> other drivers, starting with the handling

Re: [net-next v3 0/2] eBPF seccomp filters

2018-02-27 Thread chris hyser
On 02/27/2018 02:19 PM, Kees Cook wrote: On Tue, Feb 27, 2018 at 8:59 AM, chris hyser wrote: I will try to find that discussion. As someone pointed out here though, eBPF A good starting point might be this: https://lwn.net/Articles/441232/ Thanks. A fair amount of reading referenced there :

Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

2018-02-27 Thread Michael S. Tsirkin
On Tue, Feb 27, 2018 at 01:16:21PM -0800, Alexander Duyck wrote: > The other thing I am looking at is trying to find a good way to do > dirty page tracking in the hypervisor using something like a > para-virtual IOMMU. However I don't have any ETA on that as I am just > starting out and have limite

Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

2018-02-27 Thread Alexander Duyck
On Tue, Feb 27, 2018 at 12:49 AM, Jiri Pirko wrote: > Tue, Feb 20, 2018 at 05:04:29PM CET, alexander.du...@gmail.com wrote: >>On Tue, Feb 20, 2018 at 2:42 AM, Jiri Pirko wrote: >>> Fri, Feb 16, 2018 at 07:11:19PM CET, sridhar.samudr...@intel.com wrote: Patch 1 introduces a new feature bit VIR

Re: [patch net-next 15/15] mlxsw: spectrum_span: Support mirror to ip6gretap

2018-02-27 Thread Petr Machata
David Ahern writes: > On 2/27/18 6:53 AM, Jiri Pirko wrote: >> diff --git a/drivers/net/ethernet/mellanox/mlxsw/Kconfig >> b/drivers/net/ethernet/mellanox/mlxsw/Kconfig >> index 830c3e28505e..93d97b4676eb 100644 >> --- a/drivers/net/ethernet/mellanox/mlxsw/Kconfig >> +++ b/drivers/net/ethernet/m

Re: [PATCH RFC 1/2] virtio: introduce packed ring defines

2018-02-27 Thread Michael S. Tsirkin
On Tue, Feb 27, 2018 at 09:54:58AM +0100, Jens Freimann wrote: > On Fri, Feb 23, 2018 at 07:18:00PM +0800, Tiwei Bie wrote: > > Signed-off-by: Tiwei Bie > > --- > > include/uapi/linux/virtio_config.h | 18 +- > > include/uapi/linux/virtio_ring.h | 68 > > +

Re: [PATCH net-next] team: Use extack to report enslavement failures

2018-02-27 Thread Ido Schimmel
On Tue, Feb 27, 2018 at 08:42:35PM +0100, Jiri Benc wrote: > On Tue, 27 Feb 2018 17:38:08 +0200, Ido Schimmel wrote: > > if (port_dev->flags & IFF_LOOPBACK) { > > + NL_SET_ERR_MSG(extack, "Loopback device can't be added as a > > team port"); > > netdev_err(dev, "Device %s

Re: [patch net-next 15/15] mlxsw: spectrum_span: Support mirror to ip6gretap

2018-02-27 Thread David Ahern
On 2/27/18 6:53 AM, Jiri Pirko wrote: > diff --git a/drivers/net/ethernet/mellanox/mlxsw/Kconfig > b/drivers/net/ethernet/mellanox/mlxsw/Kconfig > index 830c3e28505e..93d97b4676eb 100644 > --- a/drivers/net/ethernet/mellanox/mlxsw/Kconfig > +++ b/drivers/net/ethernet/mellanox/mlxsw/Kconfig > @@ -8

Re: [PATCH net-next 04/11] mroute*: Make mr_table a common struct

2018-02-27 Thread Nikolay Aleksandrov
On 27/02/18 20:58, Yuval Mintz wrote: > Following previous changes to ip6mr, mr_table and mr6_table are > basically the same [up to mr6_table having additional '6' suffixes to > its variable names]. > Move the common structure definition into a common header; This > requires renaming all references

Re: [PATCH net-next 03/11] ip6mr: Align hash implementation to ipmr

2018-02-27 Thread Nikolay Aleksandrov
On 27/02/18 20:58, Yuval Mintz wrote: > Since commit 8fb472c09b9d ("ipmr: improve hash scalability") ipmr has > been using rhashtable as a basis for its mfc routes, but ip6mr is > currently still using the old private MFC hash implementation. > > Align ip6mr to the current ipmr implementation. >

Re: [PATCH net-next 02/11] ip6mr: Make mroute_sk rcu-based

2018-02-27 Thread Nikolay Aleksandrov
On 27/02/18 20:58, Yuval Mintz wrote: > In ipmr the mr_table socket is handled under RCU. Introduce the same > for ip6mr. > > Signed-off-by: Yuval Mintz > --- > include/linux/mroute6.h | 6 +++--- > net/ipv6/ip6_output.c | 2 +- > net/ipv6/ip6mr.c| 45 +++-

Re: [PATCH net-next 0/4] mlx4_en misc for 4.17

2018-02-27 Thread David Miller
From: Tariq Toukan Date: Tue, 27 Feb 2018 16:17:18 +0200 > This patchset contains misc enhancements from the team > to the mlx4 Eth driver. > > Patch 1 by Eran adds physical layer counters. > Patch 2 by Eran cleans-up a redundant warn print. > Patch 3 combines the checks of two end cases into a

Re: [patch net-next 00/15] mlxsw: Offloading encapsulated SPAN

2018-02-27 Thread David Miller
From: Jiri Pirko Date: Tue, 27 Feb 2018 14:53:34 +0100 > From: Jiri Pirko > > Petr says: > > This patch series introduces support for mirroring with GRE > encapsulation. It offloads tc action mirred mirror from a mlxsw port to > either a gretap or an ip6gretap netdevice. Ok, series applied.

[net-next 1/1] tipc: sockopt(TIPC_SO_RCVBUF) for setting receive buffer

2018-02-27 Thread Jon Maloy
From: Hoang Le We introduce a set/getsockopt for setting socket receive buffer per individual socket. This has turned out to sometimes be necessary for anycast and multicast receivers when used without flow control. Signed-off-by: Hoang Le Signed-off-by: Jon Maloy --- include/uapi/linux/tipc.

Re: [ethtool,2/3] ethtool: show VF and queue in the help for -N

2018-02-27 Thread John W. Linville
On Mon, Feb 26, 2018 at 10:49:55AM -0800, Jeff Kirsher wrote: > From: Jacob Keller > > Show that you can use VF and queue instead of action in the help output, > and not only in the manual page. > > Signed-off-by: Jacob Keller > Tested-by: Andrew Bowers > Signed-off-by: Jeff Kirsher LGTM --

Re: [PATCH] cdc_ether: flag the Cinterion PLS8 modem by gemalto as WWAN

2018-02-27 Thread David Miller
From: Bassem Boubaker Date: Tue, 27 Feb 2018 14:04:44 +0100 > The Cinterion PL8 is an LTE modem with 2 possible WWAN interfaces. > > The modem is controlled via AT commands through the exposed TTYs. > > AT^SWWAN write command can be used to activate or deactivate a WWAN > conne

Re: [ethtool, 3/3] ethtool: correct VF index values for the ring_cookie parameter

2018-02-27 Thread John W. Linville
On Mon, Feb 26, 2018 at 10:49:56AM -0800, Jeff Kirsher wrote: > From: Jacob Keller > > Instead of relying on the input being offset by 1, instead adjust the > "vf" input value by 1 so that it correctly targets the VF the user > expects. Additionally, update the displayed output to show the correc

Re: [ethtool] ethtool: Add SFF 8636 date code parsing support

2018-02-27 Thread John W. Linville
On Wed, Feb 21, 2018 at 12:35:09PM -0800, Saeed Mahameed wrote: > Parse date codes according to SFF 8636 and print them to output. > > ethtool -m ethX > [...] > Date code : 160220 > > Signed-off-by: Saeed Mahameed > Reviewed-by: Gal Pressman LGTM -- queued for ethtool-4.16... Th

Re: [ethtool, 1/3] ethtool: correct display of VF when showing vf/queue filters

2018-02-27 Thread John W. Linville
On Mon, Feb 26, 2018 at 10:49:54AM -0800, Jeff Kirsher wrote: > From: Jacob Keller > > The original code that implemented this accidentally had an inverted > check, so it would never show the VF number properly. > > Fix this code to correctly display the VF number when we have one. > > Fixes: 3

Re: [PATCH v4 net] tls: Use correct sk->sk_prot for IPV6

2018-02-27 Thread David Miller
From: Boris Pismenny Date: Tue, 27 Feb 2018 14:18:39 +0200 > The tls ulp overrides sk->prot with a new tls specific proto structs. > The tls specific structs were previously based on the ipv4 specific > tcp_prot sturct. > As a result, attaching the tls ulp to an ipv6 tcp socket replaced > some ip

Re: [PATCH net-next] team: Use extack to report enslavement failures

2018-02-27 Thread Jiri Benc
On Tue, 27 Feb 2018 17:38:08 +0200, Ido Schimmel wrote: > if (port_dev->flags & IFF_LOOPBACK) { > + NL_SET_ERR_MSG(extack, "Loopback device can't be added as a > team port"); > netdev_err(dev, "Device %s is loopback device. Loopback devices > can't be added as a te

Re: [PATCH net-next] sh_eth: uninline TSU register accessors

2018-02-27 Thread David Miller
From: Sergei Shtylyov Date: Tue, 27 Feb 2018 14:58:16 +0300 > We have uninlined the sh_eth_{read|write}() functions introduced in the > commit 4a55530f38e ("net: sh_eth: modify the definitions of register"). > Now remove *inline* from sh_eth_tsu_{read|write}() as well and move > these functions

Re: [patch net 0/2] mlxsw: couple of fixes

2018-02-27 Thread David Miller
From: Jiri Pirko Date: Tue, 27 Feb 2018 12:56:12 +0100 > From: Jiri Pirko > > Couple of unrelated fixes for mlxsw. > > --- > Please consider the first patch for -stable. > Thanks! Patch #2 doesn't apply cleanly, please respin. Thank you.

Re: [PATCH net 0/3] net: fix IFLA_MTU ignored on NEWLINK for some ip and ipv6 tunnels

2018-02-27 Thread David Miller
From: Xin Long Date: Tue, 27 Feb 2018 19:19:38 +0800 > The fix for ip_gre follows the way other ip tunnels do: not to > set mtu in ndo_init, as ip_tunnel_newlink will take care of it > properly. > > The fix for ip6_tunnel and sit follows the way ipv6 tunenls do: > to set mtu again according to I

Re: [PATCH net-next 01/11] ipmr,ipmr6: Define a uniform vif_device

2018-02-27 Thread Nikolay Aleksandrov
On 27/02/18 20:58, Yuval Mintz wrote: > The two implementations have almost identical structures - vif_device and > mif_device. As a step toward uniforming the mr_tables, eliminate the > mif_device and relocate the vif_device definition into a new common > header file. > > Also, introduce a common

Re: [RFC PATCH v2] ptr_ring: linked list fallback

2018-02-27 Thread Michael S. Tsirkin
On Tue, Feb 27, 2018 at 09:53:49AM -0800, Eric Dumazet wrote: > On Mon, 2018-02-26 at 03:17 +0200, Michael S. Tsirkin wrote: > > So pointer rings work fine, but they have a problem: make them too small > > and not enough entries fit. Make them too large and you start flushing > > your cache and ru

Re: [PATCH iproute2 1/3] ip: Fix compilation with kernel headers < 3.4

2018-02-27 Thread Serhey Popovych
Stephen Hemminger wrote: > On Tue, 27 Feb 2018 14:06:50 +0200 > Serhey Popovych wrote: > >> Since commit 596b1c94aa38 ("iproute: build more easily on Android"), >> iproute2 uses types __kernel_long_t and __kernel_ulong_t but does not >> provide internal definitions for it. >> >> This means that c

Re: [PATCH net-next] net: mvpp2: Add hardware offloading for VLAN filtering

2018-02-27 Thread David Miller
From: Maxime Chevallier Date: Tue, 27 Feb 2018 10:11:43 +0100 > +/* Find tcam entry with matched pair */ > +static int mvpp2_prs_vid_range_find(struct mvpp2 *priv, int pmap, u16 vid, > + u16 mask) > +{ > + struct mvpp2_prs_entry pe; > + unsigned char byte[

  1   2   3   4   >