On 27/02/18 20:58, Yuval Mintz wrote: > Now that both ipmr and ip6mr are using the same mr_table structure, > we can have a common function to allocate & initialize a new instance. > > Signed-off-by: Yuval Mintz <yuv...@mellanox.com> > --- > include/linux/mroute_base.h | 17 +++++++++++++++++ > net/ipv4/ipmr.c | 27 ++++++++++----------------- > net/ipv4/ipmr_base.c | 27 +++++++++++++++++++++++++++ > net/ipv6/ip6mr.c | 30 ++++++++++-------------------- > 4 files changed, 64 insertions(+), 37 deletions(-) >
I don't like the function definition broken with the name and type on different rows, but I guess it's a personal preference, the patch looks okay. Acked-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>
