Re: [PATCH 2/2] sh_eth: kill redundant check in the probe() method

2018-01-01 Thread Geert Uytterhoeven
H Sergei, On Sun, Dec 31, 2017 at 7:41 PM, Sergei Shtylyov wrote: > Browsing thru the driver diassembly, I noticed that gcc was able to > figure out that the 'ndev' pointer is always non-NULL when calling > free_netdev() on the probe() method's error path and thus skip that > redundant NULL

Re: [PATCH 1/2] ravb: kill redundant check in the probe() method

2018-01-01 Thread Geert Uytterhoeven
Hi Sergei, On Sun, Dec 31, 2017 at 7:41 PM, Sergei Shtylyov wrote: > Browsing thru the driver diassembly, I noticed that gcc was able to > figure out that the 'ndev' pointer is always non-NULL when calling > free_netdev() on the probe() method's error path and thus skip that > redundant NUL

Re: Linux ECN Handling

2018-01-01 Thread Steve Ibanez
Hi Neal, Apologies for the delay, and happy new year! To answer your question, data is only transferred in one direction (from the client to the server). The SeqNo in the pkts from the server to the client is not incremented. So I don't think that a data pkt is attempted to be sent in the tcp_dat

[PATCH 0/2] tests: fix issues in autopkgtest environment

2018-01-01 Thread Christian Ehrhardt
Hi, while working on Debian bug [1] and the Ubuntu counterpart of it I found that the tests can throw a broken pipe warning. I kept the associated check-and-retry of the length separate to discuss the changes individually - feel free to squash them on commit if preferred. [1]: https://bugs.debian

[PATCH 2/2] tests: make sure rand_dev suffix has 6 chars

2018-01-01 Thread Christian Ehrhardt
The change to limit the read size from /dev/urandom is a tradeoff. Reading too much can trigger an issue, but so it could if the suggested 250 random chars would not contain enough [:alpha:] chars. If they contain: a) >=6 all is ok b) [1-5] the devname would be shorter than expected (non fatal).

Re: [PATCH net 0/2] IB/ipoib: ip link support

2018-01-01 Thread Or Gerlitz
On Sun, Dec 31, 2017 at 2:28 PM, Or Gerlitz wrote: > On Sun, Dec 31, 2017 at 1:16 PM, Denis Drozdov wrote: >> IP link was broken due to the changes in IPoIB for the rdma_netdev >> support after commit cd565b4b51e5 >> ("IB/IPoIB: Support acceleration options callbacks"). > > you are approaching st

[PATCH 1/2] tests: read limited amount from /dev/urandom

2018-01-01 Thread Christian Ehrhardt
In some test environments like e.g. Ubuntu & Debian autopkgtest it can happen that while generating random device names the pipes between tr and head are considered dead while processing. That prints (non fatal) issues like: Running ip/link/new_link.t [iproute2-this/4.13.0-17-generic]: tr: write

[PATCH net-next] cxgb4: collect TX rate limit info in UP CIM logs

2018-01-01 Thread Rahul Lakkireddy
Collect TX rate limiting related information in UP CIM logs. Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/cudbg_entity.h | 80 ++- drivers/net/ethernet/chelsio/cxgb4/cudbg_if.h | 1 + drivers/net/ethernet/chelsio/cx

Re: [PATCH v3 bpf-next 10/11] bpf: Add BPF_SOCK_OPS_STATE_CB

2018-01-01 Thread kbuild test robot
Hi Lawrence, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] [also build test WARNING on next-20171222] [cannot apply to bpf-next/master linus/master net/master v4.15-rc6] [if your patch is applied to the wrong git tree, please drop us a note to

[PATCH] flex_can: Correct the checking for frame length in flexcan_start_xmit()

2018-01-01 Thread Luu An Phu
From: "phu.luuan" The flexcan_start_xmit() function compares the frame length with data register length to write frame content into data[0] and data[1] register. Data register length is 4 bytes and frame maximum length is 8 bytes. Fix the check that compares frame length with 3. Because the regi

Re: [bpf-next V3 PATCH 11/14] virtio_net: setup xdp_rxq_info

2018-01-01 Thread Jason Wang
On 2017年12月31日 19:01, Jesper Dangaard Brouer wrote: The virtio_net driver doesn't dynamically change the RX-ring queue layout and backing pages, but instead reject XDP setup if all the conditions for XDP is not meet. Thus, the xdp_rxq_info also remains fairly static. This allow us to simply a

Re: [bpf-next V3 PATCH 10/14] tun: setup xdp_rxq_info

2018-01-01 Thread Jason Wang
On 2017年12月31日 19:01, Jesper Dangaard Brouer wrote: Driver hook points for xdp_rxq_info: * reg : tun_attach * unreg: __tun_detach I've done some manual testing of this tun driver, but I would appriciate good review and someone else running their use-case tests, as I'm not 100% sure I unde

Re: [PATCH net-next 2/2] tuntap: XDP transmission

2018-01-01 Thread Jason Wang
-tuntap/20180101-105946 config: i386-randconfig-x072-201800 (attached as .config) compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025 reproduce: # save the attached .config to linux build tree make ARCH=i386 All warnings (new ones prefixed by >>): drivers//net/tun.c: In fu

Re: [PATCH net-next 2/2] tun: allow to attach ebpf socket filter

2018-01-01 Thread Jason Wang
On 2017年12月31日 18:14, Willem de Bruijn wrote: On Fri, Dec 29, 2017 at 3:44 AM, Jason Wang wrote: This patch allows userspace to attach eBPF filter to tun. This will allow to implement VM dataplane filtering in a more efficient way compared to cBPF filter. Is the idea to allow the trusted hyp

Re: [PATCH net-next 2/2] tuntap: XDP transmission

2018-01-01 Thread Jason Wang
On 2017年12月29日 20:32, Jesper Dangaard Brouer wrote: On Fri, 29 Dec 2017 18:00:04 +0800 Jason Wang wrote: This patch implements XDP transmission for TAP. Since we can't create new queues for TAP during XDP set, exist ptr_ring was reused for queuing XDP buffers. To differ xdp_buff from sk_buff

Re: ACPI issues on cold power on [bisected]

2018-01-01 Thread Joonsoo Kim
On Fri, Dec 29, 2017 at 04:36:59PM +, Jonathan McDowell wrote: > On Fri, Dec 22, 2017 at 09:21:09AM +0900, Joonsoo Kim wrote: > > On Fri, Dec 08, 2017 at 03:11:59PM +, Jonathan McDowell wrote: > > > I've been sitting on this for a while and should have spent time to > > > investigate sooner

[PATCH] ethernet: mlx4: Delete an error message for a failed memory allocation in five functions

2018-01-01 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 1 Jan 2018 21:42:27 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/net/ethernet/mellanox/mlx4/en_cq.c | 4 +--- drivers/net/ethe

[PATCH] ethernet/mediatek: Delete an error message for a failed memory allocation in mtk_add_mac()

2018-01-01 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 1 Jan 2018 21:06:50 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 1 - 1 file changed, 1 de

[PATCH] igb: Delete an error message for a failed memory allocation in igb_enable_sriov()

2018-01-01 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 1 Jan 2018 20:53:10 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/net/ethernet/intel/igb/igb_main.c | 2 -- 1 file changed, 2 del

[PATCH] i40e: Delete an error message for a failed memory allocation in i40e_init_interrupt_scheme()

2018-01-01 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 1 Jan 2018 20:38:14 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/net/ethernet/intel/i40e/i40e_main.c | 5 ++--- 1 file changed,

[PATCH] ehea: Delete an error message for a failed memory allocation in two functions

2018-01-01 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 1 Jan 2018 20:14:25 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/net/ethernet/ibm/ehea/ehea_main.c | 2 -- 1 file changed, 2 d

[PATCH v4] uapi libc compat: add fallback for unsupported libcs

2018-01-01 Thread Hauke Mehrtens
From: Felix Janda libc-compat.h aims to prevent symbol collisions between uapi and libc headers for each supported libc. This requires continuous coordination between them. The goal of this commit is to improve the situation for libcs (such as musl) which are not yet supported and/or do not wish

[PATCH] net: hns: Delete an error message for a failed memory allocation in hns_rcb_common_get_cfg()

2018-01-01 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 1 Jan 2018 19:11:46 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.c | 5 ++--- 1 file cha

[PATCH 2/2] benet: Delete an unnecessary return statement in be_work_add_vxlan_port()

2018-01-01 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 1 Jan 2018 18:45:17 +0100 The script "checkpatch.pl" pointed information out like the following. WARNING: void function return statements are not generally useful Thus remove such a statement in the affected function. Signed-off-by: Markus Elfring --- drivers/

[PATCH 1/2] benet: Delete an error message for a failed memory allocation in be_alloc_work()

2018-01-01 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 1 Jan 2018 18:38:06 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/net/ethernet/emulex/benet/be_main.c | 5 + 1 file changed,

[PATCH 0/2] benet: Adjustments for two function implementations

2018-01-01 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 1 Jan 2018 18:50:05 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation in be_alloc_work() Delete an unnecessary return statement in be_work_add_vxlan

[PATCH] LiquidIO: Delete two error messages for a failed memory allocation in octeon_setup_interrupt()

2018-01-01 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 1 Jan 2018 18:14:49 +0100 Omit extra messages for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/net/ethernet/cavium/liquidio/lio_core.c | 5 + 1 file changed

[PATCH] net: systemport: Delete an error message for a failed memory allocation in two functions

2018-01-01 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 1 Jan 2018 17:50:02 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/net/ethernet/broadcom/bcmsysport.c | 5 + 1 file changed,

[PATCH] bcm63xx_enet: Delete two error messages for a failed memory allocation in bcm_enetsw_open()

2018-01-01 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 1 Jan 2018 17:30:04 +0100 Omit extra messages for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/net/ethernet/broadcom/bcm63xx_enet.c | 2 -- 1 file changed, 2 de

[PATCH] bonding: Delete an error message for a failed memory allocation in bond_update_slave_arr()

2018-01-01 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 1 Jan 2018 17:00:04 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/net/bonding/bond_main.c | 1 - 1 file changed, 1 deletion(-) d

Re: [patch net-next v2 00/10] Add support for resource abstraction

2018-01-01 Thread Arkadi Sharshevsky
On 12/26/2017 01:23 PM, Jiri Pirko wrote: > From: Jiri Pirko > > Many of the ASIC's internal resources are limited and are shared between > several hardware procedures. For example, unified hash-based memory can > be used for many lookup purposes, like FDB and LPM. In many cases the user > can

Re: [EXT] Re: [PATCH net-next 5/6] arm64: dts: marvell: mcbin: enable the fourth network interface

2018-01-01 Thread Russell King - ARM Linux
On Mon, Jan 01, 2018 at 10:35:25AM +, Stefan Chulski wrote: > > > -Original Message- > > Hi Russell, > > > > Indeed. RGMII MAC behaves same way, although it shouldn't be named as 'in- > > band' to be on par with the specifications. Anyway - this one is rather a > > stub for > > being

[PATCH RESEND] bpf: fix bad include in libbpf when srctree is set

2018-01-01 Thread Alexander Alemayhu
The relative path can be wrong and prevents the build. Makefile:57: ../../scripts/Makefile.include: No such file or directory make: *** No rule to make target '../../scripts/Makefile.include'. Stop. Signed-off-by: Alexander Alemayhu --- tools/lib/bpf/Makefile | 2 +- 1 file ch

Re: [patch net-next v2 00/10] Add support for resource abstraction

2018-01-01 Thread Arkadi Sharshevsky
On 12/31/2017 05:46 PM, David Ahern wrote: > On 12/31/17 3:52 AM, Arkadi Sharshevsky wrote: >>> [1] This is allowed by the current patch set and perhaps it should not be: >>> >>> $ ip ro ls vrf vrf1101 >>> unreachable default metric 8192 >>> 11.2.51.0/24 dev swp1s0.51 proto kernel scope link src

RE: [PATCH] qed: Use zeroing memory allocator than allocator/memset

2018-01-01 Thread Tayar, Tomer
From: Himanshu Jha [mailto:himanshujha199...@gmail.com] Sent: Saturday, December 30, 2017 5:37 PM > Use dma_zalloc_coherent and vzalloc for allocating zeroed > memory and remove unnecessary memset function. > > Done using Coccinelle. > Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.coc

RE: [EXT] Re: [PATCH net-next 5/6] arm64: dts: marvell: mcbin: enable the fourth network interface

2018-01-01 Thread Stefan Chulski
> -Original Message- > From: Marcin Wojtas [mailto:m...@semihalf.com] > Sent: Monday, January 01, 2018 12:18 PM > To: Russell King - ARM Linux > Cc: Stefan Chulski ; Thomas Petazzoni > ; Andrew Lunn ; > Florian Fainelli ; Yan Markman > ; Jason Cooper ; netdev > ; Antoine Tenart electrons

[PATCH net] tipc: fix missing rtnl lock protection during setting link properties

2018-01-01 Thread Ying Xue
Currently when user changes link properties, TIPC first checks if user's command message contains media name or bearer name through tipc_media_find() or tipc_bearer_find() which is protected by rtnl lock. But when tipc_nl_compat_link_set() conducts the checking with the two functions, it doesn't ho

Re: [PATCH net-next 5/6] arm64: dts: marvell: mcbin: enable the fourth network interface

2018-01-01 Thread Marcin Wojtas
Hi Russell, 2017-12-30 18:31 GMT+01:00 Russell King - ARM Linux : > Hi Marcin, > > On Sat, Dec 30, 2017 at 05:34:23PM +0100, Marcin Wojtas wrote: >> Yes, I already split the series and will send first one right away. I >> will be followed by MDIO bus / PHY handling proposal, including the >> bits

Re: [net-next: PATCH v2 5/5] net: mvpp2: enable ACPI support in the driver

2018-01-01 Thread Marcin Wojtas
HI Andrew, 2017-12-31 20:23 GMT+01:00 Andrew Lunn : >> * Modify way of obtaining interrupts - with ACPI they are resources >> bound to struct platform_device and it's not possible to obtain >> them directly from the child node. Hence a formula is used, depending >> on the port_id and number

Re: [net-next: PATCH v2 4/5] net: mvpp2: use device_*/fwnode_* APIs instead of of_*

2018-01-01 Thread Marcin Wojtas
Hi Andrew, 2017-12-31 20:18 GMT+01:00 Andrew Lunn : > On Sun, Dec 31, 2017 at 12:58:39PM +0100, Marcin Wojtas wrote: > Hi Marcin > >> Because there is no equivalent for for_each_available_child_of_node(), >> use device_for_each_child_node() and check the port availability >> inside the mvpp2_port_

Re: [PATCH net-next 2/2] tuntap: XDP transmission

2018-01-01 Thread kbuild test robot
Hi Jason, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Jason-Wang/XDP-transmission-for-tuntap/20180101-105946 reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig