Re: [PATCH net-next 2/2] chcr: Add support for Inline IPSec

2017-10-28 Thread kbuild test robot
Hi Atul, Thank you for the patch! Yet we hit a small issue. [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Atul-Gupta/cxgb4-Add-support-for-Inline-IPSec-Tx/20171029-060344 reproduce: # apt-get install sparse make ARCH=x86_64 allmodco

Re: [PATCH v3 0/2] refactor code and mark expected switch fall-throughs

2017-10-28 Thread David Ranch
Hello David, Thanks for the reply. I completely admit that there aren't many changes going into this section of code. Unfortunately, we've had some nasty breaks that took quite a long while to get fixed. Can you point me in the direction of this kbuild test robot (URLs, etc) so I can bett

Re: [PATCH net-next 1/1] net sched qdisc: pass netlink message flags in event notification

2017-10-28 Thread Roman Mashak
Cong Wang writes: > On Thu, Oct 26, 2017 at 2:40 PM, Roman Mashak wrote: >> Userland client should be able to read an event, and reflect it back to >> the kernel, therefore it needs to extract complete set of netlink flags. >> >> For example, this will allow "tc monitor" to distinguish Add and R

Re: [PATCH net-next] ipv6: prevent user from adding cached routes

2017-10-28 Thread David Miller
From: Wei Wang Date: Fri, 27 Oct 2017 17:30:12 -0700 > From: Wei Wang > > Cached routes should only be created by the system when receiving pmtu > discovery or ip redirect msg. Users should not be allowed to create > cached routes. > > Furthermore, after the patch series to move cached routes

Re: [PATCH net-next] samples/bpf: adjust rlimit RLIMIT_MEMLOCK for xdp1

2017-10-28 Thread David Miller
From: Tushar Dave Date: Fri, 27 Oct 2017 16:12:30 -0700 > Default rlimit RLIMIT_MEMLOCK is 64KB, causes bpf map failure. > e.g. > [root@lab bpf]#./xdp1 -N $( failed to create a map: 1 Operation not permitted > > Fix it. > > Signed-off-by: Tushar Dave Applied.

Re: [PATCH net-next] samples/bpf: adjust rlimit RLIMIT_MEMLOCK for xdp_redirect_map

2017-10-28 Thread David Miller
From: Tushar Dave Date: Fri, 27 Oct 2017 17:28:22 -0700 > Default rlimit RLIMIT_MEMLOCK is 64KB, causes bpf map failure. > e.g. > [root@labbpf]# ./xdp_redirect_map $(> $( failed to create a map: 1 Operation not permitted > > The failure is 100% when multiple xdp programs are running. Fix it. >

Re: [PATCH net-next] net: dsa: b53: Export b53_configure_vlan()

2017-10-28 Thread David Miller
From: Florian Fainelli Date: Fri, 27 Oct 2017 15:56:01 -0700 > bcm_sf2 and b53 replicate the same operations: clear all VLANs and set > their ports to the default VLAN tag (1 for these devices) so export the > b53 function doing just that. > > Signed-off-by: Florian Fainelli Applied.

Re: [PATCH net-next] liquidio: get rid of false alarm "Unknown cmd 27" in dmesg

2017-10-28 Thread David Miller
From: Felix Manlunas Date: Fri, 27 Oct 2017 14:37:03 -0700 > Creating a macvtap interface with the liquidio VF driver as lower device > causes this alarming message to show up in dmesg: > > liquidio_link_ctrl_cmd_completion Unknown cmd 27 > > That's actually a false alarm because cmd 27 is

Re: [PATCH net-next] hv_netvsc: Set tx_table to equal weight after subchannels open

2017-10-28 Thread David Miller
From: Haiyang Zhang Date: Fri, 27 Oct 2017 12:36:38 -0700 > From: Haiyang Zhang > > In some cases, like internal vSwitch, the host doesn't provide > send indirection table updates. This patch sets the table to be > equal weight after subchannels are all open. Otherwise, all workload > will be o

Re: [PATCH net] sctp: reset owner sk for data chunks on out queues when migrating a sock

2017-10-28 Thread David Miller
From: Xin Long Date: Sat, 28 Oct 2017 02:13:29 +0800 > Now when migrating sock to another one in sctp_sock_migrate(), it only > resets owner sk for the data in receive queues, not the chunks on out > queues. > > It would cause that data chunks length on the sock is not consistent > with sk sk_wm

Re: [PATCH] ppp: allow usage in namespaces

2017-10-28 Thread David Miller
From: Matteo Croce Date: Fri, 27 Oct 2017 20:08:23 +0200 > Check for CAP_NET_ADMIN with ns_capable() instead of capable() > to allow usage of ppp in user namespace other than the init one. > > Signed-off-by: Matteo Croce Ok, applied to net-next.

Re: [net-next v2 0/6][pull request] 1GbE Intel Wired LAN Driver Updates 2017-10-27

2017-10-28 Thread David Miller
From: Jeff Kirsher Date: Fri, 27 Oct 2017 09:57:00 -0700 > This patchset is a proposal of how the Traffic Control subsystem can > be used to offload the configuration of the Credit Based Shaper > (defined in the IEEE 802.1Q-2014 Section 8.6.8.2) into supported > network devices. ... Pulled, tha

Re: [net PATCH 0/2] sockmap fixes

2017-10-28 Thread David Miller
From: John Fastabend Date: Fri, 27 Oct 2017 09:45:16 -0700 > Last two fixes (as far as I know) for sockmap code this round. > > First, we are using the qdisc cb structure when making the data end > calculation. This is really just wrong so, store it with the other > metadata in the correct tcp_s

Re: [PATCH net 0/4] l2tp: register sessions atomically

2017-10-28 Thread David Miller
From: Guillaume Nault Date: Fri, 27 Oct 2017 16:51:48 +0200 > Currently l2tp_session_create() allocates a session, partially > initialises it and finally registers it. It therefore exposes sessions > that aren't fully initialised to the rest of the system, because > pseudo-wire specific initialis

Re: net-next Compile error

2017-10-28 Thread David Miller
From: Egil Hjelmeland Date: Fri, 27 Oct 2017 15:50:25 +0200 > Starting with net-next commit 60e2a7780793bae0debc275a9ccd57f7da0cf195 > "tcp: TCP experimental option for SMC", I can not cross compile the > kernel. Thanks for the report, I've committed the following fix for this:

Re: [PATCH net-next] cxgb3: Check and handle the dma mapping errors

2017-10-28 Thread David Miller
From: Ganesh Goudar Date: Fri, 27 Oct 2017 18:08:21 +0530 > From: Arjun Vynipadath > > This patch adds checks at approprate places whether *dma_map*() call has > succeeded or not. > > Original Work by: Santosh Rastapur > Signed-off-by: Arjun Vynipadath > Signed-off-by: Ganesh Goudar Applie

Re: [PATCH] r8169: Add support for interrupt coalesce tuning (ethtool -C)

2017-10-28 Thread David Miller
Applied to net-next, thank you.

Re: [PATCH net-next v6 0/2] bridge: make setlink/dellink notifications more accurate

2017-10-28 Thread David Miller
From: Nikolay Aleksandrov Date: Fri, 27 Oct 2017 13:19:35 +0300 > Before this set the bridge would generate a notification on vlan add or del > even if they didn't actually do any changes, which confuses listeners and > is generally not preferred. We could also lose notifications on actual > chan

[PATCH net-next] net: dpaa: remove init which already done in per-cpu allocation

2017-10-28 Thread yuan linyu
From: yuan linyu Signed-off-by: yuan linyu --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c index a8d0be8..1ccc316 100644 --- a/drivers/net/e

Re: [PATCH v7 net-next 00/13] gtp: Additional feature support - Part I

2017-10-28 Thread David Miller
From: Tom Herbert Date: Sat, 28 Oct 2017 11:37:51 -0700 > Customers are using IPv6! Customers aren't using GTP with ipv6 the way you have implemented it. Please stop weasel-wording the situation to frame it in a way that purely benefits you and your objectives. Also, just because "nobody has d

Re: [PATCH v3 0/2] refactor code and mark expected switch fall-throughs

2017-10-28 Thread David Miller
From: David Ranch Date: Sat, 28 Oct 2017 10:53:24 -0700 > Does anyone else have thoughts on this topic? I think you are making a mountain out of a mole hill. If you care so much about this, set things up so that entities such as the kbuild test robot run whatever tests you think are necessary.

Re: Linux 4.14-rc6 bisected regression tun devices not working anymore in openvpn

2017-10-28 Thread David Miller
From: Cong Wang Date: Sat, 28 Oct 2017 10:37:27 -0700 > On Sat, Oct 28, 2017 at 7:57 AM, Sander Eikelenboom > wrote: >> The offending commit is: >> 0ad646c81b2182f7fa67ec0c8c825e0ee165696d >> "tun: call dev_get_valid_name() before register_netdevice()" >> >> Reverting this commit fixes t

[PATCH net-next] selftests/bpf: remove useless bpf_trace_printk

2017-10-28 Thread Alexei Starovoitov
sockmap test is using two programs that use bpf_trace_printk() which prints into trace_pipe, but nothing is reading it. Remove it. Fixes: 6f6d33f3b3d0 ("bpf: selftests add sockmap tests") Signed-off-by: Alexei Starovoitov --- tools/testing/selftests/bpf/sockmap_parse_prog.c | 3 --- tools/test

Re: [PATCH net-next 2/2] chcr: Add support for Inline IPSec

2017-10-28 Thread kbuild test robot
Hi Atul, Thank you for the patch! Yet we hit a small issue. [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Atul-Gupta/cxgb4-Add-support-for-Inline-IPSec-Tx/20171029-060344 config: ia64-allmodconfig (attached as .config) compiler: ia64-linux-gcc (GCC)

Re: [PATCH net-next 2/2] net sched act_vlan: VLAN action rewrite to use RCU lock/unlock and update

2017-10-28 Thread kbuild test robot
Hi Manish, Thank you for the patch! Yet we hit a small issue. [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Manish-Kurup/net-sched-act_vlan-Change-stats-update-to-use-per-core-stats/20171029-053449 reproduce: # apt-get install sparse

Re: [PATCH net-next 1/2] cxgb4: Add support for Inline IPSec Tx

2017-10-28 Thread kbuild test robot
Hi Atul, Thank you for the patch! Yet we hit a small issue. [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Atul-Gupta/cxgb4-Add-support-for-Inline-IPSec-Tx/20171029-060344 config: x86_64-kexec (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2

Re: [PATCH net-next 2/2] net sched act_vlan: VLAN action rewrite to use RCU lock/unlock and update

2017-10-28 Thread kbuild test robot
Hi Manish, Thank you for the patch! Yet we hit a small issue. [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Manish-Kurup/net-sched-act_vlan-Change-stats-update-to-use-per-core-stats/20171029-053449 config: ia64-allmodconfig (attached as .config) comp

Re: [PATCH V2 net] tuntap: properly align skb->head before building skb

2017-10-28 Thread Wei Wei
With this patch, the crash can’t be reproduced with the syz-repro and crash log0/log1. The auto-generated reproducers are here: https://github.com/dotweiba/skb_clone_atomic_inc_bug Thanks, Wei > On 28 Oct 2017, at 6:06 AM, David Miller wrote: > > From: Jason Wang > Date: Fri, 27 Oct 2017 11:

Re: [PATCH] phylink: Use common error handling code in phylink_create()

2017-10-28 Thread Russell King - ARM Linux
On Sat, Oct 28, 2017 at 10:00:33PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 28 Oct 2017 21:48:31 +0200 > > * Add a jump target so that a bit of exception handling can be better > reused at the end of this function. > > * Adjust three condition checks. > > This issue

Re: [PATCH] phylink: Use common error handling code in phylink_create()

2017-10-28 Thread Florian Fainelli
On 10/28/2017 01:00 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 28 Oct 2017 21:48:31 +0200 > > * Add a jump target so that a bit of exception handling can be better > reused at the end of this function. > > * Adjust three condition checks. > > This issue was detected by

[PATCH] lan78xx: Use common error handling code in lan78xx_phy_init()

2017-10-28 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 28 Oct 2017 22:42:52 +0200 * Add a jump target so that a specific error message is stored only once at the end of this function implementation. * Replace two calls of the function "netdev_err" by goto statements. * Adjust two condition checks. This issue was d

Re: [PATCH] ipv6: exthdrs: use swap macro in ipv6_dest_hao

2017-10-28 Thread Gustavo A. R. Silva
Quoting David Miller : From: "Gustavo A. R. Silva" Date: Thu, 26 Oct 2017 23:10:35 -0500 make use of the swap macro and remove unnecessary variable tmp_addr. This makes the code easier to read and maintain. This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Si

[PATCH] net: dccp: ccids: lib: packet_history: use swap macro in tfrc_rx_hist_swap

2017-10-28 Thread Gustavo A. R. Silva
Make use of the swap macro and remove unnecessary variable tmp. This makes the code easier to read and maintain. This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- net/dccp/ccids/lib/packet_history.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-

[PATCH] net: decnet: dn_nsp_out: use swap macro in dn_mk_ack_header

2017-10-28 Thread Gustavo A. R. Silva
Make use of the swap macro and remove unnecessary variable tmp. This makes the code easier to read and maintain. This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- net/decnet/dn_nsp_out.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff

[PATCH] netfilter: ipset: ip_set_bitmap_port: use swap macro in bitmap_port_create

2017-10-28 Thread Gustavo A. R. Silva
Make use of the swap macro and remove unnecessary variable tmp. This makes the code easier to read and maintain. This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- net/netfilter/ipset/ip_set_bitmap_port.c | 8 ++-- 1 file changed, 2 insertions(+), 6 d

[PATCH] netfilter: ipset: ip_set_bitmap_ip: use swap macro in bitmap_ip_create

2017-10-28 Thread Gustavo A. R. Silva
Make use of the swap macro and remove unnecessary variable tmp. This makes the code easier to read and maintain. This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- net/netfilter/ipset/ip_set_bitmap_ip.c | 8 ++-- 1 file changed, 2 insertions(+), 6 del

[PATCH] netfilter: ipset: ip_set_bitmap_ipmac: use swap macro in bitmap_ipmac_create

2017-10-28 Thread Gustavo A. R. Silva
Make use of the swap macro and remove unnecessary variable tmp. This makes the code easier to read and maintain. This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- net/netfilter/ipset/ip_set_bitmap_ipmac.c | 8 ++-- 1 file changed, 2 insertions(+), 6

Re: can: Use common error handling code in vxcan_newlink()

2017-10-28 Thread SF Markus Elfring
>> Are you interested in related adjustments for a bigger code base? > > No. Definitely not. You might have noticed that I am proposing similar changes already for other software modules. ;-) > If you aim for the the deletion of “ < 0” for all rtnl_configure_link() users > you would need to d

[PATCH] phylink: Use common error handling code in phylink_create()

2017-10-28 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 28 Oct 2017 21:48:31 +0200 * Add a jump target so that a bit of exception handling can be better reused at the end of this function. * Adjust three condition checks. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

Re: can: Use common error handling code in vxcan_newlink()

2017-10-28 Thread Oliver Hartkopp
On 10/28/2017 09:18 PM, SF Markus Elfring wrote: If you want to change the semantic of the result check I am curious if another source code reduction (by the deletion of “ < 0”) will become acceptable at similar places. Source code reduction is not the main target. If you can simplify code w

[PATCH] net: decnet: dn_nsp_in: use swap macro in dn_nsp_rx_packet

2017-10-28 Thread Gustavo A. R. Silva
Make use of the swap macro and remove unnecessary variable tmp. This makes the code easier to read and maintain. This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- net/decnet/dn_nsp_in.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff

Re: can: Use common error handling code in vxcan_newlink()

2017-10-28 Thread SF Markus Elfring
> If you want to change the semantic of the result check I am curious if another source code reduction (by the deletion of “ < 0”) will become acceptable at similar places. > - this has to done consistently at all rtnl_configure_link() caller sites. Are there any more functions to consider? >

Re: can: Use common error handling code in vxcan_newlink()

2017-10-28 Thread Oliver Hartkopp
On 10/28/2017 08:33 PM, SF Markus Elfring wrote: So if you would like to change the if-statement: It will need a small adjustment for the shown transformation. I was also unsure if the proposal will work in a single update step. 1. Send a patch for vxcan.c to improve the error handling flow

Re: [REGRESSION, BISECTED] Broken networking with net/phy/marvell

2017-10-28 Thread Andrew Lunn
On Thu, Oct 26, 2017 at 03:28:36PM +0300, Aaro Koskinen wrote: > Hi, > > When upgrading from v4.13 to v4.14-rc6 on OpenRD Client, the box loses > network connectivity. Hi Aaro What exactly is the PHY in the OpenRD? > > - mscr &= MII_88E1121_PHY_MSCR_DELAY_MASK; > + mscr &= ~MII_88E112

Re: [PATCH v7 net-next 00/13] gtp: Additional feature support - Part I

2017-10-28 Thread Tom Herbert
On Sat, Oct 28, 2017 at 9:47 AM, Harald Welte wrote: > Hi Tom, > > On Sat, Oct 28, 2017 at 09:16:01AM -0700, Tom Herbert wrote: >> Here is what the Kconfig for the EXPERIMENTAL option says: >> >> "This is an experimental implementation that allows encapsulating IPv6 >> over GTP and using GTP over

Re: can: Use common error handling code in vxcan_newlink()

2017-10-28 Thread SF Markus Elfring
> So if you would like to change the if-statement: It will need a small adjustment for the shown transformation. I was also unsure if the proposal will work in a single update step. > 1. Send a patch for vxcan.c to improve the error handling flow I am going to send a second approach for this u

[PATCH] netcp_core: Use common error handling code in netcp_create_interface()

2017-10-28 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 28 Oct 2017 20:11:02 +0200 Add a jump target so that a specific error code assignment is stored only once at the end of this function implementation. Replace five assignments by goto statements. This issue was detected by using the Coccinelle software. Signed-off

Re: [PATCH v3 0/2] refactor code and mark expected switch fall-throughs

2017-10-28 Thread David Ranch
Hello Gustavo, Thanks for the reply. I do appreciate the work but we've had other people contribute to keep things up to date but previous minor patches broke parts of the AX.25 stack in strange ways. The fixes weren't hard to repair or backout but due to the timing, various Linux distros b

[PATCH iproute2/net-next]tc: B.W limits can now be specified in %

2017-10-28 Thread Nishanth Devarajan
This patch adapts the tc command line interface to allow bandwidth limits to be specified as a percentage of the interface's capacity. For this purpose, we move int read_prop() from ip/iptuntap.c to lib/utils.c to make it accessible to tc. Additionally, adding this functionality requires passing

Re: [PATCH] can: Use common error handling code in vxcan_newlink()

2017-10-28 Thread Oliver Hartkopp
On 10/28/2017 10:23 AM, SF Markus Elfring wrote: @@ -227,10 +227,8 @@ static int vxcan_newlink(struct net *net, struct net_device *dev,   netif_carrier_off(peer);     err = rtnl_configure_link(peer, ifmp); -    if (err < 0) { -    unregister_netdevice(peer); -    return err; -

Re: Linux 4.14-rc6 bisected regression tun devices not working anymore in openvpn

2017-10-28 Thread Cong Wang
On Sat, Oct 28, 2017 at 7:57 AM, Sander Eikelenboom wrote: > L.S., > > While testing a linux 4.14-rc6 kernel i noticed OpenVPN didn't function > anymore. > My openvpn config uses tun devices and is pretty standard. > The openvpn version is current Debian stable: openvpn 2.4.0-6+deb9u2 > > From th

Re: [PATCH net-next] ipv6: prevent user from adding cached routes

2017-10-28 Thread Martin KaFai Lau
On Fri, Oct 27, 2017 at 05:30:12PM -0700, Wei Wang wrote: > So we fix this by failing the attemp to add cached routes from userspace > with returning EINVAL error. Acked-by: Martin KaFai Lau

[PATCH] ravb: Use common error handling code in ravb_probe()

2017-10-28 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 28 Oct 2017 19:10:08 +0200 Add a jump target so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/net/ethernet/renesas/ravb_main

Re: [patch net-next v2 00/20] net: sched: convert cls ndo_setup_tc offload calls to per-block callbacks

2017-10-28 Thread Jakub Kicinski
On Sat, 28 Oct 2017 10:43:51 +0200, Jiri Pirko wrote: > Sat, Oct 28, 2017 at 09:53:21AM CEST, kubak...@wp.pl wrote: > >On Sat, 28 Oct 2017 09:20:31 +0200, Jiri Pirko wrote: > >> Sat, Oct 28, 2017 at 02:52:00AM CEST, kubak...@wp.pl wrote: > >> >On Fri, 27 Oct 2017 09:27:30 +0200, Jiri Pirko wrot

Re: [PATCH] nfp: Improve unlocking of a mutex in area_cache_get()

2017-10-28 Thread Jakub Kicinski
On Sat, 28 Oct 2017 17:18:56 +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 28 Oct 2017 17:12:10 +0200 > > Add a jump target so that a call of the function "mutex_unlock" is stored > only once at the end of this function implementation. > Replace four calls by goto statements

Re: [PATCH v7 net-next 00/13] gtp: Additional feature support - Part I

2017-10-28 Thread Harald Welte
Hi Tom, On Sat, Oct 28, 2017 at 09:16:01AM -0700, Tom Herbert wrote: > Here is what the Kconfig for the EXPERIMENTAL option says: > > "This is an experimental implementation that allows encapsulating IPv6 > over GTP and using GTP over IPv6 for testing and development purposes. > This is not a sta

[PATCH] forcedeth: Use common error handling code in two functions

2017-10-28 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 28 Oct 2017 18:15:44 +0200 Add a jump target so that a bit of exception handling can be better reused at the end of these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/net/ethernet/nvidia/forcedet

Re: [PATCH v7 net-next 00/13] gtp: Additional feature support - Part I

2017-10-28 Thread Tom Herbert
On Sat, Oct 28, 2017 at 1:09 AM, Harald Welte wrote: > Hi Tom, > > my apologies for only getting back to reviews now, after return from > holidays I was too overloaded with plenty of other tasks. > > On Fri, Oct 27, 2017 at 05:09:24PM -0700, Tom Herbert wrote: >> - Experimental IPv6 support > >

[PATCH] net: phy: leds: Add support for "link" trigger

2017-10-28 Thread Maciej S. Szmigiero
Currently, we create a LED trigger for any link speed known to a PHY. These triggers only fire when their exact link speed had been negotiated (they aren't cumulative, that is, they don't fire for "their or any higher" link speed). What we are missing, however, is a trigger which will fire on any

[PATCH] nfp: Improve unlocking of a mutex in area_cache_get()

2017-10-28 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 28 Oct 2017 17:12:10 +0200 Add a jump target so that a call of the function "mutex_unlock" is stored only once at the end of this function implementation. Replace four calls by goto statements. This issue was detected by using the Coccinelle software. Signed-off-

Linux 4.14-rc6 bisected regression tun devices not working anymore in openvpn

2017-10-28 Thread Sander Eikelenboom
L.S., While testing a linux 4.14-rc6 kernel i noticed OpenVPN didn't function anymore. My openvpn config uses tun devices and is pretty standard. The openvpn version is current Debian stable: openvpn 2.4.0-6+deb9u2 >From the openvpn logging: Sat Oct 28 16:03:34 2017 us=175829 TUN/TAP device

[PATCH] net: atheros: atl1: Use common error handling code in atl1_xmit_frame()

2017-10-28 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 28 Oct 2017 16:22:30 +0200 Add a jump target so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/net/ethernet/atheros/atlx/atl1

Re: [PATCH v2 net-next 3/3] mlxsw: spectrum_router: Return extack message on abort due to fib rules

2017-10-28 Thread Ido Schimmel
On Fri, Oct 27, 2017 at 05:37:14PM -0700, David Ahern wrote: > Adding a FIB rule on a spectrum platform silently aborts FIB offload: > $ ip ru add pref 99 from all to 192.168.1.1 table 10 > $ dmesg -c > [ 623.144736] mlxsw_spectrum :03:00.0: FIB abort triggered. Note > that FIB en

Re: [PATCH v2 net-next 2/3] net: Add extack to fib_notifier_info

2017-10-28 Thread Ido Schimmel
On Fri, Oct 27, 2017 at 05:37:13PM -0700, David Ahern wrote: > Add extack to fib_notifier_info and plumb through stack to > call_fib_rule_notifiers, call_fib_entry_notifiers and > call_fib6_entry_notifiers. This allows notifer handlers to > return messages to user. > > Signed-off-by: David Ahern

Re: [PATCH v2] xdp: Sample xdp program implementing ip forward

2017-10-28 Thread Christina Jacob
On Wed, Oct 11, 2017 at 3:07 AM, David Daney wrote: > On 10/10/2017 10:19 AM, Stephen Hemminger wrote: >> >> On Tue, 10 Oct 2017 12:58:52 +0530 >> Christina Jacob wrote: >> >>> +/* Get the mac address of the interface given interface name */ >>> +static long *getmac(char *iface) >>> +{ >>> +

[PATCH net-next 1/1] forcedeth: replace pci_alloc_consistent with dma_alloc_coherent

2017-10-28 Thread Zhu Yanjun
The functions pci_alloc_consistent is obsolete. So it is replaced with dma_alloc_coherent Signed-off-by: Zhu Yanjun --- drivers/net/ethernet/nvidia/forcedeth.c | 61 ++--- 1 file changed, 41 insertions(+), 20 deletions(-) diff --git a/drivers/net/ethernet/nvidia/forc

[PATCH net-next] ip_vti: remove the useless err_count check in vti_xmit

2017-10-28 Thread Xin Long
Unlike ipip and gre, ip_vti never uses err_count in vti4_err, so no need to check err_count in vti_xmit, it's value always 0. Signed-off-by: Xin Long --- net/ipv4/ip_vti.c | 9 - 1 file changed, 9 deletions(-) diff --git a/net/ipv4/ip_vti.c b/net/ipv4/ip_vti.c index 58465c0..949f432 100

[PATCH net 3/4] sctp: fix a type cast warnings that causes a_rwnd gets the wrong value

2017-10-28 Thread Xin Long
These warnings were found by running 'make C=2 M=net/sctp/'. Commit d4d6fb5787a6 ("sctp: Try not to change a_rwnd when faking a SACK from SHUTDOWN.") expected to use the peers old rwnd and add our flight size to the a_rwnd. But with the wrong Endian, it may not work as well as expected. So fix it

[PATCH net 0/4] sctp: a bunch of fixes for some sparse warnings

2017-10-28 Thread Xin Long
As Eric noticed, when running 'make C=2 M=net/sctp/', a plenty of warnings or errors checked by sparse appear. They are all problems about Endian and type cast. Most of them are just warnings by which no issues could be caused while some might be bugs. This patchset fixes them with four patches b

[PATCH net 2/4] sctp: fix some type cast warnings introduced by transport rhashtable

2017-10-28 Thread Xin Long
These warnings were found by running 'make C=2 M=net/sctp/'. They are introduced by not aware of Endian for the port when coding transport rhashtable patches. Fixes: 7fda702f9315 ("sctp: use new rhlist interface on sctp transport rhashtable") Reported-by: Eric Dumazet Signed-off-by: Xin Long -

[PATCH net 1/4] sctp: fix some type cast warnings introduced by stream reconf

2017-10-28 Thread Xin Long
These warnings were found by running 'make C=2 M=net/sctp/'. They are introduced by not aware of Endian when coding stream reconf patches. Since commit c0d8bab6ae51 ("sctp: add get and set sockopt for reconf_enable") enabled stream reconf feature for users, the Fixes tag below would use it. Fixe

[PATCH net 4/4] sctp: fix some type cast warnings introduced since very beginning

2017-10-28 Thread Xin Long
These warnings were found by running 'make C=2 M=net/sctp/'. They are there since very beginning. Note after this patch, there still one warning left in sctp_outq_flush(): sctp_chunk_fail(chunk, SCTP_ERROR_INV_STRM) Since it has been moved to sctp_stream_outq_migrate on net-next, to avoid the e

Re: [PATCH 0/4] TI Bluetooth serdev support

2017-10-28 Thread Adam Ford
On Fri, Oct 27, 2017 at 5:55 AM, Adam Ford wrote: > On Tue, May 9, 2017 at 9:14 AM, Rob Herring wrote: >> On Mon, May 8, 2017 at 11:48 PM, Baruch Siach wrote: >>> Hi Rob, >>> >>> On Mon, May 08, 2017 at 04:12:16PM -0500, Rob Herring wrote: On Fri, May 5, 2017 at 9:51 AM, Adam Ford wrote: >

Re: [PATCH net-next 0/9] net: dsa: define port types

2017-10-28 Thread Egil Hjelmeland
Den 27. okt. 2017 21:37, skrev Andrew Lunn: On Fri, Oct 27, 2017 at 02:56:51PM +0200, Egil Hjelmeland wrote: The DSA code currently has 3 bitmaps in the dsa_switch structure: cpu_port_mask, dsa_port_mask and enabled_port_mask. Hi Vivien First I must apologize to everybody for not replying

Re: [PATCH] netfilter/ipvs: clear ipvs_property flag when SKB net namespace changed

2017-10-28 Thread Julian Anastasov
Hello, On Thu, 26 Oct 2017, Ye Yin wrote: > When run ipvs in two different network namespace at the same host, and one > ipvs transport network traffic to the other network namespace ipvs. > 'ipvs_property' flag will make the second ipvs take no effect. So we should > clear 'ipvs_propert

Re: [PATCH net-next] tcp: remove unnecessary include

2017-10-28 Thread David Miller
From: Alexei Starovoitov Date: Fri, 27 Oct 2017 10:01:39 -0700 > two extra #include are not necessary in tcp.h > Remove them. > > Fixes: 40304b2a1567 ("bpf: BPF support for sock_ops") > Signed-off-by: Alexei Starovoitov Applied, thank you.

Re: [PATCH net-next 00/12] tcp: move 12 sysctls to namespaces

2017-10-28 Thread David Miller
From: Eric Dumazet Date: Fri, 27 Oct 2017 07:47:20 -0700 > Ideally all TCP sysctls should be per netns. > This patch series takes care of 12 sysctls. Series applied, thanks Eric. > Remains the ones that need discussion : > > sysctl_tcp_mem, sysctl_tcp_rmem, sysctl_tcp_wmem, and sysctl_tcp_max_

Re: [PATCH] drivers/net: smsc: Convert timers to use timer_setup()

2017-10-28 Thread David Miller
From: Kees Cook Date: Thu, 26 Oct 2017 22:55:42 -0700 > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: "David S. Miller" > Cc: "yuval.sh...@

Re: [PATCH] drivers/net: korina: Convert timers to use timer_setup()

2017-10-28 Thread David Miller
From: Kees Cook Date: Thu, 26 Oct 2017 22:55:13 -0700 > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: "David S. Miller" > Cc: Roman Yeryomi

Re: [PATCH] tap: reference to KVA of an unloaded module causes kernel panic

2017-10-28 Thread David Miller
From: Girish Moodalbail Date: Fri, 27 Oct 2017 00:00:16 -0700 > The commit 9a393b5d5988 ("tap: tap as an independent module") created a > separate tap module that implements tap functionality and exports > interfaces that will be used by macvtap and ipvtap modules to create > create respective ta

Re: [PATCH] drivers/net: natsemi: Convert timers to use timer_setup()

2017-10-28 Thread David Miller
From: Kees Cook Date: Thu, 26 Oct 2017 22:55:27 -0700 > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: "David S. Miller" > Cc: Allen Pais >

Re: [PATCH] drivers/net: mellanox: Convert timers to use timer_setup()

2017-10-28 Thread David Miller
From: Kees Cook Date: Thu, 26 Oct 2017 22:55:20 -0700 > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Saeed Mahameed > Cc: Matan Barak > C

Re: [PATCH] drivers/net: packetengines: Convert timers to use timer_setup()

2017-10-28 Thread David Miller
From: Kees Cook Date: Thu, 26 Oct 2017 22:55:34 -0700 > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: "David S. Miller" > Cc: Allen Pais >

Re: [PATCH] drivers/net: fealnx: Convert timers to use timer_setup()

2017-10-28 Thread David Miller
From: Kees Cook Date: Thu, 26 Oct 2017 22:55:07 -0700 > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: "David S. Miller" > Cc: "yuval.sh...@

Re: [PATCH] drivers/net: chelsio/cxgb*: Convert timers to use timer_setup()

2017-10-28 Thread David Miller
From: Kees Cook Date: Thu, 26 Oct 2017 22:54:53 -0700 > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Santosh Raspatur > Cc: Ganesh Goudar

Re: [PATCH] drivers/net: dlink: Convert timers to use timer_setup()

2017-10-28 Thread David Miller
From: Kees Cook Date: Thu, 26 Oct 2017 22:54:59 -0700 > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Denis Kirjanov > Cc: netdev@vger.kern

Re: [PATCH] drivers/net: chelsio/cxgb*: Convert timers to use timer_setup()

2017-10-28 Thread David Miller
From: Kees Cook Date: Thu, 26 Oct 2017 22:54:53 -0700 > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Santosh Raspatur > Cc: Ganesh Goudar

Re: [PATCH] drivers/net: appletalk/cops: Convert timers to use timer_setup()

2017-10-28 Thread David Miller
From: Kees Cook Date: Thu, 26 Oct 2017 22:54:45 -0700 > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Allen Pais > Cc: "David S. Miller" >

Re: [PATCH] drivers/net: 8390: Convert timers to use timer_setup()

2017-10-28 Thread David Miller
From: Kees Cook Date: Thu, 26 Oct 2017 22:54:25 -0700 > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: netdev@vger.kernel.org > Signed-off-by

Re: [PATCH] drivers/net: amd: Convert timers to use timer_setup()

2017-10-28 Thread David Miller
From: Kees Cook Date: Thu, 26 Oct 2017 22:54:38 -0700 > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Tom Lendacky > Cc: "David S. Miller"

Re: [PATCH net] tcp: refresh tp timestamp before tcp_mtu_probe()

2017-10-28 Thread David Miller
From: Eric Dumazet Date: Thu, 26 Oct 2017 21:21:40 -0700 > From: Eric Dumazet > > In the unlikely event tcp_mtu_probe() is sending a packet, we > want tp->tcp_mstamp being as accurate as possible. > > This means we need to call tcp_mstamp_refresh() a bit earlier in > tcp_write_xmit(). > > Fi

Re: [PATCH] ipv6: exthdrs: use swap macro in ipv6_dest_hao

2017-10-28 Thread David Miller
From: "Gustavo A. R. Silva" Date: Thu, 26 Oct 2017 23:10:35 -0500 > make use of the swap macro and remove unnecessary variable tmp_addr. > This makes the code easier to read and maintain. > > This code was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva Applied to

Re: [PATCH V2 net] tuntap: properly align skb->head before building skb

2017-10-28 Thread David Miller
From: Jason Wang Date: Fri, 27 Oct 2017 11:05:44 +0800 > An unaligned alloc_frag->offset caused by previous allocation will > result an unaligned skb->head. This will lead unaligned > skb_shared_info and then unaligned dataref which requires to be > aligned for accessing on some architecture. Fix

Re: [PATCH net-next] stmmac: copy unicast mac address to MAC registers

2017-10-28 Thread David Miller
From: Bhadram Varka Date: Fri, 27 Oct 2017 08:22:02 +0530 > Currently stmmac driver not copying the valid ethernet > MAC address to MAC registers. This patch takes care > of updating the MAC register with MAC address. > > Signed-off-by: Bhadram Varka Applied, thank you.

Re: [PATCH net-next] nfp: inform the VF driver needs to be restarted after changing the MAC

2017-10-28 Thread David Miller
From: Jakub Kicinski Date: Thu, 26 Oct 2017 17:35:38 -0700 > From: Pablo Cascón > > Add message to inform the VF MAC was changed and the need to restart > the VF driver for the changes to be effective. > > Signed-off-by: Pablo Cascón > Signed-off-by: Jakub Kicinski Applied, thanks!

Re: [PATCH net-next] net: dsa: move fixed link registration helpers

2017-10-28 Thread David Miller
From: Vivien Didelot Date: Thu, 26 Oct 2017 10:50:07 -0400 > The new bindings (dsa2.c) and the old bindings (legacy.c) share two > helpers dsa_cpu_dsa_setup and dsa_cpu_dsa_destroy, used to register or > deregister a fixed PHY if a given port has a corresponding device node. > > Unclutter the co

Re: [PATCH net-next] liquidio: fix kernel panic in VF driver

2017-10-28 Thread David Miller
From: Felix Manlunas Date: Thu, 26 Oct 2017 16:46:36 -0700 > Doing ifconfig down on VF driver in the middle of receiving line rate > traffic causes a kernel panic: ... > Reason is: in the function assigned to net_device_ops->ndo_stop, the steps > for bringing down the interface are done in the

Re: [PATCH net-next] bnxt_en: Fix randconfig build errors.

2017-10-28 Thread David Miller
From: Michael Chan Date: Sat, 28 Oct 2017 01:56:10 -0400 > Fix undefined symbols when CONFIG_VLAN_8021Q or CONFIG_INET is not set. > > Fixes: 8c95f773b4a3 ("bnxt_en: add support for Flower based vxlan encap/decap > offload") > Reported-by: Jakub Kicinski > Signed-off-by: Michael Chan Applied

Re: [RFC PATCH v10 0/7] PCI: rockchip: Move PCIe WAKE# handling into pci core

2017-10-28 Thread Rafael J. Wysocki
On Friday, October 27, 2017 9:26:05 AM CEST Jeffy Chen wrote: > > Currently we are handling wake irq in mrvl wifi driver. Move it into > pci core. > > Tested on my chromebook bob(with cros 4.4 kernel and mrvl wifi). > > > Changes in v10: > Use device_set_wakeup_capable() instead of device_set_w

Re: [patch net-next v2 00/20] net: sched: convert cls ndo_setup_tc offload calls to per-block callbacks

2017-10-28 Thread Jiri Pirko
Sat, Oct 28, 2017 at 09:53:21AM CEST, kubak...@wp.pl wrote: >On Sat, 28 Oct 2017 09:20:31 +0200, Jiri Pirko wrote: >> Sat, Oct 28, 2017 at 02:52:00AM CEST, kubak...@wp.pl wrote: >> >On Fri, 27 Oct 2017 09:27:30 +0200, Jiri Pirko wrote: >> >> Yes, it is the same. >> > >> >FWIW I also see what Am

  1   2   >