Re: [PATCH net-next v7] openvswitch: enable NSH support

On Mon, Sep 04, 2017 at 06:42:16PM +0800, Jiri Benc wrote: > On Mon, 4 Sep 2017 16:00:05 +0800, Yang, Yi wrote: > > how can we know next push_nsh uses the same nsh header as previous > > one? > > We store the prepopulated header together with the action. > I checked source code but can't find whe

Re: [PATCH] geneve: Fix setting ttl value in collect metadata mode

On Sun, Sep 3, 2017 at 5:49 AM, Haishuang Yan wrote: > If key->tos is zero in collect metadata mode, tos should fallback to > ip{4,6}_dst_hoplimit, same as normal mode. > > Signed-off-by: Haishuang Yan > --- > drivers/net/geneve.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > >

Re: [PATCH net-next v7] openvswitch: enable NSH support

On Mon, Sep 04, 2017 at 08:57:44PM +0800, Jiri Benc wrote: > On Mon, 4 Sep 2017 20:09:07 +0800, Yang, Yi wrote: > > So we must do many changes if we want to break this assumption. > > We may do as many changes as we want to. This is uAPI we're talking > about and we need to get it right since the

[PATCH net-next] bpf: fix numa_node validation

From: Eric Dumazet syzkaller reported crashes in bpf map creation or map update [1] Problem is that nr_node_ids is a signed integer, NUMA_NO_NODE is also an integer, so it is very tempting to declare numa_node as a signed integer. This means the typical test to validate a user provided value :

linux-next: manual merge of the akpm-current tree with the net-next tree

Hi Andrew, Today's linux-next merge of the akpm-current tree got a conflict in: arch/sh/configs/se7751_defconfig between commit: 9efdb14f76f4 ("net: Remove CONFIG_NETFILTER_DEBUG and _ASSERT() macros.") from the net-next tree and commit: a83883ff2285 ("sh: defconfig: cleanup from old Kc

Re: Fwd: DA850-evm MAC Address is random

Hi Adam, On Wednesday 30 August 2017 11:08 AM, Sekhar Nori wrote: >> I wonder if U-Boot isn't pushing something to Linux because it doesn't >> appear to be running some of the da850 specific code even when I run >> linux-next. Can you tell me what verision of U-Boot you're using? >> Other than us

Re: [PATCH net-next v6 3/3] openvswitch: enable NSH support

On Mon, Sep 04, 2017 at 07:22:26PM +0800, Hannes Frederic Sowa wrote: > Hello, > > "Yang, Yi" writes: > > > On Wed, Aug 30, 2017 at 05:53:27PM +0800, Hannes Frederic Sowa wrote: > >> Hello, > >> > >> Yi Yang writes: > >> > >> [...] > >> > >> > +struct ovs_key_nsh { > >> > +u8 flags;

Re: [PATCH 1/2] netfilter/xt_hashlimit: new feature/algorithm for xt_hashlimit

On 09/04/2017 06:14 AM, Pablo Neira Ayuso wrote: > Sounds good, applied, thanks. > > A couple of questions: Does it really make sense to expose > --hashlimit-rate-interval or are you using 1 second always there? I > always wonder if it makes sense to expose yet another toggle that it's > not clear

[PATCH net V2] vhost_net: correctly check tx avail during rx busy polling

We check tx avail through vhost_enable_notify() in the past which is wrong since it only checks whether or not guest has filled more available buffer since last avail idx synchronization which was just done by vhost_vq_avail_empty() before. What we really want is checking pending buffers in the ava

[PATCH] netfilter: xt_hashlimit: fix 64 bit division compile error

commit bea74641e378 ("netfilter: xt_hashlimit: add rate match mode") introduced a line where we divide two 64bit unsigned integers. This breaks on ARM processors with the error: ERROR: "__aeabi_uldivmod" [net/netfilter/xt_hashlimit.ko] undefined! We can fix it by using div64_u64 instead. Fixes:

[PATCH iproute2 master 0/2] Two minor BPF updates

Two minor updates including a small cleanup for dumping the trace pipe and one for consolidating prog dumps for tc and xdp to use bpf_prog_info_by_fd() when possible. Thanks! Daniel Borkmann (2): bpf: minor cleanups for bpf_trace_pipe bpf: consolidate dumps to use bpf_dump_prog_info include

[PATCH iproute2 master 1/2] bpf: minor cleanups for bpf_trace_pipe

Just minor nits, e.g. no need to fflush() and instead of returning right away, just break and close the fd. Signed-off-by: Daniel Borkmann --- lib/bpf.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/lib/bpf.c b/lib/bpf.c index 5fd4928..7463fdc 100644 --

[PATCH iproute2 master 2/2] bpf: consolidate dumps to use bpf_dump_prog_info

Consolidate dump of prog info to use bpf_dump_prog_info() when possible. Moving forward, we want to have a consistent output for BPF progs when being dumped. E.g. in cls/act case we used to dump tag as a separate netlink attribute before we had BPF_OBJ_GET_INFO_BY_FD bpf(2) command. Move dumping t

Re: linux-next: manual merge of the tip tree with the net-next tree

Hi Dave, On Thu, 31 Aug 2017 13:47:02 +1000 Stephen Rothwell wrote: > > Today's linux-next merge of the tip tree got a conflict in: > > drivers/net/ethernet/cavium/liquidio/lio_main.c > > between commit: > > d1d97ee6e3a8 ("liquidio: moved liquidio_napi_drv_callback to lio_core.c") > > fr

net-next is CLOSED

If it isn't a bug fix and it isn't in patchwork right now, I don't want to see it. This time around inappropriate submissions will be silently marked as "deferred" in patchwork and not even looked at by me. Thanks.

Re: [PATCH 00/12] Netfilter updates for next-net (part 2)

From: Pablo Neira Ayuso Date: Mon, 4 Sep 2017 22:11:02 +0200 > The following patchset contains Netfilter updates for net-next. This > patchset includes updates for nf_tables, removal of > CONFIG_NETFILTER_DEBUG and a new mode for xt_hashlimit. More > specifically, they: Pulled, thanks. Since t

Re: [PATCH v3 2/3] dt-binding: net: sfp binding documentation

Hi Florian, On Mon, Sep 04, 2017 at 01:16:26PM -0700, Florian Fainelli wrote: > Le 09/03/17 à 05:31, Baruch Siach a écrit : [...] > > diff --git a/Documentation/devicetree/bindings/net/sff,sfp.txt > > b/Documentation/devicetree/bindings/net/sff,sfp.txt > > new file mode 100644 > > index 00

Re: [PATCH v3 2/3] dt-binding: net: sfp binding documentation

Le 09/03/17 à 05:31, Baruch Siach a écrit : > Add device-tree binding documentation SFP transceivers. Support for SFP > transceivers has been recently introduced (drivers/net/phy/sfp.c). > > Signed-off-by: Baruch Siach > --- > v3: > Mention gpios phandle and specifier > Mention the polarity o

[PATCH 07/12] net: Remove CONFIG_NETFILTER_DEBUG and _ASSERT() macros.

From: Varsha Rao This patch removes CONFIG_NETFILTER_DEBUG and _ASSERT() macros as they are no longer required. Replace _ASSERT() macros with WARN_ON(). Signed-off-by: Varsha Rao Signed-off-by: Pablo Neira Ayuso --- arch/parisc/configs/c3000_defconfig | 1 - arch/sh/configs/se7751_defconfig

[PATCH 06/12] net: Replace NF_CT_ASSERT() with WARN_ON().

From: Varsha Rao This patch removes NF_CT_ASSERT() and instead uses WARN_ON(). Signed-off-by: Varsha Rao --- include/net/netfilter/nf_conntrack.h | 2 +- net/ipv4/netfilter/nf_conntrack_proto_icmp.c | 2 +- net/ipv4/netfilter/nf_nat_l3proto_ipv4.c | 6 +++--- net/ipv4/netf

[PATCH 03/12] netfilter: nft_limit: replace pkt_bytes with bytes

From: "Pablo M. Bermudo Garay" Just a small refactor patch in order to improve the code readability. Signed-off-by: Pablo M. Bermudo Garay Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nft_limit.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --

[PATCH 04/12] netfilter: nft_limit: add stateful object type

From: "Pablo M. Bermudo Garay" Register a new limit stateful object type into the stateful object infrastructure. Signed-off-by: Pablo M. Bermudo Garay Signed-off-by: Pablo Neira Ayuso --- include/uapi/linux/netfilter/nf_tables.h | 3 +- net/netfilter/nft_limit.c| 122 ++

[PATCH 10/12] netlink: add NLM_F_NONREC flag for deletion requests

In the last NFWS in Faro, Portugal, we discussed that netlink is lacking the semantics to request non recursive deletions, ie. do not delete an object iff it has child objects that hang from this parent object that the user requests to be deleted. We need this new flag to solve a problem for the i

[PATCH 05/12] netfilter: remove unused hooknum arg from packet functions

From: Florian Westphal tested with allmodconfig build. Signed-off-by: Florian Westphal --- include/net/netfilter/nf_conntrack_l4proto.h | 1 - net/ipv4/netfilter/nf_conntrack_proto_icmp.c | 1 - net/ipv6/netfilter/nf_conntrack_proto_icmpv6.c | 6 ++ net/netfilter/nf_conntrack_core.c

[PATCH 08/12] netfilter: nf_tables: add nf_tables_updchain()

nf_tables_newchain() is too large, wrap the chain update path in a function to make it more maintainable. Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nf_tables_api.c | 170 +++--- 1 file changed, 92 insertions(+), 78 deletions(-) diff --git a/net/netfi

[PATCH 00/12] Netfilter updates for next-net (part 2)

Hi David, The following patchset contains Netfilter updates for net-next. This patchset includes updates for nf_tables, removal of CONFIG_NETFILTER_DEBUG and a new mode for xt_hashlimit. More specifically, they: 1) Add new rate match mode for hashlimit, this introduces a new revision for this

[PATCH 11/12] netfilter: nf_tables: use NLM_F_NONREC for deletion requests

Bail out if user requests non-recursive deletion for tables and sets. This new flags tells nf_tables netlink interface to reject deletions if tables and sets have content. Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nf_tables_api.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion

[PATCH 02/12] netfilter: nf_tables: add select_ops for stateful objects

From: "Pablo M. Bermudo Garay" This patch adds support for overloading stateful objects operations through the select_ops() callback, just as it is implemented for expressions. This change is needed for upcoming additions to the stateful objects infrastructure. Signed-off-by: Pablo M. Bermudo G

[PATCH 01/12] netfilter: xt_hashlimit: add rate match mode

From: Vishwanath Pai This patch adds a new feature to hashlimit that allows matching on the current packet/byte rate without rate limiting. This can be enabled with a new flag --hashlimit-rate-match. The match returns true if the current rate of packets is above/below the user specified value. T

[PATCH 09/12] netfilter: nf_tables: add nf_tables_addchain()

Wrap the chain addition path in a function to make it more maintainable. Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nf_tables_api.c | 199 ++ 1 file changed, 106 insertions(+), 93 deletions(-) diff --git a/net/netfilter/nf_tables_api.c b/net/netfi

[PATCH 12/12] netfilter: nf_tables: support for recursive chain deletion

This patch sorts out an asymmetry in deletions. Currently, table and set deletion commands come with an implicit content flush on deletion. However, chain deletion results in -EBUSY if there is content in this chain, so no implicit flush happens. So you have to send a flush command in first place t

Re: [iproute PATCH] lib/bpf: Fix bytecode-file parsing

On Tue, 29 Aug 2017 17:09:45 +0200 Phil Sutter wrote: > The signedness of char type is implementation dependent, and there are > architectures on which it is unsigned by default. In that case, the > check whether fgetc() returned EOF failed because the return value was > assigned an (unsigned) ch

Re: [pull request][net-next 0/3] Mellanox, mlx5 GRE tunnel offloads

On Mon, Sep 4, 2017 at 10:57 AM, Hannes Frederic Sowa wrote: > Hi Tom, > > Tom Herbert writes: > >>> The problem is that you end up having two streams, one fragmented and >>> one non-fragmented, but actually they belong to the same stream. It is >>> known to break stuff, see: >>> >>>

[net-next PATCH V2] ixgbe: add counter for times rx pages gets allocated, not recycled

The ixgbe driver have page recycle scheme based around the RX-ring queue, where a RX page is shared between two packets. Based on the refcnt, the driver can determine if the RX-page is currently only used by a single packet, if so it can then directly refill/recycle the RX-slot by with the opposite

Re: [iproute PATCH 1/6] utils: Implement strlcpy() and strlcat()

On Mon, 4 Sep 2017 17:00:15 +0200 Phil Sutter wrote: > On Mon, Sep 04, 2017 at 02:49:20PM +, David Laight wrote: > > From: Phil Sutter > > > Sent: 01 September 2017 17:53 > > > By making use of strncpy(), both implementations are really simple so > > > there is no need to add libbsd as addi

Re: [pull request][net-next 0/3] Mellanox, mlx5 GRE tunnel offloads

Hi Tom, Tom Herbert writes: >> The problem is that you end up having two streams, one fragmented and >> one non-fragmented, but actually they belong to the same stream. It is >> known to break stuff, see: >> >> >> >> I would agree with you, but we can'

Re: [pull request][net-next 0/3] Mellanox, mlx5 GRE tunnel offloads

> The problem is that you end up having two streams, one fragmented and > one non-fragmented, but actually they belong to the same stream. It is > known to break stuff, see: > > > > I would agree with you, but we can't break existing setups, > unfortunate

Mutual Coperation Thank you

-- Dear Friend, I know that this message will come to you as a surprise. I am the Auditing and Accounting section manager with African Development Bank, Ouagadougou Burkina faso. I Hope that you will not expose or betray this trust and confident that I am about to repose on you for the mutual ben

Re: [PATCH 1/1] net: mdio-mux: add mdio_mux parameter to mdio_mux_init()

On 09/04/2017 09:30 AM, Corentin Labbe wrote: > mdio_mux_init() use the parameter dev for two distinct thing: > 1) Have a device for all devm_ functions > 2) Get device_node from it > > Since it is two distinct purpose, this patch add a parameter mdio_mux > that is linked to task 2. > > This will

Re: [PATCH 1/1] net: mdio-mux: add mdio_mux parameter to mdio_mux_init()

On 09/04/2017 09:30 AM, Corentin Labbe wrote: > mdio_mux_init() use the parameter dev for two distinct thing: > 1) Have a device for all devm_ functions > 2) Get device_node from it > > Since it is two distinct purpose, this patch add a parameter mdio_mux > that is linked to task 2. > > This will

Re: [pull request][net-next 0/3] Mellanox, mlx5 GRE tunnel offloads

Hello Tom, Tom Herbert writes: > On Mon, Sep 4, 2017 at 6:50 AM, Hannes Frederic Sowa > wrote: >> Tom Herbert writes: >> >>> An encapsulator sets the UDP source port to be the flow entropy of the >>> packet being encapsulated. So when the packet traverses the network >>> devices can base their

Re: [Intel-wired-lan] [PATCH] e1000e: changed some expensive calls of udelay to usleep_range

Dear Matthew, On 08/23/17 17:59, Matthew Tan wrote: Calls to udelay are not preemtable by userspace so userspace applications experience a large (~200us) latency when running on core 0. Instead usleep_range can be used to be more friendly to userspace since it is preemtable.

[PATCH 1/1] net: mdio-mux: add mdio_mux parameter to mdio_mux_init()

mdio_mux_init() use the parameter dev for two distinct thing: 1) Have a device for all devm_ functions 2) Get device_node from it Since it is two distinct purpose, this patch add a parameter mdio_mux that is linked to task 2. This will also permit to register an of_node mdio-mux that lacks a dire

[PATCH 0/1] net: mdio-mux: add mdio_mux parameter to mdio_mux_init()

Hello For dwmac-sun8i, we need to set a MDIO mux which is not itself a device (it is part of a device but have its own DT node) This patch permit to use a MDIO mux for such case. See agreement at https://lkml.org/lkml/2017/8/29/407 Since all mdio_mux_init() users are within drivers/net/phy/ and

Re: [PATCH] e1000e: changed some expensive calls of udelay to usleep_range

Hi! > @@ -183,7 +183,7 @@ s32 e1000e_read_phy_reg_mdic(struct e1000_hw *hw, u32 > offset, u16 *data) >* reading duplicate data in the next MDIC transaction. >*/ > if (hw->mac.type == e1000_pch2lan) > - udelay(100); > + usleep_range(90, 100); > >

Re: [pull request][net-next 0/3] Mellanox, mlx5 GRE tunnel offloads

On Mon, Sep 4, 2017 at 6:50 AM, Hannes Frederic Sowa wrote: > Tom Herbert writes: > >> An encapsulator sets the UDP source port to be the flow entropy of the >> packet being encapsulated. So when the packet traverses the network >> devices can base their hash just on the canonical 5-tuple which i

Re: [PATCH v06 35/36] uapi linux/tls.h: don't include in user space

On Wed, Aug 09, 2017 at 02:25:54AM +0300, Dmitry V. Levin wrote: > On Sun, Aug 06, 2017 at 06:44:26PM +0200, Mikko Rapeli wrote: > > It is not needed and not part of uapi headers, but causes > > user space compilation error: > > > > fatal error: net/tcp.h: No such file or directory > > #include

Re: [iproute PATCH 1/6] utils: Implement strlcpy() and strlcat()

On Mon, Sep 04, 2017 at 02:49:20PM +, David Laight wrote: > From: Phil Sutter > > Sent: 01 September 2017 17:53 > > By making use of strncpy(), both implementations are really simple so > > there is no need to add libbsd as additional dependency. > > > ... > > + > > +size_t strlcpy(char *dst,

Re: virtio_net: ethtool supported link modes

On Fri, 2017-09-01 at 20:45 +0300, Michael S. Tsirkin wrote: > On Fri, Sep 01, 2017 at 05:19:53PM +0100, Radu Rendec wrote: > > On Fri, 2017-09-01 at 18:43 +0300, Michael S. Tsirkin wrote: > > > On Thu, Aug 31, 2017 at 06:04:04PM +0100, Radu Rendec wrote: > > > > Looking at the code in virtnet_set_

[PATCH] net: ipv6: fix regression of no RTM_DELADDR sent after DAD failure

Commit f784ad3d79e5 ("ipv6: do not send RTM_DELADDR for tentative addresses") incorrectly assumes that no RTM_NEWADDR are sent for addresses in tentative state, as this does happen for the standard IPv6 use-case of DAD failure, see the call to ipv6_ifa_notify() in addconf_dad_stop(). So as a result

RE: [iproute PATCH 1/6] utils: Implement strlcpy() and strlcat()

From: Phil Sutter > Sent: 01 September 2017 17:53 > By making use of strncpy(), both implementations are really simple so > there is no need to add libbsd as additional dependency. > ... > + > +size_t strlcpy(char *dst, const char *src, size_t size) > +{ > + if (size) { > + strncpy

RE: [PATCH net-next v7] openvswitch: enable NSH support

> On Mon, 4 Sep 2017 14:07:45 +, Jan Scheurich wrote: > > Then perhaps I misunderstood your comment. I thought you didn't like that > > the > > SET_MASKED action wrapped OVS_KEY_ATTR_NSH which in itself was nested. > > I was aiming to avoid this by lifting the two components of the NSH header

[PATCH net-next] rxrpc: Make service connection lookup always check for retry

When an RxRPC service packet comes in, the target connection is looked up by an rb-tree search under RCU and a read-locked seqlock; the seqlock retry check is, however, currently skipped if we got a match, but probably shouldn't be in case the connection we found gets replaced whilst we're doing a

Re: [PATCH net-next v7] openvswitch: enable NSH support

On Mon, 4 Sep 2017 14:07:45 +, Jan Scheurich wrote: > Then perhaps I misunderstood your comment. I thought you didn't like that the > SET_MASKED action wrapped OVS_KEY_ATTR_NSH which in itself was nested. > I was aiming to avoid this by lifting the two components of the NSH header > component

RE: [PATCH net-next v7] openvswitch: enable NSH support

> > So is what you are suggesting the following? > > > > For matching: > > OVS_KEY_ATTR_NSH_BASE_HEADERmandatory > > OVS_KEY_ATTR_NSH_MD1_CONTEXToptional, in case MDTYPE == MD1 > > This needs to be: > > OVS_KEY_ATTR_NSH > OVS_KEY_ATTR_NSH_BASE_HEADER >

Re: [pull request][net-next 0/3] Mellanox, mlx5 GRE tunnel offloads

Tom Herbert writes: > An encapsulator sets the UDP source port to be the flow entropy of the > packet being encapsulated. So when the packet traverses the network > devices can base their hash just on the canonical 5-tuple which is > sufficient for ECMP and RSS. IPv6 flow label is even better sin

Re: EINVAL when using connect() for udp sockets

On 28 April 2017 at 14:48, Eric Dumazet wrote: > On Fri, 2017-04-28 at 12:55 +1000, Daurnimator wrote: >> On 1 April 2017 at 03:52, Cong Wang wrote: >> > Please submit your patch formally and with a man page patch too. >> >> Did a patch get submitted? I had a look but couldn't see it. > > Not yet

Re: [PATCH net-next v7] openvswitch: enable NSH support

On Mon, 4 Sep 2017 12:57:15 +, Jan Scheurich wrote: > So is what you are suggesting the following? > > For matching: > OVS_KEY_ATTR_NSH_BASE_HEADER mandatory > OVS_KEY_ATTR_NSH_MD1_CONTEXT optional, in case MDTYPE == MD1 This needs to be: OVS_KEY_ATTR_NSH OVS_KEY_AT

Re: [PATCH net-next v7] openvswitch: enable NSH support

On Wed, 30 Aug 2017 20:39:12 +0800, Yi Yang wrote: > +enum ovs_nsh_key_attr { > + OVS_NSH_KEY_ATTR_BASE, /* struct ovs_nsh_key_base. */ > + OVS_NSH_KEY_ATTR_MD1, /* struct ovs_nsh_key_md1. */ > + OVS_NSH_KEY_ATTR_MD2, /* variable-length octets for MD type 2. */ > + __OVS_NSH_KE

RE: [PATCH net-next v7] openvswitch: enable NSH support

> On Mon, 4 Sep 2017 16:00:05 +0800, Yang, Yi wrote: > > I think we have had similiar discussion about this, the issue is we have > > no way to handle both MD type 1 and MD type 2 by using a common flow key > > struct. > > > > So we have to do so, there is miniflow to handle such issue in > > user

stable-kernel-rules: wireless and netdev-FAQ

(adding netdev and lkml) Stanislaw Gruszka writes: > On Fri, Sep 01, 2017 at 05:31:57PM +0300, Kalle Valo wrote: >> Stanislaw Gruszka writes: >> >> > On Thu, Aug 31, 2017 at 10:33:28AM -0500, Larry Finger wrote: >> >> Should the patch to wireless-drivers be annotated with a Stable reference >

Re: [PATCH net-next v7] openvswitch: enable NSH support

On Mon, 4 Sep 2017 20:09:07 +0800, Yang, Yi wrote: > So we must do many changes if we want to break this assumption. We may do as many changes as we want to. This is uAPI we're talking about and we need to get it right since the beginning. Sure, it may mean that some user space programs need some

Re: [PATCH net-next v7] openvswitch: enable NSH support

On Mon, Sep 04, 2017 at 12:42:16PM +0200, Jiri Benc wrote: > On Mon, 4 Sep 2017 16:00:05 +0800, Yang, Yi wrote: > > I think we have had similiar discussion about this, the issue is we have > > no way to handle both MD type 1 and MD type 2 by using a common flow key > > struct. > > > > So we have

RE: [PATCH net-next v6 3/3] openvswitch: enable NSH support

> >> Does it makes sense to keep the context headers as part of the flow? > >> What is the reasoning behind it? With mdtype 2 headers this might either > >> not work very well or will increase sw_flow_key size causing slowdowns > >> for all protocols. > > > > For userspace, miniflow can handle such

Re: [ethtool] ethtool: Remove UDP Fragmentation Offload use from ethtool

On 29/08/2017 1:44 PM, Michal Kubecek wrote: On Tue, Aug 29, 2017 at 10:50:20AM +0300, Tariq Toukan wrote: On 28/08/2017 9:22 PM, John W. Linville wrote: On Mon, Aug 28, 2017 at 08:00:11AM -0700, Eric Dumazet wrote: On Mon, 2017-08-28 at 15:38 +0300, Tariq Toukan wrote: From: Shaker Daibes

Re: [ovs-dev] [PATCH net-next v6 3/3] openvswitch: enable NSH support

Hello, Jan Scheurich writes: >> >> >> Does it makes sense to keep the context headers as part of the flow? >> >> >> What is the reasoning behind it? With mdtype 2 headers this might >> >> >> either not work very well or will increase sw_flow_key size causing >> >> >> slowdowns for all protocols.

Re: [PATCH 1/2] netfilter/xt_hashlimit: new feature/algorithm for xt_hashlimit

On Mon, Sep 04, 2017 at 12:14:33PM +0200, Pablo Neira Ayuso wrote: > On Fri, Aug 18, 2017 at 04:58:59PM -0400, Vishwanath Pai wrote: > [...] > > The main difference between the existing algorithm and the new one is > > that the existing algorithm rate-limits the flow whereas the new > > algorithm d

Re: [PATCH net-next v6 3/3] openvswitch: enable NSH support

Hello, "Yang, Yi" writes: > On Wed, Aug 30, 2017 at 05:53:27PM +0800, Hannes Frederic Sowa wrote: >> Hello, >> >> Yi Yang writes: >> >> [...] >> >> > +struct ovs_key_nsh { >> > + u8 flags; >> > + u8 ttl; >> > + u8 mdtype; >> > + u8 np; >> > + __be32 path_hdr; >> > + __be32 context[NSH_

Re: [PATCH net-next v7] openvswitch: enable NSH support

On Mon, 4 Sep 2017 16:00:05 +0800, Yang, Yi wrote: > I think we have had similiar discussion about this, the issue is we have > no way to handle both MD type 1 and MD type 2 by using a common flow key > struct. > > So we have to do so, there is miniflow to handle such issue in > userspace, but ke

Re: [PATCH 1/2] netfilter/xt_hashlimit: new feature/algorithm for xt_hashlimit

On Fri, Aug 18, 2017 at 04:58:59PM -0400, Vishwanath Pai wrote: [...] > The main difference between the existing algorithm and the new one is > that the existing algorithm rate-limits the flow whereas the new > algorithm does not. Instead it *classifies* the flow based on whether > it is above or b

[PATCH v3 net-next 1/2] net: Export tcpv6_prot

Want to be able to use these in TLS. Signed-off-by: Boris Pismenny --- net/ipv6/tcp_ipv6.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c index 38f76d8..60d0629 100644 --- a/net/ipv6/tcp_ipv6.c +++ b/net/ipv6/tcp_ipv6.c @@ -1948,6 +1948,7 @@ struct

[PATCH v3 net-next 2/2] tls: Use correct sk->sk_prot for IPV6

The tls ulp overrides sk->prot with a new tls specific proto structs. The tls specific structs were previously based on the ipv4 specific tcp_prot sturct. As a result, attaching the tls ulp to an ipv6 tcp socket replaced some ipv6 callback with the ipv4 equivalents. This patch adds ipv6 tls proto

[PATCH v3 net-next 0/2] Use correct sk->sk_prot for IPV6

The tls ulp overrides sk->prot with a new tls specific proto structs. The tls specific structs were previously based on the ipv4 specific tcp_prot sturct. As a result, attaching the tls ulp to an ipv6 tcp

Re: [PATCH v3 2/3] dt-binding: net: sfp binding documentation

Hello! On 9/3/2017 3:31 PM, Baruch Siach wrote: Add device-tree binding documentation SFP transceivers. Support for SFP transceivers has been recently introduced (drivers/net/phy/sfp.c). Signed-off-by: Baruch Siach [...] diff --git a/Documentation/devicetree/bindings/net/sff,sfp.txt b/Docu

RE: [ovs-dev] [PATCH net-next v6 3/3] openvswitch: enable NSH support

> >> >> Does it makes sense to keep the context headers as part of the flow? > >> >> What is the reasoning behind it? With mdtype 2 headers this might > >> >> either not work very well or will increase sw_flow_key size causing > >> >> slowdowns for all protocols. > >> > [Mooney, Sean K] > >> > Havi

Re: [pull request][net-next 0/3] Mellanox, mlx5 GRE tunnel offloads

Hello, Saeed Mahameed writes: [...] > On Sat, Sep 2, 2017 at 6:32 PM, Hannes Frederic Sowa > wrote: >> Sorry, I think I am still confused. >> >> I just want to make sure that you don't use the first nibble after the >> mpls bottom of stack label in any way as an indicator if that is an IPv4 >>

Re: netdev watchdog enp1s0 (tg3): transmit queue 0 timed out

On Fri, Sep 1, 2017 at 12:13 PM, Frans van Berckel wrote: > Dear Michael and Siva, > > On Thu, 2017-08-31 at 23:36 -0700, Michael Chan wrote: >> On Thu, Aug 31, 2017 at 11:10 PM, Frans van Berckel >> wrote: >> > >> > a long list of likely the same type of error codes. >> > >> >> Please post the

[PATCH net-next v7] net: stmmac: Delete dead code for MDIO registration

This code is no longer used, the logging function was changed by commit fbca164776e4 ("net: stmmac: Use the right logging function in stmmac_mdio_register"). It was previously showing information about the type of the IRQ, if it's polled, ignored or a normal interrupt. As we don't want information

[PATCH v3 1/2] ip_tunnel: fix ip tunnel lookup in collect_md mode

In collect_md mode, if the tun dev is down, it still can call ip_tunnel_rcv to receive on packets, and the rx statistics increase improperly. Fixes: 2e15ea390e6f ("ip_gre: Add support to collect tunnel metadata.") Cc: Pravin B Shelar Signed-off-by: Haishuang Yan --- Change since v3: * Increme

[PATCH v3 2/2] ip6_tunnel: fix ip6 tunnel lookup in collect_md mode

In collect_md mode, if the tun dev is down, it still can call __ip6_tnl_rcv to receive on packets, and the rx statistics increase improperly. Fixes: 8d79266bc48c ("ip6_tunnel: add collect_md mode to IPv6 tunnels") Cc: Alexei Starovoitov Signed-off-by: Haishuang Yan --- Change since v3: * Incr

Re: [PATCH] mm/vmstats: add counters for the page frag cache

On 04.09.2017 04:35, Kyeongdon Kim wrote: Thanks for your reply, But I couldn't find "NR_FRAGMENT_PAGES" in linux-next.git .. is that vmstat counter? or others? I mean rather than adding bunch vmstat counters for operations it might be worth to add page counter which will show current amount

Re: [PATCH net-next v7] openvswitch: enable NSH support

On Thu, Aug 31, 2017 at 06:45:16PM +0800, Jiri Benc wrote: > > + mask->context[i]); > > + } > > + memcpy(flow_key->nsh.context, nsh->md1.context, > > + sizeof(nsh->md1.context)); > > Do you follow the discussion that Hannes Sowa

Re: [PATCH v2 net-next 1/4] bpf: add helper bpf_perf_read_counter_time for perf event array map

On Fri, Sep 01, 2017 at 10:48:21PM -0700, Yonghong Song wrote: > diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h > index b14095b..5a50808 100644 > --- a/include/linux/perf_event.h > +++ b/include/linux/perf_event.h > @@ -898,7 +898,8 @@ perf_event_create_kernel_counter(struct p

[net v2] gianfar: Fix Tx flow control deactivation

The wrong register is checked for the Tx flow control bit, it should have been maccfg1 not maccfg2. This went unnoticed for so long probably because the impact is hardly visible, not to mention the tangled code from adjust_link(). First, link flow control (i.e. handling of Rx/Tx link level pause fr