On Mon, 4 Sep 2017 20:09:07 +0800, Yang, Yi wrote: > So we must do many changes if we want to break this assumption.
We may do as many changes as we want to. This is uAPI we're talking about and we need to get it right since the beginning. Sure, it may mean that some user space programs need some changes in order to make use of the new features. That happens every day. I also don't understand where's the problem. It's very easy to check for NLA_F_NESTED and generically act based on that in the function you quoted. Just call a different function than format_odp_key_attr to handle ovs_nsh_key_attr attributes in case the nested flag is set and the attribute is OVS_KEY_ATTR_NSH and you're done. You'll need such function anyway, it's not much different code size wise to call it from format_odp_key_attr or from format_odp_action. Jiri
