Re: [net,v2] ipv6: reorder ip6_route_dev_notifier after ipv6_dev_notf

2017-06-19 Thread jeffy
Hi Cong Wang, On 06/20/2017 12:54 PM, Cong Wang wrote: Hello, On Mon, Jun 19, 2017 at 8:15 PM, jeffy wrote: but actually they are not guaranteed to be paired: the netdev_run_todo(see the first dump stack above) would call netdev_wait_allrefs to rebroadcast unregister notification multiple ti

Re: [PATCH] cfg80211: Fix a memory leak in error handling path in 'brcmf_cfg80211_attach'

2017-06-19 Thread Kalle Valo
Christophe JAILLET writes: > If 'wiphy_new()' fails, we leak 'ops'. Add a new label in the error > handling path to free it in such a case. > > Fixes: 5c22fb85102a7 ("brcmfmac: add wowl gtk rekeying offload support") > Signed-off-by: Christophe JAILLET The prefix should be "brcmfmac:", like in

[PATCH] cfg80211: Fix a memory leak in error handling path in 'brcmf_cfg80211_attach'

2017-06-19 Thread Christophe JAILLET
If 'wiphy_new()' fails, we leak 'ops'. Add a new label in the error handling path to free it in such a case. Fixes: 5c22fb85102a7 ("brcmfmac: add wowl gtk rekeying offload support") Signed-off-by: Christophe JAILLET --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 3 ++- 1 file

[PATCH net-next 06/12] nfp: add stats and xmit helpers for representors

2017-06-19 Thread Simon Horman
Provide helpers for stats and xmit on representor netdevs. Parts based on work by Bert van Leeuwen, Benjamin LaHaise and Jakub Kicinski. Signed-off-by: Simon Horman Reviewed-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net_repr.c | 198 +- drivers/net/ether

[PATCH net-next 02/12] nfp: devlink add support for getting eswitch mode

2017-06-19 Thread Simon Horman
From: Jakub Kicinski Add app callback for reporting eswitch mode. Non-SRIOV apps should not implement this callback, nfp_app code will then respond with -EOPNOTSUPP. Signed-off-by: Jakub Kicinski Signed-off-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/nfp_app.h | 15 ++

[PATCH net-next 11/12] nfp: add flower app

2017-06-19 Thread Simon Horman
Add app for flower offload. At this point the PF netdev and phys port representor netdevs are initialised. Follow-up work will add support for VF and PF representors and beyond that offloading the flower classifier. Based in part on work by Benjamin LaHaise and Bert van Leeuwen. Signed-off-by: Si

[PATCH net-next 05/12] nfp: general representor implementation

2017-06-19 Thread Simon Horman
Provide infrastructure to create and destroy representors of a given type. Parts based on work by Bert van Leeuwen, Benjamin LaHaise, and Jakub Kicinski. Signed-off-by: Simon Horman Reviewed-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/Makefile | 1 + drivers/net/ethernet/

[PATCH net-next 04/12] nfp: map mac_stats and vf_cfg BARs

2017-06-19 Thread Simon Horman
If present map mac_stats and vf_cfg BARs. These will be used by representor netdevs to read statistics for phys port and vf representors. Also provide defines describing the layout of the mac_stats area. Similar defines are already present for the cf_cfg area. Based in part on work by Jakub Kicin

[PATCH net-next 12/12] nfp: add VF and PF representors to flower app

2017-06-19 Thread Simon Horman
Initialise VF and PF representors in flower app. Based in part on work by Benjamin LaHaise, Bert van Leeuwen and Jakub Kicinski. Signed-off-by: Simon Horman Reviewed-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/flower/main.c | 86 +++- 1 file changed, 84 insert

[PATCH net-next 07/12] nfp: app callbacks for SRIOV

2017-06-19 Thread Simon Horman
Add app-callbacks for app-specific initialisation of SRIOV. Disabling SRIOV is brought forward in nfp_pci_remove() so that nfp_app_sriov_disable is called while the app still exists. This is intended to be used to implement representor netdevs for virtual ports. Signed-off-by: Simon Horman Revi

[PATCH net-next 09/12] nfp: add support for tx/rx with metadata portid

2017-06-19 Thread Simon Horman
Allow tx/rx with metadata port id. This will be used for tx/rx of representor netdevs acting as upper-devices while a pf netdev acts as a lower-device. Signed-off-by: Simon Horman Reviewed-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net.h | 1 + .../net/ethernet/netrono

[PATCH net-next 08/12] nfp: provide nfp_port to of nfp_net_get_mac_addr()

2017-06-19 Thread Simon Horman
Provide port rather than vNIC as parameter of nfp_net_get_mac_addr. This is to allow this function to be used by representor netdevs where a vNIC may have more than one physical port none of which are associated with the vNIC. Signed-off-by: Simon Horman Reviewed-by: Jakub Kicinski --- drivers/

[PATCH net-next 10/12] nfp: add support for control messages for flower app

2017-06-19 Thread Simon Horman
In preparation for adding a new flower app - targeted at offloading the flower classifier - provide support for control message that it will use to communicate with the NFP. Based in part on work by Bert van Leeuwen. Signed-off-by: Simon Horman Reviewed-by: Jakub Kicinski --- drivers/net/ether

[PATCH net-next 03/12] nfp: move physical port init into a helper

2017-06-19 Thread Simon Horman
From: Jakub Kicinski Move MAC/PHY port init into a helper to make it easier to reuse it in the representor code. Signed-off-by: Jakub Kicinski Signed-off-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/nfp_app_nic.c | 23 ++ drivers/net/ethernet/netronome/nfp/nfp_p

[PATCH net-next 01/12] net: store port/representator id in metadata_dst

2017-06-19 Thread Simon Horman
From: Jakub Kicinski Switches and modern SR-IOV enabled NICs may multiplex traffic from Port representators and control messages over single set of hardware queues. Control messages and muxed traffic may need ordered delivery. Those requirements make it hard to comfortably use TC infrastructure

[PATCH net-next 00/12] nfp: add flower app with representors

2017-06-19 Thread Simon Horman
Hi, this series adds a flower app to the NFP driver. It initialises four types of netdevs: * PF netdev - lower-device for communication of packets to device * PF representor netdev * VF representor netdevs * Phys port representor netdevs The PF netdev acts as a lower-device which sends and recei

Re: [PATCH net-next 0/1] Introduction of the tc tests

2017-06-19 Thread Stephen Hemminger
On Mon, 19 Jun 2017 23:48:19 -0400 (EDT) David Miller wrote: > From: Cong Wang > Date: Mon, 19 Jun 2017 16:37:29 -0700 > > > Hi, > > > > On Fri, Jun 16, 2017 at 2:22 PM, Lucas Bates wrote: > >> Apologies for sending this as one big patch. I've been sitting on this a > >> little > >> too lo

Re: [PATCH net-next 0/1] Introduction of the tc tests

2017-06-19 Thread Stephen Hemminger
On Mon, 19 Jun 2017 23:48:19 -0400 (EDT) David Miller wrote: > From: Cong Wang > Date: Mon, 19 Jun 2017 16:37:29 -0700 > > > Hi, > > > > On Fri, Jun 16, 2017 at 2:22 PM, Lucas Bates wrote: > >> Apologies for sending this as one big patch. I've been sitting on this a > >> little > >> too lo

Re: [net,v2] ipv6: reorder ip6_route_dev_notifier after ipv6_dev_notf

2017-06-19 Thread Cong Wang
Hello, On Mon, Jun 19, 2017 at 8:15 PM, jeffy wrote: > but actually they are not guaranteed to be paired: > > the netdev_run_todo(see the first dump stack above) would call > netdev_wait_allrefs to rebroadcast unregister notification multiple times, > unless timed out or all of the "struct net_de

Re: [PATCH net-next 0/1] Introduction of the tc tests

2017-06-19 Thread Cong Wang
On Mon, Jun 19, 2017 at 8:48 PM, David Miller wrote: > From: Cong Wang > Date: Mon, 19 Jun 2017 16:37:29 -0700 > >> Hi, >> >> On Fri, Jun 16, 2017 at 2:22 PM, Lucas Bates wrote: >>> Apologies for sending this as one big patch. I've been sitting on this a >>> little >>> too long, but it's ready

Re: [PATCH 0/9] Bug fixes and ctr mode of operation

2017-06-19 Thread Herbert Xu
On Thu, Jun 15, 2017 at 12:43:38PM +0530, Harsh Jain wrote: > This series is based on cryptodev2.6 tree and includes bug fix ,ctr(aes), > rfc3686(ctr(aes)) algo. > > Harsh Jain (7): > crypto: chcr - Pass lcb bit setting to firmware > crypto: chcr - Set fallback key > crypto: chcr - Return c

Re: [PATCH net-next 0/1] Introduction of the tc tests

2017-06-19 Thread David Miller
From: Cong Wang Date: Mon, 19 Jun 2017 16:37:29 -0700 > Hi, > > On Fri, Jun 16, 2017 at 2:22 PM, Lucas Bates wrote: >> Apologies for sending this as one big patch. I've been sitting on this a >> little >> too long, but it's ready and I wanted to get it out. >> >> There are a limited number of

Re: [PATCH NET] net/hns:bugfix of ethtool -t phy self_test

2017-06-19 Thread l00371289
Hi, Andrew On 2017/6/20 5:54, Andrew Lunn wrote: > On Mon, Jun 19, 2017 at 02:00:43PM -0700, Florian Fainelli wrote: >> On 06/16/2017 02:24 AM, Lin Yun Sheng wrote: >>> This patch fixes the phy loopback self_test failed issue. when >>> Marvell Phy Module is loaded, it will powerdown fiber when doi

Re: [net,v2] ipv6: reorder ip6_route_dev_notifier after ipv6_dev_notf

2017-06-19 Thread jeffy
Hi guys, i hit some warnings when testing this patch on my local 4.4 kernel(arm64 chromebook) with KASAN & SLUB_DEBUG: [9.919374] BUG: KASAN: use-after-free in ip6_route_dev_notify+0x194/0x2bc at addr ffc0c9d4e480 [9.928469] Read of size 4 by task kworker/u12:3/124 [9.933463]

Re: [PATCH NET] net/hns:bugfix of ethtool -t phy self_test

2017-06-19 Thread l00371289
hi, Florian On 2017/6/20 5:00, Florian Fainelli wrote: > On 06/16/2017 02:24 AM, Lin Yun Sheng wrote: >> This patch fixes the phy loopback self_test failed issue. when >> Marvell Phy Module is loaded, it will powerdown fiber when doing >> phy loopback self test, which cause phy loopback self_test

[PATCH net-next v3 07/15] bpf: Add setsockopt helper function to bpf

2017-06-19 Thread Lawrence Brakmo
Added support for calling a subset of socket setsockopts from BPF_PROG_TYPE_SOCK_OPS programs. The code was duplicated rather than making the changes to call the socket setsockopt function because the changes required would have been larger. The ops supported are: SO_RCVBUF SO_SNDBUF SO_MAX_

[PATCH net-next v3 11/15] bpf: Sample BPF program to set congestion control

2017-06-19 Thread Lawrence Brakmo
Sample BPF program that sets congestion control to dctcp when both hosts are within the same datacenter. In this example that is assumed to be when they have the first 5.5 bytes of their IPv6 address are the same. Signed-off-by: Lawrence Brakmo --- samples/bpf/Makefile| 1 + samples/bpf

[PATCH net-next v3 15/15] bpf: Sample bpf program to set sndcwnd clamp

2017-06-19 Thread Lawrence Brakmo
Sample BPF program, tcp_clamp_kern.c, to demostrate the use of setting the sndcwnd clamp. This program assumes that if the first 5.5 bytes of the host's IPv6 addresses are the same, then the hosts are in the same datacenter and sets sndcwnd clamp to 100 packets, SYN and SYN-ACK RTOs to 10ms and sen

[PATCH net-next v3 10/15] bpf: Add support for changing congestion control

2017-06-19 Thread Lawrence Brakmo
Added support for changing congestion control for SOCK_OPS bpf programs through the setsockopt bpf helper function. It also adds a new SOCK_OPS op, BPF_SOCK_OPS_NEEDS_ECN, that is needed for congestion controls, like dctcp, that need to enable ECN in the SYN packets. Signed-off-by: Lawrence Brakmo

[PATCH net-next v3 13/15] bpf: Sample BPF program to set initial cwnd

2017-06-19 Thread Lawrence Brakmo
Sample BPF program that assumes hosts are far away (i.e. large RTTs) and sets initial cwnd and initial receive window to 40 packets, send and receive buffers to 1.5MB. In practice there would be a test to insure the hosts are actually far enough away. Signed-off-by: Lawrence Brakmo --- samples/

[PATCH net-next v3 14/15] bpf: Adds support for setting sndcwnd clamp

2017-06-19 Thread Lawrence Brakmo
Adds a new bpf_setsockopt for TCP sockets, TCP_BPF_SNDCWND_CLAMP, which sets the initial congestion window. It is useful to limit the sndcwnd when the host are close to each other (small RTT). Signed-off-by: Lawrence Brakmo --- include/uapi/linux/bpf.h | 1 + net/core/filter.c| 7 +++

[PATCH net-next v3 01/15] bpf: BPF support for sock_ops

2017-06-19 Thread Lawrence Brakmo
Created a new BPF program type, BPF_PROG_TYPE_SOCK_OPS, and a corresponding struct that allows BPF programs of this type to access some of the socket's fields (such as IP addresses, ports, etc.). Currently there is functionality to load one global BPF program of this type which can be called at app

[PATCH net-next v3 03/15] bpf: Support for per connection SYN/SYN-ACK RTOs

2017-06-19 Thread Lawrence Brakmo
This patch adds support for setting a per connection SYN and SYN_ACK RTOs from within a BPF_SOCK_OPS program. For example, to set small RTOs when it is known both hosts are within a datacenter. Signed-off-by: Lawrence Brakmo --- include/net/tcp.h| 11 +++ include/uapi/linux/bpf.h

[PATCH net-next v3 05/15] bpf: Support for setting initial receive window

2017-06-19 Thread Lawrence Brakmo
This patch adds suppport for setting the initial advertized window from within a BPF_SOCK_OPS program. This can be used to support larger initial cwnd values in environments where it is known to be safe. Signed-off-by: Lawrence Brakmo --- include/net/tcp.h| 10 ++ include/uapi/li

PATCH net-next v3 00/15

2017-06-19 Thread Lawrence Brakmo
Created a new BPF program type, BPF_PROG_TYPE_SOCK_OPS, and a corresponding struct that allows BPF programs of this type to access some of the socket's fields (such as IP addresses, ports, etc.) and setting connection parameters such as buffer sizes, initial window, SYN/SYN-ACK RTOs, etc. Unlike c

[PATCH net-next v3 06/15] bpf: Sample bpf program to set initial window

2017-06-19 Thread Lawrence Brakmo
The sample bpf program, tcp_rwnd_kern.c, sets the initial advertized window to 40 packets in an environment where distinct IPv6 prefixes indicate that both hosts are not in the same data center. Signed-off-by: Lawrence Brakmo --- samples/bpf/Makefile| 1 + samples/bpf/tcp_rwnd_kern.c |

[PATCH net-next v3 08/15] bpf: Add TCP connection BPF callbacks

2017-06-19 Thread Lawrence Brakmo
Added callbacks to BPF SOCK_OPS type program before an active connection is intialized and after a passive or active connection is established. The following patch demostrates how they can be used to set send and receive buffer sizes. Signed-off-by: Lawrence Brakmo --- include/uapi/linux/bpf.h

[PATCH net-next v3 12/15] bpf: Adds support for setting initial cwnd

2017-06-19 Thread Lawrence Brakmo
Adds a new bpf_setsockopt for TCP sockets, TCP_BPF_IW, which sets the initial congestion window. This can be used when the hosts are far apart (large RTTs) and it is safe to start with a large inital cwnd. Signed-off-by: Lawrence Brakmo --- include/uapi/linux/bpf.h | 2 ++ net/core/filter.c

[PATCH net-next v3 09/15] bpf: Sample BPF program to set buffer sizes

2017-06-19 Thread Lawrence Brakmo
This patch contains a BPF program to set initial receive window to 40 packets and send and receive buffers to 1.5MB. This would usually be done after doing appropriate checks that indicate the hosts are far enough away (i.e. large RTT). Signed-off-by: Lawrence Brakmo --- samples/bpf/Makefile

[PATCH net-next v3 02/15] bpf: program to load sock_ops BPF programs

2017-06-19 Thread Lawrence Brakmo
The program tcp_bpf can be used to remove current global sock_ops program and to load/replace sock_ops BPF programs. There is also an option to print the bpf trace buffer (for debugging purposes). USAGE: ./tcp_bpf [-r] [-l] [] WHERE: -r remove current loaded sock_ops BPF program

[PATCH net-next v3 04/15] bpf: Sample bpf program to set SYN/SYN-ACK RTOs

2017-06-19 Thread Lawrence Brakmo
The sample BPF program, tcp_synrto_kern.c, sets the SYN and SYN-ACK RTOs to 10ms when both hosts are within the same datacenter (i.e. small RTTs) in an environment where common IPv6 prefixes indicate both hosts are in the same data center. Signed-off-by: Lawrence Brakmo --- samples/bpf/Makefile

Re: [PATCH v2] arm: eBPF JIT compiler

2017-06-19 Thread Shubham Bansal
Hi Daniel, > > Sorry, had a travel over the weekend, so didn't read it in time. > > What is the issue with imitating in JIT what the interpreter is > doing as a starting point? That should be generic enough to handle > any case. > > Otherwise you'd need some sort of reverse mapping since verifier

Re: [RFC PATCH net-next v2 10/15] bpf: Add support for changing congestion control

2017-06-19 Thread Lawrence Brakmo
On 6/19/17, 3:34 PM, "Daniel Borkmann" wrote: On 06/18/2017 04:39 AM, Lawrence Brakmo wrote: > On 6/16/17, 6:58 AM, "Daniel Borkmann" wrote: [...] > > /* Change congestion control for socket */ > > -int tcp_set_congestion_control(struct sock *sk, const char *name

Re: [RFC net-next 6/8] nfp: bpf: add support for XDP_FLAGS_HW_MODE

2017-06-19 Thread Daniel Borkmann
On 06/20/2017 02:01 AM, Jakub Kicinski wrote: On Tue, 20 Jun 2017 01:50:17 +0200, Daniel Borkmann wrote: On 06/17/2017 01:57 AM, Jakub Kicinski wrote: Respect the XDP_FLAGS_HW_MODE. When it's set install the program on the NIC and skip enabling XDP in the driver. Signed-off-by: Jakub Kicinski

Re: [RFC net-next 6/8] nfp: bpf: add support for XDP_FLAGS_HW_MODE

2017-06-19 Thread Jakub Kicinski
On Tue, 20 Jun 2017 01:50:17 +0200, Daniel Borkmann wrote: > On 06/17/2017 01:57 AM, Jakub Kicinski wrote: > > Respect the XDP_FLAGS_HW_MODE. When it's set install the program > > on the NIC and skip enabling XDP in the driver. > > > > Signed-off-by: Jakub Kicinski > > --- > > drivers/net/ether

Re: [RFC net-next 6/8] nfp: bpf: add support for XDP_FLAGS_HW_MODE

2017-06-19 Thread Daniel Borkmann
On 06/17/2017 01:57 AM, Jakub Kicinski wrote: Respect the XDP_FLAGS_HW_MODE. When it's set install the program on the NIC and skip enabling XDP in the driver. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 10 +++--- 1 file changed, 7 insertions(

Re: [RFC net-next 7/8] xdp: add reporting of offload mode

2017-06-19 Thread Daniel Borkmann
On 06/17/2017 01:57 AM, Jakub Kicinski wrote: Extend the XDP_ATTACHED_* values to include offloaded mode. Let drivers report whether program is installed in the driver or the HW by changing the prog_attached field from bool to u8 (type of the netlink attribute). Exploit the fact that the value o

Re: [RFC net-next 2/8] xdp: add HW offload mode flag for installing programs

2017-06-19 Thread Daniel Borkmann
On 06/17/2017 01:57 AM, Jakub Kicinski wrote: Add an installation-time flag for requesting that the program be installed only if it can be offloaded to HW. Internally new command for ndo_xdp is added, this way we avoid putting checks into drivers since they all return -EINVAL on an unknown comma

Re: [RFC net-next 1/8] xdp: pass XDP flags into install handlers

2017-06-19 Thread Daniel Borkmann
On 06/17/2017 01:57 AM, Jakub Kicinski wrote: Pass XDP flags to the xdp ndo. This will allow drivers to look at the mode flags and make decisions about offload. Signed-off-by: Jakub Kicinski Acked-by: Daniel Borkmann

Re: [PATCH net-next 0/1] Introduction of the tc tests

2017-06-19 Thread Cong Wang
Hi, On Fri, Jun 16, 2017 at 2:22 PM, Lucas Bates wrote: > Apologies for sending this as one big patch. I've been sitting on this a > little > too long, but it's ready and I wanted to get it out. > > There are a limited number of tests to start - I plan to add more on a regular > basis. > > Lucas

Re: [RFC net-next 2/8] xdp: add HW offload mode flag for installing programs

2017-06-19 Thread Daniel Borkmann
On 06/20/2017 01:24 AM, Jakub Kicinski wrote: [...] The XDP_SETUP_PROG_HW command is purely for convenience of drivers without an offload. I felt it's not appropriate to burden all drivers with: if (xdp->flags & XDP_FLAGS_HW_MODE) return -EOPNOTSUPP; But, I do have a patch which does i

Re: [RFC net-next 5/8] nfp: bpf: take a reference on offloaded programs

2017-06-19 Thread Jakub Kicinski
On Tue, 20 Jun 2017 01:23:05 +0200, Daniel Borkmann wrote: > On 06/17/2017 01:57 AM, Jakub Kicinski wrote: > > The xdp_prog member of the adapter's data path structure is used > > for XDP in driver mode. In case a XDP program is loaded with in > > HW-only mode, we need to store it somewhere else.

[PATCH net-next v2] enic: Fix format truncation warning

2017-06-19 Thread Govindarajulu Varadarajan
With -Wformat-truncation, gcc throws the following warning. Fix this by increasing the size of devname to accommodate 15 character netdev interface name and description. Remove length format precision for %s. We can fit entire name. Also increment the version. drivers/net/ethernet/cisco/enic/en

Re: [RFC net-next 2/8] xdp: add HW offload mode flag for installing programs

2017-06-19 Thread Jakub Kicinski
On Tue, 20 Jun 2017 00:55:41 +0200, Daniel Borkmann wrote: > On 06/17/2017 01:57 AM, Jakub Kicinski wrote: > > Add an installation-time flag for requesting that the program > > be installed only if it can be offloaded to HW. > > > > Internally new command for ndo_xdp is added, this way we avoid > >

Re: [RFC net-next 5/8] nfp: bpf: take a reference on offloaded programs

2017-06-19 Thread Daniel Borkmann
On 06/17/2017 01:57 AM, Jakub Kicinski wrote: The xdp_prog member of the adapter's data path structure is used for XDP in driver mode. In case a XDP program is loaded with in HW-only mode, we need to store it somewhere else. Add a new XDP prog pointer in the main structure and use that when we

Re: [RFC net-next 2/8] xdp: add HW offload mode flag for installing programs

2017-06-19 Thread Daniel Borkmann
On 06/17/2017 01:57 AM, Jakub Kicinski wrote: Add an installation-time flag for requesting that the program be installed only if it can be offloaded to HW. Internally new command for ndo_xdp is added, this way we avoid putting checks into drivers since they all return -EINVAL on an unknown comma

Re: [RFC PATCH net-next v2 10/15] bpf: Add support for changing congestion control

2017-06-19 Thread Daniel Borkmann
On 06/18/2017 04:39 AM, Lawrence Brakmo wrote: On 6/16/17, 6:58 AM, "Daniel Borkmann" wrote: [...] > /* Change congestion control for socket */ > -int tcp_set_congestion_control(struct sock *sk, const char *name) > +int tcp_set_congestion_control(struct sock *sk, const char *n

Re: [PATCH NET] net/hns:bugfix of ethtool -t phy self_test

2017-06-19 Thread Andrew Lunn
On Mon, Jun 19, 2017 at 02:00:43PM -0700, Florian Fainelli wrote: > On 06/16/2017 02:24 AM, Lin Yun Sheng wrote: > > This patch fixes the phy loopback self_test failed issue. when > > Marvell Phy Module is loaded, it will powerdown fiber when doing > > phy loopback self test, which cause phy loopba

Re: Reply Urgent

2017-06-19 Thread INFO
Hello, How are you doing? I have been sent to inform you that, We have an inheritance of a deceased client with your surname. Contact Mr Andrew Bailey Reply Email To: myinf...@gmail.com with your "Full Names" for more info. Thanks for your understanding. Reply ASAP thank you. Melissa. -

Re: [PATCH NET] net/hns:bugfix of ethtool -t phy self_test

2017-06-19 Thread Florian Fainelli
On 06/16/2017 02:24 AM, Lin Yun Sheng wrote: > This patch fixes the phy loopback self_test failed issue. when > Marvell Phy Module is loaded, it will powerdown fiber when doing > phy loopback self test, which cause phy loopback self_test fail. > > Signed-off-by: Lin Yun Sheng > --- > drivers/net

Re: [RFC PATCH net-next v2 01/15] bpf: BPF support for socket ops

2017-06-19 Thread Lawrence Brakmo
On 6/19/17, 11:44 AM, "Daniel Borkmann" wrote: On 06/17/2017 01:41 AM, Lawrence Brakmo wrote: > On 6/16/17, 5:07 AM, "Daniel Borkmann" wrote: [...] > I see. You are saying have one struct in common but still keep the two > PROG_TYPES? That makes sense. Do we really need two

Re: [RFC PATCH net-next v2 01/15] bpf: BPF support for socket ops

2017-06-19 Thread Lawrence Brakmo
On 6/19/17, 11:52 AM, "Daniel Borkmann" wrote: On 06/17/2017 11:48 PM, Lawrence Brakmo wrote: > On 6/16/17, 5:07 AM, "Daniel Borkmann" wrote: > > On 06/15/2017 10:08 PM, Lawrence Brakmo wrote: > > Two new corresponding structs (one for the kernel one for the user/

[PATCH net-next v2 1/4] rtnetlink: add NEWCACHEREPORT message type

2017-06-19 Thread Julien Gomes
New NEWCACHEREPORT message type to be used for cache reports sent via Netlink, effectively allowing splitting cache report reception from mroute programming. Suggested-by: Ryan Halbrook Signed-off-by: Julien Gomes --- include/uapi/linux/rtnetlink.h | 3 +++ security/selinux/nlmsgtab.c| 3 ++

[PATCH net-next v2 0/4] ipmr/ip6mr: add Netlink notifications on cache reports

2017-06-19 Thread Julien Gomes
Currently, all ipmr/ip6mr cache reports are sent through the mroute/mroute6 socket only. This forces the use of a single socket for mroute programming, cache reports and, regarding ipmr, IGMP messages without Router Alert option reception. The present patches are aiming to send Netlink notificatio

[PATCH net-next v2 3/4] ipmr: add netlink notifications on igmpmsg cache reports

2017-06-19 Thread Julien Gomes
Add Netlink notifications on cache reports in ipmr, in addition to the existing igmpmsg sent to mroute_sk. Send RTM_NEWCACHEREPORT notifications to RTNLGRP_IPV4_MROUTE_R. MSGTYPE, VIF_ID, SRC_ADDR and DST_ADDR Netlink attributes contain the same data as their equivalent fields in the igmpmsg heade

[PATCH net-next v2 2/4] rtnetlink: add restricted rtnl groups for ipv4 and ipv6 mroute

2017-06-19 Thread Julien Gomes
Add RTNLGRP_{IPV4,IPV6}_MROUTE_R as two new restricted groups for the NETLINK_ROUTE family. Binding to these groups specifically requires CAP_NET_ADMIN to allow multicast of sensitive messages (e.g. mroute cache reports). Signed-off-by: Julien Gomes --- include/uapi/linux/rtnetlink.h | 4

[PATCH net-next v2 4/4] ip6mr: add netlink notifications on mrt6msg cache reports

2017-06-19 Thread Julien Gomes
Add Netlink notifications on cache reports in ip6mr, in addition to the existing mrt6msg sent to mroute6_sk. Send RTM_NEWCACHEREPORT notifications to RTNLGRP_IPV6_MROUTE_R. MSGTYPE, MIF_ID, SRC_ADDR and DST_ADDR Netlink attributes contain the same data as their equivalent fields in the mrt6msg hea

[PATCH 0/5] rtlwifi: Neatening

2017-06-19 Thread Joe Perches
Joe Perches (5): rtlwifi: Use temporary ops variable to reduce code size rtlwifi: Use temporary variable btc_ops for rtlpriv->btcoexist.btc_ops rtlwifi: Add and use convenience macro rtl_btc realtek: btcoexist: Make the rtl_btc_ops struct const realtek: rtlwifi: drivers: Use the rtl_btc c

[PATCH 3/5] rtlwifi: Add and use convenience macro rtl_btc

2017-06-19 Thread Joe Perches
bluetooth coexistence functions always check get_btc_status before accessing the function. Centralize this via a convenience macro to neaten the source code a little. Signed-off-by: Joe Perches --- drivers/net/wireless/realtek/rtlwifi/base.c | 8 ++-- drivers/net/wireless/realtek/rtlwifi/c

[PATCH 2/5] rtlwifi: Use temporary variable btc_ops for rtlpriv->btcoexist.btc_ops

2017-06-19 Thread Joe Perches
Reduce the code line length a little. Signed-off-by: Joe Perches --- drivers/net/wireless/realtek/rtlwifi/base.c | 7 --- drivers/net/wireless/realtek/rtlwifi/core.c | 10 ++ drivers/net/wireless/realtek/rtlwifi/pci.c | 8 +--- drivers/net/wireless/realtek/rtlwifi/ps.c | 16

[PATCH 1/5] rtlwifi: Use temporary ops variable to reduce code size

2017-06-19 Thread Joe Perches
rtlpriv->cfg->ops-> is used frequently in the source. Repeated use of this multiply dereferenced table creates larger objects. Using a temporary reduces code size as well as source code line length. $ size -t drivers/net/wireless/realtek/rtlwifi/*.o.defconfig.new textdata bss dec

[PATCH 4/5] realtek: btcoexist: Make the rtl_btc_ops struct const

2017-06-19 Thread Joe Perches
Avoid allowing a write into what should be const. Signed-off-by: Joe Perches --- drivers/net/wireless/realtek/rtlwifi/btcoexist/rtl_btc.c | 4 ++-- drivers/net/wireless/realtek/rtlwifi/btcoexist/rtl_btc.h | 2 +- drivers/net/wireless/realtek/rtlwifi/pci.c | 2 +- drivers/net/wirele

[PATCH 5/5] realtek: rtlwifi: drivers: Use the rtl_btc convenience macro

2017-06-19 Thread Joe Perches
Convert the uses of the btcoexist. to the rtl_btc macro to save a few lines of code. Signed-off-by: Joe Perches --- drivers/net/wireless/realtek/rtlwifi/rtl8192ee/hw.c | 3 +-- drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hal_btc.c | 4 +--- drivers/net/wireless/realtek/rtlwifi/rtl8723ae/

[PATCH iproute2 1/1] tc: fixed typo in usage text.

2017-06-19 Thread Roman Mashak
Signed-off-by: Roman Mashak --- tc/f_u32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tc/f_u32.c b/tc/f_u32.c index ff700e9..b272c2c 100644 --- a/tc/f_u32.c +++ b/tc/f_u32.c @@ -34,7 +34,7 @@ static void explain(void) "Usage: ... u32 [ match SELECTOR ... ]

[PATCH] liquidio: stop using huge static buffer, save 4096k in .data

2017-06-19 Thread Denys Vlasenko
Only compile-tested - I don't have the hardware. >From code inspection, octeon_pci_write_core_mem() appears to be safe wrt unaligned source. In any case, u8 fbuf[] was not guaranteed to be aligned anyway. Signed-off-by: Denys Vlasenko CC: Felix Manlunas CC: Prasad Kanneganti CC: Derek Chickles

Re: [PATCH net] sctp: ensure ep is not destroyed before doing the dump

2017-06-19 Thread David Miller
From: Xin Long Date: Sat, 17 Jun 2017 16:10:27 +0800 > Now before dumping a sock in sctp_diag, it only holds the sock while > the ep may be already destroyed. It can cause a use-after-free panic > when accessing ep->asocs. > > This patch is to set sctp_sk(sk)->ep NULL in sctp_endpoint_destroy, >

Re: [RFC PATCH net-next v2 01/15] bpf: BPF support for socket ops

2017-06-19 Thread Daniel Borkmann
On 06/17/2017 11:48 PM, Lawrence Brakmo wrote: On 6/16/17, 5:07 AM, "Daniel Borkmann" wrote: On 06/15/2017 10:08 PM, Lawrence Brakmo wrote: > Two new corresponding structs (one for the kernel one for the user/BPF > program): > > /* kernel version */ > struct bpf_so

Re: rtnetlink: add IFLA_GROUP to ifla_policy

2017-06-19 Thread David Miller
From: David Miller Date: Mon, 19 Jun 2017 14:47:44 -0400 (EDT) > From: Serhey Popovych > Date: Fri, 16 Jun 2017 15:22:24 +0300 > >> Network interface groups support added while ago, however >> there is no IFLA_GROUP attribute description in policy >> and netlink message size calculations until

Re: rtnetlink: add IFLA_GROUP to ifla_policy

2017-06-19 Thread David Miller
From: Serhey Popovych Date: Fri, 16 Jun 2017 15:22:24 +0300 > Network interface groups support added while ago, however > there is no IFLA_GROUP attribute description in policy > and netlink message size calculations until now. > > Add IFLA_GROUP attribute to the policy. > > Fixes: cbda10fa97d7

Re: [RFC PATCH net-next v2 01/15] bpf: BPF support for socket ops

2017-06-19 Thread Daniel Borkmann
On 06/17/2017 01:41 AM, Lawrence Brakmo wrote: On 6/16/17, 5:07 AM, "Daniel Borkmann" wrote: [...] I see. You are saying have one struct in common but still keep the two PROG_TYPES? That makes sense. Do we really need two different is_valid_access functions? Both types should be able to see al

Re: [PATCH] loopback: Force LOOPBACK_IFINDEX for registration

2017-06-19 Thread David Miller
From: Serhey Popovych Date: Fri, 16 Jun 2017 15:10:03 +0300 > Now with commit 9c7dafb (net: Allow to create links with > given ifindex) support registration of network devices > with specific ifindex is added. > > We can force loopback network device index before call to > register_netdev() to e

Re: [PATCH v3 0/4] PTP support for macb driver

2017-06-19 Thread David Miller
From: Rafal Ozieblo Date: Fri, 16 Jun 2017 12:58:18 +0100 > This patch series adds support for PTP synchronization protocol > in Cadence GEM driver based on PHC. This doesn't apply cleanly to net-next, please respin.

Re: ipv6: Do not leak throw route references

2017-06-19 Thread David Miller
From: Serhey Popovych Date: Fri, 16 Jun 2017 14:42:17 +0300 > While commit 73ba57b (ipv6: fix backtracking for throw routes) > does good job on error propagation to the fib_rules_lookup() > in fib rules core framework that also corrects throw routes > handling, it does not solve route reference l

Re: [PATCH NET] net/hns:bugfix of ethtool -t phy self_test

2017-06-19 Thread David Miller
From: Lin Yun Sheng Date: Fri, 16 Jun 2017 17:24:51 +0800 > This patch fixes the phy loopback self_test failed issue. when > Marvell Phy Module is loaded, it will powerdown fiber when doing > phy loopback self test, which cause phy loopback self_test fail. > > Signed-off-by: Lin Yun Sheng Appl

Re: [PATCH v2] arm: eBPF JIT compiler

2017-06-19 Thread Daniel Borkmann
On 06/17/2017 02:23 PM, Shubham Bansal wrote: Hi Daniel, Not all of the helpers have 4 or less byte arguments only, there are a few with 8 byte arguments, so making that general assumption wouldn't work. I guess what could be done is that helpers have a flag in struct bpf_func_proto which indic

Re: [PATCH net] net: 8021q: Fix one possible panic caused by BUG_ON in free_netdev

2017-06-19 Thread David Miller
From: gfree.w...@vip.163.com Date: Fri, 16 Jun 2017 15:00:02 +0800 > From: Gao Feng > > The register_vlan_device would invoke free_netdev directly, when > register_vlan_dev failed. It would trigger the BUG_ON in free_netdev > if the dev was already registered. In this case, the netdev would be >

Re: [PATCH v2 1/2] ip_tunnel: fix ip tunnel lookup in collect_md mode

2017-06-19 Thread Pravin Shelar
On Mon, Jun 19, 2017 at 6:13 AM, 严海双 wrote: > > >> On 19 Jun 2017, at 1:43 PM, Pravin Shelar wrote: >> >> On Fri, Jun 16, 2017 at 8:27 PM, Haishuang Yan >> wrote: >>> In collect_md mode, if the tun dev is down, it still can call >>> ip_tunnel_rcv to receive on packets, and the rx statistics incr

Re: [PATCH v3 2/2] tcp: md5: add TCP_MD5SIG_EXT socket option to set a key address prefix

2017-06-19 Thread David Miller
From: Ivan Delalande Date: Thu, 15 Jun 2017 18:07:07 -0700 > Replace first padding in the tcp_md5sig structure with a new flag field > and address prefix length so it can be specified when configuring a new > key for TCP MD5 signature. The tcpm_flags field will only be used if the > socket option

Re: [PATCH v3 1/2] tcp: md5: add an address prefix for key lookup

2017-06-19 Thread David Miller
From: Ivan Delalande Date: Thu, 15 Jun 2017 18:07:06 -0700 > This allows the keys used for TCP MD5 signature to be used for whole > range of addresses, specified with a prefix length, instead of only one > address as it currently is. > > Signed-off-by: Bob Gilligan > Signed-off-by: Eric Mowat

Re: [PATCH net-next 3/4] s390/diag: add diag26c support

2017-06-19 Thread David Miller
From: Martin Schwidefsky Date: Mon, 19 Jun 2017 17:34:25 +0200 > We (as in the s390 guys) tend to add __packed to hardware and hypervisor > structures even if the attribute is not strictly necessary. Most of the > diagnose related structures look that way. Dunno if it is worth to change > them.

Re: [Bug 196093] New: dot1q S-VLAN frame on dot1ad configured interface is accepted

2017-06-19 Thread Jason Lixfeld
Confirmed. Works with 1.8.1-3 on Debian via unstable. > On Jun 18, 2017, at 10:35 PM, Toshiaki Makita > wrote: > > Hi, > > On 2017/06/17 0:40, Stephen Hemminger wrote: >> I suspect that VLAN offload on this Intel NIC is allowing any of the VLAN >> types. >> >> Begin forwarded message: >> >

Re: [PATCH nf-next] netns: add and use net_ns_barrier

2017-06-19 Thread Pablo Neira Ayuso
On Tue, May 30, 2017 at 11:38:12AM +0200, Florian Westphal wrote: > Quoting Joe Stringer: > If a user loads nf_conntrack_ftp, sends FTP traffic through a network > namespace, destroys that namespace then unloads the FTP helper module, > then the kernel will crash. > > Events that lead to the

Re: [PATCH net] netfilter: do not hold dev in ipt_CLUSTERIP

2017-06-19 Thread Pablo Neira Ayuso
On Sat, May 20, 2017 at 05:08:06PM +0800, Xin Long wrote: > It's a terrible thing to hold dev in iptables target. When the dev is > being removed, unregister_netdevice has to wait for the dev to become > free. dmesg will keep logging the err: > > kernel:unregister_netdevice: waiting for veth0_in

Re: [PATCH net-next] net/mlx4_en: don't set CHECKSUM_COMPLETE on SCTP packets

2017-06-19 Thread Davide Caratti
hello Tariq, On Sun, 2017-06-18 at 14:10 +0300, Tariq Toukan wrote: > > @@ -624,12 +632,13 @@ static int check_csum(struct mlx4_cqe *cqe, struct > > sk_buff *skb, void *va, > >    hdr += sizeof(struct vlan_hdr); > >    } > >    > > - if (cqe->status & cpu_to_be16(MLX4_CQE_STAT

Re: [PATCH V3 net-next 2/8] net: hns3: Add support of the HNAE3 framework

2017-06-19 Thread Stephen Hemminger
On Sat, 17 Jun 2017 18:24:25 +0100 Salil Mehta wrote: > + > +/* This struct defines the operation on the handle. > + * > + * init_ae_dev(): (mandatory) > + * Get PF configure from pci_dev and initialize PF hardware > + * uninit_ae_dev() > + * Disable PF device and release PF resource > + * re

Re: [PATCH v1 1/2] dt-binding: ptp: add bindings document for dte based ptp clock

2017-06-19 Thread Arun Parameswaran
Hi David, Rob, I will address all of Rob's comments below. Since a part of the patch was applied to 'net-next', would you like me to send a new patch (based on the applied one), or a 'V2' of this patch ? Thanks Arun On 17-06-18 07:04 AM, Rob Herring wrote: > On Mon, Jun 12, 2017 at 01:26:00PM -0

[PATCH net-next] net: stmmac: enable TSO for IPv6

2017-06-19 Thread Niklas Cassel
There is nothing in the IP that prevents us from enabling TSO for IPv6. Before patch: ftp fe80::2aa:bbff:fecc:1336%eth0 ftp> get /dev/zero 882512708 bytes received in 00:14 (56.11 MiB/s) After patch: ftp fe80::2aa:bbff:fecc:1336%eth0 ftp> get /dev/zero 1203326784 bytes received in 00:12 (94.52 Mi

[PATCH net-next] ibmvnic: Return from ibmvnic_resume if not in VNIC_OPEN state

2017-06-19 Thread John Allen
If the ibmvnic driver is not in the VNIC_OPEN state, return from ibmvnic_resume callback. If we are not in the VNIC_OPEN state, interrupts may not be initialized and directly calling the interrupt handler will cause a crash. Signed-off-by: John Allen --- diff --git a/drivers/net/ethernet/ibm/ibmv

[PATCH] dt-bindings: net: sms911x: Add missing optional VDD regulators

2017-06-19 Thread Krzysztof Kozlowski
The lan911x family of devices require supplying from 3.3 V power supplies (connected to VDD_IO, VDD_A and VREG_3.3 pins). The existing driver however obtains only VDD_IO and VDD_A regulators in an optional way so document this in bindings. Signed-off-by: Krzysztof Kozlowski --- Documentation/de

Re: [PATCH V2 net-next 1/8] net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC

2017-06-19 Thread Stephen Hemminger
On Wed, 14 Jun 2017 00:10:28 +0100 Salil Mehta wrote: > +hns3_nic_get_stats64(struct net_device *ndev, struct rtnl_link_stats64 > *stats) > +{ > + struct hns3_nic_priv *priv = netdev_priv(ndev); > + int queue_num = priv->ae_handle->kinfo.num_tqps; > + u64 tx_bytes = 0; > + u64 rx

  1   2   >