Re: [oss-drivers] [PATCH net-next 9/9] nfp: eliminate an if statement in calculation of completed frames

2017-05-15 Thread Simon Horman
On Mon, May 15, 2017 at 05:55:23PM -0700, Jakub Kicinski wrote: > Given that our rings are always a power of 2, we can simplify the > calculation of number of completed TX descriptors by using masking > instead of if statement based on whether the index have wrapped > or not. > > Signed-off-by: Ja

Re: [oss-drivers] [PATCH net-next 3/9] nfp: support LSO2 capability

2017-05-15 Thread Simon Horman
On Mon, May 15, 2017 at 05:55:17PM -0700, Jakub Kicinski wrote: > From: Edwin Peer > > Firmware advertising the LSO2 capability exploits driver provided L3 and L4 > offsets in order to avoid parsing packet headers in the TX path. The vlan > field in struct nfp_net_tx_desc is repurposed, making TX

[PATCH net v1] net/smc: Add warning about remote memory exposure

2017-05-15 Thread Leon Romanovsky
From: Christoph Hellwig The driver explicitly bypasses APIs to register all memory once a connection is made, and thus allows remote access to memory. Signed-off-by: Christoph Hellwig Signed-off-by: Leon Romanovsky --- Dave, Can you please forward this patch to stable? Thanks --- Changes from

[PATCH] net: Improve handling of failures on link and route dumps

2017-05-15 Thread David Ahern
In general, rtnetlink dumps do not anticipate failure to dump a single object (e.g., link or route) on a single pass. As both route and link objects have grown via more attributes, that is no longer a given. netlink dumps can handle a failure if the dump function returns an error; specifically, ne

Re: [PATCH net-next] tcp: internal implementation for pacing

2017-05-15 Thread kbuild test robot
Hi Eric, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Eric-Dumazet/tcp-internal-implementation-for-pacing/20170516-115441 reproduce: make htmldocs All warnings (new ones prefixed by >>): include/net/sock.h:476: warning: No description found f

Re: [PATCH] ipmr: vrf: Find VIFs using the actual device

2017-05-15 Thread David Ahern
On 5/15/17 3:14 PM, Thomas Winter wrote: > The skb->dev that is passed into ip_mr_input is > the loX device for VRFs. When we lookup a vif > for this dev, none is found as we do not create > vifs for loopbacks. Instead lookup a vif for the > actual device that the packet was received on, > eg the v

Re: [patch net-next v2 10/10] net: sched: add termination action to allow goto chain

2017-05-15 Thread Jiri Pirko
Mon, May 15, 2017 at 10:02:08PM CEST, dan...@iogearbox.net wrote: >On 05/15/2017 10:38 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Introduce new type of termination action called "goto_chain". This allows >> user to specify a chain to be processed. This action type is >> then processed as a r

[PATCH net v2] net: x25: fix one potential use-after-free issue

2017-05-15 Thread linzhang
The function x25_init is not properly unregister related resources on error handler.It is will result in kernel oops if x25_init init failed, so add properly unregister call on error handler. Also, i adjust the coding style and make x25_register_sysctl properly return failure. Signed-off-by: linz

Re: [PATCH v4 1/4] can: m_can: move Message RAM initialization to function

2017-05-15 Thread Oliver Hartkopp
On 05/15/2017 06:50 AM, Marc Kleine-Budde wrote: On 05/12/2017 08:37 AM, Quentin Schulz wrote: Hi all, On 05/05/2017 15:50, Quentin Schulz wrote: To avoid possible ECC/parity checksum errors when reading an uninitialized buffer, the entire Message RAM is initialized when probing the driver.

Re: [PATCH net-next] tcp: internal implementation for pacing

2017-05-15 Thread Soheil Hassas Yeganeh
On Mon, May 15, 2017 at 11:43 PM, Eric Dumazet wrote: > BBR congestion control depends on pacing, and pacing is > currently handled by sch_fq packet scheduler for performance reasons, > and also because implemening pacing with FQ was convenient to truly > avoid bursts. > > However there are many c

[PATCH net-next] tcp: internal implementation for pacing

2017-05-15 Thread Eric Dumazet
BBR congestion control depends on pacing, and pacing is currently handled by sch_fq packet scheduler for performance reasons, and also because implemening pacing with FQ was convenient to truly avoid bursts. However there are many cases where this packet scheduler constraint is not practical. - Ma

Re: cxgb4 is broken in v4.12-rc1

2017-05-15 Thread Logan Gunthorpe
Hi, Thanks for looking into it. The version information of the card is: [5.235956] cxgb4 :07:00.4: Chelsio T62100-LP-CR rev 0 [5.235957] cxgb4 :07:00.4: S/N: PT51160053, P/N: 11012106004 [5.235959] cxgb4 :07:00.4: Firmware version: 1.16.29.4 [5.235960] cxgb4 :07:00

Re: cxgb4 is broken in v4.12-rc1

2017-05-15 Thread Ganesh GR
Hi Logan, Thanks for reporting the issue I will try to reproduce this, btw what is the firmware version on your setup?. Regards Ganesh From: Logan Gunthorpe Sent: Tuesday, May 16, 2017 4:06 AM To: Ganesh GR Cc: David S. Miller; Stephen Bates; SWise OGC; netdev@vger.kernel.org Subject: BUG:

[PATCH net-next 4/9] nfp: don't assume RSS and IRQ moderation are always enabled

2017-05-15 Thread Jakub Kicinski
Even if capability for RSS and IRQ moderation are present we may have not initialized them for control vNIC. Depend on selected features mask (ctrl) rather than capabilities (cap) to determine which features should be enabled. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman --- drivers

[PATCH net-next 7/9] nfp: complete the XDP TX ring only when it's full

2017-05-15 Thread Jakub Kicinski
Since XDP TX ring holds "spare" RX buffers anyway, we don't have to rush the completion. We can wait until ring fills up completely before trying to reclaim buffers. If RX poll has ended an no buffer has been queued for XDP TX we have no guarantee we will see another interrupt, so run the reclaim

[PATCH net-next 8/9] nfp: add a helper for wrapping descriptor index

2017-05-15 Thread Jakub Kicinski
We have a number of places where we calculate the descriptor index based on a value which may have overflown. Create a macro for masking with the ring size. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net.h| 3 +++ drivers/net/ethernet/netronome/nfp/nfp_net

[PATCH net-next 2/9] nfp: rename l4_offset in struct nfp_net_tx_desc to lso_hdrlen

2017-05-15 Thread Jakub Kicinski
From: Edwin Peer The l4_offset field referred to by NFD is confusingly named. It is not the offset of the L4 transport header, but rather the L4 payload. The LSO2 capability supported by alternative device firmware requires the actual L4 offset, thus the rename seems prudent. Signed-off-by: Edw

[PATCH net-next 1/9] nfp: don't enable TSO on the device when disabled

2017-05-15 Thread Jakub Kicinski
We advertise TSO to the stack but leave it disabled by default. Make sure it's not only disabled in the netdev features but also on the device itself. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 1 + 1 file changed, 1 inserti

[PATCH net-next 0/9] nfp: LSO, checksum and XDP datapath updates

2017-05-15 Thread Jakub Kicinski
Hi! This series introduces a number of refinements to standard features like LSO and checksum offload. Three major features are support for CHECKSUM_COMPLETE, refinement of TSO handling and another small speed up for XDP TX. This series also switches from depending on some app FW<>driver ABI ve

[PATCH net-next 3/9] nfp: support LSO2 capability

2017-05-15 Thread Jakub Kicinski
From: Edwin Peer Firmware advertising the LSO2 capability exploits driver provided L3 and L4 offsets in order to avoid parsing packet headers in the TX path. The vlan field in struct nfp_net_tx_desc is repurposed, making TXVLAN a mutually exclusive configuration to LSO2. Signed-off-by: Edwin Pee

[PATCH net-next 9/9] nfp: eliminate an if statement in calculation of completed frames

2017-05-15 Thread Jakub Kicinski
Given that our rings are always a power of 2, we can simplify the calculation of number of completed TX descriptors by using masking instead of if statement based on whether the index have wrapped or not. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 10

[PATCH net-next 6/9] nfp: add CHECKSUM_COMPLETE support

2017-05-15 Thread Jakub Kicinski
Introduce NFP_NET_CFG_CTRL_CSUM_COMPLETE capability and implement parsing of CHECKSUM_COMPLETE metadata. Signed-off-by: Jakub Kicinski Signed-off-by: Edwin Peer Reviewed-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/nfp_net.h | 4 ++- .../net/ethernet/netronome/nfp/nfp_net_com

[PATCH net-next 5/9] nfp: version independent support for chained RSS metadata

2017-05-15 Thread Jakub Kicinski
From: Edwin Peer ABI version 4 introduced metadata chaining. Using the ABI version to signal metadata chaining precludes firmware that advertises new capabilities which rely on prepended metadata from working on older kernels. Capability bits are thus better suited to signalling the chained meta

Re: [PATCH] net: ethernet: broadcom: bnxt: remove dead code

2017-05-15 Thread Michael Chan
On Mon, May 15, 2017 at 3:28 PM, Gustavo A. R. Silva wrote: > Local variable _sh_ is assigned to a constant value and it is never updated > again. Remove this variable and the dead code it guards. > > Addresses-Coverity-ID: 1350916 > Signed-off-by: Gustavo A. R. Silva > --- > drivers/net/etherne

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-05-15 Thread Luis R. Rodriguez
On Fri, May 12, 2017 at 11:02:26PM +0200, Arend Van Spriel wrote: > try again.. replacing email address from Michał > On 12-5-2017 22:55, Arend Van Spriel wrote: > > Let me explain the idea to refresh your memory (and mine). It started > > when we were working on adding driver support for OpenWrt i

Re: [net 1/6] net/mlx5e: Use a spinlock to synchronize statistics

2017-05-15 Thread Stephen Hemminger
On Fri, 12 May 2017 14:56:45 +0300 Saeed Mahameed wrote: > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en.h > b/drivers/net/ethernet/mellanox/mlx5/core/en.h > index 0099a3e397bc..c41cf7e82795 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/en.h > +++ b/drivers/net/ethernet/mellan

BUG: cxgb4 is broken in v4.12-rc1

2017-05-15 Thread Logan Gunthorpe
Hi, With rc1 my T62100-LP-CR no longer functions correctly. Everything appears fine but the link never goes into the UP state. I have one peer with an older (functioning) kernel and the other peer on rc1. I've bisected to find this is the offending commit: 3bb4858fd: cxgb4: avoid disabling FEC b

Re: [PATCH] neighbour: update neigh timestamps iff update is effective

2017-05-15 Thread Julian Anastasov
Hello, On Mon, 15 May 2017, Ihar Hrachyshka wrote: > On Mon, May 15, 2017 at 1:05 PM, Julian Anastasov wrote: > > > > It seems arp_accept value currently has influence on > > the locktime for GARP requests. My understanding is that > > locktime is used to ignore replies from pro

[PATCH] net: ethernet: broadcom: bnxt: remove dead code

2017-05-15 Thread Gustavo A. R. Silva
Local variable _sh_ is assigned to a constant value and it is never updated again. Remove this variable and the dead code it guards. Addresses-Coverity-ID: 1350916 Signed-off-by: Gustavo A. R. Silva --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 9 +++-- 1 file changed, 3 insertions(+), 6 d

[PATCH] ipmr: vrf: Find VIFs using the actual device

2017-05-15 Thread Thomas Winter
The skb->dev that is passed into ip_mr_input is the loX device for VRFs. When we lookup a vif for this dev, none is found as we do not create vifs for loopbacks. Instead lookup a vif for the actual device that the packet was received on, eg the vlan. Signed-off-by: Thomas Winter cc: David Ahern

Re: [Patch net] ipv4: restore rt->fi for reference counting

2017-05-15 Thread Cong Wang
On Mon, May 15, 2017 at 1:37 PM, Julian Anastasov wrote: > Any user that does not set FIB_LOOKUP_NOREF > will need nh_dev refcounts. The assumption is that the > NHs are accessed, who knows, may be even after RCU grace > period. As result, we can not use dev_put on NETDEV_UNREGISTER. > So,

Re: [PATCH iproute2 -master 0/2] Two misc BPF updates

2017-05-15 Thread Stephen Hemminger
On Sat, 13 May 2017 02:32:33 +0200 Daniel Borkmann wrote: > Requires header rebase with -net. > > Thanks! > > Daniel Borkmann (2): > bpf: update printing of generic xdp mode > bpf: dump error to the user when retrieving pinned prog fails > > ip/iplink_xdp.c | 19 +++ > lib

Re: [PATCH iproute2 master 0/4] pedit: Introduce IPv6 support + some minor fixes

2017-05-15 Thread Stephen Hemminger
On Sun, 14 May 2017 11:17:42 +0300 Amir Vadai wrote: > Hi, > > This patchset introduces pedit IPv6 support. > Almost all IPv6 header fields are editable now (src, dst, flow_lbl, > payload_len, next_hdr and hoplimit). > The patch uses the new extended pedit netlink and will fail the operation if

Re: [PATCH 1/1] dt-binding: net: wireless: fix node name in the BCM43xx example

2017-05-15 Thread Arend Van Spriel
On 15-5-2017 22:13, Martin Blumenstingl wrote: > The example in the BCM43xx documentation uses "brcmf" as node name. > However, wireless devices should be named "wifi" instead. Fix this to Hi Martin, Since when is that a rule. I never got the memo and the DTC did not ever complain to me about the

Re: [PATCH 2/3] bpf: Track alignment of MAP pointers in verifier.

2017-05-15 Thread Daniel Borkmann
On 05/15/2017 05:34 PM, David Miller wrote: From: Daniel Borkmann Date: Mon, 15 May 2017 15:10:02 +0200 What are the semantics of using id here? In ptr_to_pkt, we have it, so that eventually, in find_good_pkt_pointers() we can match on id and update the range for all such regs with the same id

Re: [PATCH] neighbour: update neigh timestamps iff update is effective

2017-05-15 Thread Ihar Hrachyshka
It's a common practice to send gratuitous ARPs after moving an IP address to another device to speed up healing of a service. To fulfill service availability constraints, the timing of network peers updating their caches to point to a new location of an IP address can be particularly important. So

Re: [PATCH] neighbour: update neigh timestamps iff update is effective

2017-05-15 Thread Ihar Hrachyshka
On Mon, May 15, 2017 at 1:05 PM, Julian Anastasov wrote: > > It seems arp_accept value currently has influence on > the locktime for GARP requests. My understanding is that > locktime is used to ignore replies from proxy_arp > routers while the requested IP is present on the LAN > and repl

[PATCH] libertas: Remove function entry/exit debugging

2017-05-15 Thread Kees Cook
In at least one place, the enter/exit debugging was not being correctly matched. Based on mailing list feedback, it was desired to drop all of these in favor of using ftrace instead. Suggested-by: Joe Perches Suggested-by: Kalle Valo Signed-off-by: Kees Cook --- drivers/net/wireless/marvell/li

[PATCH v3] libertas: Avoid reading past end of buffer

2017-05-15 Thread Kees Cook
Using memcpy() from a string that is shorter than the length copied means the destination buffer is being filled with arbitrary data from the kernel rodata segment. Instead, redefine the stat strings to be ETH_GSTRING_LEN sizes, like other drivers. This lets us use a single memcpy that does not lea

Re: [PATCH v2 net-next 3/5] dsa: add DSA switch driver for Microchip KSZ9477

2017-05-15 Thread Florian Fainelli
On 05/15/2017 02:01 PM, woojung@microchip.com wrote: >>> +static const struct ksz_chip_data ksz_switch_chips[] = { >>> + { >>> + .chip_id = 0x00947700, >>> + .dev_name = "KSZ9477", >>> + .num_vlans = 4096, >>> + .num_alus = 4096, >>> + .num_st

Re: [PATCH] arp: honour gratuitous ARP _replies_

2017-05-15 Thread Ihar Hrachyshka
When arp_accept is 1, gratuitous ARPs are supposed to override matching entries irrespective of whether they arrive during locktime. This was implemented in commit 56022a8fdd87 ("ipv4: arp: update neighbour address when a gratuitous arp is received and arp_accept is set") There is a glitch in the

[PATCH net] tcp: eliminate negative reordering in tcp_clean_rtx_queue

2017-05-15 Thread Soheil Hassas Yeganeh
From: Soheil Hassas Yeganeh tcp_ack() can call tcp_fragment() which may dededuct the value tp->fackets_out when MSS changes. When prior_fackets is larger than tp->fackets_out, tcp_clean_rtx_queue() can invoke tcp_update_reordering() with negative values. This results in absurd tp->reodering value

Re: [PATCH v2 net-next 06/12] ep93xx_eth: add GRO support

2017-05-15 Thread Alexander Sverdlin
Hi! On Mon May 15 22:43:20 2017 Ryan Mallon wrote: > > I don't know if we really care about this hardware anymore (I don't), > > but the ep93xx platform is still listed as being maintained in the > > MAINTAINERS file -- adding Ryan and Hartley. > > I no longer have any ep93xx hardware to test wi

RE: [PATCH v2 net-next 3/5] dsa: add DSA switch driver for Microchip KSZ9477

2017-05-15 Thread Woojung.Huh
> > +static const struct ksz_chip_data ksz_switch_chips[] = { > > + { > > + .chip_id = 0x00947700, > > + .dev_name = "KSZ9477", > > + .num_vlans = 4096, > > + .num_alus = 4096, > > + .num_statics = 16, > > + .enabled_ports = 0x1F, /* po

RE: [PATCH v2 net-next 3/5] dsa: add DSA switch driver for Microchip KSZ9477

2017-05-15 Thread Woojung.Huh
> >> + dev->vlan_cache = devm_kmalloc_array(dev->dev, > >> + sizeof(struct vlan_table), > >> + dev->num_vlans, GFP_KERNEL); > > > > You should check, but i think devm_kmalloc_array sets the allocated > > memory to 0. > >

Re: [PATCH v2 net-next 06/12] ep93xx_eth: add GRO support

2017-05-15 Thread Ryan Mallon
On 15/05/17 20:31, Lennert Buytenhek wrote: > On Sat, Feb 04, 2017 at 03:24:56PM -0800, Eric Dumazet wrote: > >> Use napi_complete_done() instead of __napi_complete() to : >> >> 1) Get support of gro_flush_timeout if opt-in >> 2) Not rearm interrupts for busy-polling users. >> 3) use standard NA

Re: Advice on user space application integration with tc

2017-05-15 Thread Morgan Yang
I tried on both stock CentOS 7.3 and Ubuntu 16.04 and tc-skbmod was not support (I built tc from the latest versions of iproute2). For tc-pedit, examples from man tc-pedit such as "pedit ex munge" were not supported, but "pedit munge offset" is. On Mon, May 15, 2017 at 1:14 PM, Cong Wang wrote: >

Re: [Patch net] ipv4: restore rt->fi for reference counting

2017-05-15 Thread Julian Anastasov
Hello, On Mon, 15 May 2017, Cong Wang wrote: > On Fri, May 12, 2017 at 2:27 PM, Julian Anastasov wrote: > > Now the main question: is FIB_LOOKUP_NOREF used > > everywhere in IPv4? I guess so. If not, it means > > someone can walk its res->fi NHs which is bad. I think, > > this w

Re: [PATCH net-next 3/3] udp: keep the sk_receive_queue held when splicing

2017-05-15 Thread Paolo Abeni
On Mon, 2017-05-15 at 09:11 -0700, Eric Dumazet wrote: > On Mon, 2017-05-15 at 11:01 +0200, Paolo Abeni wrote: > > On packet reception, when we are forced to splice the > > sk_receive_queue, we can keep the related lock held, so > > that we can avoid re-acquiring it, if fwd memory > > scheduling is

Re: Advice on user space application integration with tc

2017-05-15 Thread Cong Wang
On Thu, May 11, 2017 at 1:45 PM, Morgan Yang wrote: > Hi All: > > I want to build a solution that leverages the filtering and actions of > tc in kernel space, but have the ability to hook to a userspace > application that can additional packet processing (such as payload > masking). I'm curious w

[PATCH 1/1] dt-binding: net: wireless: fix node name in the BCM43xx example

2017-05-15 Thread Martin Blumenstingl
The example in the BCM43xx documentation uses "brcmf" as node name. However, wireless devices should be named "wifi" instead. Fix this to make sure that .dts authors can simply use the documentation as reference (or simply copy the node from the documentation and then adjust only the board specific

[PATCH 0/1] fix node name in the brcm,bcm43xx-fmac.txt example

2017-05-15 Thread Martin Blumenstingl
recently there were some negative comments about the quality of code-reviews for new .dts additions. one issue that came up was that the node for the Broadcom FullMAC wireless SDIO devices was named "brcmf" instead of "wifi". This patch tries to fix (one of) the root cause(s), which is that .dts a

Re: [PATCH] neighbour: update neigh timestamps iff update is effective

2017-05-15 Thread Julian Anastasov
Hello, On Tue, 9 May 2017, Ihar Hrachyshka wrote: > It's a common practice to send gratuitous ARPs after moving an > IP address to another device to speed up healing of a service. To > fulfill service availability constraints, the timing of network peers > updating their caches to point

Re: [patch net-next v2 10/10] net: sched: add termination action to allow goto chain

2017-05-15 Thread Daniel Borkmann
On 05/15/2017 10:38 AM, Jiri Pirko wrote: From: Jiri Pirko Introduce new type of termination action called "goto_chain". This allows user to specify a chain to be processed. This action type is then processed as a return value in tcf_classify loop in similar way as "reclassify" is, only it does

[GIT] Networking

2017-05-15 Thread David Miller
1) Track alignment in BPF verifier so that legitimate programs won't be rejected on !CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS architectures. 2) Make tail calls work properly in arm64 BPF JIT, from Deniel Borkmann. 3) Make the configuration and semantics Generic XDP make more sense and

Re: [PATCH] kmod: don't load module unless req process has CAP_SYS_MODULE

2017-05-15 Thread Florian Westphal
Eric W. Biederman wrote: > If loading the conntrack module changes the semantics of packet > processing when nothing is configured that is a bug in the conntrack > module. Thats the default behaviour since forever. modprobe nf_conntrack_ipv4 -- module_init registers netfilter hooks and starts do

Re: arch: arm: bpf: Converting cBPF to eBPF for arm 32 bit

2017-05-15 Thread Daniel Borkmann
On 05/13/2017 11:38 PM, Shubham Bansal wrote: Finally finished testing. "test_bpf: Summary: 314 PASSED, 0 FAILED, [274/306 JIT'ed]" What are the missing pieces and how is the performance compared to the interpreter? Thanks, Daniel

Re: [PATCH net-next 0/2] ldmvsw: port removal stability

2017-05-15 Thread David Miller
From: Shannon Nelson Date: Mon, 15 May 2017 10:51:06 -0700 > Under heavy reboot stress testing we found a couple of timing issues > when removing the device that could cause the kernel great heartburn, > addressed by these two patches. These are pretty legit bug fixes so I've applied this series

Re: [PATCH net] net: netcp: fix check of requested timestamping filter

2017-05-15 Thread David Miller
From: Miroslav Lichvar Date: Mon, 15 May 2017 16:04:36 +0200 > The driver doesn't support timestamping of all received packets and > should return error when trying to enable the HWTSTAMP_FILTER_ALL > filter. > > Cc: WingMan Kwok > Cc: Richard Cochran > Signed-off-by: Miroslav Lichvar Applie

Re: [PATCH] rt2x00: improve calling conventions for register accessors

2017-05-15 Thread Daniel Golle
On Mon, May 15, 2017 at 10:40:52AM -0400, David Miller wrote: > From: Arnd Bergmann > Date: Mon, 15 May 2017 16:36:45 +0200 > > > On Mon, May 15, 2017 at 4:28 PM, Stanislaw Gruszka > > wrote: > >> On Mon, May 15, 2017 at 03:46:55PM +0200, Arnd Bergmann wrote: > >>> With CONFIG_KASAN enabled and

Re: [lkp-robot] [bpf] de05014aba: BUG:sleeping_function_called_from_invalid_context_at_mm/slab.h

2017-05-15 Thread David Miller
From: kernel test robot Date: Mon, 15 May 2017 16:14:38 +0800 > commit: de05014aba8054e1353b720b814a0cd8ea7594e5 ("bpf: Introduce bpf_prog > ID") > url: > https://github.com/0day-ci/linux/commits/Martin-KaFai-Lau/bpf-Introduce-bpf_prog-ID/20170428-025859 Indeed, we can't use GFP_USER in the ca

Re: [PATCH] net: x25: fix one potential use-after-free issue

2017-05-15 Thread David Miller
From: linzhang Date: Mon, 15 May 2017 12:12:49 +0800 > The function x25_init is not properly unregister related resources > on error handler.It is will result in kernel oops if x25_init init > failed, so add right unregister call on error handler. > > Signed-off-by: linzhang I think we need to

Admin

2017-05-15 Thread administrador
ATENCIÓN; Su buzón ha superado el límite de almacenamiento, que es de 5 GB definidos por el administrador, quien actualmente está ejecutando en 10.9GB, no puede ser capaz de enviar o recibir correo nuevo hasta que vuelva a validar subuzón de correo electrónico. Para revalidar su buzón de corre

Re: [net 1/6] net/mlx5e: Use a spinlock to synchronize statistics

2017-05-15 Thread David Miller
From: Saeed Mahameed Date: Sun, 14 May 2017 11:52:13 +0300 > I agree, it is really ridiculous that we allocate/free a couple of > buffers on each update_stats operations, regardless of this patch. > Is it ok if we use a temp buffer under netdev_priv for such usages or > even use kmemcache ? If y

Re: [pull request][net V2 0/5] Mellanox, mlx5 fixes 2017-05-12

2017-05-15 Thread David Miller
From: Saeed Mahameed Date: Sun, 14 May 2017 13:43:06 +0300 > This series contains some mlx5 fixes for net. > Please pull and let me know if there's any problem. > > For -stable: > ("net/mlx5e: Fix ethtool pause support and advertise reporting") kernels >= > 4.8 > ("net/mlx5e: Use the correct pa

Re: [PATCH net v2] qed: Fix uninitialized data in aRFS infrastructure

2017-05-15 Thread David Miller
From: Yuval Mintz Date: Sun, 14 May 2017 12:21:23 +0300 > Current memset is using incorrect type of variable, causing the > upper-half of the strucutre to be left uninitialized and causing: > > ethernet/qlogic/qed/qed_init_fw_funcs.c: In function > 'qed_set_rfs_mode_disable': > ethernet/qlo

Re: [Patch net] ipv4: restore rt->fi for reference counting

2017-05-15 Thread Cong Wang
On Fri, May 12, 2017 at 2:27 PM, Julian Anastasov wrote: > Now the main question: is FIB_LOOKUP_NOREF used > everywhere in IPv4? I guess so. If not, it means > someone can walk its res->fi NHs which is bad. I think, > this will delay the unregistration for long time and we > can not solve

Re: [PATCH net] ipv6: avoid dad-failures for addresses with NODAD

2017-05-15 Thread David Miller
From: David Miller Date: Mon, 15 May 2017 14:26:55 -0400 (EDT) > From: Mahesh Bandewar > Date: Fri, 12 May 2017 17:03:39 -0700 > >> From: Mahesh Bandewar >> >> Every address gets added with TENTATIVE flag even for the addresses with >> IFA_F_NODAD flag and dad-work is scheduled for them. Duri

Re: [PATCH] mdio: mux: fix device_node_continue.cocci warnings

2017-05-15 Thread David Miller
From: Jon Mason Date: Mon, 15 May 2017 13:37:09 -0400 > I would prefer #1, as I would not want to break something that was > currently working. However, I think we should add much error logging > here to let people know their DT is hosed (instead of silently > working). So, this would mean appl

Re: [PATCH] kmod: don't load module unless req process has CAP_SYS_MODULE

2017-05-15 Thread Eric W. Biederman
"Mahesh Bandewar (महेश बंडेवार)" writes: > On Mon, May 15, 2017 at 6:52 AM, David Miller wrote: >> From: Greg Kroah-Hartman >> Date: Mon, 15 May 2017 08:10:59 +0200 >> >>> On Sun, May 14, 2017 at 08:57:34AM -0500, Eric W. Biederman wrote: Greg Kroah-Hartman writes: diff --git a/

Re: [PATCH net] ipv6: avoid dad-failures for addresses with NODAD

2017-05-15 Thread David Miller
From: Mahesh Bandewar Date: Fri, 12 May 2017 17:03:39 -0700 > From: Mahesh Bandewar > > Every address gets added with TENTATIVE flag even for the addresses with > IFA_F_NODAD flag and dad-work is scheduled for them. During this DAD process > we realize it's an address with NODAD and complete th

Re: [PATCH] net/packet: fix missing net_device reference release

2017-05-15 Thread David Miller
From: Douglas Caetano dos Santos Date: Fri, 12 May 2017 15:19:15 -0300 > When using a TX ring buffer, if an error occurs processing a control > message (e.g. invalid message), the net_device reference is not > released. > > Fixes c14ac9451c348 ("sock: enable timestamping using control messages")

Re: [PATCH v4] net/mlx4_core: Use min3 to select number of MSI-X vectors

2017-05-15 Thread David Miller
From: Yuval Shaia Date: Fri, 12 May 2017 09:10:51 +0300 > Signed-off-by: Yuval Shaia > --- > v0 -> v1: > * s/"min_t("/"min_t(int" > v1 -> v2: > * Use min3 instead of min_t twice > v2 -> v3: > * Change commit log header message to reflect the changes made in > v2 > v3 ->

Re: [PATCH net] macvlan: Fix performance issues with vlan tagged packets

2017-05-15 Thread David Miller
From: Vladislav Yasevich Date: Thu, 11 May 2017 11:09:52 -0400 > Macvlan always turns on offload features that have sofware > fallback (NETIF_GSO_SOFTWARE). This allows much higher guest-guest > communications over macvtap. > > However, macvtap does not turn on these features for vlan tagged tr

Re: [PATCH] kmod: don't load module unless req process has CAP_SYS_MODULE

2017-05-15 Thread David Miller
From: Mahesh Bandewar (महेश बंडेवार) Date: Mon, 15 May 2017 10:59:55 -0700 > The current behavior is already breaking things. e.g. unprivileged > process can be root inside it's own user-ns. This will allow it to > create IPtable rules causing contracking module to be loaded in > default-ns affec

Re: [PATCH] arp: honour gratuitous ARP _replies_

2017-05-15 Thread David Miller
From: Ihar Hrachyshka Date: Tue, 9 May 2017 17:16:07 -0700 > @@ -842,8 +844,20 @@ static int arp_process(struct net *net, struct sock *sk, > struct sk_buff *skb) > It is possible, that this option should be enabled for some > devices (strip is candidate) >

Re: [PATCH] kmod: don't load module unless req process has CAP_SYS_MODULE

2017-05-15 Thread महेश बंडेवार
On Mon, May 15, 2017 at 6:52 AM, David Miller wrote: > From: Greg Kroah-Hartman > Date: Mon, 15 May 2017 08:10:59 +0200 > >> On Sun, May 14, 2017 at 08:57:34AM -0500, Eric W. Biederman wrote: >>> Greg Kroah-Hartman writes: >>> >>> diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c >>> inde

[PATCH net-next] geneve: add rtnl changelink support

2017-05-15 Thread Girish Moodalbail
This patch adds changelink rtnl operation support for geneve devices. Code changes involve: - refactor geneve_newlink into geneve_nl2info to be used by both geneve_newlink and geneve_changelink - geneve_nl2info takes a changelink boolean argument to isolate changelink checks and updates

[PATCH net-next 2/2] ldmvsw: stop the clean timer at beginning of remove

2017-05-15 Thread Shannon Nelson
Stop the clean timer earlier to be sure there's no asynchronous interference while stopping the port. Orabug: 25748241 Signed-off-by: Shannon Nelson --- drivers/net/ethernet/sun/ldmvsw.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/ethernet/sun/ldmvsw.c

[PATCH net-next 0/2] ldmvsw: port removal stability

2017-05-15 Thread Shannon Nelson
Under heavy reboot stress testing we found a couple of timing issues when removing the device that could cause the kernel great heartburn, addressed by these two patches. Shannon Nelson (1): ldmvsw: stop the clean timer at beginning of remove Thomas Tai (1): ldmvsw: unregistering netdev befor

[PATCH net-next 1/2] ldmvsw: unregistering netdev before disable hardware

2017-05-15 Thread Shannon Nelson
From: Thomas Tai When running LDom binding/unbinding test, kernel may panic in ldmvsw_open(). It is more likely that because we're removing the ldc connection before unregistering the netdev in vsw_port_remove(), we set up a window of time where one process could be removing the device while anot

Re: arch: arm: bpf: Converting cBPF to eBPF for arm 32 bit

2017-05-15 Thread Kees Cook
On Sat, May 13, 2017 at 2:38 PM, Shubham Bansal wrote: > Finally finished testing. > > "test_bpf: Summary: 314 PASSED, 0 FAILED, [274/306 JIT'ed]" Nice work! Glad you've been chipping away at this. Thanks! -Kees > > Will send the patch after code refactoring. Thanks for all the help > you guys.

Re: [PATCH] mdio: mux: fix device_node_continue.cocci warnings

2017-05-15 Thread Jon Mason
On Fri, May 12, 2017 at 6:52 PM, Florian Fainelli wrote: > On 05/12/2017 09:22 AM, David Miller wrote: >> From: Julia Lawall >> Date: Fri, 12 May 2017 22:54:23 +0800 (SGT) >> >>> Device node iterators put the previous value of the index variable, so an >>> explicit put causes a double put. >> ..

Your first payment of $5000 ,

2017-05-15 Thread Mrs. Linda Jones
Attn Beneficiary, We have deposited the check of your fund ($2.5m USD) through western union money transfer department after our finally meeting today regarding your fund, Now all you will do is to contact western union director Mis Rose Kelly ,And She will give you the direction on how you wil

Re: [PATCH] neighbour: update neigh timestamps iff update is effective

2017-05-15 Thread David Miller
From: Ihar Hrachyshka Date: Tue, 9 May 2017 17:06:05 -0700 > Sometimes neigh_update calls won't touch neither lladdr nor state, for > example if an update arrives in locktime interval. Then we effectively > ignore the update request, bailing out of touching the neigh entry, > except that we stil

Re: [PATCH] kmod: don't load module unless req process has CAP_SYS_MODULE

2017-05-15 Thread Kees Cook
On Mon, May 15, 2017 at 6:12 AM, Eric Dumazet wrote: > On Sun, May 14, 2017 at 7:42 PM, Mahesh Bandewar (महेश बंडेवार) > wrote: >> On Sun, May 14, 2017 at 3:45 AM, Greg Kroah-Hartman >> wrote: >>> On Fri, May 12, 2017 at 04:22:59PM -0700, Mahesh Bandewar wrote: From: Mahesh Bandewar >

Re: [PATCH net v2] i40e/i40evf: proper update of the page_offset field

2017-05-15 Thread Duyck, Alexander H
On Mon, 2017-05-15 at 06:52 +0200, Björn Töpel wrote: > From: Björn Töpel > > In f8b45b74cc62 ("i40e/i40evf: Use build_skb to build frames") > i40e_build_skb updates the page_offset field with an incorrect offset, > which can lead to data corruption. This patch updates page_offset > correctly, by

Re: [GIT PULL 0/1] IPVS Fixes for v4.12

2017-05-15 Thread Pablo Neira Ayuso
On Mon, May 08, 2017 at 11:48:42AM +0200, Simon Horman wrote: > Hi Pablo, > > please consider this fix to IPVS for v4.12. > > * It is a fix from Julian Anastasov to only SNAT SNAT packet replies only for > NATed connections > > > My understanding is that this fix is appropriate for 4.9.25, 4.

Re: [PATCH nf] xtables: zero padding in data_to_user

2017-05-15 Thread Pablo Neira Ayuso
On Tue, May 09, 2017 at 04:17:37PM -0400, Willem de Bruijn wrote: > From: Willem de Bruijn > > When looking up an iptables rule, the iptables binary compares the > aligned match and target data (XT_ALIGN). In some cases this can > exceed the actual data size to include padding bytes. > > Before

Re: switchdev offload & ecmp

2017-05-15 Thread Ido Schimmel
Hi, On Mon, May 15, 2017 at 04:25:43PM +0200, Nicolas Dichtel wrote: > Hi Jiri and Ido, > > I'm trying to understand how ecmp offloading works. It seems that rocker > doesn't > support it: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/net/ethernet/rocker/rocke

Re: [PATCH net-next 3/3] udp: keep the sk_receive_queue held when splicing

2017-05-15 Thread Eric Dumazet
On Mon, 2017-05-15 at 11:01 +0200, Paolo Abeni wrote: > On packet reception, when we are forced to splice the > sk_receive_queue, we can keep the related lock held, so > that we can avoid re-acquiring it, if fwd memory > scheduling is required. > > Signed-off-by: Paolo Abeni > --- > net/ipv4/udp

Re: [PATCH net-next 2/3] udp: use a separate rx queue for packet reception

2017-05-15 Thread Eric Dumazet
On Mon, 2017-05-15 at 11:01 +0200, Paolo Abeni wrote: > under udp flood the sk_receive_queue spinlock is heavily contended. > This patch try to reduce the contention on such lock adding a > second receive queue to the udp sockets; recvmsg() looks first > in such queue and, only if empty, tries to f

[PATCH v2 3/3] bpf: Update MAP test_verifier.c tests wrt. alignment.

2017-05-15 Thread David Miller
Now that we perform proper alignment tracking of MAP accesses in the verifier, most of the MAP tests in test_verifier.c no longer need the special F_NEEDS_EFFICIENT_UNALIGNED_ACCESS flag or can trivially be made to not need it. struct test_val is an integer count followed by an array of integers.

[PATCH v2 2/3] bpf: Track alignment of MAP pointers in verifier.

2017-05-15 Thread David Miller
Just like packet pointers, track the known alignment of MAP pointers. In order to facilitate the state tracking, move the register offset field into where there is an unused 32-bit padding slot on 64-bit. The check logic is the same as for packet pointers, except we do not apply NET_IP_ALIGN to

[PATCH v2 0/3] bpf: Track MAP pointer alignment

2017-05-15 Thread David Miller
This patch series updates the BPF verifier to properly track MAP access alignment, just as we already do for packet pointers. The two main elements of the implementation are putting the register offset into a shared rather than reg type specific area of the verifier register tracking strcutre, an

[PATCH v2 1/3] bpf: Use 1<<16 as ceiling for immediate alignment in verifier.

2017-05-15 Thread David Miller
If we use 1<<31, then sequences like: R1 = 0 R1 <<= 2 do silly things. Examples of this actually exist in the MAP tests of test_verifier.c Update test_align.c expectation strings. Signed-off-by: David S. Miller --- kernel/bpf/verifier.c| 2 +- tools/test

Re: [PATCH net-next 1/3] net/sock: factor out dequeue/peek with offset code

2017-05-15 Thread Eric Dumazet
On Mon, 2017-05-15 at 11:01 +0200, Paolo Abeni wrote: > And update __sk_queue_drop_skb() to work on the specified queue. > This will help the udp protocol to use an additional private > rx queue in a later patch. > > Signed-off-by: Paolo Abeni > --- Acked-by: Eric Dumazet

Re: [PATCH 2/3] bpf: Track alignment of MAP pointers in verifier.

2017-05-15 Thread David Miller
From: Daniel Borkmann Date: Mon, 15 May 2017 15:10:02 +0200 >>> What are the semantics of using id here? In ptr_to_pkt, we have it, >>> so that eventually, in find_good_pkt_pointers() we can match on id >>> and update the range for all such regs with the same id. I'm just >>> wondering as the sid

[PATCH V3 net 0/1] net/smc and the RDMA core

2017-05-15 Thread Ursula Braun
From: Ursula Braun Hi Dave, as requested, here is V3 of the smc-patch with an updated commit log. V3: update commit log V2: do not use _internal_mr V1: switch to usage of IB_PD_UNSAFE_GLOBAL_RKEY Kind regards, Ursula Ursula Braun (1): smc: switch to usage of IB_PD_UNSAFE_GLOBAL_RKEY net/s

[PATCH V3 net 1/1] smc: switch to usage of IB_PD_UNSAFE_GLOBAL_RKEY

2017-05-15 Thread Ursula Braun
Currently, SMC enables remote access to physical memory when a user has successfully configured and established an SMC-connection until ten minutes after the last SMC connection is closed. Because this is considered a security risk, drivers are supposed to use IB_PD_UNSAFE_GLOBAL_RKEY in such a cas

  1   2   >