> > +static const struct ksz_chip_data ksz_switch_chips[] = {
> > +   {
> > +           .chip_id = 0x00947700,
> > +           .dev_name = "KSZ9477",
> > +           .num_vlans = 4096,
> > +           .num_alus = 4096,
> > +           .num_statics = 16,
> > +           .enabled_ports = 0x1F,  /* port0-4 */
> > +           .cpu_port = 5,          /* port5 (RGMII) */
> > +           .port_cnt = 7,
> > +           .phy_port_cnt = 5,
> > +   },
> > +};
> 
> Hi Woojung
> 
> Do we need cpu_port in this table? Can any port be used as a CPU port?
> From the code in ksz_config_cpu_port() it seems like it can.
> 
> And do we need enabled_ports? This seems to suggest only ports 0-4 can
> be user ports?
> 
Andrew,

Intention of cpu_port is for default cpu_port when devicetree doesn't have it.
However, it won't get back to dst, so it won't be needed.
Will remove it.

Enabled_ports was to configure physically connected ports. (For instance, 7 
ports switch but board only uses 4 ports.)
This code path is not working as expected. Will update at next version of patch.

Thanks.
Woojung

Reply via email to