In the function rds_ib_setup_qp, the error handle is missing. When some
error occurs, it is possible that memory leak occurs. As such, error
handle is added.
Cc: Joe Jin
Reviewed-by: Junxiao Bi
Reviewed-by: Guanglei Li
Signed-off-by: Zhu Yanjun
---
net/rds/ib_cm.c | 47 +++
On Mon, Mar 06, 2017 at 07:16:57AM +0100, Steffen Klassert wrote:
>
> > diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c
> > index b67719f..18383ef 100644
> > --- a/net/ipv4/ip_output.c
> > +++ b/net/ipv4/ip_output.c
> > @@ -960,7 +960,10 @@ static int __ip_append_data(struct sock *sk,
> >
On 2017-03-06 10:10, Cong Wang wrote:
> On Mon, Mar 6, 2017 at 2:54 AM, Dmitry Vyukov wrote:
> > Hello,
> >
> > I've got the following crash while running syzkaller fuzzer on
> > net-next/8d70eeb84ab277377c017af6a21d0a337025dede:
> >
> > kasan: GPF could be caused by NULL-ptr deref or user memory
On 3/6/2017 3:53 PM, Florian Fainelli wrote:
On 03/06/2017 03:15 PM, Shannon Nelson wrote:
When an ldom VM is bound, the network vswitch infrastructure is set up for
it, but was being forced 'UP' by the userland switch configuration script.
When 'UP' but not actually connected to a running VM,
On 3/4/17 8:57 AM, Sowmini Varadhan wrote:
Dmitry Vyukov reported some syszkaller panics during netns deletion.
While I have not been able to reproduce those exact panics, my attempts
to do so uncovered a few other problems, which are fixed patch 2 and
patch 3 of this patch series. In addition,
On 3/6/17 11:51 AM, Dmitry Vyukov wrote:
> We hit it several thousand times, but we get only several dozens of
> crashes per day on ~80 VMs. So if you try to reproduce it on a single
> machine it can take days for a single crash.
> If you are ready to go that route, here are some instructions on
>
These patches remove some problems in handling of carrier state
with the ldmvsw vswitch, remove an xoff misuse in sunvnet, and
add stats for debug and tracking of point-to-point connections
between the ldom VMs.
Shannon Nelson (5):
ldmvsw: better use of link up and down on ldom vswitch
sunvne
From: VSR Burru
Improve UDP TX performance by:
* reducing the ring size from 2K to 512
* replacing the numerous streaming DMA allocations for info buffers and
gather lists with one large consistent DMA allocation per ring
BQL is not effective here. We reduced the ring size because there is he
From: Philippe Reynes
Date: Mon, 27 Feb 2017 23:43:14 +0100
> The ethtool api {get|set}_settings is deprecated.
> We move this driver to new api {get|set}_link_ksettings.
>
> As I don't have the hardware, I'd be very pleased if
> someone may test this patch.
>
> Signed-off-by: Philippe Reynes
From: Haiyang Zhang
Date: Fri, 24 Feb 2017 17:30:32 +
> This patch adds a function to clean up duplicate config info
> on Ubuntu.
>
> Signed-off-by: Haiyang Zhang
Applied, thanks.
On Mon, 06 Mar 2017 17:13:33 -0800 (PST)
David Miller wrote:
> From: Stephen Hemminger
> Date: Mon, 27 Feb 2017 10:26:46 -0800
>
> > These patches enable NAPI, GRO and napi_alloc_skb for Hyper-V netvsc
> > driver.
>
> Series applied to net-next.
Great, but how do we coordinate allow use of
From: Jon Mason
Date: Tue, 28 Feb 2017 13:50:58 -0500
> Changes in v3:
> * Corrected a bug Florian found and added his Reviewed-by
>
> Changes in v2:
> * Reworked the PM patch with Florian's suggestions
>
>
> Add code to support Power Management (only tested on NS2), and add some
> code clean-
From: Tobias Klauser
Date: Tue, 28 Feb 2017 12:21:12 +0100
> Use eth_hw_addr_random() to set a random MAC address in order to make
> sure ndev->addr_assign_type will be properly set to NET_ADDR_RANDOM.
>
> Signed-off-by: Tobias Klauser
Applied to net-next, thanks.
From: Philippe Reynes
Date: Mon, 27 Feb 2017 22:50:25 +0100
> The ethtool api {get|set}_settings is deprecated.
> We move this driver to new api {get|set}_link_ksettings.
>
> As I don't have the hardware, I'd be very pleased if
> someone may test this patch.
>
> Signed-off-by: Philippe Reynes
From: Philippe Reynes
Date: Fri, 3 Mar 2017 23:39:35 +0100
> The ethtool api {get|set}_settings is deprecated.
> We move this driver to new api {get|set}_link_ksettings.
>
> As I don't have the hardware, I'd be very pleased if
> someone may test this patch.
>
> Signed-off-by: Philippe Reynes
From: Philippe Reynes
Date: Mon, 27 Feb 2017 23:06:41 +0100
> The ethtool api {get|set}_settings is deprecated.
> We move this driver to new api {get|set}_link_ksettings.
>
> As I don't have the hardware, I'd be very pleased if
> someone may test this patch.
>
> Signed-off-by: Philippe Reynes
From: Philippe Reynes
Date: Mon, 27 Feb 2017 23:17:37 +0100
> The ethtool api {get|set}_settings is deprecated.
> We move this driver to new api {get|set}_link_ksettings.
>
> As I don't have the hardware, I'd be very pleased if
> someone may test this patch.
>
> Signed-off-by: Philippe Reynes
From: Stephen Hemminger
Date: Mon, 27 Feb 2017 10:26:46 -0800
> These patches enable NAPI, GRO and napi_alloc_skb for Hyper-V netvsc
> driver.
Series applied to net-next.
From: David Forster
Date: Thu, 23 Feb 2017 16:27:18 +
> This provides equivalent functionality to the existing ipv4
> "disable_policy" systcl. ie. Allows IPsec processing to be skipped
> on terminating packets on a per-interface basis.
>
> Signed-off-by: David Forster
Applied to net-next,
HI Oliver,
> -Original Message-
> From: Oliver Hartkopp [mailto:socket...@hartkopp.net]
> Sent: 2017年3月7日 5:26
> To: Marc Kleine-Budde ; Wenyou Yang - A41535
> ; Wolfgang Grandegger
> Cc: Alexandre Belloni ; Florian Fainelli
> ; Quentin Schulz ;
> Wenyou Yang - A41535 ; Nicolas Ferre
> ;
From: Philippe Reynes
Date: Thu, 23 Feb 2017 22:34:43 +0100
> The ethtool api {get|set}_settings is deprecated.
> We move this driver to new api {get|set}_link_ksettings.
>
> As I don't have the hardware, I'd be very pleased if
> someone may test this patch.
>
> Signed-off-by: Philippe Reynes
From: Philippe Reynes
Date: Sun, 26 Feb 2017 22:48:59 +0100
> The ethtool api {get|set}_settings is deprecated.
> We move this driver to new api {get|set}_link_ksettings.
>
> As I don't have the hardware, I'd be very pleased if
> someone may test this patch.
>
> Signed-off-by: Philippe Reynes
From: Philippe Reynes
Date: Wed, 22 Feb 2017 08:50:27 +0100
> The ethtool api {get|set}_settings is deprecated.
> We move this driver to new api {get|set}_link_ksettings.
>
> As I don't have the hardware, I'd be very pleased if
> someone may test this patch.
>
> Signed-off-by: Philippe Reynes
From: Philippe Reynes
Date: Sun, 26 Feb 2017 19:00:29 +0100
> The ethtool api {get|set}_settings is deprecated.
> We move this driver to new api {get|set}_link_ksettings.
>
> As I don't have the hardware, I'd be very pleased if
> someone may test this patch.
>
> Signed-off-by: Philippe Reynes
From: Philippe Reynes
Date: Thu, 23 Feb 2017 00:14:08 +0100
> The ethtool api {get|set}_settings is deprecated.
> We move this driver to new api {get|set}_link_ksettings.
>
> As I don't have the hardware, I'd be very pleased if
> someone may test this patch.
>
> Signed-off-by: Philippe Reynes
On Mon, Mar 06, 2017 at 04:27:11PM +0100, Johannes Thumshirn wrote:
> On 03/06/2017 03:21 PM, Elena Reshetova wrote:
> > refcount_t type and corresponding API should be
> > used instead of atomic_t when the variable is used as
> > a reference counter. This allows to avoid accidental
> > refcounter
On 03/06/2017 03:15 PM, Shannon Nelson wrote:
> When an ldom VM is bound, the network vswitch infrastructure is set up for
> it, but was being forced 'UP' by the userland switch configuration script.
> When 'UP' but not actually connected to a running VM, the ipv6 neighbor
> probes fail (not a horr
On Mon, Mar 6, 2017 at 2:40 AM, Dmitry Vyukov wrote:
> Now with a nice single-threaded C reproducer!
Excellent...
>
> // autogenerated by syzkaller (http://github.com/google/syzkaller)
> #define _GNU_SOURCE
> #include
> #include
> #include
> #include
> #include
> #include
> #include
> #in
Dinesh reported that RTA_MULTIPATH nexthops are 8-bytes larger with IPv6
than IPv4. The recent refactoring for multipath support in netlink
messages does discriminate between non-multipath which needs the OIF
and multipath which adds a rtnexthop struct for each hop making the
RTA_OIF attribute redu
The ethtool api {get|set}_settings is deprecated.
We move this driver to new api {get|set}_link_ksettings.
As I don't have the hardware, I'd be very pleased if
someone may test this patch.
Signed-off-by: Philippe Reynes
---
drivers/net/ethernet/tundra/tsi108_eth.c | 14 --
1 files
Make sure multicast packets get counted in the device.
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/sun/sunvnet_common.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/sun/sunvnet_common.c
b/drivers/net/ethernet/sun/sunvnet_common.c
inde
In this driver, there is a "port" created for the connection to each of
the other ldoms; a netdev queue is mapped to each port, and they are
collected under a single netdev. The generic netdev statistics show
us all the traffic in and out of our network device, but don't show
individual queue/port
The sunvnet netdev is connected to the controlling ldom's vswitch
for network bridging. However, for higher performance between ldoms,
there also is a channel between each client ldom. These connections are
represented in the sunvnet driver by a queue for each ldom. The driver
uses select_queue
When an ldom VM is bound, the network vswitch infrastructure is set up for
it, but was being forced 'UP' by the userland switch configuration script.
When 'UP' but not actually connected to a running VM, the ipv6 neighbor
probes fail (not a horrible thing) and start cluttering up the kernel logs.
F
Track our used and unused queue indices correctly. Otherwise, as ports
dropped out and returned, they all eventually ended up with the same
queue index.
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/sun/sunvnet_common.c | 24
drivers/net/ethernet/sun/sunvnet_
This logic seems to be duplicated in (at least) three separate files.
Move it to one place so code can be re-use.
Signed-off-by: Yuval Shaia
---
v0 -> v1:
* Add missing #include
* Rename to genaddrconf_ifid_eui48
v1 -> v2:
* Reset eui[0] to default if dev_id is used
---
d
On 03/06/2017 07:52 PM, David Miller wrote:
From: Daniel Borkmann
Date: Mon, 06 Mar 2017 19:35:47 +0100
I can do a few more tests with the kernel I have. I'm also totally
fine if we drop this patch; it's just rc1, so there's plenty of time
till a final release.
I would really prefer we get t
On Mon, Mar 6, 2017 at 9:45 AM, Willem de Bruijn
wrote:
> On Mon, Mar 6, 2017 at 12:13 PM, chetan loke wrote:
Gosh. Can we also replace this BUG() into something less aggressive ?
>>>
>>>
>>> There are currently 5 of these WARN() + BUG() constructs and 1 BUG()-only
>>> for the 'default'
> Gosh. Can we also replace this BUG() into something less aggressive ?
There are currently 5 of these WARN() + BUG() constructs and 1 BUG()-only
for the 'default' TPACKET version spread all over af_packet, so probably
makes sense to rather make all of them less aggress
On Tue, 2017-02-28 at 14:46 -0800, Alexander Duyck wrote:
> On Tue, Feb 28, 2017 at 2:32 AM, Davide Caratti wrote:
> >
> > sctp_compute_checksum requires crc32c symbol (provided by libcrc32c), so
> > it can't be used in net core. Like it has been done previously with other
> > symbols (e.g. ipv6_
On Tue, Jan 31, 2017 at 9:09 PM, John Fastabend
wrote:
>> If I understand correctly, the difficulty lies in v3 requiring that the
>> timer "close" the block when the timer expires. That may not be worth
>> implementing, indeed.
>>
>
> Yep that is where I just gave up and decided it wasn't worth i
On Mon, Mar 6, 2017 at 5:19 PM, Kalle Valo wrote:
> Arend Van Spriel writes:
>
>> On 2-3-2017 17:38, Arnd Bergmann wrote:
>>> With KASAN and a couple of other patches applied, this driver is one
>>> of the few remaining ones that actually use more than 2048 bytes of
>>> kernel stack:
>>>
>>> broa
@Wenyou Yang: Can you please test the two patches posted here:
[PATCH 1/2] can: m_can: handle bitrate setup on IP core >= 3.1.x
http://marc.info/?l=linux-can&m=148883529927720&w=2
[PATCH 2/2] can: m_can: handle frame transmission on IP core >= 3.1.x
http://marc.info/?l=linux-can&m=14888352992771
Introduce a Kconfig option: CONFIG_TIGON3_HWMON which allows to build
in/out support for thermal sensors reported by Tigon3 NICs.
Signed-off-by: Florian Fainelli
---
drivers/net/ethernet/broadcom/Kconfig | 8 +++-
drivers/net/ethernet/broadcom/tg3.c | 7 +++
2 files changed, 14 inserti
From: Jiri Pirko
Couple of cosmetic mlxsw patches
Ido Schimmel (1):
mlxsw: pci: Remove unused bit
Jiri Pirko (1):
mlxsw: spectrum: Fix helper function and port variable names
drivers/net/ethernet/mellanox/mlxsw/cmd.h | 12
drivers/net/ethernet/mellanox/mlxsw/pci.c |
From: Ido Schimmel
The overrun ignore bit isn't supported by the device's firmware and was
recently removed from the programmer's reference manual (PRM).
Remove it from the driver as well.
Signed-off-by: Ido Schimmel
Signed-off-by: Jiri Pirko
---
drivers/net/ethernet/mellanox/mlxsw/cmd.h | 1
From: Jiri Pirko
Commit dd82364c3ab9 ("mlxsw: Flip to the new dev walk API") did some
small changes in mlxsw code, but it did not respect the naming
conventions. So fix this now.
Signed-off-by: Jiri Pirko
Reviewed-by: Ido Schimmel
---
drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 23 ++
From: Jiri Pirko
This warnings may be hit even in case they should not - in case user
puts a TC-flower rule which failed to be offloaded. So just remove them.
Reported-by: Petr Machata
Reported-by: Ido Schimmel
Fixes: commit 7aa0f5aa9030 ("mlxsw: spectrum: Implement TC flower offload")
Signed-
On Mon, 2017-03-06 at 19:46 +0100, Alexander Potapenko wrote:
> KMSAN (KernelMemorySanitizer, a new error detection tool) reports use of
> uninitialized memory in selinux_socket_bind():
>
...
> Signed-off-by: Alexander Potapenko
> ---
> Changes since v1:
> - fixed patch description
> - fixed ad
On Mon, Mar 6, 2017 at 2:54 AM, Dmitry Vyukov wrote:
> Hello,
>
> I've got the following crash while running syzkaller fuzzer on
> net-next/8d70eeb84ab277377c017af6a21d0a337025dede:
>
> kasan: GPF could be caused by NULL-ptr deref or user memory access
> general protection fault: [#1] SMP KAS
On Mon, Mar 06, 2017 at 10:55:22AM -0800, David Miller wrote:
> From: Willem de Bruijn
> Date: Mon, 6 Mar 2017 12:50:19 -0500
>
> >>> drivers/net/virtio_net.c | 73
> >>>
> >>> 1 file changed, 61 insertions(+), 12 deletions(-)
> >>>
> >>> diff -
Hi,
sorry, I decided now to take a look into the patch... Currently I have
no time to do anything... normally. That's why I simple said "everything
okay" in irc.
On 03/02/2017 02:23 PM, Luiz Augusto von Dentz wrote:
> From: Luiz Augusto von Dentz
>
> According to RFC 7668 U/L bit shall not be
From: Eric Dumazet
__sk_dst_set() must be called while we own the socket.
We can get proper lockdep coverage using lockdep_sock_is_held()
and rcu_dereference_protected()
Signed-off-by: Eric Dumazet
---
include/net/sock.h |7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --
On Fri, Mar 03, 2017 at 09:39:05AM -0500, Willem de Bruijn wrote:
> From: Willem de Bruijn
>
> Add napi for virtio-net transmit completion processing. Based on
> previous patchsets by Jason Wang:
>
> [RFC V7 PATCH 0/7] enable tx interrupts for virtio-net
> http://lkml.iu.edu/hypermail/linux/
On Mon, Mar 6, 2017 at 2:33 PM, Michael S. Tsirkin wrote:
> On Mon, Mar 06, 2017 at 10:55:22AM -0800, David Miller wrote:
>> From: Willem de Bruijn
>> Date: Mon, 6 Mar 2017 12:50:19 -0500
>>
>> >>> drivers/net/virtio_net.c | 73
>> >>>
>> >>> 1
Hi Marc,
On 03/06/2017 11:53 AM, Marc Kleine-Budde wrote:
On 03/06/2017 03:21 AM, Wenyou Yang wrote:
Enables the transmission of CAN FD frames on M_CAN IP core >= v3.1.x
and with the bit rate switching.
Tested on M_CAN IP 3.1.0 (CREL = 0x31040730) of SAMA5D2 SoC.
Does this patch work still w
From: Willem de Bruijn
Date: Mon, 6 Mar 2017 12:50:19 -0500
>>> drivers/net/virtio_net.c | 73
>>>
>>> 1 file changed, 61 insertions(+), 12 deletions(-)
>>>
>>> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
>>> index 8c21e9a4a
From: Daniel Borkmann
Date: Mon, 06 Mar 2017 19:35:47 +0100
> I can do a few more tests with the kernel I have. I'm also totally
> fine if we drop this patch; it's just rc1, so there's plenty of time
> till a final release.
I would really prefer we get to the bottom of this rather than apply
the
On Mon, Mar 6, 2017 at 6:31 PM, David Ahern wrote:
> On 3/4/17 1:15 PM, Eric Dumazet wrote:
>> On Sat, 2017-03-04 at 19:57 +0100, Dmitry Vyukov wrote:
>>> On Fri, Mar 3, 2017 at 8:12 PM, David Ahern
>>> wrote:
On 3/3/17 6:39 AM, Dmitry Vyukov wrote:
> I am getting heap out-of-bounds rep
KMSAN (KernelMemorySanitizer, a new error detection tool) reports use of
uninitialized memory in selinux_socket_bind():
==
BUG: KMSAN: use of unitialized memory
inter: 0
CPU: 3 PID: 1074 Comm: packet2 Tainted: GB 4.8.0-r
On 03/06/2017 09:21 AM, Elena Reshetova wrote:
> refcount_t type and corresponding API should be
> used instead of atomic_t when the variable is used as
> a reference counter. This allows to avoid accidental
> refcounter overflows that might lead to use-after-free
> situations.
>
> Signed-off-by: E
On Fri, Mar 3, 2017 at 7:23 PM, Daniel Borkmann wrote:
> Since d2852a224050 ("arch: add ARCH_HAS_SET_MEMORY config") and
> 9d876e79df6a ("bpf: fix unlocking of jited image when module ronx
> not set") that uses the former, Fengguang reported random corruptions
> on his i386 test machine [1]. On i3
On 03/06/2017 07:11 PM, Kees Cook wrote:
On Fri, Mar 3, 2017 at 7:23 PM, Daniel Borkmann wrote:
Since d2852a224050 ("arch: add ARCH_HAS_SET_MEMORY config") and
9d876e79df6a ("bpf: fix unlocking of jited image when module ronx
not set") that uses the former, Fengguang reported random corruptions
From: Jiri Kosina
Date: Mon, 6 Mar 2017 12:03:38 +0100 (CET)
> Ah, right you are, thanks. The complete fix is not super trivial, as it
> needs some more surgery to tc_dump_qdisc_root(), tc_dump_tclass_root() and
> qdisc_match_from_root() (see 69012ae42 for some details).
>
> There are two opti
On Sun, Mar 5, 2017 at 10:42 PM, Eric Dumazet wrote:
> On Sun, 2017-03-05 at 21:38 -0800, Cong Wang wrote:
>
>> Do you really want to disable BH again here?
>>
>> dccp_check_req() should be always called on RX path where BH
>> is already disabled and BH can't be disabled twice?
>
> What makes you
On Mon, Mar 6, 2017 at 12:13 PM, chetan loke wrote:
>>>
>>> Gosh. Can we also replace this BUG() into something less aggressive ?
>>
>>
>> There are currently 5 of these WARN() + BUG() constructs and 1 BUG()-only
>> for the 'default' TPACKET version spread all over af_packet, so probably
>> makes
>> +static void virtnet_poll_cleantx(struct receive_queue *rq)
>> +{
>> + struct virtnet_info *vi = rq->vq->vdev->priv;
>> + unsigned int index = vq2rxq(rq->vq);
>> + struct send_queue *sq = &vi->sq[index];
>> + struct netdev_queue *txq = netdev_get_tx_queue(vi->dev, index);
On Mon, Mar 6, 2017 at 12:43 PM, Willem de Bruijn
wrote:
>>> +static void virtnet_poll_cleantx(struct receive_queue *rq)
>>> +{
>>> + struct virtnet_info *vi = rq->vq->vdev->priv;
>>> + unsigned int index = vq2rxq(rq->vq);
>>> + struct send_queue *sq = &vi->sq[index];
>>> +
>> drivers/net/virtio_net.c | 73
>>
>> 1 file changed, 61 insertions(+), 12 deletions(-)
>>
>> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
>> index 8c21e9a4adc7..9a9031640179 100644
>> --- a/drivers/net/virtio_net.c
>> +++ b/
KASAN detected a use-after-free:
[ 269.467067] BUG: KASAN: use-after-free in vrf_xmit+0x7f1/0x827 [vrf] at addr
8800350a21c0
[ 269.467067] Read of size 4 by task ssh/1879
[ 269.467067] CPU: 1 PID: 1879 Comm: ssh Not tainted 4.10.0+ #249
[ 269.467067] Hardware name: QEMU Standard PC (i440F
>>
>> Gosh. Can we also replace this BUG() into something less aggressive ?
>
>
> There are currently 5 of these WARN() + BUG() constructs and 1 BUG()-only
> for the 'default' TPACKET version spread all over af_packet, so probably
> makes sense to rather make all of them less aggressive.
>
>
Very
On Mon, Mar 6, 2017 at 4:28 AM, Jason Wang wrote:
>
>
> On 2017年03月03日 22:39, Willem de Bruijn wrote:
>>
>> +void vhost_signal(struct vhost_dev *dev, struct vhost_virtqueue *vq);
>> +static enum hrtimer_restart vhost_coalesce_timer(struct hrtimer *timer)
>> +{
>> + struct vhost_virtqueue *vq
On 3/4/17 1:15 PM, Eric Dumazet wrote:
> On Sat, 2017-03-04 at 19:57 +0100, Dmitry Vyukov wrote:
>> On Fri, Mar 3, 2017 at 8:12 PM, David Ahern wrote:
>>> On 3/3/17 6:39 AM, Dmitry Vyukov wrote:
I am getting heap out-of-bounds reports in
fib6_clean_node/rt6_fill_node/fib6_age/fib6_prune_
On Tue, Feb 28, 2017 at 02:09:24PM -0800, Joe Perches wrote:
> Logging output was changed when simple printks without KERN_CONT
> are now emitted on a new line and KERN_CONT is required to continue
> lines so use pr_cont.
>
> Miscellanea:
>
> o realign arguments
> o use print_hex_dump instead of
On Tue, Feb 28, 2017 at 11:31:15AM +, Colin King wrote:
> From: Colin Ian King
>
> ret is initialized to zero and if it is set to non-zero in the
> xt_entry_foreach loop then we exit via the out_free label. Hence
> the check for ret being non-zero is redundant and can be removed.
>
> Detecte
On Fri, Feb 24, 2017 at 11:55:37AM -0800, Stephen Hemminger wrote:
> The concept is fine.
Thanks for taking a look.
> Please add some comments to the code about what is happening and why.
> The proposed patch is too sparse and has no comments.
Sure, will do that for the next version.
> > + sk
On 06/03/17 18:24, David Ahern wrote:
> On 3/6/17 7:59 AM, Nikolay Aleksandrov wrote:
>> diff --git a/include/net/route.h b/include/net/route.h
>> index c0874c87c173..77a5c613a290 100644
>> --- a/include/net/route.h
>> +++ b/include/net/route.h
>> @@ -113,13 +113,12 @@ struct in_device;
>> int ip_
Arend Van Spriel writes:
> On 2-3-2017 17:38, Arnd Bergmann wrote:
>> With KASAN and a couple of other patches applied, this driver is one
>> of the few remaining ones that actually use more than 2048 bytes of
>> kernel stack:
>>
>> broadcom/brcm80211/brcmsmac/phy/phy_n.c: In function
>> 'wlc_p
Arend Van Spriel writes:
> On 2-3-2017 17:38, Arnd Bergmann wrote:
>> In the previous commit I left the indentation alone to help reviewing
>> the patch, this one now runs the three new functions through 'indent -kr -8'
>> with some manual fixups to avoid silliness.
>>
>> No changes other than w
On 06/03/17 12:57, Sunil Kovvuri wrote:
>>>
>>> We are seeing a 0.75Mpps drop with IP forwarding rate due to that.
>>> Hence I have restricted calling DMA interfaces to only when IOMMU is
>>> enabled.
>>
>> What's 0.07Mpps as a percentage of baseline? On a correctly configured
>> coherent arm64 sy
Hello.
On 03/06/2017 05:20 PM, Elena Reshetova wrote:
refcount_t type and corresponding API should be
used instead of atomic_t when the variable is used as
a reference counter. This allows to avoid accidental
refcounter overflows that might lead to use-after-free
situations.
Signed-off-by: Ele
On Mon, 2017-03-06 at 05:45 -0800, Eric Dumazet wrote:
> On Mon, 2017-03-06 at 14:33 +0800, Daniel J Blueman wrote:
> > I do change the network queueing discipline and related at runtime [1]
> > which may be triggering this, though I did think I saw the KASAN
> > report only after resuming from su
On 3/6/17 7:59 AM, Nikolay Aleksandrov wrote:
> diff --git a/include/net/route.h b/include/net/route.h
> index c0874c87c173..77a5c613a290 100644
> --- a/include/net/route.h
> +++ b/include/net/route.h
> @@ -113,13 +113,12 @@ struct in_device;
> int ip_rt_init(void);
> void rt_cache_flush(struct n
Hello.docx
Description: MS-Word 2007 document
Tue, Feb 21, 2017 at 07:50:53PM CET, t...@herbertland.com wrote:
>On Tue, Feb 21, 2017 at 6:33 AM, Jiri Pirko wrote:
>> From: Jiri Pirko
>>
>> Make the main flow_dissect function a bit smaller and move the ARP
>> dissection into a separate function. Along with that, do the ARP header
>> processin
From: Jiri Pirko
Now, when an unexpected element in the GRE header appears, we break so
the l4 ports are processed. But since the ports are processed
unconditionally, there will be certainly random values dissected. Fix
this by just bailing out in such situations.
Signed-off-by: Jiri Pirko
---
From: Jiri Pirko
Make the main flow_dissect function a bit smaller and move the GRE
dissection into a separate function.
Signed-off-by: Jiri Pirko
---
net/core/flow_dissector.c | 244 +-
1 file changed, 134 insertions(+), 110 deletions(-)
diff --git
From: Jiri Pirko
Make the main flow_dissect function a bit smaller and move the MPLS
dissection into a separate function. Along with that, do the MPLS header
processing only in case the flow dissection user requires it.
Signed-off-by: Jiri Pirko
---
net/core/flow_dissector.c | 56 +
From: Jiri Pirko
This patchset follows-up the discussion about future extensions of flow
dissector and tries to address the mentioned concerns. Some parts are
cut out into sub-functions. Also, the processing of the code (ARP, MPLS)
is made dependent on user actually requiring the bisected values.
From: Jiri Pirko
Align with "ip_proto_again" label used in the same function and rename
vague "again" to "proto_again".
Signed-off-by: Jiri Pirko
---
net/core/flow_dissector.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/net/core/flow_dissector.c b/net/core/flow_
From: Jiri Pirko
Make the main flow_dissect function a bit smaller and move the ARP
dissection into a separate function. Along with that, do the ARP header
processing only in case the flow dissection user requires it.
Signed-off-by: Jiri Pirko
---
net/core/flow_dissector.c | 120 ++
On 03/06/2017 03:21 PM, Elena Reshetova wrote:
> refcount_t type and corresponding API should be
> used instead of atomic_t when the variable is used as
> a reference counter. This allows to avoid accidental
> refcounter overflows that might lead to use-after-free
> situations.
The subject is wron
refcount_t type and corresponding API should be
used instead of atomic_t when the variable is used as
a reference counter. This allows to avoid accidental
refcounter overflows that might lead to use-after-free
situations.
Signed-off-by: Elena Reshetova
Signed-off-by: Hans Liljestrand
Signed-off-
Lockdep issues a circular dependency warning when AFS issues an operation
through AF_RXRPC from a context in which the VFS/VM holds the mmap_sem.
The theory lockdep comes up with is as follows:
(1) If the pagefault handler decides it needs to read pages from AFS, it
calls AFS with mmap_sem
This patch adds support for ECMP hash policy choice via a new sysctl
called fib_multipath_hash_policy and also adds support for L4 hashes.
The current values for fib_multipath_hash_policy are:
0 - layer 3
1 - layer 4 (new default)
If there's an skb hash already set and it matches the chosen polic
On 6 March 2017 at 21:00, Arend Van Spriel wrote:
> + linux-wireless
>
> On 6-3-2017 8:14, Daniel J Blueman wrote:
>> KASAN reported 'struct wireless_dev wdev' was read after being freed.
>> Fix by freeing after the access.
>
> I would rather like to see the KASAN report, because something is off
Peter Senna Tschudin writes:
> On Sun, Feb 26, 2017 at 08:24:22PM +0100, Romain Perier wrote:
>> The PCI pool API is deprecated. This commits replaces the PCI pool old
>> API by the appropriated function with the DMA pool API.
>>
> Reviewed-by: Peter Senna Tschudin
Fine by me:
Acked-by: Felipe
It is too late to check for the limit of the number of VF multicast
addresses after they have already been copied to the req->multicast[]
array, possibly overflowing it.
Do the check before copying.
Checking early also avoids having to (and forgetting to) unlock
vf2pf_mutex.
While we're looking
refcount_t type and corresponding API should be
used instead of atomic_t when the variable is used as
a reference counter. This allows to avoid accidental
refcounter overflows that might lead to use-after-free
situations.
Signed-off-by: Elena Reshetova
Signed-off-by: Hans Liljestrand
Signed-off-
refcount_t type and corresponding API should be
used instead of atomic_t when the variable is used as
a reference counter. This allows to avoid accidental
refcounter overflows that might lead to use-after-free
situations.
Signed-off-by: Elena Reshetova
Signed-off-by: Hans Liljestrand
Signed-off-
1 - 100 of 171 matches
Mail list logo
