[PATCH v2] net: stmmac: Fix wrong message in stmmac_probe_config_dt

2017-02-01 Thread Heiner Kallweit
Most likely a copy & paste error in referenced commit. Restore the debug message to what it was before. Fixes: f573c0b9c4e0 ("stmmac: move stmmac_clk, pclk, clk_ptp_ref and stmmac_rst to platform structure") Signed-off-by: Heiner Kallweit --- v2: - Don't remove the wrong comment but replace it w

Re: [PATCH] net: stmmac: Remove wrong message in stmmac_probe_config_dt

2017-02-01 Thread Heiner Kallweit
Am 02.02.2017 um 03:20 schrieb Phil Reid: > On 2/02/2017 05:05, Heiner Kallweit wrote: >> I can only imagine that this message ended up there by a copy & paste >> mistake. The same message appears correctly a few lines later, but >> here it doesn't make sense. >> >> Signed-off-by: Heiner Kallweit

[PATCH net-next] cxgb4: Fix uld_send() for ctrl pkts

2017-02-01 Thread Ganesh Goudar
From: Arjun V Without any uld being loaded, uld_txq_info[] will be NULL. uld_send() is also used for sending control work requests(for eg: setting filter) that dont require any ulds to be loaded. Hence move uld_txq_info[] assignment after ctrl_xmit(). Also added a NULL check for uld_txq_info[].

Re: [PATCH net-next v2 0/5] bridge: per vlan dst_metadata support

2017-02-01 Thread Stephen Hemminger
On Wed, 01 Feb 2017 21:58:25 -0800 Roopa Prabhu wrote: > On 2/1/17, 5:23 PM, Alexei Starovoitov wrote: > > On Tue, Jan 31, 2017 at 10:59:50PM -0800, Roopa Prabhu wrote: > > > > [snip] > > >> Solution in this patch series: > >> The Goal is to use a single vxlan device to carry all vnis similar

Re: [PATCH v2 3/4] phy: Add USB3 PHY support for Broadcom NSP SoC

2017-02-01 Thread Rafał Miłecki
[Resending with fixed/complete Cc-s] On Tue, 17 Jan 2017 11:14:29 -0500, Yendapally Reddy Dhananjaya Reddy wrote:> This patch adds support for Broadcom NSP USB3 PHY > > Signed-off-by: Yendapally Reddy Dhananjaya Reddy Seriously?! I really dislike what you did there. NACK. You are aware th

Re: [PATCH net-next v2 0/5] bridge: per vlan dst_metadata support

2017-02-01 Thread Roopa Prabhu
On 2/1/17, 5:23 PM, Alexei Starovoitov wrote: > On Tue, Jan 31, 2017 at 10:59:50PM -0800, Roopa Prabhu wrote: > [snip] >> Solution in this patch series: >> The Goal is to use a single vxlan device to carry all vnis similar >> to the vxlan collect metadata mode but additionally allowing the bridge

Re: [PATCH net-next v2 0/5] bridge: per vlan dst_metadata support

2017-02-01 Thread Roopa Prabhu
On 2/1/17, 8:04 PM, Stephen Hemminger wrote: > On Wed, 01 Feb 2017 20:02:35 -0800 > Roopa Prabhu wrote: > >> On 2/1/17, 5:59 PM, David Ahern wrote: >>> On 2/1/17 6:23 PM, Alexei Starovoitov wrote: On Tue, Jan 31, 2017 at 10:59:50PM -0800, Roopa Prabhu wrote: > >>>

Re: [PATCH 1/2] Documentation: devicetree: change the mediatek ethernet compatible string

2017-02-01 Thread James Liao
On Wed, 2017-01-25 at 09:20 +0100, John Crispin wrote: > When the binding was defined, I was not aware that mt2701 was an earlier > version of the SoC. For sake of consistency, the ethernet driver should > use mt2701 inside the compat string as this is the earliest SoC with the > ethernet core. >

Re: [PATCH 2/2] net-next: ethernet: mediatek: change the compatible string

2017-02-01 Thread James Liao
On Wed, 2017-01-25 at 09:20 +0100, John Crispin wrote: > When the binding was defined, I was not aware that mt2701 was an earlier > version of the SoC. For sake of consistency, the ethernet driver should > use mt2701 inside the compat string as this is the earliest SoC with the > ethernet core. >

[PATCH net-next] net: add LINUX_MIB_PFMEMALLOCDROP counter

2017-02-01 Thread Eric Dumazet
From: Eric Dumazet Debugging issues caused by pfmemalloc is often tedious. Add a new SNMP counter to more easily diagnose these problems. Signed-off-by: Eric Dumazet Cc: Josef Bacik --- include/uapi/linux/snmp.h |1 + net/core/filter.c |5 +++-- net/ipv4/proc.c |

Re: [PATCH net-next v2 0/5] bridge: per vlan dst_metadata support

2017-02-01 Thread Stephen Hemminger
On Wed, 01 Feb 2017 20:02:35 -0800 Roopa Prabhu wrote: > On 2/1/17, 5:59 PM, David Ahern wrote: > > On 2/1/17 6:23 PM, Alexei Starovoitov wrote: > >> On Tue, Jan 31, 2017 at 10:59:50PM -0800, Roopa Prabhu wrote: > >>> > >>> This provides the required vxlan bridging functi

Re: [PATCH net-next v2 0/5] bridge: per vlan dst_metadata support

2017-02-01 Thread Roopa Prabhu
On 2/1/17, 5:59 PM, David Ahern wrote: > On 2/1/17 6:23 PM, Alexei Starovoitov wrote: >> On Tue, Jan 31, 2017 at 10:59:50PM -0800, Roopa Prabhu wrote: >>> >>> This provides the required vxlan bridging function but poses a >>> scalability problem with using a separate vxlan netd

Re: [net-next ovs clone action 3/3] openvswitch: kernel datapath clone action

2017-02-01 Thread Andy Zhou
On Wed, Feb 1, 2017 at 6:30 PM, Pravin Shelar wrote: > On Tue, Jan 31, 2017 at 8:47 AM, Andy Zhou wrote: >> Add 'clone' kernel datapath support. In case the actions within clone >> do not modify the current flow, the actions are executed without >> making a copy of current key before execution. T

Re: [PATCH net] net: phy: Fix lack of reference count on PHY driver

2017-02-01 Thread Florian Fainelli
On 02/01/2017 11:10 AM, Russell King - ARM Linux wrote: > On Wed, Feb 01, 2017 at 01:59:38PM -0500, David Miller wrote: >> From: Florian Fainelli >> Date: Wed, 1 Feb 2017 10:55:46 -0800 >> >>> You are right, but there is still a fundamental problem IMHO in that you >>> should not be able to rmmod

Re: [PATCH net] net: phy: Fix lack of reference count on PHY driver

2017-02-01 Thread Florian Fainelli
On 02/01/2017 02:51 AM, Russell King - ARM Linux wrote: > It looks to me as if that's the only case where this can happen, so maybe > the above needs to be: > > if (phydev->drv && phydev->drv->link_change_notify) > phydev->drv->link_change_notify(phydev); > > Also, I'd sug

Re: [PATCH net-next] loopback: clear pfmemalloc on outgoing skb's

2017-02-01 Thread Eric Dumazet
On Wed, 2017-02-01 at 15:38 -0800, Eric Dumazet wrote: > I am not sure this is a proper fix. > > Presumably if the socket was able to store packets in its write queue, > fact that it sends it to loopback or an Ethernet link should not matter. > > Only in RX path the pfmemalloc thing is really im

[PATCH net-next] net: ipv4: remove fib_lookup.h from devinet.c include list

2017-02-01 Thread David Ahern
nothing in devinet.c relies on fib_lookup.h; remove it from the includes Signed-off-by: David Ahern --- net/ipv4/devinet.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c index 4cd2ee8857d2..5d367b7ff542 100644 --- a/net/ipv4/devinet.c +++ b/net/ipv4/

Re: [net-next ovs clone action 3/3] openvswitch: kernel datapath clone action

2017-02-01 Thread Pravin Shelar
On Tue, Jan 31, 2017 at 8:47 AM, Andy Zhou wrote: > Add 'clone' kernel datapath support. In case the actions within clone > do not modify the current flow, the actions are executed without > making a copy of current key before execution. This analysis is > done once per flow installation. > > On t

Re: [PATCH] net: stmmac: Remove wrong message in stmmac_probe_config_dt

2017-02-01 Thread Phil Reid
On 2/02/2017 05:05, Heiner Kallweit wrote: I can only imagine that this message ended up there by a copy & paste mistake. The same message appears correctly a few lines later, but here it doesn't make sense. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/stmicro/stmmac/stmmac_platform

Re: [PATCH net-next] net: phy: marvell: Add support for 88e1545 PHY

2017-02-01 Thread Florian Fainelli
On 02/01/2017 03:35 PM, Andrew Lunn wrote: > The 88e1545 PHYs are discrete Marvell PHYs, found in a quad package on > the zii-devel-b board. Add support for it to the Marvell PHY driver. > > Signed-off-by: Andrew Lunn Reviewed-by: Florian Fainelli -- Florian

[PATCH net-next] net: remove useless pfmemalloc setting

2017-02-01 Thread Eric Dumazet
From: Eric Dumazet When __alloc_skb() allocates an skb from fast clone cache, setting pfmemalloc on the clone is not needed. Clone will be properly initialized later at skb_clone() time, including pfmemalloc field, as it is included in the headers_start/headers_end section which is fully copied.

Re: [PATCH net-next v2 0/5] bridge: per vlan dst_metadata support

2017-02-01 Thread David Ahern
On 2/1/17 6:23 PM, Alexei Starovoitov wrote: > On Tue, Jan 31, 2017 at 10:59:50PM -0800, Roopa Prabhu wrote: >> >> This provides the required vxlan bridging function but poses a >> scalability problem with using a separate vxlan netdev for each vni. > if I remember correctly th

Re: [PATCH] net: phy: dp83867: Port mirroring support in the DP83867 TI's PHY driver

2017-02-01 Thread Andrew Lunn
On Wed, Feb 01, 2017 at 11:13:23PM +0100, Lukasz Majewski wrote: > Hi Andrew, > > > > We would need a tri-state device tree properly: > > > > > > 1. Not defined - do nothing > > > 2. Defined as 0 -> explicitly disable port mirroring > > > 3. Defined as 1 -> explicitly enable port mirriring > > >

linux-next: manual merge of the net-next tree with Linus' tree

2017-02-01 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: net/sched/cls_matchall.c between commit: fd62d9f5c575 ("net/sched: matchall: Fix configuration race") from Linus' tree and commit: ec2507d2a306 ("net/sched: cls_matchall: Fix error path") from the net-next tree.

Re: [PATCH net-next v2 0/5] bridge: per vlan dst_metadata support

2017-02-01 Thread Alexei Starovoitov
On Tue, Jan 31, 2017 at 10:59:50PM -0800, Roopa Prabhu wrote: > > This provides the required vxlan bridging function but poses a > scalability problem with using a separate vxlan netdev for each vni. if I remember correctly this issue was the main reason David Ahern put netdev

[PATCH iproute2] ss: print tcpi_rcv_mss

2017-02-01 Thread Eric Dumazet
From: Eric Dumazet tcpi_rcv_mss tcp info field was not yet reported by ss. While adding GRO support to packetdrill, I found this was useful. Signed-off-by: Eric Dumazet --- misc/ss.c |4 1 file changed, 4 insertions(+) diff --git a/misc/ss.c b/misc/ss.c index 4454bd1..6e4f84a 100644

Re: [PATCH 1/2] net: ethernet: bgmac: init sequence bug

2017-02-01 Thread Zac Schroff
How about BCMA_IOCTL_PRESERVE_ACROSS_INIT? On Wed, Feb 1, 2017 at 6:06 PM, Rafał Miłecki wrote: > On 02/01/2017 11:39 PM, Jon Mason wrote: >> >> From: Zac Schroff >> >> Fix a bug in the 'bgmac' driver init sequence that blind writes for init >> sequence where it should preserve most bits other t

Re: [PATCH] xen-netfront: Delete rx_refill_timer in xennet_disconnect_backend()

2017-02-01 Thread Eric Dumazet
On Wed, 2017-02-01 at 18:29 -0500, Boris Ostrovsky wrote: > > I could not convince myself that napi_synchronize() is sufficient here > (mostly because I am not familiar with napi flow). At the same time I > would rather not make changes in anticipation of possible disappearance > of netif_carrier

Re: net: suspicious RCU usage in nf_hook

2017-02-01 Thread Eric Dumazet
On Wed, 2017-02-01 at 15:48 -0800, Eric Dumazet wrote: > On Wed, Feb 1, 2017 at 3:29 PM, Cong Wang wrote: > > > Not sure if it is better. The difference is caught up in > > net_enable_timestamp(), > > which is called setsockopt() path and sk_clone() path, so we could be > > in netstamp_needed st

Re: [PATCH net-next] loopback: clear pfmemalloc on outgoing skb's

2017-02-01 Thread Eric Dumazet
On Wed, 2017-02-01 at 15:38 -0800, Eric Dumazet wrote: > On Wed, 2017-02-01 at 16:04 -0500, Josef Bacik wrote: > > I was seeing random disconnects while testing NBD over loopback. This > > turned > > out to be because NBD sets pfmemalloc on it's socket, however the receiving > > side > > is a us

Re: net: suspicious RCU usage in nf_hook

2017-02-01 Thread Eric Dumazet
On Wed, Feb 1, 2017 at 3:29 PM, Cong Wang wrote: > Not sure if it is better. The difference is caught up in > net_enable_timestamp(), > which is called setsockopt() path and sk_clone() path, so we could be > in netstamp_needed state for a long time too until user-space exercises > these paths. >

Re: [net-next 1/8] net/mlx5: Fixed static checker warnings

2017-02-01 Thread Or Gerlitz
On Wed, Feb 1, 2017 at 7:22 PM, David Miller wrote: [..] > You're propagating values into a u32 field, which you are explicitly > performing 32-bit endianness conversions upon. > Just use "u32" for a local variable and get rid of all of these casts. ok, will do that

[PATCHv2 net-next 0/2] MV88E6390 fixes

2017-02-01 Thread Andrew Lunn
Two patches, which have been posted before. Fix simple issues in the mv88e6390 support. These don't need to go to stable, since the mv88e6390 support in stable is insufficient to be usable. To apply cleanly, these patches rely on "net: dsa: mv88e6xxx: Workaround missing PHY". v2: Added Reviewed-b

[PATCHv2 net-next 1/2] net: dsa: mv88e6xxx: Fix ATU age timer for MV88E6390

2017-02-01 Thread Andrew Lunn
The MV88E6390 family uses a different ATU age timer coefficient. Fix the info structures. Signed-off-by: Andrew Lunn Reviewed-by: Vivien Didelot --- v2: Remove redundant "the". Add Reviewed-by --- drivers/net/dsa/mv88e6xxx/chip.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletio

[PATCHv2 net-next 2/2] net: dsa: mv88e6xxx: Fix typ0 when configuring 2.5Gbps

2017-02-01 Thread Andrew Lunn
In order to enable 2.5Gbps mode, we need the base speed of 10G, plus the Alt bit setting. Fix a typ0 that used 1Gb base speed. Signed-off-by: Andrew Lunn Reviewed-by: Vivien Didelot --- v2: Add Reviewed-by --- drivers/net/dsa/mv88e6xxx/port.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-

Re: [PATCH net-next] loopback: clear pfmemalloc on outgoing skb's

2017-02-01 Thread Eric Dumazet
On Wed, 2017-02-01 at 16:04 -0500, Josef Bacik wrote: > I was seeing random disconnects while testing NBD over loopback. This turned > out to be because NBD sets pfmemalloc on it's socket, however the receiving > side > is a user space application so does not have pfmemalloc set on its socket.

[PATCH net-next] net: phy: marvell: Add support for 88e1545 PHY

2017-02-01 Thread Andrew Lunn
The 88e1545 PHYs are discrete Marvell PHYs, found in a quad package on the zii-devel-b board. Add support for it to the Marvell PHY driver. Signed-off-by: Andrew Lunn --- NOTE: To apply cleanly, the "Work around missing PHY product ID in mv88e6390" patches need to be applied first. drivers/net/

Re: net: suspicious RCU usage in nf_hook

2017-02-01 Thread Cong Wang
On Wed, Feb 1, 2017 at 1:16 PM, Eric Dumazet wrote: > On Wed, 2017-02-01 at 12:51 -0800, Cong Wang wrote: >> On Tue, Jan 31, 2017 at 7:44 AM, Eric Dumazet wrote: >> > On Mon, 2017-01-30 at 22:19 -0800, Cong Wang wrote: >> > >> >> >> >> The context is process context (TX path before hitting qdisc)

Re: [PATCH] xen-netfront: Delete rx_refill_timer in xennet_disconnect_backend()

2017-02-01 Thread Boris Ostrovsky
On 01/31/2017 12:47 PM, Boris Ostrovsky wrote: > On 01/30/2017 02:31 PM, Boris Ostrovsky wrote: >> On 01/30/2017 02:06 PM, Eric Dumazet wrote: >>> On Mon, 2017-01-30 at 13:23 -0500, Boris Ostrovsky wrote: >>> We do netif_carrier_off() first thing in xennet_disconnect_backend() and the onl

[PATCH] wcn36xx: Implement cancel_hw_scan

2017-02-01 Thread Bjorn Andersson
In the even that the wcn36xx interface is brought down while a hw_scan is active we must abort and wait for the ongoing scan to signal completion to mac80211. Reported-by: Mart Raudsepp Fixes: 886039036c20 ("wcn36xx: Implement firmware assisted scan") Signed-off-by: Bjorn Andersson --- drivers/

Re: [PATCH 1/2] net: ethernet: bgmac: init sequence bug

2017-02-01 Thread Rafał Miłecki
On 02/01/2017 11:39 PM, Jon Mason wrote: From: Zac Schroff Fix a bug in the 'bgmac' driver init sequence that blind writes for init sequence where it should preserve most bits other than the ones it is deliberately manipulating. Signed-off-by: Zac Schroff Signed-off-by: Jon Mason Fixes: f6a9

Re: [PATCHv3 net-next 5/7] net: add confirm_neigh method to dst_ops

2017-02-01 Thread Julian Anastasov
Hello, On Wed, 1 Feb 2017, Steffen Klassert wrote: > On Tue, Jan 31, 2017 at 11:57:05PM +0200, Julian Anastasov wrote: > > > > +static void xfrm_confirm_neigh(const struct dst_entry *dst, const void > > *daddr) > > +{ > > + const struct dst_entry *path = dst->path; > > + > > + if

[PATCH 2/2] net: ethernet: bgmac: mac address change bug

2017-02-01 Thread Jon Mason
From: Hari Vyas ndo_set_mac_address() passes struct sockaddr * as 2nd parameter to bgmac_set_mac_address() but code assumed u8 *. This caused two bytes chopping and the wrong mac address was configured. Signed-off-by: Hari Vyas Signed-off-by: Jon Mason Fixes: 4e209001b86 ("bgmac: write mac ad

[PATCH 0/2] net: ethernet: bgmac: bug fixes

2017-02-01 Thread Jon Mason
Bug fixes for bgmac driver Hari Vyas (1): net: ethernet: bgmac: mac address change bug Zac Schroff (1): net: ethernet: bgmac: init sequence bug drivers/net/ethernet/broadcom/bgmac-platform.c | 10 +++--- drivers/net/ethernet/broadcom/bgmac.c | 6 +- include/linux/bcma/bcma

[PATCH 1/2] net: ethernet: bgmac: init sequence bug

2017-02-01 Thread Jon Mason
From: Zac Schroff Fix a bug in the 'bgmac' driver init sequence that blind writes for init sequence where it should preserve most bits other than the ones it is deliberately manipulating. Signed-off-by: Zac Schroff Signed-off-by: Jon Mason Fixes: f6a95a24957 ("net: ethernet: bgmac: Add platfor

[PATCH v7 3/3] Bluetooth: btusb: Configure Marvell to use one of the pins for oob wakeup

2017-02-01 Thread Rajat Jain
The Marvell devices may have many gpio pins, and hence for wakeup on these out-of-band pins, the chip needs to be told which pin is to be used for wakeup, using an hci command. Thus, we read the pin number etc from the device tree node and send a command to the chip. Signed-off-by: Rajat Jain Re

[PATCH v7 2/3] Bluetooth: btusb: Add out-of-band wakeup support

2017-02-01 Thread Rajat Jain
Some onboard BT chips (e.g. Marvell 8997) contain a wakeup pin that can be connected to a gpio on the CPU side, and can be used to wakeup the host out-of-band. This can be useful in situations where the in-band wakeup is not possible or not preferable (e.g. the in-band wakeup may require the USB ho

[PATCH v7 1/3] Bluetooth: btusb: Use an error label for error paths

2017-02-01 Thread Rajat Jain
Use a label to remove the repetetive cleanup, for error cases. Signed-off-by: Rajat Jain Reviewed-by: Brian Norris --- v7: same as v6 v6: same as v5 v5: same as v4 v4: same as v3 v3: Added Brian's "Reviewed-by" v2: same as v1 drivers/bluetooth/btusb.c | 19 +-- 1 file changed,

Re: [PATCH] net: phy: dp83867: Port mirroring support in the DP83867 TI's PHY driver

2017-02-01 Thread Lukasz Majewski
Hi Andrew, > > We would need a tri-state device tree properly: > > > > 1. Not defined - do nothing > > 2. Defined as 0 -> explicitly disable port mirroring > > 3. Defined as 1 -> explicitly enable port mirriring > > > > The "net-phy-lane-swap" only fulfills points 1 and 3 above. > > > > In my u

Re: [PATCH v2 2/4] net: phy: Initialize mdio clock at probe function

2017-02-01 Thread Florian Fainelli
On 01/17/2017 08:14 AM, Yendapally Reddy Dhananjaya Reddy wrote: > Initialize mdio clock divisor in probe function. The ext bus > bit available in the same register will be used by mdio mux > to enable external mdio. > > Signed-off-by: Yendapally Reddy Dhananjaya Reddy > David, this patch shoul

Re: net: suspicious RCU usage in nf_hook

2017-02-01 Thread Eric Dumazet
On Wed, 2017-02-01 at 13:16 -0800, Eric Dumazet wrote: > This would permanently leave the kernel in the netstamp_needed state. > > I would prefer the patch using a process context to perform the > cleanup ? Note there is a race window, but probably not a big deal. > > net/core/dev.c | 30

Re: net: suspicious RCU usage in nf_hook

2017-02-01 Thread Eric Dumazet
On Wed, 2017-02-01 at 12:51 -0800, Cong Wang wrote: > On Tue, Jan 31, 2017 at 7:44 AM, Eric Dumazet wrote: > > On Mon, 2017-01-30 at 22:19 -0800, Cong Wang wrote: > > > >> > >> The context is process context (TX path before hitting qdisc), and > >> BH is not disabled, so in_interrupt() doesn't cat

Re: [PATCH] net: phy: dp83867: Port mirroring support in the DP83867 TI's PHY driver

2017-02-01 Thread Andrew Lunn
> What a poorly chosen name though... in Ethernet world, port mirroring > means the ability to capture traffic from a vector of ports and copying > it verbatim (or sampled) towards a capture port, aka the mirror port... Ack. We should avoid "port mirroring" in what ever patch we decide upon.

Re: [PATCH] net: phy: dp83867: Port mirroring support in the DP83867 TI's PHY driver

2017-02-01 Thread Andrew Lunn
> We would need a tri-state device tree properly: > > 1. Not defined - do nothing > 2. Defined as 0 -> explicitly disable port mirroring > 3. Defined as 1 -> explicitly enable port mirriring > > The "net-phy-lane-swap" only fulfills points 1 and 3 above. > > In my use case I do need point 2. Lo

Re: [PATCH] net: phy: dp83867: Port mirroring support in the DP83867 TI's PHY driver

2017-02-01 Thread Florian Fainelli
On 02/01/2017 01:05 PM, Lukasz Majewski wrote: > Dear All, > > Thanks for prompt reply. > >> On 02/01/2017 09:16 AM, Andrew Lunn wrote: >>> On Wed, Feb 01, 2017 at 03:43:35PM +0100, Lukasz Majewski wrote: This patch adds support for enabling or disabling the port mirroring feature of th

[PATCH] net: stmmac: Remove wrong message in stmmac_probe_config_dt

2017-02-01 Thread Heiner Kallweit
I can only imagine that this message ended up there by a copy & paste mistake. The same message appears correctly a few lines later, but here it doesn't make sense. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 1 - 1 file changed, 1 deletion(-) diff

Re: [PATCH] net: phy: dp83867: Port mirroring support in the DP83867 TI's PHY driver

2017-02-01 Thread Lukasz Majewski
Dear All, Thanks for prompt reply. > On 02/01/2017 09:16 AM, Andrew Lunn wrote: > > On Wed, Feb 01, 2017 at 03:43:35PM +0100, Lukasz Majewski wrote: > >> This patch adds support for enabling or disabling the port > >> mirroring feature of the DP83867 TI's PHY device. > >> > >> One use case is whe

[PATCH] net: stmmac: add separate warning for PTP not being supported by HW

2017-02-01 Thread Heiner Kallweit
Chips like Amlogic S905GXBB are supported by this driver but don't have support for PTP. Add a separate warning for missing HW support to differentiate it from other actual failures. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 6 -- 1 file changed,

[PATCH net-next] loopback: clear pfmemalloc on outgoing skb's

2017-02-01 Thread Josef Bacik
I was seeing random disconnects while testing NBD over loopback. This turned out to be because NBD sets pfmemalloc on it's socket, however the receiving side is a user space application so does not have pfmemalloc set on its socket. This means that sk_filter_trim_cap will simply drop this packet,

Re: [PATCH] stmmac: Discard masked flags in interrupt status register

2017-02-01 Thread David Miller
From: Alexey Brodkin Date: Wed, 1 Feb 2017 20:22:22 + > May we have that one back-ported to stable branches starting from 4.8.x? > > That issue started to appear due to a change from pr_debug() to pr_info() in > commit > 70523e639bf8 ("drivers: net: stmmac: reworking the PCS code."). Sure,

Re: net: suspicious RCU usage in nf_hook

2017-02-01 Thread Cong Wang
On Tue, Jan 31, 2017 at 7:44 AM, Eric Dumazet wrote: > On Mon, 2017-01-30 at 22:19 -0800, Cong Wang wrote: > >> >> The context is process context (TX path before hitting qdisc), and >> BH is not disabled, so in_interrupt() doesn't catch it. Hmm, this >> makes me thinking maybe we really need to di

RE: [PATCH] stmmac: Discard masked flags in interrupt status register

2017-02-01 Thread Alexey Brodkin
Hi David, all, > -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Monday, January 30, 2017 2:16 AM > To: alexey.brod...@synopsys.com > Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; > peppe.cavall...@st.com; fabrice.gasn...@st.com; manab...@gmail.com;

[GIT] Networking

2017-02-01 Thread David Miller
1) Fix handling of interrupt status in stmmac driver. Just because we have masked the event from generating interrupts, doesn't mean the bit won't still be set in the interrupt status register. From Alexey Brodkin. 2) Fix DMA API debugging splats in gianfar driver, from Arseny Solokha. 3

Re: [PATCH] net: phy: broadcom: rehook BCM54612E specific init

2017-02-01 Thread David Miller
From: Rafał Miłecki Date: Tue, 31 Jan 2017 22:54:54 +0100 > From: Rafał Miłecki > > This extra BCM54612E code in PHY driver isn't really aneg specific. Even > without it aneg works OK but the problem is no packets pass through PHY. > > Moreover putting this code inside config_aneg callback did

[PATCH] net: stmmac: don't set tx delay in RGMII_ID and RGMII_TXID mode

2017-02-01 Thread Heiner Kallweit
As documented in Documentation/devicetree/bindings/net/ethernet.txt, in RGMII_ID and RGMII_TXID mode the MAC should not add a tx delay. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) d

Re: [PATCH net-next 0/5] bridge: per vlan dst_metadata support

2017-02-01 Thread Roopa Prabhu
On 2/1/17, 8:35 AM, Stephen Hemminger wrote: > On Tue, 31 Jan 2017 12:43:19 -0800 > Roopa Prabhu wrote: > >> On 1/31/17, 8:41 AM, Stephen Hemminger wrote: [snip] >> But, this is just discouraging people from using the bridge driver. sorry, >> but i think it is a bit too late for that now :) >

Re: [PATCH net] net: phy: Fix lack of reference count on PHY driver

2017-02-01 Thread Russell King - ARM Linux
On Wed, Feb 01, 2017 at 01:59:38PM -0500, David Miller wrote: > From: Florian Fainelli > Date: Wed, 1 Feb 2017 10:55:46 -0800 > > > You are right, but there is still a fundamental problem IMHO in that you > > should not be able to rmmod a PHY driver as long as a network device is > > attached to

Re: [PATCH net-next 0/2] net/sched: act_sample: Little fixes

2017-02-01 Thread David Miller
From: Yotam Gigi Date: Tue, 31 Jan 2017 11:33:52 +0200 > Little fixes in sample tc action. Series applied, thanks.

Re: [PATCH 4.10-rc3 11/13] net: liquidio: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-02-01 Thread Felix Manlunas
Russell King wrote on Tue [2017-Jan-31 19:19:19 +]: > drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:30: error: expected > declaration specifiers or '...' before string constant > drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:30: warning: data > definition has no type or storage cl

Re: [PATCH] net: phy: dp83867: Port mirroring support in the DP83867 TI's PHY driver

2017-02-01 Thread Florian Fainelli
On 02/01/2017 09:16 AM, Andrew Lunn wrote: > On Wed, Feb 01, 2017 at 03:43:35PM +0100, Lukasz Majewski wrote: >> This patch adds support for enabling or disabling the port mirroring >> feature of the DP83867 TI's PHY device. >> >> One use case is when bootstrap configuration enables this feature (b

[PATCH net-next] unix: add ioctl to open a unix socket file with O_PATH

2017-02-01 Thread Andrei Vagin
This ioctl opens a file to which a socket is bound and returns a file descriptor. The caller has to have CAP_NET_ADMIN in the socket network namespace. Currently it is impossible to get a path and a mount point for a socket file. socket_diag reports address, device ID and inode number for unix soc

Re: [PATCH net] net: phy: Fix lack of reference count on PHY driver

2017-02-01 Thread David Miller
From: Florian Fainelli Date: Wed, 1 Feb 2017 10:55:46 -0800 > You are right, but there is still a fundamental problem IMHO in that you > should not be able to rmmod a PHY driver as long as a network device is > attached to the PHY, and if the PHY driver is attached from several > different networ

Re: [PATCH net] net: phy: Fix lack of reference count on PHY driver

2017-02-01 Thread Florian Fainelli
On 02/01/2017 02:51 AM, Russell King - ARM Linux wrote: > On Wed, Feb 01, 2017 at 10:22:08AM +, Russell King - ARM Linux wrote: >> On Tue, Jan 31, 2017 at 06:46:43PM -0800, Florian Fainelli wrote: >>> From: Mao Wenan >>> >>> There is currently no reference count being held on the PHY driver, >

Re: [PATCH] xen-netfront: Improve error handling during initialization

2017-02-01 Thread Boris Ostrovsky
On 02/01/2017 10:50 AM, Ross Lagerwall wrote: > Improve error handling during initialization. This fixes a crash when > running out of grant refs when creating many queues across many netdevs. > > * Delay timer creation so that if initializing a queue fails, the timer > has not been setup yet. > *

Re: [PATCH 0/2] sh_eth: fixes for MagicPacket handling

2017-02-01 Thread Niklas Söderlund
On 2017-02-01 12:54:41 -0500, David Miller wrote: > From: Niklas Söderlund > Date: Wed, 1 Feb 2017 15:41:53 +0100 > > > This series contain two fixes for MagicPacket handling. It's based on > > top of net-next and is tested on Koelsch. > > Series applied, thanks. > > I fixed the "register" --

Re: [PATCH v2 net-next] net: phy: Add LED mode driver for Microsemi

2017-02-01 Thread Florian Fainelli
On 02/01/2017 04:53 AM, Raju Lakkaraju wrote: > From: Raju Lakkaraju > > LED Mode: > Microsemi PHY support 2 LEDs (LED[0] and LED[1]) to display different > status information that can be selected by setting LED mode. Why is this LED selection done through Device Tree/initial configuration inste

Re: [PATCH v2 net-next] net: phy: Add LED mode driver for Microsemi PHYs.

2017-02-01 Thread Rob Herring
On Wed, Feb 01, 2017 at 06:23:46PM +0530, Raju Lakkaraju wrote: > From: Raju Lakkaraju > > LED Mode: > Microsemi PHY support 2 LEDs (LED[0] and LED[1]) to display different > status information that can be selected by setting LED mode. > > LED Mode parameter (vsc8531, led-0-mode) and (vsc8531, l

Re: [PATCH net] tcp: fix 0 divide in __tcp_select_window()

2017-02-01 Thread David Miller
From: Eric Dumazet Date: Wed, 01 Feb 2017 08:33:53 -0800 > From: Eric Dumazet > > syszkaller fuzzer was able to trigger a divide by zero, when > TCP window scaling is not enabled. > > SO_RCVBUF can be used not only to increase sk_rcvbuf, also > to decrease it below current receive buffers util

Re: [PATCH 0/2] sh_eth: fixes for MagicPacket handling

2017-02-01 Thread David Miller
From: Niklas Söderlund Date: Wed, 1 Feb 2017 15:41:53 +0100 > This series contain two fixes for MagicPacket handling. It's based on > top of net-next and is tested on Koelsch. Series applied, thanks. I fixed the "register" --> "registered" thing in the commit message for patch #2 when I appli

Re: pull-request: wireless-drivers-next 2017-02-01

2017-02-01 Thread David Miller
From: Kalle Valo Date: Wed, 01 Feb 2017 11:37:38 +0200 > here's a pull request to 4.11, more details in the signed tag below. > > I forgot to mention in the tag that this includes one small change to > include/linux/soc/qcom/smem_state.h which was acked by Andy Gross in > commit 6c0b2e833f14. It

Re: [patch net-next] ethernet: aquantia: fix dma_mapping_error test

2017-02-01 Thread David Miller
From: Dan Carpenter Date: Wed, 1 Feb 2017 11:52:15 +0300 > dma_mapping_error() returns 1 if there is an error and 0 if not. > > Fixes: 018423e90bee ("net: ethernet: aquantia: Add ring support code") > Signed-off-by: Dan Carpenter Applied, thanks Dan.

Re: [patch net-next] sfc: a couple off by one bugs

2017-02-01 Thread David Miller
From: Dan Carpenter Date: Wed, 1 Feb 2017 11:50:40 +0300 > These checks are off by one. These are just sanity checks and we don't > ever pass invalid values for "encap_type" so it's harmless. > > Fixes: 9b4108012517 ("sfc: insert catch-all filters for encapsulated traffic") > Signed-off-by: Dan

RE: sock_create_kern() and network namespace reference counts

2017-02-01 Thread David Laight
From: Cong Wang > Sent: 01 February 2017 17:20 > On Tue, Jan 31, 2017 at 9:57 AM, David Laight wrote: > > From: Cong Wang > >> Sent: 31 January 2017 17:38 > >> On Tue, Jan 31, 2017 at 7:41 AM, David Laight > >> wrote: > >> > Commit 26abe1437 changed sock_create_kern() so that it stopped > >> > h

Re: [patch] ipv6: pointer math error in ip6_tnl_parse_tlv_enc_lim()

2017-02-01 Thread David Miller
From: Dan Carpenter Date: Wed, 1 Feb 2017 11:46:32 +0300 > Casting is a high precedence operation but "off" and "i" are in terms of > bytes so we need to have some parenthesis here. > > Fixes: fbfa743a9d2a ("ipv6: fix ip6_tnl_parse_tlv_enc_lim()") > Signed-off-by: Dan Carpenter Applied, thanks

Re: [PATCH net-next] liquidio: fix for iq and droq cnts going negative

2017-02-01 Thread David Miller
From: Felix Manlunas Date: Tue, 31 Jan 2017 13:04:42 -0800 > From: Satanand Burla > > Flush the mmio writes before releasing spin locks. > if the maintained counts get too high > 2M force > writeback of the counts to clear them > > Signed-off-by: Satanand Burla > Signed-off-by: Felix Manlunas

Re: [net-next 1/8] net/mlx5: Fixed static checker warnings

2017-02-01 Thread David Miller
From: Saeed Mahameed Date: Tue, 31 Jan 2017 22:58:36 +0200 > @@ -487,11 +487,11 @@ static int __parse_cls_flower(struct mlx5e_priv *priv, > MLX5_SET(fte_match_set_lyr_2_4, headers_c, cvlan_tag, > 1); > MLX5_SET(fte_match_set_lyr_2_4, headers_v, cvlan_t

Re: sock_create_kern() and network namespace reference counts

2017-02-01 Thread Cong Wang
On Tue, Jan 31, 2017 at 9:57 AM, David Laight wrote: > From: Cong Wang >> Sent: 31 January 2017 17:38 >> On Tue, Jan 31, 2017 at 7:41 AM, David Laight >> wrote: >> > Commit 26abe1437 changed sock_create_kern() so that it stopped >> > holding a reference to the network namespace. >> > The rationa

Re: [PATCH] net: phy: dp83867: Port mirroring support in the DP83867 TI's PHY driver

2017-02-01 Thread Andrew Lunn
On Wed, Feb 01, 2017 at 03:43:35PM +0100, Lukasz Majewski wrote: > This patch adds support for enabling or disabling the port mirroring > feature of the DP83867 TI's PHY device. > > One use case is when bootstrap configuration enables this feature (because > of e.g. LED wiring) so then one needs t

Re: [PATCH net-next 0/2] net/sched: act_sample: Little fixes

2017-02-01 Thread Cong Wang
On Tue, Jan 31, 2017 at 1:33 AM, Yotam Gigi wrote: > Little fixes in sample tc action. > > Yotam Gigi (2): > net/sched: act_sample: Fix error path in init > net/sched: act_psample: Remove unnecessary ASSERT_RTNL > Acked-by: Cong Wang Thanks!

Re: [PATCH net-next] net: ipv6: add NLM_F_APPEND in notifications when applicable

2017-02-01 Thread David Miller
From: David Ahern Date: Tue, 31 Jan 2017 16:51:37 -0800 > IPv6 does not set the NLM_F_APPEND flag in notifications to signal that > a NEWROUTE is an append versus a new route or a replaced one. Add the > flag if the request has it. > > Signed-off-by: David Ahern > --- > sending this one outside

Re: [PATCH] net: fix ndo_features_check/ndo_fix_features comment ordering

2017-02-01 Thread David Miller
From: Dimitris Michailidis Date: Tue, 31 Jan 2017 16:03:13 -0800 > Commit cdba756f5803a2 ("net: move ndo_features_check() close to > ndo_start_xmit()") inadvertently moved the doc comment for > .ndo_fix_features instead of .ndo_features_check. Fix the comment > ordering. > > Fixes: cdba756f5803a

Re: [PATCH] net: ethernet: ti: cpsw: fix NULL pointer dereference in switch mode

2017-02-01 Thread David Miller
From: Grygorii Strashko Date: Tue, 31 Jan 2017 14:04:04 -0600 > In switch mode on struct cpsw_slave->ndev field will be initialized with > proper value only for the one cpsw slave port, as result > cpsw_get_usage_count() will generate "Unable to handle kernel NULL pointer > dereference" exception

Re: [PATCH net-next] net: reduce skb_warn_bad_offload() noise

2017-02-01 Thread David Miller
From: Eric Dumazet Date: Tue, 31 Jan 2017 10:20:32 -0800 > From: Eric Dumazet > > Dmitry reported warnings occurring in __skb_gso_segment() [1] > > All SKB_GSO_DODGY producers can allow user space to feed > packets that trigger the current check. > > We could prevent them from doing so, rejec

RE: [net-next 1/8] net/mlx5: Fixed static checker warnings

2017-02-01 Thread David Laight
From: Or Gerlitz > Sent: 01 February 2017 16:40 > On Wed, Feb 1, 2017 at 1:17 PM, David Laight wrote: > > From: Saeed Mahameed > >> Sent: 31 January 2017 20:59 > >> From: Or Gerlitz > >> > >> For some reason, sparse doesn't like using an expression of type (!x) > >> with a bitwise | and &. In or

Re: [PATCH net v2] net/sched: matchall: Fix configuration race

2017-02-01 Thread David Miller
From: Yotam Gigi Date: Tue, 31 Jan 2017 15:14:29 +0200 > In the current version, the matchall internal state is split into two > structs: cls_matchall_head and cls_matchall_filter. This makes little > sense, as matchall instance supports only one filter, and there is no > situation where one exis

Re: [PATCH] rtnetlink: Handle IFLA_MASTER parameter when processing rtnl_newlink

2017-02-01 Thread David Miller
From: Theuns Verwoerd Date: Tue, 31 Jan 2017 12:23:46 +1300 > Allow a master interface to be specified as one of the parameters when > creating a new interface via rtnl_newlink. Previously this would > require invoking interface creation, waiting for it to complete, and > then separately binding

[PATCH] [net-next] xgene_enet: remove bogus forward declarations

2017-02-01 Thread Arnd Bergmann
The device match tables for both the xgene_enet driver and its phy driver have forward declarations that declare an array without a length, leading to a clang warning when they are not followed by an actual defitinition: drivers/net/ethernet/apm/xgene/../../../phy/mdio-xgene.h:135:34: warning: te

Re: [PATCH net] tcp: fix 0 divide in __tcp_select_window()

2017-02-01 Thread Neal Cardwell
On Wed, Feb 1, 2017 at 11:33 AM, Eric Dumazet wrote: > > From: Eric Dumazet > > syszkaller fuzzer was able to trigger a divide by zero, when > TCP window scaling is not enabled. > > SO_RCVBUF can be used not only to increase sk_rcvbuf, also > to decrease it below current receive buffers utilizati

Re: [net-next 1/8] net/mlx5: Fixed static checker warnings

2017-02-01 Thread Or Gerlitz
On Wed, Feb 1, 2017 at 1:17 PM, David Laight wrote: > From: Saeed Mahameed >> Sent: 31 January 2017 20:59 >> From: Or Gerlitz >> >> For some reason, sparse doesn't like using an expression of type (!x) >> with a bitwise | and &. In order to mitigate that, we use a local >> variable. >> >> Since

Re: pull request (net-next): ipsec-next 2017-02-01

2017-02-01 Thread David Miller
From: Steffen Klassert Date: Wed, 1 Feb 2017 09:17:42 +0100 > 1) Some typo fixes, from Alexander Alemayhu. > > 2) Don't acquire state lock in get_mtu functions. >The only rece against a dead state does not matter. >From Florian Westphal. > > 3) Remove xfrm4_state_fini, it is unused for

  1   2   >