Hi Andrew, > > We would need a tri-state device tree properly: > > > > 1. Not defined - do nothing > > 2. Defined as 0 -> explicitly disable port mirroring > > 3. Defined as 1 -> explicitly enable port mirriring > > > > The "net-phy-lane-swap" only fulfills points 1 and 3 above. > > > > In my use case I do need point 2. > > Looking at the datasheet, PORT_MIRROR_EN defaults to 0. So it seems > reasonable to unconditionally set it to 0 when the PHY driver > loads. Any device which needs a value of 1 can set "net-phy-lane-swap"
Unconditionally setting this field to 0 (as we expect the reset default setting) seems to me like a good solution. However, I was not sure if such approach is acceptable by the community. > > Andrew Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
