[PATCH iproute2 v2] macsec: Nr. of packets and octets for macsec tx stats were swapped.

2016-11-22 Thread daniel . hopf
Resent from other mail address due to our company mail [clients|servers] stupidly forcing line-breaks on plain-text e-mails. Also changed the subject format as suggested by Sabrina and Rami. Acked-by: Rami Rosen Acked-by: Sabrina Dubroca Signed-off-by: Daniel Hopf --- ip/ipmacsec.c | 8 ++

Re: [PATCH net 1/1] net sched filters: fix filter handle ID in tfilter_notify_chain()

2016-11-22 Thread Daniel Borkmann
On 11/23/2016 02:57 AM, Roman Mashak wrote: Should pass valid filter handle, not the netlink flags. Fixes: 30a391a13ab92 ("net sched filters: pass netlink message flags in event notification") Signed-off-by: Roman Mashak Signed-off-by: Jamal Hadi Salim Acked-by: Daniel Borkmann

Re: [PATCH net-next 1/1] ipv6: sr: add option to control lwtunnel support

2016-11-22 Thread Roopa Prabhu
On 11/22/16, 4:16 PM, Alexei Starovoitov wrote: > On Wed, Nov 16, 2016 at 8:32 AM, David Miller wrote: >> From: David Lebrun >> Date: Tue, 15 Nov 2016 16:14:04 +0100 >> >>> This patch adds a new option CONFIG_IPV6_SEG6_LWTUNNEL to enable/disable >>> support of encapsulation with the lightweight t

pull request: bluetooth 2016-11-23

2016-11-22 Thread Johan Hedberg
Hi Dave, Sorry about the late pull request for 4.9, but we have one more important Bluetooth patch that should make it to the release. It fixes connection creation for Bluetooth LE controllers that do not have a public address (only a random one). Please let me know if there are any issues pullin

Re: [LKP] [net] 34fad54c25: kernel BUG at include/linux/skbuff.h:1935!

2016-11-22 Thread Linus Torvalds
On Tue, Nov 22, 2016 at 10:44 PM, Fengguang Wu wrote: > > On Tue, Nov 22, 2016 at 02:04:42PM -0800, Linus Torvalds wrote: > >> I also noticed that the kernel test robot had screwed up the >> participants list for some reason, and had >> >> "Acked-by: Alexander Duyck , David S. >> Miller" >> >> a

Re: [LKP] [net] 34fad54c25: kernel BUG at include/linux/skbuff.h:1935!

2016-11-22 Thread Fengguang Wu
Hi Linus, On Tue, Nov 22, 2016 at 02:04:42PM -0800, Linus Torvalds wrote: [snip] I also noticed that the kernel test robot had screwed up the participants list for some reason, and had "Acked-by: Alexander Duyck , David S. Miller" as one of the participants. So there's some odd commit parsi

Re: sendfile from 9p fs into af_alg

2016-11-22 Thread Al Viro
On Tue, Nov 22, 2016 at 08:55:59PM -0800, Alexei Starovoitov wrote: > On Wed, Nov 23, 2016 at 04:46:26AM +, Al Viro wrote: > > On Tue, Nov 22, 2016 at 07:58:29PM -0800, Alexei Starovoitov wrote: > > > Hi Al, > > > > > > it seems the following commit 523ac9afc73a ("switch > > > default_file_sp

Re: net/can: use-after-free in bcm_rx_thr_flush

2016-11-22 Thread Oliver Hartkopp
On 11/22/2016 06:37 PM, Andrey Konovalov wrote: On Tue, Nov 22, 2016 at 6:29 PM, Oliver Hartkopp wrote: Hi Andrey, thanks for the report. Although I can't see the issue in the code ... Oh, I can see it now m( Will send a patch today. Many thanks, Oliver

Re: [PATCH net-next] net/sched: cls_flower: verify root pointer before dereferncing it

2016-11-22 Thread Cong Wang
On Tue, Nov 22, 2016 at 3:36 PM, John Fastabend wrote: > On 16-11-22 12:41 PM, Daniel Borkmann wrote: >> On 11/22/2016 08:28 PM, Cong Wang wrote: >>> On Tue, Nov 22, 2016 at 8:11 AM, Jiri Pirko wrote: Tue, Nov 22, 2016 at 05:04:11PM CET, dan...@iogearbox.net wrote: > Hmm, I don't think w

Re: sendfile from 9p fs into af_alg

2016-11-22 Thread Alexei Starovoitov
On Wed, Nov 23, 2016 at 04:46:26AM +, Al Viro wrote: > On Tue, Nov 22, 2016 at 07:58:29PM -0800, Alexei Starovoitov wrote: > > Hi Al, > > > > it seems the following commit 523ac9afc73a ("switch > > default_file_splice_read() to use of pipe-backed iov_iter") > > breaks sendfile from 9p fs into

Re: sendfile from 9p fs into af_alg

2016-11-22 Thread Al Viro
On Tue, Nov 22, 2016 at 07:58:29PM -0800, Alexei Starovoitov wrote: > Hi Al, > > it seems the following commit 523ac9afc73a ("switch > default_file_splice_read() to use of pipe-backed iov_iter") > breaks sendfile from 9p fs into af_alg socket. > sendfile into af_alg is used by iproute2/tc. > I'm

[PATCH net-next 1/2] openvswitch: Add a missing break statement.

2016-11-22 Thread Jarno Rajahalme
Add a break statement to prevent fall-through from OVS_KEY_ATTR_ETHERNET to OVS_KEY_ATTR_TUNNEL. Without the break actions setting ethernet addresses fail to validate with log messages complaining about invalid tunnel attributes. Fixes: 0a6410fbde ("openvswitch: netlink: support L3 packets") Sign

[PATCH net-next 2/2] openvswitch: Fix skb->protocol for vlan frames.

2016-11-22 Thread Jarno Rajahalme
Do not set skb->protocol to be the ethertype of the L3 header, unless the packet only has the L3 header. For a non-hardware offloaded VLAN frame skb->protocol needs to be one of the VLAN ethertypes. Any VLAN offloading is undone on the OVS netlink interface. Due to this all VLAN packets sent to

Re: [PATCH net 1/1] net sched filters: fix filter handle ID in tfilter_notify_chain()

2016-11-22 Thread Cong Wang
On Tue, Nov 22, 2016 at 5:57 PM, Roman Mashak wrote: > Should pass valid filter handle, not the netlink flags. > > Fixes: 30a391a13ab92 ("net sched filters: pass netlink message flags in event > notification") > Signed-off-by: Roman Mashak > Signed-off-by: Jamal Hadi Salim Reported-by: Cong Wa

sendfile from 9p fs into af_alg

2016-11-22 Thread Alexei Starovoitov
Hi Al, it seems the following commit 523ac9afc73a ("switch default_file_splice_read() to use of pipe-backed iov_iter") breaks sendfile from 9p fs into af_alg socket. sendfile into af_alg is used by iproute2/tc. I'm not sure whether it's 9p or crypto or vfs problem, but happy to test any patches.

RE: [PATCH net 1/2] r8152: fix the sw rx checksum is unavailable

2016-11-22 Thread Hayes Wang
Mark Lord [mailto:ml...@pobox.com] > Sent: Friday, November 18, 2016 8:03 PM [..] > How does the RTL8152 know that the limit is 16KB, > rather than some other number? Is this a hardwired number > in the hardware, or is it a parameter that the software > sends to the chip during initialization? It

Re: net/icmp: null-ptr-deref in icmp6_send

2016-11-22 Thread David Ahern
On 11/22/16 1:11 PM, Cong Wang wrote: > I have no idea what commit 5d41ce29e tried to fix, but we already > use skb->dev a few lines before l3mdev_master_ifindex(), so I don't > understand why skb->dev could be NULL, maybe just for vrf dev? skb->dev can be null depending on when icmp6_send / icmpv

[lkp] [net] 50d4a9ef15: INFO:suspicious_RCU_usage

2016-11-22 Thread kernel test robot
FYI, we noticed the following commit: commit 50d4a9ef15cee93344653f6ca8f9bab62e76e972 ("net: ipv6: avoid errors due to per-cpu atomic alloc") url: https://github.com/0day-ci/linux/commits/Mike-Manning/net-ipv6-avoid-errors-due-to-per-cpu-atomic-alloc/20161122-202055 in testcase: tr

[PATCH net-next] tuntap: remove unnecessary sk_receive_queue length check during xmit

2016-11-22 Thread Jason Wang
After commit 1576d9860599 ("tun: switch to use skb array for tx"), sk_receive_queue was not used any more. So remove the uncessary sk_receive_queue length check during xmit. Signed-off-by: Jason Wang --- drivers/net/tun.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/net/tun.

[PATCH net 1/1] net sched filters: fix filter handle ID in tfilter_notify_chain()

2016-11-22 Thread Roman Mashak
Should pass valid filter handle, not the netlink flags. Fixes: 30a391a13ab92 ("net sched filters: pass netlink message flags in event notification") Signed-off-by: Roman Mashak Signed-off-by: Jamal Hadi Salim --- net/sched/cls_api.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

net/arp: ARP cache aging failed.

2016-11-22 Thread yuehaibing
Hi, I've encountered a arp cache aging failed bug in 4.9 kernel.The topo is as follow: HOST1 - IP1 | Switch |IP2-| HOST2 | |

Re: [RFC PATCH net-next] net: ethtool: add support for forward error correction modes

2016-11-22 Thread Casey Leedom
I'm attempting to start the work necessary to implement Vidya's proposed new ethtool interface to manage Forward Error Correction settings on a link. I'm confused by the ethtool FEC API and the degree/type of control it offers. At the top of the patch we have: Encoding: Types of encoding Of

Re: [RFC 02/10] IB/hfi-vnic: Virtual Network Interface Controller (VNIC) Bus driver

2016-11-22 Thread Vishwanathapura, Niranjana
On Tue, Nov 22, 2016 at 05:04:37PM -0600, Christoph Lameter wrote: On Tue, 22 Nov 2016, Vishwanathapura, Niranjana wrote: Ok, I do understand Jason's point that we should probably not put this driver under drivers/infiniband/sw/.., as this driver is not a HCA. It is an ULP similar to ipoib, bui

Re: [RESEND][PATCH v4] cgroup: Use CAP_SYS_RESOURCE to allow a process to migrate other tasks between cgroups

2016-11-22 Thread John Stultz
On Tue, Nov 8, 2016 at 4:12 PM, Andy Lutomirski wrote: > On Tue, Nov 8, 2016 at 4:03 PM, Alexei Starovoitov > wrote: >> On Tue, Nov 08, 2016 at 03:51:40PM -0800, Andy Lutomirski wrote: >>> >>> I hate to say it, but I think I may see a problem. Current >>> developments are afoot to make cgroups d

[PATCH net-next 1/2] samples/bpf: fix sockex2 example

2016-11-22 Thread Alexei Starovoitov
since llvm commit "Do not expand UNDEF SDNode during insn selection lowering" llvm will generate code that uses uninitialized registers for cases where C code is actually uses uninitialized data. So this sockex2 example is technically broken. Fix it by initializing on the stack variable fully. Also

[PATCH net-next 2/2] samples/bpf: fix bpf loader

2016-11-22 Thread Alexei Starovoitov
llvm can emit relocations into sections other than program code (like debug info sections). Ignore them during parsing of elf file Signed-off-by: Alexei Starovoitov --- samples/bpf/bpf_load.c | 4 1 file changed, 4 insertions(+) diff --git a/samples/bpf/bpf_load.c b/samples/bpf/bpf_load.c

Re: [RFC 02/10] IB/hfi-vnic: Virtual Network Interface Controller (VNIC) Bus driver

2016-11-22 Thread Jason Gunthorpe
On Tue, Nov 22, 2016 at 07:05:05PM -0500, ira.weiny wrote: > On Tue, Nov 22, 2016 at 10:04:07AM -0700, Jason Gunthorpe wrote: > > On Mon, Nov 21, 2016 at 05:53:04PM -0800, Vishwanathapura, Niranjana wrote: > > > There are many example drivers in kernel which are using bus_register() in > > > an ini

Re: [RFC net-next 0/3] net: bridge: Allow CPU port configuration

2016-11-22 Thread Florian Fainelli
On 11/22/2016 02:08 PM, Jiri Pirko wrote: > Tue, Nov 22, 2016 at 06:48:29PM CET, and...@lunn.ch wrote: >> Hi Ido >> >>> First of all, I want to be sure that when we say "CPU port", we're >>> talking about the same thing. In mlxsw, the CPU port is a pipe between >>> the device and the host, through

Re: [RFC 02/10] IB/hfi-vnic: Virtual Network Interface Controller (VNIC) Bus driver

2016-11-22 Thread ira.weiny
On Tue, Nov 22, 2016 at 10:04:07AM -0700, Jason Gunthorpe wrote: > On Mon, Nov 21, 2016 at 05:53:04PM -0800, Vishwanathapura, Niranjana wrote: > > There are many example drivers in kernel which are using bus_register() in > > an initcall. > > There really are not, certainly not in major subsystems

Re: [PATCH net-next 1/1] ipv6: sr: add option to control lwtunnel support

2016-11-22 Thread Alexei Starovoitov
On Wed, Nov 16, 2016 at 8:32 AM, David Miller wrote: > From: David Lebrun > Date: Tue, 15 Nov 2016 16:14:04 +0100 > >> This patch adds a new option CONFIG_IPV6_SEG6_LWTUNNEL to enable/disable >> support of encapsulation with the lightweight tunnels. When this option >> is enabled, CONFIG_LWTUNNEL

Re: [RFC 02/10] IB/hfi-vnic: Virtual Network Interface Controller (VNIC) Bus driver

2016-11-22 Thread Andrew Lunn
On Tue, Nov 22, 2016 at 11:49:18AM -0800, Vishwanathapura, Niranjana wrote: > Ok, I do understand Jason's point that we should probably not put > this driver under drivers/infiniband/sw/.., as this driver is not a > HCA. > It is an ULP similar to ipoib, built on top of Omni-path > irrespective of w

[PATCH net-next] mlx4: reorganize struct mlx4_en_tx_ring

2016-11-22 Thread Eric Dumazet
From: Eric Dumazet Goal is to reorganize this critical structure to increase performance. ndo_start_xmit() should only dirty one cache line, and access as few cache lines as possible. Add sp_ (Slow Path) prefix to fields that are not used in fast path, to make clear what is going on. After thi

[PATCH ethtool] ethtool: Fix the "advertise" parameter logic.

2016-11-22 Thread Michael Chan
From: Michael Chan The current code ignores the value of the advertise parameter. For example, ethtool -s ethx advertise 0x1000 The full_advertising_wanted parameter of 0x1000 is not passed to the kernel. The reason is that advertising_wanted is NULL in this case, and ethtool will think that t

Re: [RFC PATCH net-next] net: ethtool: add support for forward error correction modes

2016-11-22 Thread Casey Leedom
And by the way, we currently have two ethtool APIs which pump in an Auto-Negotiation indication -- set_link_ksettings() and set_pauseparam(). Now we're talking about adding a third, set_fecparam(). Are all of the calls to these three APIs supposed to agree on the concept of Auto-Negotiations

[PATCH RFC v1] ethtool: implement helper to get flow_type value

2016-11-22 Thread Jacob Keller
Often a driver wants to store the flow type and thus it must mask the extra fields. This is a task that could grow more complex as more flags are added in the future. Add a helper function that masks the flags for marking additional fields. Modify drivers in drivers/net/ethernet that currently che

Re: [PATCH net-next] net/sched: cls_flower: verify root pointer before dereferncing it

2016-11-22 Thread John Fastabend
On 16-11-22 12:41 PM, Daniel Borkmann wrote: > On 11/22/2016 08:28 PM, Cong Wang wrote: >> On Tue, Nov 22, 2016 at 8:11 AM, Jiri Pirko wrote: >>> Tue, Nov 22, 2016 at 05:04:11PM CET, dan...@iogearbox.net wrote: Hmm, I don't think we want to have such an additional test in fast path for e

Re: [net] 34fad54c25: kernel BUG at include/linux/skbuff.h:1935!

2016-11-22 Thread Linus Torvalds
On Tue, Nov 22, 2016 at 2:28 PM, Eric Dumazet wrote: > > This is fixed by : > https://git.kernel.org/cgit/linux/kernel/git/davem/net.git/commit/?id=c9b8af1330198ae241cd545e1f040019010d44d9 Thanks guys. This was one of the less esoteric-looking regressions, so I'm happy to hear it's solved.

Re: [RFC 02/10] IB/hfi-vnic: Virtual Network Interface Controller (VNIC) Bus driver

2016-11-22 Thread Christoph Lameter
On Tue, 22 Nov 2016, Vishwanathapura, Niranjana wrote: > Ok, I do understand Jason's point that we should probably not put this driver > under drivers/infiniband/sw/.., as this driver is not a HCA. > It is an ULP similar to ipoib, built on top of Omni-path irrespective of > whether we register a h

Re: [net] 34fad54c25: kernel BUG at include/linux/skbuff.h:1935!

2016-11-22 Thread Andre Noll
On Tue, Nov 22, 14:04, Linus Torvalds wrote > what's the situation on this issue? The bisection looks a bit odd, > but the commit in question does end up changing the key_control->thoff > value for the failure case, so maybe that in turn ends up screwing up > a later skb_pull. > > I'm not seeing

Re: [net] 34fad54c25: kernel BUG at include/linux/skbuff.h:1935!

2016-11-22 Thread Eric Dumazet
On Tue, Nov 22, 2016 at 2:04 PM, Linus Torvalds wrote: > David, Eric, > > what's the situation on this issue? The bisection looks a bit odd, > but the commit in question does end up changing the key_control->thoff > value for the failure case, so maybe that in turn ends up screwing up > a later s

Re: [PATCH] net: dsa: mv88e6xxx: egress all frames

2016-11-22 Thread Vivien Didelot
Hi Andrew, Stefan, Andrew Lunn writes: > What you might find useful is > > https://github.com/vivien/linux.git 161b96bd7d16d21b0f046c935b70c3b2d277ccc2 > > although it might need some changes for recent commits. > > With that, you can see deeper into the switches registers. FYI, I have rebased

Re: [PATCH 2/2] net: qcom/emac: add support for the Qualcomm Technologies QDF2400

2016-11-22 Thread Timur Tabi
On 11/21/2016 04:58 PM, Timur Tabi wrote: The QDF2432 and the QDF2400 have slightly different internal PHYs, so there are some programming differences. Some of the registers in the QDF2400 have moved, and some registers require different values during initialization. Because of the differences,

Re: [net] 34fad54c25: kernel BUG at include/linux/skbuff.h:1935!

2016-11-22 Thread Linus Torvalds
David, Eric, what's the situation on this issue? The bisection looks a bit odd, but the commit in question does end up changing the key_control->thoff value for the failure case, so maybe that in turn ends up screwing up a later skb_pull. I'm not seeing anything that might fix this in the last n

Re: [RFC net-next 0/3] net: bridge: Allow CPU port configuration

2016-11-22 Thread Jiri Pirko
Tue, Nov 22, 2016 at 06:48:29PM CET, and...@lunn.ch wrote: >Hi Ido > >> First of all, I want to be sure that when we say "CPU port", we're >> talking about the same thing. In mlxsw, the CPU port is a pipe between >> the device and the host, through which all packets trapped to the host >> go throu

[PATCH net-next v2] ethtool: Protect {get,set}_phy_tunable with PHY device mutex

2016-11-22 Thread Florian Fainelli
PHY drivers should be able to rely on the caller of {get,set}_tunable to have acquired the PHY device mutex, in order to both serialize against concurrent calls of these functions, but also against PHY state machine changes. All ethtool PHY-level functions do this, except {get,set}_tunable, so we m

Re: [PATCH net-next] ethtool: Protect {get,set}_phy_tunable with PHY device mutex

2016-11-22 Thread Florian Fainelli
On 11/22/2016 12:13 PM, Florian Fainelli wrote: > PHY drivers should be able to rely on the caller of {get,set}_tunable to > have acquired the PHY device mutex, in order to both serialize against > concurrent calls of these functions, but also against PHY state machine > changes. All ethtool PHY-le

[PATCH net-next V2 2/7] net/mlx5e: Support HW (offloaded) and SW counters for SRIOV switchdev mode

2016-11-22 Thread Saeed Mahameed
From: Or Gerlitz Switchdev driver net-device port statistics should follow the model introduced in commit a5ea31f57309 'Merge branch net-offloaded-stats'. For VF reps we return the SRIOV eswitch vport stats as the usual ones and SW stats if asked. For the PF, if we're in the switchdev mode, we

[PATCH net-next V2 3/7] net/mlx5e: Support VF vport link state control for SRIOV switchdev mode

2016-11-22 Thread Saeed Mahameed
From: Or Gerlitz Reflect the administative link changes done on the VF representor to the VF e-switch vport. This means that doing ip link set down/up commands on the VF rep will modify the e-switch vport state which in turn will make proper VF drivers to set their carrier accordingly. Signed-of

[PATCH net-next V2 4/7] devlink: Add E-Switch inline mode control

2016-11-22 Thread Saeed Mahameed
From: Roi Dayan Some HWs need the VF driver to put part of the packet headers on the TX descriptor so the e-switch can do proper matching and steering. The supported modes: none, link, network, transport. Signed-off-by: Roi Dayan Reviewed-by: Or Gerlitz Signed-off-by: Saeed Mahameed --- inc

[PATCH net-next V2 5/7] net/mlx5: Enable to query min inline for a specific vport

2016-11-22 Thread Saeed Mahameed
From: Roi Dayan Also move the inline capablities enum to a shared header vport.h Signed-off-by: Roi Dayan Reviewed-by: Or Gerlitz Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 6 -- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 11 +-

[PATCH net-next V2 7/7] net/mlx5e: Enforce min inline mode when offloading flows

2016-11-22 Thread Saeed Mahameed
From: Roi Dayan A flow should be offloaded only if the matches are allowed according to min inline mode. Signed-off-by: Roi Dayan Reviewed-by: Or Gerlitz Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 46 +++-- 1 file changed, 44 inser

[PATCH net-next V2 0/7] Mellanox 100G mlx5 SRIOV switchdev update

2016-11-22 Thread Saeed Mahameed
Hi Dave, This series from Roi and Or further enhances the new SRIOV switchdev mode. Roi's patches deal with allowing users to configure though devlink the level of inline headers that the VF should be setting in order for the eswitch HW to do proper matching. We also enforce that the matching req

[PATCH net-next V2 6/7] net/mlx5: E-Switch, Add control for inline mode

2016-11-22 Thread Saeed Mahameed
From: Roi Dayan Implement devlink show and set of HW inline-mode. The supported modes: none, link, network, transport. We currently support one mode for all vports so set is done on all vports. When eswitch is first initialized the inline-mode is queried from the FW. Signed-off-by: Roi Dayan Re

[PATCH net-next V2 1/7] net: Add net-device param to the get offloaded stats ndo

2016-11-22 Thread Saeed Mahameed
From: Or Gerlitz Some drivers would need to check few internal matters for that. To be used in downstream mlx5 commit. Signed-off-by: Or Gerlitz Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 2 +- include/linux/netdevice.h | 4 ++-- ne

Re: [PATCH net-next 4/5] net: phy: bcm7xxx: Add support for downshift/Wirespeed

2016-11-22 Thread Florian Fainelli
On 11/22/2016 12:57 PM, Andrew Lunn wrote: >>> Maybe we should think about this locking a bit. It is normal for the >>> lock to be held when using ops in the phy driver structure. The >>> exception is suspend/resume. Maybe we should also take the lock before >>> calling the phydev->drv->get_tunable

Re: [PATCH net-next 1/4] net: mvneta: Convert to be 64 bits compatible

2016-11-22 Thread Arnd Bergmann
On Tuesday, November 22, 2016 5:48:41 PM CET Gregory CLEMENT wrote: > +#ifdef CONFIG_64BIT > + void *data_tmp; > + > + /* In Neta HW only 32 bits data is supported, so in order to > +* obtain whole 64 bits address from RX descriptor, we store > +* the upper 32 bits when

Re: [PATCH net-next 4/5] net: phy: bcm7xxx: Add support for downshift/Wirespeed

2016-11-22 Thread Andrew Lunn
> > Maybe we should think about this locking a bit. It is normal for the > > lock to be held when using ops in the phy driver structure. The > > exception is suspend/resume. Maybe we should also take the lock before > > calling the phydev->drv->get_tunable() and phydev->drv->set_tunable()? > > Yes

Re: [PATCH net-next] net/sched: cls_flower: verify root pointer before dereferncing it

2016-11-22 Thread Daniel Borkmann
On 11/22/2016 08:28 PM, Cong Wang wrote: On Tue, Nov 22, 2016 at 8:11 AM, Jiri Pirko wrote: Tue, Nov 22, 2016 at 05:04:11PM CET, dan...@iogearbox.net wrote: Hmm, I don't think we want to have such an additional test in fast path for each and every classifier. Can we think of ways to avoid that

[PATCH ethtool v4 2/2] Ethtool: Implements ETHTOOL_PHY_GTUNABLE/ETHTOOL_PHY_STUNABLE and PHY downshift

2016-11-22 Thread Allan W. Nielsen
From: Raju Lakkaraju Add ethtool get and set tunable to access PHY drivers. Ethtool Help: ethtool -h for PHY tunables ethtool --set-phy-tunable DEVNAME Set PHY tunable [ downshift on|off [count N] ] ethtool --get-phy-tunable DEVNAME Get PHY tunable

[PATCH ethtool v4 1/2] ethtool-copy.h:sync with net

2016-11-22 Thread Allan W. Nielsen
From: Raju Lakkaraju This covers kernel changes upto: commit f5a4732f85613b3fb43f8bc33a017e3db3b3605a Author: Raju Lakkaraju Date: Wed Nov 9 16:33:09 2016 +0530 ethtool: (uapi) Add ETHTOOL_PHY_DOWNSHIFT to PHY tunables For operation in cabling environments that are incompatible with

[PATCH ethtool v4 0/2] Adding downshift support to ethtool

2016-11-22 Thread Allan W. Nielsen
(downshift feature is applied in the net-next tree - d3c19c0a72) This series adds support for downshift (using phy-tunables). Downshifting can either be turned on/off, or it can be configured to a specifc count. "count" is optional. Change set: v1: - Initial version of set/get phy tunable with

Re: [PATCH net-next 4/5] net: phy: bcm7xxx: Add support for downshift/Wirespeed

2016-11-22 Thread Florian Fainelli
On 11/22/2016 12:02 PM, Andrew Lunn wrote: >> +static int bcm7xxx_28nm_set_tunable(struct phy_device *phydev, >> +struct ethtool_tunable *tuna, >> +const void *data) >> +{ >> +u8 count = *(u8 *)data; >> +int ret; >> + >> +s

[PATCH net-next] ethtool: Protect {get,set}_phy_tunable with PHY device mutex

2016-11-22 Thread Florian Fainelli
PHY drivers should be able to rely on the caller of {get,set}_tunable to have acquired the PHY device mutex, in order to both serialize against concurrent calls of these functions, but also against PHY state machine changes. All ethtool PHY-level functions do this, except {get,set}_tunable, so we m

Re: [PATCH net-next 4/5] net: phy: bcm7xxx: Add support for downshift/Wirespeed

2016-11-22 Thread Andrew Lunn
> +static int bcm7xxx_28nm_set_tunable(struct phy_device *phydev, > + struct ethtool_tunable *tuna, > + const void *data) > +{ > + u8 count = *(u8 *)data; > + int ret; > + > + switch (tuna->id) { > + case ETHTOOL_PHY_DO

Re: [PATCH net] flow_dissect: call init_default_flow_dissectors() earlier

2016-11-22 Thread Andre Noll
On Tue, Nov 22, 11:17, Eric Dumazet wrote > -late_initcall_sync(init_default_flow_dissectors); > +core_initcall(init_default_flow_dissectors); Indeed, that fixed it. Feel free to add Tested-by: Andre Noll Thanks a lot Andre -- Max Planck Institute for Developmental Biology Spemannstraße 35, 72

Re: [RFC 02/10] IB/hfi-vnic: Virtual Network Interface Controller (VNIC) Bus driver

2016-11-22 Thread Vishwanathapura, Niranjana
Ok, I do understand Jason's point that we should probably not put this driver under drivers/infiniband/sw/.., as this driver is not a HCA. It is an ULP similar to ipoib, built on top of Omni-path irrespective of whether we register a hfi_vnic_bus or a direct custom interface with HFI1. This ULP w

Re: [PATCH net] flow_dissect: call init_default_flow_dissectors() earlier

2016-11-22 Thread David Miller
From: Eric Dumazet Date: Tue, 22 Nov 2016 11:17:30 -0800 > From: Eric Dumazet > > Andre Noll reported panics after my recent fix (commit 34fad54c2537 > "net: __skb_flow_dissect() must cap its return value") > > After some more headaches, Alexander root caused the problem to > init_default_flow

[PATCH net-next 3/5] net: phy: broadcom: Allow enabling or disabling of EEE

2016-11-22 Thread Florian Fainelli
In preparation for adding support for Wirespeed/downshift, we need to change bcm_phy_eee_enable() to allow enabling or disabling EEE, so make the function take an extra enable/disable boolean parameter and rename it to illustrate it sets EEE, not necessarily just enables it. Signed-off-by: Florian

[PATCH net-next 5/5] net: dsa: bcm_sf2: Ensure we re-negotiate EEE during after link change

2016-11-22 Thread Florian Fainelli
In case the link change and EEE is enabled or disabled, always try to re-negotiate this with the link partner. Fixes: 450b05c15f9c ("net: dsa: bcm_sf2: add support for controlling EEE") Signed-off-by: Florian Fainelli --- drivers/net/dsa/bcm_sf2.c | 4 1 file changed, 4 insertions(+) diff

[PATCH net-next 0/5] net: phy: broadcom: Wirespeed/downshift support

2016-11-22 Thread Florian Fainelli
Hi all, This patch series adds support for the Broadcom Wirespeed, aka downsfhit feature utilizing the recently added ethtool PHY tunables. Tested with two Gigabit link partners with a 4-wire cable having only 2 pairs connected. Last patch in the series is a fix that was required for testing, wh

[PATCH net-next 4/5] net: phy: bcm7xxx: Add support for downshift/Wirespeed

2016-11-22 Thread Florian Fainelli
Add support for configuring the downshift/Wirespeed enable/disable toggles and specify a link retry value ranging from 1 to 9. Since the integrated BCM7xxx have issues when wirespeed is enabled and EEE is also enabled, we do disable EEE if wirespeed is enabled. Signed-off-by: Florian Fainelli ---

[PATCH net-next 1/5] net: phy: broadcom: Move bcm54xx_auxctl_{read,write} to common library

2016-11-22 Thread Florian Fainelli
We are going to need these functions to implement support for Broadcom Wirespeed, aka downshift. Signed-off-by: Florian Fainelli --- drivers/net/phy/bcm-phy-lib.c | 17 + drivers/net/phy/bcm-phy-lib.h | 3 +++ drivers/net/phy/broadcom.c| 15 --- 3 files changed,

[PATCH net-next 2/5] net: phy: broadcom: Add support code for downshift/Wirespeed

2016-11-22 Thread Florian Fainelli
Broadcom's Wirespeed feature allows us to configure how auto-negotiation should behave with fewer working pairs of wires on a cable. Add support code for retrieving and setting such downshift counters using the recently added ethtool downshift tunables. Signed-off-by: Florian Fainelli --- driver

Re: [PATCH net-next] net/sched: cls_flower: verify root pointer before dereferncing it

2016-11-22 Thread Cong Wang
On Tue, Nov 22, 2016 at 8:11 AM, Jiri Pirko wrote: > Tue, Nov 22, 2016 at 05:04:11PM CET, dan...@iogearbox.net wrote: >>Hmm, I don't think we want to have such an additional test in fast >>path for each and every classifier. Can we think of ways to avoid that? >> >>My question is, since we unlink

[PATCH net] flow_dissect: call init_default_flow_dissectors() earlier

2016-11-22 Thread Eric Dumazet
From: Eric Dumazet Andre Noll reported panics after my recent fix (commit 34fad54c2537 "net: __skb_flow_dissect() must cap its return value") After some more headaches, Alexander root caused the problem to init_default_flow_dissectors() being called too late, in case a network driver like IGB is

Re: [PATCH net-next] tcp: enhance tcp_collapse_retrans() with skb_shift()

2016-11-22 Thread Eric Dumazet
On Tue, 2016-11-15 at 12:51 -0800, Eric Dumazet wrote: > From: Eric Dumazet > > In commit 2331ccc5b323 ("tcp: enhance tcp collapsing"), > we made a first step allowing copying right skb to left skb head. > > Since all skbs in socket write queue are headless (but possibly the very > first one), t

Re: net/icmp: null-ptr-deref in icmp6_send

2016-11-22 Thread David Ahern
Sent from my iPhone > On Nov 22, 2016, at 1:11 PM, Cong Wang wrote: > >> On Tue, Nov 22, 2016 at 2:23 AM, Andrey Konovalov >> wrote: >> Hi, >> >> I've got the following error report while fuzzing the kernel with syzkaller. >> >> It seems that skb_dst(skb) may end up being NULL. >> >> As f

Re: [PATCH net] bnxt: do not busy-poll when link is down

2016-11-22 Thread Eric Dumazet
On Tue, 2016-11-22 at 10:55 -0800, Michael Chan wrote: > On Tue, Nov 22, 2016 at 10:38 AM, Eric Dumazet wrote: > > > > Any plans removing this busy polling stuff, now it is done in core > > networking stack ? > > > > This would remove bnxt_lock_napi() extra overhead in normal path ( napi > > poll

Re: [PATCH] net: dsa: mv88e6xxx: egress all frames

2016-11-22 Thread Andrew Lunn
On Tue, Nov 22, 2016 at 07:37:33PM +0100, Stefan Eichenberger wrote: > Hi Andrew > > On Tue, Nov 22, 2016 at 04:03:30PM +0100, Andrew Lunn wrote: > > On Tue, Nov 22, 2016 at 11:39:44AM +0100, Stefan Eichenberger wrote: > > > Egress multicast and egress unicast is only enabled for CPU/DSA ports > >

Re: [PATCH net] bnxt: do not busy-poll when link is down

2016-11-22 Thread Michael Chan
On Tue, Nov 22, 2016 at 10:38 AM, Eric Dumazet wrote: > On Tue, 2016-11-22 at 13:14 -0500, Andy Gospodarek wrote: >> When busy polling while a link is down (during a link-flap test), TX >> timeouts were observed as well as the following messages in the ring >> buffer: >> >> bnxt_en 0008:01:00.2 en

Re: [PATCH] net: dsa: mv88e6xxx: egress all frames

2016-11-22 Thread Stefan Eichenberger
Hi Andrew On Tue, Nov 22, 2016 at 04:03:30PM +0100, Andrew Lunn wrote: > On Tue, Nov 22, 2016 at 11:39:44AM +0100, Stefan Eichenberger wrote: > > Egress multicast and egress unicast is only enabled for CPU/DSA ports > > but for switching operation it seems it should be enabled for all ports. > > D

Re: [PATCH net] bnxt: do not busy-poll when link is down

2016-11-22 Thread Eric Dumazet
On Tue, 2016-11-22 at 13:14 -0500, Andy Gospodarek wrote: > When busy polling while a link is down (during a link-flap test), TX > timeouts were observed as well as the following messages in the ring > buffer: > > bnxt_en 0008:01:00.2 enP8p1s0f2d2: Resp cmpl intr err msg: 0x51 > bnxt_en 0008:01:00

List pre vas

2016-11-22 Thread Paní KLeung
Ahoj. Dobre rano, a jak to delate? Jen rychly jedno, je tu oficialni prilezitosti bych chtel diskutovat s vami soukrome. Ocenil bych vasi rychlou reakci tady na mem osobnim soukromeho e-mailu nize pro dalsi komunikaci. S pratelskym pozdravem, Paní Ko May Leung email: lngkoma...@gmail.

[PATCH net] bnxt: do not busy-poll when link is down

2016-11-22 Thread Andy Gospodarek
When busy polling while a link is down (during a link-flap test), TX timeouts were observed as well as the following messages in the ring buffer: bnxt_en 0008:01:00.2 enP8p1s0f2d2: Resp cmpl intr err msg: 0x51 bnxt_en 0008:01:00.2 enP8p1s0f2d2: hwrm_ring_free tx failed. rc:-1 bnxt_en 0008:01:00.2

[PATCH/RFC -next] net: phy: Fix double free in phy_detach()

2016-11-22 Thread Geert Uytterhoeven
During "poweroff" on sh73a0/kzm9g: WARNING: CPU: 0 PID: 1271 at drivers/base/devres.c:889 phy_detach+0x44/0x60 Modules linked in: CPU: 0 PID: 1271 Comm: halt Not tainted 4.9.0-rc6-kzm9g-05637-gb090128865050239 #823 Hardware name: Generic SH73A0 (Flattened Device Tree) [] (unwi

Re: [RFC net-next 0/3] net: bridge: Allow CPU port configuration

2016-11-22 Thread Florian Fainelli
On 11/22/2016 09:41 AM, Ido Schimmel wrote: > Hi Florian, > > On Mon, Nov 21, 2016 at 11:09:22AM -0800, Florian Fainelli wrote: >> Hi all, >> >> This patch series allows using the bridge master interface to configure >> an Ethernet switch port's CPU/management port with different VLAN attributes

Re: net/icmp: null-ptr-deref in icmp6_send

2016-11-22 Thread Cong Wang
On Tue, Nov 22, 2016 at 2:23 AM, Andrey Konovalov wrote: > Hi, > > I've got the following error report while fuzzing the kernel with syzkaller. > > It seems that skb_dst(skb) may end up being NULL. > > As far as I can see the bug was introduced in commit 5d41ce29e ("net: > icmp6_send should use ds

Re: wl1251 & mac address & calibration data

2016-11-22 Thread Pali Rohár
On Tuesday 22 November 2016 17:14:28 Michal Kazior wrote: > On 22 November 2016 at 16:31, Pali Rohár wrote: > > On Tuesday 22 November 2016 16:22:57 Michal Kazior wrote: > >> On 21 November 2016 at 16:51, Pali Rohár > >> wrote: > >> > On Friday 11 November 2016 18:20:50 Pali Rohár wrote: > >> >>

Re: [RFC net-next 0/3] net: bridge: Allow CPU port configuration

2016-11-22 Thread Ido Schimmel
Hi Florian, On Mon, Nov 21, 2016 at 11:09:22AM -0800, Florian Fainelli wrote: > Hi all, > > This patch series allows using the bridge master interface to configure > an Ethernet switch port's CPU/management port with different VLAN attributes > than > those of the bridge downstream ports/members

Re: [RFC net-next 0/3] net: bridge: Allow CPU port configuration

2016-11-22 Thread Andrew Lunn
Hi Ido > First of all, I want to be sure that when we say "CPU port", we're > talking about the same thing. In mlxsw, the CPU port is a pipe between > the device and the host, through which all packets trapped to the host > go through. So, when a packet is trapped, the driver reads its Rx > descr

Re: net/can: use-after-free in bcm_rx_thr_flush

2016-11-22 Thread Andrey Konovalov
On Tue, Nov 22, 2016 at 6:29 PM, Oliver Hartkopp wrote: > Hi Andrey, > > thanks for the report. > > Although I can't see the issue in the code ... > > On 11/22/2016 10:22 AM, Andrey Konovalov wrote: > >> == >> BUG: KASAN: use-after-fr

RE: [PATCH v9 0/8] thunderbolt: Introducing Thunderbolt(TM) Networking

2016-11-22 Thread Mario.Limonciello
> Here are a couple of additional questions: > > - When the network interface is created, there is no IP address > assigned (or negotiated ?) on the Linux side. But it is done on the > MacOS side. And in the Linux kernel logs I can also read the message: > "ready for ThunderboltIP negotiatio

Re: net/can: use-after-free in bcm_rx_thr_flush

2016-11-22 Thread Oliver Hartkopp
Hi Andrey, thanks for the report. Although I can't see the issue in the code ... On 11/22/2016 10:22 AM, Andrey Konovalov wrote: == BUG: KASAN: use-after-free in bcm_rx_thr_flush+0x284/0x2b0 Read of size 1 at addr 88006c1faae

Re: [PATCH v9 0/8] thunderbolt: Introducing Thunderbolt(TM) Networking

2016-11-22 Thread Simon Guinot
On Fri, Nov 18, 2016 at 12:20:07PM +0100, Simon Guinot wrote: > On Fri, Nov 18, 2016 at 08:48:36AM +, Levy, Amir (Jer) wrote: > > On Tue, Nov 15 2016, 12:59 PM, Simon Guinot wrote: > > > On Wed, Nov 09, 2016 at 03:42:53PM +, Levy, Amir (Jer) wrote: > > > > On Wed, Nov 9 2016, 04:36 PM, Simo

Re: [PATCHv2 net-next 00/11] Start adding support for mv88e6390

2016-11-22 Thread Vivien Didelot
Hi, Andrew Lunn writes: > This is the first patchset implementing support for the mv88e6390 > family. This is a new generation of switch devices and has numerous > incompatible changes to the registers. These patches allow the switch > to the detected during probe, and makes the statistics unit

[PATCH net] udplite: call proper backlog handlers

2016-11-22 Thread Eric Dumazet
From: Eric Dumazet In commits 93821778def10 ("udp: Fix rcv socket locking") and f7ad74fef3af ("net/ipv6/udp: UDP encapsulation: break backlog_rcv into __udpv6_queue_rcv_skb") UDP backlog handlers were renamed, but UDPlite was forgotten. This leads to crashes if UDPlite header is pulled twice, wh

Re: [RFC net-next 2/3] net: dsa: Propagate VLAN add/del to CPU port(s)

2016-11-22 Thread Vivien Didelot
Hi Florian, Open question: will we need to do the same for FDB and MDB objects? Florian Fainelli writes: > Now that the bridge layer can call into switchdev to signal programming > requests targeting the bridge master device itself, allow the switch > drivers to implement separate programming o

Re: [RFC 02/10] IB/hfi-vnic: Virtual Network Interface Controller (VNIC) Bus driver

2016-11-22 Thread Jason Gunthorpe
On Mon, Nov 21, 2016 at 05:53:04PM -0800, Vishwanathapura, Niranjana wrote: > There are many example drivers in kernel which are using bus_register() in > an initcall. There really are not, certainly not in major subsystems. > We could add a custom Interface between HFI1 driver and hfi_vnic drive

[PATCH v2] net: dsa: mv88e6xxx: add MV88E6097 switch

2016-11-22 Thread Stefan Eichenberger
Add support for the MV88E6097 switch. The change was tested on an Armada based platform with a MV88E6097 switch. Signed-off-by: Stefan Eichenberger --- drivers/net/dsa/mv88e6xxx/chip.c | 26 ++ drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 2 ++ 2 files changed, 28 insert

[PATCH net-next 4/4] ARM64: dts: marvell: Add network support for Armada 3700

2016-11-22 Thread Gregory CLEMENT
Add neta nodes for network support both in device tree for the SoC and the board. Signed-off-by: Gregory CLEMENT --- arch/arm64/boot/dts/marvell/armada-3720-db.dts | 23 +++ arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 23 +++ 2 files changed, 46 inser

  1   2   >