On 11/22/2016 12:57 PM, Andrew Lunn wrote: >>> Maybe we should think about this locking a bit. It is normal for the >>> lock to be held when using ops in the phy driver structure. The >>> exception is suspend/resume. Maybe we should also take the lock before >>> calling the phydev->drv->get_tunable() and phydev->drv->set_tunable()? >> >> Yes, that certainly seems like a good approach to me, let me cook a >> patch doing that. > > Hi Florian > > There are a couple of mutex locks/unlocks you will need to remove from > mscc.c when you centralize this mutex.
Good point, thanks, let me review the mscc PHY driver and propose a more proper fix. -- Florian
