Re: [PATCH v2 3/6] qedi: Add QLogic FastLinQ offload iSCSI driver framework.

2016-11-14 Thread Rangankar, Manish
Hi Hannes, Please find the response below, On 11/11/16 10:13 PM, "Hannes Reinecke" wrote: >On 11/08/2016 07:57 AM, Manish Rangankar wrote: >> The QLogic FastLinQ Driver for iSCSI (qedi) is the iSCSI specific module >> for 41000 Series Converged Network Adapters by QLogic. >> >> This patch consi

PROBLEM:

2016-11-14 Thread Tony
Hello, I am reporting this as requested below: Anthony Buckley, the issue you are reporting is an upstream one. Could you please report this problem following the instructions verbatim at https://wiki.ubuntu.com/Bugs/Upstream/kernel to the appropriate mailing list (TO: Eric Dumazet, and David S.

Re: [PATCH v2 3/6] qedi: Add QLogic FastLinQ offload iSCSI driver framework.

2016-11-14 Thread Hannes Reinecke
On 11/15/2016 07:14 AM, Rangankar, Manish wrote: > Hi Hannes, > > Please find the response below, > > On 11/11/16 10:13 PM, "Hannes Reinecke" wrote: > [ .. ] >> Please use the irq-affinity rework from Christoph here; that'll save you >> the additional msix vectors allocation. > > The existing

RE: [PATCH net-next v5] cadence: Add LSO support.

2016-11-14 Thread Rafal Ozieblo
> > > If UFO is in use it should not silently disable UDP checksums. > > > > > > If you cannot support UFO with proper checksumming, then you cannot > > > enable support for that feature. > > > > According Cadence Gigabit Ethernet MAC documentation: > > > > "Hardware will not calculate the UDP

Re: linux-next: net->netns_ids is used after calling idr_destroy for it

2016-11-14 Thread Andrei Vagin
On Mon, Nov 14, 2016 at 10:23 PM, Andrei Vagin wrote: > Hi Nicolas, > > cleanup_net() calls idr_destroy(net->netns_ids) for network namespaces > and then it calls unregister_netdevice_many() which calls > idr_alloc(net0>netns_ids). It looks wrong, doesn't it? Here is a report from kmemleak detect

linux-next: net->netns_ids is used after calling idr_destroy for it

2016-11-14 Thread Andrei Vagin
Hi Nicolas, cleanup_net() calls idr_destroy(net->netns_ids) for network namespaces and then it calls unregister_netdevice_many() which calls idr_alloc(net0>netns_ids). It looks wrong, doesn't it? I compiled the kernel with the next patch: diff --git a/lib/idr.c b/lib/idr.c index 6098336..c0a3a32

[PATCH v5 5/5] wcn36xx: Don't use the destroyed hal_mutex

2016-11-14 Thread Bjorn Andersson
ieee80211_unregister_hw() might invoke operations to stop the interface, that uses the hal_mutex. So don't destroy it until after we're done using it. Signed-off-by: Bjorn Andersson --- With this patch I can successfully (although with a SMD send timeout in the shutdown path) start and stop the

[PATCH v5 1/5] soc: qcom: smem_state: Fix include for ERR_PTR()

2016-11-14 Thread Bjorn Andersson
The correct include file for getting errno constants and ERR_PTR() is linux/err.h, rather than linux/errno.h, so fix the include. Fixes: e8b123e60084 ("soc: qcom: smem_state: Add stubs for disabled smem_state") Acked-by: Andy Gross Signed-off-by: Bjorn Andersson --- Kalle, please merge this pat

[PATCH v5 4/5] wcn36xx: Implement print_reg indication

2016-11-14 Thread Bjorn Andersson
Some firmware versions sends a "print register indication", handle this by printing out the content. Cc: Nicolas Dechesne Signed-off-by: Bjorn Andersson --- Changes since v4: - None drivers/net/wireless/ath/wcn36xx/hal.h | 16 drivers/net/wireless/ath/wcn36xx/smd.c | 30 +

[PATCH v5 3/5] wcn36xx: Implement firmware assisted scan

2016-11-14 Thread Bjorn Andersson
Using the software based channel scan mechanism from mac80211 keeps us offline for 10-15 second, we should instead issue a start_scan/end_scan on each channel reducing this time. Signed-off-by: Bjorn Andersson --- Changes since v4: - None drivers/net/wireless/ath/wcn36xx/main.c| 64 +++

[PATCH v5 2/5] wcn36xx: Transition driver to SMD client

2016-11-14 Thread Bjorn Andersson
The wcn36xx wifi driver follows the life cycle of the WLAN_CTRL SMD channel, as such it should be a SMD client. This patch makes this transition, now that we have the necessary frameworks available. Signed-off-by: Bjorn Andersson --- Changes since v4: - Added Kconfig dependency to handle depende

Re: [PATCH net] gro_cells: mark napi struct as not busy poll candidates

2016-11-14 Thread Cong Wang
On Mon, Nov 14, 2016 at 4:28 PM, Eric Dumazet wrote: > From: Eric Dumazet > > Rolf Neugebauer reported very long delays at netns dismantle. > > Eric W. Biederman was kind enough to look at this problem > and noticed synchronize_net() occurring from netif_napi_del() that was > added in linux-4.5 >

Disable all network protocols on an interface?

2016-11-14 Thread Ed Swierk
I have a Linux kernel 4.4 system hosting a number of kvm VMs. Physical interface eth0 connects to an 802.1Q trunk port on an external switch. Each VM has a virtual interface (e1000 or virtio-net) connected to the physical NIC through a macvtap interface and a VLAN interface; traffic between the

Re: [PATCH 1/3] tuntap: rx batching

2016-11-14 Thread Michael S. Tsirkin
On Tue, Nov 15, 2016 at 11:14:48AM +0800, Jason Wang wrote: > > > On 2016年11月12日 00:20, Michael S. Tsirkin wrote: > > On Fri, Nov 11, 2016 at 12:28:38PM +0800, Jason Wang wrote: > > > > > > On 2016年11月11日 12:17, John Fastabend wrote: > > > > On 16-11-10 07:31 PM, Michael S. Tsirkin wrote: > > >

Re: [PATCH 2/3] vhost: better detection of available buffers

2016-11-14 Thread Michael S. Tsirkin
On Tue, Nov 15, 2016 at 11:16:59AM +0800, Jason Wang wrote: > > > On 2016年11月12日 00:20, Michael S. Tsirkin wrote: > > On Fri, Nov 11, 2016 at 12:18:50PM +0800, Jason Wang wrote: > > > > > > On 2016年11月11日 11:41, Michael S. Tsirkin wrote: > > > > On Fri, Nov 11, 2016 at 10:18:37AM +0800, Jason Wa

Re: Virtio_net support vxlan encapsulation package TSO offload discuss

2016-11-14 Thread Jason Wang
On 2016年11月10日 14:19, Zhangming (James, Euler) wrote: On 2016年11月09日 15:14, Jason Wang wrote: On 2016年11月08日 19:58, Zhangming (James, Euler) wrote: On 2016年11月08日 19:17, Jason Wang wrote: On 2016年11月08日 19:13, Jason Wang wrote: Cc Michael On 2016年11月08日 16:34, Zhangming (James, Euler) wro

Re: [PATCH 2/3] vhost: better detection of available buffers

2016-11-14 Thread Jason Wang
On 2016年11月12日 00:20, Michael S. Tsirkin wrote: On Fri, Nov 11, 2016 at 12:18:50PM +0800, Jason Wang wrote: On 2016年11月11日 11:41, Michael S. Tsirkin wrote: On Fri, Nov 11, 2016 at 10:18:37AM +0800, Jason Wang wrote: On 2016年11月10日 03:57, Michael S. Tsirkin wrote: On Wed, Nov 09, 2016 at 0

Re: [PATCH 1/3] tuntap: rx batching

2016-11-14 Thread Jason Wang
On 2016年11月12日 00:20, Michael S. Tsirkin wrote: On Fri, Nov 11, 2016 at 12:28:38PM +0800, Jason Wang wrote: On 2016年11月11日 12:17, John Fastabend wrote: On 16-11-10 07:31 PM, Michael S. Tsirkin wrote: On Fri, Nov 11, 2016 at 10:07:44AM +0800, Jason Wang wrote: On 2016年11月10日 00:38, Michael

Re: [PATCH net][v2] bpf: fix range arithmetic for bpf map access

2016-11-14 Thread Alexei Starovoitov
On Mon, Nov 14, 2016 at 03:45:36PM -0500, Josef Bacik wrote: > I made some invalid assumptions with BPF_AND and BPF_MOD that could result in > invalid accesses to bpf map entries. Fix this up by doing a few things > > 1) Kill BPF_MOD support. This doesn't actually get used by the compiler in >

Re: [PATCH v2 net-next 1/5] bpf: Refactor cgroups code in prep for new type

2016-11-14 Thread Alexei Starovoitov
On 11/13/16 7:51 PM, David Ahern wrote: On 10/31/16 11:49 AM, Thomas Graf wrote: On 10/31/16 at 06:16pm, Daniel Mack wrote: On 10/31/2016 06:05 PM, David Ahern wrote: On 10/31/16 11:00 AM, Daniel Mack wrote: Yeah, I'm confused too. I changed that name in my v7 from BPF_PROG_TYPE_CGROUP_SOCK t

[PATCH net-next] tcp: allow to enable the repair mode for non-listening sockets

2016-11-14 Thread Andrei Vagin
The repair mode is used to get and restore sequence numbers and data from queues. It used to checkpoint/restore connections. Currently the repair mode can be enabled for sockets in the established and closed states, but for other states we have to dump the same socket properties, so lets allow to

Re: [PATCH v2 net-next 2/6] bpf: Add percpu LRU list

2016-11-14 Thread Alexei Starovoitov
On Fri, Nov 11, 2016 at 10:55:07AM -0800, Martin KaFai Lau wrote: > Instead of having a common LRU list, this patch allows a > percpu LRU list which can be selected by specifying a map > attribute. The map attribute will be added in the later > patch. > > While the common use case for LRU is #rea

Re: [PATCH v2 net-next 1/6] bpf: LRU List

2016-11-14 Thread Alexei Starovoitov
On Fri, Nov 11, 2016 at 10:55:06AM -0800, Martin KaFai Lau wrote: > Introduce bpf_lru_list which will provide LRU capability to > the bpf_htab in the later patch. > > * General Thoughts: > 1. Target use case. Read is more often than update. >(i.e. bpf_lookup_elem() is more often than bpf_upda

Re: [PATCH v2 net-next 6/6] bpf: Add tests for the LRU bpf_htab

2016-11-14 Thread Alexei Starovoitov
On Fri, Nov 11, 2016 at 10:55:11AM -0800, Martin KaFai Lau wrote: > This patch has some unit tests and a test_lru_dist. > > The test_lru_dist reads in the numeric keys from a file. > The files used here are generated by a modified fio-genzipf tool > originated from the fio test suit. The sample d

Re: [PATCH v2 net-next 5/6] bpf: Add BPF_MAP_TYPE_LRU_PERCPU_HASH

2016-11-14 Thread Alexei Starovoitov
On Fri, Nov 11, 2016 at 10:55:10AM -0800, Martin KaFai Lau wrote: > Provide a LRU version of the existing BPF_MAP_TYPE_PERCPU_HASH > > Signed-off-by: Martin KaFai Lau ... > + /* For LRU, we need to alloc before taking bucket's > + * spinlock because LRU's elem alloc may need > + * t

Re: [PATCH net 2/2] r8152: rx descriptor check

2016-11-14 Thread Francois Romieu
Hayes Wang : > Francois Romieu [mailto:rom...@fr.zoreil.com] > > Sent: Friday, November 11, 2016 8:13 PM > [...] > > Invalid packet size corrupted receive descriptors in Realtek's device > > reminds of CVE-2009-4537. > > Do you mean that the driver would get a packet exceed the size > which is se

Re: [PATCH v3] ip6_output: ensure flow saddr actually belongs to device

2016-11-14 Thread Jason A. Donenfeld
Hey Hannes, David, On Mon, Nov 14, 2016 at 7:33 PM, Hannes Frederic Sowa wrote: > I meant to say, we don't require the IPv6 "API" to behave in a similar > way like the IPv4 one. We do this function pointer trick to allow > _in-kernel_ tree modules to use the function dynamically, even the > kerne

Re: [PATCH net] udp: restore UDPlite many-cast delivery

2016-11-14 Thread Eric Dumazet
On Mon, 2016-11-14 at 23:40 +0100, Pablo Neira Ayuso wrote: > Honor udptable parameter that is passed to __udp*_lib_mcast_deliver(), > otherwise udplite broadcast/multicast use the wrong table and it breaks. > > Fixes: 2dc41cff7545 ("udp: Use hash2 for long hash1 chains in > __udp*_lib_mcast_deli

[PATCH net] gro_cells: mark napi struct as not busy poll candidates

2016-11-14 Thread Eric Dumazet
From: Eric Dumazet Rolf Neugebauer reported very long delays at netns dismantle. Eric W. Biederman was kind enough to look at this problem and noticed synchronize_net() occurring from netif_napi_del() that was added in linux-4.5 Busy polling makes no sense for tunnels NAPI. If busy poll is used

Re: linux-next: BUG: unable to handle kernel NULL pointer dereference in __sk_mem_raise_allocated()

2016-11-14 Thread Eric Dumazet
On Mon, 2016-11-14 at 15:58 -0800, Andrei Vagin wrote: > > Yes, you are right. It works if we set .memory_allocated and .sysctl_mem. Now the question would be : Are we okay if UDP and UDPlite share the same limits ? I would vote for yes, because these default limits are huge anyway (The 50% re

[PATCH net-next V6 6/9] liquidio CN23XX: device states

2016-11-14 Thread Raghu Vatsavayi
Cleaned up resource leaks during destroy resources by introducing more device states. Signed-off-by: Raghu Vatsavayi Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_main.c| 33 -- ..

[PATCH net-next V6 0/9] liquidio CN23XX VF support

2016-11-14 Thread Raghu Vatsavayi
Dave, Following is the V6 patch series for adding VF support on CN23XX devices. This version addressed: 1) Your concern for ordering of local variable declarations from longest to shortest line. 2) Removed module parameters max_vfs, num_queues_per_{p,v}f. 3) Minor changes for fixing new checkpa

[PATCH net-next V6 9/9] liquidio CN23XX: fix for new check patch errors

2016-11-14 Thread Raghu Vatsavayi
New checkpatch script shows some errors with pre-existing driver. This patch provides fix for those errors. Signed-off-by: Raghu Vatsavayi Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas --- .../net/ethernet/cavium/liquidio/cn23xx_pf_regs.h | 12 +--

[PATCH net-next V6 8/9] liquidio CN23XX: copyrights changes and alignment

2016-11-14 Thread Raghu Vatsavayi
Updated copyrights comments and also changed some other comments alignments. Signed-off-by: Raghu Vatsavayi Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas --- .../ethernet/cavium/liquidio/cn23xx_pf_device.c| 53 ++ .../etherne

[PATCH net-next V6 1/9] liquidio CN23XX: HW config for VF support

2016-11-14 Thread Raghu Vatsavayi
Adds support for configuring HW for creating VFs. Signed-off-by: Raghu Vatsavayi Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas --- .../ethernet/cavium/liquidio/cn23xx_pf_device.c| 90 ++ .../net/ethernet/cavium/liquidio/octeo

[PATCH net-next V6 7/9] liquidio CN23XX: code cleanup

2016-11-14 Thread Raghu Vatsavayi
Cleaned up unnecessary comments and added some minor macros. Signed-off-by: Raghu Vatsavayi Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/cn66xx_device.c | 13 - drivers/net/ethernet/cavium/liqu

[PATCH net-next V6 3/9] liquidio CN23XX: Mailbox support

2016-11-14 Thread Raghu Vatsavayi
Adds support for mailbox communication between PF and VF. Signed-off-by: Raghu Vatsavayi Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/Makefile | 1 + drivers/net/ethernet/cavium/liquidio/lio_core.c

[PATCH net-next V6 4/9] liquidio CN23XX: mailbox interrupt processing

2016-11-14 Thread Raghu Vatsavayi
Adds support for mailbox interrupt processing of various commands. Signed-off-by: Raghu Vatsavayi Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas --- .../ethernet/cavium/liquidio/cn23xx_pf_device.c| 157 + drivers/net/ethernet/

[PATCH net-next V6 2/9] liquidio CN23XX: sysfs VF config support

2016-11-14 Thread Raghu Vatsavayi
Adds sysfs based support for enabling or disabling VFs. Signed-off-by: Raghu Vatsavayi Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_main.c| 106 + .../net/ethernet/cavium/liquidio

[PATCH net-next V6 5/9] liquidio CN23XX: VF related operations

2016-11-14 Thread Raghu Vatsavayi
Adds support for VF related operations like mac address vlan and link changes. Signed-off-by: Raghu Vatsavayi Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas --- .../ethernet/cavium/liquidio/cn23xx_pf_device.c| 22 +++ .../ethernet/cavium/liquidi

Re: linux-next: BUG: unable to handle kernel NULL pointer dereference in __sk_mem_raise_allocated()

2016-11-14 Thread Andrei Vagin
On Mon, Nov 14, 2016 at 3:24 PM, Andrei Vagin wrote: > Hi Paolo, > > Our test system detected a kernel oops. Looks like a problem in the > "udp: refactor memory accounting" series. > > # good: [f970bd9e3a06f06df8d8ecf1f8ad2c8615cc17eb] udp: implement > memory accounting helpers > git bisect good f

Re: linux-next: BUG: unable to handle kernel NULL pointer dereference in __sk_mem_raise_allocated()

2016-11-14 Thread Andrei Vagin
On Mon, Nov 14, 2016 at 3:35 PM, Eric Dumazet wrote: > On Mon, 2016-11-14 at 15:24 -0800, Andrei Vagin wrote: >> Hi Paolo, >> >> Our test system detected a kernel oops. Looks like a problem in the >> "udp: refactor memory accounting" series. >> >> # good: [f970bd9e3a06f06df8d8ecf1f8ad2c8615cc17eb]

Re: linux-next: BUG: unable to handle kernel NULL pointer dereference in __sk_mem_raise_allocated()

2016-11-14 Thread Eric Dumazet
On Mon, 2016-11-14 at 15:35 -0800, Eric Dumazet wrote: > > Thanks for the report. > > I guess following patch would be needed ? > > diff --git a/net/ipv4/udplite.c b/net/ipv4/udplite.c > index > af817158d830c0da080935ba29e012dffbb89112..12604c0371c451efcc9aad278bb86be9ac4bb813 > 100644 > ---

Re: qed, qedi patchset submission

2016-11-14 Thread Martin K. Petersen
> "Arun" == Arun Easi writes: Arun, Arun> Do you have any preference or thoughts on how the "qed" patches be Arun> approached? Just as a reference, our rdma driver "qedr" went Arun> through something similar[1], and eventually "qed" patches were Arun> taken by David in the net tree and "qedr

Re: linux-next: BUG: unable to handle kernel NULL pointer dereference in __sk_mem_raise_allocated()

2016-11-14 Thread Eric Dumazet
On Mon, 2016-11-14 at 15:24 -0800, Andrei Vagin wrote: > Hi Paolo, > > Our test system detected a kernel oops. Looks like a problem in the > "udp: refactor memory accounting" series. > > # good: [f970bd9e3a06f06df8d8ecf1f8ad2c8615cc17eb] udp: implement > memory accounting helpers > git bisect goo

linux-next: BUG: unable to handle kernel NULL pointer dereference in __sk_mem_raise_allocated()

2016-11-14 Thread Andrei Vagin
Hi Paolo, Our test system detected a kernel oops. Looks like a problem in the "udp: refactor memory accounting" series. # good: [f970bd9e3a06f06df8d8ecf1f8ad2c8615cc17eb] udp: implement memory accounting helpers git bisect good f970bd9e3a06f06df8d8ecf1f8ad2c8615cc17eb # bad: [2d0e30c30f84d08dc16f

Re: Long delays creating a netns after deleting one (possibly RCU related)

2016-11-14 Thread Eric Dumazet
On Mon, 2016-11-14 at 14:46 -0800, Eric Dumazet wrote: > On Mon, 2016-11-14 at 16:12 -0600, Eric W. Biederman wrote: > > > synchronize_rcu_expidited is not enough if you have multiple network > > devices in play. > > > > Looking at the code it comes down to this commit, and it appears there > > i

Re: [RFC PATCH 2/2] ptr_ring_ll: pop/push multiple objects at once

2016-11-14 Thread Michael S. Tsirkin
On Thu, Nov 10, 2016 at 08:44:32PM -0800, John Fastabend wrote: > Signed-off-by: John Fastabend This will naturally reduce the cache line bounce costs, but so will a _many API for ptr-ring, doing lock-add many-unlock. the number of atomics also scales better with the lock: one per push instead o

mvneta bug with mvneta_set_rx_mode()

2016-11-14 Thread Andrew Lunn
Hi Thomas I think i have found a bug in the mvneta driver, when coupled with DSA. I'm using an Armada 370 RD board, but i expect you can reproduce this in any board using mvneta and a switch. I set the MAC address on a switch interface: root@370-rd:~# ip link set address f2:42:42:42:42:42 dev la

Re: [RFC PATCH 1/2] net: use cmpxchg instead of spinlock in ptr rings

2016-11-14 Thread Michael S. Tsirkin
On Thu, Nov 10, 2016 at 08:44:08PM -0800, John Fastabend wrote: > > --- > include/linux/ptr_ring_ll.h | 136 > +++ > include/linux/skb_array.h | 25 > 2 files changed, 161 insertions(+) > create mode 100644 include/linux/ptr_ring_ll.h > > d

[PATCH v2 iproute2 1/1] tc: print raw qdisc handle.

2016-11-14 Thread Roman Mashak
This is v2 patch with fixed code indentation. Signed-off-by: Roman Mashak Signed-off-by: Jamal Hadi Salim --- tc/tc_qdisc.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/tc/tc_qdisc.c b/tc/tc_qdisc.c index 93c9a4c..6f60002 100644 --- a/tc/tc_qdisc.c +++ b/tc/tc_q

Re: Debugging Ethernet issues

2016-11-14 Thread Mason
On 14/11/2016 22:00, Florian Fainelli wrote: > No I missed that, way too many emails, really. Sorry, I was trying to be thorough, but I went overboard. I'll start a new thread tomorrow, with a smaller CC list (only those who have participated so far) and I'll try to remain concise. Regards.

Re: [PATCH net 1/3] bpf, mlx5: fix mlx5e_create_rq taking reference on prog

2016-11-14 Thread Saeed Mahameed
On 11/14/2016 02:43 AM, Daniel Borkmann wrote: > In mlx5e_create_rq(), when creating a new queue, we call bpf_prog_add() but > without checking the return value. bpf_prog_add() can fail, so we really Didn't know this, thanks for noticing, I wonder why taking a reference for an object would fail

Re: Long delays creating a netns after deleting one (possibly RCU related)

2016-11-14 Thread Eric Dumazet
On Mon, 2016-11-14 at 16:12 -0600, Eric W. Biederman wrote: > synchronize_rcu_expidited is not enough if you have multiple network > devices in play. > > Looking at the code it comes down to this commit, and it appears there > is a promise add rcu grace period combining by Eric Dumazet. > > Eric

Re: [PATCH 0/2] amd-xgbe: AMD XGBE driver updates 2016-11-14

2016-11-14 Thread Tom Lendacky
On 11/14/2016 4:28 PM, Tom Lendacky wrote: > This patch series addresses some minor issues found in the recently > accepted patch series for the AMD XGBE driver. > > The following fixes are included in this driver update series: > > - Fix how a mask is applied to a Clause 37 register value > - Fi

[PATCH net] udp: restore UDPlite many-cast delivery

2016-11-14 Thread Pablo Neira Ayuso
Honor udptable parameter that is passed to __udp*_lib_mcast_deliver(), otherwise udplite broadcast/multicast use the wrong table and it breaks. Fixes: 2dc41cff7545 ("udp: Use hash2 for long hash1 chains in __udp*_lib_mcast_deliver.") Signed-off-by: Pablo Neira Ayuso --- It looks like UDPlite acc

[PATCH net-next v2 2/2] amd-xgbe: Fix up some coccinelle identified warnings

2016-11-14 Thread Tom Lendacky
Fix up some warnings that were identified by coccinelle: Clean up an if/else block that can look confusing since the same statement is executed in an "else if" check and the final "else" statement. Change a variable from unsigned int to int since it is used in an if statement checking the value t

[PATCH net-next v2 1/2] amd-xgbe: Fix mask appliciation for Clause 37 register

2016-11-14 Thread Tom Lendacky
The application of a mask to clear an area of a clause 37 register value was not properly applied. Update the code to do the proper application of the mask. Reported-by: Marion & Christophe JAILLET Signed-off-by: Tom Lendacky --- drivers/net/ethernet/amd/xgbe/xgbe-mdio.c |4 ++-- 1 file cha

[PATCH net-next v2 0/2] amd-xgbe: AMD XGBE driver updates 2016-11-14

2016-11-14 Thread Tom Lendacky
(Resending with net-next in the subject) This patch series addresses some minor issues found in the recently accepted patch series for the AMD XGBE driver. The following fixes are included in this driver update series: - Fix how a mask is applied to a Clause 37 register value - Fix some coccinel

Re: [patch] netlink.7: srcfix Change buffer size in example code about reading netlink message.

2016-11-14 Thread Rick Jones
Lets change the example so others don't propagate the problem further. Signed-off-by David Wilder --- man7/netlink.7.orig 2016-11-14 13:30:36.522101156 -0800 +++ man7/netlink.7 2016-11-14 13:30:51.002086354 -0800 @@ -511,7 +511,7 @@ .in +4n .nf int len; -char buf[4096]; +char buf[8192];

[PATCH 0/2] amd-xgbe: AMD XGBE driver updates 2016-11-14

2016-11-14 Thread Tom Lendacky
This patch series addresses some minor issues found in the recently accepted patch series for the AMD XGBE driver. The following fixes are included in this driver update series: - Fix how a mask is applied to a Clause 37 register value - Fix some coccinelle identified warnings This patch series

[PATCH 2/2] amd-xgbe: Fix up some coccinelle identified warnings

2016-11-14 Thread Tom Lendacky
Fix up some warnings that were identified by coccinelle: Clean up an if/else block that can look confusing since the same statement is executed in an "else if" check and the final "else" statement. Change a variable from unsigned int to int since it is used in an if statement checking the value t

[PATCH 1/2] amd-xgbe: Fix mask appliciation for Clause 37 register

2016-11-14 Thread Tom Lendacky
The application of a mask to clear an area of a clause 37 register value was not properly applied. Update the code to do the proper application of the mask. Reported-by: Marion & Christophe JAILLET Signed-off-by: Tom Lendacky --- drivers/net/ethernet/amd/xgbe/xgbe-mdio.c |4 ++-- 1 file cha

Re: [PATCH net] ipv4: fix cloning issues in fib_trie_unmerge()

2016-11-14 Thread Alexander Duyck
On Mon, Nov 14, 2016 at 1:34 PM, Eric Dumazet wrote: > From: Eric Dumazet > > I had crashes in a DEBUG_PAGEALLOC kernels in fib_table_flush() or > fib_table_lookup() that I back tracked to a refcounting issue > happening when we clone struct fib_alias in fib_trie_unmerge() > > While fixing this i

[patch] netlink.7: srcfix Change buffer size in example code about reading netlink message.

2016-11-14 Thread dwilder
The example code in netlink(7) (for reading netlink message) suggests using a 4k read buffer with recvmsg. This can cause truncated messages on systems using a page size is >4096. Please see: linux/include/linux/netlink.h (in the kernel source) /* * skb should fit one page. This choice

Re: Long delays creating a netns after deleting one (possibly RCU related)

2016-11-14 Thread Eric W. Biederman
"Paul E. McKenney" writes: > On Mon, Nov 14, 2016 at 09:44:35AM -0800, Cong Wang wrote: >> On Mon, Nov 14, 2016 at 8:24 AM, Paul E. McKenney >> wrote: >> > On Sun, Nov 13, 2016 at 10:47:01PM -0800, Cong Wang wrote: >> >> On Fri, Nov 11, 2016 at 4:55 PM, Cong Wang >> >> wrote: >> >> > On Fri, N

qed, qedi patchset submission

2016-11-14 Thread Arun Easi
Hi Martin, David, This is regarding the submission of the recent patch series we have posted to linux-scsi and netdev: [PATCH v2 0/6] Add QLogic FastLinQ iSCSI (qedi) driver. [PATCH v2 1/6] qed: Add support for hardware offloaded iSCSI. [PATCH v2 2/6] qed: Add iSCSI out of order packe

Re: [PATCH] net/phy/vitesse: Configure RGMII skew on VSC8601, if needed

2016-11-14 Thread Alex
On 11/14/2016 01:25 PM, Florian Fainelli wrote: On 11/14/2016 01:18 PM, David Miller wrote: From: Alexandru Gagniuc Date: Sat, 12 Nov 2016 15:32:13 -0800 + if (phydev->interface == PHY_INTERFACE_MODE_RGMII_ID) + ret = vsc8601_add_skew(phydev); I think you should use ph

[GIT] Networking

2016-11-14 Thread David Miller
1) Fix off by one wrt. indexing when dumping /proc/net/route entries, from Alexander Duyck. 2) Fix lockdep splats in iwlwifi, from Johannes Berg. 3) Cure panic when inserting certain netfilter rules when NFT_SET_HASH is disabled, from Liping Zhang. 4) Memory leak when nft_expr_clone() fai

Re: [patch net] mlxsw: spectrum_router: Flush FIB tables during fini

2016-11-14 Thread David Miller
From: Jiri Pirko Date: Mon, 14 Nov 2016 11:26:32 +0100 > From: Ido Schimmel > > Since commit b45f64d16d45 ("mlxsw: spectrum_router: Use FIB notifications > instead of switchdev calls") we reflect to the device the entire FIB > table and not only FIBs that point to netdevs created by the driver.

Re: [PATCH net] net: stmmac: Fix lack of link transition for fixed PHYs

2016-11-14 Thread David Miller
From: Florian Fainelli Date: Sun, 13 Nov 2016 17:50:35 -0800 > Commit 52f95bbfcf72 ("stmmac: fix adjust link call in case of a switch > is attached") added some logic to avoid polling the fixed PHY and > therefore invoking the adjust_link callback more than once, since this > is a fixed PHY and l

Re: [PATCH net-next] mdio: Demote print from info to debug in mdio_driver_register

2016-11-14 Thread David Miller
From: Florian Fainelli Date: Sun, 13 Nov 2016 19:01:17 -0800 > While it is useful to know which MDIO driver is being registered, demote > the pr_info() to a pr_debug(). > > Signed-off-by: Florian Fainelli Applied, thanks.

Re: [PATCH net-next 1/1] driver: macvlan: Replace integer number with bool value

2016-11-14 Thread David Miller
From: f...@ikuai8.com Date: Mon, 14 Nov 2016 08:24:19 +0800 > From: Gao Feng > > The return value of function macvlan_addr_busy is used as bool value, > so use bool value instead of integer number "1" and "0". > > Signed-off-by: Gao Feng Applied, thanks.

[PATCH] can: spi: hi311x: fix semicolon.cocci warnings (fwd)

2016-11-14 Thread Julia Lawall
Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci CC: Akshay Bhat Signed-off-by: Julia Lawall Signed-off-by: Fengguang Wu --- It's a minor issue, but may as well fix it up now. The tree this code is from is as follows: url: https://github.com/0day-ci/linux/co

[PATCH net] ipv4: fix cloning issues in fib_trie_unmerge()

2016-11-14 Thread Eric Dumazet
From: Eric Dumazet I had crashes in a DEBUG_PAGEALLOC kernels in fib_table_flush() or fib_table_lookup() that I back tracked to a refcounting issue happening when we clone struct fib_alias in fib_trie_unmerge() While fixing this issue, I also noticed a mem leak happening if fib_insert_alias() fa

Re: [PATCH] net: stmmac: Add support for ethtool::nway_reset

2016-11-14 Thread David Miller
From: Florian Fainelli Date: Sun, 13 Nov 2016 13:35:04 -0800 > Le 13/11/2016 à 13:24, Florian Fainelli a écrit : >> If we have a PHY device, just invoke genphy_restart_aneg() to restart >> auto-negotiation. >> >> Signed-off-by: Florian Fainelli > > David, please drop this patch for now, since

Re: [PATCH net-next 00/11] Start adding support for mv88e6390 family

2016-11-14 Thread David Miller
From: Andrew Lunn Date: Sun, 13 Nov 2016 21:24:03 +0100 > I'm happy to respin, but i'm wondering why the don't apply. Andrew, even though this issue has been resolved, it looks like Vivien has some feedback for you to address with this series so I guess I'll see a v2 or similar soon. Thanks.

Re: [PATCH] net/phy/vitesse: Configure RGMII skew on VSC8601, if needed

2016-11-14 Thread Florian Fainelli
On 11/14/2016 01:18 PM, David Miller wrote: > From: Alexandru Gagniuc > Date: Sat, 12 Nov 2016 15:32:13 -0800 > >> +if (phydev->interface == PHY_INTERFACE_MODE_RGMII_ID) >> +ret = vsc8601_add_skew(phydev); > > I think you should use phy_interface_is_rgmii() here. > This would i

Re: [PATCH net] sctp: change sk state only when it has assocs in sctp_shutdown

2016-11-14 Thread David Miller
From: Xin Long Date: Sun, 13 Nov 2016 21:44:37 +0800 > Now when users shutdown a sock with SEND_SHUTDOWN in sctp, even if > this sock has no connection (assoc), sk state would be changed to > SCTP_SS_CLOSING, which is not as we expect. > > Besides, after that if users try to listen on this sock,

Re: [PATCH v2 0/2] bnx2: Wait for in-flight DMA to complete at probe stage

2016-11-14 Thread David Miller
From: Baoquan He Date: Sun, 13 Nov 2016 13:01:31 +0800 > This is v2 post. > > In commit 3e1be7a ("bnx2: Reset device during driver initialization"), > firmware requesting code was moved from open stage to probe stage. > The reason is in kdump kernel hardware iommu need device be reset in > drive

Re: [PATCH] net/phy/vitesse: Configure RGMII skew on VSC8601, if needed

2016-11-14 Thread David Miller
From: Alexandru Gagniuc Date: Sat, 12 Nov 2016 15:32:13 -0800 > + if (phydev->interface == PHY_INTERFACE_MODE_RGMII_ID) > + ret = vsc8601_add_skew(phydev); I think you should use phy_interface_is_rgmii() here.

Re: Debugging Ethernet issues

2016-11-14 Thread Florian Fainelli
On 11/14/2016 12:27 PM, Mason wrote: > On 14/11/2016 19:20, Florian Fainelli wrote: > >> On 11/14/2016 09:59 AM, Sebastian Frias wrote: >> >>> Could you confirm that Mason's patch is correct and/or that it does not >>> has negative side-effects? >> >> The patch is not correct nor incorrect per-se,

Re: [PATCH v2 net-next 4/6] bpf: Add BPF_MAP_TYPE_LRU_HASH

2016-11-14 Thread Alexei Starovoitov
On Fri, Nov 11, 2016 at 10:55:09AM -0800, Martin KaFai Lau wrote: > Provide a LRU version of the existing BPF_MAP_TYPE_HASH. > > Signed-off-by: Martin KaFai Lau ... > +/* Instead of having one common LRU list in the > + * BPF_MAP_TYPE_LRU_HASH map, use a percpu LRU list > + * which can scale and

Re: [RFC v4 00/18] Landlock LSM: Unprivileged sandboxing

2016-11-14 Thread Mickaël Salaün
On 14/11/2016 11:35, Sargun Dhillon wrote: > Was there a plan around getting Daniel's patches in as well? Also, > rather than making these handles landlock-specific, can they be > implemented in such a way where we can keep track of (some) of these > in other types of programs? > About the map o

[PATCH net][v2] bpf: fix range arithmetic for bpf map access

2016-11-14 Thread Josef Bacik
I made some invalid assumptions with BPF_AND and BPF_MOD that could result in invalid accesses to bpf map entries. Fix this up by doing a few things 1) Kill BPF_MOD support. This doesn't actually get used by the compiler in real life and just adds extra complexity. 2) Fix the logic for BPF_AND,

Re: Debugging Ethernet issues

2016-11-14 Thread Mason
On 14/11/2016 19:20, Florian Fainelli wrote: > On 11/14/2016 09:59 AM, Sebastian Frias wrote: > >> Could you confirm that Mason's patch is correct and/or that it does not >> has negative side-effects? > > The patch is not correct nor incorrect per-se, it changes the default > policy of having pau

Re: Debugging Ethernet issues

2016-11-14 Thread Florian Fainelli
On 11/14/2016 11:00 AM, Måns Rullgård wrote: > Florian Fainelli writes: > >> On 11/14/2016 10:20 AM, Florian Fainelli wrote: >>> On 11/14/2016 09:59 AM, Sebastian Frias wrote: On 11/14/2016 06:32 PM, Florian Fainelli wrote: > On 11/14/2016 07:33 AM, Mason wrote: >> On 14/11/2016 15:5

Haster Response.//..

2016-11-14 Thread UNCLAIMED ASSET
Mr. Steve Bhatti, Drift / regionsjef Santander Bank Plc, 47-48 Piccadilly PICCADILLY W1J0DT London, Storbritannia Hei, Jeg er Steve Bhatti, fra Harlesden North West London, leder for regnskap Revisjonen og formell senior programmerer sjef hos Deutsche bank, her i England (Santander Bank Plc).

Re: AF_VSOCK loopback

2016-11-14 Thread Stefan Hajnoczi
On Fri, Nov 11, 2016 at 02:14:44PM +, Jorgen S. Hansen wrote: > Hi Stefan, > > All datagram communication in VMCI based AF_VSOCK is going through the host - > also for loopback communication. The only difference wrt loopback is that the > VMCI queue pairs implementing the shared queues for t

[PATCH 0/3 v5] Fixes for running a big-endian kernel on Cubieboard2

2016-11-14 Thread Michael Weiser
the following patches are what remains to be fixed in order to allow running a big-endian kernel on the Cubieboard2. The first patch fixes up endianness problems with DMA descriptors in the stmmac driver preventing it from working correctly when runnning a big-endian kernel. The second patch adds

[PATCH 3/3] net: ethernet: sun4i-emac: Read rxhdr in CPU byte-order

2016-11-14 Thread Michael Weiser
The EMAC EMAC_RX_IO_DATA_REG data register is dual-purpose: On one hand it is used to move actual packet data off the wire. This will be in wire-format and accepted as such by higher layers such as IP. Therefore it is correctly read as-is (i.e. raw) using readsl. On the other hand it provides meta

Re: [PATCH net 2/3] bpf, mlx5: fix various refcount/prog issues in mlx5e_xdp_set

2016-11-14 Thread Daniel Borkmann
On 11/14/2016 07:27 PM, Saeed Mahameed wrote: On 11/14/2016 02:43 AM, Daniel Borkmann wrote: There are multiple issues in mlx5e_xdp_set(): 1) prog can be NULL, so calling unconditionally into bpf_prog_add(prog, priv->params.num_channels) can end badly. not correct, if prog is null we will

Re: Debugging Ethernet issues

2016-11-14 Thread Måns Rullgård
Florian Fainelli writes: > On 11/14/2016 10:20 AM, Florian Fainelli wrote: >> On 11/14/2016 09:59 AM, Sebastian Frias wrote: >>> On 11/14/2016 06:32 PM, Florian Fainelli wrote: On 11/14/2016 07:33 AM, Mason wrote: > On 14/11/2016 15:58, Mason wrote: > >> nb8800 26000.ethernet eth

[PATCH 1/3] net: ethernet: stmmac: change dma descriptors to __le32

2016-11-14 Thread Michael Weiser
The stmmac driver does not take into account the processor may be big endian when writing the DMA descriptors. This causes the ethernet interface not to be initialised correctly when running a big-endian kernel. Change the descriptors for DMA to use __le32 and ensure they are suitably swapped befor

Re: [PATCH 2/3] net: ethernet: sun4i-emac: Allow to enable netif messages

2016-11-14 Thread Maxime Ripard
On Mon, Nov 14, 2016 at 06:58:06PM +0100, Michael Weiser wrote: > sun4i-emac has the ability to print a number of diagnostic messages using > dev_dbg depending on message level settings implemented using netif_msg_* > macros. But there's no way to actually enable them. > > Add the ability to switc

[PATCH 2/3] net: ethernet: sun4i-emac: Allow to enable netif messages

2016-11-14 Thread Michael Weiser
sun4i-emac has the ability to print a number of diagnostic messages using dev_dbg depending on message level settings implemented using netif_msg_* macros. But there's no way to actually enable them. Add the ability to switch diagnostic messages on using either a module parameter debug or ethtool

Re: [PATCH 3/3] net: ethernet: sun4i-emac: Read rxhdr in CPU byte-order

2016-11-14 Thread Maxime Ripard
On Mon, Nov 14, 2016 at 06:58:07PM +0100, Michael Weiser wrote: > The EMAC EMAC_RX_IO_DATA_REG data register is dual-purpose: On one hand > it is used to move actual packet data off the wire. This will be in > wire-format and accepted as such by higher layers such as IP. Therefore > it is correctly

Re: [PATCH net-next] bpf: fix range arithmetic for bpf map access

2016-11-14 Thread Josef Bacik
On 11/11/2016 10:13 PM, Alexei Starovoitov wrote: On Fri, Nov 11, 2016 at 04:47:39PM -0500, Josef Bacik wrote: I made some invalid assumptions with BPF_AND and BPF_MOD that could result in invalid accesses to bpf map entries. Fix this up by doing a few things 1) Kill BPF_MOD support. This doe

Re: [PATCH net 2/3] bpf, mlx5: fix various refcount/prog issues in mlx5e_xdp_set

2016-11-14 Thread Saeed Mahameed
On 11/14/2016 02:43 AM, Daniel Borkmann wrote: > There are multiple issues in mlx5e_xdp_set(): > > 1) prog can be NULL, so calling unconditionally into bpf_prog_add(prog, >priv->params.num_channels) can end badly. not correct, if prog is null we will never get to bpf_prog_add: rese

Re: [PATCH v2 net-next 3/6] bpf: Refactor codes handling percpu map

2016-11-14 Thread Alexei Starovoitov
On Fri, Nov 11, 2016 at 10:55:08AM -0800, Martin KaFai Lau wrote: > Refactor the codes that populate the value > of a htab_elem in a BPF_MAP_TYPE_PERCPU_HASH > typed bpf_map. > > Signed-off-by: Martin KaFai Lau Acked-by: Alexei Starovoitov

  1   2   3   >