Re: [PATCH v2 1/2 nf] netfilter: seqadj: Fix one possible panic in seqadj when mem is exhausted

2016-09-01 Thread Florian Westphal
f...@ikuai8.com wrote: > From: Gao Feng > > When memory is exhausted, nfct_seqadj_ext_add may fail to add the seqadj > extension. But the function nf_ct_seqadj_init doesn't check if get valid > seqadj pointer by the nfct_seqadj, while other functions perform the > sanity check. > > So the syste

Re: [PATCH 2/2 nf-next] netfilter: seqadj: print the warning log when fail to add seqadj extension

2016-09-01 Thread Florian Westphal
f...@ikuai8.com wrote: > From: Gao Feng > > Print the warning log when fail to add seqadj extension like > nf_ct_acct_ext_add does. It could be helpful to find the problem. Failure to add ext area means that we're pretty much completely out of memory. There is nothing the user could do, so pr_

Re: [PATCH v3] mISDN: mark symbols static where possible

2016-09-01 Thread David Miller
From: Baoyou Xie Date: Thu, 1 Sep 2016 14:16:24 +0800 > We get a few warnings when building kernel with W=1: > drivers/isdn/hardware/mISDN/hfcmulti.c:568:1: warning: no previous > declaration for 'enablepcibridge' [-Wmissing-declarations] > drivers/isdn/hardware/mISDN/hfcmulti.c:574:1: warning:

Re: [PATCH] ipv6: Don't unset flowi6_proto in ipxip6_tnl_xmit()

2016-09-01 Thread David Miller
From: Eli Cooper Date: Thu, 1 Sep 2016 09:18:04 +0800 > Hello, > > On 2016/9/1 4:56, David Miller wrote: >> From: Eli Cooper >> Date: Fri, 26 Aug 2016 23:52:29 +0800 >> >>> @@ -1174,6 +1174,7 @@ ip4ip6_tnl_xmit(struct sk_buff *skb, struct >>> net_device *dev) >>> encap_limit = t->p

Re: [PATCH] softirq: let ksoftirqd do its job

2016-09-01 Thread David Miller
From: Eric Dumazet Date: Wed, 31 Aug 2016 10:42:29 -0700 > From: Eric Dumazet > > A while back, Paolo and Hannes sent an RFC patch adding threaded-able > napi poll loop support : (https://patchwork.ozlabs.org/patch/620657/) > > The problem seems to be that softirqs are very aggressive and are

Re: [PATCH] [v10] net: emac: emac gigabit ethernet controller driver

2016-09-01 Thread David Miller
From: Timur Tabi Date: Wed, 31 Aug 2016 18:22:08 -0500 > Add support for the Qualcomm Technologies, Inc. EMAC gigabit Ethernet > controller. > > This driver supports the following features: > 1) Checksum offload. > 2) Interrupt coalescing support. > 3) SGMII phy. > 4) phylib interface for extern

Re: [Patch v4 01/12] microblaze: irqchip: Move intc driver to irqchip

2016-09-01 Thread Michal Simek
On 1.9.2016 18:50, Zubair Lutfullah Kakakhel wrote: > The Xilinx AXI Interrupt Controller IP block is used by the MIPS > based xilfpga platform. > > Move the interrupt controller code out of arch/microblaze so that > it can be used by everyone > > Signed-off-by: Zubair Lutfullah Kakakhel > > --

Re: [PATCH net-next 1/1] rxrpc: Don't expose skbs to in-kernel users [ver #2]

2016-09-01 Thread David Howells
David Miller wrote: > Ok, I tried this one instead. If no warnings, I'll push it to net-next. Thanks, David

[RFC Patch net-next 4/6] net_sched: introduce tcf_hash_copy()

2016-09-01 Thread Cong Wang
Signed-off-by: Cong Wang --- include/net/act_api.h | 1 + net/sched/act_api.c | 18 ++ 2 files changed, 19 insertions(+) diff --git a/include/net/act_api.h b/include/net/act_api.h index a374bab..17837af 100644 --- a/include/net/act_api.h +++ b/include/net/act_api.h @@ -166,6 +

[RFC Patch net-next 6/6] net_sched: switch to RCU API for act_mirred

2016-09-01 Thread Cong Wang
Signed-off-by: Cong Wang --- net/sched/act_mirred.c | 41 +++-- 1 file changed, 19 insertions(+), 22 deletions(-) diff --git a/net/sched/act_mirred.c b/net/sched/act_mirred.c index 6038c85..90a024c 100644 --- a/net/sched/act_mirred.c +++ b/net/sched/act_mirred

[RFC Patch net-next 5/6] net_sched: use rcu in fast path

2016-09-01 Thread Cong Wang
Signed-off-by: Cong Wang --- net/sched/act_api.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/net/sched/act_api.c b/net/sched/act_api.c index 2f8db3c..fb6ff52 100644 --- a/net/sched/act_api.c +++ b/net/sched/act_api.c @@ -470,10 +470,14 @@ int tcf_action_exec(struct sk

[RFC Patch net-next 2/6] net_sched: introduce tcf_hash_replace()

2016-09-01 Thread Cong Wang
This API is used to replace the old action in hash table with the new one. It is used by the following patch. Cc: Jamal Hadi Salim Signed-off-by: Cong Wang --- include/net/act_api.h | 2 ++ net/sched/act_api.c | 20 2 files changed, 22 insertions(+) diff --git a/include

Re: [PATCH v2 net] rps: flow_dissector: Fix uninitialized flow_keys used in __skb_get_hash possibly

2016-09-01 Thread David Miller
From: f...@ikuai8.com Date: Wed, 31 Aug 2016 14:15:05 +0800 > From: Gao Feng > > The original codes depend on that the function parameters are evaluated from > left to right. But the parameter's evaluation order is not defined in C > standard actually. > > When flow_keys_have_l4(&keys) is invok

[RFC Patch net-next 3/6] net_sched: return NULL in tcf_hash_check()

2016-09-01 Thread Cong Wang
When we don't find an action with a specific index, we only return false but not touch *a. It is nicer if we could set *a to NULL here, this would make callers easier to use these API's. Cc: Jamal Hadi Salim Signed-off-by: Cong Wang --- net/sched/act_api.c | 1 + 1 file changed, 1 insertion(+)

[RFC Patch net-next 1/6] net_sched: use RCU for action hash table

2016-09-01 Thread Cong Wang
We already free tc actions in a RCU callback, so here we just need to convert the hash table operations to RCU API's. Cc: Jamal Hadi Salim Signed-off-by: Cong Wang --- net/sched/act_api.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/net/sched/act_api.c b/ne

[RFC Patch net-next 0/6] net_sched: really switch to RCU for tc actions

2016-09-01 Thread Cong Wang
Currently there are only two tc actions lockless: gact and mirred. But they are questionable because we don't have anything to prevent a parallel update on an existing tc action in hash table while reading it on fast path, this could be a problem when a tc action becomes complex. This patchset int

Re: [Patch v4 01/12] microblaze: irqchip: Move intc driver to irqchip

2016-09-01 Thread Michal Simek
On 1.9.2016 18:50, Zubair Lutfullah Kakakhel wrote: > The Xilinx AXI Interrupt Controller IP block is used by the MIPS > based xilfpga platform. > > Move the interrupt controller code out of arch/microblaze so that > it can be used by everyone if this is just move that you should setup your git r

Re: [PATCH net-next] net: dsa: remove ds_to_priv

2016-09-01 Thread David Miller
From: Vivien Didelot Date: Wed, 31 Aug 2016 18:06:13 -0400 > Access the priv member of the dsa_switch structure directly, instead of > having an unnecessary helper. > > Signed-off-by: Vivien Didelot Applied.

Re: [PATCH net v2] bnx2x: don't reset chip on cleanup if PCI function is offline

2016-09-01 Thread David Miller
From: "Guilherme G. Piccoli" Date: Wed, 31 Aug 2016 12:11:57 -0300 > When PCI error is detected, in some architectures (like PowerPC) a slot > reset is performed - the driver's error handlers are in charge of "disable" > device before the reset, and re-enable it after a successful slot reset. >

Re: [PATCH net-next v3 0/2] net: bridge: add per-port unknown multicast flood control

2016-09-01 Thread David Miller
From: Nikolay Aleksandrov Date: Wed, 31 Aug 2016 15:36:50 +0200 > The first patch prepares the forwarding path by having the exact packet > type passed down so we can later filter based on it and the per-port > unknown mcast flood flag introduced in the second patch. It is similar to > how the pe

Re: [PATCH v3 0/5] meson: Meson8b and GXBB DWMAC glue driver

2016-09-01 Thread David Miller
From: Kevin Hilman Date: Thu, 01 Sep 2016 21:23:52 -0700 > David Miller writes: > >> From: Martin Blumenstingl >> Date: Tue, 30 Aug 2016 20:49:28 +0200 >> >>> On Mon, Aug 29, 2016 at 5:40 AM, David Miller wrote: From: Martin Blumenstingl Date: Sun, 28 Aug 2016 18:16:32 +0200 >

[PATCH] net: Don't delete routes in different VRFs

2016-09-01 Thread Mark Tomlinson
When deleting an IP address from an interface, there is a clean-up of routes which refer to this local address. However, there was no check to see that the VRF matched. This meant that deletion wasn't confined to the VRF it should have been. To solve this, a new field has been added to fib_info to

[PATCH net] bonding: Fix bonding crash

2016-09-01 Thread Mahesh Bandewar
From: Mahesh Bandewar Following few steps will crash kernel - (a) Create bonding master > modprobe bonding miimon=50 (b) Create macvlan bridge on eth2 > ip link add link eth2 dev mvl0 address aa:0:0:0:0:01 \ type macvlan (c) Now try adding eth2 into the bond >

[PATCH v2 1/2 nf] netfilter: seqadj: Fix one possible panic in seqadj when mem is exhausted

2016-09-01 Thread fgao
From: Gao Feng When memory is exhausted, nfct_seqadj_ext_add may fail to add the seqadj extension. But the function nf_ct_seqadj_init doesn't check if get valid seqadj pointer by the nfct_seqadj, while other functions perform the sanity check. So the system would be panic when nfct_seqadj_ext_ad

Re: [PATCH 1/2 nf] netfilter: seqadj: Fix some possible panics of seqadj when mem is exhausted

2016-09-01 Thread Gao Feng
Hi Liping, On Fri, Sep 2, 2016 at 12:50 PM, Liping Zhang wrote: > Hi Feng, > 2016-09-02 9:48 GMT+08:00 : >> From: Gao Feng >> @@ -171,6 +176,11 @@ int nf_ct_seq_adjust(struct sk_buff *skb, >> struct nf_ct_seqadj *this_way, *other_way; >> int res; >> >> + if (unlikely(!seqa

Re: [PATCH net-next] rtnetlink: fdb dump: optimize by saving last interface markers

2016-09-01 Thread Eric Dumazet
On Tue, 2016-08-30 at 21:56 -0700, Roopa Prabhu wrote: > From: Roopa Prabhu > @@ -342,7 +342,7 @@ static inline int switchdev_port_fdb_dump(struct sk_buff > *skb, > struct netlink_callback *cb, > struct net_device *d

[Patch net-next 1/2] vxlan: call peernet2id() in fdb notification

2016-09-01 Thread Cong Wang
netns id should be already allocated each time we change netns, that is, in dev_change_net_namespace() (more precisely in rtnl_fill_ifinfo()). It is safe to just call peernet2id() here. Cc: Nicolas Dichtel Signed-off-by: Cong Wang --- drivers/net/vxlan.c | 2 +- net/core/net_namespace.c |

[Patch net-next 2/2] netns: avoid disabling irq for netns id

2016-09-01 Thread Cong Wang
We never read or change netns id in hardirq context, the only place we read netns id in softirq context is in vxlan_xmit(). So, it should be enough to just disable BH. Cc: Nicolas Dichtel Signed-off-by: Cong Wang --- net/core/net_namespace.c | 35 +++ 1 file chan

[Patch net-next 0/2] net: some minor optimization for netns id

2016-09-01 Thread Cong Wang
Cong Wang (2): vxlan: call peernet2id() in fdb notification netns: avoid disabling irq for netns id drivers/net/vxlan.c | 2 +- net/core/net_namespace.c | 37 - 2 files changed, 17 insertions(+), 22 deletions(-) -- 2.1.0

Re: [PATCH 1/2 nf] netfilter: seqadj: Fix some possible panics of seqadj when mem is exhausted

2016-09-01 Thread Liping Zhang
Hi Feng, 2016-09-02 9:48 GMT+08:00 : > From: Gao Feng > @@ -171,6 +176,11 @@ int nf_ct_seq_adjust(struct sk_buff *skb, > struct nf_ct_seqadj *this_way, *other_way; > int res; > > + if (unlikely(!seqadj)) { IPS_SEQ_ADJUST_BIT will be tested before we call nf_ct_seq_adjust(),

Re: [PATCH v3 0/5] meson: Meson8b and GXBB DWMAC glue driver

2016-09-01 Thread Kevin Hilman
David Miller writes: > From: Martin Blumenstingl > Date: Tue, 30 Aug 2016 20:49:28 +0200 > >> On Mon, Aug 29, 2016 at 5:40 AM, David Miller wrote: >>> From: Martin Blumenstingl >>> Date: Sun, 28 Aug 2016 18:16:32 +0200 >>> This adds a DWMAC glue driver for the PRG_ETHERNET registers found

[PATCH 2/2 nf-next] netfilter: seqadj: print the warning log when fail to add seqadj extension

2016-09-01 Thread fgao
From: Gao Feng Print the warning log when fail to add seqadj extension like nf_ct_acct_ext_add does. It could be helpful to find the problem. Signed-off-by: Gao Feng --- include/net/netfilter/nf_conntrack_seqadj.h | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/inclu

[PATCH 1/2 nf] netfilter: seqadj: Fix some possible panics of seqadj when mem is exhausted

2016-09-01 Thread fgao
From: Gao Feng When memory is exhausted, nfct_seqadj_ext_add may fail to add the seqadj extension. But these interface functions nf_ct_seqadj_init and nf_ct_seq_adjust don't check if they get the valid seqadj pointer by the nfct_seqadj, while nf_ct_seqadj_set and nf_ct_seq_offset perform that che

[PATCH v3 net-next 4/6] perf, bpf: add perf events core support for BPF_PROG_TYPE_PERF_EVENT programs

2016-09-01 Thread Alexei Starovoitov
Allow attaching BPF_PROG_TYPE_PERF_EVENT programs to sw and hw perf events via overflow_handler mechanism. When program is attached the overflow_handlers become stacked. The program acts as a filter. Returning zero from the program means that the normal perf_event_output handler will not be called

[PATCH v3 net-next 3/6] bpf: perf_event progs should only use preallocated maps

2016-09-01 Thread Alexei Starovoitov
Make sure that BPF_PROG_TYPE_PERF_EVENT programs only use preallocated hash maps, since doing memory allocation in overflow_handler can crash depending on where nmi got triggered. Signed-off-by: Alexei Starovoitov Acked-by: Daniel Borkmann --- kernel/bpf/verifier.c | 22 +-

[PATCH v3 net-next 6/6] samples/bpf: add sampleip example

2016-09-01 Thread Alexei Starovoitov
From: Brendan Gregg sample instruction pointer and frequency count in a BPF map Signed-off-by: Brendan Gregg Signed-off-by: Alexei Starovoitov --- samples/bpf/Makefile| 4 + samples/bpf/sampleip_kern.c | 38 + samples/bpf/sampleip_user.c | 196 ++

[PATCH v3 net-next 5/6] samples/bpf: add perf_event+bpf example

2016-09-01 Thread Alexei Starovoitov
The bpf program is called 50 times a second and does hashmap[kern&user_stackid]++ It's primary purpose to check that key bpf helpers like map lookup, update, get_stackid, trace_printk and ctx access are all working. It checks: - PERF_COUNT_HW_CPU_CYCLES on all cpus - PERF_COUNT_HW_CPU_CYCLES for c

[PATCH v3 net-next 1/6] bpf: support 8-byte metafield access

2016-09-01 Thread Alexei Starovoitov
The verifier supported only 4-byte metafields in struct __sk_buff and struct xdp_md. The metafields in upcoming struct bpf_perf_event are 8-byte to match register width in struct pt_regs. Teach verifier to recognize 8-byte metafield access. The patch doesn't affect safety of sockets and xdp program

[PATCH v3 net-next 2/6] bpf: introduce BPF_PROG_TYPE_PERF_EVENT program type

2016-09-01 Thread Alexei Starovoitov
Introduce BPF_PROG_TYPE_PERF_EVENT programs that can be attached to HW and SW perf events (PERF_TYPE_HARDWARE and PERF_TYPE_SOFTWARE correspondingly in uapi/linux/perf_event.h) The program visible context meta structure is struct bpf_perf_event_data { struct pt_regs regs; __u64 sample_per

[PATCH v3 net-next 0/6] perf, bpf: add support for bpf in sw/hw perf_events

2016-09-01 Thread Alexei Starovoitov
Hi Peter, Dave, this patch set is a follow up to the discussion: https://lkml.kernel.org/r/20160804142853.GO6862%20()%20twins%20!%20programming%20!%20kicks-ass%20!%20net It turned out to be simpler than what we discussed. Patches 1-3 is bpf-side prep for the main patch 4 that adds bpf program as

Re: [Patch v4 02/12] irqchip: axi-intc: Clean up irqdomain argument and read/write

2016-09-01 Thread kbuild test robot
Hi Zubair, [auto build test WARNING on tip/irq/core] [also build test WARNING on v4.8-rc4 next-20160825] [cannot apply to linus/master linux/master] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] [Suggest to use git(>=2.9.0) format-patch --base=

[PATCH net-next] openvswitch: Free tmpl with tmpl_free.

2016-09-01 Thread Joe Stringer
When an error occurs during conntrack template creation as part of actions validation, we need to free the template. Previously we've been using nf_ct_put() to do this, but nf_ct_tmpl_free() is more appropriate. Signed-off-by: Joe Stringer --- net/openvswitch/conntrack.c | 2 +- 1 file changed,

[net-next:master 246/246] include/net/switchdev.h:347:15: warning: return makes integer from pointer without a cast

2016-09-01 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: d297653dd6f07afbe7e6c702a4bcd7615680002e commit: d297653dd6f07afbe7e6c702a4bcd7615680002e [246/246] rtnetlink: fdb dump: optimize by saving last interface markers config: powerpc-cm5200_defconfig (attached a

[Patch v4 07/12] MIPS: xilfpga: Update DT node and specify uart irq

2016-09-01 Thread Zubair Lutfullah Kakakhel
Update the DT node with the UART irq Signed-off-by: Zubair Lutfullah Kakakhel --- V3 -> V4 No change V2 -> V3 No change V1 -> V2 No change --- arch/mips/boot/dts/xilfpga/nexys4ddr.dts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/mips/boot/dts/xilfpga/nexys4ddr.dts b/arch/mips

[Patch v4 05/12] MIPS: xilfpga: Use irqchip_init instead of the legacy way

2016-09-01 Thread Zubair Lutfullah Kakakhel
This prepares the code use the Xilinx AXI Interrupt Controller driver now available in drivers/irqchip/irq-axi-intc.c Signed-off-by: Zubair Lutfullah Kakakhel --- V3 -> V4 Corrected commit message. Was irq-xilinx.c. Now irq-axi-intc.c V2 -> V3 No change V1 -> V2 No change --- arch/mips/xilfpga

[Patch v4 04/12] irqchip: axi-intc: Add support for parent intc

2016-09-01 Thread Zubair Lutfullah Kakakhel
The MIPS based xilfpga platform has the following IRQ structure Peripherals --> xilinx_intcontroller -> mips_cpu_int controller Add support for the driver to chain the irq handler Signed-off-by: Zubair Lutfullah Kakakhel --- V3 -> V4 Clean up if/else when a parent is found Pass irqchip structu

[Patch v4 08/12] MIPS: Xilfpga: Add DT node for AXI I2C

2016-09-01 Thread Zubair Lutfullah Kakakhel
The xilfpga platform has an AXI I2C Bus master with a temperature sensor connected to it. Add the device tree node to use them. Signed-off-by: Zubair Lutfullah Kakakhel --- V3 -> V4 changed compatible string from "adt7420" to "adi,adt7420" V2 -> V3 No change V1 -> V2 No change --- arch/mips

[Patch v4 09/12] net: ethernet: xilinx: Generate random mac if none found

2016-09-01 Thread Zubair Lutfullah Kakakhel
At the moment, if the emaclite device doesn't find a mac address from any source, it simply uses 0x0 with a warning printed. Instead of using a 0x0 mac address, use a randomly generated one. Signed-off-by: Zubair Lutfullah Kakakhel --- V3 -> V4 Curly braces after if check for correct styling V

[Patch v4 01/12] microblaze: irqchip: Move intc driver to irqchip

2016-09-01 Thread Zubair Lutfullah Kakakhel
The Xilinx AXI Interrupt Controller IP block is used by the MIPS based xilfpga platform. Move the interrupt controller code out of arch/microblaze so that it can be used by everyone Signed-off-by: Zubair Lutfullah Kakakhel --- V3 -> V4 No change V2 -> V3 No change here. Cleanup patches follow

[Patch v4 00/12] microblaze/MIPS: xilfpga: intc and peripheral

2016-09-01 Thread Zubair Lutfullah Kakakhel
Hi, The MIPS based Xilfpga platform uses the axi interrupt controller daisy chained to the MIPS microAptiv cpu interrupt controller. This patch series moves the axi interrupt controller driver out of arch/microblaze to drivers/irqchip and then cleans it up a bit. This makes it usable by MIPS. The

[Patch v4 10/12] net: ethernet: xilinx: Enable emaclite for MIPS

2016-09-01 Thread Zubair Lutfullah Kakakhel
The MIPS based xilfpga platform uses this driver. Enable it for MIPS Signed-off-by: Zubair Lutfullah Kakakhel --- V3 -> V4 Removed unnecesary braces V2 -> V3 No change V1 -> V2 No change --- drivers/net/ethernet/xilinx/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -

[Patch v4 06/12] MIPS: xilfpga: Use Xilinx AXI Interrupt Controller

2016-09-01 Thread Zubair Lutfullah Kakakhel
IRQs from peripherals such as i2c/uart/ethernet come via the AXI Interrupt controller. Select it in Kconfig for xilfpga and add the DT node Signed-off-by: Zubair Lutfullah Kakakhel --- V3 -> V4 No change V2 -> V3 No change V1 -> V2 Renamed select XILINX_INTC to select XILINX_AXI_INTC --- arc

[Patch v4 12/12] MIPS: xilfpga: Update defconfig

2016-09-01 Thread Zubair Lutfullah Kakakhel
Update defconfig to enable emaclite, i2c, temp sensor found on the xilfpga platform Signed-off-by: Zubair Lutfullah Kakakhel --- V3 -> V4 No change V2 -> V3 No change V1 -> V2 No change --- arch/mips/configs/xilfpga_defconfig | 37 - 1 file changed, 36 inse

[Patch v4 03/12] irqchip: axi-intc: Rename get_irq to xintc_get_irq

2016-09-01 Thread Zubair Lutfullah Kakakhel
Now that the driver is generic and used by multiple archs, get_irq is too generic. Rename get_irq to xintc_get_irq to avoid any conflicts Signed-off-by: Zubair Lutfullah Kakakhel --- V3 -> V4 New patch. --- arch/microblaze/include/asm/irq.h | 2 +- arch/microblaze/kernel/irq.c | 4 ++-- d

[Patch v4 11/12] MIPS: xilfpga: Add DT node for AXI emaclite

2016-09-01 Thread Zubair Lutfullah Kakakhel
The xilfpga platform has a Xilinx AXI emaclite block. Add the DT node to use it. Signed-off-by: Zubair Lutfullah Kakakhel --- V3 -> V4 No change V2 -> V3 No change V1 -> V2 Removed accidental local-mac-address entry --- arch/mips/boot/dts/xilfpga/nexys4ddr.dts | 26 ++

[Patch v4 02/12] irqchip: axi-intc: Clean up irqdomain argument and read/write

2016-09-01 Thread Zubair Lutfullah Kakakhel
The drivers read/write function handling is a bit quirky. And the irqmask is passed directly to the handler. Add a new irqchip struct to pass to the handler and cleanup read/write handling. Signed-off-by: Zubair Lutfullah Kakakhel --- V3 -> V4 Better error handling for kzalloc Erroring out if t

[BUG] af_packet FANOUT and device dismantle

2016-09-01 Thread Eric Dumazet
Hi David When you added fanout in commit dc99f600698dcac, it seems a device dismantle is not properly handled. packet_notifier() does properly finds all sockets attached to the device and we call __unregister_prot_hook() But the actual dev_remove_pack() is called when the last socket attached to

Re: [PATCH net-next] rtnetlink: fdb dump: optimize by saving last interface markers

2016-09-01 Thread David Miller
From: Roopa Prabhu Date: Tue, 30 Aug 2016 21:56:45 -0700 > From: Roopa Prabhu > > fdb dumps spanning multiple skb's currently restart from the first > interface again for every skb. This results in unnecessary > iterations on the already visited interfaces and their fdb > entries. In large scal

Re: [PATCH net-next] rps: flow_dissector: Add the const for the parameter of flow_keys_have_l4

2016-09-01 Thread David Miller
From: f...@ikuai8.com Date: Wed, 31 Aug 2016 11:16:22 +0800 > From: Gao Feng > > Add the const for the parameter of flow_keys_have_l4 for the readability. > > Signed-off-by: Gao Feng Applied.

Re: [PATCH net-next 1/1] rxrpc: Don't expose skbs to in-kernel users [ver #2]

2016-09-01 Thread David Miller
From: David Howells Date: Tue, 30 Aug 2016 20:42:14 +0100 > Don't expose skbs to in-kernel users, such as the AFS filesystem, but > instead provide a notification hook the indicates that a call needs > attention and another that indicates that there's a new call to be > collected. ... > Signed-o

Re: [PATCH] net: pegasus: Remove deprecated create_singlethread_workqueue

2016-09-01 Thread David Miller
From: Bhaktipriya Shridhar Date: Tue, 30 Aug 2016 22:02:47 +0530 > The workqueue "pegasus_workqueue" queues a single work item per pegasus > instance and hence it doesn't require execution ordering. Hence, > alloc_workqueue has been used to replace the deprecated > create_singlethread_workqueue i

Re: [PATCH net-next] rxrpc: Don't expose skbs to in-kernel users

2016-09-01 Thread David Howells
David Miller wrote: > Actually, reverted, this adds a new warning to the build: > > net/rxrpc/recvmsg.c: In function ‘rxrpc_kernel_recv_data’: > net/rxrpc/recvmsg.c:531:1: warning: label ‘need_more_data’ defined but not > used [-Wunused-label] > need_more_data: > ^ > net/rxrpc/recvmsg.c:475:7

Re: [PATCH] bonding: Remove deprecated create_singlethread_workqueue

2016-09-01 Thread David Miller
From: Bhaktipriya Shridhar Date: Tue, 30 Aug 2016 22:02:01 +0530 > alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces > deprecated create_singlethread_workqueue(). This is the identity > conversion. > > The workqueue "wq" queues multiple work items viz > &bond->mcast_work, &nnw->work, &

Re: [PATCH next] tcp: fastopen: fix rcv_wup initialization for TFO server on SYN/data

2016-09-01 Thread David Miller
From: Neal Cardwell Date: Tue, 30 Aug 2016 11:55:23 -0400 > Yuchung noticed that on the first TFO server data packet sent after > the (TFO) handshake, the server echoed the TCP timestamp value in the > SYN/data instead of the timestamp value in the final ACK of the > handshake. This problem did n

Re: [PATCH net-next] rxrpc: Don't expose skbs to in-kernel users

2016-09-01 Thread David Miller
From: David Miller Date: Thu, 01 Sep 2016 16:38:32 -0700 (PDT) > From: David Howells > Date: Tue, 30 Aug 2016 16:52:39 +0100 > >> Don't expose skbs to in-kernel users, such as the AFS filesystem, but >> instead provide a notification hook the indicates that a call needs >> attention and another

Re: [PATCH net-next] rxrpc: Don't expose skbs to in-kernel users

2016-09-01 Thread David Miller
From: David Howells Date: Tue, 30 Aug 2016 16:52:39 +0100 > Don't expose skbs to in-kernel users, such as the AFS filesystem, but > instead provide a notification hook the indicates that a call needs > attention and another that indicates that there's a new call to be > collected. ... > Signed-o

Re: [PATCH net] net: bridge: don't increment tx_dropped in br_do_proxy_arp

2016-09-01 Thread David Miller
From: Nikolay Aleksandrov Date: Tue, 30 Aug 2016 17:44:29 +0200 > pskb_may_pull may fail due to various reasons (e.g. alloc failure), but the > skb isn't changed/dropped and processing continues so we shouldn't > increment tx_dropped. > > CC: Kyeyoon Park > CC: Roopa Prabhu > CC: Stephen Hemmi

Re: [PATCH net] l2tp: fix use-after-free during module unload

2016-09-01 Thread David Miller
From: Sabrina Dubroca Date: Tue, 30 Aug 2016 16:05:16 +0200 > Tunnel deletion is delayed by both a workqueue (l2tp_tunnel_delete -> wq > -> l2tp_tunnel_del_work) and RCU (sk_destruct -> RCU -> > l2tp_tunnel_destruct). > > By the time l2tp_tunnel_destruct() runs to destroy the tunnel and finish

Re: [PATCH 0/4] SA11x0 Clocks and removal of Neponset SMC91x hack

2016-09-01 Thread David Miller
From: Russell King - ARM Linux Date: Tue, 30 Aug 2016 11:51:17 +0100 > Please ack these changes; due to the dependencies, I wish to merge > them through my tree. Thanks. Acked-by: David S. Miller

Re: [PATCH] net/mlx4_en: protect ring->xdp_prog with rcu_read_lock

2016-09-01 Thread Tom Herbert
On Thu, Sep 1, 2016 at 3:59 PM, Saeed Mahameed wrote: > On Wed, Aug 31, 2016 at 4:50 AM, Brenden Blanco wrote: >> On Tue, Aug 30, 2016 at 12:35:58PM +0300, Saeed Mahameed wrote: >>> On Mon, Aug 29, 2016 at 8:46 PM, Tom Herbert wrote: >>> > On Mon, Aug 29, 2016 at 8:55 AM, Brenden Blanco >>> >

Re: [PATCH net-next 4/4] xps_flows: XPS for packets that don't have a socket

2016-09-01 Thread Alexander Duyck
On Thu, Sep 1, 2016 at 8:56 AM, Tom Herbert wrote: > On Thu, Sep 1, 2016 at 8:36 AM, Alexander Duyck > wrote: >> On Wed, Aug 31, 2016 at 5:10 PM, Tom Herbert wrote: >>> xps_flows maintains a per device flow table that is indexed by the >>> skbuff hash. The table is only consulted when there is n

Re: [PATCH] net/mlx4_en: protect ring->xdp_prog with rcu_read_lock

2016-09-01 Thread Saeed Mahameed
On Wed, Aug 31, 2016 at 4:50 AM, Brenden Blanco wrote: > On Tue, Aug 30, 2016 at 12:35:58PM +0300, Saeed Mahameed wrote: >> On Mon, Aug 29, 2016 at 8:46 PM, Tom Herbert wrote: >> > On Mon, Aug 29, 2016 at 8:55 AM, Brenden Blanco >> > wrote: >> >> On Mon, Aug 29, 2016 at 05:59:26PM +0300, Tariq

[PATCH net-next V5 8/8] liquidio:CN23XX pause frame support

2016-09-01 Thread Raghu Vatsavayi
Adds support for pause frame and priv flag for cn23xx device. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas Signed-off-by: Raghu Vatsavayi --- drivers/net/ethernet/cavium/liquidio/lio_ethtool.c | 110 + drivers/net/ethernet/caviu

Re: [PATCH] [v9] net: emac: emac gigabit ethernet controller driver

2016-09-01 Thread Rob Herring
On Wed, Aug 31, 2016 at 4:00 PM, Timur Tabi wrote: > Rob Herring wrote: >>> >>> It's not a generic phy. It's a funky "internal phy" that differs among >>> >SOCs. I call it the internal phy, but I could use another name. >>> > Internally, >>> >some people call it the "sgmii phy", but I don't thin

Re: [RFC] xgbe: constify get_netdev_ops and get_ethtool_ops

2016-09-01 Thread Tom Lendacky
On 08/31/2016 07:50 PM, Tom Lendacky wrote: > On 08/31/2016 04:17 PM, David Miller wrote: >> From: Stephen Hemminger >> Date: Wed, 31 Aug 2016 08:57:36 -0700 >> >>> Casting away const is bad practice. Since this is ARM specific driver >>> don't have hardware actually test this. >>> >>> Having gett

Re: [Patch v4 02/12] irqchip: axi-intc: Clean up irqdomain argument and read/write

2016-09-01 Thread Marc Zyngier
On 01/09/16 17:50, Zubair Lutfullah Kakakhel wrote: > The drivers read/write function handling is a bit quirky. > And the irqmask is passed directly to the handler. > > Add a new irqchip struct to pass to the handler and > cleanup read/write handling. > > Signed-off-by: Zubair Lutfullah Kakakhel

[PATCH v4 4/6] arm64: dts: rockchip: add the gmac power domain on rk3399

2016-09-01 Thread Caesar Wang
This patch supports the gmac pd to save power consumption. Even though some boards not need Ethernet support, the driver core can also take care of powering up the pd before probe. Signed-off-by: Caesar Wang --- Changes in v4: - remove the Roger signed-off for domain patch. Changes in v3: - lea

Re: [Patch v4 04/12] irqchip: axi-intc: Add support for parent intc

2016-09-01 Thread Marc Zyngier
On 01/09/16 17:50, Zubair Lutfullah Kakakhel wrote: > The MIPS based xilfpga platform has the following IRQ structure > > Peripherals --> xilinx_intcontroller -> mips_cpu_int controller > > Add support for the driver to chain the irq handler > > Signed-off-by: Zubair Lutfullah Kakakhel > > ---

Re: possible circular locking dependency detected

2016-09-01 Thread Linus Torvalds
On Thu, Sep 1, 2016 at 2:43 PM, Linus Torvalds wrote: > On Thu, Sep 1, 2016 at 2:01 PM, Al Viro wrote: >> >> Outside as in "all fs activity in bind happens under it". Along with >> assignment to ->u.addr, etc. IOW, make it the outermost lock there. > > Hah, yes. I misunderstood you. > > Yes. In

[PATCH v4 3/6] net: stmmac: dwmac-rk: add pd_gmac support for rk3399

2016-09-01 Thread Caesar Wang
From: David Wu Add the gmac power domain support for rk3399, in order to save more power consumption. Signed-off-by: David Wu Signed-off-by: Caesar Wang --- Changes in v4: None Changes in v3: None Changes in v2: - fixes the build error on next kernel. drivers/net/ethernet/stmicro/stmmac/dwm

Re: [PATCH net-next] mpls: get rid of trivial returns

2016-09-01 Thread David Miller
From: Stephen Hemminger Date: Thu, 1 Sep 2016 08:51:07 -0700 > return at end of function is useless. > > Signed-off-by: Stephen Hemminger Applied.

Re: [PATCH v4 4/6] arm64: dts: rockchip: add the gmac power domain on rk3399

2016-09-01 Thread Doug Anderson
Hi, On Thu, Sep 1, 2016 at 10:50 AM, Caesar Wang wrote: > This patch supports the gmac pd to save power consumption. > Even though some boards not need Ethernet support, the driver > core can also take care of powering up the pd before probe. > > Signed-off-by: Caesar Wang > --- > > Changes in v

Re: e1000e on Thinkpad x60: gigabit not available due to "SmartSpeed"

2016-09-01 Thread Greg
On Thu, 2016-09-01 at 22:14 +0200, Pavel Machek wrote: > Hi! > > I have trouble getting 1000mbit out of my ethernet card. > > I tried direct connection between two PCs with different cables, and > no luck. > > Today I tried connection to 1000mbit switch, and no luck, either. (Two > cables, one w

[PATCH] ath9k: bring back direction setting in ath9k_{start_stop}

2016-09-01 Thread Giedrius Statkevičius
A regression was introduced in commit id 79d4db1214a ("ath9k: cleanup led_pin initial") that broken the WLAN status led on my laptop with AR9287 after suspending and resuming. Steps to reproduce: * Suspend (laptop) * Resume (laptop) * Observe that the WLAN led no longer turns ON/OFF depending on t

[PATCH net-next 3/3] tipc: send broadcast nack directly upon sequence gap detection

2016-09-01 Thread Jon Maloy
Because of the risk of an excessive number of NACK messages and retransissions, receivers have until now abstained from sending broadcast NACKS directly upon detection of a packet sequence number gap. We have instead relied on such gaps being detected by link protocol STATE message exchange, someth

Re: [PATCH V2] dt: net: enhance DWC EQoS binding to support Tegra186

2016-09-01 Thread Stephen Warren
On 09/01/2016 01:50 AM, Lars Persson wrote: On 08/31/2016 11:48 PM, Stephen Warren wrote: On 08/31/2016 03:15 AM, Lars Persson wrote: On 08/30/2016 10:50 PM, Stephen Warren wrote: On 08/30/2016 01:01 PM, Rob Herring wrote: On Wed, Aug 24, 2016 at 03:20:46PM -0600, Stephen Warren wrote: The

[PATCH net-next 1/3] tipc: transfer broadcast nacks in link state messages

2016-09-01 Thread Jon Maloy
When we send broadcasts in clusters of more 70-80 nodes, we sometimes see the broadcast link resetting because of an excessive number of retransmissions. This is caused by a combination of two factors: 1) A 'NACK crunch", where loss of broadcast packets is discovered and NACK'ed by several node

[PATCH net-next 0/3] tipc: improve broadcast NACK mechanism

2016-09-01 Thread Jon Maloy
The broadcast protocol has turned out to not scale well beyond 70-80 nodes, while it is now possible to build TIPC clusters of at least ten times that size. This commit series improves the NACK/retransmission mechanism of the broadcast protocol to make is at scalable as the rest of TIPC. Jon Maloy

[PATCH net-next V5 2/8] liquidio: RX control commands

2016-09-01 Thread Raghu Vatsavayi
Adds support for RX control commands on cn23xx device. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas Signed-off-by: Raghu Vatsavayi --- drivers/net/ethernet/cavium/liquidio/lio_main.c| 100 ++--- .../net/ethernet/cavium/liquidio/

[PATCH net-next V5 7/8] liquidio: CN23XX napi support

2016-09-01 Thread Raghu Vatsavayi
This patch adds NAPI related support for cn23xx device. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas Signed-off-by: Raghu Vatsavayi --- drivers/net/ethernet/cavium/liquidio/lio_main.c | 10 ++ drivers/net/ethernet/cavium/liquidio/octeo

[PATCH net-next 2/3] tipc: rate limit broadcast retransmissions

2016-09-01 Thread Jon Maloy
As cluster sizes grow, so does the amount of identical or overlapping broadcast NACKs generated by the packet receivers. This often leads to 'NACK crunches' resulting in huge numbers of redundant retransmissions of the same packet ranges. In this commit, we introduce rate control of broadcast retr

Re: [PATCH v2 1/1] net: macb: initialize checksum when using checksum offloading

2016-09-01 Thread David Miller
From: Helmut Buchsbaum Date: Mon, 29 Aug 2016 15:57:25 +0200 > diff --git a/drivers/net/ethernet/cadence/macb.c > b/drivers/net/ethernet/cadence/macb.c > index 89c0cfa..de2f791 100644 > --- a/drivers/net/ethernet/cadence/macb.c > +++ b/drivers/net/ethernet/cadence/macb.c > @@ -1323,6 +1323,19 @@

[PATCH v4 6/6] arm64: dts: rockchip: enable the gmac for rk3399 evb board

2016-09-01 Thread Caesar Wang
From: Roger Chen We add the required and optional properties for evb board. See the [0] to get the detail information. [0]: Documentation/devicetree/bindings/net/rockchip-dwmac.txt Signed-off-by: Roger Chen Signed-off-by: Caesar Wang --- Changes in v4: None Changes in v3: None Changes in v2:

[PATCH net-next V5 0/8] liquidio CN23XX support

2016-09-01 Thread Raghu Vatsavayi
Dave, I am posting the remaining half of patchset after the acceptance of first half. With this patchset I am able to completely submit the code of V3 patchset which you earlier advised me to split into smaller ones. This V5 patch also addresses all the comments from previous submission: 1) Avoi

[PATCH net-next V5 3/8] liquidio: CN23XX IQ access

2016-09-01 Thread Raghu Vatsavayi
Adds support for Instruction Queue(IQ) index manipulation routines through bar1 of cn23xx. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas Signed-off-by: Raghu Vatsavayi --- .../ethernet/cavium/liquidio/cn23xx_pf_device.c| 66 +

[PATCH net-next V5 1/8] liquidio: link and control commands

2016-09-01 Thread Raghu Vatsavayi
This patch adds work queue support for link status and control commands. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas Signed-off-by: Raghu Vatsavayi --- drivers/net/ethernet/cavium/liquidio/lio_core.c| 5 +- drivers/net/ethernet/cavium/liquidi

[PATCH net-next V5 4/8] liquidio: CN23XX octeon3 instruction

2016-09-01 Thread Raghu Vatsavayi
Adds support for data path related changes based on octeon3 instruction header(ih3) for cn23xx. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas Signed-off-by: Raghu Vatsavayi --- drivers/net/ethernet/cavium/liquidio/lio_main.c| 37 +++-- .../net/

[PATCH v4 2/6] net: stmmac: dwmac-rk: fixes the gmac resume after PD on/off

2016-09-01 Thread Caesar Wang
From: Roger Chen GMAC Power Domain(PD) will be disabled during suspend. That will causes GRF registers reset. So corresponding GRF registers for GMAC must be setup again. Signed-off-by: Roger Chen Signed-off-by: Caesar Wang --- Changes in v4: None Changes in v3: None Changes in v2: - rk_gmac_

[PATCH net-next V5 6/8] liquidio: CN23XX health monitoring

2016-09-01 Thread Raghu Vatsavayi
Adds support for watchdog based health monitoring of octeon cores on cn23xx device. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas Signed-off-by: Raghu Vatsavayi --- drivers/net/ethernet/cavium/liquidio/lio_main.c| 126 - .../

[PATCH net-next V5 5/8] liquidio: ethtool and led control support

2016-09-01 Thread Raghu Vatsavayi
This patch adds support for some control operations like LED identification, ethtool statistics and intr config for cn23xx device. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas Signed-off-by: Raghu Vatsavayi --- .../ethernet/cavium/liquidio/cn23xx_p

  1   2   3   >