Resurrecting due to huge ipoib perf regression - [BUG] skb corruption and kernel panic at forwarding with fragmentation

2016-07-06 Thread Roland Dreier
On Thu, Jan 7, 2016 at 3:00 AM, Konstantin Khlebnikov wrote: > Or just shift GSO CB and add couple checks like > BUILD_BUG_ON(sizeof(SKB_GSO_CB(skb)->room) < sizeof(*IPCB(skb))); Resurrecting this old thread, because the patch that ultimately went upstream (commit 9207f9d45b0a / net: preserve IP

[PATCH net-next v2 0/4] net: support MPLS in IPv4 and UDP

2016-07-06 Thread Simon Horman
This short series provides support for MPLS in IPv4 (RFC4023), and by virtue of FOU, MPLS in UDP (RFC7510). The changes are as follows: 1. Teach tunnel4.c about AF_MPLS, it already understands AF_INET and AF_INET6 2. Enhance IPIP and SIT to handle MPLS. Both already handle IPv4. SIT also alr

[PATCH net-next v2 1/4] tunnels: support MPLS over IPv4 tunnels

2016-07-06 Thread Simon Horman
Extend tunnel support to MPLS over IPv4. The implementation extends the existing differentiation between IPIP and IPv6 over IPv4 to also cover MPLS over IPv4. Signed-off-by: Simon Horman Reviewed-by: Dinan Gunawardena --- net/ipv4/tunnel4.c | 77 +++-

[PATCH net-next v2 4/4] mpls: allow routes on ipip and sit devices

2016-07-06 Thread Simon Horman
Allow MPLS routes on IPIP and SIT devices now that they support forwarding MPLS packets. Signed-off-by: Simon Horman Reviewed-by: Dinan Gunawardena --- net/mpls/af_mpls.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c index e9be

[PATCH net-next v2 2/4] sit: support MPLS over IPv4

2016-07-06 Thread Simon Horman
Extend the SIT driver to support MPLS over IPv4. This implementation extends existing support for IPv6 over IPv4 and IPv4 over IPv4. Signed-off-by: Simon Horman Reviewed-by: Dinan Gunawardena --- v2 * Correct inverted logic for IPIP in ipip6_valid_ip_proto() --- net/ipv6/sit.c | 93

[PATCH net-next v2 3/4] ipip: support MPLS over IPv4

2016-07-06 Thread Simon Horman
Extend the IPIP driver to support MPLS over IPv4. The implementation is an extension of existing support for IPv4 over IPv4 and is based of multiple inner-protocol support for the SIT driver. Signed-off-by: Simon Horman Reviewed-by: Dinan Gunawardena --- net/ipv4/ipip.c | 137 ++

[PATCH net-next] bpf: introduce bpf_get_current_task() helper

2016-07-06 Thread Alexei Starovoitov
over time there were multiple requests to access different data structures and fields of task_struct current, so finally add the helper to access 'current' as-is. Tracing bpf programs will do the rest of walking the pointers via bpf_probe_read(). Note that current can be null and bpf program has to

Re: [PATCH/RFC net-next 0/4] net: support MPLS in IPv4 and UDP

2016-07-06 Thread Simon Horman
On Wed, Jul 06, 2016 at 09:44:13PM -0700, Tom Herbert wrote: > On Wed, Jul 6, 2016 at 11:22 AM, Simon Horman > wrote: > > This short series provides support for MPLS in IPv4 (RFC4023), and by > > virtue of FOU, MPLS in UDP (RFC7510). > > > > The changes are as follows: > > 1. Teach tunnel4.c about

Re: [PATCH/RFC net-next 2/4] sit: support MPLS over IPv4

2016-07-06 Thread Simon Horman
On Wed, Jul 06, 2016 at 10:10:59PM -0700, David Miller wrote: > From: Simon Horman > Date: Wed, 6 Jul 2016 20:22:33 +0200 > > > > > +bool ipip6_valid_ip_proto(u8 ipproto) > > +{ > > + return ipproto == IPPROTO_IPV6 || > > + ipproto != IPPROTO_IPIP || > > +#if IS_ENABLED(CONFIG_MPLS

Re: pull-request: mac80211-next 2016-07-06

2016-07-06 Thread David Miller
From: Johannes Berg Date: Wed, 6 Jul 2016 17:34:59 +0200 > And here's another set of new things. This is the last one I'll send > since I'll be away for a bit. > > Let me know if there's any problem. Pulled, thanks Johannes.

Re: [PATCH -next] net: mediatek: remove .owner field for driver

2016-07-06 Thread David Miller
From: weiyj...@163.com Date: Wed, 6 Jul 2016 13:30:13 + > From: Wei Yongjun > > Remove .owner field since calls to module_platform_driver() will > set it automatically. > > Signed-off-by: Wei Yongjun Applied.

Re: [iproute PATCHv2 0/2] Netns performance improvements

2016-07-06 Thread Eric W. Biederman
Stephen Hemminger writes: > On Tue, 5 Jul 2016 16:51:18 +0200 > Phil Sutter wrote: > >> Stress-testing OpenStack Neutron revealed poor performance of 'ip netns' >> when dealing with a high amount of namespaces. The cause of this lies in >> the combination of how iproute2 mounts NETNS_RUN_DIR an

Re: [PATCH/RFC net-next 2/4] sit: support MPLS over IPv4

2016-07-06 Thread David Miller
From: Simon Horman Date: Wed, 6 Jul 2016 20:22:33 +0200 > > +bool ipip6_valid_ip_proto(u8 ipproto) > +{ > + return ipproto == IPPROTO_IPV6 || > + ipproto != IPPROTO_IPIP || > +#if IS_ENABLED(CONFIG_MPLS) > + ipproto == IPPROTO_MPLS || > +#endif > + ippro

Re: [iproute PATCH 0/2] Netns performance improvements

2016-07-06 Thread Eric W. Biederman
Phil Sutter writes: > Hi Eric, > > Thanks for your quick and insightful reply rightfully pointing out the > lack of rationale behind this change. So let me try to catch up: Grr. I did not get what you are trying to accomplish the first time I skimmed this and rereading it all again closely I st

Re: [PATCH/RFC net-next 0/4] net: support MPLS in IPv4 and UDP

2016-07-06 Thread David Miller
From: Simon Horman Date: Wed, 6 Jul 2016 20:22:31 +0200 > This short series provides support for MPLS in IPv4 (RFC4023), and by > virtue of FOU, MPLS in UDP (RFC7510). > > The changes are as follows: > 1. Teach tunnel4.c about AF_MPLS, it already understands AF_INET and >AF_INET6 > 2. Enhan

Re: [PATCH/RFC net-next 0/4] net: support MPLS in IPv4 and UDP

2016-07-06 Thread Tom Herbert
On Wed, Jul 6, 2016 at 11:22 AM, Simon Horman wrote: > This short series provides support for MPLS in IPv4 (RFC4023), and by > virtue of FOU, MPLS in UDP (RFC7510). > > The changes are as follows: > 1. Teach tunnel4.c about AF_MPLS, it already understands AF_INET and >AF_INET6 > 2. Enhance IPI

Re: [PATCH v4 iproute2 0/6] Add support for vrf keyword

2016-07-06 Thread Stephen Hemminger
On Wed, 29 Jun 2016 11:26:56 -0700 David Ahern wrote: > Currently the syntax for VRF related commands is rather kludgy and > inconsistent from one subcommand to another. This set adds support > for the VRF keyword to the link, address, neigh, and route commands > to improve the user experience li

Re: [PATCH iproute2] tc: flower: Add skip_{hw|sw} support

2016-07-06 Thread Stephen Hemminger
On Mon, 4 Jul 2016 10:34:11 +0300 Amir Vadai wrote: > From: Amir Vadai > > On devices that support TC flower offloads, these flags enable a filter to be > added only to HW or only to SW. skip_sw and skip_hw are mutually exclusive > flags. By default without any flags, the filter is added to bo

Re: [iproute PATCHv2 0/2] Netns performance improvements

2016-07-06 Thread Stephen Hemminger
On Tue, 5 Jul 2016 16:51:18 +0200 Phil Sutter wrote: > Stress-testing OpenStack Neutron revealed poor performance of 'ip netns' > when dealing with a high amount of namespaces. The cause of this lies in > the combination of how iproute2 mounts NETNS_RUN_DIR and the netns files > therein and the

Re: [iproute2 1/1] actions: skbedit add support for mod-ing skb pkt_type

2016-07-06 Thread Stephen Hemminger
On Sat, 2 Jul 2016 07:14:33 -0400 Jamal Hadi Salim wrote: > From: Jamal Hadi Salim > > I'll make a formal submission sans the header when the kernel patches > makes it in. This version is for someone who wants to play around with > the net-next kernel patches i sent > > Signed-off-by: Jamal H

Re: [PATCH] Add support for configuring Infiniband GUIDs

2016-07-06 Thread Stephen Hemminger
On Tue, 5 Jul 2016 10:53:38 -0500 Eli Cohen wrote: > > +static int extract_guid(__u64 *guid, char *arg) > +{ > + __u64 ret; > + int g[8]; > + int err; > + > + err = sscanf(arg, "%02x:%02x:%02x:%02x:%02x:%02x:%02x:%02x", > + g, g + 1, g + 2, g + 3, g + 4, g + 5,

Re: [PATCH 1/1] iproute2: unmangle netdev/my emails in man pages (hfsc, stab)

2016-07-06 Thread Stephen Hemminger
On Sat, 2 Jul 2016 13:03:12 +0200 Michal Soltys wrote: > No other man pages do so, hiding netdev is kind of silly and I don't > mind having my own address normally visible. Sure applied

Re: [PATCH] man: rtacct: add missing TP marker

2016-07-06 Thread Stephen Hemminger
On Tue, 5 Jul 2016 18:08:50 +0900 Masatake YAMATO wrote: > Signed-off-by: Masatake YAMATO Applied

Re: [PATCH] net/ixgbe: Allow resetting VF admin mac to zero

2016-07-06 Thread Stephen Hemminger
On Fri, 1 Jul 2016 11:19:38 +0200 Juerg Haefliger wrote: > The VF administrative mac addresses (stored in the PF driver) are > initialized to zero when the PF driver starts up. > > These addresses may be modified in the PF driver through ndo calls > initiated by iproute2 or libvirt. > > While

Re: [PATCH net-next] tun: Don't assume type tun in tun_device_event

2016-07-06 Thread Jason Wang
On 2016年07月07日 06:44, Craig Gallek wrote: From: Craig Gallek The referenced change added a netlink notifier for processing device queue size events. These events are fired for all devices but the registered callback assumed they only occurred for tun devices. This fix adds a check (borrowed

Re: [PATCH net-next v2 0/4] net: dsa: Preparatory patches for pdata

2016-07-06 Thread Vivien Didelot
Hi, Florian Fainelli writes: > Hi all, > > This is a resend of the patches that just clean up and prepare net/dsa/dsa2.c > to support platform data in the future. > > Florian Fainelli (4): > net: dsa: Pass device pointer to dsa_register_switch > net: dsa: Make most functions take a dsa_port

Re: [PATCH] ipv6: Fix soft lockup for ipv6 network notifier.

2016-07-06 Thread Ding Tianhong
On 2016/7/6 16:44, Eric Dumazet wrote: > On Wed, 2016-07-06 at 16:15 +0800, Ding Tianhong wrote: >> Hi Eric: >> >> I had found out that the patch aaf92f(netfilter: conntrack: resched in >> nf_ct_iterate_cleanup) solve the problem, >> this patch add cond_sched() in the nf_ct_iterate_cleanup() which

[PATCH 4.6 05/31] kcm: fix /proc memory leak

2016-07-06 Thread Greg Kroah-Hartman
4.6-stable review patch. If anyone has any objections, please let me know. -- From: Jiri Slaby [ Upstream commit d19af0a76444fde629667ecb823c0ee28f9f67d8 ] Every open of /proc/net/kcm leaks 16 bytes of memory as is reported by kmemleak: unreferenced object 0x88059c0e3458 (

[PATCH v4 10/11] Documentation: dtb: xgene: Add MDIO node

2016-07-06 Thread Iyappan Subramanian
Signed-off-by: Iyappan Subramanian Tested-by: Fushen Chen Tested-by: Toan Le Tested-by: Matthias Brugger --- .../devicetree/bindings/net/apm-xgene-mdio.txt | 37 ++ 1 file changed, 37 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/apm-xgene-mdio

[PATCH v4 05/11] drivers: net: phy: xgene: Add MDIO driver

2016-07-06 Thread Iyappan Subramanian
Currently, SGMII based 1G rely on the hardware registers for link state and sometimes it's not reliable. To get most accurate link state, this interface has to use the MDIO bus to poll the PHY. In X-Gene SoC, MDIO bus is shared across RGMII and SGMII based 1G interfaces, so adding this driver to

[PATCH v4 06/11] drivers: net: xgene: Add backward compatibility

2016-07-06 Thread Iyappan Subramanian
This patch adds xgene_enet_check_phy_hanlde() function that checks whether MDIO driver is probed successfully and sets pdata->mdio_driver to true. If MDIO driver is not probed, ethernet driver falls back to backward compatibility mode. Since enum xgene_enet_cmd is used by MDIO driver, removing thi

Re: [RFC 0/7] netlink: Add allocation flag to netlink_unicast()

2016-07-06 Thread Masashi Honma
At the fs/dlm/netlink.c#dlm_timeout_warn(), prepare_data allocates buffer with GFP_NOFS and send_data() sends the buffer. But send_data() uses GFP_KERNEL or GFP_ATOMIC inside it. Should it be replaced by GFP_NOFS ? Masashi Honma

[PATCH v4 08/11] drivers: net: xgene: ethtool: Use phy_ethtool_gset and sset

2016-07-06 Thread Iyappan Subramanian
Changed SGMII 1G get_settings to use phy_ethtool_gset. Changed SGMII 1G set_settings to use phy_ethtool_sset. Signed-off-by: Iyappan Subramanian Tested-by: Fushen Chen Tested-by: Toan Le --- .../net/ethernet/apm/xgene/xgene_enet_ethtool.c| 22 +++--- 1 file changed, 19 inse

[PATCH v4 09/11] dtb: xgene: Add MDIO node

2016-07-06 Thread Iyappan Subramanian
Added mdio node for mdio driver. Also added phy-handle reference to the ethernet nodes. Removed unused mdio subnode within storm menet ethernet node. Removed unused clock node from storm sgenet1. Signed-off-by: Iyappan Subramanian Tested-by: Fushen Chen Tested-by: Toan Le Tested-by: Matthias

[PATCH v4 03/11] drivers: net: xgene: Fix module unload crash - change sw sequence

2016-07-06 Thread Iyappan Subramanian
When the driver is configured as kernel module and when it gets unloaded and reloaded, kernel crash was observed. This patch addresses the software cleanup by doing the following, - Moved register_netdev call after hardware is ready - Since ndev is not ready, added set_irq_name to set irq name -

[PATCH v4 04/11] drivers: net: xgene: Fix module unload crash - clkrst sequence

2016-07-06 Thread Iyappan Subramanian
This patch fixes clock reset sequence. - Added clock reset sequence for ACPI - Removed MII_MGMT_CONFIG programming, since it is not required - Fixed programming XGENET_CONFIG_REG to enable SGMII mode Signed-off-by: Iyappan Subramanian Tested-by: Fushen Chen Tested-by: Toan Le Tested-by: Matthi

[PATCH v4 00/11] drivers: net: xgene: Fix module crash and 1G hot-plug

2016-07-06 Thread Iyappan Subramanian
This patchset addresses the following issues, 1. Fixes the kernel crash when the driver loaded as an kernel module - by fixing hardware cleanups and rearrange kernel API calls 2. Hot-plug issue on the SGMII 1G interface - by adding a driver for MDIO management Signed-off-by: Iyap

[PATCH v4 07/11] drivers: net: xgene: Enable MDIO driver

2016-07-06 Thread Iyappan Subramanian
This patch enables MDIO driver by, - Selecting MDIO_XGENE - Changed open and close to use phy_start and phy_stop - Changed to use mac_ops->tx(rx)_enable and tx(rx)_disable Signed-off-by: Iyappan Subramanian Tested-by: Fushen Chen Tested-by: Toan Le Tested-by: Matthias Brugger --- drivers/net

[PATCH v4 11/11] MAINTAINERS: xgene: Add driver and documentation path

2016-07-06 Thread Iyappan Subramanian
Added path to the MDIO driver and Documentation file. Signed-off-by: Iyappan Subramanian --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6374be2..a2ce997 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -839,7 +839,9 @@ M: Iyappan Subramanian

[PATCH v4 01/11] drivers: net: xgene: Separate set_speed from mac_init

2016-07-06 Thread Iyappan Subramanian
Since mac_init is too heavy to be called when the link changes, moved the speed_set configuration to a new function and added mac_ops->set_speed function pointer. This function will be called from adjust_link callback. Added cases for 10/100 support for SGMII based 1G interface. Signed-off-by: I

[PATCH v4 02/11] drivers: net: xgene: Fix module unload crash - hw resource cleanup

2016-07-06 Thread Iyappan Subramanian
When the driver is configured as kernel module and when it gets unloaded and reloaded, kernel crash was observed. This patch address the hardware resource cleanups by doing the following, - Added mac_ops->clear() to do prefetch buffer clean up - Fixed delete freepool buffers logic - Reordered mac

[PATCH net-next] net: dsa: initialize the routing table

2016-07-06 Thread Vivien Didelot
The routing table of every switch in a tree is currently initialized to all zeros. This is an issue since 0 is a valid port number. Add a DSA_RTABLE_NONE=-1 constant to initialize the signed values of the routing table pointing to other switches. This fixes the device mapping of the mv88e6xxx dri

Re:Re:Hi

2016-07-06 Thread hi
welcome to our shop tv,bike,watch,laptop,brand guitar... ... we can offer you 50% disocunt and FREE Shipping s ite: slooone .com

Re: [PATCH v2 3/5] drivers: net: phy: Add MDIO driver

2016-07-06 Thread Iyappan Subramanian
Hi Andrew, On Tue, Jul 5, 2016 at 6:49 AM, Andrew Lunn wrote: > On Mon, Jun 06, 2016 at 10:12:35AM -0700, Iyappan Subramanian wrote: >> Hi Andrew, >> >> Thanks for the review. >> >> On Tue, May 31, 2016 at 6:11 PM, Andrew Lunn wrote: >> > On Tue, May 31, 2016 at 05:10:38PM -0700, Iyappan Subrama

Re: [PATCH] (resend) ixgbe: always initialize setup_fc

2016-07-06 Thread Rustad, Mark D
Patrick McLean wrote: Gmail mangled my first message, sorry about that. Second attempt. In ixgbe_init_mac_link_ops_X550em, the code has a special case for backplane media type, but does not fall through to the default case, so the setup_fc never gets initialized. This causes a panic when it la

[PATCH net-next] tun: Don't assume type tun in tun_device_event

2016-07-06 Thread Craig Gallek
From: Craig Gallek The referenced change added a netlink notifier for processing device queue size events. These events are fired for all devices but the registered callback assumed they only occurred for tun devices. This fix adds a check (borrowed from macvtap.c) to discard non-tun device eve

Re: [PATCH iptables 3/3] libxt_hashlimit: iptables-restore does not work as expected with xt_hashlimit

2016-07-06 Thread Vishwanath Pai
On 07/05/2016 04:13 PM, Vishwanath Pai wrote: > On 06/25/2016 05:39 AM, Pablo Neira Ayuso wrote: >> I see, but I'm not convinced about this /proc rename feature. >> >> I think the main point of this, as well as other entries in bugzilla >> related to this, is ability to update an existing hashlimit

Re: [PATCH 01/26] bridge: netfilter: checkpatch data type fixes

2016-07-06 Thread Stephen Hemminger
On Wed, 6 Jul 2016 16:23:43 +0200 Pablo Neira Ayuso wrote: > From: Tobin C Harding > > checkpatch produces data type 'checks'. > > This patch amends them by changing, for example: > uint8_t -> u8 > > Signed-off-by: Tobin C Harding > Signed-off-by: Pablo Neira Ayuso Thanks, for fixing this

Re: [PATCH net-next] net: bridge: extend MLD/IGMP query stats

2016-07-06 Thread Stephen Hemminger
On Wed, 6 Jul 2016 12:12:21 -0700 Nikolay Aleksandrov wrote: > As was suggested this patch adds support for the different versions of MLD > and IGMP query types. Since the user visible structure is still in net-next > we can augment it instead of adding netlink attributes. > The distinction betw

Re: vmxnet3 LROv6 performance issues

2016-07-06 Thread Ramprasad K S
Bernhard Schmidt birkenwald.de> writes: > > Hi, > > this started as a Debian bug > (http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=816377), but since > it's affecting SLES as well I'm hoping to get some help here. > > I'm a bit unsure where to search here. It is definitely > hardware/firmwar

[PATCH net 3/4] ibmvnic: simplify and improve driver probe function

2016-07-06 Thread Thomas Falcon
This patch creates a function that handles sub-CRQ IRQ creation separately from sub-CRQ initialization. Another function is then needed to release sub-CRQ resources prior to sub-CRQ IRQ creation. These additions allow the driver probe function to be simplified, specifically during the VNIC Server

[PATCH net 1/4] ibmvnic: properly start and stop tx queues

2016-07-06 Thread Thomas Falcon
Since ibmvnic uses multiple tx queues, start and stop all queues when opening and closing devices. Signed-off-by: Thomas Falcon --- drivers/net/ethernet/ibm/ibmvnic.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethern

[PATCH net 2/4] ibmvnic: dispose irq mappings

2016-07-06 Thread Thomas Falcon
IRQ mappings were not being properly disposed when releasing sub-CRQ's. Signed-off-by: Thomas Falcon --- drivers/net/ethernet/ibm/ibmvnic.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index f04830e..79d2ab3 100644

[PATCH net 4/4] ibmvnic: Fix passive VNIC server login process

2016-07-06 Thread Thomas Falcon
In some cases, if there is no VNIC server available during the driver probe, the driver should wait until it receives an initialization request from the VNIC Server to start the login process. Recent testing has show that this is incorrectly handled in the current driver. The proposed solution han

[PATCH net 0/4] ibmvnic driver bugfixes and improvements

2016-07-06 Thread Thomas Falcon
Miscellaneous fixes and improvements on the ibmvnic driver. Thomas Falcon (4): ibmvnic: properly start and stop tx queues ibmvnic: dispose irq mappings ibmvnic: simplify and improve driver probe function ibmvnic: Fix passive VNIC server login process drivers/net/ethernet/ibm/ibmvnic.c |

Re: 4.6.3 kernel panic on ppp interface termination (__tcf_hash_release / spinlock )

2016-07-06 Thread nuclearcat
On 2016-07-05 01:02, Cong Wang wrote: On Mon, Jul 4, 2016 at 12:07 PM, wrote: A little bit more details: ~ # tc -s -d filter show dev ppp0 parent : filter protocol ip pref 100 u32 filter protocol ip pref 100 u32 fh 800: ht divisor 1 filter protocol ip pref 100 u32 fh 800::1 order 1 key h

[PATCH] Remove lots of IS_ERR_VALUE abuses.

2016-07-06 Thread Arvind Yadav
Most users of IS_ERR_VALUE() in the kernel are wrong, as they pass an 'int' into a function that takes an 'unsigned long' argument. This happens to work because the type is sign-extended on 64-bit architectures before it gets converted into an unsigned type. However, anythi

[PATCH net-next] net: bridge: extend MLD/IGMP query stats

2016-07-06 Thread Nikolay Aleksandrov
As was suggested this patch adds support for the different versions of MLD and IGMP query types. Since the user visible structure is still in net-next we can augment it instead of adding netlink attributes. The distinction between the different IGMP/MLD query types is done as suggested in Section 7

Re: Network hang after c3f1010b30f7fc611139cfb702a8685741aa6827 with CIPSO & Smack

2016-07-06 Thread Casey Schaufler
On 7/6/2016 11:43 AM, David Ahern wrote: > On 7/6/16 11:01 AM, Casey Schaufler wrote: >> I find the test occasionally passes without hanging, but will >> hang the system if repeated. I am running on Ubuntu and Fedora, >> both with systemd, which may be a contributing factor. I run >> under qemu, an

Re: Network hang after c3f1010b30f7fc611139cfb702a8685741aa6827 with CIPSO & Smack

2016-07-06 Thread David Ahern
On 7/6/16 11:01 AM, Casey Schaufler wrote: I find the test occasionally passes without hanging, but will hang the system if repeated. I am running on Ubuntu and Fedora, both with systemd, which may be a contributing factor. I run under qemu, and am based on Linus' tree. With this: for n in $(

[PATCH/RFC iproute2 2/3] iptunnel: add support for mpls/ip to sit tunnels

2016-07-06 Thread Simon Horman
Signed-off-by: Simon Horman --- ip/link_iptnl.c | 12 +++- ip/tunnel.c | 10 ++ man/man8/ip-link.8.in | 9 + 3 files changed, 26 insertions(+), 5 deletions(-) diff --git a/ip/link_iptnl.c b/ip/link_iptnl.c index 8411a6a00a1b..34e4625b4335 100644 --- a/ip/

[PATCH/RFC iproute2 0/3] iptunnel: support MPLS in IPv4 and UDP

2016-07-06 Thread Simon Horman
This short series provides support for MPLS in IPv4 (RFC4023), and by virtue of FOU MPLS in UDP (RFC7510). The changes are as follows: 1. Document the mode parameter of SIT tunnels 2. Enhance ipip and sit to handle MPLS. Both already handle IPv4. sit also already handles IPv6. A corresponding

[PATCH/RFC iproute2 1/3] iptunnel: document mode parameter for sit tunnels

2016-07-06 Thread Simon Horman
Signed-off-by: Simon Horman --- man/man8/ip-link.8.in | 8 1 file changed, 8 insertions(+) diff --git a/man/man8/ip-link.8.in b/man/man8/ip-link.8.in index 375b4d081408..822cf1bbd5f1 100644 --- a/man/man8/ip-link.8.in +++ b/man/man8/ip-link.8.in @@ -605,6 +605,8 @@ the following additio

[PATCH/RFC iproute2 3/3] iptunnel: add support for mpls/ip to ipip tunnels

2016-07-06 Thread Simon Horman
Signed-off-by: Simon Horman --- ip/link_iptnl.c | 35 +++ man/man8/ip-link.8.in | 5 +++-- 2 files changed, 30 insertions(+), 10 deletions(-) diff --git a/ip/link_iptnl.c b/ip/link_iptnl.c index 34e4625b4335..43a431f6d3a7 100644 --- a/ip/link_iptnl.c +++ b/

[PATCH/RFC net-next 1/4] tunnels: support MPLS over IPv4 tunnels

2016-07-06 Thread Simon Horman
Extend tunnel support to MPLS over IPv4. The implementation extends the existing differentiation between IPIP and IPv6 over IPv4 to also cover MPLS over IPv4. Signed-off-by: Simon Horman Reviewed-by: Dinan Gunawardena --- net/ipv4/tunnel4.c | 77 +++-

[PATCH/RFC net-next 4/4] mpls: allow routes on ipip and sit devices

2016-07-06 Thread Simon Horman
Allow MPLS routes on IPIP and SIT devices now that they support forwarding MPLS packets. Signed-off-by: Simon Horman Reviewed-by: Dinan Gunawardena --- net/mpls/af_mpls.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c index e9be

[PATCH/RFC net-next 3/4] ipip: support MPLS over IPv4

2016-07-06 Thread Simon Horman
Extend the IPIP driver to support MPLS over IPv4. The implementation is an extension of existing support for IPv4 over IPv4 and is based of multiple inner-protocol support for the SIT driver. Signed-off-by: Simon Horman Reviewed-by: Dinan Gunawardena --- net/ipv4/ipip.c | 137 ++

[PATCH/RFC net-next 0/4] net: support MPLS in IPv4 and UDP

2016-07-06 Thread Simon Horman
This short series provides support for MPLS in IPv4 (RFC4023), and by virtue of FOU, MPLS in UDP (RFC7510). The changes are as follows: 1. Teach tunnel4.c about AF_MPLS, it already understands AF_INET and AF_INET6 2. Enhance IPIP and SIT to handle MPLS. Both already handle IPv4. SIT also alr

[PATCH/RFC net-next 2/4] sit: support MPLS over IPv4

2016-07-06 Thread Simon Horman
Extend the SIT driver to support MPLS over IPv4. This implementation extends existing support for IPv6 over IPv4 and IPv4 over IPv4. Signed-off-by: Simon Horman Reviewed-by: Dinan Gunawardena --- net/ipv6/sit.c | 93 -- 1 file changed, 77

Re: [PATCH 03/26] netfilter: x_tables: fix possible ZERO_SIZE_PTR pointer dereferencing error.

2016-07-06 Thread Sergei Shtylyov
Hello. On 07/06/2016 05:23 PM, Pablo Neira Ayuso wrote: From: Xiubo Li Since we cannot make sure that the 'hook_mask' will always be none zero here. Non-zero, you mean? If it equals to zero, the num_hooks will be zero too, and then kmalloc() will return ZERO_SIZE_PTR, which is (void *)

Re: Network hang after c3f1010b30f7fc611139cfb702a8685741aa6827 with CIPSO & Smack

2016-07-06 Thread Casey Schaufler
On 7/6/2016 10:40 AM, David Ahern wrote: > On 7/6/16 10:24 AM, Casey Schaufler wrote: >> On 7/6/2016 9:28 AM, David Ahern wrote: >>> On 7/5/16 6:31 PM, Casey Schaufler wrote: On 7/5/2016 5:49 PM, David Ahern wrote: > On 7/5/16 5:38 PM, Casey Schaufler wrote: >> I have encountered a sys

[PATCH net-next v11 3/6] openvswitch: set skb protocol and mac_len when receiving on internal device

2016-07-06 Thread Simon Horman
* Set skb protocol based on contents of packet. I have observed this is necessary to get actual protocol of a packet when it is injected into an internal device e.g. by libnet in which case skb protocol will be set to ETH_ALL. * Set the mac_len which has been observed to not be set up correc

[PATCH net-next v11 1/6] net: introduce skb_transport_header_was_set()

2016-07-06 Thread Simon Horman
This helper resets the mac_header of an skb to a state where skb_transport_header_was_set() will return false. This is intended to be used with packets received on ARPHRD_NONE devices without an Ethernet header in the inner packet. It allows skb_transport_header_was_set to be subsequently used to

[PATCH net-next v11 0/6] openvswitch: support for layer 3 encapsulated packets

2016-07-06 Thread Simon Horman
At the core of this patch set is removing the assumption in Open vSwitch datapath that all packets have Ethernet header. Support for layer 3 GRE tunnels is also added by this patchset. The implementation relies on the presence of pop_eth and push_eth actions in datapath flows to facilitate adding

[PATCH net-next v11 2/6] gre: unset mac header for non-TEB packets received by ipgre device

2016-07-06 Thread Simon Horman
unset rather than reset mach header for non-TEB packets received by an ipgre device. This allows skb_transport_header_was_set to be subsequently used to differentiate TEB and non-TEB packets recieved on an ipgre device. Signed-off-by: Simon Horman --- v11 * New patch --- net/ipv4/ip_gre.c | 2 +

[PATCH net-next v11 4/6] openvswitch: add support to push and pop mpls for layer3 packets

2016-07-06 Thread Simon Horman
Allow push and pop mpls actions to act on layer 3 packets by teaching them not to access non-existent L2 headers of such packets. Signed-off-by: Simon Horman --- v11 * group l2 code in pop_mpls() v10 * Limit scope of hdr in {push,pop}_mpls() v9 * New Patch --- include/uapi/linux/openvswitch.h

[PATCH net-next v11 5/6] openvswitch: add layer 3 flow/port support

2016-07-06 Thread Simon Horman
From: Lorand Jakab Implementation of the pop_eth and push_eth actions in the kernel, and layer 3 flow support. This doesn't actually do anything yet as no layer 2 tunnel ports are supported yet. The original patch by Lorand was against the Open vSwitch tree which has L2 LISP tunnels but that is

[PATCH net-next v11 6/6] openvswitch: use ipgre tunnel rather than gretap tunnel

2016-07-06 Thread Simon Horman
This allows GRE tunnels to send and receive both layer 2 packets (packets with an ethernet header) and layer 3 packets (packets without an ethernet header). Signed-off-by: Simon Horman --- v11 * Make use of skb_mac_header_was_set() to avoid needing to calculate mac_len v10 * Handle case of l3 on

Re: [PATCH net-next V4 0/6] switch to use tx skb array in tun

2016-07-06 Thread Craig Gallek
On Thu, Jun 30, 2016 at 2:45 AM, Jason Wang wrote: > Hi all: > > This series tries to switch to use skb array in tun. This is used to > eliminate the spinlock contention between producer and consumer. The > conversion was straightforward: just introdce a tx skb array and use > it instead of sk_rec

Re: Network hang after c3f1010b30f7fc611139cfb702a8685741aa6827 with CIPSO & Smack

2016-07-06 Thread David Ahern
On 7/6/16 10:24 AM, Casey Schaufler wrote: On 7/6/2016 9:28 AM, David Ahern wrote: On 7/5/16 6:31 PM, Casey Schaufler wrote: On 7/5/2016 5:49 PM, David Ahern wrote: On 7/5/16 5:38 PM, Casey Schaufler wrote: I have encountered a system hang with my Smack networking tests that bisects to the ch

Re: Network hang after c3f1010b30f7fc611139cfb702a8685741aa6827 with CIPSO & Smack

2016-07-06 Thread Casey Schaufler
On 7/6/2016 9:28 AM, David Ahern wrote: > On 7/5/16 6:31 PM, Casey Schaufler wrote: >> On 7/5/2016 5:49 PM, David Ahern wrote: >>> On 7/5/16 5:38 PM, Casey Schaufler wrote: I have encountered a system hang with my Smack networking tests that bisects to the change below. I can't say t

Re: Network hang after c3f1010b30f7fc611139cfb702a8685741aa6827 with CIPSO & Smack

2016-07-06 Thread David Ahern
On 7/5/16 6:31 PM, Casey Schaufler wrote: On 7/5/2016 5:49 PM, David Ahern wrote: On 7/5/16 5:38 PM, Casey Schaufler wrote: I have encountered a system hang with my Smack networking tests that bisects to the change below. I can't say that I have any idea why the change would impact the Smack pr

[PATCHv5 wl-drv-next 1/2] add basic register-field manipulation macros

2016-07-06 Thread Jakub Kicinski
Common approach to accessing register fields is to define structures or sets of macros containing mask and shift pair. Operations on the register are then performed as follows: field = (reg >> shift) & mask; reg &= ~(mask << shift); reg |= (field & mask) << shift; Defining shift and mask sepa

[PATCHv5 wl-drv-next 2/2] mt7601u: use linux/bitfield.h

2016-07-06 Thread Jakub Kicinski
Use the newly added linux/bitfield.h. Signed-off-by: Jakub Kicinski --- drivers/net/wireless/mediatek/mt7601u/dma.h | 2 - drivers/net/wireless/mediatek/mt7601u/mt7601u.h | 5 +- drivers/net/wireless/mediatek/mt7601u/util.h| 77 - 3 files changed, 4 insertions(+

[PATCHv5 wl-drv-next 0/2] register-field manipulation macros

2016-07-06 Thread Jakub Kicinski
Hi! I've added few lines about the compilation problems in the commit message of patch 1. I would prefer the mass rename of macros in mt7601u not to be part of this series so patch 2 is left as it was and I'll follow up once this is accepted. == v4 blurb This set moves to a global header file

Re: [PATCH 00/26] Netfilter updates for net-next

2016-07-06 Thread David Miller
From: Pablo Neira Ayuso Date: Wed, 6 Jul 2016 16:23:42 +0200 > The following patchset contains Netfilter updates for net-next, > they are: Pulled, thanks Pablo.

pull-request: mac80211-next 2016-07-06

2016-07-06 Thread Johannes Berg
Hi Dave, And here's another set of new things. This is the last one I'll send since I'll be away for a bit. Let me know if there's any problem. Thanks, johannes The following changes since commit ee58b57100ca953da7320c285315a95db2f7053d: Merge git://git.kernel.org/pub/scm/linux/kernel/git/

Fwd: Fwd: Re: [PATCH net-next 00/15] net/smc: Shared Memory Communications - RDMA

2016-07-06 Thread Ursula Braun
Dave, we still like to see SMC-R included into a future Linux-kernel. After answering your first 2 questions, there is no longer a response. What should we do next? - Still wait for an answer from you? - Resend the same whole SMC-R patch series, this time with the cover letter adapted to your

RE: [RFC PATCH v2 1/4] Documentation: DT: net: Add Xilinx gmiitorgmii converter device tree binding documentation

2016-07-06 Thread Punnaiah Choudary Kalluri
> -Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Wednesday, July 06, 2016 7:51 PM > To: Punnaiah Choudary Kalluri > Cc: Appana Durga Kedareswara Rao ; > robh...@kernel.org; mark.rutl...@arm.com; Michal Simek > ; Soren Brinkmann ; > nicolas.fe...@atmel.com; f.faine

Re: [PATCH net-next 04/24] rxrpc: Avoid using stack memory in SG lists in rxkad

2016-07-06 Thread David Howells
Andy Lutomirski wrote: > > From: Herbert Xu > > > > rxkad uses stack memory in SG lists which would not work if stacks were > > allocated from vmalloc memory. In fact, in most cases this isn't even > > necessary as the stack memory ends up getting copied over to kmalloc > > memory. > > This ve

Re: [PATCH 06/26] netfilter: conntrack: align nf_conn on cacheline boundary

2016-07-06 Thread Florian Westphal
David Laight wrote: > From: Pablo Neira Ayuso > > Sent: 06 July 2016 15:24 > > From: Florian Westphal > > > > increases struct size by 32 bytes (288 -> 320), but it is the right thing, > > else any attempt to (re-)arrange nf_conn members by cacheline won't work. > ... > > nf_conntrack_cachep

RE: [PATCH 06/26] netfilter: conntrack: align nf_conn on cacheline boundary

2016-07-06 Thread David Laight
From: Pablo Neira Ayuso > Sent: 06 July 2016 15:24 > From: Florian Westphal > > increases struct size by 32 bytes (288 -> 320), but it is the right thing, > else any attempt to (re-)arrange nf_conn members by cacheline won't work. ... > nf_conntrack_cachep = kmem_cache_create("nf_conntrack"

Re: Network hang after c3f1010b30f7fc611139cfb702a8685741aa6827 with CIPSO & Smack

2016-07-06 Thread Casey Schaufler
On 7/6/2016 7:03 AM, Paul Moore wrote: > On Wed, Jul 6, 2016 at 8:50 AM, Paul Moore wrote: >> On Tue, Jul 5, 2016 at 8:38 PM, Casey Schaufler >> wrote: >>> I have encountered a system hang with my Smack >>> networking tests that bisects to the change below. >>> I can't say that I have any idea w

Re: Network hang after c3f1010b30f7fc611139cfb702a8685741aa6827 with CIPSO & Smack

2016-07-06 Thread Paul Moore
On Wed, Jul 6, 2016 at 10:15 AM, Casey Schaufler wrote: > On 7/6/2016 5:50 AM, Paul Moore wrote: >> On Tue, Jul 5, 2016 at 8:38 PM, Casey Schaufler >> wrote: >>> I have encountered a system hang with my Smack >>> networking tests that bisects to the change below. >>> I can't say that I have any

[PATCH 17/26] netfilter: nft_rbtree: check for next generation when deactivating elements

2016-07-06 Thread Pablo Neira Ayuso
set->ops->deactivate() is invoked from nft_del_setelem() that happens from the transaction path, so we have to check if the object is active in the next generation, not the current. Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nft_rbtree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH 25/26] netfilter: Convert FWINV<[foo]> macros and uses to NF_INVF

2016-07-06 Thread Pablo Neira Ayuso
From: Joe Perches netfilter uses multiple FWINV #defines with identical form that hide a specific structure variable and dereference it with a invflags member. $ git grep "#define FWINV" include/linux/netfilter_bridge/ebtables.h:#define FWINV(bool,invflg) ((bool) ^ !!(info->invflags & invflg))

[PATCH 14/26] netfilter: nf_tables: add generation mask to tables

2016-07-06 Thread Pablo Neira Ayuso
This patch addresses two problems: 1) The netlink dump is inconsistent when interfering with an ongoing transaction update for several reasons: 1.a) We don't honor the internal NFT_TABLE_INACTIVE flag, and we should be skipping these inactive objects in the dump. 1.b) We perform speculat

[PATCH 24/26] netfilter: Remove references to obsolete CONFIG_IP_ROUTE_FWMARK

2016-07-06 Thread Pablo Neira Ayuso
From: Moritz Sichert This option was removed in commit 47dcf0cb1005 ("[NET]: Rethink mark field in struct flowi"). Signed-off-by: Moritz Sichert Signed-off-by: Pablo Neira Ayuso --- net/netfilter/Kconfig | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/net/netfil

[PATCH 04/26] netfilter: nf_log: handle NFPROTO_INET properly in nf_logger_[find_get|put]

2016-07-06 Thread Pablo Neira Ayuso
From: Liping Zhang When we request NFPROTO_INET, it means both NFPROTO_IPV4 and NFPROTO_IPV6. Signed-off-by: Liping Zhang Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nf_log.c | 20 net/netfilter/nft_log.c | 21 + 2 files changed, 21 insertions(

[PATCH 16/26] netfilter: nf_tables: add generation mask to sets

2016-07-06 Thread Pablo Neira Ayuso
Similar to ("netfilter: nf_tables: add generation mask to tables"). Signed-off-by: Pablo Neira Ayuso --- include/net/netfilter/nf_tables.h | 8 +++-- net/netfilter/nf_tables_api.c | 68 +++ net/netfilter/nft_dynset.c| 7 ++-- net/netfilter/nft_lo

  1   2   >