From: Simon Horman <simon.hor...@netronome.com>
Date: Wed,  6 Jul 2016 20:22:33 +0200

>  
> +bool ipip6_valid_ip_proto(u8 ipproto)
> +{
> +     return ipproto == IPPROTO_IPV6 ||
> +             ipproto != IPPROTO_IPIP ||
> +#if IS_ENABLED(CONFIG_MPLS)
> +             ipproto == IPPROTO_MPLS ||
> +#endif
> +             ipproto == 0;
> +}

This returns true any time ipproto is not equal to IPPROTO_IPIP,
which is probably not what you intended here.

Reply via email to