Re: [4.5-rc7+ regression, bisected] libphy: PHY stmmac-0:ffffffff not found

2016-03-08 Thread Giuseppe CAVALLARO
Hi Frank yes we are also looking at this problem in this thread: [PATCH v3 0/8] arm64: rockchip: Initial GeekBox enablement I am implementing a patch and I will propose it soon. Peppe On 3/8/2016 7:06 PM, Frank Schäfer wrote: commit 88f8b1bb41c6208f81b6a480244533ded7b59493 Author: Gabriel

Re: [PATCH net 1/3] net: mvneta: Fix spinlock usage

2016-03-08 Thread Gregory CLEMENT
Hi Jisheng, On mer., mars 09 2016, Jisheng Zhang wrote: > Dear Gregory, > > On Tue, 8 Mar 2016 13:57:04 +0100 Gregory CLEMENT wrote: > >> In the previous patch, the spinlock was not initialized. While it didn't >> cause any trouble yet it could be a problem to use it uninitialized. >> >> The

Re: [PATCH v3 0/8] arm64: rockchip: Initial GeekBox enablement

2016-03-08 Thread Giuseppe CAVALLARO
Hi Dinh On 3/8/2016 4:45 PM, Dinh Nguyen wrote: On Tue, Mar 8, 2016 at 1:24 AM, Giuseppe CAVALLARO wrote: Hi Dinh, On 3/8/2016 12:22 AM, Dinh Nguyen wrote: [snip] I'm seeing the same issue on the SoCFPGA platform: libphy: PHY stmmac-0: not found eth0: Could not attach to PHY stmma

[PATCH net-next 3/4] qed: Notify of transciever changes

2016-03-08 Thread Yuval Mintz
From: Zvi Nachmani Handle a new message from the MFW, one that indicate that the transciever state has changed, and log that into the system logs. Signed-off-by: Zvi Nachmani Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed_hsi.h | 11 +++ drivers/net/ethernet/qlogic

[PATCH net-next 4/4] qed: Enlrage the drain timeout

2016-03-08 Thread Yuval Mintz
In the scenario where slowpath configuration isn't passing due to various pause configurations affecting the chip, the theoretical time required in worst-case-scenario to empty hw fifos sufficiently to guarantee that slowpath configuration would flow is currently insufficient. This increases such

[PATCH net-next 0/4] qed: Management firmware updates

2016-03-08 Thread Yuval Mintz
This series contains several changes to driver interaction with the management fw. The biggest [& most significant] change here is a change in the locking scheme and re-definition of the 'critical section' when accessing shared resources toward the goal of interacting with the management firmware.

[PATCH net-next 1/4] qed: Prevent MF link notifications

2016-03-08 Thread Yuval Mintz
From: Sudarsana Reddy Kalluru When device is configured for Multi-function mode, some older management firmware might incorrectly notify interfaces of link changes while they haven't requested the physical link configuration to be set. This can create bizzare race conditions where unloading inter

[PATCH net-next 2/4] qed: Major changes to MB locking

2016-03-08 Thread Yuval Mintz
From: Tomer Tayar Driver interaction with the managemnt firmware is done via mailbox commands which the management firmware periodically sample, as well as placing of additional data in set places in the shared memory. Each PF has a single designated mailbox address, and all flows that require me

Re: [PATCH net 1/3] net: mvneta: Fix spinlock usage

2016-03-08 Thread Jisheng Zhang
Dear Gregory, On Tue, 8 Mar 2016 13:57:04 +0100 Gregory CLEMENT wrote: > In the previous patch, the spinlock was not initialized. While it didn't > cause any trouble yet it could be a problem to use it uninitialized. > > The most annoying part was the critical section protected by the spinlock >

Re: [net-next PATCH] csum: Update csum_block_add to use rotate instead of byteswap

2016-03-08 Thread Tom Herbert
On Tue, Mar 8, 2016 at 10:08 PM, Alexander Duyck wrote: > On Tue, Mar 8, 2016 at 9:50 PM, Joe Perches wrote: >> On Tue, 2016-03-08 at 21:23 -0800, Alexander Duyck wrote: >>> On Tue, Mar 8, 2016 at 3:25 PM, Joe Perches wrote: >>> > On Tue, 2016-03-08 at 14:42 -0800, Alexander Duyck wrote: >>> > >

Re: [net-next PATCH] csum: Update csum_block_add to use rotate instead of byteswap

2016-03-08 Thread Alexander Duyck
On Tue, Mar 8, 2016 at 9:50 PM, Joe Perches wrote: > On Tue, 2016-03-08 at 21:23 -0800, Alexander Duyck wrote: >> On Tue, Mar 8, 2016 at 3:25 PM, Joe Perches wrote: >> > On Tue, 2016-03-08 at 14:42 -0800, Alexander Duyck wrote: >> > > The code for csum_block_add was doing a funky byteswap to swap

Re: [net-next PATCH] csum: Update csum_block_add to use rotate instead of byteswap

2016-03-08 Thread Joe Perches
On Tue, 2016-03-08 at 21:23 -0800, Alexander Duyck wrote: > On Tue, Mar 8, 2016 at 3:25 PM, Joe Perches wrote: > > On Tue, 2016-03-08 at 14:42 -0800, Alexander Duyck wrote: > > > The code for csum_block_add was doing a funky byteswap to swap the even > > > and > > > odd bytes of the checksum if t

[PATCH 0/2] drivers: net: xgene: fix irq related issues

2016-03-08 Thread Iyappan Subramanian
This patch set addresses, 1. Remove static association of prefetch buffers and derive that from Linux irq 2. Remove irq sharing Signed-off-by: Iyappan Subramanian --- Iyappan Subramanian (2): drivers: net: xgene: fix: Derive prefetch number from irq drivers: net: xgene: fix

[PATCH 1/2] drivers: net: xgene: fix: Derive prefetch number from irq

2016-03-08 Thread Iyappan Subramanian
Prefetch buffer numbers are mapped to hardware irqs. Currently they are statically assigned to match with firmware irqs. If the irq on firmware changes, prefetch buffer number on the driver also needs to be updated to match with the firmware. This patch removes this static association between fir

[PATCH 2/2] drivers: net: xgene: fix: Remove IRQF_SHARED flag

2016-03-08 Thread Iyappan Subramanian
Not allowing sharing of IRQs. Signed-off-by: Iyappan Subramanian Tested-by: Toan Le --- drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c b/drivers/net/ethernet/apm/xgene/xge

Re: [PATCH nf-next v8 8/8] openvswitch: Interface with NAT.

2016-03-08 Thread kbuild test robot
Hi Jarno, [auto build test ERROR on nf-next/master] url: https://github.com/0day-ci/linux/commits/Jarno-Rajahalme/netfilter-Remove-IP_CT_NEW_REPLY-definition/20160309-083126 base: https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next master config: x86_64-randconfig-s3-03091202 (att

Re: [net-next PATCH] csum: Update csum_block_add to use rotate instead of byteswap

2016-03-08 Thread Alexander Duyck
On Tue, Mar 8, 2016 at 3:25 PM, Joe Perches wrote: > On Tue, 2016-03-08 at 14:42 -0800, Alexander Duyck wrote: >> The code for csum_block_add was doing a funky byteswap to swap the even and >> odd bytes of the checksum if the offset was odd. Instead of doing this we >> can save ourselves some tro

Re: [PATCH nf-next v8 8/8] openvswitch: Interface with NAT.

2016-03-08 Thread kbuild test robot
Hi Jarno, [auto build test ERROR on nf-next/master] url: https://github.com/0day-ci/linux/commits/Jarno-Rajahalme/netfilter-Remove-IP_CT_NEW_REPLY-definition/20160309-083126 base: https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next master config: x86_64-randconfig-b0-03091138 (att

Re: [PATCH net-next 2/3] samples/bpf: stress test bpf_get_stackid

2016-03-08 Thread David Miller
From: Alexei Starovoitov Date: Tue, 8 Mar 2016 15:07:53 -0800 > increase stress by also calling bpf_get_stackid() from > various *spin* functions > > Signed-off-by: Alexei Starovoitov Applied.

Re: [PATCH net-next 1/3] samples/bpf: add bpf map stress test

2016-03-08 Thread David Miller
From: Alexei Starovoitov Date: Tue, 8 Mar 2016 15:07:52 -0800 > this test calls bpf programs from different contexts: > from inside of slub, from rcu, from pretty much everywhere, > since it kprobes all spin_lock functions. > It stresses the bpf hash and percpu map pre-allocation, > deallocation

Re: [PATCH net-next 3/3] samples/bpf: add map performance test

2016-03-08 Thread David Miller
From: Alexei Starovoitov Date: Tue, 8 Mar 2016 15:07:54 -0800 > performance tests for hash map and per-cpu hash map > with and without pre-allocation > > Signed-off-by: Alexei Starovoitov Applied.

Re: [PATCH net-next] ip_tunnel, bpf: ip_tunnel_info_opts_{get,set} depends on CONFIG_INET

2016-03-08 Thread David Miller
From: Daniel Borkmann Date: Tue, 8 Mar 2016 23:36:03 +0100 > Helpers like ip_tunnel_info_opts_{get,set}() are only available if > CONFIG_INET is set, thus add an empty definition into the header for > the !CONFIG_INET case, where already other empty inline helpers are > defined. > > This avoids

Re: [PATCH net-next 3/4] geneve: support setting IPv6 flow label

2016-03-08 Thread Tom Herbert
On Tue, Mar 8, 2016 at 6:00 PM, Daniel Borkmann wrote: > This work adds support for setting the IPv6 flow label for geneve per > device and through collect metadata (ip_tunnel_key) frontends. Also here, > the geneve dst cache does not need any special considerations, for the > cases where caches c

Re: [PATCH net-next 2/4] vxlan: support setting IPv6 flow label

2016-03-08 Thread Tom Herbert
On Tue, Mar 8, 2016 at 6:00 PM, Daniel Borkmann wrote: > This work adds support for setting the IPv6 flow label for vxlan per > device and through collect metadata (ip_tunnel_key) frontends. The > vxlan dst cache does not need any special considerations here, for > the cases where caches can be us

Re: [PATCH 01/11] rxrpc: Add a common object cache

2016-03-08 Thread David Miller
From: David Howells Date: Tue, 08 Mar 2016 21:11:09 + > I can put in a limit per peer, where a 'peer' is either a particular remote > UDP port or particulat remote host. TCP has this by virtue of having a > limited number of ports available per IP address. But if I have 10 IP > addresses av

Re: [RFC] xfrm: netdevice unregistration during decryption

2016-03-08 Thread Herbert Xu
On Tue, Mar 08, 2016 at 07:16:23PM -0700, subas...@codeaurora.org wrote: > > 2. Encrypted packet queued for decryption (asynchronous) > > static int esp_input(struct xfrm_state *x, struct sk_buff *skb) > ... > aead_request_set_callback(req, 0, esp_input_done, skb); I suppose we'll have t

[RFC] xfrm: netdevice unregistration during decryption

2016-03-08 Thread subashab
I am observing a crash originating from XFRM framework on a 3.18 ARM64 kernel. get_rps_cpus tries to dereference the skb->dev fields but it appears that the device is freed from the poison pattern. The following is the crash call stack - 55428.227024: <2> [] get_rps_cpu+0x94/0x2f0 55428.22

[PATCH net-next 3/4] geneve: support setting IPv6 flow label

2016-03-08 Thread Daniel Borkmann
This work adds support for setting the IPv6 flow label for geneve per device and through collect metadata (ip_tunnel_key) frontends. Also here, the geneve dst cache does not need any special considerations, for the cases where caches can be used, the label is static per cache. Signed-off-by: Danie

[PATCH net-next 2/4] vxlan: support setting IPv6 flow label

2016-03-08 Thread Daniel Borkmann
This work adds support for setting the IPv6 flow label for vxlan per device and through collect metadata (ip_tunnel_key) frontends. The vxlan dst cache does not need any special considerations here, for the cases where caches can be used, the label is static per cache. Signed-off-by: Daniel Borkma

[PATCH net-next 1/4] ip_tunnel: add support for setting flow label via collect metadata

2016-03-08 Thread Daniel Borkmann
This patch extends udp_tunnel6_xmit_skb() to pass in the IPv6 flow label from call sites. Currently, there's no such option and it's always set to zero when writing ip6_flow_hdr(). Add a label member to ip_tunnel_key, so that flow-based tunnels via collect metadata frontends can make use of it. vxl

[PATCH net-next 4/4] bpf: support flow label for bpf_skb_{set,get}_tunnel_key

2016-03-08 Thread Daniel Borkmann
This patch extends bpf_tunnel_key with a tunnel_label member, that maps to ip_tunnel_key's label so underlying backends like vxlan and geneve can propagate the label to udp_tunnel6_xmit_skb(), where it's being set in the IPv6 header. It allows for having 20 more bits to encode/decode flow related m

[PATCH net-next 0/4] BPF support for flow labels

2016-03-08 Thread Daniel Borkmann
This set adds support for tunnel key flow labels for vxlan and geneve devices in collect meta data mode and eBPF support for managing these. For details please see individual patches. Thanks! Daniel Borkmann (4): ip_tunnel: add support for setting flow label via collect metadata vxlan: suppor

Re: Question on switchdev

2016-03-08 Thread Andrew Lunn
> Andrew, > > >From the high level, it looks like netcp switch meets the specifications > of a DSA hardware. Can you point me to a specific implementation that > I can use as an example to implement this for netcp? You need two parts: A tagging implementation, in net/dsa/tag_*.c. They are all pr

[PATCH nf-next v8 6/8] openvswitch: Handle NF_REPEAT in conntrack action.

2016-03-08 Thread Jarno Rajahalme
Repeat the nf_conntrack_in() call when it returns NF_REPEAT. This avoids dropping a SYN packet re-opening an existing TCP connection. Signed-off-by: Jarno Rajahalme Acked-by: Joe Stringer --- net/openvswitch/conntrack.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --g

[PATCH nf-next v8 5/8] openvswitch: Find existing conntrack entry after upcall.

2016-03-08 Thread Jarno Rajahalme
Add a new function ovs_ct_find_existing() to find an existing conntrack entry for which this packet was already applied to. This is only to be called when there is evidence that the packet was already tracked and committed, but we lost the ct reference due to an userspace upcall. ovs_ct_find_exis

[PATCH nf-next v8 8/8] openvswitch: Interface with NAT.

2016-03-08 Thread Jarno Rajahalme
Extend OVS conntrack interface to cover NAT. New nested OVS_CT_ATTR_NAT attribute may be used to include NAT with a CT action. A bare OVS_CT_ATTR_NAT only mangles existing and expected connections. If OVS_NAT_ATTR_SRC or OVS_NAT_ATTR_DST is included within the nested attributes, new (non-committed

[PATCH nf-next v8 7/8] openvswitch: Delay conntrack helper call for new connections.

2016-03-08 Thread Jarno Rajahalme
There is no need to help connections that are not confirmed, so we can delay helping new connections to the time when they are confirmed. This change is needed for NAT support, and having this as a separate patch will make the following NAT patch a bit easier to review. Signed-off-by: Jarno Rajaha

[PATCH nf-next v8 2/8] netfilter: Allow calling into nat helper without skb_dst.

2016-03-08 Thread Jarno Rajahalme
NAT checksum recalculation code assumes existence of skb_dst, which becomes a problem for a later patch in the series ("openvswitch: Interface with NAT."). Simplify this by removing the check on skb_dst, as the checksum will be dealt with later in the stack. Suggested-by: Pravin Shelar Signed-of

[PATCH nf-next v8 4/8] openvswitch: Update the CT state key only after nf_conntrack_in().

2016-03-08 Thread Jarno Rajahalme
Only a successful nf_conntrack_in() call can effect a connection state change, so if suffices to update the key only after the nf_conntrack_in() returns. This change is needed for the later NAT patches. Signed-off-by: Jarno Rajahalme --- net/openvswitch/conntrack.c | 7 --- 1 file changed,

[PATCH nf-next v8 3/8] openvswitch: Add commentary to conntrack.c

2016-03-08 Thread Jarno Rajahalme
This makes the code easier to understand and the following patches more focused. Signed-off-by: Jarno Rajahalme --- net/openvswitch/conntrack.c | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/net/openvswitch/conntrack.c b/net/openvswitch/conntrack.c inde

[PATCH nf-next v8 1/8] netfilter: Remove IP_CT_NEW_REPLY definition.

2016-03-08 Thread Jarno Rajahalme
Remove the definition of IP_CT_NEW_REPLY from the kernel as it does not make sense. This allows the definition of IP_CT_NUMBER to be simplified as well. Signed-off-by: Jarno Rajahalme --- include/uapi/linux/netfilter/nf_conntrack_common.h | 12 +--- net/openvswitch/conntrack.c

Re: [PATCH net] r8169:Remove unnecessary phy reset for pcie nic when setting link spped.

2016-03-08 Thread Francois Romieu
Chunhao Lin : > For pcie nic, after setting link speed and thers is no link driver does not > need > to do phy reset untill link up. > > For some pcie nics, to do this will also reset phy speed down counter and > prevent > phy from auto speed down. > > This patch fix the issue reported in fol

Re: [net-next PATCH] csum: Update csum_block_add to use rotate instead of byteswap

2016-03-08 Thread Joe Perches
On Tue, 2016-03-08 at 14:42 -0800, Alexander Duyck wrote: > The code for csum_block_add was doing a funky byteswap to swap the even and > odd bytes of the checksum if the offset was odd.  Instead of doing this we > can save ourselves some trouble and just shift by 8 as this should have the > same e

[PATCH net-next 3/3] samples/bpf: add map performance test

2016-03-08 Thread Alexei Starovoitov
performance tests for hash map and per-cpu hash map with and without pre-allocation Signed-off-by: Alexei Starovoitov --- samples/bpf/Makefile | 4 + samples/bpf/map_perf_test_kern.c | 100 + samples/bpf/map_perf_test_user.c | 155 +++

[PATCH net-next 1/3] samples/bpf: add bpf map stress test

2016-03-08 Thread Alexei Starovoitov
this test calls bpf programs from different contexts: from inside of slub, from rcu, from pretty much everywhere, since it kprobes all spin_lock functions. It stresses the bpf hash and percpu map pre-allocation, deallocation logic and call_rcu mechanisms. User space part adding more stress by walki

[PATCH net-next 2/3] samples/bpf: stress test bpf_get_stackid

2016-03-08 Thread Alexei Starovoitov
increase stress by also calling bpf_get_stackid() from various *spin* functions Signed-off-by: Alexei Starovoitov --- samples/bpf/spintest_kern.c | 9 + 1 file changed, 9 insertions(+) diff --git a/samples/bpf/spintest_kern.c b/samples/bpf/spintest_kern.c index ef8ac33bb2e9..4b27619d91a

Re: [PATCH v2 net-next 0/12] bpf: map pre-alloc

2016-03-08 Thread Alexei Starovoitov
On Tue, Mar 08, 2016 at 03:31:10PM -0500, David Miller wrote: ... > > Patch 10: stress test for hash map infra. It attaches to spin_lock > > functions and bpf_map_update/delete are called from different contexts > > Patch 11: stress for bpf_get_stackid > > Patch 12: map performance test > > > > Re

Re: [PATCH net-next] ip_tunnel, bpf: ip_tunnel_info_opts_{get,set} depends on CONFIG_INET

2016-03-08 Thread Alexei Starovoitov
On Tue, Mar 08, 2016 at 11:36:03PM +0100, Daniel Borkmann wrote: > Helpers like ip_tunnel_info_opts_{get,set}() are only available if > CONFIG_INET is set, thus add an empty definition into the header for > the !CONFIG_INET case, where already other empty inline helpers are > defined. > > This avo

[PATCH net-next] ip_tunnel, bpf: ip_tunnel_info_opts_{get,set} depends on CONFIG_INET

2016-03-08 Thread Daniel Borkmann
Helpers like ip_tunnel_info_opts_{get,set}() are only available if CONFIG_INET is set, thus add an empty definition into the header for the !CONFIG_INET case, where already other empty inline helpers are defined. This avoids ifdef kludge inside filter.c, but also vxlan and geneve themself where th

[net-next PATCH] csum: Update csum_block_add to use rotate instead of byteswap

2016-03-08 Thread Alexander Duyck
The code for csum_block_add was doing a funky byteswap to swap the even and odd bytes of the checksum if the offset was odd. Instead of doing this we can save ourselves some trouble and just shift by 8 as this should have the same effect in terms of the final checksum value and only requires one i

Re: [PATCH net-next 5/5] vxlan: implement GPE in L3 mode

2016-03-08 Thread Jesse Gross
On Sat, Feb 27, 2016 at 11:44 AM, Jiri Benc wrote: > On Sat, 27 Feb 2016 20:21:59 +0100, Jiri Benc wrote: >> You mean returning ETH_P_TEB in skb->protocol? That's not much useful, >> unfortunately. You won't get such packet processed by the kernel IP >> stack, rendering the VXLAN-GPE device unusab

[PATCH] cisco: enic: Update logging macros and uses

2016-03-08 Thread Joe Perches
Don't hide varibles used by the logging macros. Miscellanea: o Use the more common ##__VA_ARGS__ extension o Add missing newlines to formats o Realign arguments Signed-off-by: Joe Perches --- drivers/net/ethernet/cisco/enic/enic.h | 22 -- drivers/net/ethernet/cisco/enic/vnic_

Re: linux-next: manual merge of the crypto tree with the net-next tree

2016-03-08 Thread Stephen Rothwell
Hi David, On Tue, 08 Mar 2016 16:48:07 + David Howells wrote: > > Stephen Rothwell wrote: > > > > What's the best way to deal with this? Should I take Herbert's > > > > > > [PATCH 18/26] rxrpc: Use skcipher > > > > > > patch into my rxrpc tree also and pass it on to Dave? > > > > Li

Re: [PATCH 01/11] rxrpc: Add a common object cache

2016-03-08 Thread David Howells
David Miller wrote: > > One could argue, I suppose, that things should've been arranged that the > > RxRPC client would manage the lifetime of each connection it sets up, > > rather than both ends letting it lapse by mutual loss of interest. But > > you *still* have to have a timeout, lest the c

[PATCH net 0/3] bridge: ageing timer regression fix

2016-03-08 Thread Stephen Hemminger
This fixes regression in how ageing timer is managed. Backing out the change required fixing switch drivers as well. Ido Schimmel (2): mlxsw: spectrum: Check requested ageing time is valid rocker: Set FDB cleanup timer according to lowest ageing time Stephen Hemminger (1): bridge: fix regre

[PATCH 1/3] mlxsw: spectrum: Check requested ageing time is valid

2016-03-08 Thread Stephen Hemminger
From: Ido Schimmel Commit c62987bbd8a1 ("bridge: push bridge setting ageing_time down to switchdev") added a check for minimum and maximum ageing time, but this breaks existing behaviour where one can set ageing time to 0 for a non-learning bridge. Push this check down to the driver and allow th

[PATCH 3/3] bridge: allow zero ageing time

2016-03-08 Thread Stephen Hemminger
From: Stephen Hemminger This fixes a regression in the bridge ageing time caused by: commit c62987bbd8a1 ("bridge: push bridge setting ageing_time down to switchdev") There are users of Linux bridge which use the feature that if ageing time is set to 0 it causes entries to never expire. See:

[PATCH 2/3] rocker: set FDB cleanup timer according to lowest ageing time

2016-03-08 Thread Stephen Hemminger
From: Ido Schimmel In rocker, ageing time is a per-port attribute, so the next time the FDB cleanup timer fires should be set according to the lowest ageing time. This will later allow us to delete the BR_MIN_AGEING_TIME macro, which was added to guarantee minimum ageing time in the bridge layer

Re: [PATCH 4/5] net: sxgbe: fix error paths in sxgbe_platform_probe()

2016-03-08 Thread Rasmus Villemoes
ping On Tue, Feb 09 2016, Rasmus Villemoes wrote: > We need to use post-decrement to ensure that irq_dispose_mapping is > also called on priv->rxq[0]->irq_no; moreover, if one of the above for > loops failed already at i==0 (so we reach one of these labels with > that value of i), we'll enter an

Re: [PATCH] cdc_ncm: do not call usbnet_link_change from cdc_ncm_bind

2016-03-08 Thread Ben Hutchings
On Tue, 2016-03-08 at 21:18 +0100, Bjørn Mork wrote: > Linus Torvalds writes: > > > > > So looking at this, I wonder... > > > > Why is that FLAG_LINK_INTR thing not just always used? > > > > The _only_ thing that FLAG_LINK_INTR does is to cause > > > > usbnet_link_change(dev, 0, 0); >

[RFC 5/7] wlcore: avoid fragile snprintf use

2016-03-08 Thread Rasmus Villemoes
Appending to a buffer like this is not guaranteed to work (passing overlapping src and dst buffers to snprintf is undefined behaviour). The standard and safe idiom is to keep track of the current string length. Signed-off-by: Rasmus Villemoes --- drivers/net/wireless/ti/wlcore/boot.c | 12 ++

Re: [net-next:master 1077/1082] net/core/filter.c:1824:2: error: implicit declaration of function 'ip_tunnel_info_opts_get'

2016-03-08 Thread Daniel Borkmann
On 03/08/2016 09:20 PM, kbuild test robot wrote: tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: f8b33d8e870758ccff13e5f81fd5050b52a42d35 commit: 14ca0751c96f8d3d0f52e8ed3b3236f8b34d3460 [1077/1082] bpf: support for access to tunnel options config: x86_

Re: [PATCH v2 net-next 0/12] bpf: map pre-alloc

2016-03-08 Thread David Miller
From: Alexei Starovoitov Date: Mon, 7 Mar 2016 21:57:12 -0800 > v1->v2: > . fix few issues spotted by Daniel > . converted stackmap into pre-allocation as well > . added a workaround for lockdep false positive > . added pcpu_freelist_populate to be used by hashmap and stackmap > > this path set

Re: [RFC PATCH net-next v2] tcp: Add RFC4898 tcpEStatsPerfDataSegsOut/In

2016-03-08 Thread David Miller
From: Marcelo Ricardo Leitner Date: Tue, 8 Mar 2016 16:41:54 -0300 > On Mon, Mar 07, 2016 at 06:01:05PM -0800, Martin KaFai Lau wrote: >> v2: >> Rework based on recent fix by Eric: >> commit a9d99ce28ed3 ("tcp: fix tcpi_segs_in after connection establishment") >> >> v1: > > Patch itself looks g

Re: [PATCH] cdc_ncm: do not call usbnet_link_change from cdc_ncm_bind

2016-03-08 Thread Oliver Neukum
On Tue, 2016-03-08 at 21:18 +0100, Bjørn Mork wrote: > > Why is it called "FLAG_LINK_INTR" anyway? There doesn't seem to be > > anything "INTR" about it. > > Beats me. I can only say that I always find naming difficult... > We could ask Ben, who introduced it in: It used to be done over USB inte

[net-next:master 1077/1082] net/core/filter.c:1824:2: error: implicit declaration of function 'ip_tunnel_info_opts_get'

2016-03-08 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: f8b33d8e870758ccff13e5f81fd5050b52a42d35 commit: 14ca0751c96f8d3d0f52e8ed3b3236f8b34d3460 [1077/1082] bpf: support for access to tunnel options config: x86_64-randconfig-i0-03080544 (attached as .config) rep

[PATCH net] macvtap: always pass ethernet header in linear

2016-03-08 Thread Willem de Bruijn
From: Willem de Bruijn The stack expects link layer headers in the skb linear section. Macvtap can create skbs with llheader in frags in edge cases: when (IFF_VNET_HDR is off or vnet_hdr.hdr_len < ETH_HLEN) and prepad + len > PAGE_SIZE and vnet_hdr.flags has no or bad csum. Add checks to ensure

Re: [PATCH] cdc_ncm: do not call usbnet_link_change from cdc_ncm_bind

2016-03-08 Thread Bjørn Mork
Linus Torvalds writes: > So looking at this, I wonder... > > Why is that FLAG_LINK_INTR thing not just always used? > > The _only_ thing that FLAG_LINK_INTR does is to cause > > usbnet_link_change(dev, 0, 0); > > to be called after network device attach. That doesn't seem to be > controv

Re: [PATCH net-next v2 0/3] ipv6: per netns FIB6 walkers and garbage collector

2016-03-08 Thread David Miller
From: Michal Kubecek Date: Tue, 8 Mar 2016 14:44:15 +0100 (CET) > Commit 2ac3ac8f86f2 ("ipv6: prevent fib6_run_gc() contention") reduced > the risk of contention on FIB6 garbage collector lock on systems with > many CPUs. However, one of our customers can still observe heavy > contention on fib6

Re: [PATCH] cdc_ncm: do not call usbnet_link_change from cdc_ncm_bind

2016-03-08 Thread Oliver Neukum
On Tue, 2016-03-08 at 11:43 -0800, Linus Torvalds wrote: > Why is that FLAG_LINK_INTR thing not just always used? > > The _only_ thing that FLAG_LINK_INTR does is to cause > > usbnet_link_change(dev, 0, 0); > > to be called after network device attach. That doesn't seem to be > controver

Re: [PATCH 01/11] rxrpc: Add a common object cache

2016-03-08 Thread David Miller
From: David Howells Date: Tue, 08 Mar 2016 13:02:28 + > David Howells wrote: > >> Does it make sense to maintain a FIFO list of connections (though this would >> mean potentially taking a spinlock every time I get a packet)? > > It occurs to me that only inactive connections would need to

Re: [PATCH net-next 3/3] macsec: introduce IEEE 802.1AE driver

2016-03-08 Thread Johannes Berg
On Mon, 2016-03-07 at 18:12 +0100, Sabrina Dubroca wrote: >  > +struct gcm_iv { > + union { > + u8 secure_channel_id[8]; > + sci_t sci; > + }; > + __be32 pn; > +}; Should this be __packed? But the struct is confusing; sci_t is a host type (that depends on endia

Re: [PATCH 01/11] rxrpc: Add a common object cache

2016-03-08 Thread David Miller
From: David Howells Date: Tue, 08 Mar 2016 11:39:57 + > One could argue, I suppose, that things should've been arranged that the RxRPC > client would manage the lifetime of each connection it sets up, rather than > both ends letting it lapse by mutual loss of interest. But you *still* have

Re: [PATCH net v2] sctp: fix copying more bytes than expected in sctp_add_bind_addr

2016-03-08 Thread David Miller
From: Marcelo Ricardo Leitner Date: Tue, 8 Mar 2016 10:34:28 -0300 > Dmitry reported that sctp_add_bind_addr may read more bytes than > expected in case the parameter is a IPv4 addr supplied by the user > through calls such as sctp_bindx_add(), because it always copies > sizeof(union sctp_addr)

Re: [PATCH net-next 1/3] uapi: add MACsec bits

2016-03-08 Thread Johannes Berg
On Mon, 2016-03-07 at 18:12 +0100, Sabrina Dubroca wrote: > +++ b/include/uapi/linux/if_macsec.h Some bits of documentation in this file, regarding all the various operations and attributes, might be nice. At least the netlink types? E.g., given this: > +#define DEFAULT_CIPHER_NAME "GCM-AES-128

Re: [PATCH v2 net-next 0/8] bnxt_en: Updates for net-next.

2016-03-08 Thread David Miller
From: Michael Chan Date: Mon, 7 Mar 2016 15:38:40 -0500 > Updates to support autoneg for all supported speeds, add PF port statistics, > and Advanced Error Reporting. > > v2: Fixed patch 3 to not use parentheses on function return. Series applied, thanks Michael.

Re: Tool for sampling /proc/net/softnet_stat statistics

2016-03-08 Thread David Miller
From: Jesper Dangaard Brouer Date: Mon, 7 Mar 2016 16:36:07 +0100 > I lack of better, I coded up my own tool softnet_stat.pl here: > > https://github.com/netoptimizer/network-testing/blob/master/bin/softnet_stat.pl > > The output format/columns in /proc/net/softnet_stat is undocumented, > plus

Re: [PATCH] cdc_ncm: do not call usbnet_link_change from cdc_ncm_bind

2016-03-08 Thread Linus Torvalds
On Mon, Mar 7, 2016 at 12:15 PM, Bjørn Mork wrote: > usbnet_link_change will call schedule_work and should be > avoided if bind is failing. Otherwise we will end up with > scheduled work referring to a netdev which has gone away. > > Instead of making the call conditional, we can just defer > it t

Re: [RFC PATCH net-next v2] tcp: Add RFC4898 tcpEStatsPerfDataSegsOut/In

2016-03-08 Thread Marcelo Ricardo Leitner
On Mon, Mar 07, 2016 at 06:01:05PM -0800, Martin KaFai Lau wrote: > v2: > Rework based on recent fix by Eric: > commit a9d99ce28ed3 ("tcp: fix tcpi_segs_in after connection establishment") > > v1: Patch itself looks good to me, just this patch history is better placed on the Notes region (togethe

Re: [PATCH net-next v3] net_sched: dsmark: use qdisc_dequeue_peeked()

2016-03-08 Thread David Miller
From: Kyeong Yoo Date: Mon, 07 Mar 2016 17:07:57 +1300 > This fix is for dsmark similar to commit 3557619f0f6f7496ed453d4825e249 > ("net_sched: prio: use qdisc_dequeue_peeked") > and makes use of qdisc_dequeue_peeked() instead of direct dequeue() call. > > First time, wrr peeks dsmark, which wil

Re: [PATCH 00/10] Netfilter/IPVS updates for net-next

2016-03-08 Thread David Miller
From: Pablo Neira Ayuso Date: Tue, 8 Mar 2016 11:00:40 +0100 > The following patchset contains Netfilter updates for your net-next tree, > they are: > > 1) Remove useless debug message when deleting IPVS service, from >Yannick Brosseau. > > 2) Get rid of compilation warning when CONFIG_PRO

Re: [net-next PATCH 2/7] mlx4: use napi_consume_skb API to get bulk free operations

2016-03-08 Thread David Miller
From: Jesper Dangaard Brouer Date: Fri, 04 Mar 2016 14:01:33 +0100 > @@ -276,7 +276,8 @@ static void mlx4_en_stamp_wqe(struct mlx4_en_priv *priv, > > static u32 mlx4_en_free_tx_desc(struct mlx4_en_priv *priv, > struct mlx4_en_tx_ring *ring, > -

Re: [PATCH net-next 0/7] BPF updates

2016-03-08 Thread Daniel Borkmann
On 03/08/2016 08:05 PM, David Miller wrote: From: Daniel Borkmann Date: Fri, 4 Mar 2016 15:15:01 +0100 Couple of misc updates to BPF, besides others this series adds bpf_csum_diff() to be used with L3 csums, allows for managing tunnel options for collect meta data mode, and enabling ipv6 traf

[PATCH net] ppp: ensure file->private_data can't be overridden

2016-03-08 Thread Guillaume Nault
Lock ppp_mutex and check that file->private_data is NULL before executing any action in ppp_unattached_ioctl(). The test done by ppp_ioctl() can't be relied upon, because file->private_data may have been updated meanwhile. In which case ppp_unattached_ioctl() will override file->private_data and me

Re: [PATCH net-next 0/7] BPF updates

2016-03-08 Thread David Miller
From: Daniel Borkmann Date: Fri, 4 Mar 2016 15:15:01 +0100 > Couple of misc updates to BPF, besides others this series adds > bpf_csum_diff() to be used with L3 csums, allows for managing > tunnel options for collect meta data mode, and enabling ipv6 > traffic class for collect meta data in vxla

Re: [PATCH next 3/3] net: Use l3_dev instead of skb->dev for L3 processing

2016-03-08 Thread Mahesh Bandewar
On Mon, Mar 7, 2016 at 9:37 PM, Cong Wang wrote: > On Fri, Mar 4, 2016 at 2:12 PM, Mahesh Bandewar wrote: >> >> Unfortunately we don't have a way to switch to ns after L3 processing. > > I am totally aware of this, this is exactly why I said this might not be easy. > > The question is how hard it

Re: [PATCH net-next v2 3/3] ipv6: per netns FIB garbage collection

2016-03-08 Thread Cong Wang
On Tue, Mar 8, 2016 at 5:44 AM, Michal Kubecek wrote: > One of our customers observed issues with FIB6 garbage collectors > running in different network namespaces blocking each other, resulting > in soft lockups (fib6_run_gc() initiated from timer runs always in > forced mode). > > Now that FIB6

Re: [PATCH net-next v2 2/3] ipv6: per netns fib6 walkers

2016-03-08 Thread Cong Wang
On Tue, Mar 8, 2016 at 5:44 AM, Michal Kubecek wrote: > The IPv6 FIB data structures are separated per network namespace but > there is still only one global walkers list and one global walker list > lock. This means changes in one namespace unnecessarily interfere with > walkers in other namespac

Re: [PATCH net-next v2 1/3] ipv6: replace global gc_args with local variable

2016-03-08 Thread Cong Wang
On Tue, Mar 8, 2016 at 5:44 AM, Michal Kubecek wrote: > Global variable gc_args is only used in fib6_run_gc() and functions > called from it. As fib6_run_gc() makes sure there is at most one > instance of fib6_clean_all() running at any moment, we can replace > gc_args with a local variable which

[4.5-rc7+ regression, bisected] libphy: PHY stmmac-0:ffffffff not found

2016-03-08 Thread Frank Schäfer
commit 88f8b1bb41c6208f81b6a480244533ded7b59493 Author: Gabriel Fernandez Date: Mon Feb 29 17:18:22 2016 +0100 stmmac: Fix 'eth0: No PHY found' regression This patch manages the case when you have an Ethernet MAC with a "fixed link", and not connected to a normal MDIO-managed PH

Re: [PATCH/RFC v6 net-next] ravb: Add dma queue interrupt support

2016-03-08 Thread Yoshihiro Kaneko
Hi Sergei-san, 2016-02-29 0:41 GMT+09:00 Yoshihiro Kaneko : [snip] > +static bool ravb_timestamp_interrupt(struct net_device *ndev, u32 tis) > +{ I'd like to read TIS here like ravb_queue_interrupt(). > + if (tis & TIS_TFUF) { > + ravb_write(ndev, ~TIS_TFUF, TIS); > +

Re: [PATCH v2] can: rcar_canfd: Add Renesas R-Car CAN FD driver

2016-03-08 Thread Oliver Hartkopp
On 03/08/2016 01:48 PM, Ramesh Shanmugasundaram wrote: >> In fact you provided a CAN driver which is "CAN-FD-only". > > Yes. That's the status of current submission. > >> We did not had that before but there's a solution for this kind of setup. >> >> There is a similar case with CAN_CTRLMODE_FD_

Re: [PATCH v5 net-next] net: Implement fast csum_partial for x86_64

2016-03-08 Thread Tom Herbert
On Mon, Mar 7, 2016 at 5:39 PM, Linus Torvalds wrote: > On Mon, Mar 7, 2016 at 4:07 PM, Tom Herbert wrote: >> >> As I said previously, if alignment really is a factor then we can >> check up front if a buffer crosses a page boundary and call the slow >> path function (original code). I'm seeing a

Re: linux-next: manual merge of the crypto tree with the net-next tree

2016-03-08 Thread David Howells
Stephen Rothwell wrote: > > What's the best way to deal with this? Should I take Herbert's > > > > [PATCH 18/26] rxrpc: Use skcipher > > > > patch into my rxrpc tree also and pass it on to Dave? > > Linus can deal with it when he merges the latter of the crypto or > net-next trees. It mi

Re: [PATCH v2 net-next 0/12] bpf: map pre-alloc

2016-03-08 Thread Alexei Starovoitov
On 3/8/16 1:13 AM, Daniel Wagner wrote: Some time back Daniel Wagner reported crashes when bpf hash map is >used to compute time intervals between preempt_disable->preempt_enable >and recently Tom Zanussi reported a dead lock in iovisor/bcc/funccount >tool if it's used to count the number of invo

[PATCH rdma-next V2 01/10] net/core: Add support for configuring VF GUIDs

2016-03-08 Thread Eli Cohen
Add two new NLAs to support configuration of Infiniband node or port GUIDs. New applications can choose to use this interface to configure GUIDs with iproute2 with commands such as: ip link set dev ib0 vf 0 node_guid 00:02:c9:03:00:21:6e:70 ip link set dev ib0 vf 0 port_guid 00:02:c9:03:00:21:6e:7

Re: [PATCH v3 0/8] arm64: rockchip: Initial GeekBox enablement

2016-03-08 Thread Dinh Nguyen
On Tue, Mar 8, 2016 at 1:24 AM, Giuseppe CAVALLARO wrote: > Hi Dinh, > > On 3/8/2016 12:22 AM, Dinh Nguyen wrote: > [snip] >> >> >> I'm seeing the same issue on the SoCFPGA platform: >> >> libphy: PHY stmmac-0: not found >> eth0: Could not attach to PHY >> stmmac_open: Cannot attach to PHY

[PATCH net-next 3/4] ldmvsw: Add ldmvsw.c driver code

2016-03-08 Thread Aaron Young
Add ldmvsw.c driver Details: The ldmvsw driver very closely follows the sunvnet.c code and makes use of the sunvnet_common.c code for core functionality. A significant difference between sunvnet and ldmvsw driver is sunvnet creates a network interface for each vnet-port *parent* no

[PATCH net-next 1/4] ldmvsw: Split sunvnet driver into common code

2016-03-08 Thread Aaron Young
Split sunvnet.c into sunvnet.c and sunvnet_common.c. Details: Since the sunvnet and ldmvsw drivers will both use common sunvnet code, move the functions (and support functions) anticipated to be common code from sunvnet.c to sunvnet_common.c. Similarly, sunvnet.h was renamed to sunvne

[PATCH net-next 4/4] ldmvsw: Checkpatch sunvnet.c and sunvnet_common.c

2016-03-08 Thread Aaron Young
Checkpatch updates for sunvnet.c and sunvnet_common.c. Signed-off-by: Aaron Young Signed-off-by: Rashmi Narasimhan Reviewed-by: Sowmini Varadhan Reviewed-by: Alexandre Chartre --- drivers/net/ethernet/sun/sunvnet.c|4 +- drivers/net/ethernet/sun/sunvnet_common.c | 100 +

  1   2   >