在 2016年01月06日 15:35, zhuyj 写道:
IMHO, "The path MTU is set to the active slave device, not the bonding
master."
Can we set PMTU to bonding master when path MTU is set to the active
slave device?
Actually the route is set on bonding master, not on any slave, the
trying to set PMTU to the acti
IMHO, "The path MTU is set to the active slave device, not the bonding
master."
Can we set PMTU to bonding master when path MTU is set to the active
slave device?
If not appropriate, you can ignore it.
Best Regards!
Zhu Yanjun
On 01/06/2016 03:06 PM, Wengang Wang wrote:
Hi Yanjun,
Thanks fo
Hmm, we are not changing device MTU but PMTU...
thanks,
wengang
在 2016年01月06日 14:44, zhuyj 写道:
IMHO, the following comments will help us all.
case NETDEV_CHANGEMTU:
/* TODO: Should slaves be allowed to
* independently alter their MTU? For
Hi Yanjun,
Thanks for your review.
Master MTU is same as that for slaves.
Maybe fixing in bonding driver is a good idea, but I don't find a good
place to do that.
Let's go through the simplified follow:
...
1) Fragmentation.
--This is is done is against the bonding master device(device MTU
Hi Joao,
> For platform drivers to be able to correctly drive the "Airplane Mode"
> indicative LED there needs to be a RFKill LED trigger tied to the global
> state of RFKILL_TYPE_ALL (instead of to a specific RFKill) and that
> works in an inverted manner of regular RFKill LED triggers, that is,
Hi Insu,
> if addr_len < sizeof(sa), sa.rc_bdaddr(4bytes) can be leaked
> by using rfcomm_sock_getname()
>
> Signed-off-by: Insu Yun
> ---
> net/bluetooth/rfcomm/sock.c | 9 +
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/net/bluetooth/rfcomm/sock.c b/net/bluetooth/
IMHO, the following comments will help us all.
case NETDEV_CHANGEMTU:
/* TODO: Should slaves be allowed to
* independently alter their MTU? For
* an active-backup bond, slaves need
* not be the same type of device, so
From: Eric Dumazet
Date: Tue, 05 Jan 2016 19:07:49 -0800
> On Tue, 2016-01-05 at 18:49 -0800, Cong Wang wrote:
>> On Tue, Jan 5, 2016 at 9:44 AM, Eric Dumazet wrote:
>> > On Tue, 2016-01-05 at 09:11 -0800, John Fastabend wrote:
>> >> When a qdisc is using per cpu stats (currently just the ingres
From: Rabin Vincent
Date: Tue, 5 Jan 2016 18:34:04 +0100
> The LSR instruction cannot be used to perform a zero right shift since a
> 0 as the immediate value (imm5) in the LSR instruction encoding means
> that a shift of 32 is perfomed. See DecodeIMMShift() in the ARM ARM.
>
> Make the JIT sk
From: Craig Gallek
Date: Tue, 5 Jan 2016 10:57:13 -0500
> From: Craig Gallek
>
> Fixes: 538950a1b752 ("soreuseport: setsockopt SO_ATTACH_REUSEPORT_[CE]BPF")
> Suggested-by: Daniel Borkmann
> Signed-off-by: Craig Gallek
Also applied, thanks again Craig.
--
To unsubscribe from this list: send
在 2016年01月06日 14:18, David Miller 写道:
From: Wengang Wang
Date: Wed, 6 Jan 2016 13:49:28 +0800
@@ -523,11 +523,20 @@ static void build_skb_flow_key(struct flowi4 *fl4, const
struct sk_buff *skb,
const struct sock *sk)
{
const struct iphdr *iph = ip_h
From: Craig Gallek
Date: Tue, 5 Jan 2016 15:08:07 -0500
> From: Craig Gallek
>
> This socket-lookup path did not pass along the skb in question
> in my original BPF-based socket selection patch. The skb in the
> udpN_lib_lookup2 path can be used for BPF-based socket selection just
> like it i
From: Alan
Date: Tue, 05 Jan 2016 11:51:25 +
> commit acf673a3187edf72068ee2f92f4dc47d66baed47 fixed a user triggerable free
> memory scribble but in doing so replaced it with a different one that allows
> the user to control the data and scribble even more.
>
> sixpack_close is called by th
On Fri, Jan 1, 2016 at 4:52 AM, SF Markus Elfring
wrote:
> From: Markus Elfring
> Date: Fri, 1 Jan 2016 00:11:57 +0100
>
> Remove two checks for null pointers which would be handled by usual
> error detection before.
>
> Signed-off-by: Markus Elfring
Acked-by: Sathya Perla
This patch is suita
From: Jarod Wilson
Date: Tue, 5 Jan 2016 18:12:34 -0500
> - if ((raw_mtu + 8) < ALX_TXQ1_JUMBO_TSO_TH)
> - val = (raw_mtu + 8 + 7) >> 3;
> + if ((raw_mtu) < ALX_TXQ1_JUMBO_TSO_TH)
> + val = (raw_mtu + 7) >> 3;
The parenthesis around 'raw_mtu' is superfluous, plea
IMHO, this should fix in bonding driver because the active slave mtu
should be the same with the master.
bonding master's mtu is changed to path MTU, then slave dev's MTU should
be changed, too.
Zhu Yanjun
On 01/06/2016 01:49 PM, Wengang Wang wrote:
A problem is found that we are looking for
From: Wengang Wang
Date: Wed, 6 Jan 2016 13:49:28 +0800
> @@ -523,11 +523,20 @@ static void build_skb_flow_key(struct flowi4 *fl4,
> const struct sk_buff *skb,
> const struct sock *sk)
> {
> const struct iphdr *iph = ip_hdr(skb);
> - int oif = skb->dev->i
From: Jiri Pirko
Date: Tue, 5 Jan 2016 11:36:40 +0100
> From: Ido Schimmel
>
> During initialization, when creating the send descriptor queues (SDQs),
> we specify the CPU egress traffic class of each SDQ. The maximum number
> of classes of this type is different in the two ASICs supported by
A problem is found that we are looking for route basing a bonding device and
deal with path MTU there: The path MTU is set to the active slave device, not
the bonding master.
The patch tries to fix the issue by letting build_skb_flow_key() take care
of the transition of device index from bonding s
From: Rabin Vincent
Date: Tue, 5 Jan 2016 16:23:07 +0100
> The SKF_AD_ALU_XOR_X ancillary is not like the other ancillary data
> instructions since it XORs A with X while all the others replace A with
> some loaded value. All the BPF JITs fail to clear A if this is used as
> the first instructi
On 12/31/2015 12:37 AM, Tantilov, Emil S wrote:
-Original Message-
From: zhuyj [mailto:zyjzyj2...@gmail.com]
Sent: Wednesday, December 30, 2015 12:20 AM
To: Tantilov, Emil S; Kirsher, Jeffrey T; Brandeburg, Jesse; Nelson,
Shannon; Wyborny, Carolyn; Skidmore, Donald C; Allan, Bruce W; Ronc
> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
> Sent: Tuesday, January 5, 2016 17:52
>
> Just some minor nitpicks below -- I have to admit I didn't test the feature.
>
> [..skip..]
>
> > +
> > + if (sk->sk_err) {
> > + ret = -sk->sk_err;
> > + goto out_wait_error;
>
From: Kalle Valo
Date: Tue, 05 Jan 2016 12:28:36 +0200
> here's a big pull request for 4.5, which I should have sent to you
> earlier but instead I was wasting my time with eating way too much
> chocolate and keeping my brains in low power mode :)
>
> Once again 'git request-pull' got diffstat w
From: Arnd Bergmann
Date: Fri, 01 Jan 2016 23:27:57 +0100
> gcc fails to see that the use of the 'last_offset' variable
> in hns_nic_reuse_page() is used correctly and issues a bogus
> warning:
>
> drivers/net/ethernet/hisilicon/hns/hns_enet.c: In function
> 'hns_nic_reuse_page':
> drivers/net/
From: Saeed Mahameed
Date: Tue, 5 Jan 2016 22:04:02 +0200
> - /* Add node to tree */
> - tree_init_node(&fg->node, 1, del_flow_group);
Why in the world would you take a properly formatted comment:
> + /*Add node to tree*/
And proceed to molest it like this?
Please don't do this.
On 01/05/2016 11:18 AM, Yang Zhang wrote:
> On 2016/1/4 14:22, Jason Wang wrote:
>>
>>
>> On 01/04/2016 09:39 AM, Yang Zhang wrote:
>>> On 2015/12/31 15:13, Jason Wang wrote:
This patch tries to implement an device IOTLB for vhost. This could be
used with for co-operation with userspace
if addr_len < sizeof(sa), sa.rc_bdaddr(4bytes) can be leaked
by using rfcomm_sock_getname()
Signed-off-by: Insu Yun
---
net/bluetooth/rfcomm/sock.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/net/bluetooth/rfcomm/sock.c b/net/bluetooth/rfcomm/sock.c
index 7511df
From: Florian Westphal
Date: Tue, 5 Jan 2016 22:17:55 +0100
> The only user was removed in commit
> 029f7f3b8701cc7a ("netfilter: ipv6: nf_defrag: avoid/free clone operations").
>
> Signed-off-by: Florian Westphal
Thanks for noticing this, applied, thanks Florian.
--
To unsubscribe from this
On Wed, 2016-01-06 at 00:35 +0100, Hannes Frederic Sowa wrote:
>
> Tom, did you have a look if it makes sense to add a second carry
> addition train with the adcx instruction, which does not signal carry
> via the carry flag but with the overflow flag? This instruction should
> not have any de
On Tue, 2016-01-05 at 18:49 -0800, Cong Wang wrote:
> On Tue, Jan 5, 2016 at 9:44 AM, Eric Dumazet wrote:
> > On Tue, 2016-01-05 at 09:11 -0800, John Fastabend wrote:
> >> When a qdisc is using per cpu stats (currently just the ingress
> >> qdisc) only the bstats are being freed. This also free's
On 01/06/2016 09:26 AM, Tantilov, Emil S wrote:
-Original Message-
From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On
Behalf Of zhuyj
Sent: Monday, December 28, 2015 1:19 AM
To: Michal Kubecek; Jay Vosburgh
Cc: vfal...@gmail.com; go...@cumulusnetworks.com; netdev@
On Tue, 2016-01-05 at 17:10 -0800, H. Peter Anvin wrote:
> Apparently "adcq.d8" will do The Right Thing for this.
Nice trick ;)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.o
On Tue, Jan 5, 2016 at 9:44 AM, Eric Dumazet wrote:
> On Tue, 2016-01-05 at 09:11 -0800, John Fastabend wrote:
>> When a qdisc is using per cpu stats (currently just the ingress
>> qdisc) only the bstats are being freed. This also free's the qstats.
>>
>> Signed-off-by: John Fastabend
>> ---
>
>
On Tue, Jan 5, 2016 at 5:00 PM, Daniel Borkmann wrote:
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index c20b814..752c0d2 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -1739,7 +1739,9 @@ struct net_device {
> #ifdef CONFIG_XPS
>
Hi, Yoshifuji-san.
Thanks for your kindly check.
I will correct it in Patch v2.
Best Regards,
Yuki Machida
On 2016年01月05日 19:17, YOSHIFUJI Hideaki wrote:
> Hi, Machida-san.
>
> Yuki Machida wrote:
>> Please apply the following patch to v4.1.x.
>>
>> By ommit 6fd99094de2b ("ipv6: Don't reduce ho
Hello Johannes,
On 26 December 2015 at 10:05, João Paulo Rechi Vita wrote:
> For platform drivers to be able to correctly drive the "Airplane Mode"
> indicative LED there needs to be a RFKill LED trigger tied to the global
> state of RFKILL_TYPE_ALL (instead of to a specific RFKill) and that
> wo
>-Original Message-
>From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On
>Behalf Of zhuyj
>Sent: Monday, December 28, 2015 1:19 AM
>To: Michal Kubecek; Jay Vosburgh
>Cc: vfal...@gmail.com; go...@cumulusnetworks.com; netdev@vger.kernel.org;
>Shteinbock, Boris (Wind Ri
On 01/05/2016 02:18 PM, Eric Dumazet wrote:
> On Tue, 2016-01-05 at 10:41 -0800, Tom Herbert wrote:
>> Implement assembly routine for csum_partial for 64 bit x86. This
>> primarily speeds up checksum calculation for smaller lengths such as
>> those that are present when doing skb_postpull_rcsum whe
This work adds a generalization of the ingress qdisc as a qdisc holding
only classifiers. The clsact qdisc works on ingress, but also on egress.
In both cases, it's execution happens without taking the qdisc lock, and
the main difference for the egress part compared to prior version of [1]
is that
在 2016/1/2 6:27, Arnd Bergmann 写道:
> gcc fails to see that the use of the 'last_offset' variable
> in hns_nic_reuse_page() is used correctly and issues a bogus
> warning:
>
> drivers/net/ethernet/hisilicon/hns/hns_enet.c: In function
> 'hns_nic_reuse_page':
> drivers/net/ethernet/hisilicon/hns/
Gilad Avidov wrote:
diff --git a/drivers/net/ethernet/qualcomm/emac/emac-mac.c
b/drivers/net/ethernet/qualcomm/emac/emac-mac.c
new file mode 100644
index 000..36a7746
--- /dev/null
+++ b/drivers/net/ethernet/qualcomm/emac/emac-mac.c
@@ -0,0 +1,1808 @@
+/* Copyright (c) 2013-2015, The Linux
On Tue, 2016-01-05 at 17:56 -0500, Craig Gallek wrote:
> On Tue, Jan 5, 2016 at 5:33 PM, Eric Dumazet wrote:
> > From: Eric Dumazet
> > + unsigned short hnum = ntohs(req->id.idiag_dport);
> > + unsigned int slot = udp_hashfn(net, hnum, tbl->mask);
> > + struct udp_hslot *hslot =
Hi,
On 05.01.2016 19:41, Tom Herbert wrote:
Implement assembly routine for csum_partial for 64 bit x86. This
primarily speeds up checksum calculation for smaller lengths such as
those that are present when doing skb_postpull_rcsum when getting
CHECKSUM_COMPLETE from device or after CHECKSUM_UNNE
This is based on the work done by Przemek Rudy in bug 70761 at
bugzilla.kernel.org, but with some work done to disentagle and clarify
things a bit.
Similar to Przemek's work and other drivers, we're adding a padding of 16
here, but we're also disentangling mtu size calculations from max buffer
siz
On Tue, Jan 5, 2016 at 5:33 PM, Eric Dumazet wrote:
> From: Eric Dumazet
> + unsigned short hnum = ntohs(req->id.idiag_dport);
> + unsigned int slot = udp_hashfn(net, hnum, tbl->mask);
> + struct udp_hslot *hslot = &tbl->hash[slot];
> + struct hlist_nulls_node *node;
> +
On Tue, 2016-01-05 at 17:26 -0500, Craig Gallek wrote:
> Thanks Eric! Still reading through this, but I noticed a couple other
> paths as well. Anything that comes through the exported
> udp4_lib_lookup. Currently xt_TPROXY.c and xt_socket.c. Though,
> these could probably be changed to pass th
From: Eric Dumazet
udp_dump_one() uses __udp4_lib_lookup() & __udp6_lib_lookup()
which cannot properly handle the provided cookie when SO_REUSEPORT
is used, as many sockets share the same 4-tuple
Instead, let's use the provided 64bit cookie to uniquely identify
the socket.
This will allow us to
When running certain routing protocols like VRRP, VF guests need the
ability to set the unicast address of the interface. Extend the new ndo
trust feature to let the hypervisor trust a guest to set/update its own
unicast address.
Signed-off-by: Chas Williams <3ch...@gmail.com>
---
drivers/net/et
On Tue, Jan 5, 2016 at 5:22 PM, Eric Dumazet wrote:
> On Tue, 2016-01-05 at 14:08 -0800, Eric Dumazet wrote:
>> From: Eric Dumazet
>>
>> udp_dump_one() uses __udp4_lib_lookup() & __udp6_lib_lookup()
>> which cannot properly handle the provided cookie when SO_REUSEPORT
>> is used, as many sockets
On Tue, 2016-01-05 at 14:08 -0800, Eric Dumazet wrote:
> From: Eric Dumazet
>
> udp_dump_one() uses __udp4_lib_lookup() & __udp6_lib_lookup()
> which cannot properly handle the provided cookie when SO_REUSEPORT
> is used, as many sockets share the same 4-tuple
>
> Instead, let's use the provided
On Tue, 2016-01-05 at 10:41 -0800, Tom Herbert wrote:
> Implement assembly routine for csum_partial for 64 bit x86. This
> primarily speeds up checksum calculation for smaller lengths such as
> those that are present when doing skb_postpull_rcsum when getting
> CHECKSUM_COMPLETE from device or afte
From: Eric Dumazet
udp_dump_one() uses __udp4_lib_lookup() & __udp6_lib_lookup()
which cannot properly handle the provided cookie when SO_REUSEPORT
is used, as many sockets share the same 4-tuple
Instead, let's use the provided 64bit cookie to uniquely identify
the socket.
This will allow us to
On Tue, 2016-01-05 at 15:08 -0500, Craig Gallek wrote:
> From: Craig Gallek
>
> This socket-lookup path did not pass along the skb in question
> in my original BPF-based socket selection patch. The skb in the
> udpN_lib_lookup2 path can be used for BPF-based socket selection just
> like it is in
From: Richard Alpe
Date: Tue, 5 Jan 2016 10:56:16 +0100
> Make the c files less cluttered and enable netlink attributes to be
> shared between files. This will prove useful in a future patch where a
> node message will contain a nested network.
>
> Signed-off-by: Richard Alpe
> Acked-by: Jon Ma
From: Heinrich Schuchardt
Date: Tue, 5 Jan 2016 10:12:49 +0100
> IOCTL SIOCRTMSG does nothing but return EINVAL.
>
> So comment it as unused.
>
> SIOCRTMSG is only used in:
> * net/ipv4/af_inet.c
> * include/uapi/linux/sockios.h
>
> inet_ioctl calls ip_rt_ioctl.
> ip_rt_ioctl only handles SIO
From: Arnd Bergmann
Date: Fri, 01 Jan 2016 23:27:57 +0100
> gcc fails to see that the use of the 'last_offset' variable
> in hns_nic_reuse_page() is used correctly and issues a bogus
> warning:
>
> drivers/net/ethernet/hisilicon/hns/hns_enet.c: In function
> 'hns_nic_reuse_page':
> drivers/net/
The only user was removed in commit
029f7f3b8701cc7a ("netfilter: ipv6: nf_defrag: avoid/free clone operations").
Signed-off-by: Florian Westphal
---
include/net/inet_frag.h | 1 -
net/ieee802154/6lowpan/reassembly.c | 1 -
net/ipv4/inet_fragment.c| 10 +-
net/i
On Tue, 2016-01-05 at 16:01 -0500, Joseph Salisbury wrote:
> Hello,
>
> Please consider including mainline commit
> 50a9eea694ab8e0779069e0a4e0b12e145521468 in the next v4.2.y-ckt
> release. It was
> included in the mainline tree as of v4.4-rc2. It has been tested and
> confirmed to resolve:
> h
Hello,
Please consider including mainline commit
50a9eea694ab8e0779069e0a4e0b12e145521468 in the next v4.2.y-ckt
release. It was
included in the mainline tree as of v4.4-rc2. It has been tested and
confirmed to resolve:
http://bugs.launchpad.net/bugs/1528466
commit 50a9eea694ab8e0779069e0a4e0b1
Hi Or,
On Tue, 5 Jan 2016 19:05:24 +0200 Or Gerlitz wrote:
>
> On 1/5/2016 3:51 AM, Stephen Rothwell wrote:
> > Hi Doug,
> >
> > Today's linux-next merge of the rdma tree got conflicts in:
> >
> >drivers/net/ethernet/mellanox/mlx5/core/vport.c
> >include/linux/mlx5/mlx5_ifc.h
> >inclu
From: Craig Gallek
This socket-lookup path did not pass along the skb in question
in my original BPF-based socket selection patch. The skb in the
udpN_lib_lookup2 path can be used for BPF-based socket selection just
like it is in the 'traditional' udpN_lib_lookup path.
udpN_lib_lookup2 kicks in
From: Maor Gottlieb
Add two utility functions for find next and prev flow table.
Find next flow table function gets priority and return the
first flow table of the next priority in the tree.
Find prev flow table return the last flow table of
the previous priority in the tree.
These utility funct
Hi Dave,
This series adds three new functionalists to the driver flow-steering
infrastructure:
auto-grouped flow tables, chaining of flow tables and updates for the
root flow table.
1. Auto-grouped flow tables - Flow table with auto grouping management.
When a flow table is created, hints regardi
From: Maor Gottlieb
Adding flow steering support by creating a flow-table per
priority (if rules exist in the priority).
mlx5_ib uses autogrouping and thus only creates the
required destinations.
Signed-off-by: Maor Gottlieb
Signed-off-by: Moni Shoua
Signed-off-by: Matan Barak
Signed-off-by:
From: Maor Gottlieb
Add three utility functions for support flow steering:
1. Parsing verbs flow attributes hardware steering specs.
2. Check if flow is multicast - this is required in order to decide to
which flow table will we add the steering rule.
3. Set outer headers in flow match criteri
From: Maor Gottlieb
Introduce the modify flow table command. This command is used when
we want to change the next flow table of an existing flow table.
The next flow table is defined as the table we search (in order
to find a match), if we couldn't find a match in any of the flow table
entries in
From: Maor Gottlieb
Change the mlx5 firmware interface header to make it
more clear which bytes should be used by IPv4 or
IPv6 addresses.
Signed-off-by: Maor Gottlieb
Signed-off-by: Moni Shoua
Signed-off-by: Matan Barak
Signed-off-by: Saeed Mahameed
---
include/linux/mlx5/mlx5_ifc.h | 20
From: Maor Gottlieb
When user add rule to autogrouped flow table, we search
for flow group with the same match criteria, if we don't
find such group then we create new flow group with the
required match criteria and insert the rule to this group.
We divide the flow table into required_groups + 1
From: Maor Gottlieb
Flow tables from different priorities should be chained together.
When a packet arrives we search for a match in the
by-pass flow tables (first we search for a match in priority 0
and if we don't find a match we move to the next priority).
If we can't find a match in any of th
From: Maor Gottlieb
The root Flow Table for each Flow Table Type is defined,
by default, as the Flow Table with level 0.
In order not to use an empty flow tables and introduce new hops,
but still preserve space for flow-tables that have a priority
greater(lower number) than the current flow tabl
From: Maor Gottlieb
Add exports to flow steering API for mlx5_ib usage.
The following functions are exported:
1. mlx5_create_auto_grouped_flow_table - used to create flow
table with auto flow grouping management (create and destroy
flow groups). In auto-grouped flow tables, we create groups
auto
From: Maor Gottlieb
Each priority has two attributes:
1. max_ft - maximum allowed flow tables under this priority.
2. start_level - start level range of the flow tables
in the priority.
These attributes are set by traversing the tree nodes by
DFS and set start level and max flow tables to each p
From: Maor Gottlieb
When the driver is loaded, we create flow steering namespace
for kernel bypass with nine priorities and another namespace
for leftovers(in order to catch packets that weren't matched).
Verbs applications will use these priorities.
we found nine as a number that balances the re
I am Mr. Wang Zhiqiang working with Wing Lung Bank Hong Kong; I have a
highly mutual and legitimate Bequest for you to handle with me. This fund
was deposited in our bank by an Oil Magnate who lived in Hong Kong for
Twenty Eight years. He died along with his family during the Tsunami which
occur
From: Maor Gottlieb
Before we create the sub tree of a steering namespaces(kernel, bypass,
leftovers) we check that the device has the required capabilities
in order to create this subtree.
Signed-off-by: Maor Gottlieb
Signed-off-by: Moni Shoua
Signed-off-by: Matan Barak
Signed-off-by: Saeed
On Tue, 2016-01-05 at 14:12 -0500, Craig Gallek wrote:
> OK, I can buy that an skb should be piped through udp4|6_lib_lookup2,
> but I don't think it's safe to remove the skb NULL check in
> reuseport_select_sock. There's at least one path (udp_diag.c:
> udp_dump_one) which does a lookup without
No. This patch is a suspend resume thing and your bug is something
else. Honestly, this patch is a static checker fix and I doubt it has
much real worl impact at all.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord..
On Tue, Jan 05, 2016 at 02:15:34PM -0500, David Miller wrote:
> From: Guillaume Nault
> Date: Tue, 5 Jan 2016 19:10:20 +0100
>
> > On Wed, Dec 23, 2015 at 09:04:46PM +0100, Guillaume Nault wrote:
> >> This series adds netlink support for creating PPP devices.
> >>
> > Any feedback on this series
From: Guillaume Nault
Date: Tue, 5 Jan 2016 19:10:20 +0100
> On Wed, Dec 23, 2015 at 09:04:46PM +0100, Guillaume Nault wrote:
>> This series adds netlink support for creating PPP devices.
>>
> Any feedback on this series? I can see that it has been marked
> "Deferred" in patchwork, so I'm unsure
Thank you David and Richard.
On Tue, Jan 5, 2016 at 9:12 PM, David Miller wrote:
> From: Saeed Mahameed
> Date: Tue, 29 Dec 2015 14:58:28 +0200
>
>> This patch series introduces the support for ConnectX-4 timestamping
>> and the PTP kernel interface.
>
> Series applied, thank you.
--
To unsubscr
From: Eric Dumazet
Date: Tue, 05 Jan 2016 09:44:11 -0800
> David, please add the following tag to ease backports to stable kernels:
>
> Fixes: 22e0f8b9322cb ("net: sched: make bstats per cpu and estimator RCU
> safe")
Ok, will do, thanks!
--
To unsubscribe from this list: send the line "unsubs
From: Saeed Mahameed
Date: Tue, 29 Dec 2015 14:58:28 +0200
> This patch series introduces the support for ConnectX-4 timestamping
> and the PTP kernel interface.
Series applied, thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@
On Tue, Jan 5, 2016 at 1:31 PM, Eric Dumazet wrote:
> On Tue, 2016-01-05 at 12:47 -0500, Craig Gallek wrote:
>> On Tue, Jan 5, 2016 at 12:38 PM, Eric Dumazet wrote:
>
>> >
>> > BTW, why UDP calls reuseport_select_sock() with hdr_len == 0 sometimes ?
>> hdr_len only matters when you have an skb to
On 12/30/2015 10:50 AM, Xin Long wrote:
> apply lookup apis to two functions, for __sctp_endpoint_lookup_assoc
> and __sctp_lookup_association, it's invoked in the protection of sock
> lock, it will be safe, but sctp_lookup_association need to call
> rcu_read_lock() and to detect the t->dead to pro
From: Richard Cochran
Date: Tue, 5 Jan 2016 13:51:18 +0100
> On Mon, Jan 04, 2016 at 04:47:03PM -0500, David Miller wrote:
>> Richard, please review this series.
>
> It looks fine to me now, and I acked the timestamping/phc bits.
Thank you.
--
To unsubscribe from this list: send the line "unsub
From: Giuseppe CAVALLARO
Date: Tue, 5 Jan 2016 10:03:28 +0100
> On 1/5/2016 4:25 AM, David Miller wrote:
>> From: Giuseppe Cavallaro
>> Date: Mon, 4 Jan 2016 14:06:46 +0100
>>
>>> @@ -376,7 +376,8 @@ extern const struct stmmac_desc_ops ndesc_ops;
>>> /* Specific DMA helpers */
>>> struct stm
Implement assembly routine for csum_partial for 64 bit x86. This
primarily speeds up checksum calculation for smaller lengths such as
those that are present when doing skb_postpull_rcsum when getting
CHECKSUM_COMPLETE from device or after CHECKSUM_UNNECESSARY
conversion.
This implementation is sim
On 12/30/2015 10:50 AM, Xin Long wrote:
> tranport hashtbale will replace the association hashtable to do the
> lookup for transport, and then get association by t->assoc, rhashtable
> apis will be used because of it's resizable, scalable and using rcu.
>
> lport + rport + paddr will be the base h
Joe Perches writes:
> On Sat, 2016-01-02 at 19:25 -0500, Aaron Conole wrote:
>> When signaling that a GRO frame is ready to be processed, the network stack
>> correctly checks length and aborts processing when a frame is less than 14
>> bytes. However, such a condition is really indicative of a br
On Tue, 2016-01-05 at 12:47 -0500, Craig Gallek wrote:
> On Tue, Jan 5, 2016 at 12:38 PM, Eric Dumazet wrote:
> >
> > BTW, why UDP calls reuseport_select_sock() with hdr_len == 0 sometimes ?
> hdr_len only matters when you have an skb to work with. In both of
> the call sites of your suggested p
On Wed, Dec 23, 2015 at 09:04:46PM +0100, Guillaume Nault wrote:
> This series adds netlink support for creating PPP devices.
>
Any feedback on this series? I can see that it has been marked
"Deferred" in patchwork, so I'm unsure about what to do with this patch
set now.
Should I repost later (e.g
On 01/05/2016 06:11 PM, John Fastabend wrote:
When a qdisc is using per cpu stats (currently just the ingress
qdisc) only the bstats are being freed. This also free's the qstats.
Signed-off-by: John Fastabend
Acked-by: Daniel Borkmann
--
To unsubscribe from this list: send the line "unsubscr
On Tue, Jan 05, 2016 at 06:39:03PM +0100, Rabin Vincent wrote:
> Attempting to generate UBFM/SBFM instructions with shifts that can't be
> encoded in the immediate fields of the opcodes leads to a trigger of a
> BUG() in the instruction generation code. As the ARMv8 ARM says: "The
> shift amounts
On Tue, Jan 5, 2016 at 12:38 PM, Eric Dumazet wrote:
> On Tue, 2016-01-05 at 10:57 -0500, Craig Gallek wrote:
>> From: Craig Gallek
>>
>> Fixes: 538950a1b752 ("soreuseport: setsockopt SO_ATTACH_REUSEPORT_[CE]BPF")
>> Suggested-by: Daniel Borkmann
>> Signed-off-by: Craig Gallek
>> ---
>> net/co
On Tue, Jan 05, 2016 at 06:34:04PM +0100, Rabin Vincent wrote:
> The LSR instruction cannot be used to perform a zero right shift since a
> 0 as the immediate value (imm5) in the LSR instruction encoding means
> that a shift of 32 is perfomed. See DecodeIMMShift() in the ARM ARM.
>
> Make the JIT
On Tue, 2016-01-05 at 09:11 -0800, John Fastabend wrote:
> When a qdisc is using per cpu stats (currently just the ingress
> qdisc) only the bstats are being freed. This also free's the qstats.
>
> Signed-off-by: John Fastabend
> ---
Acked-by: Eric Dumazet
David, please add the following tag t
On Tue, Jan 05, 2016 at 05:36:47PM +0100, Daniel Borkmann wrote:
> On 01/05/2016 04:23 PM, Rabin Vincent wrote:
> >The SKF_AD_ALU_XOR_X ancillary is not like the other ancillary data
> >instructions since it XORs A with X while all the others replace A with
> >some loaded value. All the BPF JITs f
Attempting to generate UBFM/SBFM instructions with shifts that can't be
encoded in the immediate fields of the opcodes leads to a trigger of a
BUG() in the instruction generation code. As the ARMv8 ARM says: "The
shift amounts must be in the range 0 to one less than the register width
of the instr
On Tue, 2016-01-05 at 10:57 -0500, Craig Gallek wrote:
> From: Craig Gallek
>
> Fixes: 538950a1b752 ("soreuseport: setsockopt SO_ATTACH_REUSEPORT_[CE]BPF")
> Suggested-by: Daniel Borkmann
> Signed-off-by: Craig Gallek
> ---
> net/core/sock_reuseport.c | 2 +-
> 1 file changed, 1 insertion(+),
The LSR instruction cannot be used to perform a zero right shift since a
0 as the immediate value (imm5) in the LSR instruction encoding means
that a shift of 32 is perfomed. See DecodeIMMShift() in the ARM ARM.
Make the JIT skip generation of the LSR if a zero-shift is requested.
This was found
1 - 100 of 168 matches
Mail list logo
