Re: [PATCH net-next] tcp: diag: add support for request sockets to tcp_abort()

2015-12-18 Thread Lorenzo Colitti
On Fri, Dec 18, 2015 at 9:46 PM, Eric Dumazet wrote: > > Tested-by: Lorenzo Colitti > > I am curious, did you use packetdrill for this ? No, I added this to our existing kernel networking tests: https://android-review.googlesource.com/#/c/187491/ The tests are written in Python and run under A

Re: [PATCH 1/1] net: Add SO_REUSEPORT_LISTEN_OFF socket option as drain mode

2015-12-18 Thread Willy Tarreau
On Fri, Dec 18, 2015 at 06:38:03PM -0800, Eric Dumazet wrote: > On Fri, 2015-12-18 at 19:58 +0100, Willy Tarreau wrote: > > Hi Josh, > > > > On Fri, Dec 18, 2015 at 08:33:45AM -0800, Josh Snyder wrote: > > > I was also puzzled that binding succeeded. Looking into the code paths > > > involved, in

Re: [PATCH] netcp: fix regression in receive processing

2015-12-18 Thread David Miller
From: Arnd Bergmann Date: Fri, 18 Dec 2015 15:18:08 +0100 > A cleanup patch I did was unfortunately wrong and introduced > multiple serious bugs in the netcp rx processing, as indicated > by these correct gcc warnings: > > drivers/net/ethernet/ti/netcp_core.c:776:14: warning: 'buf_ptr' may be us

Re: [LKP] [PATCH v2] rhashtable: Kill harmless RCU warning in rhashtable_walk_init

2015-12-18 Thread Fengguang Wu
On Fri, Dec 18, 2015 at 11:42:59PM -0500, David Miller wrote: > From: Herbert Xu > Date: Sat, 19 Dec 2015 10:45:28 +0800 > > > On Fri, Dec 18, 2015 at 04:27:31PM -0500, David Miller wrote: > >> From: Herbert Xu > >> Date: Fri, 18 Dec 2015 21:14:08 +0800 > >> > >> > On Fri, Dec 18, 2015 at 04:54

Re: [PATCH v2] rhashtable: Kill harmless RCU warning in rhashtable_walk_init

2015-12-18 Thread David Miller
From: Herbert Xu Date: Sat, 19 Dec 2015 10:45:28 +0800 > On Fri, Dec 18, 2015 at 04:27:31PM -0500, David Miller wrote: >> From: Herbert Xu >> Date: Fri, 18 Dec 2015 21:14:08 +0800 >> >> > On Fri, Dec 18, 2015 at 04:54:14AM -0800, Eric Dumazet wrote: >> >> >> >> You can avoid the comment by usin

Re: [RFC 3/5] net/ethtool: support set coalesce per queue

2015-12-18 Thread Ben Hutchings
On Thu, 2015-12-17 at 06:51 +, kan.li...@intel.com wrote: [...] > --- a/net/core/ethtool.c > +++ b/net/core/ethtool.c > @@ -1778,6 +1778,37 @@ static int ethtool_get_per_queue_coalesce(struct > net_device *dev, >   return 0; >  } >   > +static int ethtool_set_per_queue_coalesce(struct net_

Re: [RFC 1/5] net/ethtool: introduce a new ioctl for per queue setting

2015-12-18 Thread Ben Hutchings
On Sat, 2015-12-19 at 03:27 +, Ben Hutchings wrote: > On Thu, 2015-12-17 at 06:51 +, kan.li...@intel.com wrote: > > From: Kan Liang > > > > Introduce a new ioctl ETHTOOL_PERQUEUE for per queue parameters setting. > > The following patches will enable some SUB_COMMANDs for per queue > > se

Re: [RFC 2/5] net/ethtool: support get coalesce per queue

2015-12-18 Thread Ben Hutchings
On Thu, 2015-12-17 at 06:51 +, kan.li...@intel.com wrote: > From: Kan Liang > > Device driver has to provide an interface to get per queue coalesce. > The interrupt coalescing parameters of each masked queue will be > copied back to user space one by one. > > Signed-off-by: Kan Liang > ---

Re: [RFC 1/5] net/ethtool: introduce a new ioctl for per queue setting

2015-12-18 Thread Ben Hutchings
On Thu, 2015-12-17 at 06:51 +, kan.li...@intel.com wrote: > From: Kan Liang > > Introduce a new ioctl ETHTOOL_PERQUEUE for per queue parameters setting. > The following patches will enable some SUB_COMMANDs for per queue > setting. > > Signed-off-by: Kan Liang > --- >  include/uapi/linux/et

RE: [Intel-wired-lan] [PATCH net-next 2/2] igb: Unpair the queues when changing the number of queues

2015-12-18 Thread Brown, Aaron F
> From: Intel-wired-lan [intel-wired-lan-boun...@lists.osuosl.org] on behalf of > Shota Suzuki > [suzuki_shota...@lab.ntt.co.jp] > Sent: Friday, December 11, 2015 1:44 AM > To: Kirsher, Jeffrey T; Brandeburg, Jesse; Nelson, Shannon; Wyborny, Carolyn; > Skidmore, Donald C; > Ronciak, John; Willi

RE: [PATCH net-next 1/2] igb: Remove unnecessary flag setting in igb_set_flag_queue_pairs()

2015-12-18 Thread Brown, Aaron F
> From: netdev-ow...@vger.kernel.org [netdev-ow...@vger.kernel.org] on behalf > of Shota Suzuki > [suzuki_shota...@lab.ntt.co.jp] > Sent: Friday, December 11, 2015 1:43 AM > To: Kirsher, Jeffrey T; Brandeburg, Jesse; Nelson, Shannon; Wyborny, Carolyn; > Skidmore, Donald C; > Ronciak, John; Will

[PATCH v2] rhashtable: Kill harmless RCU warning in rhashtable_walk_init

2015-12-18 Thread Herbert Xu
On Fri, Dec 18, 2015 at 04:27:31PM -0500, David Miller wrote: > From: Herbert Xu > Date: Fri, 18 Dec 2015 21:14:08 +0800 > > > On Fri, Dec 18, 2015 at 04:54:14AM -0800, Eric Dumazet wrote: > >> > >> You can avoid the comment by using the self documented and lockdep > >> enabled primitive > >> >

Re: [PATCH 1/1] net: Add SO_REUSEPORT_LISTEN_OFF socket option as drain mode

2015-12-18 Thread Eric Dumazet
On Fri, 2015-12-18 at 19:58 +0100, Willy Tarreau wrote: > Hi Josh, > > On Fri, Dec 18, 2015 at 08:33:45AM -0800, Josh Snyder wrote: > > I was also puzzled that binding succeeded. Looking into the code paths > > involved, in inet_csk_get_port, we quickly goto have_snum. From there, we > > end > >

Re: [PATCH] natsemi: add checks for dma mapping errors

2015-12-18 Thread David Miller
From: Alexey Khoroshilov Date: Sat, 19 Dec 2015 00:55:37 +0300 > @@ -2093,6 +2099,10 @@ static netdev_tx_t start_tx(struct sk_buff *skb, > struct net_device *dev) > np->tx_skbuff[entry] = skb; > np->tx_dma[entry] = pci_map_single(np->pci_dev, > skb->data

Re: [PATCH net-next] asix: silence log message from oversize packet

2015-12-18 Thread David Miller
From: Stephen Hemminger Date: Fri, 18 Dec 2015 16:15:03 -0800 > On Fri, 18 Dec 2015 16:08:53 -0500 (EST) > David Miller wrote: > >> From: Stephen Hemminger >> Date: Thu, 17 Dec 2015 17:51:16 -0800 >> >> > Since it is possible for an external system to send oversize packets >> > at anytime, it

Re: [PATCH 3/4] net/rfkill: Create "airplane mode" LED trigger

2015-12-18 Thread David Miller
From: Darren Hart Date: Fri, 18 Dec 2015 16:22:12 -0800 > On Tue, Dec 15, 2015 at 10:30:41AM -0500, João Paulo Rechi Vita wrote: >> For platform drivers to be able to correctly drive the "Airplane Mode" >> indicative LED there needs to be a RFKill LED trigger tied to the global >> state of RFKILL

net, ipv6: out of bounds access in secret_stable

2015-12-18 Thread Sasha Levin
c91 Not tainted 4.4.0-rc5-next-20151218-sasha-00021-gaba8d84-dirty #2750 [ 459.559809] 549d0aa3 8802ab0ef860 a1042384 [ 459.561036] 41b58ab3 ac667cdb a10422d9 8802ab0ef848 [ 459.562245] 9f6a417e 549d0aa3 f

Re: [PATCH 3/4] net/rfkill: Create "airplane mode" LED trigger

2015-12-18 Thread João Paulo Rechi Vita
On 18 December 2015 at 19:22, Darren Hart wrote: > On Tue, Dec 15, 2015 at 10:30:41AM -0500, João Paulo Rechi Vita wrote: >> For platform drivers to be able to correctly drive the "Airplane Mode" >> indicative LED there needs to be a RFKill LED trigger tied to the global >> state of RFKILL_TYPE_AL

Re: [PATCH 3/4] net/rfkill: Create "airplane mode" LED trigger

2015-12-18 Thread Darren Hart
On Tue, Dec 15, 2015 at 10:30:41AM -0500, João Paulo Rechi Vita wrote: > For platform drivers to be able to correctly drive the "Airplane Mode" > indicative LED there needs to be a RFKill LED trigger tied to the global > state of RFKILL_TYPE_ALL (instead of to a specific RFKill) and that > works in

Re: [PATCH net-next] asix: silence log message from oversize packet

2015-12-18 Thread Stephen Hemminger
On Fri, 18 Dec 2015 16:08:53 -0500 (EST) David Miller wrote: > From: Stephen Hemminger > Date: Thu, 17 Dec 2015 17:51:16 -0800 > > > Since it is possible for an external system to send oversize packets > > at anytime, it is best for driver not to print a message and spam > > the log (potential

Attention please!!!

2015-12-18 Thread MRS. PATRICIA O. PHILIP
Attention please!!! We have registered your ATM CARD of €4.9m Euros with DHL Courier Company with registration code of (DCJKT00147G). Please kindly Contact DHL Courier delivery Company services with your Address and Telephone No: for the delivery of the loaded ATM CARD to you Contact Person:

Re: [PATCH][iproute2] tc/q_htb.c: Fix the MPU value output in 'tc -d class show dev ' command

2015-12-18 Thread Dmitrii Shcherbakov
Phil, 18.12.2015, 19:55, "Phil Sutter" : > On Fri, Dec 18, 2015 at 07:39:25PM +0300, Dmitrii Shcherbakov wrote: >>  > Dmitrii, did iproute2 without your change even print the overhead as set >>  > by you before? Looking at the code, I'd assume not. >> >>  Tried building iproute2 (as of tag 4.2) an

Re: [PATCH v2 0/3] drivers: net: cpsw: Fix bugs in fixed-link PHY DT parsing

2015-12-18 Thread David Rivshin (Allworx)
On Fri, 18 Dec 2015 11:20:21 +0100 Daniel Trautmann wrote: > On Thu, Dec 17, 2015 at 03:45:08PM -0500, David Miller wrote: > > From: "David Rivshin (Allworx)" > > Date: Wed, 16 Dec 2015 23:02:08 -0500 > > > > > I have tested on the following hardware configurations: > > > - (EVMSK) dual emac w

Re: use-after-free in sixpack_close

2015-12-18 Thread One Thousand Gnomes
> > Also you are at the point the tty is closing so the net device may be > > active. Don't you need to netif_stop_queue() or defer the buffer > > kfrees until after the network device is unregistered so you don't pee > > into free memory if you have a transmit occurring ? > > I'm pretty sure that

[PATCH] natsemi: add checks for dma mapping errors

2015-12-18 Thread Alexey Khoroshilov
refill_rx() and start_tx() do not check if mapping dma memory succeed. The patch adds the checks and failure handling. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/net/ethernet/natsemi/natsemi.c | 10 ++ 1 file changed, 10

Re: [PATCH v2 0/2] net: usb: cdc_ncm: Adding support for two new Dell devices

2015-12-18 Thread David Miller
From: Daniele Palmas Date: Fri, 18 Dec 2015 14:43:32 +0100 > This patch series add support in the cdc_ncm driver for two devices > based on the same platform, that are different only for carrier > customization. > > V2: Added comment for highlighting FLAG_NOARP usage for those devices Series ap

Re: [PATCH net] openvswitch: correct encoding of set tunnel action attributes

2015-12-18 Thread David Miller
From: Simon Horman Date: Fri, 18 Dec 2015 19:43:15 +0900 > In a set action tunnel attributes should be encoded in a > nested action. > > I noticed this because ovs-dpctl was reporting an error > when dumping flows due to the incorrect encoding of tunnel attributes > in a set action. > > Fixes:

Re: [PATCH v2 net] bnx2x: Prevent FW assertion when using Vxlan

2015-12-18 Thread David Miller
From: Yuval Mintz Date: Fri, 18 Dec 2015 10:42:12 +0200 > FW has a rare corner case in which a fragmented packet using lots > of frags would not be linearized, causing the FW to assert while trying > to transmit the packet. > > To prevent this, we need to make sure the window of fragements conta

Re: rhashtable: Kill harmless RCU warning in rhashtable_walk_init

2015-12-18 Thread David Miller
From: Herbert Xu Date: Fri, 18 Dec 2015 21:14:08 +0800 > On Fri, Dec 18, 2015 at 04:54:14AM -0800, Eric Dumazet wrote: >> >> You can avoid the comment by using the self documented and lockdep >> enabled primitive >> >> iter->walker->tbl = rcu_dereference_protected(ht->tbl, >>

Re: [PATCH net-next] asix: silence log message from oversize packet

2015-12-18 Thread David Miller
From: Stephen Hemminger Date: Thu, 17 Dec 2015 17:51:16 -0800 > Since it is possible for an external system to send oversize packets > at anytime, it is best for driver not to print a message and spam > the log (potential external DoS). > > Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=1094

Re: [PATCH] ipip: ioctl: Remove superfluous IP-TTL handling.

2015-12-18 Thread David Miller
From: Pravin B Shelar Date: Thu, 17 Dec 2015 16:46:39 -0800 > IP-TTL case is already handled in ip_tunnel_ioctl() API. > > Signed-off-by: Pravin B Shelar Applied, thanks Pravin. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kern

Re: [PATCH net-next] tcp: diag: add support for request sockets to tcp_abort()

2015-12-18 Thread David Miller
From: Eric Dumazet Date: Thu, 17 Dec 2015 16:14:11 -0800 > From: Eric Dumazet > > Adding support for SYN_RECV request sockets to tcp_abort() > is quite easy after our tcp listener rewrite. > > Note that we also need to better handle listeners, or we might > leak not yet accepted children, beca

Re: [PATCH 2/2] can: sja1000: of: add compatibility with Technologic Systems version

2015-12-18 Thread Marc Kleine-Budde
On 12/18/2015 10:02 PM, Damien Riegel wrote: > On Fri, Dec 18, 2015 at 09:41:47PM +0100, Marc Kleine-Budde wrote: >> On 12/18/2015 09:17 PM, Damien Riegel wrote: >>> Technologic Systems provides an IP compatible with the SJA1000, >>> instantiated in an FPGA. Because of some bus widths issue, access

RE: [RFC 5/5] i40e/ethtool: support coalesce setting by queue

2015-12-18 Thread Liang, Kan
> > diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c > > b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c > > index b41f0be..5a35fdb 100644 > > --- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c > > +++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c > > @@ -1901,14 +1901,29 @@ stat

Re: use-after-free in sixpack_close

2015-12-18 Thread David Miller
From: One Thousand Gnomes Date: Thu, 17 Dec 2015 23:47:39 + > On Thu, 17 Dec 2015 16:05:32 -0500 (EST) > David Miller wrote: > >> From: One Thousand Gnomes >> Date: Thu, 17 Dec 2015 11:41:04 + >> >> >> This report is then followed by a dozen of other use-after-free reports. >> >> >>

Re: [PATCH net-next 0/5] Misc BPF updates

2015-12-18 Thread David Miller
From: Daniel Borkmann Date: Thu, 17 Dec 2015 23:51:52 +0100 > This series contains a couple of misc updates to the BPF code, besides > others a new helper bpf_skb_load_bytes(), moving clearing of A/X to the > classic converter, etc. Please see individual patches for details. Series applied, than

Re: [PATCH 2/2] mkiss: Fix use after free in sixpack_close().

2015-12-18 Thread David Miller
From: Ralf Baechle Date: Thu, 17 Dec 2015 22:35:31 +0100 > On Thu, Dec 17, 2015 at 04:05:49PM -0500, David Miller wrote: > >> Subject: [PATCH 2/2] mkiss: Fix use after free in sixpack_close(). > > Make that subject "... mkiss_close()." Durrr... indeed. Thanks for catching that. Committed as

Re: [PATCH 2/2] can: sja1000: of: add compatibility with Technologic Systems version

2015-12-18 Thread Damien Riegel
On Fri, Dec 18, 2015 at 09:41:47PM +0100, Marc Kleine-Budde wrote: > On 12/18/2015 09:17 PM, Damien Riegel wrote: > > Technologic Systems provides an IP compatible with the SJA1000, > > instantiated in an FPGA. Because of some bus widths issue, access to > > registers is made through a "window" tha

Re: [PATCH net] be2net: Avoid accessing eq object in be_msix_register routine, when i < 0.

2015-12-18 Thread David Miller
From: Venkat Duvvuru Date: Fri, 18 Dec 2015 01:40:50 +0530 > When the first request_irq fails in be_msix_register, i value > would be zero. The current code decrements the i value and > accesses the eq object without validating the decremented > "i" value. This can cause an "invalid memory addres

Re: [PATCH 2/2] can: sja1000: of: add compatibility with Technologic Systems version

2015-12-18 Thread Marc Kleine-Budde
On 12/18/2015 09:17 PM, Damien Riegel wrote: > Technologic Systems provides an IP compatible with the SJA1000, > instantiated in an FPGA. Because of some bus widths issue, access to > registers is made through a "window" that works like this: > > base + 0x0: address to read/write > base +

Re: [PATCH 00/23] Netfilter updates for net-next

2015-12-18 Thread David Miller
From: Pablo Neira Ayuso Date: Fri, 18 Dec 2015 21:26:26 +0100 > The following patchset contains the first batch of Netfilter updates for > the upcoming 4.5 kernel. This batch contains userspace netfilter header > compilation fixes, support for packet mangling in nf_tables, the new > tracing infra

Re: [PATCH] ila: add NETFILTER dependency

2015-12-18 Thread Pablo Neira Ayuso
On Fri, Dec 18, 2015 at 07:09:31PM +0100, Florian Westphal wrote: > Pablo Neira Ayuso wrote: > > I'm afraid this extra Kconfig dependency that Arnd adds to fix this is > > a symptom that there is something that doesn't belong there. > > > > I overlook this new hook on priority -1, how does this i

[PATCH 05/23] netfilter-bridge: brace placement

2015-12-18 Thread Pablo Neira Ayuso
From: Ian Morris Change brace placement to eliminate checkpatch error. No changes detected by objdiff. Signed-off-by: Ian Morris Signed-off-by: Pablo Neira Ayuso --- net/bridge/netfilter/ebt_log.c | 6 ++ net/bridge/netfilter/ebtables.c | 3 +-- 2 files changed, 3 insertions(+), 6 delet

[PATCH 03/23] netfilter-bridge: Cleanse indentation

2015-12-18 Thread Pablo Neira Ayuso
From: Ian Morris Fixes a bunch of issues detected by checkpatch with regards to code indentation. No changes detected by objdiff. Signed-off-by: Ian Morris Signed-off-by: Pablo Neira Ayuso --- net/bridge/netfilter/ebt_stp.c| 2 +- net/bridge/netfilter/ebtable_filter.c | 2 +- net/b

[PATCH 04/23] netfilter-bridge: use netdev style comments

2015-12-18 Thread Pablo Neira Ayuso
From: Ian Morris Changes comments to use netdev style. No changes detected by objdiff. Signed-off-by: Ian Morris Signed-off-by: Pablo Neira Ayuso --- net/bridge/netfilter/ebt_log.c | 3 +- net/bridge/netfilter/ebt_vlan.c | 15 +--- net/bridge/netfilter/ebtables.c | 84 +

[PATCH 07/23] netfilter: nf_ct_sctp: move ip_ct_sctp away from UAPI

2015-12-18 Thread Pablo Neira Ayuso
From: Marcelo Ricardo Leitner ip_ct_sctp is an internal structure, embedded by the union nf_conntrack_proto to store sctp-specific information at conntrack entries. It has no business with UAPI. This patch moves it from UAPI to a saner place, together with similar structs for other protocols. S

[PATCH 17/23] netfilter: nfnetlink_log: Change setter functions to be void

2015-12-18 Thread Pablo Neira Ayuso
From: "Rosen, Rami" Change return type of nfulnl_set_timeout() and nfulnl_set_qthresh() to be void. This patch changes the return type of the static methods nfulnl_set_timeout() and nfulnl_set_qthresh() to be void, as there is no justification and no need for these methods to return int. Signed

[PATCH 16/23] netfilter: ipv6: nf_defrag: fix NULL deref panic

2015-12-18 Thread Pablo Neira Ayuso
From: Florian Westphal Valdis reports NULL deref in nf_ct_frag6_gather. Problem is bogus use of skb_queue_walk() -- we miss first skb in the list since we start with head->next instead of head. In case the element we're looking for was head->next we won't find a result and then trip over NULL it

[PATCH 08/23] netfilter: remove duplicate include

2015-12-18 Thread Pablo Neira Ayuso
From: stephen hemminger Signed-off-by: Stephen Hemminger Signed-off-by: Pablo Neira Ayuso --- net/ipv4/netfilter/nf_reject_ipv4.c | 1 - net/ipv6/netfilter/nf_reject_ipv6.c | 1 - 2 files changed, 2 deletions(-) diff --git a/net/ipv4/netfilter/nf_reject_ipv4.c b/net/ipv4/netfilter/nf_reject_

[PATCH 15/23] netfilter: nf_tables: wrap tracing with a static key

2015-12-18 Thread Pablo Neira Ayuso
From: Florian Westphal Only needed when meta nftrace rule(s) were added. The assumption is that no such rules are active, so the call to nft_trace_init is "never" needed. When nftrace rules are active, we always call the nft_trace_* functions, but will only send netlink messages when all of the

[PATCH 18/23] netfilter: nf_tables: fix nf_log_trace based tracing

2015-12-18 Thread Pablo Neira Ayuso
From: Florian Westphal nf_log_trace() outputs bogus 'TRACE:' strings because I forgot to update the comments array. Fixes: 33d5a7b14bfd0 ("netfilter: nf_tables: extend tracing infrastructure") Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nf_tables_core.c

[PATCH 09/23] netfilter: ipv6: nf_defrag: avoid/free clone operations

2015-12-18 Thread Pablo Neira Ayuso
From: Florian Westphal commit 6aafeef03b9d9ecf ("netfilter: push reasm skb through instead of original frag skbs") changed ipv6 defrag to not use the original skbs anymore. So rather than keeping the original skbs around just to discard them afterwards just use the original skbs directly for the

[PATCH 06/23] netfilter-bridge: layout of if statements

2015-12-18 Thread Pablo Neira Ayuso
From: Ian Morris Eliminate some checkpatch issues by improved layout of if statements. No changes detected by objdiff. Signed-off-by: Ian Morris Signed-off-by: Pablo Neira Ayuso --- net/bridge/netfilter/ebt_ip6.c | 4 ++-- net/bridge/netfilter/ebtables.c | 8 2 files changed, 6 ins

[PATCH 02/23] netfilter: fix include files for compilation

2015-12-18 Thread Pablo Neira Ayuso
From: Mikko Rapeli Add missing header dependencies and other small changes so that each file compiles alone in userspace. Signed-off-by: Mikko Rapeli Signed-off-by: Pablo Neira Ayuso --- include/uapi/linux/netfilter/ipset/ip_set_bitmap.h | 2 ++ include/uapi/linux/netfilter/ipset/ip_se

[PATCH 13/23] netfilter: nft_payload: add packet mangling support

2015-12-18 Thread Pablo Neira Ayuso
From: Patrick McHardy Add support for mangling packet payload. Checksum for the specified base header is updated automatically if requested, however no updates for any kind of pseudo headers are supported, meaning no stateless NAT is supported. For checksum updates different checksumming methods

[PATCH 21/23] netfilter: implement xt_cgroup cgroup2 path match

2015-12-18 Thread Pablo Neira Ayuso
From: Tejun Heo This patch implements xt_cgroup path match which matches cgroup2 membership of the associated socket. The match is recursive and invertible. For rationales on introducing another cgroup based match, please refer to a preceding commit "sock, cgroup: add sock->sk_cgroup". v3: Fol

[PATCH 11/23] netfilter: Set /proc/net entries owner to root in namespace

2015-12-18 Thread Pablo Neira Ayuso
From: Philip Whineray Various files are owned by root with 0440 permission. Reading them is impossible in an unprivileged user namespace, interfering with firewall tools. For instance, iptables-save relies on /proc/net/ip_tables_names contents to dump only loaded tables. This patch assigned owne

[PATCH 22/23] nfnetlink: add nfnl_dereference_protected helper

2015-12-18 Thread Pablo Neira Ayuso
From: Florian Westphal to avoid overly long line in followup patch. Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nfnetlink.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/net/netfilter/nfnetlink.c b/net/netfilter/nfnetl

[PATCH 20/23] netfilter: prepare xt_cgroup for multi revisions

2015-12-18 Thread Pablo Neira Ayuso
From: Tejun Heo xt_cgroup will grow cgroup2 path based match. Postfix existing symbols with _v0 and prepare for multi revision registration. Signed-off-by: Tejun Heo Cc: Daniel Borkmann Cc: Daniel Wagner CC: Neil Horman Cc: Jan Engelhardt Cc: Pablo Neira Ayuso Signed-off-by: Pablo Neira A

[PATCH 23/23] netfilter: meta: add support for setting skb->pkttype

2015-12-18 Thread Pablo Neira Ayuso
From: Florian Westphal This allows to redirect bridged packets to local machine: ether type ip ether daddr set aa:53:08:12:34:56 meta pkttype set unicast Without 'set unicast', ip stack discards PACKET_OTHERHOST skbs. It is also useful to add support for a '-m cluster like' nft rule (where swit

[PATCH 14/23] netfilter: nf_tables: extend tracing infrastructure

2015-12-18 Thread Pablo Neira Ayuso
From: Florian Westphal nft monitor mode can then decode and display this trace data. Parts of LL/Network/Transport headers are provided as separate attributes. Otherwise, printing IP address data becomes virtually impossible for userspace since in the case of the netdev family we really don't w

[PATCH 19/23] netfilter: cttimeout: add netns support

2015-12-18 Thread Pablo Neira Ayuso
From: Pablo Neira Add a per-netns list of timeout objects and adjust code to use it. Signed-off-by: Pablo Neira Ayuso --- include/net/net_namespace.h | 3 + include/net/netfilter/nf_conntrack_timeout.h | 2 +- net/netfilter/nf_conntrack_timeout.c | 2 +- net/netfilt

[PATCH 12/23] netfilter: nf_tables: remove unused struct members

2015-12-18 Thread Pablo Neira Ayuso
From: Florian Westphal Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso --- include/net/netfilter/nf_tables.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/net/netfilter/nf_tables.h b/include/net/netfilter/nf_tables.h index 4bd7508..101d7d7 100644 --- a/include/

[PATCH 10/23] netfilter: ipv6: avoid nf_iterate recursion

2015-12-18 Thread Pablo Neira Ayuso
From: Florian Westphal The previous patch changed nf_ct_frag6_gather() to morph reassembled skb with the previous one. This means that the return value is always NULL or the skb argument. So change it to an err value. Instead of invoking NF_HOOK recursively with threshold to skip already-called

[PATCH 00/23] Netfilter updates for net-next

2015-12-18 Thread Pablo Neira Ayuso
Hi David, The following patchset contains the first batch of Netfilter updates for the upcoming 4.5 kernel. This batch contains userspace netfilter header compilation fixes, support for packet mangling in nf_tables, the new tracing infrastructure for nf_tables and cgroup2 support for iptables. Mor

[PATCH 01/23] netfilter: ebtables: use __u64 from linux/types.h

2015-12-18 Thread Pablo Neira Ayuso
From: Mikko Rapeli Fixes userspace compilation error: linux/netfilter_bridge/ebtables.h:38:2: error: unknown type name ‘uint64_t’ Signed-off-by: Mikko Rapeli Signed-off-by: Pablo Neira Ayuso --- include/uapi/linux/netfilter_bridge/ebtables.h | 6 -- 1 file changed, 4 insertions(+), 2 del

Re: [PATCH net-next] nfp: call netif_carrier_off() during init

2015-12-18 Thread David Miller
From: Jakub Kicinski Date: Thu, 17 Dec 2015 14:18:44 + > Netdevs default to carrier on, we should call netif_carrier_off() > during initialization since we handle carrier state changes in the > driver. > > Signed-off-by: Jakub Kicinski > Reviewed-by: Rolf Neugebauer Applied, thanks. -- To

[PATCH 1/2] can: sja1000: add documentation for Technologic Systems version

2015-12-18 Thread Damien Riegel
This commit adds documentation for the Technologic Systems version of SJA1000. The difference with the NXP version is in the way the registers are accessed. Signed-off-by: Damien Riegel --- Documentation/devicetree/bindings/net/can/sja1000.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion

[PATCH 2/2] can: sja1000: of: add compatibility with Technologic Systems version

2015-12-18 Thread Damien Riegel
Technologic Systems provides an IP compatible with the SJA1000, instantiated in an FPGA. Because of some bus widths issue, access to registers is made through a "window" that works like this: base + 0x0: address to read/write base + 0x2: 8-bit register value This commit adds a new compati

Re: [PATCH] veth: don't modify ip-summed; doing so treats packets with bad checksums as good.

2015-12-18 Thread Vijay Pandurangan
Evan and I have demonstrated this bug on Kubernetes as well, so it's not just a problem in Mesos. (See https://github.com/kubernetes/kubernetes/issues/18898) Sorry about my email client, I've re-sent the patch in another thread from git-email as I should have initially. I'll read through the TX p

Re: [PATCH net 0/2] Mellanox mlx4 driver fixes

2015-12-18 Thread David Miller
From: Or Gerlitz Date: Thu, 17 Dec 2015 15:35:36 +0200 > Two small fixes from Jenny for code flows that deal with time-stamping. Series applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH v2 0/3] drivers: net: cpsw: Fix bugs in fixed-link PHY DT parsing

2015-12-18 Thread David Miller
From: "David Rivshin (Allworx)" Date: Wed, 16 Dec 2015 23:02:08 -0500 > Commit 1f71e8c96fc654724723ce987e0a8b2aeb81746d ("drivers: net: cpsw: > Add support for fixed-link PHY") added initial fixed-link PHY support > for CPSW, but missed a few considerations. > > This series is based on the tip o

Re: [iproute PATCH v2] ip{,6}tunnel: have a shared stats parser/printer

2015-12-18 Thread Stephen Hemminger
On Fri, 18 Dec 2015 11:58:06 +0100 Phil Sutter wrote: > This has a slight side-effect of not aborting when /proc/net/dev is > malformed, but OTOH stats are not parsed for uninteresting interfaces. > > Signed-off-by: Phil Sutter > --- > Changes since v1: > - Fix conflict resolution (sscan from '

Re: [PATCH net-next v3 0/2] net: Allow accepted sockets to be bound to l3mdev domain

2015-12-18 Thread David Miller
From: David Ahern Date: Wed, 16 Dec 2015 13:20:42 -0800 > Allow accepted sockets to derive their sk_bound_dev_if setting from the > l3mdev domain in which the packets originated. This version adds a sysctl > to control whether the setting is inherited, making the functionality > similar to sk_mar

Re: [PATCH iproute2 v3 0/3] improve lwtunnel route support

2015-12-18 Thread Stephen Hemminger
On Fri, 18 Dec 2015 10:50:35 +0100 Paolo Abeni wrote: > This patch series try to improve the current route based > lwtunnel support in iproute2, namely adding support for the > COLLECT_METADATA flag in vxlan and gre link, and for ip6 > encap type in lwtunnel. > > Tunnel devices need to have the

Re: [PATCH net-next 0/2] Local checksum offload for VXLAN

2015-12-18 Thread Tom Herbert
On Fri, Dec 18, 2015 at 2:41 AM, Edward Cree wrote: > On 17/12/15 18:06, Tom Herbert wrote: >> I'm not sure that we need bits in VXLAN or any other encapsulation. It >> should be sufficient in udp_set_csum that if we already have >> CHECKSUM_PARTIAL that can always be used to do local checksum off

Re: [PATCH net-next] ipv6: addrconf: use stable address generator for ARPHRD_NONE

2015-12-18 Thread David Miller
From: Bjørn Mork Date: Wed, 16 Dec 2015 16:44:38 +0100 > Add a new address generator mode, using the stable address generator > with an automatically generated secret. This is intended as a default > address generator mode for device types with no EUI64 implementation. > The new generator is used

[PATCH] veth: don’t modify ip_summed; doing so treats packets with bad checksums as good.

2015-12-18 Thread Vijay Pandurangan
Packets that arrive from real hardware devices have ip_summed == CHECKSUM_UNNECESSARY if the hardware verified the checksums, or CHECKSUM_NONE if the packet is bad or it was unable to verify it. The current version of veth will replace CHECKSUM_NONE with CHECKSUM_UNNECESSARY, which causes corrupt p

Re: [PATCH] ila: add NETFILTER dependency

2015-12-18 Thread David Miller
From: Arnd Bergmann Date: Fri, 18 Dec 2015 15:37:37 +0100 > The recently added generic ILA translation facility fails to > build when CONFIG_NETFILTER is disabled: > > net/ipv6/ila/ila_xlat.c:229:20: warning: 'struct nf_hook_state' declared > inside parameter list > net/ipv6/ila/ila_xlat.c:235:

Re: [PATCH net-next v4 4/4] ila: Add generic ILA translation facility

2015-12-18 Thread David Miller
From: Florian Westphal Date: Fri, 11 Dec 2015 12:19:04 +0100 > So if we do ILA in init ns it & pass such skbs to other netns > it would be preferable to use nf_register_net_hooks in a namespace > once the first ila translation is added within that namespace. Right, the idea is that we want to do

Re: [PATCH] veth: don't modify ip-summed; doing so treats packets with bad checksums as good.

2015-12-18 Thread Cong Wang
(Cc'ing Eric B and Tom) On Fri, Dec 18, 2015 at 9:54 AM, Vijay Pandurangan wrote: > Packets that arrive from real hardware devices have ip_summed == > CHECKSUM_UNNECESSARY if the hardware verified the checksums, or > CHECKSUM_NONE if the packet is bad or it was unable to verify it. The > current

Re: [PATCH 1/1] net: Add SO_REUSEPORT_LISTEN_OFF socket option as drain mode

2015-12-18 Thread Willy Tarreau
Hi Josh, On Fri, Dec 18, 2015 at 08:33:45AM -0800, Josh Snyder wrote: > I was also puzzled that binding succeeded. Looking into the code paths > involved, in inet_csk_get_port, we quickly goto have_snum. From there, we end > up dropping into tb_found. Since !hlist_empty(&tb->owners), we end up che

Re: [PATCH][iproute2] tc/q_htb.c: Fix the MPU value output in 'tc -d class show dev ' command

2015-12-18 Thread Dmitrii Shcherbakov
Phil, > Dmitrii, did iproute2 without your change even print the overhead as set > by you before? Looking at the code, I'd assume not. Tried building iproute2 (as of tag 4.2) and using the upstream linux kernel (also tag 4.2 - 64291f7db5bd8150a74ad2036f1037e6a0428df2): ~/src/iproute2/tc$ uname

pull-request: mac80211-next 2015-12-18

2015-12-18 Thread Johannes Berg
Hi Dave, Before we all go on vacation/holidays, I have a few bugfixes for net-next. The remain-on-channel ones are quite necessary since Ilan's patch broke things quite a bit, causing crashes. If the issue with the strange mail formatting persists let me know and I'll send these through some othe

Re: [PATCH] ila: add NETFILTER dependency

2015-12-18 Thread Florian Westphal
Pablo Neira Ayuso wrote: > On Fri, Dec 18, 2015 at 03:37:37PM +0100, Arnd Bergmann wrote: > > The recently added generic ILA translation facility fails to > > build when CONFIG_NETFILTER is disabled: > > > > net/ipv6/ila/ila_xlat.c:229:20: warning: 'struct nf_hook_state' declared > > inside para

Re: [PATCH 1/2] [iproute2] tc/q_htb.c: remove printing of a deprecated overhead value previously encoded as a part of mpu field

2015-12-18 Thread Dmitrii Shcherbakov
Jesper, > Thank you Dmitrii for cleaning this up :-) You are welcome :^) I should read more carefully: its what you asked from the beginning. Thank you, Dmitrii Shcherbakov -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org

[PATCH] veth: don't modify ip-summed; doing so treats packets with bad checksums as good.

2015-12-18 Thread Vijay Pandurangan
Packets that arrive from real hardware devices have ip_summed == CHECKSUM_UNNECESSARY if the hardware verified the checksums, or CHECKSUM_NONE if the packet is bad or it was unable to verify it. The current version of veth will replace CHECKSUM_NONE with CHECKSUM_UNNECESSARY, which causes corrupt p

commit e34d65696d2e broke stmmac ethernet on socfpga

2015-12-18 Thread Dinh Nguyen
Hi, It appears that commit e34d65696d2e 'stmmac: create of compatible mdio bus for stmmac driver' is causing this error on the SoCFPGA platform: [1.767246] libphy: PHY stmmac-0: not found [1.772106] eth0: Could not attach to PHY [1.776129] stmmac_open: Cannot attach to PHY (er

Re: [PATCH] ila: add NETFILTER dependency

2015-12-18 Thread Pablo Neira Ayuso
On Fri, Dec 18, 2015 at 03:37:37PM +0100, Arnd Bergmann wrote: > The recently added generic ILA translation facility fails to > build when CONFIG_NETFILTER is disabled: > > net/ipv6/ila/ila_xlat.c:229:20: warning: 'struct nf_hook_state' declared > inside parameter list > net/ipv6/ila/ila_xlat.c:2

Fw: [Bug 109581] New: WARNING: CPU: 1 PID: 0 at net/sched/sch_hfsc.c:1429 hfsc_dequeue+0x166/0x2da()

2015-12-18 Thread Stephen Hemminger
Begin forwarded message: Date: Fri, 18 Dec 2015 17:12:15 + From: "bugzilla-dae...@bugzilla.kernel.org" To: "shemmin...@linux-foundation.org" Subject: [Bug 109581] New: WARNING: CPU: 1 PID: 0 at net/sched/sch_hfsc.c:1429 hfsc_dequeue+0x166/0x2da() https://bugzilla.kernel.org/show_bug.cg

[PATCH net-next 5/5] sfc: Downgrade or remove some error messages

2015-12-18 Thread Bert Kenward
Depending on configuration the NIC may return errors for unprivileged functions and/or VFs. Where these are expected and handled, reduce the level of any output. Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/ef10.c | 20 ++-- drivers/net/ethernet/sfc/efx.c | 7 --

[PATCH net-next 4/5] sfc: Downgrade EPERM messages from MCDI to debug

2015-12-18 Thread Bert Kenward
From: Tomáš Pilař When running in an unprivileged function we expect some MC commands to fail with permission errors. To avoid log spew downgrade these to debug only. Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/mcdi.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) d

[PATCH net-next 3/5] sfc: Make failed filter removal less noisy

2015-12-18 Thread Bert Kenward
There are situations - mostly reset related - where our view of the filter table differs from the hardware. In this case we may try and remove filters that aren't actually installed. This isn't that interesting in most situations, so downgrade the logging. Signed-off-by: Bert Kenward --- drivers

[PATCH net-next 2/5] sfc: Handle MCDI proxy authorisation

2015-12-18 Thread Bert Kenward
For unprivileged functions operations can be authorised by an admin function. Extra steps are introduced to the MCDI protocol in this situation - the initial response from the MCDI tells us that the operation has been deferred, and we must retry when told. We then receive an event telling us to ret

[PATCH net-next 1/5] sfc: Retry MCDI after NO_EVB_PORT error on a VF

2015-12-18 Thread Bert Kenward
After reboot the vswitch configuration from the PF may not be complete before the VF attempts to restore filters. In that case we see NO_EVB_PORT errors from the MC. Retry up to a time limit or until a different result is seen. Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/mcdi.c | 99

[PATCH net-next 0/5] sfc: additional virtual function support​

2015-12-18 Thread Bert Kenward
This introduces the client side of a mechanism to defer authorisation of operations, for example multicast subscription. Although primarily aimed at SRIOV VFs this can also apply to unprivileged PFs. Also handle reboot ordering corner cases better and reduce the level of some logging. Bert Kenwar

Re: [PATCH 03/14] ipv4, ipv6: use list_for_each_entry*

2015-12-18 Thread Julia Lawall
; > TO: Geliang Tang > CC: "David S. Miller" , Alexey Kuznetsov > , James Morris , Hideaki YOSHIFUJI > , Patrick McHardy > CC: Geliang Tang , netdev@vger.kernel.org, > linux-ker...@vger.kernel.org > > Hi Geliang, > > [auto build test WARNING on net/

Re: [PATCH][iproute2] tc/q_htb.c: Fix the MPU value output in 'tc -d class show dev ' command

2015-12-18 Thread Phil Sutter
On Fri, Dec 18, 2015 at 07:39:25PM +0300, Dmitrii Shcherbakov wrote: > > Dmitrii, did iproute2 without your change even print the overhead as set > > by you before? Looking at the code, I'd assume not. > > Tried building iproute2 (as of tag 4.2) and using the upstream linux kernel > (also tag 4.2

Re: [PATCH 1/1] net: Add SO_REUSEPORT_LISTEN_OFF socket option as drain mode

2015-12-18 Thread Josh Snyder
I was also puzzled that binding succeeded. Looking into the code paths involved, in inet_csk_get_port, we quickly goto have_snum. From there, we end up dropping into tb_found. Since !hlist_empty(&tb->owners), we end up checking that (tb->fastreuseport > 0 && sk->sk_reuseport && uid_eq(tb->fastuid,

Re: [PATCH net] sctp: sctp should release assoc when sctp_make_abort_user return NULL in sctp_close

2015-12-18 Thread Marcelo Ricardo Leitner
On Fri, Dec 18, 2015 at 09:08:46AM -0500, Vlad Yasevich wrote: > On 12/17/2015 02:33 PM, Vlad Yasevich wrote: > > On 12/17/2015 02:01 PM, Marcelo Ricardo Leitner wrote: ... > >> There is a check on sctp_cmd_delete_tcb() that avoids calling that on temp > >> assocs on > >> listening sockets, but th

  1   2   >