On Fri, Dec 18, 2015 at 07:39:25PM +0300, Dmitrii Shcherbakov wrote: > > Dmitrii, did iproute2 without your change even print the overhead as set > > by you before? Looking at the code, I'd assume not. > > Tried building iproute2 (as of tag 4.2) and using the upstream linux kernel > (also tag 4.2 - 64291f7db5bd8150a74ad2036f1037e6a0428df2):
This is without your patch, right? [...] > ~/src/iproute2/tc$ sudo ./tc class add dev eth0 parent 1: classid 1:1 htb > rate 100kbps ceil 100kbps mpu 256 overhead 64 Setting an mpu of 256 is suitable to get 0 as output value, as the code before your patch ANDs it with 0xff. > So it looks like the overhead is being set correctly, but the mpu is not, > even though the respective kernel module is loaded judging by what I see. To really know what is being set, you would have to look at the kernel variables not what iproute prints. This is nitpicking mostly, but relevant in this case as your patches to fix iproute's output show. Cheers, Phil -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
