Re: Random packet loss using IPsec with AES128-SHA1

2015-12-17 Thread Steffen Klassert
On Thu, Dec 17, 2015 at 04:36:06PM +0100, Gabriele Beltrame wrote: > Hi Steffen, > > I don't think it's IPsec (I can see the outbound packet in tcpdump), not > alone at least but the XEN /AWS Ethernet driver (or multiple things > concurring to the issue) actually.i Well, in this case you should c

rhashtable: Kill harmless RCU warning in rhashtable_walk_init

2015-12-17 Thread Herbert Xu
On Fri, Dec 18, 2015 at 01:34:16PM +0800, Herbert Xu wrote: > On Fri, Dec 18, 2015 at 09:39:22AM +0800, kernel test robot wrote: > > FYI, we noticed the below changes on > > > > https://github.com/0day-ci/linux > > Herbert-Xu/rhashtable-Fix-walker-list-corruption/20151216-164833 > > commit f9f51b

Re: [PATCH 4/6] bpf: hash: convert per-hashtable lock into per-bucket bit spinlock

2015-12-17 Thread Alexei Starovoitov
On Wed, Dec 16, 2015 at 02:58:08PM +0800, Ming Lei wrote: > On Wed, Dec 16, 2015 at 1:01 PM, Yang Shi wrote: > > > > > I recalled Steven confirmed raw_spin_lock has the lockdep benefit too in the > > patch review for changing to raw lock. > > > > Please check this thread out > > http://lists.ope

Re: [lkp] [rhashtable] f9f51b8070: INFO: suspicious RCU usage. ]

2015-12-17 Thread Herbert Xu
On Fri, Dec 18, 2015 at 09:39:22AM +0800, kernel test robot wrote: > FYI, we noticed the below changes on > > https://github.com/0day-ci/linux > Herbert-Xu/rhashtable-Fix-walker-list-corruption/20151216-164833 > commit f9f51b8070be3e829100614a7372b219723b864f ("rhashtable: Fix walker list > corr

Re: [PATCH 1/1] bonding: delay up state without speed and duplex in 802.3ad mode

2015-12-17 Thread Jay Vosburgh
wrote: >From: yzhu1 > >In 802.3ad mode, the speed and duplex is needed. But in some NICs, >there is a time span between NIC up state and getting speed and duplex. >As such, sometimes a slave in 802.3ad mode is in up state without >speed and duplex. This will make bonding in 802.3ad mode can not

Re: [PATCH 1/1] bonding: restrict up state in 802.3ad mode

2015-12-17 Thread zyjzyj2000
Hi, Jay Thanks for your reply. Yes. The NIC is a bit odd. We have to be compatible with it. I followed your advice to delay calling netif_carrier_on(). Changes: Delay calling netif_carrier_on(). Best Regards! Zhu Yanjun -- To unsubscribe from this list: send the line "unsubscribe netdev" in th

[PATCH 1/1] bonding: delay up state without speed and duplex in 802.3ad mode

2015-12-17 Thread zyjzyj2000
From: yzhu1 In 802.3ad mode, the speed and duplex is needed. But in some NICs, there is a time span between NIC up state and getting speed and duplex. As such, sometimes a slave in 802.3ad mode is in up state without speed and duplex. This will make bonding in 802.3ad mode can not work well. To

Re: rhashtable: Prevent spurious EBUSY errors on insertion

2015-12-17 Thread Herbert Xu
On Fri, Dec 18, 2015 at 12:07:08AM +0800, Xin Long wrote: > > I'm just wondering, why do not we handle the genuine double rehash > issue inside rhashtable? i mean it's just a temporary error that a > simple retry may fix it. Because a double rehash means that someone has cracked your hash function

[PATCH net-next] asix: silence log message from oversize packet

2015-12-17 Thread Stephen Hemminger
Since it is possible for an external system to send oversize packets at anytime, it is best for driver not to print a message and spam the log (potential external DoS). Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=109471 Signed-off-by: Stephen Hemminger --- a/drivers/net/usb/asix_common.c

Re: [PATCH] netconsole: Initialize after all core networking drivers

2015-12-17 Thread Calvin Owens
On Thursday 12/17 at 17:08 -0800, Eric Dumazet wrote: > On Thu, 2015-12-17 at 15:52 -0800, Calvin Owens wrote: > > With built-in netconsole and IXGBE, configuring netconsole via the kernel > > cmdline results in the following panic at boot: > > > > netpoll: netconsole: device eth0 not up yet,

Re: [PATCH] netconsole: Initialize after all core networking drivers

2015-12-17 Thread Calvin Owens
On Thursday 12/17 at 17:10 -0800, Stephen Hemminger wrote: > On Thu, 17 Dec 2015 15:52:39 -0800 > Calvin Owens wrote: > > > With built-in netconsole and IXGBE, configuring netconsole via the kernel > > cmdline results in the following panic at boot: > > > > netpoll: netconsole: device eth0 n

Re: [PATCH iproute2] iplink: support 'stable-privacy' IPv6 addrgenmode

2015-12-17 Thread Stephen Hemminger
On Wed, 16 Dec 2015 16:15:14 +0100 Bjørn Mork wrote: > Signed-off-by: Bjørn Mork Does not apply to current code base. Probably because of Hannes recent changes. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majord

Re: [PATCH iproute2 v2 3/3] lwtunnel: implement support for ip6 encap

2015-12-17 Thread Stephen Hemminger
On Wed, 16 Dec 2015 13:22:28 +0100 Paolo Abeni wrote: > Currently ip6 encap support for lwtunnel is missing. > This patch implement it, mostly duplicating the ipv4 parts. > > Also be sure to insert a space after the encap type, when > showing lwtunnel, to avoid the tunnel type and the following

Re: [PATCH iproute2] iproute: print addrgenmode stable_secret and fallback otherwise

2015-12-17 Thread Stephen Hemminger
On Wed, 16 Dec 2015 10:52:36 +0100 Hannes Frederic Sowa wrote: Applied thanks -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH iproute2 -next] bpf: minor fix in api and bpf_dump_error() usage

2015-12-17 Thread Stephen Hemminger
On Mon, 14 Dec 2015 16:57:32 +0100 Daniel Borkmann wrote: > Fix a whitespace in bpf_dump_error() usage, and also a missing closing > bracket in ntohl() macro for eBPF programs. > > Signed-off-by: Daniel Borkmann > --- Applied to net-next -- To unsubscribe from this list: send the line "unsubsc

Re: [PATCH iproute2] lwtunnel: fix argument parsing

2015-12-17 Thread Stephen Hemminger
On Tue, 15 Dec 2015 12:18:04 +0100 Paolo Abeni wrote: > Currently parse_encap_ip() does not update correctly argv/argc; > if multiple lwtunnel arguments are provided, the parsing fails after > the first one, i.e. > > ip route add 172.16.101.0/24 dev vxlan1 encap ip id 42 dst 192.168.255.1 > >

Re: [iproute PATCH] route: Fix printing of locked entries

2015-12-17 Thread Stephen Hemminger
On Sat, 12 Dec 2015 14:09:48 +0100 Phil Sutter wrote: > Commit 0f7543322c5fd ("route: ignore RTAX_HOPLIMIT of value -1") > accidentally reordered fprintf statements. This patch restores the > original ordering. > > Fixes: 0f7543322c5fd ("route: ignore RTAX_HOPLIMIT of value -1") > Signed-off-by:

Re: [iproute PATCH] ip{,6}tunnel: have a shared stats parser/printer

2015-12-17 Thread Stephen Hemminger
On Fri, 11 Dec 2015 13:23:44 +0100 Phil Sutter wrote: > This has a slight side-effect of not aborting when /proc/net/dev is > malformed, but OTOH stats are not parsed for uninteresting interfaces. > > Signed-off-by: Phil Sutter > --- > ip/ip6tunnel.c | 21 ++--- > ip/iptunnel.c

Re: [PATCH iproute2] ip, route: fix minor compile warning

2015-12-17 Thread Stephen Hemminger
On Mon, 14 Dec 2015 16:53:20 +0100 Daniel Borkmann wrote: > On 12/14/2015 04:51 PM, Phil Sutter wrote: > > On Mon, Dec 14, 2015 at 04:34:29PM +0100, Daniel Borkmann wrote: > >> Seems like gcc (4.8.3) doesn't catch this false positive, triggering > >> after 0f7543322c5f ("route: ignore RTAX_HOPLIM

Re: [PATCH] netconsole: Initialize after all core networking drivers

2015-12-17 Thread Stephen Hemminger
On Thu, 17 Dec 2015 15:52:39 -0800 Calvin Owens wrote: > With built-in netconsole and IXGBE, configuring netconsole via the kernel > cmdline results in the following panic at boot: > > netpoll: netconsole: device eth0 not up yet, forcing it > usb 2-1: new high-speed USB device number 2 u

Re: [PATCH] netconsole: Initialize after all core networking drivers

2015-12-17 Thread Eric Dumazet
On Thu, 2015-12-17 at 15:52 -0800, Calvin Owens wrote: > With built-in netconsole and IXGBE, configuring netconsole via the kernel > cmdline results in the following panic at boot: > > netpoll: netconsole: device eth0 not up yet, forcing it > usb 2-1: new high-speed USB device number 2 usi

[PATCH] ipip: ioctl: Remove superfluous IP-TTL handling.

2015-12-17 Thread Pravin B Shelar
IP-TTL case is already handled in ip_tunnel_ioctl() API. Signed-off-by: Pravin B Shelar --- net/ipv4/ipip.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/net/ipv4/ipip.c b/net/ipv4/ipip.c index 1f06729..4044da6 100644 --- a/net/ipv4/ipip.c +++ b/net/ipv4/ipip.c @@ -252,9 +252,6 @@ ipip_t

[PATCH net-next] tcp: diag: add support for request sockets to tcp_abort()

2015-12-17 Thread Eric Dumazet
From: Eric Dumazet Adding support for SYN_RECV request sockets to tcp_abort() is quite easy after our tcp listener rewrite. Note that we also need to better handle listeners, or we might leak not yet accepted children, because of a missing inet_csk_listen_stop() call. Signed-off-by: Eric Dumaze

Re: [PATCH net-next 2/5] bpf: move clearing of A/X into classic to eBPF migration prologue

2015-12-17 Thread Z Lim
On Thu, Dec 17, 2015 at 2:51 PM, Daniel Borkmann wrote: > Back in the days where eBPF (or back then "internal BPF" ;->) was not > exposed to user space, and only the classic BPF programs internally > translated into eBPF programs, we missed the fact that for classic BPF > A and X needed to be clea

[PATCH] netconsole: Initialize after all core networking drivers

2015-12-17 Thread Calvin Owens
With built-in netconsole and IXGBE, configuring netconsole via the kernel cmdline results in the following panic at boot: netpoll: netconsole: device eth0 not up yet, forcing it usb 2-1: new high-speed USB device number 2 using ehci-pci ixgbe :03:00.0: registered PHC device on eth0

Re: [PATCH net-next 2/5] bpf: move clearing of A/X into classic to eBPF migration prologue

2015-12-17 Thread Shi, Yang
On 12/17/2015 2:51 PM, Daniel Borkmann wrote: Back in the days where eBPF (or back then "internal BPF" ;->) was not exposed to user space, and only the classic BPF programs internally translated into eBPF programs, we missed the fact that for classic BPF A and X needed to be cleared. It was fixed

Re: use-after-free in sixpack_close

2015-12-17 Thread One Thousand Gnomes
On Thu, 17 Dec 2015 16:05:32 -0500 (EST) David Miller wrote: > From: One Thousand Gnomes > Date: Thu, 17 Dec 2015 11:41:04 + > > >> This report is then followed by a dozen of other use-after-free reports. > >> > >> On commit edb42dc7bc0da0125ceacab810a553ce1f0cac8d (Dec 15). > >> > >> Tha

Re: [PATCH] af_unix: Revert 'lock_interruptible' in stream receive code

2015-12-17 Thread Rainer Weikusat
Hannes Frederic Sowa writes: [...] > There is still a deadlock lingering around [...] > http://lists.openwall.net/netdev/2015/11/10/4 Interesting problem. Assuming the description (a while ago) A: socketpair() B: splice() from a pipe to /mnt/regular_file d

[PATCH net-next 3/5] bpf: fix misleading comment in bpf_convert_filter

2015-12-17 Thread Daniel Borkmann
Comment says "User BPF's register A is mapped to our BPF register 6", which is actually wrong as the mapping is on register 0. This can already be inferred from the code itself. So just remove it before someone makes assumptions based on that. Only code tells truth. ;) Signed-off-by: Daniel Borkma

[PATCH net-next 1/5] bpf: add bpf_skb_load_bytes helper

2015-12-17 Thread Daniel Borkmann
When hacking tc programs with eBPF, one of the issues that come up from time to time is to load addresses from headers. In eBPF as in classic BPF, we have BPF_LD | BPF_ABS | BPF_{B,H,W} instructions that extract a byte, half-word or word out of the skb data though helpers such as bpf_load_pointer()

[PATCH net-next 4/5] bpf, x86: detect/optimize loading 0 immediates

2015-12-17 Thread Daniel Borkmann
When sometimes structs or variables need to be initialized/'memset' to 0 in an eBPF C program, the x86 BPF JIT converts this to use immediates. We can however save a couple of bytes (f.e. even up to 7 bytes on a single emmission of BPF_LD | BPF_IMM | BPF_DW) in the image by detecting such case and

[PATCH net-next 2/5] bpf: move clearing of A/X into classic to eBPF migration prologue

2015-12-17 Thread Daniel Borkmann
Back in the days where eBPF (or back then "internal BPF" ;->) was not exposed to user space, and only the classic BPF programs internally translated into eBPF programs, we missed the fact that for classic BPF A and X needed to be cleared. It was fixed back then via 83d5b7ef99c9 ("net: filter: initi

[PATCH net-next 5/5] bpf, test: add couple of test cases

2015-12-17 Thread Daniel Borkmann
Add couple of test cases for interpreter but also JITs, f.e. to test that when imm32 moves are being done, upper 32bits of the regs are being zero extended. Without JIT: [...] [ 1114.129301] test_bpf: #43 MOV REG64 jited:0 128 PASS [ 1114.130626] test_bpf: #44 MOV REG32 jited:0 139 PASS [

[PATCH net-next 0/5] Misc BPF updates

2015-12-17 Thread Daniel Borkmann
This series contains a couple of misc updates to the BPF code, besides others a new helper bpf_skb_load_bytes(), moving clearing of A/X to the classic converter, etc. Please see individual patches for details. Thanks! Daniel Borkmann (5): bpf: add bpf_skb_load_bytes helper bpf: move clearing

RE: [RFC 5/5] i40e/ethtool: support coalesce setting by queue

2015-12-17 Thread Nelson, Shannon
> From: Kan Liang > > This patch implements set_per_queue_coalesce for i40e driver. > For i40e driver, only rx and tx usecs has per queue value. Changing > these two parameters only impact the specific queue. For other interrupt > coalescing parameters, they are shared among queues. The change to

RE: [RFC 4/5] i40e/ethtool: support coalesce getting by queue

2015-12-17 Thread Nelson, Shannon
> From: Kan Liang > > This patch implements get_per_queue_coalesce for i40e driver. > For i40e driver, only rx and tx usecs has per queue value. So only these > two parameters are read from specific registers. For other interrupt > coalescing parameters, they are shared among queues. The values w

Re: [PATCH net-next] ipv6: addrconf: use stable address generator for ARPHRD_NONE

2015-12-17 Thread Hannes Frederic Sowa
On 16.12.2015 16:44, Bjørn Mork wrote: > Add a new address generator mode, using the stable address generator > with an automatically generated secret. This is intended as a default > address generator mode for device types with no EUI64 implementation. > The new generator is used for ARPHRD_NONE i

Re: [PATCH 1/1] bonding: restrict up state in 802.3ad mode

2015-12-17 Thread Jay Vosburgh
wrote: >From: Zhu Yanjun > >In 802.3ad mode, the speed and duplex is needed. But in some NIC, >there is a time span between NIC up state and getting speed and duplex. >As such, sometimes a slave in 802.3ad mode is in up state without >speed and duplex. This will make bonding in 802.3ad mode can

[GIT] Networking

2015-12-17 Thread David Miller
1) Fix uninitialized variable warnings in nfnetlink_queue, a lot of people reported this... From Arnd Bergmann. 2) Don't init mutex twice in i40e driver, from Jesse Brandeburg. 3) Fix spurious EBUSY in rhashtable, from Herbert Xu. 4) Missing DMA unmaps in mvpp2 driver, from Marcin Wojtas. 5

Re: use-after-free in sixpack_close

2015-12-17 Thread Ralf Baechle DL5RB
On Thu, Dec 17, 2015 at 04:05:32PM -0500, David Miller wrote: > This should fix it, the only thing I'm unsure of is if we should perhaps > also use del_timer_sync() here. Anyone? I think so. Ralf -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

Re: [PATCH 2/2] mkiss: Fix use after free in sixpack_close().

2015-12-17 Thread Ralf Baechle
On Thu, Dec 17, 2015 at 04:05:49PM -0500, David Miller wrote: > Subject: [PATCH 2/2] mkiss: Fix use after free in sixpack_close(). Make that subject "... mkiss_close()." Ralf -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.

Re: [PATCH net 2/2] udp: restrict offloads to one namespace

2015-12-17 Thread Tom Herbert
On Thu, Dec 17, 2015 at 12:33 PM, Hannes Frederic Sowa wrote: > On 17.12.2015 19:10, Tom Herbert wrote: >> On Thu, Dec 17, 2015 at 9:40 AM, Hannes Frederic Sowa >> wrote: >>> On 17.12.2015 18:32, Tom Herbert wrote: On Thu, Dec 17, 2015 at 12:49 AM, Hannes Frederic Sowa wrote: > Wit

Re: [PATCHv3 net-next] ipv6: allow routes to be configured with expire values

2015-12-17 Thread David Miller
From: Dan Williams Date: Thu, 17 Dec 2015 14:23:57 -0600 > On Thu, 2015-12-17 at 15:08 -0500, David Miller wrote: >> That brings up an interesting issue, and I do not agree that we >> should >> publish the value for the purpose of determining if the kernel >> supports >> it or not. > > That said

Re: [PATCH net-next] team: Advertise tunneling offload features

2015-12-17 Thread David Miller
From: Or Gerlitz Date: Thu, 17 Dec 2015 16:11:55 +0200 > From: Eran Ben Elisha > > When the underlying device supports offloads encapulated traffic, > we need to reflect that through the hw_enc_features field of the > team net-device. > > This will cause the xmit path in the core networking st

Re: [PATCH net-next] net: qmi_wwan: ignore bogus CDC Union descriptors

2015-12-17 Thread David Miller
From: Bjørn Mork Date: Thu, 17 Dec 2015 12:44:04 +0100 > The CDC descriptors found on these vendor specific functions should > not be considered authoritative. They seem to be ignored by drivers > for other systems, and the quality is therefore low. > > One device (1e0e:9001) has been reported

Re: [PATCH] decnet: fix possible NULL deref in dnet_select_source()

2015-12-17 Thread Vegard Nossum
On 7 April 2014 at 21:18, David Miller wrote: > From: Eric Dumazet > Date: Sun, 06 Apr 2014 14:59:14 -0700 > >> From: Eric Dumazet >> >> dnet_select_source() should make sure dn_ptr is not NULL. >> >> While looking at this decnet code, I believe I found a device >> reference leak, lets fix it as

[PATCH 2/2] mkiss: Fix use after free in sixpack_close().

2015-12-17 Thread David Miller
Need to do the unregister_device() after all references to the driver private have been done. Signed-off-by: David S. Miller --- drivers/net/hamradio/mkiss.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/hamradio/mkiss.c b/drivers/net/hamradio/mkiss.c index

Re: use-after-free in sixpack_close

2015-12-17 Thread David Miller
From: One Thousand Gnomes Date: Thu, 17 Dec 2015 11:41:04 + >> This report is then followed by a dozen of other use-after-free reports. >> >> On commit edb42dc7bc0da0125ceacab810a553ce1f0cac8d (Dec 15). >> >> Thank you > > sixpack_close does unregister_netdev(sp->dev), which frees sp as sp

Re: [PATCH] net/macb: Update device tree binding for resetting PHY using GPIO

2015-12-17 Thread David Miller
From: Gregory CLEMENT Date: Thu, 17 Dec 2015 10:51:04 +0100 > Instead of being at the MAC level the reset gpio preperty is moved at the > PHY child node level. It is still managed by the MAC, but from the point > of view of the binding it make more sense to be part of the PHY node. > > This comm

Re: [PATCHv2 net-next 0/4] Few l2 table related enhancements for cxgb4

2015-12-17 Thread David Miller
From: Hariprasad Shenai Date: Thu, 17 Dec 2015 13:45:06 +0530 > This series adds a new API to allocate and update l2t entry, replaces > arpq_head/arpq_tail with double skb double linked list. Use t4_mgmt_tx() > to send control packets of l2t write request. Use symbolic constants > while calculati

Re: [Patch net] net: check both type and procotol for tcp sockets

2015-12-17 Thread David Miller
From: Cong Wang Date: Wed, 16 Dec 2015 23:39:04 -0800 > Dmitry reported the following out-of-bound access: > > Call Trace: > [] __asan_report_load4_noabort+0x3e/0x40 > mm/kasan/report.c:294 > [] sock_setsockopt+0x1284/0x13d0 net/core/sock.c:880 > [< inline >] SYSC_setsockopt net/socke

Re: [PATCH v2] drivers: net: xgene: fix Tx flow control

2015-12-17 Thread David Miller
From: Iyappan Subramanian Date: Wed, 16 Dec 2015 22:26:05 -0800 > Currently the Tx flow control is based on reading the hardware state, > which is not accurate since it may not reflect the descriptors that > are not yet reached the memory. > > To accurately control the Tx flow, changing it to be

Re: [PATCH v2 0/3] drivers: net: cpsw: Fix bugs in fixed-link PHY DT parsing

2015-12-17 Thread David Miller
From: "David Rivshin (Allworx)" Date: Wed, 16 Dec 2015 23:02:08 -0500 > I have tested on the following hardware configurations: > - (EVMSK) dual emac with two real MDIO-connected phys using RGMII-TXID > - single emac with fixed-link using RGMII > Testing of other CPSW emac configurations that f

Re: [PATCH net] tcp: restore fastopen with no data in SYN packet

2015-12-17 Thread David Miller
From: Eric Dumazet Date: Wed, 16 Dec 2015 13:53:10 -0800 > From: Eric Dumazet > > Yuchung tracked a regression caused by commit 57be5bdad759 ("ip: convert > tcp_sendmsg() to iov_iter primitives") for TCP Fast Open. > > Some Fast Open users do not actually add any data in the SYN packet. > > F

Re: [PATCH] af_unix: Revert 'lock_interruptible' in stream receive code

2015-12-17 Thread David Miller
From: Rainer Weikusat Date: Wed, 16 Dec 2015 20:09:25 + > With b3ca9b02b00704053a38bfe4c31dbbb9c13595d0, the AF_UNIX SOCK_STREAM > receive code was changed from using mutex_lock(&u->readlock) to > mutex_lock_interruptible(&u->readlock) to prevent signals from being > delayed for an indefinite

Re: [PATCH net 2/2] udp: restrict offloads to one namespace

2015-12-17 Thread Hannes Frederic Sowa
On 17.12.2015 19:10, Tom Herbert wrote: > On Thu, Dec 17, 2015 at 9:40 AM, Hannes Frederic Sowa > wrote: >> On 17.12.2015 18:32, Tom Herbert wrote: >>> On Thu, Dec 17, 2015 at 12:49 AM, Hannes Frederic Sowa >>> wrote: With user namespaces a normal user can start a new network namespace

Re: [PATCHv3 net-next] ipv6: allow routes to be configured with expire values

2015-12-17 Thread Hannes Frederic Sowa
On 17.12.2015 21:23, Dan Williams wrote: > On Thu, 2015-12-17 at 15:08 -0500, David Miller wrote: >> From: Dan Williams >> Date: Wed, 16 Dec 2015 11:03:52 -0600 >> >>> On Wed, 2015-12-16 at 17:50 +0800, Xin Long wrote: Add the support for adding expire value to routes, requested by Tom

Re: [PATCH net-next] nfp: clear ring delayed kick counters

2015-12-17 Thread David Miller
From: Jakub Kicinski Date: Wed, 16 Dec 2015 19:08:52 + > We need to clear delayed kick counters when we free rings otherwise > after ndo_close()/ndo_open() we could kick HW by more entries than > actually written to rings. > > Signed-off-by: Jakub Kicinski > Reviewed-by: Rolf Neugebauer A

Re: [PATCH net-next] tun: honor IFF_UP in tun_get_user()

2015-12-17 Thread David Miller
From: Eric Dumazet Date: Wed, 16 Dec 2015 08:57:37 -0800 > From: Eric Dumazet > > If a tun interface is turned down, we should not allow packet injection > into the kernel. > > Kernel does not send packets to the tun already. > > TUNATTACHFILTER can not be used as only tun_net_xmit() is takin

Re: [PATCHv3 net-next] ipv6: allow routes to be configured with expire values

2015-12-17 Thread Dan Williams
On Thu, 2015-12-17 at 15:08 -0500, David Miller wrote: > From: Dan Williams > Date: Wed, 16 Dec 2015 11:03:52 -0600 > > > On Wed, 2015-12-16 at 17:50 +0800, Xin Long wrote: > >> Add the support for adding expire value to routes, requested by > >> Tom Gundersen for systemd-networkd, and > Networ

Re: [PATCH net-next V1 4/4] net/mlx5e: Add PTP Hardware Clock (PHC) support

2015-12-17 Thread Richard Cochran
On Thu, Dec 17, 2015 at 02:35:35PM +0200, Saeed Mahameed wrote: > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c > b/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c > index 8e86f2c..b2e5014 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c > +++ b/drivers/

Re: [PATCH net-next V1 1/4] net/mlx5e: Restore the skb data pointer after xmit is finished

2015-12-17 Thread David Miller
From: Saeed Mahameed Date: Thu, 17 Dec 2015 14:35:32 +0200 > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tx.c > b/drivers/net/ethernet/mellanox/mlx5/core/en_tx.c > index 1341b1d..0fcfe64 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tx.c > +++ b/drivers/net/ethernet/mella

Re: [PATCH net-next V1 3/4] net/mlx5e: Add HW timestamping (TS) support

2015-12-17 Thread Richard Cochran
On Thu, Dec 17, 2015 at 02:35:34PM +0200, Saeed Mahameed wrote: > +static int mlx5e_get_ts_info(struct net_device *dev, > + struct ethtool_ts_info *info) > +{ > + struct mlx5e_priv *priv = netdev_priv(dev); > + int ret; > + > + ret = ethtool_op_get_ts_info(dev,

Re: [PATCH net-next] ipv6: add IPV6_HDRINCL option for raw sockets

2015-12-17 Thread David Miller
From: Hannes Frederic Sowa Date: Wed, 16 Dec 2015 17:22:47 +0100 > Same as in Windows, we miss IPV6_HDRINCL for SOL_IPV6 and SOL_RAW. > The SOL_IP/IP_HDRINCL is not available for IPv6 sockets. > > Signed-off-by: Hannes Frederic Sowa This looks fine, applied, thanks! -- To unsubscribe from this

Re: [PATCH net-next V1 3/4] net/mlx5e: Add HW timestamping (TS) support

2015-12-17 Thread Richard Cochran
On Thu, Dec 17, 2015 at 02:35:34PM +0200, Saeed Mahameed wrote: > @@ -63,6 +65,7 @@ > #define MLX5E_TX_CQ_POLL_BUDGET128 > #define MLX5E_UPDATE_STATS_INTERVAL200 /* msecs */ > #define MLX5E_SQ_BF_BUDGET 16 > +#define MLX5E_SERVICE_TASK_DELAY (HZ / 4) Hm... > +vo

Re: [PATCH net-next] ipv6: addrconf: use stable address generator for ARPHRD_NONE

2015-12-17 Thread David Miller
From: Bjørn Mork Date: Wed, 16 Dec 2015 16:44:38 +0100 > Add a new address generator mode, using the stable address generator > with an automatically generated secret. This is intended as a default > address generator mode for device types with no EUI64 implementation. > The new generator is used

Re: [PATCHv3 net-next] ipv6: allow routes to be configured with expire values

2015-12-17 Thread David Miller
From: Xin Long Date: Wed, 16 Dec 2015 17:50:11 +0800 > Add the support for adding expire value to routes, requested by > Tom Gundersen for systemd-networkd, and NetworkManager > wants it too. > > implement it by adding the new RTNETLINK attribute RTA_EXPIRES. > > Signed-off-by: Xin Long App

Re: [PATCHv3 net-next] ipv6: allow routes to be configured with expire values

2015-12-17 Thread David Miller
From: Dan Williams Date: Wed, 16 Dec 2015 11:03:52 -0600 > On Wed, 2015-12-16 at 17:50 +0800, Xin Long wrote: >> Add the support for adding expire value to routes, requested by >> Tom Gundersen for systemd-networkd, and NetworkManager >> wants it too. >> >> implement it by adding the new RTNET

Re: [PATCH net] sctp: sctp should release assoc when sctp_make_abort_user return NULL in sctp_close

2015-12-17 Thread Vlad Yasevich
On 12/17/2015 02:01 PM, Marcelo Ricardo Leitner wrote: > Em 17-12-2015 16:29, Vlad Yasevich escreveu: >> On 12/17/2015 09:30 AM, Xin Long wrote: >>> In sctp_close, sctp_make_abort_user may return NULL because of memory >>> allocation failure. If this happens, it will bypass any state change >>> and

Re: pull-request: mac80211 2015-12-15

2015-12-17 Thread Joe Perches
On Thu, 2015-12-17 at 13:44 +0100, Johannes Berg wrote: > On Wed, 2015-12-16 at 18:34 -0500, David Miller wrote: > >   > > Something about your text encoding kept this from ending up > > in patchwork for some reason. > > > > Hm. I don't see anything special with this, seems to just be plain > tex

Re: [PATCH net] sctp: sctp should release assoc when sctp_make_abort_user return NULL in sctp_close

2015-12-17 Thread Marcelo Ricardo Leitner
Em 17-12-2015 16:29, Vlad Yasevich escreveu: On 12/17/2015 09:30 AM, Xin Long wrote: In sctp_close, sctp_make_abort_user may return NULL because of memory allocation failure. If this happens, it will bypass any state change and never free the assoc. The assoc has no chance to be freed and it wil

[RFC 5/5] ethtool: support per queue sub command --coalesce

2015-12-17 Thread kan . liang
From: Kan Liang This patch uses a similar way as do_scoalesce to set coalesce per queue. It reads the current settings, change them, and write them back to the kernel for each masked queue. Example: $ sudo ./ethtool --set-perqueue-command eth5 queue_mask 0x1 --coalesce rx-usecs 10 tx-usecs 5

[RFC 1/5] ethtool: move option parsing related codes into function

2015-12-17 Thread kan . liang
From: Kan Liang Move option parsing code into find_option function. No behavior changes. Signed-off-by: Kan Liang --- ethtool.c | 49 +++-- 1 file changed, 31 insertions(+), 18 deletions(-) diff --git a/ethtool.c b/ethtool.c index 92c40b8..04c5015 1

[RFC 4/5] ethtool: support per queue sub command --show-coalesce

2015-12-17 Thread kan . liang
From: Kan Liang Get all masked queues' coalesce from kernel and dump them one by one. Example: $ sudo ./ethtool --set-perqueue-command eth5 queue_mask 0x11 --show-coalesce Queue: 0 Adaptive RX: off TX: off stats-block-usecs: 0 sample-interval: 0 pkt-rate-low: 0 pkt-rate-high: 0 rx-

[RFC 3/5] ethtool: introduce new ioctl for per queue setting

2015-12-17 Thread kan . liang
From: Kan Liang Introduce a new ioctl for per queue parameters setting. Users can apply commands to specific queues by setting SUB_COMMAND and queue_mask as following command. ethtool --set-perqueue-command DEVNAME [queue_mask %x] SUB_COMMAND If queue_mask is not set, the SUB_COMMAND will be a

[RFC 2/5] ethtool: move cmdline_coalesce out of do_scoalesce

2015-12-17 Thread kan . liang
From: Kan Liang Moving cmdline_coalesce out of do_scoalesce, so it can be shared with other functions. No behavior change. Signed-off-by: Kan Liang --- ethtool.c | 147 +++--- 1 file changed, 74 insertions(+), 73 deletions(-) diff --git

[RFC 2/5] net/ethtool: support get coalesce per queue

2015-12-17 Thread kan . liang
From: Kan Liang Device driver has to provide an interface to get per queue coalesce. The interrupt coalescing parameters of each masked queue will be copied back to user space one by one. Signed-off-by: Kan Liang --- include/linux/ethtool.h | 5 - net/core/ethtool.c | 33

[RFC 5/5] i40e/ethtool: support coalesce setting by queue

2015-12-17 Thread kan . liang
From: Kan Liang This patch implements set_per_queue_coalesce for i40e driver. For i40e driver, only rx and tx usecs has per queue value. Changing these two parameters only impact the specific queue. For other interrupt coalescing parameters, they are shared among queues. The change to one queue w

[RFC 1/5] net/ethtool: introduce a new ioctl for per queue setting

2015-12-17 Thread kan . liang
From: Kan Liang Introduce a new ioctl ETHTOOL_PERQUEUE for per queue parameters setting. The following patches will enable some SUB_COMMANDs for per queue setting. Signed-off-by: Kan Liang --- include/uapi/linux/ethtool.h | 18 ++ net/core/ethtool.c | 17 +

[RFC 3/5] net/ethtool: support set coalesce per queue

2015-12-17 Thread kan . liang
From: Kan Liang Device driver has to provide an interface to set per queue coalesce. The wanted coalesce information are stored in "data" for each masked queue, which can copy from userspace. Signed-off-by: Kan Liang --- include/linux/ethtool.h | 4 net/core/ethtool.c | 33 +

[RFC 4/5] i40e/ethtool: support coalesce getting by queue

2015-12-17 Thread kan . liang
From: Kan Liang This patch implements get_per_queue_coalesce for i40e driver. For i40e driver, only rx and tx usecs has per queue value. So only these two parameters are read from specific registers. For other interrupt coalescing parameters, they are shared among queues. The values which are sto

Re: [PATCH net] sctp: sctp should release assoc when sctp_make_abort_user return NULL in sctp_close

2015-12-17 Thread Vlad Yasevich
On 12/17/2015 09:30 AM, Xin Long wrote: > In sctp_close, sctp_make_abort_user may return NULL because of memory > allocation failure. If this happens, it will bypass any state change > and never free the assoc. The assoc has no chance to be freed and it > will be kept in memory with the state it ha

Re: [PATCH net 2/2] udp: restrict offloads to one namespace

2015-12-17 Thread Tom Herbert
On Thu, Dec 17, 2015 at 9:40 AM, Hannes Frederic Sowa wrote: > On 17.12.2015 18:32, Tom Herbert wrote: >> On Thu, Dec 17, 2015 at 12:49 AM, Hannes Frederic Sowa >> wrote: >>> With user namespaces a normal user can start a new network namespace >>> with all privileges and thus add new offloads, le

Re: pull-request: mac80211 2015-12-15

2015-12-17 Thread David Rivshin (Allworx)
On Thu, 17 Dec 2015 12:04:48 -0500 (EST) David Miller wrote: > From: Johannes Berg > Date: Thu, 17 Dec 2015 13:44:32 +0100 > > > On Wed, 2015-12-16 at 18:34 -0500, David Miller wrote: > >>  > >> Something about your text encoding kept this from ending up > >> in patchwork for some reason. > >>

Re: [PATCH net-next 0/2] Local checksum offload for VXLAN

2015-12-17 Thread Tom Herbert
On Thu, Dec 17, 2015 at 7:27 AM, Edward Cree wrote: > When the inner packet checksum is offloaded, the outer UDP checksum is easy > to calculate as it doesn't depend on the payload (because the inner checksum > cancels out everything from the inner packet except the pseudo header). > Thus, trans

Re: [PATCH/RFC net-next] ravb: Add dma queue interrupt support

2015-12-17 Thread Sergei Shtylyov
Hello. On 12/17/2015 07:29 PM, Yoshihiro Kaneko wrote: From: Kazuya Mizuguchi This patch supports the following interrupts. - One interrupt for multiple (descriptor, error, management) - One interrupt for emac - Four interrupts for dma queue (best effort rx/tx, network control rx/tx)

Re: [PATCH net 2/2] udp: restrict offloads to one namespace

2015-12-17 Thread Hannes Frederic Sowa
On 17.12.2015 18:32, Tom Herbert wrote: > On Thu, Dec 17, 2015 at 12:49 AM, Hannes Frederic Sowa > wrote: >> With user namespaces a normal user can start a new network namespace >> with all privileges and thus add new offloads, letting the other stack >> interpret this garbage. Because the user na

Re: [PATCH net 2/2] udp: restrict offloads to one namespace

2015-12-17 Thread Tom Herbert
On Thu, Dec 17, 2015 at 12:49 AM, Hannes Frederic Sowa wrote: > Hi all, > > On 17.12.2015 01:04, David Miller wrote: >> From: Hannes Frederic Sowa >> Date: Tue, 15 Dec 2015 21:01:54 +0100 >> >>> udp tunnel offloads tend to aggregate datagrams based on inner >>> headers. gro engine gets notified b

Re: pull-request: mac80211 2015-12-15

2015-12-17 Thread David Miller
From: Johannes Berg Date: Thu, 17 Dec 2015 13:44:32 +0100 > On Wed, 2015-12-16 at 18:34 -0500, David Miller wrote: >>  >> Something about your text encoding kept this from ending up >> in patchwork for some reason. >> > > Hm. I don't see anything special with this, seems to just be plain text >

Re: rhashtable: Prevent spurious EBUSY errors on insertion

2015-12-17 Thread David Miller
From: Xin Long Date: Thu, 17 Dec 2015 17:00:35 +0800 > On Thu, Dec 17, 2015 at 4:48 PM, Herbert Xu > wrote: >> On Thu, Dec 17, 2015 at 04:46:00PM +0800, Xin Long wrote: >>> >>> sorry for late test, but unfortunately, my case with rhashtalbe still >>> return EBUSY. >>> I added some debug code in

Re: [PATCH v3] net/macb: add support for resetting PHY using GPIO

2015-12-17 Thread David Miller
From: Gregory CLEMENT Date: Thu, 17 Dec 2015 09:39:32 +0100 > if I remebered well you do not remove patch from yout branch. So would > you agree to take a follow-up patch on top of 5833e0526820 "net/macb: > add support for resetting PHY using GPIO" ? Yes. -- To unsubscribe from this list: send

Re: [PATCH/RFC net-next] ravb: Add dma queue interrupt support

2015-12-17 Thread Yoshihiro Kaneko
Hi, 2015-12-16 4:00 GMT+09:00 Sergei Shtylyov : > Hello. > > On 12/15/2015 03:23 PM, Yoshihiro Kaneko wrote: > >> From: Kazuya Mizuguchi >> >> This patch supports the following interrupts. >> >> - One interrupt for multiple (descriptor, error, management) >> - One interrupt for emac >> - Four int

Re: [PATCH 08/15] i40iw: add files for iwarp interface

2015-12-17 Thread Christoph Hellwig
> + i40iw_next_iw_state(iwqp, I40IW_QP_STATE_ERROR, 0, 0, 0); > + > + if (!iwqp->user_mode) { > + if (iwqp->iwscq) > + i40iw_clean_cqes(iwqp, iwqp->iwscq); > + if ((iwqp->iwrcq) && (iwqp->iwrcq != iwqp->iwscq)) Please try to do a pass ove

Instantaneous Threshold ECN marking for DCTCP

2015-12-17 Thread Bryce Cronkite-Ratcliff
Hi there, I am attempting to run some experiments with DCTCP using mininet (so this is all user-level emulation -- my switch is a linux namespace using OVS). My question is on how to apply DCTCP's AQM. DCTCP's AQM just marks all packets with CE if they are received when the queue is over a thresho

Re: rhashtable: Prevent spurious EBUSY errors on insertion

2015-12-17 Thread Xin Long
On Thu, Dec 17, 2015 at 5:00 PM, Xin Long wrote: > On Thu, Dec 17, 2015 at 4:48 PM, Herbert Xu > wrote: >> On Thu, Dec 17, 2015 at 04:46:00PM +0800, Xin Long wrote: >>> >>> sorry for late test, but unfortunately, my case with rhashtalbe still >>> return EBUSY. >>> I added some debug code in rhas

Re: [PATCH 07/15] i40iw: add hw and utils files

2015-12-17 Thread Christoph Hellwig
> +#ifndef UNREFERENCED_PARAMETER > +#define UNREFERENCED_PARAMETER(_p) \ > +{\ > + (_p) = (_p);\ > +} > +#endif No need for this, just remove it. > +#define I40E_MASK(mask, shift) (mask << shift) Please just opencode the shit, this m

Re: [iproute PATCH v2 1/2] libnetlink: add a variant of rtnl_send_check that consumes ACKs

2015-12-17 Thread Eric Dumazet
On Thu, 2015-12-17 at 22:22 +0900, Lorenzo Colitti wrote: > The new variant is identical to rtnl_send_check, except it also > consumes the kernel response instead of using MSG_PEEK. This is > useful for callers that send simple commands that never cause a > response but only ACKs, and that expect t

Re: [Patch net] net: check both type and procotol for tcp sockets

2015-12-17 Thread Willem de Bruijn
On Thu, Dec 17, 2015 at 2:39 AM, Cong Wang wrote: > Dmitry reported the following out-of-bound access: > > Call Trace: > [] __asan_report_load4_noabort+0x3e/0x40 > mm/kasan/report.c:294 > [] sock_setsockopt+0x1284/0x13d0 net/core/sock.c:880 > [< inline >] SYSC_setsockopt net/socket.c:17

[PATCH net] be2net: Avoid accessing eq object in be_msix_register routine, when i < 0.

2015-12-17 Thread Venkat Duvvuru
When the first request_irq fails in be_msix_register, i value would be zero. The current code decrements the i value and accesses the eq object without validating the decremented "i" value. This can cause an "invalid memory address access" violation. This patch fixes the problem by accessing the e

Re: [PATCH] af_unix: Revert 'lock_interruptible' in stream receive code

2015-12-17 Thread Hannes Frederic Sowa
On 17.12.2015 16:28, Rainer Weikusat wrote: > Hannes Frederic Sowa writes: >> On 16.12.2015 21:09, Rainer Weikusat wrote: >>> With b3ca9b02b00704053a38bfe4c31dbbb9c13595d0, the AF_UNIX SOCK_STREAM >>> receive code was changed from using mutex_lock(&u->readlock) to >>> mutex_lock_interruptible(&u->

  1   2   >