On Thu, Dec 17, 2015 at 2:39 AM, Cong Wang <xiyou.wangc...@gmail.com> wrote: > Dmitry reported the following out-of-bound access: > > Call Trace: > [<ffffffff816cec2e>] __asan_report_load4_noabort+0x3e/0x40 > mm/kasan/report.c:294 > [<ffffffff84affb14>] sock_setsockopt+0x1284/0x13d0 net/core/sock.c:880 > [< inline >] SYSC_setsockopt net/socket.c:1746 > [<ffffffff84aed7ee>] SyS_setsockopt+0x1fe/0x240 net/socket.c:1729 > [<ffffffff85c18c76>] entry_SYSCALL_64_fastpath+0x16/0x7a > arch/x86/entry/entry_64.S:185 > > This is because we mistake a raw socket as a tcp socket. > We should check both sk->sk_type and sk->sk_protocol to ensure > it is a tcp socket. > > Willem points out __skb_complete_tx_timestamp() needs to fix as well. > > Reported-by: Dmitry Vyukov <dvyu...@google.com> > Cc: Willem de Bruijn <willemdebruijn.ker...@gmail.com> > Cc: Eric Dumazet <eric.duma...@gmail.com> > Signed-off-by: Cong Wang <xiyou.wangc...@gmail.com>
Acked-by: Willem de Bruijn <will...@google.com> Thanks for fixing both cases at once. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
