Re: [PATCH v2] stmmac: avoid ipq806x constant overflow warning

2015-11-12 Thread Joe Perches
On Fri, 2015-11-13 at 08:37 +0100, Geert Uytterhoeven wrote: > On Thu, Nov 12, 2015 at 10:03 PM, Arnd Bergmann > wrote: > > Building dwmac-ipq806x on a 64-bit architecture produces a harmless > > warning from gcc: > > > > stmmac/dwmac-ipq806x.c: In function 'ipq806x_gmac_probe': > > include/linux

Re: [PATCH v2] stmmac: avoid ipq806x constant overflow warning

2015-11-12 Thread Geert Uytterhoeven
On Thu, Nov 12, 2015 at 10:03 PM, Arnd Bergmann wrote: > Building dwmac-ipq806x on a 64-bit architecture produces a harmless > warning from gcc: > > stmmac/dwmac-ipq806x.c: In function 'ipq806x_gmac_probe': > include/linux/bitops.h:6:19: warning: overflow in implicit constant > conversion [-Wover

[PATCH RESEND] net: smsc911x: Reset PHY during initialization

2015-11-12 Thread Pavel Fedin
On certain hardware after software reboot the chip may get stuck and fail to reinitialize during reset. This can be fixed by ensuring that PHY is reset too. Old PHY resetting method required operational MDIO interface, therefore the chip should have been already set up. In order to be able to func

Re: [PATCH 08/14] net: tcp_memcontrol: sanitize tcp memory accounting callbacks

2015-11-12 Thread Johannes Weiner
On Thu, Nov 12, 2015 at 08:53:38PM -0800, Eric Dumazet wrote: > On Thu, 2015-11-12 at 18:41 -0500, Johannes Weiner wrote: > > @@ -711,6 +705,12 @@ static inline void mem_cgroup_wb_stats(struct > > bdi_writeback *wb, > > struct sock; > > void sock_update_memcg(struct sock *sk); > > void sock_rel

Re: [net-next 04/17] drivers/net/intel: use napi_complete_done()

2015-11-12 Thread Eric Dumazet
On Thu, 2015-10-15 at 14:43 -0700, Jeff Kirsher wrote: > From: Jesse Brandeburg > > As per Eric Dumazet's previous patches: > (see commit (24d2e4a50737) - tg3: use napi_complete_done()) > > Quoting verbatim: > Using napi_complete_done() instead of napi_complete() allows > us to use /sys/class/ne

Re: [PATCH 08/14] net: tcp_memcontrol: sanitize tcp memory accounting callbacks

2015-11-12 Thread Eric Dumazet
On Thu, 2015-11-12 at 18:41 -0500, Johannes Weiner wrote: > @@ -711,6 +705,12 @@ static inline void mem_cgroup_wb_stats(struct > bdi_writeback *wb, > struct sock; > void sock_update_memcg(struct sock *sk); > void sock_release_memcg(struct sock *sk); > +bool mem_cgroup_charge_skmem(struct cg_p

Re: [PATCH 1/2] arm64: bpf: add 'store immediate' instruction

2015-11-12 Thread Z Lim
On Thu, Nov 12, 2015 at 11:33 AM, Shi, Yang wrote: > On 11/11/2015 4:39 AM, Will Deacon wrote: >> >> Wait a second, we're both talking rubbish here :) The STR (immediate) >> form is referring to the addressing mode, whereas this patch wants to >> store an immediate value to memory, which does need

Re: [PATCH 2/2] arm64: bpf: make BPF prologue and epilogue align with ARM64 AAPCS

2015-11-12 Thread Z Lim
On Thu, Nov 12, 2015 at 1:57 PM, Yang Shi wrote: > > Save and restore FP/LR in BPF prog prologue and epilogue, save SP to FP > in prologue in order to get the correct stack backtrace. > > However, ARM64 JIT used FP (x29) as eBPF fp register, FP is subjected to > change during function call so it m

Re: [PATCH 1/2] arm64: bpf: fix JIT frame pointer setup

2015-11-12 Thread Z Lim
On Thu, Nov 12, 2015 at 1:57 PM, Yang Shi wrote: > BPF fp should point to the top of the BPF prog stack. The original > implementation made it point to the bottom incorrectly. > Move A64_SP to fp before reserve BPF prog stack space. > > CC: Zi Shen Lim > CC: Xi Wang > Signed-off-by: Yang Shi >

[PATCH] net: hisilicon: fix binding document of mdio

2015-11-12 Thread huangdaode
This patch fixes explain the occasion of "hisilcon,mdio" according to Arnd's comments. specify it is only used for hip04. First, please give your commnents. Signed-off-by: huangdaode --- Documentation/devicetree/bindings/net/hisilicon-hns-mdio.txt | 4 +++- 1 file changed, 3 insertions(+), 1 de

Re: [PATCH v2 net-next] net/core: ensure features get disabled on new lower devs

2015-11-12 Thread Florian Fainelli
On 04/11/15 18:56, David Miller wrote: >> Fixes: fd867d51f889 ("net/core: generic support for disabling netdev >> features down stack") > ... >> Reported-by: Nikolay Aleksandrov >> Signed-off-by: Jarod Wilson >> --- >> v2: Based on suggestions from Alex, and with not changing err to ret, this >

[PATCH 01/14] mm: memcontrol: export root_mem_cgroup

2015-11-12 Thread Johannes Weiner
A later patch will need this symbol in files other than memcontrol.c, so export it now and replace mem_cgroup_root_css at the same time. Signed-off-by: Johannes Weiner Acked-by: Michal Hocko --- include/linux/memcontrol.h | 3 ++- mm/backing-dev.c | 2 +- mm/memcontrol.c|

[PATCH 00/14] mm: memcontrol: account socket memory in unified hierarchy

2015-11-12 Thread Johannes Weiner
Hi, this is version 3 of the patches to add socket memory accounting to the unified hierarchy memory controller. Changes since v2 include: - Fixed an underflow bug in the mem+swap counter that came through the design of the per-cpu charge cache. To fix that, the unused mem+swap counter is now

[PATCH 02/14] mm: vmscan: simplify memcg vs. global shrinker invocation

2015-11-12 Thread Johannes Weiner
Letting shrink_slab() handle the root_mem_cgroup, and implicitely the !CONFIG_MEMCG case, allows shrink_zone() to invoke the shrinkers unconditionally from within the memcg iteration loop. Signed-off-by: Johannes Weiner Acked-by: Michal Hocko --- include/linux/memcontrol.h | 2 ++ mm/vmscan.c

[PATCH 03/14] net: tcp_memcontrol: properly detect ancestor socket pressure

2015-11-12 Thread Johannes Weiner
When charging socket memory, the code currently checks only the local page counter for excess to determine whether the memcg is under socket pressure. But even if the local counter is fine, one of the ancestors could have breached its limit, which should also force this child to enter socket pressu

[PATCH 04/14] net: tcp_memcontrol: remove bogus hierarchy pressure propagation

2015-11-12 Thread Johannes Weiner
When a cgroup currently breaches its socket memory limit, it enters memory pressure mode for itself and its *ancestors*. This throttles transmission in unrelated sibling and cousin subtrees that have nothing to do with the breached limit. On the contrary, breaching a limit should make that group a

[PATCH 05/14] net: tcp_memcontrol: protect all tcp_memcontrol calls by jump-label

2015-11-12 Thread Johannes Weiner
Move the jump-label from sock_update_memcg() and sock_release_memcg() to the callsite, and so eliminate those function calls when socket accounting is not enabled. This also eliminates the need for dummy functions because the calls will be optimized away if the Kconfig options are not enabled. Si

[PATCH 06/14] net: tcp_memcontrol: remove dead per-memcg count of allocated sockets

2015-11-12 Thread Johannes Weiner
The number of allocated sockets is used for calculations in the soft limit phase, where packets are accepted but the socket is under memory pressure. Since there is no soft limit phase in tcp_memcontrol, and memory pressure is only entered when packets are already dropped, this is actually dead cod

[PATCH 07/14] net: tcp_memcontrol: simplify the per-memcg limit access

2015-11-12 Thread Johannes Weiner
tcp_memcontrol replicates the global sysctl_mem limit array per cgroup, but it only ever sets these entries to the value of the memory_allocated page_counter limit. Use the latter directly. Signed-off-by: Johannes Weiner --- include/linux/memcontrol.h | 1 - include/net/sock.h | 8 +-

[PATCH 08/14] net: tcp_memcontrol: sanitize tcp memory accounting callbacks

2015-11-12 Thread Johannes Weiner
There won't be a tcp control soft limit, so integrating the memcg code into the global skmem limiting scheme complicates things unnecessarily. Replace this with simple and clear charge and uncharge calls--hidden behind a jump label--to account skb memory. Note that this is not purely aesthetic: as

[PATCH 11/14] mm: memcontrol: do not account memory+swap on unified hierarchy

2015-11-12 Thread Johannes Weiner
The unified hierarchy memory controller doesn't expose the memory+swap counter to userspace, but its accounting is hardcoded in all charge paths right now, including the per-cpu charge cache ("the stock"). To avoid adding yet more pointless memory+swap accounting with the socket memory support in

[PATCH 10/14] mm: memcontrol: generalize the socket accounting jump label

2015-11-12 Thread Johannes Weiner
The unified hierarchy memory controller is going to use this jump label as well to control the networking callbacks. Move it to the memory controller code and give it a more generic name. Signed-off-by: Johannes Weiner --- include/linux/memcontrol.h | 4 include/net/sock.h | 7 -

[PATCH 09/14] net: tcp_memcontrol: simplify linkage between socket and page counter

2015-11-12 Thread Johannes Weiner
There won't be any separate counters for socket memory consumed by protocols other than TCP in the future. Remove the indirection and link sockets directly to their owning memory cgroup. Signed-off-by: Johannes Weiner --- include/linux/memcontrol.h | 18 +++- include/net/sock.h

[PATCH 12/14] mm: memcontrol: move socket code for unified hierarchy accounting

2015-11-12 Thread Johannes Weiner
The unified hierarchy memory controller will account socket memory. Move the infrastructure functions accordingly. Signed-off-by: Johannes Weiner Acked-by: Michal Hocko --- mm/memcontrol.c | 148 1 file changed, 74 insertions(+), 74 delet

[PATCH 13/14] mm: memcontrol: account socket memory in unified hierarchy memory controller

2015-11-12 Thread Johannes Weiner
Socket memory can be a significant share of overall memory consumed by common workloads. In order to provide reasonable resource isolation in the unified hierarchy, this type of memory needs to be included in the tracking/accounting of a cgroup under active memory resource control. Overhead is onl

[PATCH 14/14] mm: memcontrol: hook up vmpressure to socket pressure

2015-11-12 Thread Johannes Weiner
Let the networking stack know when a memcg is under reclaim pressure so that it can clamp its transmit windows accordingly. Whenever the reclaim efficiency of a cgroup's LRU lists drops low enough for a MEDIUM or HIGH vmpressure event to occur, assert a pressure state in the socket and tcp memory

[PATCH iproute2 -next] {f,m}_bpf: allow for sharing maps

2015-11-12 Thread Daniel Borkmann
This larger work addresses one of the bigger remaining issues on tc's eBPF frontend, that is, to allow for persistent file descriptors. Whenever tc parses the ELF object, extracts and loads maps into the kernel, these file descriptors will be out of reach after the tc instance exits. Meaning, for

Re: [PATCH] bpf: samples: exclude asm/sysreg.h for arm64

2015-11-12 Thread Alexei Starovoitov
On Thu, Nov 12, 2015 at 02:07:46PM -0800, Yang Shi wrote: > commit 338d4f49d6f7114a017d294ccf7374df4f998edc > ("arm64: kernel: Add support for Privileged Access Never") includes sysreg.h > into futex.h and uaccess.h. But, the inline assembly used by asm/sysreg.h is > incompatible with llvm so it wi

Re: [PATCH] net: phy: at803x: support interrupt on 8030 and 8035

2015-11-12 Thread Måns Rullgård
Mason writes: > On 12/11/2015 20:14, Florian Fainelli wrote: >> On 12/11/15 11:09, Måns Rullgård wrote: >>> On 12 November 2015 19:06:23 GMT+00:00, Mason wrote: On 12/11/2015 18:40, Mans Rullgard wrote: > Commit 77a993942 "phy/at8031: enable at8031 to work on interrupt mode" > added

Re: Is ndo_do_ioctl still acceptable?

2015-11-12 Thread Stephen Hemminger
On Thu, 12 Nov 2015 23:19:06 +0100 "Jason A. Donenfeld" wrote: > On Thu, Nov 12, 2015 at 9:30 PM, Austin S Hemmelgarn > wrote: > >> > > On the other hand, based on what you are saying about your device, it sounds > > like you are working on some kind of cryptographically secured (either > > auth

[PATCH] bpf: samples: exclude asm/sysreg.h for arm64

2015-11-12 Thread Yang Shi
commit 338d4f49d6f7114a017d294ccf7374df4f998edc ("arm64: kernel: Add support for Privileged Access Never") includes sysreg.h into futex.h and uaccess.h. But, the inline assembly used by asm/sysreg.h is incompatible with llvm so it will cause BPF samples build failure for ARM64. Since sysreg.h is us

Re: Is ndo_do_ioctl still acceptable?

2015-11-12 Thread Jason A. Donenfeld
On Thu, Nov 12, 2015 at 9:30 PM, Austin S Hemmelgarn wrote: >> > On the other hand, based on what you are saying about your device, it sounds > like you are working on some kind of cryptographically secured (either > authenticated or encrypted or both) tunnel, in which case the fact that > securit

Re: [PATCH net 1/3] ipv6: Avoid creating RTF_CACHE from a rt that is not managed by fib6 tree

2015-11-12 Thread Chris Siebenmann
> The original bug report: > https://bugzilla.redhat.com/show_bug.cgi?id=1272571 > > The setup has a IPv4 GRE tunnel running in a IPSec. The bug > happens when ndisc starts sending router solicitation at the gre > interface. The simplified oops stack is like: [...] > Reported-by: Chris Siebenman

[PATCH V2 0/2] arm64: bpf: correct JIT stack setup and make it align with ARM64 AAPCS

2015-11-12 Thread Yang Shi
Changelog in V2: Split to two patches according to the suggestion from Zi Shen Lim Show A64_FP in stack layout diagram Correct "+64" to "-64" Yang Shi (2): arm64: bpf: fix JIT frame pointer setup arm64: bpf: make BPF prologue and epilogue align with ARM64 AAPCS arch/arm64/net/bpf_ji

[PATCH 1/2] arm64: bpf: fix JIT frame pointer setup

2015-11-12 Thread Yang Shi
BPF fp should point to the top of the BPF prog stack. The original implementation made it point to the bottom incorrectly. Move A64_SP to fp before reserve BPF prog stack space. CC: Zi Shen Lim CC: Xi Wang Signed-off-by: Yang Shi --- arch/arm64/net/bpf_jit_comp.c | 6 +++--- 1 file changed, 3

[PATCH 2/2] arm64: bpf: make BPF prologue and epilogue align with ARM64 AAPCS

2015-11-12 Thread Yang Shi
Save and restore FP/LR in BPF prog prologue and epilogue, save SP to FP in prologue in order to get the correct stack backtrace. However, ARM64 JIT used FP (x29) as eBPF fp register, FP is subjected to change during function call so it may cause the BPF prog stack base address change too. Use x25

Re: [PATCH] net: phy: at803x: support interrupt on 8030 and 8035

2015-11-12 Thread Mason
On 12/11/2015 20:14, Florian Fainelli wrote: > On 12/11/15 11:09, Måns Rullgård wrote: >> On 12 November 2015 19:06:23 GMT+00:00, Mason wrote: >>> On 12/11/2015 18:40, Mans Rullgard wrote: Commit 77a993942 "phy/at8031: enable at8031 to work on interrupt mode" added interrupt support for t

Re: [PATCH v2] stmmac: avoid ipq806x constant overflow warning

2015-11-12 Thread David Miller
From: Arnd Bergmann Date: Thu, 12 Nov 2015 22:03:40 +0100 > @@ -337,11 +337,11 @@ static int ipq806x_gmac_probe(struct platform_device > *pdev) >QSGMII_PHY_RX_SIGNAL_DETECT_EN | >QSGMII_PHY_TX_DRIVER_EN | >QSGMII

[PATCH iproute2] ip_tunnel: determine tunnel address family from the tunnel type

2015-11-12 Thread Konstantin Shemyak
When creating an IP tunnel over IPv6, the address family must be passed in the option, e.g. ip -6 tunnel add mode ip6gre local 1::1 remote 2::2 This makes it impossible to create both IPv4 and IPv6 tunnels in one batch. In fact the address family option is redundant here, as each tunnel mode is

[PATCH v2] stmmac: avoid ipq806x constant overflow warning

2015-11-12 Thread Arnd Bergmann
Building dwmac-ipq806x on a 64-bit architecture produces a harmless warning from gcc: stmmac/dwmac-ipq806x.c: In function 'ipq806x_gmac_probe': include/linux/bitops.h:6:19: warning: overflow in implicit constant conversion [-Woverflow] val = QSGMII_PHY_CDR_EN | stmmac/dwmac-ipq806x.c:333:8: not

Re: [PATCH net] sctp: translate host order to network order when setting a hmacid

2015-11-12 Thread Vlad Yasevich
On 11/12/2015 12:07 AM, Xin Long wrote: > now sctp auth cannot work well when setting a hmacid manually, which > is caused by that we didn't use the network order for hmacid, so fix > it by adding the transformation in sctp_auth_ep_set_hmacs. > > even we set hmacid with the network order in usersp

Re: [PATCH] stmmac: avoid ipq806x constant overflow warning

2015-11-12 Thread Arnd Bergmann
On Thursday 12 November 2015 12:25:28 David Miller wrote: > From: Arnd Bergmann > Date: Thu, 12 Nov 2015 15:12:48 +0100 > > > Building dwmac-ipq806x on a 64-bit architecture produces a harmless > > warning from gcc: > > > > stmmac/dwmac-ipq806x.c: In function 'ipq806x_gmac_probe': > > include/li

Re: [linux-4.4-mw] BUG: unable to handle kernel paging request ip_vs_out.constprop

2015-11-12 Thread Ido Schimmel
Thu, Nov 12, 2015 at 07:12:03PM IST, li...@eikelenboom.it wrote: >On 2015-11-12 17:52, Eric Dumazet wrote: >> On Thu, 2015-11-12 at 16:16 +0100, Sander Eikelenboom wrote: >> >>> > Thanks for the report, please try following patch : >>> >>> Hi Eric, >>> >>> Thanks for the patch! >>> Got it up and

Re: Is ndo_do_ioctl still acceptable?

2015-11-12 Thread Austin S Hemmelgarn
On 2015-11-12 11:58, Jason A. Donenfeld wrote: Hi Stephen, Thanks for your response. On Thu, Nov 12, 2015 at 5:34 PM, Stephen Hemminger wrote: The problem is ioctl's are device specific, and therefore create dependency on the unique features supported by your device. The question always comes

Re: [PATCH 1/2] arm64: bpf: add 'store immediate' instruction

2015-11-12 Thread Shi, Yang
On 11/11/2015 4:39 AM, Will Deacon wrote: On Wed, Nov 11, 2015 at 12:12:56PM +, Will Deacon wrote: On Tue, Nov 10, 2015 at 06:45:39PM -0800, Z Lim wrote: On Tue, Nov 10, 2015 at 2:41 PM, Yang Shi wrote: aarch64 doesn't have native store immediate instruction, such operation Actually, aa

Re: [PATCH 00/10] Netfilter fixes for net

2015-11-12 Thread David Miller
From: Pablo Neira Ayuso Date: Wed, 11 Nov 2015 18:33:33 +0100 > The following patchset contains Netfilter fixes for your net tree. This > large batch that includes fixes for ipset, netfilter ingress, nf_tables > dynamic set instantiation and a longstanding Kconfig dependency problem. > More speci

Re: [PATCH] net: phy: at803x: support interrupt on 8030 and 8035

2015-11-12 Thread Florian Fainelli
On 12/11/15 09:40, Mans Rullgard wrote: > Commit 77a993942 "phy/at8031: enable at8031 to work on interrupt mode" > added interrupt support for the 8031 PHY but left out the other two > chips supported by this driver. > > This patch sets the .ack_interrupt and .config_intr functions for the > 8030

Re: [PATCH] net: phy: vitesse: add support for VSC8601

2015-11-12 Thread Florian Fainelli
On 12/11/15 10:41, Mans Rullgard wrote: > This adds support for the Vitesse VSC8601 PHY. Generic functions are > used for everything except interrupt handling. > > Signed-off-by: Mans Rullgard Reviewed-by: Florian Fainelli -- Florian -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH] net: phy: at803x: support interrupt on 8030 and 8035

2015-11-12 Thread Florian Fainelli
On 12/11/15 11:09, Måns Rullgård wrote: > On 12 November 2015 19:06:23 GMT+00:00, Mason wrote: >> On 12/11/2015 18:40, Mans Rullgard wrote: >>> Commit 77a993942 "phy/at8031: enable at8031 to work on interrupt >> mode" >>> added interrupt support for the 8031 PHY but left out the other two >>> chip

Re: [PATCH] unix: avoid use-after-free in ep_remove_wait_queue

2015-11-12 Thread Rainer Weikusat
Jason Baron writes: >> + >> +/* Needs sk unix state lock. After recv_ready indicated not ready, >> + * establish peer_wait connection if still needed. >> + */ >> +static int unix_dgram_peer_wake_me(struct sock *sk, struct sock *other) >> +{ >> +int connected; >> + >> +connected = unix_dgra

Re: [PATCH 5/8] mm: memcontrol: account socket memory on unified hierarchy

2015-11-12 Thread Johannes Weiner
On Thu, Nov 12, 2015 at 06:36:20PM +, Mel Gorman wrote: > Bottom line, there is legimate confusion over whether cgroup controllers > are going to be enabled by default or not in the future. If they are > enabled by default, there is a non-zero cost to that and a change in > semantics that peopl

Re: [PATCH] net: phy: at803x: support interrupt on 8030 and 8035

2015-11-12 Thread Måns Rullgård
On 12 November 2015 19:06:23 GMT+00:00, Mason wrote: >On 12/11/2015 18:40, Mans Rullgard wrote: >> Commit 77a993942 "phy/at8031: enable at8031 to work on interrupt >mode" >> added interrupt support for the 8031 PHY but left out the other two >> chips supported by this driver. >> >> This patch set

Re: [PATCH] net: phy: at803x: support interrupt on 8030 and 8035

2015-11-12 Thread Mason
On 12/11/2015 18:40, Mans Rullgard wrote: > Commit 77a993942 "phy/at8031: enable at8031 to work on interrupt mode" > added interrupt support for the 8031 PHY but left out the other two > chips supported by this driver. > > This patch sets the .ack_interrupt and .config_intr functions for the > 803

Re: [PATCH net 1/1] r8169: fix kasan reported skb use-after-free.

2015-11-12 Thread David Miller
From: Francois Romieu Date: Wed, 11 Nov 2015 23:35:18 +0100 > Signed-off-by: Francois Romieu > Reported-by: Dave Jones > Fixes: d7d2d89d4b0af ("r8169: Add software counter for multicast packages") > Acked-by: Eric Dumazet > Acked-by: Corinna Vinschen > --- > > Applies to davem's net as of c

Re: [PATCH 5/8] mm: memcontrol: account socket memory on unified hierarchy

2015-11-12 Thread Mel Gorman
On Fri, Nov 06, 2015 at 11:19:53AM -0500, Johannes Weiner wrote: > On Fri, Nov 06, 2015 at 11:57:24AM +0100, Michal Hocko wrote: > > On Thu 05-11-15 17:52:00, Johannes Weiner wrote: > > > On Thu, Nov 05, 2015 at 03:55:22PM -0500, Johannes Weiner wrote: > > > > On Thu, Nov 05, 2015 at 03:40:02PM +01

[PATCH] net: phy: vitesse: add support for VSC8601

2015-11-12 Thread Mans Rullgard
This adds support for the Vitesse VSC8601 PHY. Generic functions are used for everything except interrupt handling. Signed-off-by: Mans Rullgard --- drivers/net/phy/vitesse.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/vitesse.c b/drivers/

[PATCH] net: phy: at803x: support interrupt on 8030 and 8035

2015-11-12 Thread Mans Rullgard
Commit 77a993942 "phy/at8031: enable at8031 to work on interrupt mode" added interrupt support for the 8031 PHY but left out the other two chips supported by this driver. This patch sets the .ack_interrupt and .config_intr functions for the 8030 and 8035 drivers as well. Signed-off-by: Mans Rullg

[PATCH net 0/6] Mellanox NIC driver update, Nov 12, 2015

2015-11-12 Thread Or Gerlitz
Hi Dave, Few small mlx5 and mlx4 fixes from the team... done over net commit c5a3788 "Merge branch 'akpm' (patches from Andrew)" Eran's patch needs to go to 4.2 and 4.3 stable kernels. Tariq's patch need to go to 4.3 stable too. Or. Achiad Shochat (1): net/mlx5e: Use the right DMA free funct

[PATCH net 5/6] net/mlx4_core: Fix sleeping while holding spinlock at rem_slave_counters

2015-11-12 Thread Or Gerlitz
From: Eran Ben Elisha When cleaning slave's counter resources, we hold a spinlock that protects the slave's counters list. As part of the clean, we call __mlx4_clear_if_stat which calls mlx4_alloc_cmd_mailbox which is a sleepable function. In order to fix this issue, hold the spinlock, and copy

[PATCH net 4/6] net/mlx5e: Use the right DMA free function on TX path

2015-11-12 Thread Or Gerlitz
From: Achiad Shochat On xmit path we use skb_frag_dma_map() which is using dma_map_page(), while upon completion we dma-unmap the skb fragments using dma_unmap_single() rather than dma_unmap_page(). To fix this, we now save the dma map type on xmit path and use this info to call the right dma un

[PATCH net 6/6] net/mlx4_core: Avoid returning success in case of an error flow

2015-11-12 Thread Or Gerlitz
From: Noa Osherovich The err variable wasn't set with the correct error value in some cases. Fixes: 47605df95398 ('mlx4: Modify proxy/tunnel QP mechanism [..]') Signed-off-by: Noa Osherovich Signed-off-by: Or Gerlitz --- drivers/net/ethernet/mellanox/mlx4/main.c | 8 +--- 1 file changed,

[PATCH net 1/6] net/mlx5e: Fix inline header size calculation

2015-11-12 Thread Or Gerlitz
From: Saeed Mahameed mlx5e_get_inline_hdr_size didn't take into account the vlan insertion into the inline WQE segment. This could lead to max inline violation in cases where skb_headlen(skb) + VLAN_HLEN >= sq->max_inline. Fixes: 3ea4891db8d0 ("net/mlx5e: Fix LSO vlan insertion") Signed-off-by:

[PATCH net 2/6] net/mlx5e: Added self loopback prevention

2015-11-12 Thread Or Gerlitz
From: Tariq Toukan Prevent outgoing multicast frames from looping back to the RX queue. By introducing new HW capability self_lb_en_modifiable, which indicates the support to modify self_lb_en bit in modify_tir command. When this capability is set we can prevent TIRs from sending back loopback

[PATCH net 3/6] net/mlx5e: Max mtu comparison fix

2015-11-12 Thread Or Gerlitz
From: Doron Tsur On change mtu the driver compares between hardware queried mtu and software requested mtu. We need to compare between software representation of the queried mtu and the requested mtu. Fixes: facc9699f0fe ('net/mlx5e: Fix HW MTU settings') Signed-off-by: Doron Tsur Signed-off-by

Re: [PATCH stable <= 3.18] net: add length argument to skb_copy_and_csum_datagram_iovec

2015-11-12 Thread Eric Dumazet
On Thu, 2015-11-12 at 10:48 +0100, Sabrina Dubroca wrote: > 2015-11-10, 16:03:52 -0800, Greg Kroah-Hartman wrote: > > On Tue, Nov 10, 2015 at 05:59:26PM -0600, Josh Hunt wrote: > > > On Thu, Oct 29, 2015 at 5:00 AM, Sabrina Dubroca > > > wrote: > > > > 2015-10-15, 14:25:03 +0200, Sabrina Dubroca

Re: [PATCH] stmmac: avoid ipq806x constant overflow warning

2015-11-12 Thread David Miller
From: Arnd Bergmann Date: Thu, 12 Nov 2015 15:12:48 +0100 > Building dwmac-ipq806x on a 64-bit architecture produces a harmless > warning from gcc: > > stmmac/dwmac-ipq806x.c: In function 'ipq806x_gmac_probe': > include/linux/bitops.h:6:19: warning: overflow in implicit constant > conversion [-

Re: [PATCH v5] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

2015-11-12 Thread Måns Rullgård
Måns Rullgård writes: > Mason writes: > >> [ CCing a few knowledgeable people ] >> >> Despite the subject, this is about an Atheros 8035 PHY :-) >> >> On 12/11/2015 15:04, Måns Rullgård wrote: >> >>> Mason wrote: >>> BTW, you're not using the PHY IRQ, right? I think I remember you saying >

Re: [linux-4.4-mw] BUG: unable to handle kernel paging request ip_vs_out.constprop

2015-11-12 Thread Sander Eikelenboom
On 2015-11-12 17:52, Eric Dumazet wrote: On Thu, 2015-11-12 at 16:16 +0100, Sander Eikelenboom wrote: > Thanks for the report, please try following patch : Hi Eric, Thanks for the patch! Got it up and running at the moment, but since i don't have a clear trigger it will take 1 or 2 days befor

[PATCH net] ipvs: use skb_to_full_sk() helper

2015-11-12 Thread Eric Dumazet
From: Eric Dumazet SYNACK packets might be attached to request sockets. Use skb_to_full_sk() helper to avoid illegal accesses to inet_sk(skb->sk) Fixes: ca6fb0651883 ("tcp: attach SYNACK messages to request sockets instead of listener") Signed-off-by: Eric Dumazet Reported-by: Sander Eikelenb

Re: [PATCH v5] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

2015-11-12 Thread Måns Rullgård
Mason writes: > [ CCing a few knowledgeable people ] > > Despite the subject, this is about an Atheros 8035 PHY :-) > > On 12/11/2015 15:04, Måns Rullgård wrote: > >> Mason wrote: >> >>> BTW, you're not using the PHY IRQ, right? I think I remember you saying >>> it didn't work reliably? >> >> I

Re: [PATCH] bonding: Offloading bonds to hardware

2015-11-12 Thread Andrew Lunn
On Thu, Nov 12, 2015 at 04:02:18PM +, Premkumar Jonnala wrote: > Packet forwarding to/from bond interfaces is done in software. > > This patch enables certain platforms to bridge traffic to/from > bond interfaces in hardware. Notifications are sent out when > the "active" slave set for a bon

Re: Is ndo_do_ioctl still acceptable?

2015-11-12 Thread Jason A. Donenfeld
Hi Stephen, Thanks for your response. On Thu, Nov 12, 2015 at 5:34 PM, Stephen Hemminger wrote: > The problem is ioctl's are device specific, and therefore create dependency > on the unique features supported by your device. > The question always comes up, why is this new API not something gener

Re: [linux-4.4-mw] BUG: unable to handle kernel paging request ip_vs_out.constprop

2015-11-12 Thread Eric Dumazet
On Thu, 2015-11-12 at 16:16 +0100, Sander Eikelenboom wrote: > > Thanks for the report, please try following patch : > > Hi Eric, > > Thanks for the patch! > Got it up and running at the moment, but since i don't have a clear > trigger it > will take 1 or 2 days before i can report something ba

Re: [PATCH] ip_tunnel: disable preemption when updating per-cpu tstats

2015-11-12 Thread Jason A. Donenfeld
By the way, in case anybody is interested, I've done a little bit of historical digging work. The functions in question date back to aa0010f8 from 2012. Before that commit, statistics structures would be incremented after each tunnel's driver itself dereferenced the per-cpu variable. When this got

[PATCH net] tcp: ensure proper barriers in lockless contexts

2015-11-12 Thread Eric Dumazet
From: Eric Dumazet Some functions access TCP sockets without holding a lock and might output non consistent data, depending on compiler and or architecture. tcp_diag_get_info(), tcp_get_info(), tcp_poll(), get_tcp4_sock() ... Introduce sk_state_load() and sk_state_store() to fix the issues, and

Re: kasan r8169 use-after-free trace.

2015-11-12 Thread Dave Jones
On Wed, Nov 11, 2015 at 10:19:28AM +0100, Francois Romieu wrote: > Dave Jones : > > This happens during boot, (and then there's a flood of traces that happen > > so fast > > afterwards it completely overwhelms serial console; not sure if they're the > > same/related or not). > > > > =

Re: [PATCH] ip_tunnel: disable preemption when updating per-cpu tstats

2015-11-12 Thread Jason A. Donenfeld
On Thu, Nov 12, 2015 at 5:25 PM, Hannes Frederic Sowa wrote: > The canonical way is get_cpu_ptr(stats) / put_cpu_ptr. Thanks for the pointer. Fixed in v2. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info

[PATCH v2] ip_tunnel: disable preemption when updating per-cpu tstats

2015-11-12 Thread Jason A. Donenfeld
Drivers like vxlan use the recently introduced udp_tunnel_xmit_skb/udp_tunnel6_xmit_skb APIs. udp_tunnel6_xmit_skb makes use of ip6tunnel_xmit, and ip6tunnel_xmit, after sending the packet, updates the struct stats using the usual u64_stats_update_begin/end calls on this_cpu_ptr(dev->tstats). udp_t

Re: Is ndo_do_ioctl still acceptable?

2015-11-12 Thread Stephen Hemminger
On Thu, 12 Nov 2015 05:59:03 +0100 "Jason A. Donenfeld" wrote: > Hi David & Folks, > > Soon I will submit a virtual tunnel device driver to LKML for review. > It uses rtnl_link_register to create a virtual network interface, > which then handles encryption, authentication, and some other things,

Re: [PATCH] ip_tunnel: disable preemption when updating per-cpu tstats

2015-11-12 Thread Hannes Frederic Sowa
On Thu, Nov 12, 2015, at 16:30, Jason A. Donenfeld wrote: > if (err > 0) { > - struct pcpu_sw_netstats *tstats = this_cpu_ptr(stats); > - > + struct pcpu_sw_netstats *tstats; > + preempt_disable(); > + tstats = this_cpu_ptr(stats); The

Re: PING: [PATCH] net: smsc911x: Reset PHY during initialization

2015-11-12 Thread David Miller
From: Pavel Fedin Date: Thu, 12 Nov 2015 10:04:39 +0300 > Or is it just a formal requirement to RESEND? Yes, this always what I ask people to do. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at htt

Re: [PATCH v5] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

2015-11-12 Thread Mason
[ CCing a few knowledgeable people ] Despite the subject, this is about an Atheros 8035 PHY :-) On 12/11/2015 15:04, Måns Rullgård wrote: > Mason wrote: > >> BTW, you're not using the PHY IRQ, right? I think I remember you saying >> it didn't work reliably? > > It doesn't seem to be wired up o

[PATCH] bonding: Offloading bonds to hardware

2015-11-12 Thread Premkumar Jonnala
Packet forwarding to/from bond interfaces is done in software. This patch enables certain platforms to bridge traffic to/from bond interfaces in hardware. Notifications are sent out when the "active" slave set for a bond interface is updated in software. Platforms use the notifications to prog

[PATCH] ip_tunnel: disable preemption when updating per-cpu tstats

2015-11-12 Thread Jason A. Donenfeld
Drivers like vxlan use the recently introduced udp_tunnel_xmit_skb/udp_tunnel6_xmit_skb APIs. udp_tunnel6_xmit_skb makes use of ip6tunnel_xmit, and ip6tunnel_xmit, after sending the packet, updates the struct stats using the usual u64_stats_update_begin/end calls on this_cpu_ptr(dev->tstats). udp_t

Re: [linux-4.4-mw] BUG: unable to handle kernel paging request ip_vs_out.constprop

2015-11-12 Thread Sander Eikelenboom
On 2015-11-12 15:09, Eric Dumazet wrote: On Thu, 2015-11-12 at 11:08 +0100, Sander Eikelenboom wrote: Hi All, Just got a crash with a linux-4.4-mw kernel. I'm using a routed bridge and apart from the splat below i have got some interesting other messages that aren't there in 4.3 (and perhaps a

Re: [PATCH] vhost: move is_le setup to the backend

2015-11-12 Thread Greg Kurz
On Thu, 12 Nov 2015 15:46:30 +0200 "Michael S. Tsirkin" wrote: > On Fri, Oct 30, 2015 at 12:42:35PM +0100, Greg Kurz wrote: > > The vq->is_le field is used to fix endianness when accessing the vring via > > the cpu_to_vhost16() and vhost16_to_cpu() helpers in the following cases: > > > > 1) host

Re: [PATCH v2 0/6] net: dsa: mv88e6060: cleanup and fix setup

2015-11-12 Thread Neil Armstrong
On 11/10/2015 05:14 PM, Andrew Lunn wrote: > On Tue, Nov 10, 2015 at 04:51:09PM +0100, Neil Armstrong wrote: >> This patchset introduces some fixes and a registers addressing cleanup for >> the mv88e6060 DSA driver. > > Hi Neil > > It is normal for netdev to put into the email subject of patches

[PATCH] stmmac: avoid ipq806x constant overflow warning

2015-11-12 Thread Arnd Bergmann
Building dwmac-ipq806x on a 64-bit architecture produces a harmless warning from gcc: stmmac/dwmac-ipq806x.c: In function 'ipq806x_gmac_probe': include/linux/bitops.h:6:19: warning: overflow in implicit constant conversion [-Woverflow] val = QSGMII_PHY_CDR_EN | stmmac/dwmac-ipq806x.c:333:8: not

Re: [linux-4.4-mw] BUG: unable to handle kernel paging request ip_vs_out.constprop

2015-11-12 Thread Eric Dumazet
On Thu, 2015-11-12 at 11:08 +0100, Sander Eikelenboom wrote: > Hi All, > > Just got a crash with a linux-4.4-mw kernel. > I'm using a routed bridge and apart from the splat below i have got some > interesting other messages that aren't there in 4.3 (and perhaps are of > interest for the crash as

Re: [PATCH v5] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

2015-11-12 Thread Måns Rullgård
Mason writes: > On 10/11/2015 20:25, Måns Rullgård wrote: > >> Mason writes: >> >>> On 10/11/2015 17:14, Mans Rullgard wrote: >>> This adds a driver for the Aurora VLSI NB8800 Ethernet controller. It is an almost complete rewrite of a driver originally found in a Sigma Designs 2.6

Re: Fw: [Bug 107141] New: [1177853.192071] INFO: task accel-pppd:24263 blocked for more than 120 seconds.

2015-11-12 Thread Guillaume Nault
On Wed, Nov 11, 2015 at 08:57:15AM -0800, Stephen Hemminger wrote: > > > Begin forwarded message: > > Date: Wed, 4 Nov 2015 10:46:56 + > From: "bugzilla-dae...@bugzilla.kernel.org" > > To: "shemmin...@linux-foundation.org" > Subject: [Bug 107141] New: [1177853.192071] INFO: task accel-ppp

Re: [PATCH] vhost: move is_le setup to the backend

2015-11-12 Thread Michael S. Tsirkin
On Fri, Oct 30, 2015 at 12:42:35PM +0100, Greg Kurz wrote: > The vq->is_le field is used to fix endianness when accessing the vring via > the cpu_to_vhost16() and vhost16_to_cpu() helpers in the following cases: > > 1) host is big endian and device is modern virtio > > 2) host has cross-endian su

Re: [PATCH v5] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

2015-11-12 Thread Mason
On 10/11/2015 20:25, Måns Rullgård wrote: > Mason writes: > >> On 10/11/2015 17:14, Mans Rullgard wrote: >> >>> This adds a driver for the Aurora VLSI NB8800 Ethernet controller. >>> It is an almost complete rewrite of a driver originally found in >>> a Sigma Designs 2.6.22 tree. >>> >>> Signed-o

Re: [PATCH net] sctp: translate host order to network order when setting a hmacid

2015-11-12 Thread Neil Horman
On Thu, Nov 12, 2015 at 01:07:07PM +0800, Xin Long wrote: > now sctp auth cannot work well when setting a hmacid manually, which > is caused by that we didn't use the network order for hmacid, so fix > it by adding the transformation in sctp_auth_ep_set_hmacs. > > even we set hmacid with the netwo

Re: [PATCH] vhost: move is_le setup to the backend

2015-11-12 Thread Cornelia Huck
On Fri, 30 Oct 2015 12:42:35 +0100 Greg Kurz wrote: > The vq->is_le field is used to fix endianness when accessing the vring via > the cpu_to_vhost16() and vhost16_to_cpu() helpers in the following cases: > > 1) host is big endian and device is modern virtio > > 2) host has cross-endian support

Re: [Intel-wired-lan] regression in ixgbe SFP detection patch

2015-11-12 Thread William Dauchy
On Nov11 22:13, Rustad, Mark D wrote: > Just so you know, there are patches in queue that will improve this situation > in two ways: > 1) When the I2C probe times out, the code assumes that the cage is empty and > does not retry the access until the next probe. > 2) The driver will use its own pr

Re: [PATCH net-next RFC V3 0/3] basic busy polling support for vhost_net

2015-11-12 Thread Felipe Franciosi
Hi Jason, I understand your busy loop timeout is quite conservative at 50us. Did you try any other values? Also, did you measure how polling affects many VMs talking to each other (e.g. 20 VMs on each host, perhaps with several vNICs each, transmitting to a corresponding VM/vNIC pair on anothe

[PATCH] net: thunder: Fix crash upon shutdown after failed probe

2015-11-12 Thread Pavel Fedin
If device probe fails, driver remains bound to the PCI device. However, driver data has been reset to NULL. This causes crash upon dereferencing it in nicvf_remove() Signed-off-by: Pavel Fedin --- drivers/net/ethernet/cavium/thunder/nicvf_main.c | 3 +++ 1 file changed, 3 insertions(+) diff --g

Re: [PATCH net] sctp: translate host order to network order when setting a hmacid

2015-11-12 Thread marcelo . leitner
On Thu, Nov 12, 2015 at 01:07:07PM +0800, Xin Long wrote: > now sctp auth cannot work well when setting a hmacid manually, which > is caused by that we didn't use the network order for hmacid, so fix > it by adding the transformation in sctp_auth_ep_set_hmacs. > > even we set hmacid with the netwo

Re: [PATCH net-next RFC V3 0/3] basic busy polling support for vhost_net

2015-11-12 Thread Jason Wang
On 11/12/2015 06:16 PM, Jason Wang wrote: > Hi all: > > This series tries to add basic busy polling for vhost net. The idea is > simple: at the end of tx/rx processing, busy polling for new tx added > descriptor and rx receive socket for a while. The maximum number of > time (in us) could be spen

  1   2   >